On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote: > On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote: > ^^^^^^^^^^ > Looks like your clock is _way_ off. > > > + if (!pci->compat) { > > + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */ > > + } > > > static Property serial_pci_properties[] = { > > DEFINE_PROP_CHR("chardev", PCISerialState, state.chr), > > + DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0), > > DEFINE_PROP_END_OF_LIST(), > > }; > > > + {\ > > + .driver = "pci-serial",\ > > + .property = "compat",\ > > + .value = stringify(1),\ > > + },\ > > Reviewed-by: Gerd Hoffmann <kra...@redhat.com> > > mst, do you take that through the pci tree? > > cheers, > Gerd >
Yes but I'd like the property renamed. Agree?