Re: [Qemu-devel] [PATCH] Fix 'name' option to work with -readconfig

2014-05-14 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > The 'name' option silently failed when used in config files >> > ( http://lists.gnu.org/archive/html/qemu-devel/2014-04/m

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Markus Armbruster
"Richard W.M. Jones" writes: > On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: >> libssh2_session_last_error() already returns the error code. >> >> Cc: "Richard W.M. Jones" >> Signed-off-by: Markus Armbruster >> --- >> block/ssh.c | 9 - >> 1 file changed, 4 insert

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Paolo Bonzini
Il 14/05/2014 12:59, BALATON Zoltan ha scritto: On Wed, 14 May 2014, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 01:39:03AM +0200, BALATON Zoltan wrote: On Thu, 8 May 2014, Michael Tokarev wrote: 27.02.2014 05:05, BALATON Zoltan wrote: Shoudl we actually make it machine-specific, to kee

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 12:59:15PM +0200, BALATON Zoltan wrote: > On Wed, 14 May 2014, Michael S. Tsirkin wrote: > >On Wed, May 14, 2014 at 01:39:03AM +0200, BALATON Zoltan wrote: > >>On Thu, 8 May 2014, Michael Tokarev wrote: > >>>27.02.2014 05:05, BALATON Zoltan wrote: > >>> > >>>Shoudl we actual

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-14 Thread BALATON Zoltan
On Wed, 14 May 2014, Mark Cave-Ayland wrote: On 14/05/14 00:02, BALATON Zoltan wrote: command 0x43 is read the TOC which according to atapi_cmd_table should call cmd_read_toc_pma_atip(). You can see that in your MorphOS case you are getting a line with a "atapi_cmd_error" prefix which indicates

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: >>> Fam Zheng writes: >>> >>> > On Tue, 05/13 10:46, Markus Armbruster wrote: >>> >> The shell script attempts to suppress core dumps like this: >>> >> >>> >> old_ulimit=$(ulimit

Re: [Qemu-devel] Where is vga-rom mapped in guest system memory?

2014-05-14 Thread Jaeyong Yoo
> -Original Message- > From: qemu-devel-bounces+jaeyong.yoo=samsung@nongnu.org [mailto:qemu- > devel-bounces+jaeyong.yoo=samsung@nongnu.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, May 14, 2014 7:56 PM > To: Jaeyong Yoo; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] Where

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

2014-05-14 Thread Kevin Wolf
Am 08.05.2014 um 18:22 hat Peter Lieven geschrieben: > this patch tries to optimize zero write requests > by automatically using bdrv_write_zeroes if it is > supported by the format. > > This significantly speeds up file system initialization and > should speed zero write test used to test backend

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 13:16 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: > >>> Fam Zheng writes: > >>> > >>> > On Tue, 05/13 10:46, Markus Armbruster wrote: > >>> >> The shell script attemp

Re: [Qemu-devel] Where is vga-rom mapped in guest system memory?

2014-05-14 Thread Laszlo Ersek
On 05/14/14 13:41, Jaeyong Yoo wrote: > I built the seabios in qemu and try to see the debug message of seabios. > So, I checked the "Serial port debugging" option in Debugging section with > the > serial port base address 0x3f8. (Is this the correct value?) > And, launch qemu with option "-seri

Re: [Qemu-devel] [PATCH 2/2] block: add test for vhdx image created by Disk2VHD

2014-05-14 Thread Jeff Cody
On Wed, May 14, 2014 at 09:58:07AM +0800, Fam Zheng wrote: > On Tue, 05/13 10:00, Jeff Cody wrote: > > This adds a test for VHDX images created by Microsoft's tool, Disk2VHD. > > Out of curiosity, is this an official tool from Microsoft? > Yes, it is a p2v tool from MS for Virtual PC / Hyper-V h

[Qemu-devel] [PATCH] qemu-iotests: Fix blkdebug in VM drive in 030

2014-05-14 Thread Fam Zheng
The test test_stream_pause in this class uses vm.pause_drive, which requires a blkdebug driver on top of image, otherwise it's no-op and the test running is undeterministic. So add it. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-14 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > If you implement this in the net layer then that problem is easy to resolve > > since > > we can flush all queues when the guest resumes to get packets flowing again. > > > Do you mean we should also listen for VM runstate changes

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Markus Armbruster
Max Reitz writes: > Currently, QEMU's iotests rely on /usr/bin/env to start the correct > Python (that is, at least Python 2.4, but not 3). On systems where > Python 3 is the default, the user has no clean way of making the iotests > use the correct binary. > > This commit makes the iotests use t

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Stefan Hajnoczi
On Tue, May 13, 2014 at 11:40:47AM -0400, Mike Day wrote: > On Tue, May 13, 2014 at 10:18 AM, Cornelia Huck > wrote: > > > > qemu-img.o: In function `add_format_to_seq': > > /home/cohuck/git/qemu/qemu-img.c:73: undefined reference to > > `g_sequence_lookup' > > collect2: ld returned 1 exit status

Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible

2014-05-14 Thread Stefan Hajnoczi
On Mon, May 12, 2014 at 10:07:07AM -0600, Eric Blake wrote: > On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote: > > From: Peter Krempa > > > > The docs for glfs_init suggest that the function sets errno on every > > failure. In fact it doesn't. As other functions such as > > qemu_gluster_open() in t

Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-14 Thread Stefan Hajnoczi
On Sun, May 11, 2014 at 12:35:57AM +0800, Jun Li wrote: > From: Jun Li > > This patch fixed the following bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1084302 . > > path_combine can not calculate the correct full path name for backing_file. > Such as: > create a snapshot chain: > sn2->sn1-

Re: [Qemu-devel] [PATCH 2/2] nbd: Miscellaneous typo fixes.

2014-05-14 Thread Stefan Hajnoczi
On Tue, May 13, 2014 at 12:35:16AM +0100, Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles > --- > nbd.c | 2 +- > qemu-nbd.c| 2 +- > qemu-nbd.texi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-14 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote: > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > > If you implement this in the net layer then that problem is easy to > > > resolve since > > > we can flush all queues when the guest resumes to get packets flowin

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Richard W.M. Jones
On Wed, May 14, 2014 at 01:06:21PM +0200, Markus Armbruster wrote: > "Richard W.M. Jones" writes: > > > On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: > >> libssh2_session_last_error() already returns the error code. > >> > >> Cc: "Richard W.M. Jones" > >> Signed-off-by: Mar

Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible

2014-05-14 Thread Peter Krempa
On 05/14/14 14:36, Stefan Hajnoczi wrote: > On Mon, May 12, 2014 at 10:07:07AM -0600, Eric Blake wrote: >> On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote: >>> From: Peter Krempa >>> >>> The docs for glfs_init suggest that the function sets errno on every >>> failure. In fact it doesn't. As other fu

Re: [Qemu-devel] Undefined error for curl_multi_socket_action

2014-05-14 Thread Stefan Hajnoczi
On Tue, May 13, 2014 at 03:21:17PM +0530, Gaurav Sharma wrote: > After rebasing my code with the master branch, i have started getting error > for this method "curl_multi_socket_action". > In the file blocl/curl.c I can see function call for this method without > NEED_CURL_TIMER_CALLBACK directive

Re: [Qemu-devel] Undefined error for curl_multi_socket_action

2014-05-14 Thread Stefan Hajnoczi
On Tue, May 13, 2014 at 03:21:17PM +0530, Gaurav Sharma wrote: > After rebasing my code with the master branch, i have started getting error > for this method "curl_multi_socket_action". > In the file blocl/curl.c I can see function call for this method without > NEED_CURL_TIMER_CALLBACK directive

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Eric Blake
On 05/14/2014 01:48 AM, Kevin Wolf wrote: > Anyway, let's not add new options encoded in the URL, but point users to > separate options. We may decide that we need the support the old crude > way of encoding local options for compatibility, but preferably I would > make filename just a plain URL.

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Stefan Hajnoczi
On Wed, May 14, 2014 at 04:09:14PM +0800, Fam Zheng wrote: > On Wed, 05/14 09:50, Kevin Wolf wrote: > > Am 13.05.2014 um 18:07 hat Mike Day geschrieben: > > > The help message for qemu-img lists the supported block formats, of > > > which there are 27 as of version 2.0.50. The formats are printed i

Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-14 Thread Fam Zheng
On Wed, 05/14 14:40, Stefan Hajnoczi wrote: > On Sun, May 11, 2014 at 12:35:57AM +0800, Jun Li wrote: > > From: Jun Li > > > > This patch fixed the following bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=1084302 . > > > > path_combine can not calculate the correct full path name for backi

Re: [Qemu-devel] [PATCH v2 10/23] target-arm: implement CPACR register logic

2014-05-14 Thread Peter Crosthwaite
On Tue, May 13, 2014 at 4:15 PM, Fabian Aggeler wrote: > From: Sergey Fedorov > > CPACR register allows to control access rights to coprocessor 0-13 > interfaces. Bits corresponding to unimplemented coprocessors should be > RAZ/WI. QEMU implements only VFP coprocessor on ARMv6+ targets. So only >

[Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Markus Armbruster
The shell script attempts to suppress core dumps like this: old_ulimit=$(ulimit -c) ulimit -c 0 $QEMU_IO arg... ulimit -c "$old_ulimit" This breaks the test hard unless the limit was zero to begin with! ulimit sets both hard and soft limit by default, and (re-)raising the hard lim

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

2014-05-14 Thread Eric Blake
On 05/13/2014 06:06 AM, Peter Lieven wrote: >>> - changed the parse function in blockdev_init to >>>be generic usable for other enum parameters >> If you wouldn't mind, I think the generic function is useful enough that >> people might want to backport it independently from th

Re: [Qemu-devel] [PATCH net v1 0/4] Cadence GEM patches

2014-05-14 Thread Peter Crosthwaite
Ping! On Wed, May 7, 2014 at 9:15 AM, Peter Crosthwaite wrote: > > Hi Stefan, Peter, > > Found a bug in the Cadence GEM. Fixed in P1. Have some follow us trivials > as well (P2-4). > > Regards, > Peter > > > Peter Crosthwaite (4): > net: cadence_gem: Fix Tx descriptor update > net: cadence_ge

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

2014-05-14 Thread Michael S. Tsirkin
On Mon, May 12, 2014 at 03:16:07PM +0300, Michael S. Tsirkin wrote: > Correct post load checks: > 1. dev->setup_len == sizeof(dev->data_buf) > seems fine, no need to fail migration > 2. When state is DATA, passing index > len >will cause memcpy with negative length, >resulting in heap o

Re: [Qemu-devel] [PATCH v2] usb: fix up post load checks

2014-05-14 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > Correct post load checks: > 1. dev->setup_len == sizeof(dev->data_buf) > seems fine, no need to fail migration > 2. When state is DATA, passing index > len >will cause memcpy with negative length, >resulting in heap overflow > > First of the issues was rep

Re: [Qemu-devel] [RFC 0/5] virtio: use alias properties in transport devices

2014-05-14 Thread Stefan Hajnoczi
On Wed, Mar 19, 2014 at 4:48 PM, Stefan Hajnoczi wrote: > This RFC is just the beginning. The same problem exists for virtio-net and > other devices. I am looking for feedback before I convert all of virtio. > > The virtio transport/device split is broken as follows: > > 1. The virtio-blk device

Re: [Qemu-devel] [PATCH v3 0/3] SMBIOS cleanup round

2014-05-14 Thread Laszlo Ersek
On 05/13/14 23:16, Gabriel L. Somlo wrote: > Changelog: > > v3: > - endian-ness fix (1/3) now correctly handles cpuid version and features > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) > - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :) > > v2: > -

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > thought part of your intention was to address the duplicates with your > patch. > > We can back out the sequence API if it's not supported on older glib but > it wou

Re: [Qemu-devel] [RFC 1/5] qdev: add child alias properties

2014-05-14 Thread Andreas Färber
Am 19.03.2014 16:48, schrieb Stefan Hajnoczi: > Child alias properties allow a parent object to expose child object > properties. This makes it possible for a parent object to forward all > or a subset of a child's properties. > > Currently we achieve similar behavior by duplicating property > de

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Fam Zheng
On Wed, 05/14 15:12, Markus Armbruster wrote: > The shell script attempts to suppress core dumps like this: > > old_ulimit=$(ulimit -c) > ulimit -c 0 > $QEMU_IO arg... > ulimit -c "$old_ulimit" > > This breaks the test hard unless the limit was zero to begin with! > ulimit sets bo

Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-05-14 Thread Michael S. Tsirkin
On Mon, May 12, 2014 at 11:51:35PM +0800, Jun Li wrote: > > On 05/11/2014 05:17 PM, Marcel Apfelbaum wrote: > >On Sun, 2014-05-11 at 11:07 +0800, lijun wrote: > >>On 04/22/2014 05:21 PM, Marcel Apfelbaum wrote: > >>>On Wed, 2014-04-16 at 22:20 +0800, Jun Li wrote: > Add remove_boot_device_path

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 9:02 AM, Stefan Hajnoczi wrote: > Yes, we cannot change the git commit history once a commit is in the > public qemu.git repository. The only options are to: > > 1. Add a patch on top that fixes the issue. > 2. Use git-revert(1) to undo your commit entirely (this adds a ne

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Fam Zheng
On Wed, 05/14 09:27, Mike Day wrote: > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > thought part of your intention was to address the duplicates with your > > patch. > > > > We can back out the sequence API

Re: [Qemu-devel] [RFC 1/5] qdev: add child alias properties

2014-05-14 Thread Paolo Bonzini
Il 14/05/2014 15:27, Andreas Färber ha scritto: > +PropertyInfo qdev_prop_child_alias = { > +.name = "ChildAlias", Won't this turn into the QMP-exposed type of the property? That would be wrong then, requiring per-type alias property types. They could be macro-automated of course, if we nee

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Jeff Cody
On Wed, May 14, 2014 at 09:27:31AM -0400, Mike Day wrote: > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > thought part of your intention was to address the duplicates with your > > patch. > > > > We can back

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Jeff Cody
On Wed, May 14, 2014 at 09:40:00PM +0800, Fam Zheng wrote: > On Wed, 05/14 09:27, Mike Day wrote: > > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > > thought part of your intention was to address the dupli

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-14 Thread Greg Bellows
Hi Fabian, I too had been updating the core TZ patches provided by Samsung. From looking at your changes I see a lot of similarities in our code with the exception being the mechanism for banked register support. The difference being that your approach is a bit more explicit in the declaration o

Re: [Qemu-devel] [PATCH v19 01/16] vmdk: Optimize cluster allocation

2014-05-14 Thread Fam Zheng
This patch is included by mistake, there should already be a seperate patch on the list. Please ignore this one. Fam

Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 9:43 AM, Jeff Cody wrote: > Prior to a recent commit, this function did not make distinction on > duplicates. As of commit e855e4fb7, duplicates are not longer printed > in the help message: > > e855e4fb7: Ignore duplicate or NULL format_name in bdrv_iterate_format): > Th

Re: [Qemu-devel] [PATCH V2] qapi: Let redundant includes be skipped excepted the first occurrence.

2014-05-14 Thread Benoît Canet
The Monday 12 May 2014 à 11:11:41 (-0600), Eric Blake wrote : > On 05/09/2014 09:48 AM, Benoît Canet wrote: > > Subject line has problems. 'excepted' is not a word, and you are already > asked to avoid trailing '.'. I suggest a much simpler: > > qapi: skip redundant includes > > > The purpose o

Re: [Qemu-devel] [RFC 2/5] virtio: add child alias properties for virtio-blk

2014-05-14 Thread Peter Crosthwaite
On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: > Now that qdev child alias properties exist, define aliases for > virtio-blk properties. The aliases will replace the duplicated > properties that current live in virtio-blk-pci, virtio-blk-ccw, and > friends. > > Signed-off-by: Stefan Hajn

[Qemu-devel] [PATCH v3] qapi: skip redundant includes

2014-05-14 Thread Benoît Canet
The purpose of this change is to help create a json file containing common definitions; each bit of generated C code must be emitted only one time. A second history global to all QAPISchema instances has been added to detect when a file is included more than one time and skip these includes. It do

[Qemu-devel] [PATCH v3] Let the C generated bits of QAPI be generated only once when identical includes are done

2014-05-14 Thread Benoît Canet
in V3: change commit title [Eric] s/spitted/emitted/ change tests names [Eric] Benoît Canet (1): qapi: skip redundant includes scripts/qapi.py | 14 +++--- tests/Makefile| 3 ++- tests/qapi-schema/in

Re: [Qemu-devel] [RFC 1/5] qdev: add child alias properties

2014-05-14 Thread Peter Crosthwaite
On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: > Child alias properties allow a parent object to expose child object > properties. This makes it possible for a parent object to forward all > or a subset of a child's properties. > So this sounds useful to my MemoryRegion and GPIO QOMific

Re: [Qemu-devel] [RFC 1/5] qdev: add child alias properties

2014-05-14 Thread Andreas Färber
Am 14.05.2014 16:13, schrieb Peter Crosthwaite: > On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: >> Child alias properties allow a parent object to expose child object >> properties. This makes it possible for a parent object to forward all >> or a subset of a child's properties. >> > >

Re: [Qemu-devel] [PATCH v2 02/23] target-arm: move SCR into Security Extensions register list

2014-05-14 Thread Greg Bellows
On 13 May 2014 11:15, Fabian Aggeler wrote: > From: Sergey Fedorov > > Define a new ARM CP register info list for the Security Extension feature. > Register that list only for ARM cores with Security Extension support. > Moving SCR into Security Extension register group. > > Signed-off-by: Serge

[Qemu-devel] [PATCH 2/3] throttle: add detach/attach test case

2014-05-14 Thread Stefan Hajnoczi
Add a test case that checks the timer is really removed/added by the detach/attach functions. Cc: Benoît Canet Signed-off-by: Stefan Hajnoczi --- tests/test-throttle.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/test-throttle.c b/tests/test-throttle.c ind

[Qemu-devel] [PATCH 1/3] throttle: add throttle_detach/attach_aio_context()

2014-05-14 Thread Stefan Hajnoczi
Block I/O throttling uses timers and currently always adds them to the main loop. Throttling will break if bdrv_set_aio_context() is used to move a BlockDriverState to a different AioContext. This patch adds throttle_detach/attach_aio_context() interfaces so the throttling timers and uses them to

[Qemu-devel] [PATCH 0/3] throttle: use AioContext for dataplane support

2014-05-14 Thread Stefan Hajnoczi
This series applies on top of my "dataplane: use QEMU block layer" series. Now that the dataplane code path is using the QEMU block layer we should make I/O throttling limits safe to use. When the block_set_io_throttle monitor command is executed, the BlockDriverState's AioContext must be acquire

[Qemu-devel] [PATCH 3/3] blockdev: acquire AioContext in block_set_io_throttle

2014-05-14 Thread Stefan Hajnoczi
The block_set_io_throttle QMP and HMP commands modify I/O throttling limits for block devices. Acquire the BlockDriverState's AioContext to protect against race conditions with an IOThread that is running I/O for this device. Cc: Benoît Canet Signed-off-by: Stefan Hajnoczi --- blockdev.c | 6 +

Re: [Qemu-devel] [RFC 1/5] qdev: add child alias properties

2014-05-14 Thread Peter Crosthwaite
On Wed, May 14, 2014 at 2:17 PM, Andreas Färber wrote: > Am 14.05.2014 16:13, schrieb Peter Crosthwaite: >> On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: >>> Child alias properties allow a parent object to expose child object >>> properties. This makes it possible for a parent object t

[Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

2014-05-14 Thread Peter Maydell
Before we write common.env to the tests/qemu-iotests directory, ensure that it exists. This fixes out-of-tree builds from clean. Signed-off-by: Peter Maydell --- If somebody would like to review this I'll apply it to master as a buildfix... configure | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben: > On Wed, 05/14 15:12, Markus Armbruster wrote: > > The shell script attempts to suppress core dumps like this: > > > > old_ulimit=$(ulimit -c) > > ulimit -c 0 > > $QEMU_IO arg... > > ulimit -c "$old_ulimit" > > > > This breaks the

Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 16:26 hat Peter Maydell geschrieben: > Before we write common.env to the tests/qemu-iotests directory, ensure > that it exists. This fixes out-of-tree builds from clean. > > Signed-off-by: Peter Maydell > --- > If somebody would like to review this I'll apply it to master as > a

Re: [Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-14 Thread Kevin Wolf
Am 08.05.2014 um 07:57 hat Fam Zheng geschrieben: > This drops the unnecessary bdrv_truncate() from, and also improves, > cluster allocation code path. > [...] > > Tested that this passes qemu-iotests for all VMDK subformats. > > Signed-off-by: Fam Zheng Unfortunately, this is seriously broken

Re: [Qemu-devel] [RFC 2/5] virtio: add child alias properties for virtio-blk

2014-05-14 Thread Stefan Hajnoczi
On Wed, May 14, 2014 at 02:04:25PM +, Peter Crosthwaite wrote: > On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: > > Now that qdev child alias properties exist, define aliases for > > virtio-blk properties. The aliases will replace the duplicated > > properties that current live in vi

Re: [Qemu-devel] [RFC 2/5] virtio: add child alias properties for virtio-blk

2014-05-14 Thread Peter Crosthwaite
On Wed, May 14, 2014 at 2:33 PM, Stefan Hajnoczi wrote: > On Wed, May 14, 2014 at 02:04:25PM +, Peter Crosthwaite wrote: >> On Wed, Mar 19, 2014 at 3:48 PM, Stefan Hajnoczi wrote: >> > Now that qdev child alias properties exist, define aliases for >> > virtio-blk properties. The aliases will

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
On 14 May 2014 00:53, Sergey Fedorov wrote: > On 13.05.2014 20:15, Fabian Aggeler wrote: > > arm_is_secure() function allows to determine CPU security state > > if the CPU implements Security Extensions. > > > > Signed-off-by: Sergey Fedorov > > Signed-off-by: Fabian Aggeler > > --- > > target

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix blkdebug in VM drive in 030

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 14:30 hat Fam Zheng geschrieben: > The test test_stream_pause in this class uses vm.pause_drive, which > requires a blkdebug driver on top of image, otherwise it's no-op and the > test running is undeterministic. > > So add it. > > Signed-off-by: Fam Zheng Thanks, applied to th

Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

2014-05-14 Thread Peter Maydell
On 14 May 2014 15:32, Kevin Wolf wrote: > Am 14.05.2014 um 16:26 hat Peter Maydell geschrieben: >> Before we write common.env to the tests/qemu-iotests directory, ensure >> that it exists. This fixes out-of-tree builds from clean. >> >> Signed-off-by: Peter Maydell >> --- >> If somebody would lik

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Markus Armbruster
"Richard W.M. Jones" writes: > On Wed, May 14, 2014 at 01:06:21PM +0200, Markus Armbruster wrote: >> "Richard W.M. Jones" writes: >> >> > On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: >> >> libssh2_session_last_error() already returns the error code. >> >> >> >> Cc: "Richa

Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 16:46 hat Peter Maydell geschrieben: > On 14 May 2014 15:32, Kevin Wolf wrote: > > Am 14.05.2014 um 16:26 hat Peter Maydell geschrieben: > >> Before we write common.env to the tests/qemu-iotests directory, ensure > >> that it exists. This fixes out-of-tree builds from clean. > >>

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-14 Thread Edgar E. Iglesias
On Wed, May 14, 2014 at 08:58:09AM +, Aggeler Fabian wrote: > I see. What is Greg Bellows working on exactly? Also peripherals like TZASC, > TZPC,...? My plan is to focus on them now if no one else is working on them. > What do you suggest to minimize overlap? Hi, With regards to my patche

Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:39PM +0200, Markus Armbruster wrote: > libssh2_session_last_error() already returns the error code. > > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 9 - > 1 file changed, 4 insertions(+), 5

Re: [Qemu-devel] [PATCH 06/18] block/ssh: Propagate errors through check_host_key()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:40PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 68 > - > 1 file changed, 49 insertions(+), 19 deletion

Re: [Qemu-devel] [PATCH 07/18] block/ssh: Propagate errors through authenticate()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:41PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 23 ++- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/block/ssh.c b/block

Re: [Qemu-devel] [PATCH 09/18] block/ssh: Propagate errors to open and create methods

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:43PM +0200, Markus Armbruster wrote: > Completes the conversion to Error started in commit 015a103^..d5124c0. > > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 47 ++---

Re: [Qemu-devel] [PATCH 08/18] block/ssh: Propagate errors through connect_to_ssh()

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:02:42PM +0200, Markus Armbruster wrote: > Cc: "Richard W.M. Jones" > Signed-off-by: Markus Armbruster Reviewed-by: Richard W.M. Jones > block/ssh.c | 34 +- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/block/s

Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes

2014-05-14 Thread Eric Blake
On 05/14/2014 08:07 AM, Benoît Canet wrote: > The purpose of this change is to help create a json file containing > common definitions; each bit of generated C code must be emitted > only one time. > > A second history global to all QAPISchema instances has been added > to detect when a file is in

Re: [Qemu-devel] [PATCH 1/3] throttle: add throttle_detach/attach_aio_context()

2014-05-14 Thread Benoît Canet
The Wednesday 14 May 2014 à 16:22:45 (+0200), Stefan Hajnoczi wrote : > Block I/O throttling uses timers and currently always adds them to the > main loop. Throttling will break if bdrv_set_aio_context() is used to > move a BlockDriverState to a different AioContext. > > This patch adds throttle_

Re: [Qemu-devel] [PATCH 2/3] throttle: add detach/attach test case

2014-05-14 Thread Benoît Canet
The Wednesday 14 May 2014 à 16:22:46 (+0200), Stefan Hajnoczi wrote : > Add a test case that checks the timer is really removed/added by the > detach/attach functions. > > Cc: Benoît Canet > Signed-off-by: Stefan Hajnoczi > --- > tests/test-throttle.c | 24 > 1 file cha

Re: [Qemu-devel] [PATCH 0/3] throttle: use AioContext for dataplane support

2014-05-14 Thread Benoît Canet
The Wednesday 14 May 2014 à 16:22:44 (+0200), Stefan Hajnoczi wrote : > This series applies on top of my "dataplane: use QEMU block layer" series. > > Now that the dataplane code path is using the QEMU block layer we should make > I/O throttling limits safe to use. When the block_set_io_throttle

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-14 Thread Kevin Wolf
Am 12.05.2014 um 22:27 hat Mike Day geschrieben: > When deleting the last snapshot, copying the resulting snapshot table > currently fails, causing the delete operation to also fail. Fix the > failure by skipping the copy and just writing the snapshot header and > freeing the extra clusters. Do yo

Re: [Qemu-devel] [RFC PATCH V5 1/8] update-linux-headers.sh: Add psci.h to linux header sync-up script

2014-05-14 Thread Peter Maydell
On 12 May 2014 13:37, Pranavkumar Sawargaonkar wrote: > We will be using linux/psci.h for KVM ARM/ARM64 hence add it to > linux header sync-up script. > > Signed-off-by: Pranavkumar Sawargaonkar > Signed-off-by: Anup Patel > --- > scripts/update-linux-headers.sh |2 +- > 1 file changed, 1 i

Re: [Qemu-devel] [RFC PATCH V5 3/8] kvm: Handle exit reason KVM_EXIT_SYSTEM_EVENT

2014-05-14 Thread Peter Maydell
On 12 May 2014 13:37, Pranavkumar Sawargaonkar wrote: > In-kernel PSCI v0.2 emulation of KVM ARM/ARM64 forwards SYSTEM_OFF > and SYSTEM_RESET function calls to QEMU using KVM_EXIT_SYSTEM_EVENT > exit reason. > > This patch updates kvm_cpu_exec() to handle KVM_SYSTEM_EVENT_SHUTDOWN > and KVM_SYSTEM

Re: [Qemu-devel] [PATCH 3/3] blockdev: acquire AioContext in block_set_io_throttle

2014-05-14 Thread Benoît Canet
The Wednesday 14 May 2014 à 16:22:47 (+0200), Stefan Hajnoczi wrote :G > The block_set_io_throttle QMP and HMP commands modify I/O throttling > limits for block devices. > > Acquire the BlockDriverState's AioContext to protect against race > conditions with an IOThread that is running I/O for this

[Qemu-devel] [PATCH] qapi: Show qapi-commands.py invocation in qapi-code-gen.txt

2014-05-14 Thread Markus Armbruster
While there, pare down the shell prompts. Signed-off-by: Markus Armbruster --- Note: to be applied on top of "[PATCH v2 00/12] qapi: Purge error_is_set()". docs/qapi-code-gen.txt | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/docs/qapi-code-gen

Re: [Qemu-devel] [RFC PATCH V5 5/8] target-arm: Common kvm_arm_vcpu_init() for KVM ARM and KVM ARM64

2014-05-14 Thread Peter Maydell
On 12 May 2014 13:37, Pranavkumar Sawargaonkar wrote: > Introduce a common kvm_arm_vcpu_init() for doing KVM_ARM_VCPU_INIT > ioctl in KVM ARM and KVM ARM64. This also helps us factor-out few > common code lines from kvm_arch_init_vcpu() for KVM ARM/ARM64. Mostly OK, some minor tweaks below. > Si

[Qemu-devel] vnc or spice which one is better

2014-05-14 Thread Kekane, Abhishek
Hi All, Just wondering which graphics device is better between vnc and spice in terms of features and performance? Thanks, Abhishek Kekane __ Disclaimer:This email and any attachments are sent in strictest confidence for the

[Qemu-devel] [PATCH RFC 0/8] virtio: migrate new properties

2014-05-14 Thread Greg Kurz
The work on virtio endianness unveiled the need to add new properties to VirtIODevice and be able to migrate without breaking compatibility. There was a similar concern with the introduction of a VirtIODevice.broken property. This patch set is a tentative to address the issue, following a suggesti

[Qemu-devel] [PATCH RFC 2/8] virtio-net: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/net/virtio-net.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index fd23c46..4004d02 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -1300,6 +1300,8 @@ static void virtio_net_save(QEMUFile *f,

[Qemu-devel] [PATCH RFC 6/8] virtio-balloon: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/virtio/virtio-balloon.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index a470a0b..41f7ae1 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -316,6 +316,

[Qemu-devel] [PATCH RFC 7/8] virtio-rng: migrate subsections

2014-05-14 Thread Greg Kurz
While we are here, we also check virtio_load() return value. Signed-off-by: Greg Kurz --- hw/virtio/virtio-rng.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index b6ab361..0371103 100644 --- a/hw/virtio/virti

[Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
There is a need to add some more fields to VirtIODevice that should be migrated (broken status, endianness). The problem is that we do not want to break compatibility while adding a new feature... This issue has been addressed in the generic VMState code with the use of optional subsections. As a *

[Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-14 Thread Greg Kurz
Some CPU families can dynamically change their endianness. This means we can have little endian ppc or big endian arm guests for example. This has an impact on legacy virtio data structures since they are target endian. We hence introduce a new property to track the endianness of each virtio device

[Qemu-devel] [PATCH RFC 3/8] virtio-blk: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/block/virtio-blk.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 8a568e5..5a0d224 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -600,6 +600,8 @@ static void virtio_b

[Qemu-devel] [PATCH RFC 4/8] virtio-scsi: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/scsi/virtio-scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index b0d7517..989e4ed 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -471,6 +471,7 @@ static void virtio_sc

[Qemu-devel] [PATCH RFC 5/8] virtio-serial: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/char/virtio-serial-bus.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 2b647b6..98f32fd 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@

Re: [Qemu-devel] [RFC PATCH V5 7/8] target-arm: Implement kvm_arch_reset_vcpu() for KVM ARM64

2014-05-14 Thread Peter Maydell
On 12 May 2014 13:37, Pranavkumar Sawargaonkar wrote: > To implement kvm_arch_reset_vcpu(), we simply re-init the VCPU > using kvm_arm_vcpu_init() so that all registers of VCPU are set > to their reset values by in-kernel KVM code. > > Signed-off-by: Pranavkumar Sawargaonkar > Signed-off-by: Anup

Re: [Qemu-devel] [PATCH v1 18/22] target-arm: A64: Generalize update_spsel for the various ELs

2014-05-14 Thread Richard Henderson
On 05/13/2014 06:18 PM, Edgar E. Iglesias wrote: > I've changed it to the following for next version: > /* We rely on illegal updates to SPsel from EL0 to get trapped > * at translation time. > */ > > If you have better suggestions I'm happy to update. Excellent, thanks. r~

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Matthew Booth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/05/14 15:47, Eric Blake wrote: > On 05/08/2014 02:42 AM, Matthew Booth wrote: >> [PATCH 1/4] curl: Fix parsing of readahead option from filename >> [PATCH 2/4] curl: Add sslverify option [PATCH 3/4] curl: Add >> usage documentation >> >> The fi

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Matthew Booth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/05/14 03:48, Kevin Wolf wrote: > Am 13.05.2014 um 21:47 hat Eric Blake geschrieben: >> On 05/08/2014 02:42 AM, Matthew Booth wrote: >>> [PATCH 1/4] curl: Fix parsing of readahead option from >>> filename [PATCH 2/4] curl: Add sslverify option [PA

Re: [Qemu-devel] [PATCH] qapi: Show qapi-commands.py invocation in qapi-code-gen.txt

2014-05-14 Thread Eric Blake
On 05/14/2014 09:27 AM, Markus Armbruster wrote: > While there, pare down the shell prompts. > > Signed-off-by: Markus Armbruster > --- > Note: to be applied on top of "[PATCH v2 00/12] qapi: Purge > error_is_set()". > > docs/qapi-code-gen.txt | 27 +-- > 1 file changed,

<    1   2   3   4   >