Hi Fabian,

I too had been updating the core TZ patches provided by Samsung.  From
looking at your changes I see a lot of similarities in our code with the
exception being the mechanism for banked register support.  The difference
being that your approach is a bit more explicit in the declaration of the
banked registers.  Whereas my approach was to update the banked registers
once all the other registers were registered.  Both approaches I believe
work.

I spoke with Peter M. and he and I are okay with your approach.  I will be
looking closer at your patches today and making comments.

One thing that held me up from committing sooner was testing my changes.
 Do you have a good approach for testing the changes?

Regards,

Greg


On 14 May 2014 03:58, Aggeler Fabian <aggel...@student.ethz.ch> wrote:

> I see. What is Greg Bellows working on exactly? Also peripherals like
> TZASC, TZPC,...? My plan is to focus on them now if no one else is working
> on them. What do you suggest to minimize overlap?
>
> Thanks,
> Fabian
> ________________________________________
> From: Peter Maydell [peter.mayd...@linaro.org]
> Sent: Monday, May 12, 2014 10:39 PM
> To: Aggeler  Fabian
> Cc: Edgar E. Iglesias; Rob Herring; Peter Crosthwaite; QEMU Developers;
> Alexander Graf; John Williams; Alex Bennée; Greg Bellows
> Subject: Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for
> A64 EL2 and 3
>
> On 12 May 2014 20:13, Aggeler  Fabian <aggel...@student.ethz.ch> wrote:
> > I’ve been reworking the Samsung patches as part of my Master thesis and
> I wanted to
> > send them some time this week. I am currently rebasing them when I
> noticed Edgar’s
> > patches. Is there some branch with the patches so I could rebase on them?
>
> Hmm, that makes about three lots of people trying to do similar things
> at this point. We should try to coordinate so we don't duplicate work.
>
> thanks
> -- PMM
>

Reply via email to