On Thu, May 08, 2014 at 12:51:05PM +0000, Zhanghailiang wrote: > > If you implement this in the net layer then that problem is easy to resolve > > since > > we can flush all queues when the guest resumes to get packets flowing again. > > > Do you mean we should also listen for VM runstate changes in net layer, and > when detect runstate changes back to running , we flush all queues actively? > Am I misunderstanding? > Or we can do it *before* qemu (exactly when it check if it can send packets) > send packets to guest again, this way will be simple, but it also need know > the change of runstate. Any idea?
When the runstate changes back to running, we definitely need to flush queues to get packets flowing again. I think the simplest way of doing that is in the net layer so individual NICs and netdevs don't have to duplicate this code. Stefan