Re: [Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-14 Thread Alexander Graf
On 12.04.14 17:52, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another and the two hosts might have a different timebase origin. However, the timebase seen by the guest

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-14 Thread Markus Armbruster
"Gabriel L. Somlo" writes: > Kevin, > > Thanks for the comments. I'll work your feedback (and any other > feedback I get by early next week) into another iteration of smbios > patches for both SeaBIOS and QEMU. > > In the mean time, there's one remaining "big picture" design question: > > On Sat,

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 04:37 PM, Alexander Graf wrote: > > On 12.04.14 23:44, Benjamin Herrenschmidt wrote: >> On Sat, 2014-04-12 at 16:31 +0200, Alexander Graf wrote: >>> Don't we generate PHBs on the fly? How exactly is this going to help >>> with the problem at hand? >> We can still assign the interrupt

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-14 Thread Markus Armbruster
Alistair Francis writes: > On Wed, Apr 9, 2014 at 9:58 PM, Peter Crosthwaite > wrote: >> On Wed, Apr 9, 2014 at 7:56 PM, Markus Armbruster wrote: >>> We have a number of device model names containing '.'. They're unusable >>> with -global. That's because "-global A.B.C=foo" gets parsed as >>>

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Alexander Graf
On 14.04.14 09:12, Alexey Kardashevskiy wrote: On 04/14/2014 04:37 PM, Alexander Graf wrote: On 12.04.14 23:44, Benjamin Herrenschmidt wrote: On Sat, 2014-04-12 at 16:31 +0200, Alexander Graf wrote: Don't we generate PHBs on the fly? How exactly is this going to help with the problem at hand?

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-14 Thread Hu Tao
On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > Needed for Windows to use hotplugged memory device, otherwise > it complains that server is not configured for memory hotplug. > Tests shows that aftewards it uses dynamically provided > proximity value from _PXM() method if available

Re: [Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 05:08 PM, Alexander Graf wrote: > > On 12.04.14 17:52, Alexey Kardashevskiy wrote: >> This allows guests to have a different timebase origin from the host. >> >> This is needed for migration, where a guest can migrate from one host >> to another and the two hosts might have a differe

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-14 Thread Alexander Graf
On 11.04.14 18:30, Alexey Kardashevskiy wrote: On 04/12/2014 02:15 AM, Alexander Graf wrote: On 11.04.14 18:01, Alexey Kardashevskiy wrote: On 04/12/2014 01:38 AM, Alexander Graf wrote: On 11.04.14 17:27, Alexey Kardashevskiy wrote: On 04/12/2014 12:58 AM, Alexander Graf wrote: On 11.04.14

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 05:34 PM, Alexander Graf wrote: > > On 11.04.14 18:30, Alexey Kardashevskiy wrote: >> On 04/12/2014 02:15 AM, Alexander Graf wrote: >>> On 11.04.14 18:01, Alexey Kardashevskiy wrote: On 04/12/2014 01:38 AM, Alexander Graf wrote: > On 11.04.14 17:27, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH] spapr: add ibm, chip-id property in device tree

2014-04-14 Thread Alexander Graf
On 11.04.14 18:41, Alexey Kardashevskiy wrote: On 04/12/2014 02:29 AM, Alexander Graf wrote: On 13.03.14 07:29, Alexey Kardashevskiy wrote: This adds a "ibm,chip-id" property for CPU nodes which should be the same for all cores in the same CPU socket. The recent guest kernels use this informat

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-14 Thread Alexander Graf
On 14.04.14 09:41, Alexey Kardashevskiy wrote: On 04/14/2014 05:34 PM, Alexander Graf wrote: On 11.04.14 18:30, Alexey Kardashevskiy wrote: On 04/12/2014 02:15 AM, Alexander Graf wrote: On 11.04.14 18:01, Alexey Kardashevskiy wrote: On 04/12/2014 01:38 AM, Alexander Graf wrote: On 11.04.14

Re: [Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-14 Thread Alexander Graf
On 14.04.14 09:33, Alexey Kardashevskiy wrote: On 04/14/2014 05:08 PM, Alexander Graf wrote: On 12.04.14 17:52, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another an

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 05:42 PM, Alexander Graf wrote: > > On 14.04.14 09:41, Alexey Kardashevskiy wrote: >> On 04/14/2014 05:34 PM, Alexander Graf wrote: >>> On 11.04.14 18:30, Alexey Kardashevskiy wrote: On 04/12/2014 02:15 AM, Alexander Graf wrote: > On 11.04.14 18:01, Alexey Kardashevskiy wrot

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-14 Thread Markus Armbruster
Peter Crosthwaite writes: > On Fri, Apr 11, 2014 at 11:41 PM, Markus Armbruster wrote: >> Peter Crosthwaite writes: >> >>> On Thu, Apr 10, 2014 at 1:48 AM, Markus Armbruster >>> wrote: I stumbled over this while trying to purge error_is_set() from the code. Here's how we c

Re: [Qemu-devel] [PATCH] spapr: add ibm, chip-id property in device tree

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 05:41 PM, Alexander Graf wrote: > > On 11.04.14 18:41, Alexey Kardashevskiy wrote: >> On 04/12/2014 02:29 AM, Alexander Graf wrote: >>> On 13.03.14 07:29, Alexey Kardashevskiy wrote: This adds a "ibm,chip-id" property for CPU nodes which should be the same for all cores in

Re: [Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 05:46 PM, Alexander Graf wrote: > > On 14.04.14 09:33, Alexey Kardashevskiy wrote: >> On 04/14/2014 05:08 PM, Alexander Graf wrote: >>> On 12.04.14 17:52, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed f

Re: [Qemu-devel] Automatic spice port selection

2014-04-14 Thread Fabio Fantoni
Il 26/03/2014 17:15, Fabio Fantoni ha scritto: Time ago I have read somewhere that there is an option to automatically spice port in qemu as for vnc. I started to write a libxl patch to add this feature like the vnc one: https://github.com/Fantu/Xen/commit/63c54f354a34e7eb27b1c69016789a372a75843

Re: [Qemu-devel] Turning off default storage devices?

2014-04-14 Thread Markus Armbruster
Peter Crosthwaite writes: > Hi Andy, > > On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski wrote: >> Currently, -M q35 boots linux quite a bit slower than the default >> machine type. This seems to be because it takes a few hundred ms to >> determine that there's nothing attached to the AHCI con

Re: [Qemu-devel] [PATCH v5] spapr: Add support for time base offset migration

2014-04-14 Thread Alexander Graf
On 14.04.14 10:10, Alexey Kardashevskiy wrote: On 04/14/2014 05:46 PM, Alexander Graf wrote: On 14.04.14 09:33, Alexey Kardashevskiy wrote: On 04/14/2014 05:08 PM, Alexander Graf wrote: On 12.04.14 17:52, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from

Re: [Qemu-devel] iPXE timeout missing

2014-04-14 Thread Gerd Hoffmann
On So, 2014-04-13 at 02:05 +0200, Sebastian wrote: > Hi, > > when trying current qemu git, I noticed the iPXE timeout has been removed: > > commit 95ca557d5cfc1ef69ba9708ded552f389afe643d > Author: Gerd Hoffmann > Date: Mon Mar 25 09:07:40 2013 +0100 > > ipxe: disable two second timeout

Re: [Qemu-devel] [PATCH qemu 5/6] virtio-input: control device

2014-04-14 Thread Gerd Hoffmann
Hi, > > What I was thinking about is sending feedback about volume changes to > > the guest is something completely different, let me explain in detail: > > > > What we have in spice today is that the guests volume change request is > > passed to the spice client, which in turn forwards it to p

Re: [Qemu-devel] [PATCH for 2.0] ide: Correct improper smart self test counter reset in ide core.

2014-04-14 Thread Markus Armbruster
Benoît Canet writes: > The counter being reseted to zero make the array index negative. > Reset it to 1. > > Signed-off-by: Benoit Canet > --- > hw/ide/core.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index e1dfe54..c943a4d 10064

Re: [Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-14 Thread Markus Armbruster
Copying Marcel. Jun Li writes: > Add remove_boot_device_path() function to remove bootindex when hot-unplug > a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic > device. > So it has fixed bug1086603, ref: > https://bugzilla.redhat.com/show_bug.cgi?id=1086603 > > Signed-off

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-14 Thread Gerd Hoffmann
Hi, > harm in always producing type0). Also, it would be nice to move up > patch 18 to after patch 10 - that way an end-to-end test between > old/new smbios with the new interface could be done. Agree, that would be nice to have (although I wouldn't make that a hard requirement for merging).

Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

2014-04-14 Thread Gerd Hoffmann
Hi, > 2. QEMU only generates type 0 if explicitly told to do so on the > command line (i.e., *not* by default). In this case, SeaBIOS (or OVMF, > or any other BIOS) would have to scan the tables and insert its own > default type 0 if one was not purposely supplied by QEMU. (I know my > current S

Re: [Qemu-devel] [PATCH] arch_init.c: remove duplicate function

2014-04-14 Thread Laszlo Ersek
On 04/14/14 04:27, Amos Kong wrote: > We already have a function buffer_is_zero() in util/cutils.c > > Signed-off-by: Amos Kong > --- > arch_init.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 60c975d..342e5dc 100644 > --- a

Re: [Qemu-devel] [PATCH 1/5] s390x/cpu: Use ioctl to reset state in the kernel

2014-04-14 Thread Alexander Graf
On 26.02.14 12:38, Christian Borntraeger wrote: From: Thomas Huth Some of the state in the kernel can not be reset from QEMU yet. For this we've got to use the KVM_S390_INITIAL_RESET ioctl to make sure that the state in the kernel is set to the right values during initial CPU reset, too. Sign

Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h

2014-04-14 Thread Alexander Graf
On 25.02.14 09:46, Peter Crosthwaite wrote: Ping! Did this get applied meanwhile? Edgar? Alex On Thu, Feb 13, 2014 at 9:21 AM, Peter Crosthwaite wrote: Hi Edgar, This file is written for a very old qdev style of machine description. Remove by inlining all usages of its functions (which

Re: [Qemu-devel] [PATCH v2 0/3] target-ppc: Relax use of generic CPU name for KVM

2014-04-14 Thread Alexander Graf
On 11.04.14 19:34, Alexey Kardashevskiy wrote: This enables generic CPU family name use with "-cpu" for all CPUs across the family and not for the ones already defined in QEMU. Changes: v2: * split one patch into 3 * added assert into ppc_cpu_get_family_class() Thanks, applied to ppc-next.

Re: [Qemu-devel] [PATCH 1/2] QEMU: PPC: specify PVRs for all e500 cores

2014-04-14 Thread Alexander Graf
On 14.02.14 20:22, Stuart Yoder wrote: From: Stuart Yoder Signed-off-by: Stuart Yoder --- target-ppc/cpu-models.c | 64 +-- target-ppc/cpu-models.h | 30 -- 2 files changed, 90 insertions(+), 4 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 2/2] QEMU: PPC: set default cpu type to be 'host'

2014-04-14 Thread Alexander Graf
On 14.02.14 20:22, Stuart Yoder wrote: From: Stuart Yoder -for KVM we always want the cpu to be that of the host system, so make that the default -for TGC mode, the emulated cpu type should be explicitly set Signed-off-by: Stuart Yoder Could you please indicate in the subject line tha

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-04-14 Thread Alexander Graf
On 10.02.14 06:12, Alexey Kardashevskiy wrote: On 02/08/2014 01:06 AM, Alexander Graf wrote: On 07.02.2014, at 14:44, Greg Kurz wrote: In the past, IO space could not be mapped into the memory address space so we introduced a workaround for that. Nowadays it does not look necessary so we can

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Benjamin Herrenschmidt
On Mon, 2014-04-14 at 08:32 +0200, Alexander Graf wrote: > So for chips that might be configurable, configuration has to happen via > some SPR, right? Wouldn't it make sense to transfer that configuration > SPR on these and thus the configuration as well? Well, on a real 970 I can always go poke

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Benjamin Herrenschmidt
On Mon, 2014-04-14 at 08:37 +0200, Alexander Graf wrote: > So we either have to create some way to make interrupt numbering a > function of something very simple we plug the PHB into, like a virtual > pseries slot number which we multiply by x to get an irq number range. > Or we'd have to manual

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] smp: autodetect numbers of threads per core

2014-04-14 Thread Alexander Graf
On 15.11.13 17:58, Alexey Kardashevskiy wrote: On 16.11.2013 0:15, Alexander Graf wrote: Am 15.11.2013 um 00:12 schrieb Alexey Kardashevskiy : At the moment only a whole CPU core can be assigned to a KVM. Since POWER7/8 support several threads per core, we want all threads of a core to go to

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Benjamin Herrenschmidt
On Mon, 2014-04-14 at 17:12 +1000, Alexey Kardashevskiy wrote: > Our additional PHBs require @index property which is used to calculate > base > MMIO and IO ranges. That we could use for LSI/MSI too. That works. We need to decide how much interrupt "space" we give to each. The HW on P8 does 2048

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-14 Thread Benjamin Herrenschmidt
On Mon, 2014-04-14 at 21:14 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2014-04-14 at 17:12 +1000, Alexey Kardashevskiy wrote: > > Our additional PHBs require @index property which is used to calculate > > base > > MMIO and IO ranges. That we could use for LSI/MSI too. > > That works. We need t

Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling

2014-04-14 Thread Peter Maydell
On 14 April 2014 07:04, Peter Crosthwaite wrote: > On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell > wrote: >> From: Rob Herring >> +switch (cs->exception_index) { >> +case EXCP_PREFETCH_ABORT: >> +case EXCP_DATA_ABORT: >> +qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-14 Thread Claudio Fontana
On 07.04.2014 18:33, Richard Henderson wrote: > On 04/07/2014 12:58 AM, Claudio Fontana wrote: >>> +|| (insn & 0x3bc0) == 0x2840 /* C3.3.7 */ >> >> I think the Load (L) bit should be 0 here so >> >> == 0x2800 > > Oops. Fixed. > >> >>> +|| (insn & 0x3

Re: [Qemu-devel] [PATCH v5 22/37] hw/arm/virt: Add support for Cortex-A57

2014-04-14 Thread Peter Maydell
On 14 April 2014 07:10, Peter Crosthwaite wrote: > On Sat, Mar 29, 2014 at 2:10 AM, Peter Maydell > wrote: >> Support the Cortex-A57 in the virt machine model. >> >> Signed-off-by: Peter Maydell >> --- >> This should perhaps not be just stealing the a15mpcore_priv >> on the basis that it's a GI

Re: [Qemu-devel] [PATCH v6 00/37] AArch64 system emulation

2014-04-14 Thread Peter Maydell
On 14 April 2014 07:39, Peter Crosthwaite wrote: > Im finished with the review. There's a few areas that I'm not very > familiar with that Ive skipped or others have reviewed. So for all > un-commented patches: > > Acked-by: Peter Crosthwaite Thanks! I've made the minor tweaks you suggested. We

[Qemu-devel] [PATCH v7 0/8] virtio endian-ambivalent target fixes

2014-04-14 Thread Greg Kurz
Hi, Here's the latest patchset to have virtio working with targets that can change endianness. It is based on 2.0-rc2. It is also available at github: https://github.com/gkurz/qemu/commits/virtio This serie addresses all the remarks that I got from v6. It also brings some more fixes: TCP checks

Re: [Qemu-devel] [PATCH 1/5] s390x/cpu: Use ioctl to reset state in the kernel

2014-04-14 Thread Thomas Huth
On Mon, 14 Apr 2014 12:14:49 +0200 Alexander Graf wrote: > > On 26.02.14 12:38, Christian Borntraeger wrote: > > From: Thomas Huth > > > > Some of the state in the kernel can not be reset from QEMU yet. > > For this we've got to use the KVM_S390_INITIAL_RESET ioctl to make > > sure that the sta

[Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory accessors to be used accross the virti

[Qemu-devel] [PATCH v7 2/8] virtio: allow byte swapping for vring and config access

2014-04-14 Thread Greg Kurz
From: Rusty Russell This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains headers. Signed-off-by: Rusty Russell [ add VirtIODevice * argument to most helpers, Greg Kurz ] Si

[Qemu-devel] [PATCH v7 3/8] virtio-net: use virtio wrappers to access headers

2014-04-14 Thread Greg Kurz
From: Rusty Russell virtio-net gets target independant. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori [ pass VirtIODevice * to memory accessors, TCP checksums fix by Cédric Le Goater, target independant, Greg Kurz ] Cc: Cédric Le Goater Signed-off-by: Greg Kurz --- Change

Re: [Qemu-devel] [PATCH for-2.0] pc: ACPI BIOS: fix incorrect integer encoding for 0x{F-1}FFFF values

2014-04-14 Thread Michael S. Tsirkin
On Sun, Apr 13, 2014 at 11:55:51PM +0200, Igor Mammedov wrote: > Fix typo in build_append_int() which causes integer > truncation when it's in range 0x{F-1} by packing it > as WordConst instead of required DWordConst. > > Signed-off-by: Igor Mammedov Good catch - this fixes hotplug in slots

[Qemu-devel] [PATCH v7 4/8] virtio-balloon: use virtio wrappers to access page frame numbers

2014-04-14 Thread Greg Kurz
From: Rusty Russell This one can't get target independant because of TARGET_PAGE_SIZE. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori [ pass VirtIODevice * to memory accessors, Greg Kurz ] Signed-off-by: Greg Kurz --- hw/virtio/virtio-balloon.c |8 +--- 1 file changed,

[Qemu-devel] [PATCH v7 5/8] virtio-blk: use virtio wrappers to access headers

2014-04-14 Thread Greg Kurz
From: Rusty Russell Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. virtio-blk gets target independant. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori [ pass VirtIODevice * to memory accessors, target independant, Greg Kurz ] Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 1/5] s390x/cpu: Use ioctl to reset state in the kernel

2014-04-14 Thread Alexander Graf
On 14.04.14 13:54, Thomas Huth wrote: On Mon, 14 Apr 2014 12:14:49 +0200 Alexander Graf wrote: On 26.02.14 12:38, Christian Borntraeger wrote: From: Thomas Huth Some of the state in the kernel can not be reset from QEMU yet. For this we've got to use the KVM_S390_INITIAL_RESET ioctl to mak

[Qemu-devel] [PATCH v7 6/8] virtio-scsi: use virtio wrappers to access headers

2014-04-14 Thread Greg Kurz
From: Rusty Russell Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. virtio-scsi gets target independant. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori [ pass VirtIODevice * to memory accessors, fix missing tswap32 in virtio_scsi_push_event() by Cédric

[Qemu-devel] [PATCH v7 7/8] virtio-serial-bus: use virtio wrappers to access headers

2014-04-14 Thread Greg Kurz
From: Rusty Russell virtio-serial-bus gets platform independant. Signed-off-by: Rusty Russell Reviewed-by: Anthony Liguori [ pass VirtIODevice * to memory accessors, platform independant, Greg Kurz ] Signed-off-by: Greg Kurz --- Changes since v6: - target independant hw/char/Makefile

[Qemu-devel] [PATCH v7 8/8] virtio-9p: use virtio wrappers to access headers

2014-04-14 Thread Greg Kurz
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. virtio-9p-device gets platform independant. Signed-off-by: Greg Kurz --- Changes since v6: - target independant hw/9pfs/Makefile.objs |3 +-- hw/9pfs/virtio-9p-device.c |3 ++- 2 files changed, 3 insertio

Re: [Qemu-devel] [PATCH v4 21/25] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-14 Thread Claudio Fontana
On 11.04.2014 17:40, Richard Henderson wrote: > Cleaning up the implementation of REV and REV16 at the same time. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 57 > > 1 file changed, 33 insertions(+), 24 deletions(-) >

[Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-14 Thread Greg Kurz
We turn the virtio_is_big_endian() helper into a target dependant hook to compute endianness for legacy virtio devices. We base it on the OS endian, as reflected by the endianness of the interrupt vectors (handled through the ILE bit in the LPCR register). Using first_cpu to fetch the registers f

[Qemu-devel] [PATCH for-2.0] Revert "fix return check for KVM_GET_DIRTY_LOG ioctl"

2014-04-14 Thread Michael Tokarev
This reverts commit b533f658a98325d0e47b36113bd9f5bcc046fdae. The original code was wrong, because effectively it ignored errors from kernel, because kernel does not return -1 on error case but returns -errno, and does not return -EPERM for this particular ioctl. But in some cases kernel actually

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory

Re: [Qemu-devel] [PATCH for 2.0] ide: Correct improper smart self test counter reset in ide core.

2014-04-14 Thread Markus Armbruster
Markus Armbruster writes: > Benoît Canet writes: > >> The counter being reseted to zero make the array index negative. >> Reset it to 1. >> >> Signed-off-by: Benoit Canet >> --- >> hw/ide/core.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/ide/core.c b/hw/i

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > >From: Rusty Russell > > > >virtio data structures are defined as "target endian", which assumes > >that's a fixed value. In fact, that actually means it's platform-specific. > >The OASIS vi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > >From: Rusty Russell > > > >virtio data structures are defined as "target endian", which assumes > >that's a fixed value. In fact, that actually means it's platform-specific. > >The OASIS vi

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-14 Thread Alexander Graf
On 14.04.14 14:12, Greg Kurz wrote: We turn the virtio_is_big_endian() helper into a target dependant hook to compute endianness for legacy virtio devices. We base it on the OS endian, as reflected by the endianness of the interrupt vectors (handled through the ILE bit in the LPCR register). U

[Qemu-devel] [PULL for-2.0 2/2] acpi-test: update expected files

2014-04-14 Thread Michael S. Tsirkin
commit 58b035c7354afc0c5351ea62264c01d74196ec26 acpi: fix incorrect encoding for 0x{F-1} changes the SSDT, update expected files accordingly. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT | Bin 2261 -> 2269 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's p

[Qemu-devel] [PULL for-2.0 0/2] acpi: SSDT update

2014-04-14 Thread Michael S. Tsirkin
The following changes since commit 590e5dd98fcc926cc3b63aad35aed79235ca4c2a: configure: Make stack-protector test check both compile and link (2014-04-14 12:11:18 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to

[Qemu-devel] [PULL for-2.0 1/2] acpi: fix incorrect encoding for 0x{F-1}FFFF

2014-04-14 Thread Michael S. Tsirkin
From: Igor Mammedov Fix typo in build_append_int() which causes integer truncation when it's in range 0x{F-1} by packing it as WordConst instead of required DWordConst. In partucular this fixes a regression: hotplug in slots 16,17,18 and 19 didn't work, since SSDT had code like this:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:28, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's p

Re: [Qemu-devel] [PATCH for 2.0] ide: Correct improper smart self test counter reset in ide core.

2014-04-14 Thread Kevin Wolf
Am 14.04.2014 um 14:10 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Benoît Canet writes: > > > >> The counter being reseted to zero make the array index negative. > >> Reset it to 1. > >> > >> Signed-off-by: Benoit Canet > >> --- > >> hw/ide/core.c |2 +- > >> 1 fil

[Qemu-devel] When QEMU is emulating DMA, can other vcpus read/write the same memory region?

2014-04-14 Thread Le Tan
Hi, I have been confused by this question for a long time, both in hardware and software. First, in the real x86 hardware architectures, while the DMA is operating, can other CPUs access the same memory region? Or the DMA controller will hold the bus and the memory exclusively and CPUs have to wait

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: > > On 14.04.14 14:28, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: > >>On 14.04.14 13:58, Greg Kurz wrote: > >>>From: Rusty Russell > >>> > >>>virtio data structures are defined as "ta

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > > On 14.04.14 14:24, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > >>On 14.04.14 13:58, Greg Kurz wrote: > >>>From: Rusty Russell > >>> > >>>virtio data structures are defined as "ta

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:34, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: On 14.04.14 14:28, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: Could we try to poison any non-virtio, non-endian-specific memory accessors

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:16:03 +0200 Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > > From: Rusty Russell > > > > virtio data structures are defined as "target endian", which assumes > > that's a fixed value. In fact, that actually means it's platform-specific. > > The OASIS vir

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data stru

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:38:14PM +0200, Alexander Graf wrote: > > On 14.04.14 14:34, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:28, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:46, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: This will have to be measure

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > > From: Rusty Russell > > > > virtio data structures are defined as "target endian", which assumes > > that's a fixed value. In fact, that actually means it's platform-specific. > > The OASIS vir

Re: [Qemu-devel] [PATCH for 2.0] ide: Correct improper smart self test counter reset in ide core.

2014-04-14 Thread Peter Maydell
On 14 April 2014 13:31, Kevin Wolf wrote: > Am 14.04.2014 um 14:10 hat Markus Armbruster geschrieben: >> Markus Armbruster writes: >> >> > Benoît Canet writes: >> > >> >> The counter being reseted to zero make the array index negative. >> >> Reset it to 1. >> >> >> >> Signed-off-by: Benoit Canet

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:50, Greg Kurz wrote: On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specif

[Qemu-devel] [PATCH v6] spapr: Add support for time base offset migration

2014-04-14 Thread Alexey Kardashevskiy
This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another and the two hosts might have a different timebase origin. However, the timebase seen by the guest must not go backwards, and should go forwards onl

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:49:31PM +0200, Alexander Graf wrote: > > On 14.04.14 14:46, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:37, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH] spapr_pci: Fix number of returned vectors in ibm, change-msi

2014-04-14 Thread Alexey Kardashevskiy
On 04/07/2014 10:53 PM, Alexey Kardashevskiy wrote: > Current guest kernels try allocating as many vectors as the quota is. > For example, in the case of virtio-net (which has just 3 vectors) > the guest requests 4 vectors (that is the quota in the test) and > the existing ibm,change-msi handler re

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Cedric Le Goater
On 04/14/2014 02:49 PM, Alexander Graf wrote: > > On 14.04.14 14:46, Michael S. Tsirkin wrote: >> On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: >>> On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > On 14.04.14

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:56, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:49:31PM +0200, Alexander Graf wrote: On 14.04.14 14:46, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 15:46:34 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > > >>On 14.04.14 14:24, Michael S. Tsirkin w

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:55, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] smp: autodetect numbers of threads per core

2014-04-14 Thread Alexey Kardashevskiy
On 04/14/2014 09:15 PM, Alexander Graf wrote: > > On 15.11.13 17:58, Alexey Kardashevskiy wrote: >> On 16.11.2013 0:15, Alexander Graf wrote: >>> >>> Am 15.11.2013 um 00:12 schrieb Alexey Kardashevskiy : >>> At the moment only a whole CPU core can be assigned to a KVM. Since POWER7/8 sup

Re: [Qemu-devel] [PATCH] spapr_pci: Fix number of returned vectors in ibm, change-msi

2014-04-14 Thread Alexander Graf
On 14.04.14 14:55, Alexey Kardashevskiy wrote: On 04/07/2014 10:53 PM, Alexey Kardashevskiy wrote: Current guest kernels try allocating as many vectors as the quota is. For example, in the case of virtio-net (which has just 3 vectors) the guest requests 4 vectors (that is the quota in the test)

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-14 Thread Peter Maydell
On 11 April 2014 18:37, Peter Maydell wrote: > Status update: > Applied: > * ACPI fixes (both sets) > * block queue > * SDL2 relative mode fixes > * fix for virtio-net CVE > * fix for qom-list crash > * my patch to stack-protector check > Patches on list but need review/ack and/or not sure w

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] smp: autodetect numbers of threads per core

2014-04-14 Thread Alexander Graf
On 14.04.14 15:10, Alexey Kardashevskiy wrote: On 04/14/2014 09:15 PM, Alexander Graf wrote: On 15.11.13 17:58, Alexey Kardashevskiy wrote: On 16.11.2013 0:15, Alexander Graf wrote: Am 15.11.2013 um 00:12 schrieb Alexey Kardashevskiy : At the moment only a whole CPU core can be assigned to

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 03:08:23PM +0200, Alexander Graf wrote: > > On 14.04.14 14:55, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:37, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:53:03 +0200 Alexander Graf wrote: > > On 14.04.14 14:50, Greg Kurz wrote: > > On Mon, 14 Apr 2014 14:22:36 +0200 > > Alexander Graf wrote: > > > >> On 14.04.14 13:58, Greg Kurz wrote: > >>> From: Rusty Russell > >>> > >>> virtio data structures are defined as "target endi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 15:12, Greg Kurz wrote: On Mon, 14 Apr 2014 14:53:03 +0200 Alexander Graf wrote: On 14.04.14 14:50, Greg Kurz wrote: On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-14 Thread Paolo Bonzini
Il 14/04/2014 09:11, Peter Maydell ha scritto: > On 11 April 2014 18:37, Peter Maydell wrote: >> Status update: >> Applied: >> * ACPI fixes (both sets) >> * block queue >> * SDL2 relative mode fixes >> * fix for virtio-net CVE >> * fix for qom-list crash >> * my patch to stack-protector chec

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:40:04 +0200 Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > > On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >> On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>> On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > >

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-14 Thread Peter Maydell
On 14 April 2014 14:17, Paolo Bonzini wrote: > Il 14/04/2014 09:11, Peter Maydell ha scritto: >>> * win64 virtio-scsi regression >> >> In the absence of any patches here I think we should deem >> win64 virtio-scsi sufficiently minor that it will get >> fixed in 2.0.1. > > The patch is at > http:/

Re: [Qemu-devel] [PATCH v4 23/25] tcg-aarch64: Introduce tcg_out_insn_3312, _3310, _3313

2014-04-14 Thread Claudio Fontana
On 11.04.2014 17:40, Richard Henderson wrote: > Replace aarch64_ldst_op_data with AArch64LdstType, as it wasn't encoded > for the proper shift for the field and was confusing. > > Merge aarch64_ldst_op_data, AArch64LdstType, and a few stray opcode bits > into a single I3312_* argument, eliminating

Re: [Qemu-devel] [PATCH] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-14 Thread Kevin Wolf
Am 03.04.2014 um 16:44 hat Max Reitz geschrieben: > On 02.04.2014 08:04, Fam Zheng wrote: > >bdrv_getlength could fail, check the return value before using it. > > > >Signed-off-by: Fam Zheng > >--- > > block-migration.c | 28 > > block.c | 10 ++

  1   2   3   >