On 14 April 2014 07:04, Peter Crosthwaite <peter.crosthwa...@xilinx.com> wrote: > On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> From: Rob Herring <rob.herr...@linaro.org> >> + switch (cs->exception_index) { >> + case EXCP_PREFETCH_ABORT: >> + case EXCP_DATA_ABORT: >> + qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64 "\n", >> + env->cp15.far_el1); > > need a /* fallthrough */
I think a simple 'break;' would be better, actually. > otherwise: > > Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> thanks -- PMM