Re: [Qemu-devel] [PATCH] qemu-char: Allow a chardev to reconnect if disconnected

2014-04-11 Thread Gerd Hoffmann
Hi, > > This patch is modified according to corey's patch. Some changes below: > > 1. IMO it's unnecessary that chardev reconnect if it fails to connect at > > startup. > > Qemu exit in this scene. In this way the patch does not change interface of > > chardev. > > It would be much more simple

[Qemu-devel] [PATCH v2 4/4] qemu-options.hx: Update the command line documentation for -device

2014-04-11 Thread Alistair Francis
Update the command line documentation to include the new sysbus connection ability Signed-off-by: Alistair Francis --- qemu-options.hx |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2d33815..131248b 100644 --- a/qemu-optio

Re: [Qemu-devel] [PATCH qemu 3/6] virtio-input: core code & base class

2014-04-11 Thread Gerd Hoffmann
Hi, > > It's not different from other input devices. No buffer space -> drop > > event. What else do you think should happen? We could signal "you lost > > events" to the guest, but I suspect that buys us nothing. Other input > > devices don't have that capability, so guests are likely not p

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-11 Thread Peter Maydell
On 11 April 2014 02:40, Eric Blake wrote: > We uncovered a real bug that would be fixed by this patch: > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01745.html No, that's a bug in the called code. The API here defines that for optional parameters, if the have_foo bool is false then t

Re: [Qemu-devel] [PATCH v2 3/4] vl.c: Enable adding devices to the system bus

2014-04-11 Thread Peter Maydell
On 11 April 2014 07:34, Alistair Francis wrote: > This removes the old method to connect devices and replaces it > with three calls to the three qdev-monitor functions added > in the previous patch. > > This allows complete machines to be built via the command line as > well as just attaching simp

Re: [Qemu-devel] KVM call agenfda for 2014-04-01

2014-04-11 Thread Markus Armbruster
[Cc: Andreas, Anthony] Alexander Graf writes: > On 10.04.2014, at 17:52, Peter Maydell wrote: > >> On 10 April 2014 16:49, Alexander Graf wrote: >>> For the next call, I would propose to revive the "platform bus" >>> (aka: how to create non-PCI devices with -device) discussions Rather: device

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-11 Thread Fam Zheng
On Fri, 04/11 08:27, Peter Maydell wrote: > On 11 April 2014 02:40, Eric Blake wrote: > > We uncovered a real bug that would be fixed by this patch: > > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01745.html > > No, that's a bug in the called code. The API here defines > that for opt

Re: [Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-11 Thread Peter Maydell
On 11 April 2014 07:34, Alistair Francis wrote: > This patch allows sysbus devices to be attached via > command line arguments. > > This can be used to build an entire machine from the command > line or to just add devices that aren't in the machine_init > code. > > A peripheral can be added with

Re: [Qemu-devel] [PATCH qemu 4/6] virtio-input: emulated devices

2014-04-11 Thread Gerd Hoffmann
Hi, > If drivers don't expect a mix of functionality, then separate IDs > seem better. The linux kernel can deal with it just fine. It's just that humans are more used to have separate devices. And I remember back in the dark xen days the input channel for xenfb was a unified input device whi

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-11 Thread Markus Armbruster
Eric Blake writes: > On 04/10/2014 07:45 AM, Alexander Graf wrote: > > > Is this something that can be quickly fixed (perhaps by reverting the > PPC patch until a more complete solution is ready), and if so, is it > worth doing for 2.0 proper, rather than waiting for 2.0.1? W

Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-11 Thread Gerd Hoffmann
Hi, > > I guess the only thing we might want to here is bail out in case the > > major version is != 1 (which implies a incompatible change). The major > > version didn't change so far though, and I think it is highly unlikely > > that it'll ever happen. > > > > cheers, > > Gerd > > BTW thi

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> I stumbled over this while trying to purge error_is_set() from the code. > >> Here's how we commonly use the Error API: >> >> Error *err = NULL; >> >> foo(arg, &err) >> if (err) { >> goto ou

Re: [Qemu-devel] [PATCH qemu 5/6] virtio-input: control device

2014-04-11 Thread Gerd Hoffmann
On Do, 2014-04-10 at 18:20 +0300, Michael S. Tsirkin wrote: > On Thu, Apr 10, 2014 at 02:10:20PM +0200, Gerd Hoffmann wrote: > > On Do, 2014-04-10 at 14:05 +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 10, 2014 at 11:07:53AM +0200, Gerd Hoffmann wrote: > > > > Device for sending non-input cont

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.04.2014 um 17:48 hat Markus Armbruster geschrieben: >> I stumbled over this while trying to purge error_is_set() from the code. >> >> >> Here's how we commonly use the Error API: >> >> Error *err = NULL; >> >> foo(arg, &err) >> if (err) { >> goto

[Qemu-devel] [PATCH for-2.0] kvm_physical_sync_dirty_bitmap: ignore ENOENT from kvm_vm_ioctl

2014-04-11 Thread Michael Tokarev
ENOENT means the kernel has an empty dirty bitmap for this slot. Don't abort in that case. This appears to solve the bug reported at https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1303926 which first showed up with commit b533f658a98325d: fix return check for KVM_GET_DIRTY_LOG ioctl Cc: S

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Markus Armbruster
Anthony Liguori writes: > The original visiting code was loosely based on ASN1 marshaling code > from Samba which used the "if error, bail out at the top" style of > error handling. > > As use of Error has evolved in QEMU, I agree that the paradigm of > "bail out as soon as you see an error and f

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> I stumbled over this while trying to purge error_is_set() from the code. > > > >> Here's how we commonly use the Error API: > >> > >> Error *err = NULL;

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-11 Thread Daniel P. Berrange
On Fri, Apr 11, 2014 at 10:01:37AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 04/10/2014 07:45 AM, Alexander Graf wrote: > > > > > > Is this something that can be quickly fixed (perhaps by reverting the > > PPC patch until a more complete solution is ready), and if

Re: [Qemu-devel] [RFC PATCH] target-ppc: Relax use of generic CPU name for KVM

2014-04-11 Thread Alexander Graf
On 11.04.14 07:00, Alexey Kardashevskiy wrote: At the moment generic version-less CPUs are supported via hardcoded aliases. For example, POWER7 is an alias for POWER7_v2.1. So when QEMU is started with -cpu POWER7, the POWER7_v2.1 class instance is created. This approach works for TCG and KVMs

Re: [Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-11 Thread Alexander Graf
On 11.04.14 09:55, Peter Maydell wrote: On 11 April 2014 07:34, Alistair Francis wrote: This patch allows sysbus devices to be attached via command line arguments. This can be used to build an entire machine from the command line or to just add devices that aren't in the machine_init code. A

Re: [Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-11 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 5:55 PM, Peter Maydell wrote: > On 11 April 2014 07:34, Alistair Francis wrote: >> This patch allows sysbus devices to be attached via >> command line arguments. >> >> This can be used to build an entire machine from the command >> line or to just add devices that aren't i

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-11 Thread Igor Mammedov
On Mon, 7 Apr 2014 18:14:51 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 13:23:54 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > > > Notify PIIX4_PM/I

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-11 Thread Igor Mammedov
On Mon, 7 Apr 2014 18:21:14 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 04:26:02PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 11:13:01 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > > > On 04/05/2014 1

Re: [Qemu-devel] KVM call agenfda for 2014-04-01

2014-04-11 Thread Alexander Graf
On 11.04.14 09:46, Markus Armbruster wrote: [Cc: Andreas, Anthony] Alexander Graf writes: On 10.04.2014, at 17:52, Peter Maydell wrote: On 10 April 2014 16:49, Alexander Graf wrote: For the next call, I would propose to revive the "platform bus" (aka: how to create non-PCI devices with

Re: [Qemu-devel] [RFC v2 1/6] hw/arm/virt: add a xgmac device

2014-04-11 Thread Alexander Graf
On 11.04.14 07:41, Alistair Francis wrote: On Thu, Apr 10, 2014 at 11:48 PM, Alexander Graf wrote: On 10.04.14 15:26, Peter Crosthwaite wrote: On Thu, Apr 10, 2014 at 1:33 AM, Eric Auger wrote: From: Kim Phillips This is a hack and only serves as an example of what needs to be done to mak

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexander Graf
On 10.04.14 16:43, Alexey Kardashevskiy wrote: On 04/10/2014 11:26 PM, Alexander Graf wrote: On 10.04.14 15:24, Alexey Kardashevskiy wrote: On 04/10/2014 10:51 PM, Alexander Graf wrote: On 14.03.14 05:18, Alexey Kardashevskiy wrote: The current allocator returns IRQ numbers from a pool and d

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-11 Thread Alexander Graf
On 10.04.14 16:31, Alexey Kardashevskiy wrote: On 04/10/2014 10:34 PM, Alexander Graf wrote: On 03.04.14 15:14, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another an

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-11 Thread Igor Mammedov
On Mon, 7 Apr 2014 18:36:34 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 04:22:06PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 16:25:30 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr 201

Re: [Qemu-devel] [PATCH v2 4/4] qemu-options.hx: Update the command line documentation for -device

2014-04-11 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 4:35 PM, Alistair Francis wrote: > Update the command line documentation to include the new sysbus > connection ability > > Signed-off-by: Alistair Francis > --- > > qemu-options.hx |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/qemu-

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Kevin Wolf
Am 11.04.2014 um 10:28 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 09.04.2014 um 17:48 hat Markus Armbruster geschrieben: > >> I stumbled over this while trying to purge error_is_set() from the code. > >> > >> > >> Here's how we commonly use the Error API: > >> > >> Er

[Qemu-devel] [PULL for-2.0 0/2] sdl2: relative mouse mode fixes

2014-04-11 Thread Gerd Hoffmann
Hi, Two sdl2 fixes for relative mouse mode, by Cole Robinson. please pull, Gerd The following changes since commit f516a5cc051db6e999e9e60dc968dcb5aeffe11f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-04-10 23:07:56 +0100) are available in the git rep

[Qemu-devel] [PULL 1/2] input: sdl2: Fix guest_cursor logic

2014-04-11 Thread Gerd Hoffmann
From: Cole Robinson Unbreaks relative mouse mode with sdl2, just like was done with sdl.c in c3aa84b6. Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index f1

Re: [Qemu-devel] [PATCH] block-commit: speed is an optional parameter

2014-04-11 Thread Kevin Wolf
Am 10.04.2014 um 19:36 hat Max Reitz geschrieben: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Bla

[Qemu-devel] [PULL 2/2] input: sdl2: Fix relative mode to match SDL1 behavior

2014-04-11 Thread Gerd Hoffmann
From: Cole Robinson Right now relative mode accelerates too fast, and has the 'invisible wall' problem. SDL2 added an explicit API to handle this use case, so let's use it. Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH v10 0/2] target-ppc: gdbstub little endian support patches

2014-04-11 Thread Alexander Graf
On 07.04.2014, at 23:40, Thomas Falcon wrote: > The first patch pulls the register length calculation into its own > function, and the second adds support for little endian ppc in gdbstub. Thanks, applied to ppc-next. (For some reason your to: mails don't arrive in my inbox, I only see the ML

Re: [Qemu-devel] [Qemu-ppc] [PATCH] mac99: Bring memory layout closer to real hardware

2014-04-11 Thread Alexander Graf
On 20.03.14 11:16, BALATON Zoltan wrote: On Sat, 15 Mar 2014, BALATON Zoltan wrote: Try to better match the memory map of a PowerMac3,1 model by moving the pci-cfg mappings to where they are on a real machine. Also add the VGA card after the macio to let the latter be mapped from 0x8000 to

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Alexey Kardashevskiy
On 04/10/2014 07:24 PM, Daniel P. Berrange wrote: > On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: >> Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: alpha/typhoon.c:b = pci_register_bus(dev, "pci", mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", >>

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Peter Crosthwaite
On Thu, Apr 10, 2014 at 1:48 AM, Markus Armbruster wrote: > I stumbled over this while trying to purge error_is_set() from the code. > > > Here's how we commonly use the Error API: > > Error *err = NULL; > > foo(arg, &err) > if (err) { > goto out; > } > bar(arg, &err) >

[Qemu-devel] commit a87f39543a92 'memory: fix limiting of translation at a page boundary' breaks virtio-scsi for windows 64

2014-04-11 Thread Michael Tokarev
Chris Boot updated his qemu from 1.7.0 to 1.7.1, and noticed that windows guests which was using virtio-scsi does not work anymore. Windows BSODs at boot with the following error: STOP: c221 Unknown Hard Error \StstenRiit\System32\ntdll.dll Collecting data for crash dump ... ... A

[Qemu-devel] [PATCH for-2.0] virtio-net: fix guest-triggerable buffer overrun

2014-04-11 Thread Michael S. Tsirkin
When VM guest programs multicast addresses for a virtio net card, it supplies a 32 bit entries counter for the number of addresses. These addresses are read into tail portion of a fixed macs array which has size MAC_TABLE_ENTRIES, at offset equal to in_use. To avoid overflow of this array by guest

Re: [Qemu-devel] commit a87f39543a92 'memory: fix limiting of translation at a page boundary' breaks virtio-scsi for windows 64

2014-04-11 Thread Laszlo Ersek
On 04/11/14 14:02, Michael Tokarev wrote: > Chris Boot updated his qemu from 1.7.0 to 1.7.1, and noticed that windows > guests > which was using virtio-scsi does not work anymore. Windows BSODs at > boot with the following error: > > > STOP: c221 Unknown Hard Error >\StstenRiit\System

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Eric Blake
On 04/11/2014 05:40 AM, Alexey Kardashevskiy wrote: >> but AFAICT nothing got merged to change this for all the other boards as >> discussed here :-( This is painful for libvirt since we have todo even >> more hacks triggered off machine names now, instead of being able to >> rely on pci.0 naming

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-11 Thread Alexander Graf
On 11.04.14 14:27, Eric Blake wrote: On 04/11/2014 05:40 AM, Alexey Kardashevskiy wrote: but AFAICT nothing got merged to change this for all the other boards as discussed here :-( This is painful for libvirt since we have todo even more hacks triggered off machine names now, instead of being

Re: [Qemu-devel] [PATCH for-2.0] configure: use do_cc when checking for -fstack-protector support

2014-04-11 Thread Alexey Kardashevskiy
On 04/09/2014 09:04 PM, Peter Maydell wrote: > MacOSX clang silently swallows unrecognized -f options when doing a link > with '-framework' also on the command line, so to detect support for > the various -fstack-protector options we must do a plain .c to .o compile, > not a complete compile-and-li

Re: [Qemu-devel] [PATCH v3 13/26] tcg-aarch64: Implement tcg_register_jit

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 84 > +++- > 1 file changed, 69 insertions(+), 15 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > i

Re: [Qemu-devel] [PATCH v3 12/26] tcg-aarch64: Introduce tcg_out_insn_3314

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Combines 4 other inline functions and tidies the prologue. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 100 > --- > 1 file changed, 33 insertions(+), 67 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > It's obviously call-clobbered, but is otherwise unused. > Repurpose it as the TCG temporary. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 34 -- > tcg/aarch64/tcg-target.h | 32

Re: [Qemu-devel] [PATCH v3 26/26] tcg-aarch64: Use tcg_out_mov in preference to tcg_out_movr

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > It's the more canonical interface. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c

Re: [Qemu-devel] [PATCH v3 18/26] tcg-aarch64: Pass qemu_ld/st arguments directly

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Instead of passing them the "args" array. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 49 > +--- > 1 file changed, 17 insertions(+), 32 deletions(-) > > diff --git a/tcg/aarc

Re: [Qemu-devel] [PATCH v3 22/26] tcg-aarch64: Merge aarch64_ldst_get_data/type into tcg_out_op

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 115 > +-- > 1 file changed, 32 insertions(+), 83 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > i

Re: [Qemu-devel] [PATCH v3 24/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType

2014-04-11 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 07.04.2014 16:31, Richard Henderson wrote: > On 04/07/2014 04:45 AM, Claudio Fontana wrote: >> On 03.04.2014 21:56, Richard Henderson wrote: >>> The definition of op_type wasn't encoded for the proper shift for >>> the field, making the implementations confusing. >

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexey Kardashevskiy
On 04/11/2014 07:24 PM, Alexander Graf wrote: > > On 10.04.14 16:43, Alexey Kardashevskiy wrote: >> On 04/10/2014 11:26 PM, Alexander Graf wrote: >>> On 10.04.14 15:24, Alexey Kardashevskiy wrote: On 04/10/2014 10:51 PM, Alexander Graf wrote: > On 14.03.14 05:18, Alexey Kardashevskiy wrot

[Qemu-devel] [PULL 0/4] Block patches for 2.0.0-rc3

2014-04-11 Thread Kevin Wolf
The following changes since commit f516a5cc051db6e999e9e60dc968dcb5aeffe11f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-04-10 23:07:56 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch cha

[Qemu-devel] [PULL 1/4] bochs: Fix memory leak in bochs_open() error path

2014-04-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Laszlo Ersek --- block/bochs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 826ec12..50b84a9 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -150,11 +150,13 @@ static int bochs_open(BlockDri

Re: [Qemu-devel] [PATCH v3 20/26] tcg-aarch64: Support stores of zero

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 35 +++ > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 34e477d..ca

[Qemu-devel] [PULL 2/4] bochs: Fix catalog size check

2014-04-11 Thread Kevin Wolf
The old check was off by a factor of 512 and didn't consider cases where we don't get an exact division. This could lead to an out-of-bounds array access in seek_to_sector(). Signed-off-by: Kevin Wolf Reviewed-by: Laszlo Ersek --- block/bochs.c | 14 +++--- tests/qemu-iotes

Re: [Qemu-devel] [PATCH v3 25/26] tcg-aarch64: Prefer unsigned offsets before signed offsets for ldst

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > The assembler seems to prefer them, perhaps we should too. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aar

Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-11 Thread Claudio Fontana
Just to remember that there is an issue with this, as the previous reviewed-by tag by me might mislead: Nacked-by: Claudio Fontana On 03.04.2014 21:56, Richard Henderson wrote: > Cleaning up the implementation of REV and REV16 at the same time. > > Reviewed-by: Claudio Fontana > Signed-off-by

[Qemu-devel] [PULL 3/4] iscsi: Remember to set ret for iscsi_open in error case

2014-04-11 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index 64a509f..f425573 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverSt

[Qemu-devel] [PULL 4/4] block-commit: speed is an optional parameter

2014-04-11 Thread Kevin Wolf
From: Max Reitz As speed is an optional parameter for the QMP block-commit command, it should be set to 0 if not given (as it is undefined if has_speed is false), that is, the speed should not be limited. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by:

Re: [Qemu-devel] drive_del vs. device_del: what should come first?

2014-04-11 Thread Heinz Graalfs
Hello Markus, I finally managed to reproduce the problem, at least once ... The scenario was: dd if=/dev/vdx1 of=partitionone followed by a virsh detach... (with the device_del() under the cover) during active dd processing dmesg shows: [79026.220718] User process fault: interruption code 0x4

Re: [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case

2014-04-11 Thread Kevin Wolf
Am 11.04.2014 um 07:29 hat Fam Zheng geschrieben: > On Thu, 04/10 13:11, Kevin Wolf wrote: > > Am 10.04.2014 um 03:33 hat Fam Zheng geschrieben: > > > Signed-off-by: Fam Zheng > > > > Thanks, applied to the block branch. > > > > Is this going into 2.0? Looks like we're going to have an -rc3, s

Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP

2014-04-11 Thread Kevin Wolf
Am 10.04.2014 um 16:32 hat Max Reitz geschrieben: > On 08.04.2014 17:14, Kevin Wolf wrote: > >Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: > >>qemu-img should use QMP commands whenever possible in order to ensure > >>feature completeness of both online and offline image operations. As > >>qemu

Re: [Qemu-devel] commit a87f39543a92 'memory: fix limiting of translation at a page boundary' breaks virtio-scsi for windows 64

2014-04-11 Thread Michael Tokarev
11.04.2014 16:02, Michael Tokarev пишет: > Chris Boot updated his qemu from 1.7.0 to 1.7.1, and noticed that windows > guests > which was using virtio-scsi does not work anymore. Windows BSODs at > boot with the following error: > > > STOP: c221 Unknown Hard Error >\StstenRiit\System3

Re: [Qemu-devel] [PATCH 27/26] tcg-aarch64: Introduce tcg_out_insn_3312, _3310, _3313

2014-04-11 Thread Claudio Fontana
On 07.04.2014 20:34, Richard Henderson wrote: > Merge TCGMemOp size, AArch64LdstType type and a few stray opcode bits > into a single I3312_* argument, eliminating some magic numbers from > helper functions. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 129 > +

Re: [Qemu-devel] [PATCH] gtk: Keep the pointer within window during input grab

2014-04-11 Thread Gerd Hoffmann
On Di, 2014-04-08 at 14:46 +0200, Takashi Iwai wrote: > The current code shows annoying behavior where the X pointer can move > out of the window during the input grab in the absolute mode. Due to > this, the pointer in qemu window looks as if frozen until the real > (invisible) X pointer comes ba

Re: [Qemu-devel] [PULL for-2.0 0/2] sdl2: relative mouse mode fixes

2014-04-11 Thread Peter Maydell
On 11 April 2014 11:40, Gerd Hoffmann wrote: > Hi, > > Two sdl2 fixes for relative mouse mode, by Cole Robinson. > > please pull, > Gerd Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH v3 23/26] tcg-aarch64: Replace aarch64_ldst_op_data with TCGMemOp

2014-04-11 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > The definition of op_data included opcode bits, not just > the size field of the various ldst instructions. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 111 > +-- > 1 file cha

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-11 Thread Eric Blake
On 04/11/2014 01:27 AM, Peter Maydell wrote: > On 11 April 2014 02:40, Eric Blake wrote: >> We uncovered a real bug that would be fixed by this patch: >> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01745.html > > No, that's a bug in the called code. The API here defines > that for op

Re: [Qemu-devel] commit a87f39543a92 'memory: fix limiting of translation at a page boundary' breaks virtio-scsi for windows 64

2014-04-11 Thread Laszlo Ersek
On 04/11/14 14:27, Laszlo Ersek wrote: > On 04/11/14 14:02, Michael Tokarev wrote: >> More, the same issue exists on 2.0-tobe as well, but in this case, reverting >> the same commit from there -- a87f39543a9259f671c5413723311180ee2ad2a8 -- >> does NOT fix the problem. I'm bisecting between 1.7.0

Re: [Qemu-devel] [PATCH] gtk: Keep the pointer within window during input grab

2014-04-11 Thread Takashi Iwai
At Fri, 11 Apr 2014 15:07:34 +0200, Gerd Hoffmann wrote: > On Di, 2014-04-08 at 14:46 +0200, Takashi Iwai wrote: > > The current code shows annoying behavior where the X pointer can move > > out of the window during the input grab in the absolute mode. Due to > > this, the pointer in qemu window

Re: [Qemu-devel] [PULL 0/4] Block patches for 2.0.0-rc3

2014-04-11 Thread Peter Maydell
On 11 April 2014 13:39, Kevin Wolf wrote: > The following changes since commit f516a5cc051db6e999e9e60dc968dcb5aeffe11f: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2014-04-10 23:07:56 +0100) > > are available in the git repository at: > > > git://repo.or.

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-11 Thread Peter Maydell
On 11 April 2014 14:11, Eric Blake wrote: > The called code ALSO needs a fix, but guaranteeing that > 'have_foo==false' implies 'foo==0' is MUCH nicer than 'have_foo==false' > implies 'foo is indeterminate'. For this particular caller, an > indeterminate foo had detrimental effects, and a known f

Re: [Qemu-devel] paravirtual mouse/tablet, v5

2014-04-11 Thread Gerd Hoffmann
On Mi, 2011-02-02 at 14:48 +1000, Peter Hutterer wrote: ^^ FYI: It's been a while ... > sorry, late again. conference last week. > > On Thu, Jan 27, 2011 at 02:11:35PM +0100, Gerd Hoffmann wrote: > > Next revision the pvmouse protocol. It is quite different now, I've > > decided t

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-11 Thread Markus Armbruster
Peter Crosthwaite writes: > On Thu, Apr 10, 2014 at 1:48 AM, Markus Armbruster wrote: >> I stumbled over this while trying to purge error_is_set() from the code. >> >> >> Here's how we commonly use the Error API: >> >> Error *err = NULL; >> >> foo(arg, &err) >> if (err) { >>

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexander Graf
On 11.04.2014, at 14:38, Alexey Kardashevskiy wrote: > On 04/11/2014 07:24 PM, Alexander Graf wrote: >> >> On 10.04.14 16:43, Alexey Kardashevskiy wrote: >>> On 04/10/2014 11:26 PM, Alexander Graf wrote: On 10.04.14 15:24, Alexey Kardashevskiy wrote: > On 04/10/2014 10:51 PM, Alexander

Re: [Qemu-devel] [PATCH V2 1/4] vmxnet3: validate interrupt indices coming from guest

2014-04-11 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > CVE-2013-4544 > > Signed-off-by: Dmitry Fleytman > Reported-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert > --- > hw/net/vmxnet3.c | 36 ++-- > 1 file changed, 34

Re: [Qemu-devel] [PATCH V2 2/4] vmxnet3: validate queues configuration coming from quest

2014-04-11 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > CVE-2013-4544 > > Signed-off-by: Dmitry Fleytman > Reported-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- Reviewed-by: Dr. David Alan Gilbert > hw/net/vmxnet3.c | 19 ++- > 1 file changed, 18 insertions(+), 1

Re: [Qemu-devel] [PATCH RFC V2] virtio-net: announce self by guest

2014-04-11 Thread 陈梁
Hi Jason, Have you ever test that adds a bridge on the virtio-net in vm and migrate the vm? The bridge may don't send garp packet(in my testing). BTW, how about the other net devices like e1000 and rtl8139? Is it better that qemu notifys qemu guest agent to force the net devices in the vm to send

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-04-11 Thread Laszlo Ersek
On 03/20/14 20:21, Michael Roth wrote: > Quoting Markus Armbruster (2014-03-18 04:32:08) >> Peter Maydell writes: >> >>> This is something clang's -fsanitize=undefined spotted. The >>> code generated by qapi-commands.py in qmp-marshal.c for >>> qmp_marshal_* functions where there are some optional

Re: [Qemu-devel] [PATCH for-2.0] virtio-net: fix guest-triggerable buffer overrun

2014-04-11 Thread Michael Tokarev
11.04.2014 16:18, Michael S. Tsirkin wrote: > When VM guest programs multicast addresses for > a virtio net card, it supplies a 32 bit > entries counter for the number of addresses. > These addresses are read into tail portion of > a fixed macs array which has size MAC_TABLE_ENTRIES, > at offset eq

Re: [Qemu-devel] [PATCH V2 3/4] vmxnet3: validate interrupt indices read on migration

2014-04-11 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > CVE-2013-4544 > > Signed-off-by: Dmitry Fleytman > Reported-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert Dave > --- > hw/net/vmxnet3.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH V2 4/4] vmxnet3: validate queues configuration read on migration

2014-04-11 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > CVE-2013-4544 > > Signed-off-by: Dmitry Fleytman > Reported-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert > --- > hw/net/vmxnet3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net

Re: [Qemu-devel] [PATCH for-2.0] configure: use do_cc when checking for -fstack-protector support

2014-04-11 Thread Alexey Kardashevskiy
On 04/11/2014 10:34 PM, Alexey Kardashevskiy wrote: > On 04/09/2014 09:04 PM, Peter Maydell wrote: >> MacOSX clang silently swallows unrecognized -f options when doing a link >> with '-framework' also on the command line, so to detect support for >> the various -fstack-protector options we must do

Re: [Qemu-devel] [PATCH V2 0/4] CVE-2013-4544

2014-04-11 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > Changes since V1: > > * Comments added and extended as sugested by Dave and Michael > > Dmitry Fleytman (4): > vmxnet3: validate interrupt indices coming from guest > vmxnet3: validate queues configuration coming from quest > vmxnet3: validate

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexey Kardashevskiy
On 04/11/2014 11:58 PM, Alexander Graf wrote: > > On 11.04.2014, at 14:38, Alexey Kardashevskiy wrote: > >> On 04/11/2014 07:24 PM, Alexander Graf wrote: >>> >>> On 10.04.14 16:43, Alexey Kardashevskiy wrote: On 04/10/2014 11:26 PM, Alexander Graf wrote: > On 10.04.14 15:24, Alexey Kard

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexander Graf
On 11.04.14 16:50, Alexey Kardashevskiy wrote: On 04/11/2014 11:58 PM, Alexander Graf wrote: On 11.04.2014, at 14:38, Alexey Kardashevskiy wrote: On 04/11/2014 07:24 PM, Alexander Graf wrote: On 10.04.14 16:43, Alexey Kardashevskiy wrote: On 04/10/2014 11:26 PM, Alexander Graf wrote: On 1

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexey Kardashevskiy
On 04/12/2014 12:58 AM, Alexander Graf wrote: > > On 11.04.14 16:50, Alexey Kardashevskiy wrote: >> On 04/11/2014 11:58 PM, Alexander Graf wrote: >>> On 11.04.2014, at 14:38, Alexey Kardashevskiy wrote: >>> On 04/11/2014 07:24 PM, Alexander Graf wrote: > On 10.04.14 16:43, Alexey Kardash

Re: [Qemu-devel] [PATCH for-2.0] configure: use do_cc when checking for -fstack-protector support

2014-04-11 Thread Peter Maydell
On 11 April 2014 15:33, Alexey Kardashevskiy wrote: > On 04/12/2014 12:24 AM, Alexey Kardashevskiy wrote: >> This helps. No idea why. Any ideas? :) >> >> @@ -1448,7 +1452,7 @@ done >> if test "$stack_protector" != "no" ; then >>gcc_flags="-fstack-protector-strong -fstack-protector-all" >>

Re: [Qemu-devel] [Qemu-ppc] [RFC 00/12] target-ppc: Decimal Floating Point

2014-04-11 Thread Alexander Graf
On 13.03.14 16:12, Tom Musta wrote: This patch series provides a prototype of Decimal Floating Point (DFP) instruction support in QEMU. The topic was briefly discussed here: http://lists.nongnu.org/archive/html/qemu-ppc/2014-02/msg00129.html I. Overview The core of the DFP model is a librar

Re: [Qemu-devel] [PATCH 0/2] ivshmem: validate incoming_posn value from server

2014-04-11 Thread Andreas Färber
Am 31.03.2014 09:08, schrieb Stefan Hajnoczi: > ivshmem can talk to a server over a UNIX domain socket on the host. We should > validate inputs from the server to prevent crashes or memory corruption. > > Stefan Hajnoczi (2): > ivshmem: check ivshmem_read() size argument > ivshmem: validate i

Re: [Qemu-devel] [PATCH v8 2/4] qapi: [trivial] Show full exception message in "test-qapi.py"

2014-04-11 Thread Markus Armbruster
Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova > --- > tests/qapi-schema/test-qapi.py |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py > index b3d1e1d..ac6da13 100644 > --- a/tests/qapi-schema

Re: [Qemu-devel] [PATCH 6/8] spapr: move interrupt allocator to xics

2014-04-11 Thread Alexander Graf
On 11.04.14 17:27, Alexey Kardashevskiy wrote: On 04/12/2014 12:58 AM, Alexander Graf wrote: On 11.04.14 16:50, Alexey Kardashevskiy wrote: On 04/11/2014 11:58 PM, Alexander Graf wrote: On 11.04.2014, at 14:38, Alexey Kardashevskiy wrote: On 04/11/2014 07:24 PM, Alexander Graf wrote: On 1

Re: [Qemu-devel] [PATCH for-2.0] virtio-net: fix guest-triggerable buffer overrun

2014-04-11 Thread Peter Maydell
On 11 April 2014 15:21, Michael Tokarev wrote: > 11.04.2014 16:18, Michael S. Tsirkin wrote: >> When VM guest programs multicast addresses for >> a virtio net card, it supplies a 32 bit >> entries counter for the number of addresses. >> These addresses are read into tail portion of >> a fixed macs

[Qemu-devel] [PATCH v4 02/25] tcg-aarch64: Use intptr_t apropriately

2014-04-11 Thread Richard Henderson
As opposed to tcg_target_long. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 661a5af..6938248 100644 --- a/tcg/aa

[Qemu-devel] [PATCH v4 04/25] tcg-aarch64: Use MOVN in tcg_out_movi

2014-04-11 Thread Richard Henderson
When profitable, initialize the register with MOVN instead of MOVZ, before setting the remaining lanes with MOVK. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 63 ++-- 1 file changed, 50 insertions(+), 1

[Qemu-devel] [PATCH v4 06/25] tcg-aarch64: Special case small constants in tcg_out_movi

2014-04-11 Thread Richard Henderson
Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index c1d9895..a08f6c7 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target

[Qemu-devel] [PATCH v4 01/25] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-11 Thread Richard Henderson
Since the kernel doesn't pass any info on the reason for the fault, disassemble the instruction to detect a store. Signed-off-by: Richard Henderson --- user-exec.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/user-exec.c b/user-exec.c index b

[Qemu-devel] [PATCH v4 12/25] tcg-aarch64: Introduce tcg_out_insn_3314

2014-04-11 Thread Richard Henderson
Combines 4 other inline functions and tidies the prologue. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 100 --- 1 file changed, 33 insertions(+), 67 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b

[Qemu-devel] [PATCH v4 07/25] tcg-aarch64: Use adrp in tcg_out_movi

2014-04-11 Thread Richard Henderson
Loading an qemu pointer as an immediate happens often. E.g. - exit_tb $0x7fa8140013 + exit_tb $0x7f81ee0013 ... - : d2800260mov x0, #0x13 - : f2b50280movkx0, #0xa814, lsl #16 - : f2c00fe0movkx0, #0x7f, lsl #32 + : 90ff1000adrpx0, 0x7f81ee +

  1   2   >