Re: [Qemu-devel] [RFC PATCH 7/7] target-arm: Hacky implementation of kvm_arch_reset_vcpu() for KVM ARM64

2014-03-14 Thread Pranavkumar Sawargaonkar
Hi Christoffer, On 14 March 2014 09:21, Christoffer Dall wrote: > On Thu, Feb 27, 2014 at 04:05:04PM +0530, Pranavkumar Sawargaonkar wrote: >> Hi Peter, >> >> On 27 February 2014 15:23, Peter Maydell wrote: >> > On 27 February 2014 06:51, Pranavkumar Sawargaonkar >> > wrote: >> >> We need to "F

Re: [Qemu-devel] [PATCH v2 1/9] qapi: Add optional field "name" to block dirty bitmap

2014-03-14 Thread Fam Zheng
On Thu, 03/13 14:15, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:30:56 (+0800), Fam Zheng wrote : > > This field will be set for user created dirty bitmap. Also pass in an > > error pointer to bdrv_create_dirty_bitmap, so when a name is already > > taken on this BDS, it can report an error

Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-14 Thread Fam Zheng
On Thu, 03/13 14:26, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:30:57 (+0800), Fam Zheng wrote : > > The new command pair is added to manage user created dirty bitmap. The > > dirty bitmap's name is mandatory and must be unique for the same device, > > but different devices can have bitma

Re: [Qemu-devel] [PATCH 7/8] spapr: remove @next_irq

2014-03-14 Thread Thomas Huth
On Fri, 14 Mar 2014 15:18:08 +1100 Alexey Kardashevskiy wrote: > This removes @next_irq from sPAPREnvironment which was used in old > IRQ allocator as XICS is now responsible for IRQs and keep track of > allocated IRQs. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr.c | 3

Re: [Qemu-devel] [PATCH v2 7/9] qmp: Add dirty-bitmap-enable and dirty-bitmap-disable

2014-03-14 Thread Fam Zheng
On Thu, 03/13 14:55, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:31:02 (+0800), Fam Zheng wrote : > > This allows to put the dirty bitmap into a disabled state where no more > > writes will be tracked. > > > > It will be used before backup or writing to persistent file. > > > > Signed-of

Re: [Qemu-devel] [PATCH v2 8/9] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-03-14 Thread Fam Zheng
On Thu, 03/13 15:32, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:31:03 (+0800), Fam Zheng wrote : > > For "dirty-bitmap" sync mode, the block job will iterate through the > > given dirty bitmap to decide if a sector needs backup (backup all the > > dirty clusters and skip clean ones), just

[Qemu-devel] VNC viewer displays nothing with -enable-kvm but works fine without -enable-kvm

2014-03-14 Thread Le Tan
Hi, I used qemu-kvm-1.2.0 before. I can run qemu with kvm well. Two days ago, I updated qemu to qemu-1.6.2, and start the qemu with the command: qemu-system-x86_64 -m 2048 -smp 4 -hda /home/tanle/study/new.img -nographic -vnc 162.105.146.118:2 It works fine and slow. It is obviously not using the k

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 03/13 14:25, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Wed, 03/12 18:00, Markus Armbruster wrote: >> >> Opening an encrypted image takes an additional step: setting the key. >> >> Between open and the key set, the image must not be used. >> >> >> >> W

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Markus Armbruster
Paolo Bonzini writes: > Il 13/03/2014 16:00, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Il 13/03/2014 14:18, Markus Armbruster ha scritto: Paolo Bonzini writes: > Il 12/03/2014 18:00, Markus Armbruster ha scritto: >> +} else if (!runstate_check(RUN_STATE

[Qemu-devel] [PATCH v2 for-2.0] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Markus Armbruster
Opening an encrypted image takes an additional step: setting the key. Between open and the key set, the image must not be used. We have some protection against accidental use in place: you can't unpause a guest while we're missing keys. You can, however, hot-plug block devices lacking keys into a

[Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean"

2014-03-14 Thread Fam Zheng
DANGEROUS: don't try it before you read to the end. A first "make distclean" will unset $(DSOSUF), a following "make distclean" or "make clean" will find all the files and delete it. Including all the files in the .git directory! Fix it by only do it when $(DSOSUF) is not empty. Signed-off-by:

Re: [Qemu-devel] [PATCH 7/8] trace: [simple] Bump up log version number

2014-03-14 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 03:42:19PM +0100, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Sun, Feb 23, 2014 at 08:37:35PM +0100, Lluís Vilanova wrote: > >> The following tracetool cleanup changes the event numbering policy. > >> > >> Signed-off-by: Lluís Vilanova > >> --- > >> scripts/s

Re: [Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-14 Thread Igor Mammedov
On Thu, 13 Mar 2014 15:01:16 -0400 "Gabriel L. Somlo" wrote: > On Thu, Mar 13, 2014 at 04:36:12PM +0100, Igor Mammedov wrote: > > > > After memory hotplug is in I might add e820 entries after above_4g > > for present at boot hotpluggable DIMMDevices. They would have 1:1 mapping > > i.e. t19<-t20

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread James Hogan
Hi Andreas, On 13/03/14 21:28, Andreas Färber wrote: >> diff --git a/target-mips/kvm.c b/target-mips/kvm.c >> new file mode 100644 >> index 000..0ec343d >> --- /dev/null >> +++ b/target-mips/kvm.c > [...] >> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int32 >> *addr) >

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread James Hogan
On 13/03/14 22:35, Peter Maydell wrote: > On 13 March 2014 21:28, Andreas Färber wrote: >> I'm not sure if we have a policy about __u64 etc. in KVM code. Since >> it'll be Linux-only I don't see problems currently; for cross-platform >> parts we prefer uint64_t. Suggest to leave as is unless told

Re: [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes

2014-03-14 Thread Gerd Hoffmann
On Do, 2014-03-13 at 15:30 -0400, Cole Robinson wrote: > First patch documents a configure option. > Next 3 patches fix deprecation warnings on gtk 3.10. > The remaining patches are bug fixes. > > v2: > Add configure patch > Fix building against GTK2 I'll go cherry-pick the two warp bugfi

[Qemu-devel] [PULL 0/3] gtk fixes.

2014-03-14 Thread Gerd Hoffmann
Hi, gtk pull second round, this time a bit shorter as I've dropped the cleanup patches. Lesson learned: getting them right so we still build on all supported gtk2+3 versions isn't that easy. There is no reason to rush them, so lets sort that after 2.0 is out of the door. please pull, Gerd

[Qemu-devel] [PULL 1/3] gtk: Allow to activate grab-on-hover from the command line

2014-03-14 Thread Gerd Hoffmann
From: Jan Kiszka As long as we have no persistent GTK configuration, this allows to enable the useful grab-on-hover feature already when starting the VM. Signed-off-by: Jan Kiszka Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- qemu-options.hx | 5 + ui/gtk.c

[Qemu-devel] [PULL 3/3] gtk: Don't warp absolute pointer

2014-03-14 Thread Gerd Hoffmann
From: Cole Robinson This matches the behavior of SDL, and makes the mouse usable when using -display gtk -vga qxl https://bugzilla.redhat.com/show_bug.cgi?id=1051724 Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 1 file changed, 8 insertions(+) diff --gi

[Qemu-devel] [PULL 2/3] gtk: Fix mouse warping with gtk3

2014-03-14 Thread Gerd Hoffmann
From: Cole Robinson We were using the wrong coordinates, this fixes things to match the original gtk2 implementation. You can see this error in action by using -vga qxl, however even after this patch the mouse warps in small increments up and to the left, -7x and -3y pixels at a time, until the

[Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants

2014-03-14 Thread Jeff Cody
On 32-bit hosts, some compilers will warn on too large integer constants for constants that are 64-bit in length. Explicitly put a 'ULL' suffix on those defines. Reported-by: Alexander Graf Signed-off-by: Jeff Cody --- block/vhdx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-14 Thread Gerd Hoffmann
On Do, 2014-03-13 at 10:08 +0100, Gerd Hoffmann wrote: > Hi, > > > One thing to do is add this to the virtio spec. > > Need help with that? > > What is the authoritative spec these days? > The virtio 1.0 draft? > Where can I find the latest revision? Seems to be this: https://github.com/rusty

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-14 Thread Gerd Hoffmann
Hi, > Perhaps a configuration field is better, like this: > > u32 events_read; > u32 events_clear; > > A new event sets a bit in events_read and generates a configuration > change interrupt. The guest should never write to events_read. Makes sense to me. I think I'll go write up

Re: [Qemu-devel] [PULL 073/130] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2014-03-14 Thread Paolo Bonzini
Il 07/03/2014 00:33, Alexander Graf ha scritto: +if (bd.flags | BD_INTERRUPT) { +/* Set RXFx */ +etsec->regs[RSTAT].value |= 1 << (7 - ring_nbr); + +/* Set IEVENT */ +ievent_set(etsec, IEVENT_RXF); +

Re: [Qemu-devel] [PULL 125/130] target-ppc: Fix page table lookup with kvm enabled

2014-03-14 Thread Paolo Bonzini
Il 07/03/2014 00:34, Alexander Graf ha scritto: @@ -105,30 +106,37 @@ static target_ulong h_enter(PowerPCCPU *cpu, sPAPREnvironment *spapr, if (!valid_pte_index(env, pte_index)) { return H_PARAMETER; } + +index = 0; +hpte = pte_index * HASH_PTE_SIZE_64; if (likely

Re: [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes

2014-03-14 Thread Cole Robinson
On 03/14/2014 05:48 AM, Gerd Hoffmann wrote: > On Do, 2014-03-13 at 15:30 -0400, Cole Robinson wrote: >> First patch documents a configure option. >> Next 3 patches fix deprecation warnings on gtk 3.10. >> The remaining patches are bug fixes. >> >> v2: >> Add configure patch >> Fix building

[Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type

2014-03-14 Thread mrezanin
From: Miroslav Rezanina Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the

[Qemu-devel] [PATCH] qemu-doc.texi: Replace remaining obsolete -M option

2014-03-14 Thread mrezanin
From: Miroslav Rezanina When -M option was deprecated (commit 80f52a6) and removed from documentation, two occurrencies were not updated corectly. Fixing them. Signed-off-by: Miroslav Rezanina --- qemu-doc.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-doc.te

Re: [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes

2014-03-14 Thread Gerd Hoffmann
Hi, > Hmm, thanks for testing. I didn't notice the GDK_KEY_foo back compat defines > at the top of gtk.c, we need one for GDK_KEY_q as well. > > Would you prefer I wait until after 2.0 is out to resubmit the series? I don't mind much, do whatever works best for you. Most likely there are no c

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean"

2014-03-14 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 04:38:20PM +0800, Fam Zheng wrote: > DANGEROUS: don't try it before you read to the end. > > A first "make distclean" will unset $(DSOSUF), a following "make > distclean" or "make clean" will find all the files and delete it. > > Including all the files in the .git directo

[Qemu-devel] Coverity scan successes

2014-03-14 Thread Paolo Bonzini
Hi all, I'm happy to announce that the number of outstanding Coverity-reported defects in QEMU is now down to 0.33 per 1000 lines of code. This is half the average defect density for open source project (0.69) and also lower than the average defect density for projects in the 500k-1M SLOC ra

Re: [Qemu-devel] [PATCH v2 for-2.0] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Eric Blake
On 03/14/2014 02:22 AM, Markus Armbruster wrote: > Opening an encrypted image takes an additional step: setting the key. > Between open and the key set, the image must not be used. > > We have some protection against accidental use in place: you can't > unpause a guest while we're missing keys. Y

Re: [Qemu-devel] Problems compiling HEAD on Mac OS X 10.9.2

2014-03-14 Thread Paolo Bonzini
Il 13/03/2014 19:48, Peter Maydell ha scritto: Yep, here we are: LIBSSH2_LIBS=-L/opt/local/lib -lssh2 -Wl,-headerpad_max_install_names -arch x86_64 CURL_LIBS=-L/opt/local/lib -lcurl rules.mak is incorrectly reordering the contents of these and generating a non-working mess. Fam, is the $(sort

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Paolo Bonzini
Il 13/03/2014 22:49, Richard W.M. Jones ha scritto: I got fstrim happily working in Fedora 20, but it's not working with the upstream kernel. The message is: fstrim -v /sysroot/ [ 45.541339] sda: WRITE SAME failed. Manually zeroing. /sysroot/: 47.2 MiB (49466368 bytes) trimmed While th

Re: [Qemu-devel] [PATCH for-2.0] rules.mak: Fix per object libs extraction

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 03:21, Fam Zheng ha scritto: Don't sort the extracted options, sort the objects. Reported-by: Christian Mahnke Signed-off-by: Fam Zheng --- rules.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules.mak b/rules.mak index 9dda9f7..5c454d8 100644 --- a

Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-14 Thread Eric Blake
On 03/14/2014 01:18 AM, Fam Zheng wrote: >>> >>> +void qmp_dirty_bitmap_add(const char *device, const char *name, >> Do we want this to work on node-names too ? > > I think having dirty bitmap on device is good enough for now. If there is a > necessity we can add on top. How would anything oth

Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type

2014-03-14 Thread Eric Blake
On 03/14/2014 06:06 AM, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu >

Re: [Qemu-devel] [PATCH] qemu-doc.texi: Replace remaining obsolete -M option

2014-03-14 Thread Eric Blake
On 03/14/2014 06:08 AM, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > When -M option was deprecated (commit 80f52a6) and removed from documentation, > two occurrencies were not updated corectly. Fixing them. s/occurrencies/occurrences/ s/corectly/correctly/ > > Signed-off-by: Mirosl

Re: [Qemu-devel] [PATCH] scsi: Fix migration of scsi sense data

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 06:58, Fam Zheng ha scritto: Ping. Should we take this in 2.0? Of course, I'll send it for 2.0-rc1. Paolo

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-03-14 Thread Jeff Cody
On Wed, Mar 12, 2014 at 12:16:04PM +0100, Kevin Wolf wrote: > Am 24.01.2014 um 14:48 hat Jeff Cody geschrieben: > > On Fri, Jan 24, 2014 at 02:33:19PM +0100, Kevin Wolf wrote: > > > Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: > > > > Having both read-only=on and snapshot=on together does not

[Qemu-devel] [PULL 0/3] SCSI changes for 2.0-rc1

2014-03-14 Thread Paolo Bonzini
The following changes since commit 5d92c74f8a1728a202ba9457872ab0f27ff15e81: Update version for v2.0-rc0 (2014-03-13 20:08:15 -0700) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to aa7a6a399f8253d3831465b1db8544032b49f57a:

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2014 at 01:30:40PM +0100, Paolo Bonzini wrote: > Il 13/03/2014 22:49, Richard W.M. Jones ha scritto: > >- Is there any reason why virtio-scsi doesn't emulate WRITE SAME? > > Yes, the reason is that you're using QEMU 1.7. :) > > >- Can you see where ext4 issues the zeroout/write sa

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 13:42, Richard W.M. Jones ha scritto: I worked around this in any case by rearranging the test [2]: Doing: rm /a_big_file fstrim / sync umount / [shut down qemu] would only trim 64 KB on the host. Doing: rm /a_big_file umount / # added mo

[Qemu-devel] [PATCH v4 05/10] kvm: Allow arch to set sigmask length

2014-03-14 Thread James Hogan
MIPS/Linux is unusual in having 128 signals rather than just 64 like most other architectures. This means its sigmask is 16 bytes instead of 8, so allow arches to override the sigmask->len value passed to the KVM_SET_SIGNAL_MASK ioctl in kvm_set_signal_mask() by calling kvm_set_sigmask_len() from k

[Qemu-devel] [PATCH v4 01/10] hw/mips/cputimer: Don't start periodic timer in KVM mode

2014-03-14 Thread James Hogan
From: Sanjay Lal Compare/Count timer interrupts are handled in-kernel for KVM, so don't bother starting it in QEMU. Signed-off-by: Sanjay Lal Signed-off-by: James Hogan Reviewed-by: Aurelien Jarno --- Changes in v2: - Expand commit message - Rebase on v1.7.0 - Wrap comment --- hw/mips/cpu

[Qemu-devel] [PATCH v4 07/10] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls

2014-03-14 Thread James Hogan
From: Sanjay Lal COP0 emulation is in-kernel for KVM, so inject IRQ2 (I/O) interrupts via ioctls. Signed-off-by: Sanjay Lal Signed-off-by: James Hogan Reviewed-by: Aurelien Jarno Reviewed-by: Andreas Färber --- Changes in v3: - Pass MIPSCPU to kvm_mips_set_[ipi_]interrupt (Andreas Färber).

[Qemu-devel] [PATCH v4 03/10] target-mips: get_physical_address: Add defines for segment bases

2014-03-14 Thread James Hogan
Add preprocessor definitions for 32bit segment bases for use in get_physical_address(). These will also be taken advantage of in the next patch which adds KVM awareness. Signed-off-by: James Hogan Reviewed-by: Aurelien Jarno --- target-mips/helper.c | 18 -- 1 file changed, 12 i

[Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-14 Thread James Hogan
I'd like to have this squeezed into 2.0 (if at all possible), so any final review from KVM people would be much appreciated. Thanks to everybody who has already taken part in review. This patchset implements KVM support for MIPS32 processors, using Trap & Emulation. In KVM mode, CPU virtualizat

[Qemu-devel] [PATCH v4 02/10] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA

2014-03-14 Thread James Hogan
From: Sanjay Lal Add APIs for converting between KVM guest KSEG0 addresses and guest physical addresses. These will be used for translating addresses when loading a kernel ELF in KVM mode. In KVM trap and emulate mode both the guest kernel and guest userspace execute in useg: Guest User addr

[Qemu-devel] [PATCH v4 08/10] hw/mips: malta: Add KVM support

2014-03-14 Thread James Hogan
In KVM mode the bootrom is loaded and executed from the last 1MB of DRAM. Based on "[PATCH 12/12] KVM/MIPS: General KVM support and support for SMP Guests" by Sanjay Lal . Signed-off-by: James Hogan Reviewed-by: Aurelien Jarno Cc: Peter Maydell Cc: Sanjay Lal --- Changes in v3: - Remove unne

[Qemu-devel] [PATCH v4 10/10] MAINTAINERS: Add entry for MIPS KVM

2014-03-14 Thread James Hogan
Add MAINTAINERS entry for MIPS KVM. Signed-off-by: James Hogan --- Changes in v4: - Add MAINTAINERS entry for MIPS KVM. --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d17f83..cefe1a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -169,6

[Qemu-devel] [PATCH v4 09/10] target-mips: Enable KVM support in build system

2014-03-14 Thread James Hogan
From: Sanjay Lal Enable KVM support for MIPS in the build system. Signed-off-by: Sanjay Lal Signed-off-by: James Hogan Reviewed-by: Aurelien Jarno --- Changes in v2: - Expand commit message - Remove GIC code - Create asm-mips symlink using generic code and move above default case (Peter

Re: [Qemu-devel] [PATCH v2 for-2.0] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 09:22, Markus Armbruster ha scritto: Opening an encrypted image takes an additional step: setting the key. Between open and the key set, the image must not be used. We have some protection against accidental use in place: you can't unpause a guest while we're missing keys. You can

[Qemu-devel] [PATCH v4 06/10] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread James Hogan
From: Sanjay Lal Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal Signed-off-by: James Hogan Cc: Aurelien Jarno Cc: Gleb Natapov Cc: Paolo Bonzini Cc: Andreas Färber Cc: Peter Maydell --- Changes in v4: (No functional changes, assembly output unchanged) - Use int32_t i

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread Paolo Bonzini
Il 13/03/2014 23:35, Peter Maydell ha scritto: > I'm not sure if we have a policy about __u64 etc. in KVM code. Since > it'll be Linux-only I don't see problems currently; for cross-platform > parts we prefer uint64_t. Suggest to leave as is unless told otherwise. For ARM I took the view that __

[Qemu-devel] [PATCH v4 04/10] target-mips: get_physical_address: Add KVM awareness

2014-03-14 Thread James Hogan
MIPS KVM trap & emulate mode (which is currently the only supported mode) has to add an extra kseg0/kseg1 at 0x4000 and an extra kseg2/kseg3 at 0x6000. Take this into account in get_physical_address() so that debug memory access works. This is done by translating the address to a standard

Re: [Qemu-devel] [PULL 125/130] target-ppc: Fix page table lookup with kvm enabled

2014-03-14 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 07/03/2014 00:34, Alexander Graf ha scritto: >> @@ -105,30 +106,37 @@ static target_ulong h_enter(PowerPCCPU *cpu, >> sPAPREnvironment *spapr, >> if (!valid_pte_index(env, pte_index)) { >> return H_PARAMETER; >> } >> + >> +index = 0; >> +hpte

Re: [Qemu-devel] [PULL 125/130] target-ppc: Fix page table lookup with kvm enabled

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 14:13, Aneesh Kumar K.V ha scritto: diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index e999bbaea062..e079be050fc7 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -118,7 +118,8 @@ static target_ulong h_enter(PowerPCCPU *cpu, sPAPREnvironment *spapr,

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2014 at 01:47:59PM +0100, Paolo Bonzini wrote: > Il 14/03/2014 13:42, Richard W.M. Jones ha scritto: > >I worked around this in any case by rearranging the test [2]: > > > >Doing: > > > > rm /a_big_file > > fstrim / > > sync > > umount / > > [shut down qemu] > > > >would only t

Re: [Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-14 Thread Peter Maydell
On 14 March 2014 12:47, James Hogan wrote: > I'd like to have this squeezed into 2.0 (if at all possible), so any > final review from KVM people would be much appreciated. Unfortunately we're already in hardfreeze, which means bug fixes only at this point. I don't think we can really justify putt

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Paolo Bonzini
Il 14/03/2014 14:24, Richard W.M. Jones ha scritto: > Could be a race condition (something going on in the background > between rm and fstrim). Not much happens in the libguestfs appliance. There are usually only two processes (udev + guestfsd). There's also the kernel. The ext4 driver is pr

Re: [Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-14 Thread James Hogan
On 14/03/14 13:27, Peter Maydell wrote: > On 14 March 2014 12:47, James Hogan wrote: >> I'd like to have this squeezed into 2.0 (if at all possible), so any >> final review from KVM people would be much appreciated. > > Unfortunately we're already in hardfreeze, which means > bug fixes only at th

Re: [Qemu-devel] fstrim & upstream kernel not working

2014-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2014 at 02:28:24PM +0100, Paolo Bonzini wrote: > Il 14/03/2014 14:24, Richard W.M. Jones ha scritto: > >>> Could be a race condition (something going on in the background > >>> between rm and fstrim). > >Not much happens in the libguestfs appliance. There are usually only > >two pr

[Qemu-devel] [PATCH] target-ppc: Fix h_enter to loop correctly

2014-03-14 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" We wanted to loop till index is 8. On 8 we return with H_PTEG_FULL. If we are successful in loading hpte with any other index, we continue with that index value. Reported-by: Paolo Bonzini Signed-off-by: Aneesh Kumar K.V --- hw/ppc/spapr_hcall.c | 11 +-- 1 fi

[Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

2014-03-14 Thread Aakriti Gupta
This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() (error_setg() is part of error reporting API in include/qapi/error.h) Signed-off-by: Aakriti Gupta --- block/qed.c | 8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/VERSION b/VERSION i

Re: [Qemu-devel] [RFC PATCH 6/7] hw/arm/virt: Use PSCI v0.2 function IDs when kernel supports its

2014-03-14 Thread Mark Rutland
On Fri, Mar 14, 2014 at 06:53:53AM +, Pranavkumar Sawargaonkar wrote: > Hi Christoffer, > > On 14 March 2014 09:19, Christoffer Dall wrote: > > On Thu, Feb 27, 2014 at 12:21:07PM +0530, Pranavkumar Sawargaonkar wrote: > >> If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then > >

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc0 is now available

2014-03-14 Thread Riku Voipio
On Thu, Mar 13, 2014 at 08:19:48PM -0700, Anthony Liguori wrote: > Please add entries to the ChangeLog for the 2.0 release below: > http://wiki.qemu.org/ChangeLog/Next I could do some updates for linux-user - but how does one get an account to edit on wiki.l.o ? Riku

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-03-14 Thread Peter Maydell
On 27 February 2014 13:20, Michael Matz wrote: > On Wed, 26 Feb 2014, Dann Frazier wrote: >> I've narrowed down the changes that seem to prevent both types of >> segfaults to the following changes that introduce a wrapper around >> sigprocmask: >> >> https://github.com/susematz/qemu/commit/f1542ae

Re: [Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

2014-03-14 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 06:05:47PM +0530, Aakriti Gupta wrote: > This patch converts fprintf() calls to error_setg() in > block/qed.c:bdrv_qed_create() > (error_setg() is part of error reporting API in include/qapi/error.h) > > Signed-off-by: Aakriti Gupta > --- > block/qed.c | 8 > 1 f

Re: [Qemu-devel] [PATCH] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

2014-03-14 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 06:05:47PM +0530, Aakriti Gupta wrote: > @@ -650,18 +650,18 @@ static int bdrv_qed_create(const char *filename, > QEMUOptionParameter *options, I just noticed that the email is line-wrapped. Please do not copy-paste patches into GMail. The GMail web interface always wraps

Re: [Qemu-devel] qemu patch for adding functionality to rtas_ibm_get_system_parameter [Version 2]

2014-03-14 Thread Mike Day
Tomohiro B Berry writes: > Hi again, > > I believe I have added the appropriate format changes and made a couple > changes to the code. This patch should add functionality to the function > rtas_ibm_get_system_parameter to return a string containing the values for > partition_max_entitled_ca

[Qemu-devel] [PATCH 1/2] linux-user: Add wrapper for guest uses of sigprocmask function

2014-03-14 Thread Peter Maydell
From: Alex Barcelo Create a wrapper for signal mask changes initiated by the guest; (this includes syscalls and also the sigreturns from signal.c) this will give us a place to put code which prevents the guest from changing the handling of signals used by QEMU itself internally. The wrapper is c

[Qemu-devel] [PATCH 1/2] signal: added a wrapper for sigprocmask function

2014-03-14 Thread Peter Maydell
From: Alex Barcelo Create a wrapper for signal mask changes initiated by the guest; (this includes syscalls and also the sigreturns from signal.c) this will give us a place to put code which prevents the guest from changing the handling of signals used by QEMU itself internally. The wrapper is c

[Qemu-devel] [PATCH 0/2] linux-user: Don't allow guest to block SIGSEGV

2014-03-14 Thread Peter Maydell
QEMU uses SIGSEGV for its own purposes (notably for detection of guest writes to pages marked read-only because we have cached translated code from them), so allowing the guest to block SIGSEGV is a bad idea. Instead we wrap sigprocmask() uses for guest-derived signal masks and just track whether t

[Qemu-devel] [PATCH 2/2] linux-user: Don't allow guest to block SIGSEGV

2014-03-14 Thread Peter Maydell
Don't allow the linux-user guest to block SIGSEGV -- QEMU needs this signal to detect accesses to pages which it has marked read-only because it has cached translated code from them. We implement this by making the do_sigprocmask() wrapper suppress SIGSEGV when doing the host process signal mask m

[Qemu-devel] [trivial PATCH 2.0 0/1] silence invalid cyrus-sasl warning on startup

2014-03-14 Thread Laszlo Ersek
Here's a patch that suits my mental capabilities on this Friday afternoon. Laszlo Ersek (1): sasl: Avoid 'Could not find keytab file' in syslog qemu.sasl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.8.3.1

[Qemu-devel] [trivial PATCH 2.0 1/1] sasl: Avoid 'Could not find keytab file' in syslog

2014-03-14 Thread Laszlo Ersek
The "keytab" specification in "qemu.sasl" only makes sense if "gssapi" is selected in "mech_list". Even if the latter is not done (ie. "gssapi" is not selected), the cyrus-sasl library tries to open the specified keytab file, although nothing has a use for it outside the gssapi backend. Since the

Re: [Qemu-devel] [trivial PATCH 2.0 1/1] sasl: Avoid 'Could not find keytab file' in syslog

2014-03-14 Thread Cole Robinson
On 03/14/2014 10:39 AM, Laszlo Ersek wrote: > The "keytab" specification in "qemu.sasl" only makes sense if "gssapi" is > selected in "mech_list". Even if the latter is not done (ie. "gssapi" is > not selected), the cyrus-sasl library tries to open the specified keytab > file, although nothing has

Re: [Qemu-devel] [PATCH V2 3/3] qemu-iotests: Add 088 new test for drive-mirror-replace.

2014-03-14 Thread Benoît Canet
The Thursday 13 Mar 2014 à 22:31:01 (+0100), Max Reitz wrote : > On 11.03.2014 22:53, Benoît Canet wrote: > >Tests for drive-mirror-replace whose purpose is to enable quorum file > >mirroring > >and replacement after failure. > > > >Signed-off-by: Benoit Canet > >--- > > tests/qemu-iotests/041

Re: [Qemu-devel] [PATCH V2 2/3] block: Add drive-mirror-replace command to repair quorum files.

2014-03-14 Thread Benoît Canet
The Thursday 13 Mar 2014 à 21:50:52 (+0100), Max Reitz wrote : > On 11.03.2014 22:53, Benoît Canet wrote: > >When a quorum file is totally destroyed (broken NAS or SAN) the user can > >start a > >drive-mirror job on the quorum block backend and then replace the broken > >quorum file with drive-mir

[Qemu-devel] [PATCH 0/2] dataplane: fix bogus coverity warnings

2014-03-14 Thread Stefan Hajnoczi
Coverity detects when variable are accessed under a mutex most of the time. It warns when they are not accessed under the mutex. I initialized variables before the mutex and threads that access them even exist - Coverity doesn't like that. Fix the code. Stefan Hajnoczi (2): iothread: fix bogu

Re: [Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-14 Thread Gabriel Somlo
On Fri, Mar 14, 2014 at 10:28:30AM +0100, Igor Mammedov wrote: > On Thu, 13 Mar 2014 15:01:16 -0400 > "Gabriel L. Somlo" wrote: > > > On Thu, Mar 13, 2014 at 04:36:12PM +0100, Igor Mammedov wrote: > > > > > > After memory hotplug is in I might add e820 entries after above_4g > > > for present at

[Qemu-devel] [PATCH 1/2] iothread: fix bogus coverity warning

2014-03-14 Thread Stefan Hajnoczi
Coverity warns about initializing variables that will later be accessed under a mutex. There is no problem with the code itself but let's avoid accumulating Coverity warnings. Signed-off-by: Stefan Hajnoczi --- iothread.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/i

[Qemu-devel] [PATCH 2/4] s390x/cpu hotplug: Fix memory leak

2014-03-14 Thread Christian Borntraeger
valgrind complains about the following: ==42117== 8 bytes in 1 blocks are definitely lost in loss record 88 of 833 ==42117==at 0x4031AFE: malloc (vg_replace_malloc.c:292) ==42117==by 0x8022F855: malloc_and_trace (vl.c:2715) ==42117==by 0x4145569: g_malloc (in /usr/lib64/libglib-2.0.so.0

[Qemu-devel] [PATCH 2/2] rfifolock: fix bogus coverity warning

2014-03-14 Thread Stefan Hajnoczi
Coverity warns about initializing variables that will later be accessed under a mutex. There is no problem with the code itself but let's avoid accumulating Coverity warnings. Signed-off-by: Stefan Hajnoczi --- util/rfifolock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH 3/4] s390x/sclpconsole: Fix and simplify interrupt injection

2014-03-14 Thread Christian Borntraeger
valgrind complains about a memory leak in irq setup of sclpconsole: ==42117== 8 bytes in 1 blocks are definitely lost in loss record 89 of 833 ==42117==at 0x4031AFE: malloc (vg_replace_malloc.c:292) ==42117==by 0x8022F855: malloc_and_trace (vl.c:2715) ==42117==by 0x4145569: g_malloc (i

[Qemu-devel] [PATCH 1/4] s390/ipl: Fix error path on BIOS loading

2014-03-14 Thread Christian Borntraeger
commit 18674b26788a9e47f1157170234e32ece2044367 (elf-loader: add more return codes) enabled the elf loader to return other errors than -1. Lets also handle that case for our "BIOS" on s390. Signed-off-by: Christian Borntraeger CC: Alexey Kardashevskiy CC: Alexander Graf --- hw/s390x/ipl.c | 2

[Qemu-devel] [PATCH V3 0/3] Quorum maintainance operations

2014-03-14 Thread Benoît Canet
Hello, This series for 2.1 add the missing maintainance feature for Quorum. The first patch allows quorum to correct corrupted reads by rewriting them. The second add the drive-mirror-replace command to be used on a drive-mirrored device to replace a target bs by the mirror. The series apply on

[Qemu-devel] [PATCH V3 1/3] quorum: Add the rewrite-corrupted parameter to quorum.

2014-03-14 Thread Benoît Canet
On read operations when this parameter is set and some replicas are corrupted while quorum can be reached quorum will proceed to rewrite the correct version of the data to fix the corrupted replicas. This will shine with SSD where the FTL will remap the same block at another place on rewrite. Sig

[Qemu-devel] [PATCH/RFC 0/4] s390/kvm: Fixes

2014-03-14 Thread Christian Borntraeger
Here are 4 s390/kvm fixes scheduled for 2.0. Pull request will follow later if there are no comments. Christian Christian Borntraeger (4): s390/ipl: Fix error path on BIOS loading s390x/cpu hotplug: Fix memory leak s390x/sclpconsole: Fix and simplify interrupt injection s390x/sclpconsole-

[Qemu-devel] [PATCH V3 3/3] qemu-iotests: Add 088 new test for drive-mirror-replace.

2014-03-14 Thread Benoît Canet
Tests for drive-mirror-replace whose purpose is to enable quorum file mirroring and replacement after failure. Signed-off-by: Benoit Canet --- tests/qemu-iotests/041| 34 +-- tests/qemu-iotests/088| 219 ++ tests/qemu-iotests/088.out

[Qemu-devel] [PATCH V3 2/3] block: Add drive-mirror-replace command to repair quorum files.

2014-03-14 Thread Benoît Canet
When a quorum file is totally destroyed (broken NAS or SAN) the user can start a drive-mirror job on the quorum block backend and then replace the broken quorum file with drive-mirror-replace given it has a node-name. Signed-off-by: Benoit Canet --- block.c | 8 ++-- block/mi

[Qemu-devel] [PATCH 4/4] s390x/sclpconsole-lm: Fix and simplify irq setup

2014-03-14 Thread Christian Borntraeger
valgrind complains about a memory leak in irq setup of sclpconsole: ==42117== 8 bytes in 1 blocks are definitely lost in loss record 89of 833 ==42117==at 0x4031AFE: malloc (vg_replace_malloc.c:292) ==42117==by 0x8022F855: malloc_and_trace (vl.c:2715) ==42117==by 0x4145569: g_malloc (in

Re: [Qemu-devel] [PATCH v2 for-2.0] blockdev: Refuse to open encrypted image unless paused

2014-03-14 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 09:22:48AM +0100, Markus Armbruster wrote: > Opening an encrypted image takes an additional step: setting the key. > Between open and the key set, the image must not be used. > > We have some protection against accidental use in place: you can't > unpause a guest while we'r

Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants

2014-03-14 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 06:50:37AM -0400, Jeff Cody wrote: > On 32-bit hosts, some compilers will warn on too large integer constants > for constants that are 64-bit in length. Explicitly put a 'ULL' suffix > on those defines. > > Reported-by: Alexander Graf > Signed-off-by: Jeff Cody > --- >

Re: [Qemu-devel] [PATCH v2 0/3] nbd: fix issues when connection breaks

2014-03-14 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 03:30:17PM +0100, Stefan Hajnoczi wrote: > v2: > * Use qemu-iotests 083 test number to avoid conflicts [kwolf] > * Test class negotiation without export name [lupine] > * Test short replies from the server [lupine] > > The first patch ensures the nbd_receive_reply() fd h

Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants

2014-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2014 at 06:50:37AM -0400, Jeff Cody wrote: > On 32-bit hosts, some compilers will warn on too large integer constants > for constants that are 64-bit in length. Explicitly put a 'ULL' suffix > on those defines. > -#define VHDX_FILE_SIGNATURE 0x656C696678646876 /* "vhdxfile" in ASC

Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants

2014-03-14 Thread Peter Maydell
On 14 March 2014 15:36, Richard W.M. Jones wrote: > On Fri, Mar 14, 2014 at 06:50:37AM -0400, Jeff Cody wrote: >> On 32-bit hosts, some compilers will warn on too large integer constants >> for constants that are 64-bit in length. Explicitly put a 'ULL' suffix >> on those defines. >> -#define VHD

Re: [Qemu-devel] [Qemu-trivial] [trivial PATCH 2.0 1/1] sasl: Avoid 'Could not find keytab file' in syslog

2014-03-14 Thread Michael Tokarev
14.03.2014 18:42, Cole Robinson wrote: > On 03/14/2014 10:39 AM, Laszlo Ersek wrote: [..] >> Since the default keytab file "/etc/qemu/krb5.tab" is usually absent, the >> cyrus-sasl library emits a warning to syslog at startup, which tends to >> annoy users (who didn't ask for gssapi in the first pl

Re: [Qemu-devel] [Qemu-trivial] [trivial PATCH 2.0 1/1] sasl: Avoid 'Could not find keytab file' in syslog

2014-03-14 Thread Cole Robinson
On 03/14/2014 11:43 AM, Michael Tokarev wrote: > 14.03.2014 18:42, Cole Robinson wrote: >> On 03/14/2014 10:39 AM, Laszlo Ersek wrote: > [..] >>> Since the default keytab file "/etc/qemu/krb5.tab" is usually absent, the >>> cyrus-sasl library emits a warning to syslog at startup, which tends to >>>

  1   2   3   >