Hi Andreas, On 13/03/14 21:28, Andreas Färber wrote: >> diff --git a/target-mips/kvm.c b/target-mips/kvm.c >> new file mode 100644 >> index 0000000..0ec343d >> --- /dev/null >> +++ b/target-mips/kvm.c > [...] >> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int32 >> *addr) > > Did you mean int32_t?
>> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, int32 >> *addr) > > int32_t? >> + *addr = (int32)val64; > > int32_t? > int32 is a type used in softfloat that has weird at-least-as-wide > semantics and bit us in the past. Well spotted, they should indeed be int32_t. > Otherwise looking good now, thanks for the CPU cleanups! We just had > another round of CPU refactorings go in today, but I don't spot a > conflict in this patch. Please rebase your local branch to verify. It rebased clearly, but I'll double check and send a v4 today anyway. Thanks James
