On Thu, 03/13 14:26, Benoît Canet wrote: > The Wednesday 12 Mar 2014 à 14:30:57 (+0800), Fam Zheng wrote : > > The new command pair is added to manage user created dirty bitmap. The > > dirty bitmap's name is mandatory and must be unique for the same device, > > but different devices can have bitmaps with the same names. > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > --- > > blockdev.c | 60 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > qapi-schema.json | 45 ++++++++++++++++++++++++++++++++++++++++++ > > qmp-commands.hx | 49 +++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 154 insertions(+) > > > > diff --git a/blockdev.c b/blockdev.c > > index c3422a1..662c950 100644 > > --- a/blockdev.c > > +++ b/blockdev.c > > @@ -1713,6 +1713,66 @@ void qmp_block_set_io_throttle(const char *device, > > int64_t bps, int64_t bps_rd, > > } > > } > > > > +void qmp_dirty_bitmap_add(const char *device, const char *name, > Do we want this to work on node-names too ?
I think having dirty bitmap on device is good enough for now. If there is a necessity we can add on top. Fam
