Re: [Qemu-devel] [PATCH] gtk: Add mouse wheel support

2014-03-12 Thread Gerd Hoffmann
On Di, 2014-03-11 at 17:26 +0100, Jan Kiszka wrote: > Hook into scroll-event to properly forward mouse wheel movements to > the > guest, just like we already do in SDL. Added to input queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Jan Kiszka
On 2014-03-12 00:15, Cole Robinson wrote: > These errors don't seem user initiated, so forcibly printing to the > monitor doesn't seem right. Just print to stderr. > > Drop lprint since it's now unused. > > Cc: Jan Kiszka > Signed-off-by: Cole Robinson > --- > checkpatch flags some pre-existing

Re: [Qemu-devel] slirp smb with modern win guests when samba is also running on host

2014-03-12 Thread Jan Kiszka
On 2013-11-28 20:32, Michael Tokarev wrote: > After numerous reports that -smb (or -netdev user,smb=foo) not working > with modern windows (win7 and vista are reported as non-working), I > started digging myself. And found that indeed it doesn't work, and > why. > > The thing is that modern win t

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-03-12 Thread Jan Kiszka
On 2014-02-11 14:08, Samuel Thibault wrote: > Hello, > > This is a respin of IPv6 in Qemu -net user mode. > > These patches add ICMPv6, NDP, and make UDP and TCP compatible with > IPv6. We have made some refactoring to make current code compatible with > IPv6. > > Some patches, like 2 and 13, ca

[Qemu-devel] [PULL] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Mark Cave-Ayland
Hi Peter, This request contains just a single patch to add CPU_FEATURE_CASA for target-sparc. Please pull for 2.0. Many thanks, Mark. The following changes since commit 239618707637ec87eba8c452d2b2f75dc5ca20c7: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-03-11

[Qemu-devel] [pull] slirp queue

2014-03-12 Thread Jan Kiszka
The following changes since commit 239618707637ec87eba8c452d2b2f75dc5ca20c7: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-03-11 19:39:17 +) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp for you to fetch changes up to 5c1e

[Qemu-devel] [PATCH][RESEND] gtk: Allow to activate grab-on-hover from the command line

2014-03-12 Thread Jan Kiszka
As long as we have no persistent GTK configuration, this allows to enable the useful grab-on-hover feature already when starting the VM. Signed-off-by: Jan Kiszka --- include/ui/console.h | 2 +- qemu-options.hx | 5 + ui/gtk.c | 5 - vl.c | 22 +++

Re: [Qemu-devel] [PATCH 1/2][RESENT] Add GDB qAttached support

2014-03-12 Thread Jan Kiszka
On 2013-07-17 10:10, Jan Kiszka wrote: > With this patch QEMU handles qAttached request from gdb. When QEMU > replies 1, GDB sends a "detach" command at the end of a debugging > session otherwise GDB sends "kill". > > The default value for qAttached is 1 on system emulation and 0 on user > emulati

[Qemu-devel] [Bug 1290558] Re: color issue (ppc as guest)

2014-03-12 Thread Mark Cave-Ayland
Hi Joe, Thanks for the bug report. A few things to try: - Can you confirm that you see the same color issue when booting a Darwin ISO such as darwinppc-602.iso? - Do you still see the same the issue with QEMU git master as 1.6 is fairly old now? Using the Darwin image above, I do not see the c

[Qemu-devel] [RFC v4 1/3] cpu: introduce CpuTopoInfo structure for argument simplification

2014-03-12 Thread Chen Fan
Signed-off-by: Chen Fan --- target-i386/topology.h | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..9b811c1 100644 --- a/target-i386/topology.h +++ b/target-i386/topology.h @@ -47

[Qemu-devel] [RFC v4 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu

2014-03-12 Thread Chen Fan
at present, after hotplug a discontinuous cpu id on source, then done migration, on target, it will fail to add the unoccupied cpu id which was skipped at source, this cause is on target Qemu prebuild CPU with continuous cpu_index. so after migration, the cpu infrastructure bewteen source and targ

[Qemu-devel] [RFC v4 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()

2014-03-12 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/i386/pc.c | 25 ++--- target-i386/cpu.c | 28 +++- target-i386/cpu.h | 5 + target-i386/topology.h | 18 ++ 4 files changed, 60 insertions(+), 16 deletions(-) diff --git a/hw/i386/

[Qemu-devel] [RFC v4 3/3] i386: introduce cpu QOM hierarchy tree

2014-03-12 Thread Chen Fan
add cpu-topology.h cpu-topology.c files for prebuilding cpu qom tree "/machine/node[X]/socket[Y]/core[Z]->link cpu" Signed-off-by: Chen Fan --- hw/i386/pc.c | 3 + target-i386/Makefile.objs | 2 +- target-i386/cpu-topology.c | 199 +

Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage

2014-03-12 Thread Gerd Hoffmann
On Di, 2014-03-11 at 19:15 -0400, Cole Robinson wrote: > These errors don't seem user initiated, so forcibly printing to the > monitor doesn't seem right. Just print to stderr. > > Cc: Anthony Liguori > Cc: Gerd Hoffmann > Signed-off-by: Cole Robinson Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Markus Armbruster
Cole Robinson writes: > These errors don't seem user initiated, so forcibly printing to the > monitor doesn't seem right. Just print to stderr. > > Drop lprint since it's now unused. > > Cc: Jan Kiszka > Signed-off-by: Cole Robinson > --- > checkpatch flags some pre-existing tab issues, but I d

Re: [Qemu-devel] [v2 PATCH 00/13] SMBIOS: build full tables in QEMU

2014-03-12 Thread Gerd Hoffmann
On Di, 2014-03-11 at 12:58 -0400, Gabriel L. Somlo wrote: > On Tue, Mar 11, 2014 at 11:46:17AM -0400, Kevin O'Connor wrote: > > I would suggest being "bug for bug" compatible in the first set of > > patches, and then add patches on top to add the additional > > functionality. Just my 2 cents. Mak

Re: [Qemu-devel] [PATCH v22 01/25] add def_value_str to QemuOptDesc

2014-03-12 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 10:45:57AM +0800, Chunyan Liu wrote: > 2014-03-11 21:29 GMT+08:00 Stefan Hajnoczi : > > > On Mon, Mar 10, 2014 at 03:31:37PM +0800, Chunyan Liu wrote: > > > Add def_value_str (default value) to QemuOptDesc, to replace function of > > the > > > default value in QEMUOptionPar

Re: [Qemu-devel] [PATCH V4] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 09:20:55PM +0200, Marcel Apfelbaum wrote: > On Tue, 2014-03-11 at 19:51 +0100, Stefan Hajnoczi wrote: > > On Tue, Mar 11, 2014 at 03:00:34PM +0200, Marcel Apfelbaum wrote: > > > 'socket_accept' waits for Qemu to init its unix socket. > > > If Qemu encounters an error during

Re: [Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp

2014-03-12 Thread Markus Armbruster
Cole Robinson writes: > error_printf is just a wrapper around monitor_printf, which already > drops the requested output if cur_mon is qmp. Since commit 74ee59a: monitor: drop unused monitor debug code In the old QMP days, this code was used to find out QMP commands that might

Re: [Qemu-devel] [PATCH qom-next v2] qom-test: Test QOM properties

2014-03-12 Thread Markus Armbruster
Andreas Färber writes: > Recursively walk all properties under /machine and try to retrieve their > value. This is a regression test for link<> properties and the > DeviceState::hotpluggable property. > > Cf. be2f78b6b062eec5170e2612299fb8953046993f and > 1a37eca107cece3ed454bae29eef0bd1fac4a

Re: [Qemu-devel] [PATCH] block: Unlink temporary file

2014-03-12 Thread Stefan Hajnoczi
On Sat, Feb 15, 2014 at 06:03:21PM +0100, Max Reitz wrote: > If the image file cannot be opened and was created as a temporary file, > it should be deleted; thus, in this case, we should jump to the > "unlink_and_fail" label and not just to "fail". > > Reported-by: Benoît Canet > Signed-off-by: M

Re: [Qemu-devel] [PATCH v2 0/3] nbd: fix issues when connection breaks

2014-03-12 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 03:30:17PM +0100, Stefan Hajnoczi wrote: > v2: > * Use qemu-iotests 083 test number to avoid conflicts [kwolf] > * Test class negotiation without export name [lupine] > * Test short replies from the server [lupine] > > The first patch ensures the nbd_receive_reply() fd h

Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-12 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote: > Smatch complains about several global symbols which should be local. > > Add the missing 'static' attributes and move the 'extern' declaration > of variable qemuio_misalign to qemu-io.h. This variable also changes > the type from 'int'

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-12 Thread Gerd Hoffmann
Hi, > > I think we should not generate a type0 table unless -smbios type0=... is > > explicitly specified on the qemu command line. It is about the > > firmware, and we should leave it to the firmware to fill it by default. > > If you are running OVMF (EFI) instead of SeaBIOS you should see it

Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables

2014-03-12 Thread Gerd Hoffmann
On Di, 2014-03-11 at 11:16 -0400, Gabriel L. Somlo wrote: > From: "Gabriel L. Somlo" > > Build full smbios type 19 (memory array mapped address) tables, > and make them available via fw_cfg > +smbios_build_type_19_table(0, 0, smbios_below_4g_ram >> 10); > +if (smbios_above_4g_ra

[Qemu-devel] pci passthrough in Aarch64

2014-03-12 Thread Chalamarla, Tirumalesh
Hi, Some one Please let me know, What is the way to assign a pass through PCI device with qemu on Aarch64 without VFIO. i tried ? -device pci-assign,host=01.00.0? got the following error qemu-system-aarch64: -device pci-assign,host=01.00.0: 'kvm-pci-assign' is not a valid device m

[Qemu-devel] [PULL 0/1] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-03-12 Thread Gerd Hoffmann
Hi, Single patch I've just found still lingering in my misc branch ... please pull, Gerd The following changes since commit 239618707637ec87eba8c452d2b2f75dc5ca20c7: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-03-11 19:39:17 +) are available in the git re

[Qemu-devel] [PULL 1/1] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-03-12 Thread Gerd Hoffmann
From: Miki Mishael Support for pci-serial-2x and pci-serial-4x was added to the inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman Signed-off-by: Gerd Hoffmann --

Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()

2014-03-12 Thread Kevin Wolf
Am 11.03.2014 um 17:41 hat Benoît Canet geschrieben: > I have the impression that you are silently fixing other nits; Am I? Not intentionally at least. I think I can justify every single line of the patch with respect to the bug described in the commit message. We need to recursive into the proto

Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Markus Armbruster
Marcel Apfelbaum writes: > 'socket_accept' waits for Qemu to init its unix socket. > If Qemu encounters an error during command line parsing, > it can exit before initializing the communication channel. > It gets worse as the make check-qtest-* gets stuck without > notifying which test exactly ha

Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()

2014-03-12 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 10:40:00 (+0100), Kevin Wolf wrote : > Am 11.03.2014 um 17:41 hat Benoît Canet geschrieben: > > I have the impression that you are silently fixing other nits; > > Am I? > > Not intentionally at least. I think I can justify every single line of > the patch with respect

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows

2014-03-12 Thread Sebastian Huber
Hello, On 2014-03-02 16:56, Sebastian Huber wrote: On 03/02/2014 02:17 PM, Michael Tokarev wrote: 26.02.2014 11:53, Sebastian Huber wrote: Ping. There was another comment on this, about the first hunk, see https://lists.gnu.org/archive/html/qemu-trivial/2014-02/msg00067.html Note that the co

Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Marcel Apfelbaum
On Wed, 2014-03-12 at 10:42 +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > 'socket_accept' waits for Qemu to init its unix socket. > > If Qemu encounters an error during command line parsing, > > it can exit before initializing the communication channel. > > It gets worse as the

Re: [Qemu-devel] pci passthrough in Aarch64

2014-03-12 Thread Peter Maydell
On 12 March 2014 09:30, Chalamarla, Tirumalesh wrote: > Some one Please let me know, What is the way to assign a pass through PCI > device with qemu on Aarch64 without VFIO. This isn't currently possible because the only AArch64 board model we support is "virt" and that does not have a PCI contro

Re: [Qemu-devel] [PATCH v2 0/5] block: Strip protocol prefixes from filenames

2014-03-12 Thread Stefan Hajnoczi
On Sat, Mar 08, 2014 at 12:39:40AM +0100, Max Reitz wrote: > As some kind of follow-up to the "block: Strip 'file:' prefix from > filenames" series, this series does the same thing for other protocol > drivers. > > All protocol drivers which implement bdrv_probe() may rely on them being > selected

Re: [Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Fabien Chouteau
Thanks Sebastian, I will try my first pull request ;)

Re: [Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Fabien Chouteau
Thanks Sebastian, I will try my first pull request :)

Re: [Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Sebastian Huber
Hello Fabien, On 2014-03-12 11:17, Fabien Chouteau wrote: Thanks Sebastian, I will try my first pull request :) I think Mark already did this http://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02325.html ? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchh

Re: [Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Fabien Chouteau
On 03/12/2014 11:22 AM, Sebastian Huber wrote: > Hello Fabien, > > On 2014-03-12 11:17, Fabien Chouteau wrote: >> Thanks Sebastian, I will try my first pull request :) > > I think Mark already did this > > http://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02325.html > > ? Very well then

[Qemu-devel] [PULL 00/24] Block patches for QEMU 2.0

2014-03-12 Thread Stefan Hajnoczi
The following changes since commit b304bf0021a2dfb24fa91f704a1d976b74f56f20: s390/kvm: Add Maintainers for s390/kvm (2014-03-10 16:43:11 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 11dfe5671f5d7587

[Qemu-devel] [PULL 04/24] block: bs->drv may be NULL in bdrv_debug_resume()

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz Currently, bdrv_debug_resume() requires every bs->drv in the BDS stack to be NULL until a bs->drv with an implementation of bdrv_debug_resume() is found. For a normal function, this would be fine, but this is a function for debugging purposes and should therefore allow intermediat

[Qemu-devel] [PULL 01/24] qcow2-refcount: Sanitize refcount table entry

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz When reading the refcount table entry in get_refcount(), only bits which are actually significant for the refcount block offset should be taken into account. Signed-off-by: Max Reitz Reviewed-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 3 ++-

[Qemu-devel] [PULL 06/24] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-12 Thread Stefan Hajnoczi
From: Benoît Canet This patch keep the recursive way of doing things but simplify it by giving two responsabilities to all block filters implementors. They will need to do two things: -Set the is_filter field of their block driver to true. -Implement the bdrv_recurse_is_first_non_filter method

[Qemu-devel] [PULL 08/24] rfifolock: add recursive FIFO lock

2014-03-12 Thread Stefan Hajnoczi
QemuMutex does not guarantee fairness and cannot be acquired recursively: Fairness means each locker gets a turn and the scheduler cannot cause starvation. Recursive locking is useful for composition, it allows a sequence of locking operations to be invoked atomically by acquiring the lock around

[Qemu-devel] [PULL 09/24] aio: add aio_context_acquire() and aio_context_release()

2014-03-12 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

[Qemu-devel] [PULL 07/24] object: add object_get_canonical_path_component()

2014-03-12 Thread Stefan Hajnoczi
It is often useful to find an object's child property name. Also use this new function to simplify the implementation of object_get_canonical_path(). Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- include/qom/object.h | 8 qom/object.c | 54 +++

[Qemu-devel] [PULL 10/24] iothread: add I/O thread object

2014-03-12 Thread Stefan Hajnoczi
This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop threads, allowing users to define them. When SMP guests run on SMP hosts it makes s

[Qemu-devel] [PULL 12/24] iothread: add "iothread" qdev property type

2014-03-12 Thread Stefan Hajnoczi
Add a "iothread" qdev property type so devices can be hooked up to an IOThread from the comand-line: qemu -object iothread,id=iothread0 \ -device some-device,x-iothread=iothread0 Note that Paolo Bonzini has suggested using QOM links instead. This way the relationship between the object

[Qemu-devel] [PULL 14/24] iothread: stash thread ID away

2014-03-12 Thread Stefan Hajnoczi
Keep the thread ID around so we can report it via QMP. There's only one problem: qemu_get_thread_id() (gettid() wrapper on Linux) must be called from the thread itself. There is no way to get the thread ID outside the thread. This patch uses a condvar to wait for iothread_run() to populate the t

[Qemu-devel] [PULL 05/24] iotests: Test corruption during COW request

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz Extend test file 060 by a test case for corruption occuring concurrently to a COW request. QEMU should not crash but rather return an appropriate error message. Signed-off-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/060 | 26

[Qemu-devel] [PULL 17/24] qcow2: Don't write with BDRV_O_INCOMING

2014-03-12 Thread Stefan Hajnoczi
From: Kevin Wolf qcow2_open() causes writes when repairing an image with the dirty flag set and when clearing autoclear flags. It shouldn't do this when another qemu instance is still actively working on this image file. One effect of the bug is that images may have a cleared dirty flag while th

[Qemu-devel] [PULL 11/24] qdev: make get_pointer() handle temporary strings

2014-03-12 Thread Stefan Hajnoczi
From: Igor Mammedov get_pointer()'s print() callback might return a heap allocated string, to avoid adding dedicated get_pointer_foo for this case convert current print() callbacks to return temporary heap allocated string and make get_pointer() free it. Reviewed-by: Andreas Färber Signed-off-b

[Qemu-devel] [PULL 15/24] qmp: add query-iothreads command

2014-03-12 Thread Stefan Hajnoczi
The "query-iothreads" command returns a list of information about iothreads. See the patch for API documentation. Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- iothread.c | 36 qapi-schema.json | 29 + qmp-comm

[Qemu-devel] [PULL 21/24] block/raw-posix: bdrv_parse_filename() for floppy

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz The "host_floppy" protocol driver should strip the "host_floppy:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/ra

Re: [Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes

2014-03-12 Thread Peter Maydell
On 11 March 2014 12:32, Michael S. Tsirkin wrote: > The following changes since commit 220c8ed536491315b4040d820328b8dfd60d67a7: > > qemu: x86: ignore ioapic polarity (2014-03-09 21:09:38 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.7.1, freeze on 2013-02-27

2014-03-12 Thread Michael Tokarev
04.03.2014 21:54, Michael Roth wrote: > Sorry, it's been tagged for release already. The tarball/announcement should > go out soon. Has it been released? Thanks, /mjt

[Qemu-devel] [PATCH] input: activate legacy kbd

2014-03-12 Thread Gerd Hoffmann
Restores traditional behavior: Keyboard input will be routed to the most recently added keyboard. Without this all kbd input goes to the ps/2 keyboard, even if you add a usb keyboard to your guest. Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 1 + 1 file changed, 1 insertion(+) diff -

[Qemu-devel] [PULL 19/24] qemu-io: Fix warnings from static code analysis

2014-03-12 Thread Stefan Hajnoczi
From: Stefan Weil Smatch complains about several global symbols which should be local. Add the missing 'static' attributes and move the 'extern' declaration of variable qemuio_misalign to qemu-io.h. This variable also changes the type from 'int' to 'bool' which better fits documents its use. Si

[Qemu-devel] [PULL 24/24] block/raw-win32: bdrv_parse_filename() for hdev

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-win32.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/ra

[Qemu-devel] [PULL 16/24] qcow2: Keep option in qcow2_invalidate_cache()

2014-03-12 Thread Stefan Hajnoczi
From: Kevin Wolf Instead of manually building a list of all options from BDRVQcowState values just reuse the options that were used to open the image. qcow2_open() won't fully use all of the options in the QDict, but that's okay. This fixes all of the driver-specific options in qcow2, except for

Re: [Qemu-devel] WIP: Migration format: ASN.1/BER schema

2014-03-12 Thread Michael S. Tsirkin
On Fri, Mar 07, 2014 at 04:55:03PM +, Dr. David Alan Gilbert wrote: > Hi, > I've been looking at reviving the migration-as-ber work that Michael and > Stefan looked at a while ago, and have stuff starting to work, but not > ready yet, so I thought I'd start by posting my current view > of an

[Qemu-devel] [PULL 02/24] block: Update image size in bdrv_invalidate_cache()

2014-03-12 Thread Stefan Hajnoczi
From: Kevin Wolf After migration has completed, we call bdrv_invalidate_cache() so that drivers which cache some data drop their stale copy of the data and reread it from the image file to get a new version of data that the source modified while the migration was running. Reloading metadata from

[Qemu-devel] [PULL 18/24] block: Unlink temporary file

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz If the image file cannot be opened and was created as a temporary file, it should be deleted; thus, in this case, we should jump to the "unlink_and_fail" label and not just to "fail". Reported-by: Benoît Canet Signed-off-by: Max Reitz Acked-by: Stefan Hajnoczi Signed-off-by: S

[Qemu-devel] [PULL 20/24] block/raw-posix: bdrv_parse_filename() for hdev

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/ra

[Qemu-devel] [PULL 22/24] block/raw-posix: bdrv_parse_filename() for cdrom

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz The "host_cdrom" protocol drivers should strip the "host_cdrom:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/bloc

[Qemu-devel] [PULL 03/24] qcow2: Check bs->drv in copy_sectors()

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz Before dereferencing bs->drv for a call to its member bdrv_co_readv(), copy_sectors() should check whether that pointer is indeed valid, since it may have been set to NULL by e.g. a concurrent write triggering the corruption prevention mechanism. Signed-off-by: Max Reitz Signed-

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-03-12 Thread Kevin Wolf
Am 24.01.2014 um 14:48 hat Jeff Cody geschrieben: > On Fri, Jan 24, 2014 at 02:33:19PM +0100, Kevin Wolf wrote: > > Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: > > > Having both read-only=on and snapshot=on together does not make sense; > > > currently, the read-only argument is effectively i

[Qemu-devel] [PULL 23/24] block/raw-posix: Strip protocol prefix on creation

2014-03-12 Thread Stefan Hajnoczi
From: Max Reitz The hdev_create() implementation in block/raw-posix.c is used by the "host_device", "host_cdrom" and "host_floppy" protocol block drivers together. Thus, any of the associated prefixes may occur and exactly one should should be stripped, if it does (thus, "host_device:host_cdrom:/

[Qemu-devel] [PULL 13/24] dataplane: replace internal thread with IOThread

2014-03-12 Thread Stefan Hajnoczi
Today virtio-blk dataplane uses a 1:1 device-per-thread model. Now that IOThreads have been introduced we can generalize this to N:M devices per threads. This patch drops thread code from dataplane in favor of running inside an IOThread AioContext. As a bonus we solve the case where a guest keep

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-03-12 Thread Michael S. Tsirkin
On Fri, Feb 07, 2014 at 10:02:52AM +0100, Greg Kurz wrote: > On Wed, 5 Feb 2014 23:31:11 +0200 > "Michael S. Tsirkin" wrote: > > On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kum

Re: [Qemu-devel] [PULL 073/130] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2014-03-12 Thread Fabien Chouteau
On 03/09/2014 09:02 AM, Paolo Bonzini wrote: > Il 07/03/2014 00:33, Alexander Graf ha scritto: >> From: Fabien Chouteau >> >> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. >> >> Signed-off-by: Fabien Chouteau >> Signed-off-by: Alexander Graf >> --- > > Is this code de

Re: [Qemu-devel] [PULL for-2.0 00/11] QMP queue

2014-03-12 Thread Peter Maydell
On 11 March 2014 13:41, Luiz Capitulino wrote: > The following changes since commit c57ec3249e9839c7ea2e3789f6e40f9ec1c92f55: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-5' into > staging (2014-03-11 12:52:08 +) > > are available in the git repository at: > > > git://

[Qemu-devel] [PATCH 1/1] Detect pthread_setname_np at configure time

2014-03-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Warn if no way of setting thread name is available. Signed-off-by: Dr. David Alan Gilbert --- configure| 28 util/qemu-thread-posix.c | 21 ++--- util/qemu-thread-win32.c | 2 ++ 3 files changed, 48 in

[Qemu-devel] [PATCH 0/1] configure time fix for thread naming on old glibc

2014-03-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Peter was preferring configure time detection of pthread_setname_np to guard against my recent breaking of builds on old libc. I've tested this on: Fedora 20 - modern glibc - works as before RHEL 5 - glibc 2.5: [dgilbert@davidgil-rhel5 try]$ ./bin/qemu-s

Re: [Qemu-devel] [PATCH qom-next v2] qom-test: Test QOM properties

2014-03-12 Thread Andreas Färber
Am 12.03.2014 10:09, schrieb Markus Armbruster: > Andreas Färber writes: > >> Recursively walk all properties under /machine and try to retrieve their >> value. This is a regression test for link<> properties and the >> DeviceState::hotpluggable property. >> >> Cf. be2f78b6b062eec5170e2612299fb89

Re: [Qemu-devel] Disk I/O in QEMU

2014-03-12 Thread Le Tan
Hi Stefan, Thanks for your help. I find that the source code of qemu-1.2.0 doesn't have hw/block/. So I download the qemu-1.6.2. However it doesn't work. I run the configure like this: ./configure --enable-kvm --x86_64-softmmu then make and make install. I can start the vm using this command: qemu-

[Qemu-devel] [PATCH] MAINTAINERS: add self as MACHINE maintainer

2014-03-12 Thread Marcel Apfelbaum
'Machine as QOM object' feature produced a new file (machine.c). I am taking responsibility to maintain it (and others as needed). Signed-off-by: Marcel Apfelbaum --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7efaccf..60b7e00 100644 ---

Re: [Qemu-devel] [PATCH v22 05/25] add some QemuOpts functions for replace work

2014-03-12 Thread Eric Blake
On 03/11/2014 09:10 PM, Chunyan Liu wrote: >>> Could be if changing qemu_opt_get return value type, but just as said >>> before, >>> that will affect many codes. >> >> Also, changing an existing function that returns 'const char *' into now >> returning 'char *' will NOT break any callers if

Re: [Qemu-devel] [PATCH v3 2/2] virtio-serial-port: Convert to QOM realize/unrealize

2014-03-12 Thread Amit Shah
Hi, I haven't really followed the whole discussion, so can't say much about it -- overall looks alright. A couple of minor nits: > max_nr_ports = tswap32(port->vser->config.max_nr_ports); > if (port->id >= max_nr_ports) { > -error_report("virtio-serial-bus: Out-of-range port id

Re: [Qemu-devel] [PULL] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-12 Thread Peter Maydell
On 12 March 2014 07:25, Mark Cave-Ayland wrote: > Hi Peter, > > This request contains just a single patch to add CPU_FEATURE_CASA for > target-sparc. > Please pull for 2.0. > Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH] linux-user: Don't reserve space for commpage for AArch64

2014-03-12 Thread Riku Voipio
On Mon, Mar 10, 2014 at 12:59:17PM +, Peter Maydell wrote: > AArch64 Linux, unlike AArch32, doesn't use a commpage. This means we > should not be reserving room in the guest address space for one. > Fixes LP:1287195. Looks good, Reviewed-by: Riku Voipio > Reported-by: Amanieu d'Antras > Si

[Qemu-devel] [PATCH 1/4] vga: allow non-global vmstate

2014-03-12 Thread Gerd Hoffmann
Need a way to opt-out from vga.vram being global vmstate, for secondary vga cards. Add a bool parameter to vga_common_init to support this. Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vga-isa-mm.c | 2 +- hw/display/vga-isa.c

[Qemu-devel] [PATCH 0/4] vga: new display devices

2014-03-12 Thread Gerd Hoffmann
Hi, This patch series adds new display devices. Number one is secondary-vga. That is identical to VGA (aka -vga std), except that it doesn't occupy all the legacy vga stuff (ioports, memory window @ 0xa), so you can have more than one of these in the system. It has one pci memory bar for t

[Qemu-devel] [PATCH 2/4] vga: add secondary stdvga variant

2014-03-12 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. Signed-off-by: Gerd Hoffmann --- docs/specs/standard-vga.txt | 13 +++--- hw/display/vga-pci.c

[Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-12 Thread Gerd Hoffmann
From: Dave Airlie This is the basic virtio-gpu which is multi-head capable, ARGB cursor support, unaccelerated. Some more info is in docs/specs/virtio-gpu.txt. Signed-off-by: Dave Airlie changes by kraxel: * adapt to changes in master. * move from hw/virtio to hw/display. * codestyle clea

[Qemu-devel] [PATCH 4/4] virtio-vga: v1

2014-03-12 Thread Gerd Hoffmann
From: Dave Airlie This is a virtio-vga device built on top of the virtio-gpu device. Signed-off-by: Dave Airlie changes by kraxel: * adapt to changes in master. * codestyle cleanups. Signed-off-by: Gerd Hoffmann --- Makefile | 2 +- default-configs/x86_64-softm

[Qemu-devel] [PATCH 1/2] linux-user/signal.c: Correct error path for AArch64 do_rt_sigreturn

2014-03-12 Thread Peter Maydell
The error path in AArch64 do_rt_sigreturn() which fails before attempting lock_user_struct() was doing an unlock_user_struct() on an uninitialized variable. Initialize frame to NULL so we can use the same error-exit path in all cases (unlock of NULL is permitted and does nothing). Signed-off-by: P

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Luiz Capitulino
On Wed, 12 Mar 2014 08:22:05 +0100 Jan Kiszka wrote: > On 2014-03-12 00:15, Cole Robinson wrote: > > These errors don't seem user initiated, so forcibly printing to the > > monitor doesn't seem right. Just print to stderr. > > > > Drop lprint since it's now unused. > > > > Cc: Jan Kiszka > > S

Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables

2014-03-12 Thread Gabriel L. Somlo
On Wed, Mar 12, 2014 at 09:27:18AM +0100, Gerd Hoffmann wrote: > I think we should just use e820_table (see pc.c) here. Loop over it and > add a type 19 table for each ram region in there. I'm assuming this should be another post-Seabios-compatibility patch, at the end of the series, and I should

Re: [Qemu-devel] [PATCH 2/4] vga: add secondary stdvga variant

2014-03-12 Thread Eric Blake
On 03/12/2014 06:55 AM, Gerd Hoffmann wrote: > Add a standard vga variant which doesn't occupy any legacy > ressources and thus can easily be used as secondary (or legacy-free) s/ressources/resources/ > graphics adapter. Programming must be done using the MMIO bar. > > Signed-off-by: Gerd Hoffm

Re: [Qemu-devel] Disk I/O in QEMU

2014-03-12 Thread Fam Zheng
On Wed, 03/12 20:27, Le Tan wrote: > Hi Stefan, > Thanks for your help. I find that the source code of qemu-1.2.0 doesn't > have hw/block/. So I download the qemu-1.6.2. However it doesn't work. I > run the configure like this: > ./configure --enable-kvm --x86_64-softmmu > then make and make instal

Re: [Qemu-devel] WIP: Migration format: ASN.1/BER schema

2014-03-12 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Mar 07, 2014 at 04:55:03PM +, Dr. David Alan Gilbert wrote: > I think this is already useful. > For example this will make input parser > more robust against unexpected input > as octet string blobs are bounded, so if we fail > to parse

Re: [Qemu-devel] Disk I/O in QEMU

2014-03-12 Thread Le Tan
I am sorry I didn't give the complete command I have executed. It is like this: qemu-system-x86_64 -m 1024 -smp 2 -hda /home/tanle/study/new.img -nographic -vnc 192.168.146.118:2 -enable-kvm If I delete the "-enable-kvm", it is ok and the system can boot up (just slow). But with "-enable-kvm", the

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Cole Robinson
On 03/12/2014 04:13 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> These errors don't seem user initiated, so forcibly printing to the >> monitor doesn't seem right. Just print to stderr. >> >> Drop lprint since it's now unused. >> >> Cc: Jan Kiszka >> Signed-off-by: Cole Robinson >>

[Qemu-devel] [PATCH 2/2] linux-user: Don't return uninitialized value for atomic_barrier syscall

2014-03-12 Thread Peter Maydell
QEMU's implementation of the m68k atomic_barrier syscall, like the kernel's, is just a no-op. However we still need to return a result code from it. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall

[Qemu-devel] [PATCH] target-m68k: Remove custom qemu_assert() function

2014-03-12 Thread Peter Maydell
Remove the custom qemu_assert() function defined by target-m68k/translate.c in favour of either using glib g_assert_not_reached() (for the genuinely can't-happen cases) or cpu_abort() (for the "this isn't implemented", in line with other unimplemented cases in the target). This has the benefit of

Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables

2014-03-12 Thread Gerd Hoffmann
On Mi, 2014-03-12 at 09:05 -0400, Gabriel L. Somlo wrote: > On Wed, Mar 12, 2014 at 09:27:18AM +0100, Gerd Hoffmann wrote: > > I think we should just use e820_table (see pc.c) here. Loop over it and > > add a type 19 table for each ram region in there. > > I'm assuming this should be another post

[Qemu-devel] [PATCH 0/2] linux-user: Fix uninitialized variables

2014-03-12 Thread Peter Maydell
Fix a couple of uses of uninitialized variables in linux-user; both spotted by clang as compile warnings. Peter Maydell (2): linux-user/signal.c: Correct error path for AArch64 do_rt_sigreturn linux-user: Don't return uninitialized value for atomic_barrier syscall linux-user/signal.c |

Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-12 Thread Peter Maydell
On 11 March 2014 12:29, Peter Maydell wrote: > On 10 March 2014 19:56, Michael S. Tsirkin wrote: >> casting an unaligned address to e.g. >> uint32_t can trigger undefined behaviour in C. >> Replace cast + assignment with memcpy. >> >> Reported-by: Peter Maydell >> Signed-off-by: Michael S. Tsirk

[Qemu-devel] [PULL 1/1] trace: Fix build warnings for Win32 build

2014-03-12 Thread Stefan Hajnoczi
From: Peter Maydell The Win32 build warns about trace/control-internal.h: warning: 'trace_event_count' declared inline after being called Fix this by simply reordering trace_event_id() and trace_event_count(). Signed-off-by: Peter Maydell Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoc

  1   2   3   4   >