On 06.03.2014 15:19, Liguori, Anthony wrote:
We can check the moderation queue although it's usually empty. Savannah has a
pretty aggressive spam filter and mail delivery isn't always reliable.
I think I got it. I accidently had a typo (missing space) in the git send-email
command which left
this patch introduces a new flag to indicate that we are going to sequentially
read from a file and do not plan to reread/reuse the data after it has been
read.
The current use of this flag is to open the source(s) of a qemu-img convert
process. If a protocol from block/raw-posix.c is used posix_
This series adds for point-in-time snapshot NBD exporting based on
blockdev-backup (variant of drive-backup with existing device as target).
We get a thin point-in-time snapshot by COW mechanism of drive-backup, and
export it through built in NBD server. The steps are as below:
1. (SHELL) qemu-i
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
---
include/block/block.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 780f48b..882073
This drops BlockDriverState.in_use with op_blockers:
- Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
- Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
- Check bdrv_op_is_blocked() in place of bdrv_in_use(bs).
The specific types are used, e.g. in place of startin
This reuses the new bdrv_drop_intermediate.
Signed-off-by: Fam Zheng
---
block/stream.c | 42 +-
1 file changed, 1 insertion(+), 41 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index dd0b4ac..1b348a2 100644
--- a/block/stream.c
+++ b/block/st
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
elements. Each list is a list of blockers of an operation type
(BlockOpType), that marks this BDS as currently blocked for a certain
type of operation with reason errors stored in the list. The rule of
usage is:
* BDS user w
This makes use of op_blocker and blocks all the operations except for
commit target, on each BlockDriverState->backing_hd.
The asserts for op_blocker in bdrv_swap are removed because with this
change, the target of block commit has at least the backing blocker of
its child, so the assertion is not
It makes no sense to check for "any" blocker on bs, we are here only
because of the mechanical conversion from in_use to op_blockers. Remove
it now, and let the callers check specific operation types. Backup and
mirror already have it, add checker to stream and commit.
Signed-off-by: Fam Zheng
Re
This is the common but non-trivial steps to assign or change the
backing_hd of BDS.
Signed-off-by: Fam Zheng
---
block.c | 39 +--
include/block/block.h | 1 +
2 files changed, 26 insertions(+), 14 deletions(-)
diff --git a/block.c b/block.c
in
Dropping intermediate could be useful both for commit and stream, and
BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs
to work with op blockers.
Signed-off-by: Fam Zheng
---
block.c| 139 -
block/commit.c |
Now it's safe to allow reference for backing_hd in the interface.
Signed-off-by: Fam Zheng
---
block.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 650931f..bcfeb50 100644
--- a/block.c
+++ b/block.c
@@ -1395,12 +1395,35
Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and any other operation on it will be blocked by that.
Signed-off-by: Fam Zheng
---
block.c | 2
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
now.
Add check and report error for bs == target which became possible but is
an illegal case with introduction of
This applies cases on drive-backup on blockdev-backup, except cases with
target format and mode.
Also add a case to check source == target.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/055 | 275 ++---
tests/qemu-iotests/055.out | 4 +-
2 files c
On Fri, Mar 07, 2014 at 12:34:28PM +1100, Alexey Kardashevskiy wrote:
> On 02/21/2014 07:24 PM, Alexander Graf wrote:
> >
> > On 21.02.2014, at 07:09, Alexey Kardashevskiy wrote:
> >
> >> On 02/10/2014 05:52 PM, Alexey Kardashevskiy wrote:
> >> Ping?
> >
> > Anthony / Stefan, could you please u
This tests the workflow of creating a lightweight point-in-time snapshot
with blockdev-backup command and export it with built-in NBD server.
It's tested that after the snapshot it created, writing to the original
device doesn't change data that can be read from target with NBD.
Signed-off-by: Fa
Signed-off-by: Fam Zheng
---
blockdev.c | 48
qapi-schema.json | 1 +
2 files changed, 49 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 065d0ac..4f2c6f9 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1409,6 +1409,49 @@ static void
Stefan Hajnoczi writes:
> On Fri, Mar 07, 2014 at 12:34:28PM +1100, Alexey Kardashevskiy wrote:
>> On 02/21/2014 07:24 PM, Alexander Graf wrote:
>> >
>> > On 21.02.2014, at 07:09, Alexey Kardashevskiy wrote:
>> >
>> >> On 02/10/2014 05:52 PM, Alexey Kardashevskiy wrote:
>> >> Ping?
>> >
>> >
Il 07/03/2014 00:44, Andreas Färber ha scritto:
Am 05.03.2014 18:30, schrieb Marcel Apfelbaum:
In order to allow attaching machine options to a machine instance,
current_machine is converted into MachineState.
As a first step of deprecating QEMUMachine, some of the functions
were modified to ret
Il 07/03/2014 08:40, Fam Zheng ha scritto:
On Thu, 03/06 11:27, Paolo Bonzini wrote:
We were always truncating the sense size to 96 bytes.
Signed-off-by: Paolo Bonzini
---
hw/scsi/virtio-scsi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/s
Please ignore this patch, it was prematurely sent.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
On 7 March 2014 02:19, Riku Voipio wrote:
> So you agree these patches are the way to go?
I haven't actually reviewed them but I think the idea is right,
yes.
-- PMM
On 7 March 2014 04:09, Xuebing Wang wrote:
>
> On 03/07/2014 03:32 AM, Peter Maydell wrote:
>>
>> This is v4 of the AArch64 system emulation patches, and it's
>> an important milestone -- this is enough to boot a Linux kernel.
>
>
> Does this boot an aarch64 kernel with tcg on x86 host?
Yes, that
On Fri, Mar 7, 2014 at 1:22 AM, Christian Benvenuti (benve)
wrote:
>> -Original Message-
>> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org]
>> On Behalf Of Stefan Hajnoczi
>> Sent: Friday, February 14, 2014 7:58 AM
>> To: Cedric Bosdonnat
>> Cc: Jan Kiszka; qemu-devel; k
On 03/07/2014 12:09 AM, Paolo Bonzini wrote:
Il 06/03/2014 15:39, Andreas Färber ha scritto:
Am 06.03.2014 15:33, schrieb Paolo Bonzini:
Il 06/03/2014 14:37, Mark Wu ha scritto:
Thanks for your reply! I need confirm I am understanding your comments
correctly. I think you're suggesting to tra
Before spapr_vga_init will returned false if the vga is specified by
the command '-device VGA' because vga_interface_type was evaluated to
VGA_NONE. With the change in previous patch of this series,
spapr_vga_init should return true if it's told that the vga will be
initialized in flow of the gener
Some machine (like ppc) initialization code determines if it has
grahicis according to vga_interface_type. In the original code,
vga_interface_type is evaluated to VGA_NONE even if a vga is added
by '-device VGA'. It causes the machine not aware of the graphics
device configured. This patch adds a
Those versions don't fully support __int128_t.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Weil
---
See http://stackoverflow.com/questions/16447808/bug-with-int128-t-in-clang
for more details. Debian wheezy uses clang 3.0 and shows this bug.
I did not test whether the QEMU code will work n
Il 07/03/2014 10:37, Mark Wu ha scritto:
> Before spapr_vga_init will returned false if the vga is specified by
> the command '-device VGA' because vga_interface_type was evaluated to
> VGA_NONE. With the change in previous patch of this series,
> spapr_vga_init should return true if it's told that
Eric Blake writes:
> On 03/05/2014 07:36 PM, Amos Kong wrote:
>> vm_config_groups[] only contains part of the options which have
>> argument, and all options which have no argument aren't added
>> to vm_config_groups[]. Current query-command-line-options only
>> checks options from vm_config_grou
Amos Kong writes:
> vm_config_groups[] only contains part of the options which have
> argument, and all options which have no argument aren't added
> to vm_config_groups[]. Current query-command-line-options only
> checks options from vm_config_groups[], so some options will
> be lost.
>
> We hav
Andreas Färber writes:
> Am 06.03.2014 10:12, schrieb Markus Armbruster:
>> Stefan's patch has been rotting on the list since December. Reposting
>> it together with a patch for a robustness issue I spotted when
>> reviewing it.
>
> Stefan had applied qdev-monitor-test through his block tree, an
Hi Stefan, Christian,
On Fri, 2014-03-07 at 10:16 +0100, Stefan Hajnoczi wrote:
> > I am not applying as a student and I am not offering myself as a mentor (I
> > do not qualify as a mentor), I Just wanted to point out a possible
> > interesting
> > (and challenging) project.
> > I am afraid it w
'make test' is broken at least since commit
baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
to util/, and some of them there split, so add the missing prefix and new
files to fix the compiler and linker errors.
There remain more issues, but these changes allow running the
Am 06.03.2014 um 22:33 hat Peter Maydell geschrieben:
> Ping?
Sorry, somehow this one fell between the cracks.
Thanks, applied to the block branch.
Kevin
> On 21 February 2014 14:03, Peter Maydell wrote:
> > Add 'U' suffixes to avoid undefined behaviour shifting left into
> > the signed bit o
Am 01.03.2014 um 03:08 hat Jeff Cody geschrieben:
> This adds tests for live snapshots, both through the single
> snapshot command, and the transaction group snapshot command.
>
> The snapshots are done through the QMP interface, using the
> following commands for snapshots:
>
> Single snapshot:
Amit Shah wrote:
> Hi Juan,
>
> Here's a compilation of migration-related patches from the list that
> I've reviewed.
>
> For the first patch, I picked Markus's over yours, just because it's
> been on the list longer.
>
>
> The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca9102029
On Fri, Mar 07, 2014 at 01:59:28PM +0530, Nikunj A Dadhania wrote:
> Stefan Hajnoczi writes:
>
> > On Fri, Mar 07, 2014 at 12:34:28PM +1100, Alexey Kardashevskiy wrote:
> >> On 02/21/2014 07:24 PM, Alexander Graf wrote:
> >> >
> >> > On 21.02.2014, at 07:09, Alexey Kardashevskiy wrote:
> >> >
Am 07.03.2014 06:32, schrieb Marcel Apfelbaum:
> On Fri, 2014-03-07 at 00:44 +0100, Andreas Färber wrote:
>> Am 05.03.2014 18:30, schrieb Marcel Apfelbaum:
>>> In order to allow attaching machine options to a machine instance,
>>> current_machine is converted into MachineState.
>>> As a first step
Am 05.03.2014 18:30, schrieb Marcel Apfelbaum:
> +struct MachineState {
> +/*< private >*/
> +Object parent_obj;
> +/*< public >*/
> +
> +char *accel;
> +bool kernel_irqchip;
> +int kvm_shadow_mem;
> +char *kernel;
> +char *initrd;
> +char *append;
> +char *d
Am 05.03.2014 12:30, schrieb Paolo Bonzini:
> Il 05/03/2014 12:05, Andreas Färber ha scritto:
>> Am 04.03.2014 15:00, schrieb Paolo Bonzini:
>>> This series includes all the pending work on QOMifying the memory
>>> backends.
>> [snip]
>>
>> There's also a recent RFC from Chen Fan about how to model
On 3 March 2014 01:43, Xuebing Wang wrote:
> Hi Paolo, Stephen,
>
> The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca91020290:
>
> Merge remote-tracking branch 'remotes/kvm/uq/master' into staging
> (2014-02-27 16:00:31 +)
>
> are available in the git repository at:
>
>
>
Stefan Weil writes:
> 'make test' is broken at least since commit
> baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
> to util/, and some of them there split, so add the missing prefix and new
> files to fix the compiler and linker errors.
I'm curious as why the Travis
Am 07.03.2014 12:19, schrieb Stefan Hajnoczi:
> On Fri, Mar 07, 2014 at 01:59:28PM +0530, Nikunj A Dadhania wrote:
>> Stefan Hajnoczi writes:
>>
>>> On Fri, Mar 07, 2014 at 12:34:28PM +1100, Alexey Kardashevskiy wrote:
On 02/21/2014 07:24 PM, Alexander Graf wrote:
>
> On 21.02.2014, a
Hi all,
I'm using QEMU with ACPI enabled and the "no-shutdown"-option which does
not close the QEMU process after the shutdown is completed.
I would like to show to the user on the guest display that the guest system
is actually shut off - currently I just see the stalled "shutting down"
scree
On 03/02/2014 07:11 PM, Andreas Färber wrote:
> Hi Fabien,
>
> Am 14.02.2014 18:27, schrieb Fabien Chouteau:
>> On 02/14/2014 04:33 PM, Andreas Färber wrote:
>>> As for the other one you'll need to sort our who sends a pull if Blue
>>> doesn't resurface -
>>
>> I didn't see any message about this.
Il 07/03/2014 12:59, Andreas Färber ha scritto:
Am 05.03.2014 12:30, schrieb Paolo Bonzini:
Il 05/03/2014 12:05, Andreas Färber ha scritto:
I didn't review it in-depth yet, but minor technical issues apart, I
think we need to keep NUMA and CPU separate,
I agree.
Here you agreed ...
Compar
Am 07.03.2014 13:06, schrieb Alex Bennée:
>
> Stefan Weil writes:
>
>> 'make test' is broken at least since commit
>> baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
>> to util/, and some of them there split, so add the missing prefix and new
>> files to fix the compile
On Fri, 07 Mar 2014 13:20:45 +0100
Paolo Bonzini wrote:
> Il 07/03/2014 12:59, Andreas Färber ha scritto:
> > Am 05.03.2014 12:30, schrieb Paolo Bonzini:
> >> Il 05/03/2014 12:05, Andreas Färber ha scritto:
> >>> I didn't review it in-depth yet, but minor technical issues apart, I
> >>> think we
Am 07.03.2014 13:40, schrieb Stefan Weil:
> Am 07.03.2014 13:06, schrieb Alex Bennée:
>>
>> Stefan Weil writes:
>>
>>> 'make test' is broken at least since commit
>>> baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
>>> to util/, and some of them there split, so add the mi
Am 07.03.2014 13:56, schrieb Andreas Färber:
> Am 07.03.2014 13:40, schrieb Stefan Weil:
>> Am 07.03.2014 13:06, schrieb Alex Bennée:
>>>
>>> Stefan Weil writes:
>>>
'make test' is broken at least since commit
baacf04799ace72a9c735dd9306a1ceaf305e7cf. Several source files were moved
Signed-off-by: Romain Dolbeau
---
hw/net/e1000.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 4d7204c..8987edd 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -49,7 +49,7 @@ enum {
DEBUG_UNKNOWN, DEBUG
Hello,
Another update to my e1000 patch. See the previous 3 episodes for
the gory details :-)
The first patch is a cleaned-up version of the V3 patch, it should
address most of Andreas' concerns except for a few spaces. The
versioning of E1000Satate should be checked by an expert.
The second pat
Try to implement proper QOM
some cleaning up, and (hopefully proper) E1000State versioning support
Signed-off-by: Romain Dolbeau
---
hw/net/e1000.c | 398 +++
hw/net/e1000_regs.h | 149 ---
2 files changed, 496 insertions(+)
From: Bharata B Rao
Pipe handling mechanism in gluster driver was based on similar implementation
in RBD driver and hence had GPLv2 and associated copyright information.
After changing gluster driver to coroutine based implementation, the pipe
handling code no longer exists and hence change glust
From: Bharata B Rao
Remove the definitions of GLUSTER_FD_WRITE and GLUSTER_FD_READ which are
no longer used. Also sockets.h isn't needed any more.
Signed-off-by: Bharata B Rao
Acked-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/gluster.c | 4
1 file changed, 4 deletions(-)
di
The following changes since commit f55ea6297cc0224fe4934b90ff5343b620b14669:
block/gluster: Add missing argument to qemu_gluster_init() call (2014-03-04
20:20:57 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/086 | 65 ++
tests/qemu-iotests/086.out | 18 +
tests/qemu-iotests/group | 1 +
3 files changed, 84 insertions(+)
create mode 100755 tests/qemu-iotests/086
create mode 100644 tests/qe
From: Max Reitz
The bdrv_create() implementation of the block/raw-win32 "file" protocol
driver should strip the "file:" prefix from filenames if present.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block/raw-win32.c | 2 ++
1 file
From: Benoît Canet
Moving only the node_name one field could lead to some inconsitencies where a
node_name was defined on a bs which was not registered in the graph node list.
bdrv_swap between a named node bs and a non named node bs would lead to this.
bdrv_make_anon would then crash because i
Using an invalid option for a block device that is opened with
BDRV_O_PROTOCOL led to drv = NULL, and when trying to include the driver
name in the error message, qemu dereferenced it:
$ x86_64-softmmu/qemu-system-x86_64 -drive file=/tmp/test.qcow2,file.foo=bar
Segmentation fault (core dum
From: Max Reitz
The "file" protocol driver should strip the "file:" prefix from
filenames if present.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block/raw-win32.c | 12
1 file changed, 12 insertions(+)
diff --git a/
Il 07/03/2014 13:56, Igor Mammedov ha scritto:
However, I'd still like it to be mostly a container, and that is why I
liked the idea of having /node[n] with "flat" links to the actual
CPUStates (and also memdevs).
Is there a point in having flat links to CPUState at /nodeX level,
Easily getti
From: Peter Maydell
Add 'U' suffixes to avoid undefined behaviour shifting left into
the signed bit of a signed integer type. Clang's sanitizer will
warn about this:
hw/ide/ahci.c:1210:27: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'
Signed-off-by: Peter May
From: Max Reitz
The "file" protocol driver should strip the "file:" prefix from
filenames if present.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 12
1 file changed, 12 insertions(+)
diff --git a/
On 03/07/2014 06:20 AM, Romain Dolbeau wrote:
> Signed-off-by: Romain Dolbeau
> ---
> hw/net/e1000.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
> if (++s->eecd_state.bitnum_in == 9 && !s->eecd_state.reading) {
> -s->eecd_state.bitnum_out = ((s->eecd
On 7 March 2014 13:19, Stefan Weil wrote:
> test-i386 does some calculations and prints the results (see source code
> tests/tcg/test-i386.c). If the user mode emulation of QEMU works, it
> should not matter whether that executable runs native or emulated and
> both outputs be identical. They aren
From: Max Reitz
The bdrv_create() implementation of the block/raw-posix "file" protocol
driver should strip the "file:" prefix from filenames if present.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 2 ++
1 file
If aio=native, we check that cache.direct is set as well. If however
cache wasn't specified at all, qemu just segfaulted.
The old condition didn't make any sense anyway because it effectively
only checked for the default cache mode case, but not for an explicitly
set cache.direct=off mode.
Signed
Encrypted images need a password before they can be used, and we don't
want blockdev-add to create BDSes that aren't fully initialised. So for
now simply forbid encrypted images; we can come back to it later if we
need the functionality.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
blo
This bug is still present in qemu 1.7.0:
qemu-system-mips64el: g364: invalid read at [00102000]
qemu-system-mips64el: hw/scsi/scsi-bus.c:1578: scsi_req_data: Assertion
`req->cmd.mode != SCSI_XFER_NONE' failed.
./nt4mips.sh: line 3: 26409 Aborted (core dumped)
./qemu-syste
On Thu, 06 Mar 2014 13:21:21 +0100
Markus Armbruster wrote:
> Wenchao Xia writes:
>
> > This series address two issues:
> >
> > 1. support using enum as discriminator in union.
> > For example, if we have following define in qapi schema:
> > { 'enum': 'EnumOne',
> > 'data': [ 'value1', 'value
On Tue, 4 Mar 2014 18:44:30 -0800
Wenchao Xia wrote:
> This series address two issues:
>
> 1. support using enum as discriminator in union.
> For example, if we have following define in qapi schema:
> { 'enum': 'EnumOne',
> 'data': [ 'value1', 'value2', 'value3' ] }
>
> { 'type': 'UserDefBas
This bug is apparently fixed in 1.7.0 and can be closed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1245924
Title:
mips64el magnum emulation broken
Status in QEMU:
New
Bug description:
I'm
For sg backends, bs->request_alignment is meaningless and may be 0.
Signed-off-by: Kevin Wolf
Reviewed-by: Benoit Canet
Acked-by: Paolo Bonzini
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 38bbdf3..f01b91c 100644
--- a/block.c
+++ b/bl
F_GETOWN is replaced by F_GETOWN_EX inside the glibc fcntl wrapper
Signed-off-by: Andreas Schwab
---
Only tested so far with the gnulib test-fcntl module, which mainly tests
proper error handling only.
---
linux-user/syscall.c | 36
linux-user/syscall_de
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1245924
Title:
mips64el magnum emulation broken
Status in QEMU:
Fix Released
Bug description
The current iscsi block driver code makes the rather arbitrary decision
that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all
other device types are disks.
Instead of this, check for TYPE_DISK to expose the disk interface and
make everything else bs->sg = 1. In particular, this in
Wenchao Xia writes:
> By default, any union will automatically generate a enum type as
> "[UnionName]Kind" in C code, and it is duplicated when the discriminator
> is specified as a pre-defined enum type in schema. After this patch,
> the pre-defined enum type will be really used as the switch ca
From: Jeff Cody
This adds tests for live snapshots, both through the single
snapshot command, and the transaction group snapshot command.
The snapshots are done through the QMP interface, using the
following commands for snapshots:
Single snapshot:
{ 'execute': 'blockdev-snapshot-sync', 'argume
On 03/06/2014 11:32 AM, Peter Maydell wrote:
> +/**
> + * tlb_vaddr_to_host:
> + * @env: CPUArchState
> + * @addr: guest virtual address to look up
> + * @mmu_idx: MMU index to use for lookup
> + *
> + * Look up the specified guest virtual index in the TCG softmmu TLB.
> + * If the TLB contains a h
Initialise progress output only when the -p and -q options have already
been parsed, otherwise it's always disabled.
Reported-by: Peter Lieven
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
qemu-img.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --gi
Signed-off-by: Kevin Wolf
Reviewed-by: Benoit Canet
---
tests/qemu-iotests/087 | 122 +
tests/qemu-iotests/087.out | 40 +++
tests/qemu-iotests/group | 1 +
3 files changed, 163 insertions(+)
create mode 100755 tests/qemu-iotests/
On Fri, 07 Mar 2014 14:35:09 +0100
Paolo Bonzini wrote:
> Il 07/03/2014 13:56, Igor Mammedov ha scritto:
> >> However, I'd still like it to be mostly a container, and that is why I
> >> liked the idea of having /node[n] with "flat" links to the actual
> >> CPUStates (and also memdevs).
> >
> > Is
From: Max Reitz
Currently, bdrv_file_open() always removes the "filename" option from
the options QDict after bdrv_parse_filename() has been (successfully)
called. However, for drivers with bdrv_needs_filename, it makes more
sense for bdrv_parse_filename() to overwrite the "filename" option and
f
From: Jeff Cody
Originally, this built up the error message with the backing filename,
so that errp was set as follows:
error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename);
However, we now propagate the local_error from the
bdrv_open_backing_file() call instead, making these 2 lines use
Quoting Paolo Bonzini (pbonz...@redhat.com):
> Il 07/03/2014 04:31, Serge Hallyn ha scritto:
> >Hi,
> >
> >At https://bugs.launchpad.net/bugs/1284793 it was found that commit
> >a66e657e: "pci/pcie: convert PCIE hotplug to use hotplug-handler API"
> >seems to break vga passthrough. Reverting that
On 7 March 2014 14:51, Richard Henderson wrote:
> On 03/06/2014 11:32 AM, Peter Maydell wrote:
>> +/**
>> + * tlb_vaddr_to_host:
>> + * @env: CPUArchState
>> + * @addr: guest virtual address to look up
>> + * @mmu_idx: MMU index to use for lookup
>> + *
>> + * Look up the specified guest virtual i
From: "Aneesh Kumar K.V"
After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including
hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs
rules doesn't depend on variable defined in Makefile.objs
Tested-by: Serge Hallyn
Signed-off-by: Aneesh Kumar K.V
---
Make
From: Chen Gang
When "goto err_out", 'v9fs_string' already was allocated, so still need
free 'v9fs_string' before return.
Signed-off-by: Chen Gang
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-local.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9
From: Chen Gang
When path is truncated by PATH_MAX limitation, it causes QEMU to access
incorrect file. So use original full path instead of PATH_MAX within
9pfs (need check/process ENOMEM for related memory allocation).
The related test:
- Environments (for qemu-devel):
- Host is under fe
Hi,
Please pull the below update for VirtFS
The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21:
xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000)
are available in the git repository at:
https://github.com/kvaneesh/qemu.git for-upstream
for you to fet
From: Markus Armbruster
readlink() returns the number of bytes written to the buffer, and it
doesn't write a terminating null byte. do_readlink() writes it
itself. Overruns the buffer when readlink() filled it completely.
Fix by reserving space for the null byte when calling readlink(), like
w
From: Chen Gang
'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so
need use snprintf() instead of sprintf() just like another area have done
in 9pfs. This could possibly result in the truncation of pathname, which we
address in the follow up patch.
Signed-off-by: Chen Gang
On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote:
> On 03/06/2014 05:40 PM, Marcelo Tosatti wrote:
> >
> > Failing initialization in case hugepage path has
> > hugepage smaller than specified.
> >
> > Signed-off-by: Marcelo Tosatti
> >
> > diff --git a/exec.c b/exec.c
> > index b69fd
On Fri, Mar 07, 2014 at 08:53:50AM +0100, Paolo Bonzini wrote:
> Il 07/03/2014 01:40, Marcelo Tosatti ha scritto:
> >
> >Failing initialization in case hugepage path has
> >hugepage smaller than specified.
> >
> >Signed-off-by: Marcelo Tosatti
>
>
> Why is this needed? Isn't it just operator er
On 03/07/2014 07:11 AM, Peter Maydell wrote:
>> > cpu_stb_data doesn't take into account user vs kernel mode accesses.
> ...so what does it use for the mmu index?
>
Oops, read the macro garbage incorrectly. It does make its way back to
cpu_mmu_index.
r~
We're about to release 2.0, so it would be more interesting to know
whether it still happens in latest qemu.git.
And since this seems to depend on .iso and nvram.bin files that we don't
have available for reproducing, some tracing on your part might help
narrow down whether this is caused by a bug
Am 07.03.2014 16:16, schrieb Aneesh Kumar K.V:
> From: "Aneesh Kumar K.V"
>
> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including
> hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs
> rules doesn't depend on variable defined in Makefile.objs
>
> Tested
1 - 100 of 166 matches
Mail list logo
