Re: [Qemu-devel] [RFC] support memory reserved feature and optimize mlock guest memory propose

2014-03-06 Thread Zhanghailiang
> Il 05/03/2014 09:01, Zhanghailiang ha scritto: > > Hi all: > > > > Currently, we use cgroup(memory) to support memory QoS on KVM > > platform, and use "mlock" on qemu to support "memory reserved". > > > > The "mlock" seems to be not appropriate. > > > > Now qemu "mlock" memory in the main thread

[Qemu-devel] [PATCH] scsi: Fix migration of scsi sense data

2014-03-06 Thread Fam Zheng
c5f52875 changed the size of sense array in vmstate_scsi_device by mistake. This patch restores the old size, and add a subsection for the remaining part of the buffer size. So that migration is not broken. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 30 +++

Re: [Qemu-devel] [PATCH V9 00/10] qapi script: support enum as discriminator and better enum name

2014-03-06 Thread Markus Armbruster
Wenchao Xia writes: > This series address two issues: > > 1. support using enum as discriminator in union. > For example, if we have following define in qapi schema: > { 'enum': 'EnumOne', > 'data': [ 'value1', 'value2', 'value3' ] } > > { 'type': 'UserDefBase0', > 'data': { 'base-string0': '

Re: [Qemu-devel] [RFC] support memory reserved feature and optimize mlock guest memory propose

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 09:06, Zhanghailiang ha scritto: > >> Il 05/03/2014 09:01, Zhanghailiang ha scritto: >>> Hi all: >>> >>> Currently, we use cgroup(memory) to support memory QoS on KVM >>> platform, and use "mlock" on qemu to support "memory reserved". >>> >>> The "mlock" seems to be not appropriate.

Re: [Qemu-devel] [PATCH] scsi: Fix migration of scsi sense data

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 09:26, Fam Zheng ha scritto: c5f52875 changed the size of sense array in vmstate_scsi_device by mistake. This patch restores the old size, and add a subsection for the remaining part of the buffer size. So that migration is not broken. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bu

[Qemu-devel] [PATCH 1/1] s390/kvm: Add Maintainers for s390/kvm

2014-03-06 Thread Christian Borntraeger
Lets add Conny and myself as maintainers for s390/kvm and related code. This does not include any tcg related code, which is maintained by Richard and Alex. Signed-off-by: Christian Borntraeger Acked-by: Cornelia Huck --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a

[Qemu-devel] [PATCH 0/1] s390/kvm maintainership

2014-03-06 Thread Christian Borntraeger
Alex, we finally managed to get the paper work finished. Can you Ack the following maintainership change? Peter, can you apply afterwards? Christian Borntraeger (1): s390/kvm: Add Maintainers for s390/kvm MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) -- 1.7.9.5

Re: [Qemu-devel] [PATCH V9 07/10] qapi script: support enum type as discriminator in union

2014-03-06 Thread Markus Armbruster
Wenchao Xia writes: > By default, any union will automatically generate a enum type as > "[UnionName]Kind" in C code, and it is duplicated when the discriminator > is specified as a pre-defined enum type in schema. After this patch, > the pre-defined enum type will be really used as the switch ca

Re: [Qemu-devel] [PATCH v3] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

2014-03-06 Thread Romain Dolbeau
2014-03-05 17:55 GMT+01:00 Andreas Färber : >> +DBGOUT(UNKNOWN, "Flash unknown write >> addr=0x%08x,val=0x%08"PRIx64"\n", >> + index<<2, val); > Spaces There's a handful of place like that where I just duplicated lines - this particular warning is a duplicate from a similar

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-06 Thread Gerd Hoffmann
On Mi, 2014-03-05 at 09:48 -0500, Gabriel L. Somlo wrote: > On Wed, Mar 05, 2014 at 11:59:44AM +0100, Gerd Hoffmann wrote: > > > -static bool smbios_type1_defaults = true; > > > +static bool smbios_defaults = true; > > > /* Make sure that guest addresses aligned at 1Gbyte boundaries get > > > map

[Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust

2014-03-06 Thread Markus Armbruster
Stefan's patch has been rotting on the list since December. Reposting it together with a patch for a robustness issue I spotted when reviewing it. Markus Armbruster (1): qdev-monitor-test: Don't test human-readable error message Stefan Hajnoczi (1): qdev-monitor-test: simplify using g_assert

[Qemu-devel] [PATCH v2 2/2] qdev-monitor-test: Don't test human-readable error message

2014-03-06 Thread Markus Armbruster
Test the error class instead. Expecting a specific message is fragile. In fact, it broke once already, in commit 75884af. Restore the test of error member "class" dropped there, and drop the test of error member "desc". There are no other tests of "desc" as far as I can tell. Signed-off-by: Ma

[Qemu-devel] [PATCH v2 1/2] qdev-monitor-test: simplify using g_assert_cmpstr()

2014-03-06 Thread Markus Armbruster
From: Stefan Hajnoczi Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3). This simplifies the code since we no longer have to play games to distinguish NULL from "" using "(null)". gcc extension haters will also be happy that ?: was dropped. Suggested-by: Markus Armbruster Sig

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-06 Thread Dr. David Alan Gilbert
* Huangpeng (Peter) (peter.huangp...@huawei.com) wrote: > Hi David > > Where can I get your post-copy git tree? > I wish to take a look into it first before start live-snapshot design. It's not yet published, as soon as it shows signs of life and I tidy it up I'll get it out there. Dave -- Dr. D

[Qemu-devel] [PATCH v4 1/2] qemu-option: introduce qemu_find_opts_singleton

2014-03-06 Thread Igor Mammedov
From: Paolo Bonzini Reviewed-by: Laszlo Ersek Reviewed-by: Andreas Färber Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov --- include/qemu/config-file.h |2 ++ util/qemu-config.c | 14 ++ vl.c | 11 +-- 3 files changed, 17 i

[Qemu-devel] [PATCH v4 0/2] convert -m to QemuOpts

2014-03-06 Thread Igor Mammedov
changes since v3: - fix not completed option renaming s/mem/size/ changes since v2 suggested by Andreas Färber: - s/fprintf/error_report/ - rename 'mem' option to 'size' - CCing to qemu-trivial changes since v1: - check for overflow - check for empty mem="" case - reshuffle code to avoid c

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 02:12:20PM +, anton.iva...@kot-begemot.co.uk wrote: Please don't put "New feature - " in the commit message. "net: " or "l2tpv3: " would be a good prefix (see git-log(1) for other examples). The idea behind using a prefix is that you can immediately determine which are

Re: [Qemu-devel] [PATCH v3 2/2] vl: convert -m to QemuOpts

2014-03-06 Thread Igor Mammedov
On Wed, 05 Mar 2014 18:04:23 +0100 Andreas Färber wrote: > Am 05.03.2014 17:10, schrieb Igor Mammedov: > > Adds option to -m > > "size" - startup memory amount > > > > For compatibility with legacy CLI if suffix-less number is passed, > > it assumes amount in Mb. > > > > Otherwise user is free

Re: [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups

2014-03-06 Thread Claudio Fontana
On Tuesday, March 4, 2014, Richard Henderson wrote: > This is an initial split of a 40+ patch set for aarch64. These should > all be totally non-controversial and easy to review. > > > r~ > > > Richard Henderson (10): > tcg-aarch64: Enable builtin disassembler > tcg-aarch64: Remove redundant

[Qemu-devel] [PATCH v4 2/2] vl: convert -m to QemuOpts

2014-03-06 Thread Igor Mammedov
Adds option to -m "size" - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in Mb. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v3 2/2] vl: convert -m to QemuOpts

2014-03-06 Thread Igor Mammedov
On Wed, 05 Mar 2014 13:33:43 -0700 Eric Blake wrote: > On 03/05/2014 09:10 AM, Igor Mammedov wrote: > > Adds option to -m > > "size" - startup memory amount > > > > For compatibility with legacy CLI if suffix-less number is passed, > > it assumes amount in Mb. > > > > Otherwise user is free to

Re: [Qemu-devel] kill /destroy a VM - help

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 06:35:18PM +0200, Alexander Binun wrote: > Now we encountered yet one problem: Our security module (which is a LKM) > performs security check and, when suspecting malicious activity at a VCPU, > must suspend or even kill this VM. The problem is: how to suspend/kill a VCPU

[Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H

2014-03-06 Thread Xuebing Wang
Hi Community, I am not sure if there is value for this patchset. After the first pach: Size of x86_64-softmmu/qemu-system-x86_64 is unchanged. Size of sh4-softmmu/qemu-system-sh4 increases by about 2.8KB. Xuebing Wang (7): kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H"

[Qemu-devel] [PATCH 5/7] kvm-ppc: fix build for ppc64-softmmu

2014-03-06 Thread Xuebing Wang
The build issue was caused by the patch of removing "#if defined CONFIG_KVM || !defined NEED_CPU_H" Signed-off-by: Xuebing Wang --- target-ppc/kvm_ppc.h | 12 1 file changed, 12 insertions(+) diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h index 5f78e4b..c532d2a 100644 -

[Qemu-devel] [PATCH] virtio-scsi: actually honor sense_size from configuration space

2014-03-06 Thread Paolo Bonzini
We were always truncating the sense size to 96 bytes. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6610b3a..b0d7517 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scs

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-06 Thread Anton Ivanov
On 06/03/14 09:44, Stefan Hajnoczi wrote: On Wed, Mar 05, 2014 at 02:12:20PM +, anton.iva...@kot-begemot.co.uk wrote: Please don't put "New feature - " in the commit message. "net: " or "l2tpv3: " would be a good prefix (see git-log(1) for other examples). The idea behind using a prefix is

[Qemu-devel] [PATCH 3/7] kvm-i386: remove target-i386/kvm-stub.c

2014-03-06 Thread Xuebing Wang
To eliminate kvm-stub for target-i386. Size of text section of x86_64-linux-user/qemu-x86_64 is reduced by 104 bytes by inline these 2 functions. Signed-off-by: Xuebing Wang --- include/sysemu/kvm.h |3 --- target-i386/Makefile.objs |1 - target-i386/cpu.c |2 +- target

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 03:44:17PM +0100, Peter Lieven wrote: > [PATCH] block: introduce BDRV_O_SEQUENTIAL It hasn't shown up on the mailing list yet. I received it privately because I am CCed but it needs to be on the list in order to get review and be merged. Anthony: how can Peter troubleshoo

[Qemu-devel] [PATCH 1/7] kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H"

2014-03-06 Thread Xuebing Wang
There is no direct relevance between CONFIG_KVM and NEED_CPU_H. Thus logic of why using "#if defined CONFIG_KVM || !defined NEED_CPU_H" is hard to explain and hard to understand. The root cause is that we can not *always* get correct CONFIG_KVM, because: - CONFIG_KVM is defined in [*-softmmu | *

[Qemu-devel] [PATCH 2/7] kvm-i386: fix build for x86_64-linux-user after applying previous patch

2014-03-06 Thread Xuebing Wang
As explained in previous patch, kvm functions won't be optimized out for non-CONFIG_KVM. Signed-off-by: Xuebing Wang --- target-i386/kvm-stub.c |6 -- 1 file changed, 6 deletions(-) diff --git a/target-i386/kvm-stub.c b/target-i386/kvm-stub.c index 2b9e801..0ef642d 100644 --- a/target-i

[Qemu-devel] [PATCH 6/7] kvm-ppc: remove target-ppc/kvm-stub.c

2014-03-06 Thread Xuebing Wang
Size of text section of ppc64-softmmu/qemu-system-ppc64 is reduced by 152 bytes. Signed-off-by: Xuebing Wang --- include/hw/ppc/openpic.h |1 - target-ppc/Makefile.objs |1 - target-ppc/kvm-stub.c| 18 -- target-ppc/kvm_ppc.h |5 + 4 files changed, 5 ins

Re: [Qemu-devel] kill /destroy a VM - help

2014-03-06 Thread Alexander Binun
Thanks for the rapid answer ! On Thu 06 Mar 12:22 2014 Stefan Hajnoczi wrote: > On Wed, Mar 05, 2014 at 06:35:18PM +0200, Alexander Binun wrote: > > Now we encountered yet one problem: Our security module (which is a LKM) > > performs security check and, when suspecting malicious activity at a VC

[Qemu-devel] [PATCH 4/7] kvm: fix build for target sh4-softmmu

2014-03-06 Thread Xuebing Wang
The build issue was caused by the patch of removing "#if defined CONFIG_KVM || !defined NEED_CPU_H" Signed-off-by: Xuebing Wang --- kvm-stub.c |1 + 1 file changed, 1 insertion(+) diff --git a/kvm-stub.c b/kvm-stub.c index e979f76..f859249 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -22,6 +

Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field.

2014-03-06 Thread Kevin Wolf
Am 05.03.2014 um 23:48 hat Benoît Canet geschrieben: > Moving only the node_name one field could lead to some inconsitencies where a > node_name was defined on a bs which was not registered in the graph node list. > > bdrv_swap between a named node bs and a non named node bs would lead to this. >

[Qemu-devel] [PATCH 7/7] kvm-i386: fix build for "x86_64-softmmu --disable-kvm"

2014-03-06 Thread Xuebing Wang
Probably no one uses disable-kvm for x86_64. Also move 3 kvm-i386 function declarations from sysemu/kvm.h => target-i386/kvm_i386.h - kvm_pc_gsi_handler() - kvm_pc_setup_irq_routing() - kvm_i8259_init() Signed-off-by: Xuebing Wang --- hw/i386/kvm/i8259.c|2 +- hw/i386/kvm/ioapic.c

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: Add Maintainers for s390/kvm

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 09:49, Christian Borntraeger ha scritto: Lets add Conny and myself as maintainers for s390/kvm and related code. This does not include any tcg related code, which is maintained by Richard and Alex. Signed-off-by: Christian Borntraeger Acked-by: Cornelia Huck --- MAINTAINERS |

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 07:09:13PM +0100, Peter Lieven wrote: > Am 05.03.2014 18:38, schrieb Marcus: > > On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: > >> So you can confirm my oberservations and would be happy if > >> this behaviour could be toggled with a cmdline switch? > > Yes, I've see

Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function

2014-03-06 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 10:35:48AM -0500, Jeff Cody wrote: > Originally, this built up the error message with the backing filename, > so that errp was set as follows: > error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); > > However, we now propagate the local_error from the > bdrv_open_

Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field.

2014-03-06 Thread Kevin Wolf
Am 05.03.2014 um 23:48 hat Benoît Canet geschrieben: > Moving only the node_name one field could lead to some inconsitencies where a > node_name was defined on a bs which was not registered in the graph node list. > > bdrv_swap between a named node bs and a non named node bs would lead to this. >

Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function

2014-03-06 Thread Kevin Wolf
Am 04.03.2014 um 16:35 hat Jeff Cody geschrieben: > Originally, this built up the error message with the backing filename, > so that errp was set as follows: > error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); > > However, we now propagate the local_error from the > bdrv_open_backing_f

Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote: > Smatch complains about several global symbols which should be local. > > Add the missing 'static' attributes and move the 'extern' declaration > of variable qemuio_misalign to qemu-io.h. This variable also changes > the type from 'int'

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-03-06 Thread Gonglei
On 2014/3/6 0:18, Juan Quintela wrote: > "Gonglei (Arei)" wrote: >> Add counters to log the times of updating the dirty bitmap. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei > > As told by Eric, I am with this change, but can we move the code to the > same place that the rest of the

[Qemu-devel] Solaris 10 x86 not booting with -icount

2014-03-06 Thread Sai Prajeeth
Hi list, I am unable to boot the solaris 10 x86 (32-bit) operating system on qemu when i use the -icount 1 option. I get the error "qemu: Fatal: Raised an Interrupt while not in I/O function" I tried different values for icount but still i am not able to get it working. I compiled qemu from sourc

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-06 Thread Markus Armbruster
Amos Kong writes: > vm_config_groups[] only contains part of the options which have > argument, and all options which have no argument aren't added > to vm_config_groups[]. Current query-command-line-options only > checks options from vm_config_groups[], so some options will > be lost. > > We hav

Re: [Qemu-devel] Solaris 10 x86 not booting with -icount

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 11:50, Sai Prajeeth ha scritto: Hi list, I am unable to boot the solaris 10 x86 (32-bit) operating system on qemu when i use the -icount 1 option. I get the error "qemu: Fatal: Raised an Interrupt while not in I/O function" I tried different values for icount but still i am not ab

Re: [Qemu-devel] kill /destroy a VM - help

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 11:31, Alexander Binun ha scritto: Then - more questions : 1. How can I access the Qemu process (relevant to a given VM) from within in the kernel context (being in a kernel module) ? The struct pid for the VCPU is in the "pid" field of struct kvm_vcpu. From there if needed y

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 11:29, Stefan Hajnoczi ha scritto: On Wed, Mar 05, 2014 at 03:44:17PM +0100, Peter Lieven wrote: [PATCH] block: introduce BDRV_O_SEQUENTIAL It hasn't shown up on the mailing list yet. I received it privately because I am CCed but it needs to be on the list in order to get review

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-03-06 Thread Alex Bennée
Janne Grunau writes: > On 2014-02-25 15:54:37 +, Alex Bennée wrote: >> >> Have you got the log file "unsupported" line? I seem to recall you did >> ping me but maybe it was just on IRC? I just want to make sure I >> do the right ones. I'm working on this now. > > We spoke on irc about it. a

Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 04:11, Alexey Kardashevskiy ha scritto: Previously libvirt required the first/default PCI bus to have name "pci". Since QEMU can support multiple buses now, libvirt wants "pci.0" now. This removes custom busname and lets QEMU make up default names. Signed-off-by: Alexey Kardashevs

Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming

2014-03-06 Thread Daniel P. Berrange
On Thu, Mar 06, 2014 at 12:47:28PM +0100, Paolo Bonzini wrote: > Il 06/03/2014 04:11, Alexey Kardashevskiy ha scritto: > >Previously libvirt required the first/default PCI bus to have name "pci". > >Since QEMU can support multiple buses now, libvirt wants "pci.0" now. > > > >This removes custom bus

Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 12:50, Daniel P. Berrange ha scritto: I'd like to see this change done across all machines, not just this ppc one, so that libvirt can do 1 single version check and know that the new naming applies for everything from that point. Yes, I'll take care of the other machines. Paolo

Re: [Qemu-devel] [PATCH V9 07/10] qapi script: support enum type as discriminator in union

2014-03-06 Thread Wenchao Xia
于 2014/3/6 16:25, Markus Armbruster 写道: > Wenchao Xia writes: > >> By default, any union will automatically generate a enum type as >> "[UnionName]Kind" in C code, and it is duplicated when the discriminator >> is specified as a pre-defined enum type in schema. After this patch, >> the pre-defined

Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 11:27, Xuebing Wang ha scritto: Hi Community, I am not sure if there is value for this patchset. I am not sure this is too useful, since after all the code works and the patches are tricky. I'd be more interested in seeing work done to remove qemu-common.h and cpu.h inclusion

Re: [Qemu-devel] [PATCH V9 00/10] qapi script: support enum as discriminator and better enum name

2014-03-06 Thread Markus Armbruster
Wenchao Xia writes: > This series address two issues: > > 1. support using enum as discriminator in union. > For example, if we have following define in qapi schema: > { 'enum': 'EnumOne', > 'data': [ 'value1', 'value2', 'value3' ] } > > { 'type': 'UserDefBase0', > 'data': { 'base-string0': '

Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames

2014-03-06 Thread Kevin Wolf
Am 05.03.2014 um 22:41 hat Max Reitz geschrieben: > The "file" protocol drivers (block/raw-posix and block/raw-win32) may be > explicitly selected by prepending a "file:" prefix to a filename (as > with all other block protocols). However, currently, they do not strip > this prefix as they should.

Re: [Qemu-devel] [PATCH 1/5] block: Keep "filename" option after parsing

2014-03-06 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:41:36 (+0100), Max Reitz wrote : > Currently, bdrv_file_open() always removes the "filename" option from > the options QDict after bdrv_parse_filename() has been (successfully) > called. However, for drivers with bdrv_needs_filename, it makes more > sense for bdrv_par

Re: [Qemu-devel] [PATCH 2/5] block/raw-posix: Implement bdrv_parse_filename()

2014-03-06 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:41:37 (+0100), Max Reitz wrote : > The "file" protocol driver should strip the "file:" prefix from > filenames if present. > > Signed-off-by: Max Reitz > --- > block/raw-posix.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/block/raw-posix

Re: [Qemu-devel] [PATCH V9 07/10] qapi script: support enum type as discriminator in union

2014-03-06 Thread Luiz Capitulino
On Thu, 06 Mar 2014 19:54:33 +0800 Wenchao Xia wrote: > 于 2014/3/6 16:25, Markus Armbruster 写道: > > Wenchao Xia writes: > > > >> By default, any union will automatically generate a enum type as > >> "[UnionName]Kind" in C code, and it is duplicated when the discriminator > >> is specified as a p

Re: [Qemu-devel] [PATCH 3/5] block/raw-posix: Strip "file:" prefix on creation

2014-03-06 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:41:38 (+0100), Max Reitz wrote : > The bdrv_create() implementation of the block/raw-posix "file" protocol > driver should strip the "file:" prefix from filenames if present. > > Signed-off-by: Max Reitz > --- > block/raw-posix.c | 2 ++ > 1 file changed, 2 inserti

Re: [Qemu-devel] [PATCH 4/5] block/raw-win32: Implement bdrv_parse_filename()

2014-03-06 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:41:39 (+0100), Max Reitz wrote : > The "file" protocol driver should strip the "file:" prefix from > filenames if present. > > Signed-off-by: Max Reitz > --- > block/raw-win32.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/block/raw-win32

Re: [Qemu-devel] [PATCH 5/5] block/raw-win32: Strip "file:" prefix on creation

2014-03-06 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 22:41:40 (+0100), Max Reitz wrote : > The bdrv_create() implementation of the block/raw-win32 "file" protocol > driver should strip the "file:" prefix from filenames if present. > > Signed-off-by: Max Reitz > --- > block/raw-win32.c | 2 ++ > 1 file changed, 2 inserti

Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 13:57:55 (+0100), Kevin Wolf wrote : > Am 05.03.2014 um 22:41 hat Max Reitz geschrieben: > > The "file" protocol drivers (block/raw-posix and block/raw-win32) may be > > explicitly selected by prepending a "file:" prefix to a filename (as > > with all other block protocol

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-03-06 Thread Juan Quintela
Gonglei wrote: > On 2014/3/6 0:18, Juan Quintela wrote: > >> "Gonglei (Arei)" wrote: >>> Add counters to log the times of updating the dirty bitmap. >>> >>> Signed-off-by: ChenLiang >>> Signed-off-by: Gonglei >> >> As told by Eric, I am with this change, but can we move the code to the >> same

Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-03-06 Thread Mark Wu
On 02/28/2014 09:03 PM, Paolo Bonzini wrote: Il 28/02/2014 13:45, Mark Wu ha scritto: Some machine (like ppc) initialization code determines if it has vga configured according to vga_interface_type. In the original code, vga_interface_type is evaluated to VGA_NONE even if a vga is added by '-dev

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-06 Thread Mike Day
Alexey Kardashevskiy writes: > This adds migration support for OHCI. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/usb/hcd-ohci.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index e38cdeb..c42e091

[Qemu-devel] [PATCH] vnc: fix use-after-free in vnc_update_client_sync

2014-03-06 Thread Gerd Hoffmann
Spotted by Coverity: 876 static int vnc_update_client_sync(VncState *vs, int has_dirty) 877 { (1) Event freed_arg:"vnc_update_client(VncState *, int)" frees "vs". [details] Also see events:[deref_arg] 878 int ret = vnc_update_client(vs, has_dirty); (2) Event deref_

[Qemu-devel] [PATCH V2 for 2.0 1/2] block: Add node-name and to-replace-node-name arguments to drive-mirror.

2014-03-06 Thread Benoît Canet
node-name gives a name to the created BDS and registers it in the node graph. to-replace-node-name can be used when drive-mirror is called with sync=full. The purpose of these fields is to be able to reconstruct and replace a broken quorum file. drive-mirror will bdrv_swap the new BDS named node

[Qemu-devel] [PATCH V2 for 2.0 2/2] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

2014-03-06 Thread Benoît Canet
The the to-replace-node-name is designed to allow repairing of broken Quorum file. This patch introduce a new class TestRepairQuorum testing that the feature works. Some further work will be done on QEMU to improve the robutness of the tests. Signed-off-by: Benoit Canet --- tests/qemu-iotests/04

[Qemu-devel] [PATCH V2 for 2.0 0/2] Allow to repair broken quorum files

2014-03-06 Thread Benoît Canet
I would like to make this series merge in 2.0 before hard freeze because it would allow a production usage of quorum so it would let me move on the rest of the block filter infrastructure.(throttling as filter, filter insertion and removal etc..) in v2: Fix typos and spelling mistakes [Eric]

[Qemu-devel] [Bug 1288620] [NEW] memory leak with default NIC model

2014-03-06 Thread Aidan Gauland
Public bug reported: I have a Windows 7 SP1 Professional 64-bit installation on a QCOW2 image with compat=1.1, which I launch via qemu-system-x86_64 -drive file=windows_base_HDD.img,index=0,media=disk -enable-kvm -m 512M -vga std -net nic,vlan=0 -net user,vlan=0 As soon as I start using the netw

Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 14:37, Mark Wu ha scritto: Thanks for your reply! I need confirm I am understanding your comments correctly. I think you're suggesting to traverse the pci devices and check if it owns the I/O port 0x3d4 to detect if the vga device is initialized.But it seems not be able to res

Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-03-06 Thread Andreas Färber
Am 06.03.2014 15:33, schrieb Paolo Bonzini: > Il 06/03/2014 14:37, Mark Wu ha scritto: >> Thanks for your reply! I need confirm I am understanding your comments >> correctly. I think you're suggesting to traverse the pci devices and >> check if it owns the I/O port 0x3d4 to detect if the vga devi

Re: [Qemu-devel] [PATCH 1/7] kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H"

2014-03-06 Thread Andreas Färber
Am 06.03.2014 11:27, schrieb Xuebing Wang: > Advantage of applying this patch is: logic is clear > Disadvantage is: binary code for non-CONFIG_KVM target is bigger > (like sh4-softmmu or *-linux-user) > - kvm_enabled() is always runtime (kvm_allowed), and compiler won't optimize

Re: [Qemu-devel] [PATCH] block: qemu-iotests 085 - live snapshots tests

2014-03-06 Thread Benoît Canet
The Friday 28 Feb 2014 à 21:08:11 (-0500), Jeff Cody wrote : > This adds tests for live snapshots, both through the single > snapshot command, and the transaction group snapshot command. > > The snapshots are done through the QMP interface, using the > following commands for snapshots: > > Single

Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements

2014-03-06 Thread Jason J. Herne
On 02/28/2014 11:30 AM, Andreas Färber wrote: Am 26.02.2014 18:18, schrieb Jason J. Herne: From: "Jason J. Herne" Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow m

Re: [Qemu-devel] [PATCH] vnc: fix use-after-free in vnc_update_client_sync

2014-03-06 Thread Markus Armbruster
Gerd Hoffmann writes: > Spotted by Coverity: > > 876 static int vnc_update_client_sync(VncState *vs, int has_dirty) > 877 { > > (1) Event freed_arg:"vnc_update_client(VncState *, int)" frees "vs". > [details] > Also see events:[deref_arg] > > 878 int ret = vnc_update

[Qemu-devel] [PATCH] seccomp: add getrusage() to the syscall whitelist for Open vSwitch

2014-03-06 Thread Paul Moore
When QEMU is used with Open vSwitch it is common to create netdev script and downscript scripts that use the ovs-vsctl command to manage the underlying network devices. Unfortunately, ovs-vsctl calls the getrusage() syscall which is not currently present in the QEMU/seccomp whistelist. Signed-off

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: Add Maintainers for s390/kvm

2014-03-06 Thread Alexander Graf
> Am 06.03.2014 um 16:49 schrieb Christian Borntraeger : > > Lets add Conny and myself as maintainers for s390/kvm and > related code. This does not include any tcg related code, > which is maintained by Richard and Alex. > > Signed-off-by: Christian Borntraeger > Acked-by: Cornelia Huck Woo

Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H

2014-03-06 Thread Andreas Färber
Hi, Am 06.03.2014 11:27, schrieb Xuebing Wang: > I am not sure if there is value for this patchset. > > After the first pach: > Size of x86_64-softmmu/qemu-system-x86_64 is unchanged. > Size of sh4-softmmu/qemu-system-sh4 increases by about 2.8KB. > > Xuebing Wang (7): > kvm: remove the hack "

[Qemu-devel] [PATCH] block: Fix error path segfault in bdrv_open()

2014-03-06 Thread Kevin Wolf
Using an invalid option for a block device that is opened with BDRV_O_PROTOCOL led to drv = NULL, and when trying to include the driver name in the error message, qemu dereferenced it: $ x86_64-softmmu/qemu-system-x86_64 -drive file=/tmp/test.qcow2,file.foo=bar Segmentation fault (core dum

[Qemu-devel] [PATCH 0/3] blockdev: blockdev-add error path fixes and tests

2014-03-06 Thread Kevin Wolf
Kevin Wolf (3): blockdev: Fail blockdev-add with encrypted images blockdev: Fix NULL pointer dereference in blockdev-add qemu-iotests: Test a few blockdev-add error cases blockdev.c | 15 -- tests/qemu-iotests/087 | 122 +

[Qemu-devel] [PATCH 3/3] qemu-iotests: Test a few blockdev-add error cases

2014-03-06 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/087 | 122 + tests/qemu-iotests/087.out | 40 +++ tests/qemu-iotests/group | 1 + 3 files changed, 163 insertions(+) create mode 100755 tests/qemu-iotests/087 create mode 100644 tes

[Qemu-devel] [PATCH 2/3] blockdev: Fix NULL pointer dereference in blockdev-add

2014-03-06 Thread Kevin Wolf
If aio=native, we check that cache.direct is set as well. If however cache wasn't specified at all, qemu just segfaulted. The old condition didn't make any sense anyway because it effectively only checked for the default cache mode case, but not for an explicitly set cache.direct=off mode. Signed

[Qemu-devel] [PATCH 1/3] blockdev: Fail blockdev-add with encrypted images

2014-03-06 Thread Kevin Wolf
Encrypted images need a password before they can be used, and we don't want blockdev-add to create BDSes that aren't fully initialised. So for now simply forbid encrypted images; we can come back to it later if we need the functionality. Signed-off-by: Kevin Wolf --- blockdev.c | 9 - 1

[Qemu-devel] [PATCH 2/2] pc: option rom migration compatibility with 1.7

2014-03-06 Thread Michael S. Tsirkin
when using 1.7 machine types, enable option ROMs in RAM to match that version. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1acd2b2..99c7a3a 100644 --- a/hw/i386/

Re: [Qemu-devel] kill /destroy a VM - still hangs!

2014-03-06 Thread Alexander Binun
Hello Friends, Thanks to your help I have found the task structure of the target process (denote it as TASK) and its group leader (TASK->tgid) Now I did the following: struct siginfo info; .. info.si_signo = SIGTERM; info.si_code = SI_QUEUE; info.si_errno = 0; /* no recovery */ sta

Re: [Qemu-devel] [PATCH] block: Fix error path segfault in bdrv_open()

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 16:42:12 (+0100), Kevin Wolf wrote : > Using an invalid option for a block device that is opened with > BDRV_O_PROTOCOL led to drv = NULL, and when trying to include the driver > name in the error message, qemu dereferenced it: > > $ x86_64-softmmu/qemu-system-x86_64

[Qemu-devel] [PATCH 1/2] pc: avoid duplicate names for ROM MRs

2014-03-06 Thread Michael S. Tsirkin
Since commit 04920fc0faa4760f9c4fc0e73b992b768099be70 loader: store FW CFG ROM files in RAM RAM MRs including ROM files in FW CFGs are created and named using the file basename. This becomes problematic if these names are supplied by user, since the basename might not be unique. There are two

Re: [Qemu-devel] [PATCH 1/3] blockdev: Fail blockdev-add with encrypted images

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 16:44:27 (+0100), Kevin Wolf wrote : > Encrypted images need a password before they can be used, and we don't > want blockdev-add to create BDSes that aren't fully initialised. So for > now simply forbid encrypted images; we can come back to it later if we > need the func

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-03-06 Thread Janne Grunau
On 2014-03-06 11:40:47 +, Alex Bennée wrote: > > Janne Grunau writes: > > > On 2014-02-25 15:54:37 +, Alex Bennée wrote: > >> > > >> Have you got the log file "unsupported" line? I seem to recall you did > >> ping me but maybe it was just on IRC? I just want to make sure I > >> do the r

Re: [Qemu-devel] [PATCH 2/3] blockdev: Fix NULL pointer dereference in blockdev-add

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 16:44:28 (+0100), Kevin Wolf wrote : > If aio=native, we check that cache.direct is set as well. If however > cache wasn't specified at all, qemu just segfaulted. > > The old condition didn't make any sense anyway because it effectively > only checked for the default cac

Re: [Qemu-devel] [PATCH V2 for 2.0 2/2] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 15:06:22 (+0100), Benoît Canet wrote : > The the to-replace-node-name is designed to allow repairing of broken Quorum > file. > This patch introduce a new class TestRepairQuorum testing that the feature > works. > Some further work will be done on QEMU to improve the robu

Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 15:39, Andreas Färber ha scritto: > Am 06.03.2014 15:33, schrieb Paolo Bonzini: >> Il 06/03/2014 14:37, Mark Wu ha scritto: >>> Thanks for your reply! I need confirm I am understanding your comments >>> correctly. I think you're suggesting to traverse the pci devices and >>> check i

Re: [Qemu-devel] [PATCH] seccomp: add getrusage() to the syscall whitelist for Open vSwitch

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 15:50, Paul Moore ha scritto: When QEMU is used with Open vSwitch it is common to create netdev script and downscript scripts that use the ovs-vsctl command to manage the underlying network devices. Unfortunately, ovs-vsctl calls the getrusage() syscall which is not currently prese

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-06 Thread Gabriel L. Somlo
On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: > > You don't need to worry about live migration, but the smbios stuff > clearly goes into the guest-visible change category. > > smbios_type1_defaults is one of the compatibility controls. It is false > for 1.7 (+older) machine type

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test a few blockdev-add error cases

2014-03-06 Thread Benoît Canet
The Thursday 06 Mar 2014 à 16:44:29 (+0100), Kevin Wolf wrote : > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/087 | 122 > + > tests/qemu-iotests/087.out | 40 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 163 i

Re: [Qemu-devel] [PATCH 1/2] pc: avoid duplicate names for ROM MRs

2014-03-06 Thread Marcel Apfelbaum
On Thu, 2014-03-06 at 17:48 +0200, Michael S. Tsirkin wrote: > Since > commit 04920fc0faa4760f9c4fc0e73b992b768099be70 > loader: store FW CFG ROM files in RAM > RAM MRs including ROM files in FW CFGs are created > and named using the file basename. > > This becomes problematic if these names a

[Qemu-devel] [Bug 1288620] Re: memory leak with default NIC model

2014-03-06 Thread Stefan Weil
Please try to reproduce this with a debug built (configure --enable- debug) from latest QEMU. If it shows the same memory leak, you can try to find the cause of this leak with valgrind: valgrind --leak-check=full qemu-system-x86_64 -drive file=windows_base_HDD.img,index=0,media=disk -enable-kvm -m

Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming

2014-03-06 Thread Andreas Färber
Am 06.03.2014 04:11, schrieb Alexey Kardashevskiy: > Previously libvirt required the first/default PCI bus to have name "pci". > Since QEMU can support multiple buses now, libvirt wants "pci.0" now. > > This removes custom busname and lets QEMU make up default names. > > Signed-off-by: Alexey Kar

Re: [Qemu-devel] [PATCH 1/2] pc: avoid duplicate names for ROM MRs

2014-03-06 Thread Michael S. Tsirkin
On Thu, Mar 06, 2014 at 06:14:11PM +0200, Marcel Apfelbaum wrote: > On Thu, 2014-03-06 at 17:48 +0200, Michael S. Tsirkin wrote: > > Since > > commit 04920fc0faa4760f9c4fc0e73b992b768099be70 > > loader: store FW CFG ROM files in RAM > > RAM MRs including ROM files in FW CFGs are created > > and

  1   2   3   4   >