Il 06/03/2014 11:27, Xuebing Wang ha scritto:
Hi Community,
I am not sure if there is value for this patchset.
I am not sure this is too useful, since after all the code works and the
patches are tricky.
I'd be more interested in seeing work done to remove qemu-common.h and
cpu.h inclusions from header files, and possibly splitting TCG-specific
parts out of exec-all.h. I hope we convinced you that this is the right
thing to do for such central files.
Paolo
After the first pach:
Size of x86_64-softmmu/qemu-system-x86_64 is unchanged.
Size of sh4-softmmu/qemu-system-sh4 increases by about 2.8KB.
Xuebing Wang (7):
kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H"
kvm-i386: fix build for x86_64-linux-user after applying previous
patch
kvm-i386: remove target-i386/kvm-stub.c
kvm: fix build for target sh4-softmmu
kvm-ppc: fix build for ppc64-softmmu
kvm-ppc: remove target-ppc/kvm-stub.c
kvm-i386: fix build for "x86_64-softmmu --disable-kvm"
hw/i386/kvm/i8259.c | 2 +-
hw/i386/kvm/ioapic.c | 2 +-
hw/i386/pc_piix.c | 2 +-
hw/i386/pc_q35.c | 2 +-
include/hw/i386/pc.h | 1 -
include/hw/ppc/openpic.h | 1 -
include/sysemu/kvm.h | 18 ------------------
kvm-stub.c | 1 +
target-i386/Makefile.objs | 1 -
target-i386/cpu.c | 2 +-
target-i386/kvm-stub.c | 30 ------------------------------
target-i386/kvm_i386.h | 32 ++++++++++++++++++++++++++++++++
target-ppc/Makefile.objs | 1 -
target-ppc/kvm-stub.c | 18 ------------------
target-ppc/kvm_ppc.h | 17 +++++++++++++++++
15 files changed, 55 insertions(+), 75 deletions(-)
delete mode 100644 target-i386/kvm-stub.c
delete mode 100644 target-ppc/kvm-stub.c