2014-03-05 17:55 GMT+01:00 Andreas Färber <afaer...@suse.de>: >> + DBGOUT(UNKNOWN, "Flash unknown write >> addr=0x%08x,val=0x%08"PRIx64"\n", >> + index<<2, val); > Spaces
There's a handful of place like that where I just duplicated lines - this particular warning is a duplicate from a similar one about MMIO access. Do I add the spaces to match the rules, or do I left them out to match everything else in the file ? >> - pci_register_bar(pci_dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &d->io); >> + pci_register_bar(pci_dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &d->flash); >> + >> + pci_register_bar(pci_dev, 2, PCI_BASE_ADDRESS_SPACE_IO, &d->io); > I wonder if this change is migration-compatible? I must confess I didn't think about migration. I don't have much of a choice; the e1000e driver requires the second mapping to be the flash registers, if I understand the code correctly. > Spaces around << at least please, not sure about file's surrounding > style - Stefan's call. As before - copy/pasting from a few lines above, so the style matches the file. Cordially, -- Romain Dolbeau
