[Qemu-devel] [PULL 24/38] input: keyboard: switch cocoa ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 8661777..d4af3e5 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -514,16 +514,14 @@ QemuCocoaView *cocoaView; if (keycode) {

[Qemu-devel] [PULL 38/38] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2014-02-28 Thread Gerd Hoffmann
From: Dave Airlie I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu compatible ones. I'm stil

[Qemu-devel] [PULL 37/38] console: add QemuUIInfo

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 ui/console.c | 17 + 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index b2af53e..08a38ea 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Peter Maydell
On 28 February 2014 14:12, Alex Bennée wrote: > Is this "simply" a case of having a precise state in/around syscalls? No. > AIUI we already have such a mechanism for dealing with faults in > translated code so this is all aimed at when an asynchronous signal > arrives somewhere in QEMU's own cod

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Alexander Graf
> Am 28.02.2014 um 22:21 schrieb Peter Maydell : > >> On 28 February 2014 14:12, Alex Bennée wrote: >> Is this "simply" a case of having a precise state in/around syscalls? > > No. > >> AIUI we already have such a mechanism for dealing with faults in >> translated code so this is all aimed at

[Qemu-devel] [PULL 02/38] input: rename file to legacy

2014-02-28 Thread Gerd Hoffmann
Rename ui/input.c to ui/input-legacy.c. We are going to replace it step by step. Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 2 +- ui/{input.c => input-legacy.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename ui/{input.c => input-legacy.c} (100%) diff --git a/

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-28 Thread Peter Lieven
On 27.02.2014 09:57, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the sourc

[Qemu-devel] [PATCH] linux-user: correct handling of break exception for MIPS

2014-02-28 Thread Petar Jovanovic
From: Petar Jovanovic Exception with break instruction has not been correctly propagated as SIGTRAP. This resolves crash issues with examples that use break instruction on MIPS. Signed-off-by: Petar Jovanovic --- linux-user/main.c |4 1 file changed, 4 insertions(+) diff --git a/linu

Re: [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-02-28 Thread Marcelo Tosatti
On Thu, Feb 27, 2014 at 07:30:26PM +0100, Paolo Bonzini wrote: > Il 04/02/2014 19:41, Marcelo Tosatti ha scritto: > > > >-mem-prealloc asks to preallocate memory residing on -mem-path path. > > > >Currently QEMU exits in case: > > > >- Memory file has been created but allocation via explicit write

[Qemu-devel] [PULL 16/38] input: mouse: add graphic_rotate support

2014-02-28 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 33 ++

[Qemu-devel] [PULL 12/38] input: keyboard: switch vnc ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..4658559 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -33,6 +33,7 @@ #include "qapi/qmp/types.h" #include "qmp-commands.h" #incl

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Peter Maydell
On 28 February 2014 14:27, Alexander Graf wrote: > Could we check the instruction at the sognaling pc and check > if it's a known syscall instruction? No need to replace glibc > wrappers then. No, because the behaviour we want for "started handling syscall in qemu" through to "PC anything up to b

[Qemu-devel] [PULL 34/38] input: move do_mouse_set to new core

2014-02-28 Thread Gerd Hoffmann
This removes the last user of the lecagy input mouse handler list, so we can remove more legacy bits with this. Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 43 --- ui/input.c| 21 + 2 files changed, 21 insertions(+), 43

[Qemu-devel] [PULL 23/38] input: mouse: switch monitor to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- monitor.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index aebcbd8..d019141 100644 --- a/monitor.c +++ b/monitor.c @@ -39,6 +39,7 @@ #include "monitor/monitor.h" #include "qemu/readl

Re: [Qemu-devel] [PATCH] target-arm: Fix incorrect setting of E bit in CPSR

2014-02-28 Thread Peter Maydell
On 28 February 2014 13:40, Peter Maydell wrote: > Commit 4cc35614a moved the exception mask bits out of env->uncached_cpsr > and into env->daif. However the env->daif contents are AArch64 style > mask bits, which include not just the AArch32 AIF bits but also the > new D bit (masks debug exception

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Alex Bennée
Michael Matz writes: > Hi, > > On Tue, 25 Feb 2014, Peter Maydell wrote: > >> On 25 February 2014 13:33, Michael Matz wrote >> > The biggest road-block is that signal vs syscall handling is >> > fundamentally broken in linux-user and it's unfixable without >> > assembler implementations of the

[Qemu-devel] [PULL 32/38] input: add input_mouse_mode tracepoint

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 1 + ui/input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/trace-events b/trace-events index b1dd4d1..7238451 100644 --- a/trace-events +++ b/trace-events @@ -1027,6 +1027,7 @@ input_event_btn(int conidx, const char *btn, bool down) "c

[Qemu-devel] [PULL 22/38] input: mouse: switch spice ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 62 ++-- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index c9df699..6dab23b 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -98,4

[Qemu-devel] [PULL 33/38] input: move qmp_query_mice to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 23 --- ui/input.c| 29 + 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 7f8e72b..7843482 100644 --- a/ui/input-legacy.c +++ b

[Qemu-devel] [PULL 35/38] input: remove index_from_keycode (no users)

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 14 -- 2 files changed, 15 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 9a282cb..3bf69ee 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -329,7 +329,6 @

[Qemu-devel] [PULL 19/38] input: mouse: switch gtk ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 58 +++--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 74c0936..1851495 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -194,7 +194,7 @@ static void gd_update_curs

[Qemu-devel] [PULL 01/38] console: export QemuConsole index, width, height

2014-02-28 Thread Gerd Hoffmann
Add functions to query QemuConsole properties. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 +++ ui/console.c | 24 2 files changed, 27 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 4156a87..8543d18 100644 --- a/inclu

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Alexey Kardashevskiy
On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: > On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: >> Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: > > Each of them highlights one of the two aspects that, in my opinion, make > QOM interesting (respectively, unification of int

[Qemu-devel] [PULL 25/38] input: mouse: switch cocoa ui to new core

2014-02-28 Thread Gerd Hoffmann
Build fixes by Peter Maydell. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 ++ ui/cocoa.m | 63 ++-- 2 files changed, 44 insertions(+), 21 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 8543d18.

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: Each of them highlights one of the two aspects that, in my opinion, make QOM interest

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Eric Blake
On 02/28/2014 07:00 AM, Paolo Bonzini wrote: > Il 28/02/2014 14:40, Eric Blake ha scritto: >> These should probably be 'int', not 'str'. If you have to hand-parse a >> string into a numeric value, you encoded the QMP wrong. > > Eric, note that this is not QMP. It is only used for option parsing.

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Alexey Kardashevskiy
On 03/01/2014 02:05 AM, Paolo Bonzini wrote: > Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: >> On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: >>> On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: >>> >>> Each of them hig

Re: [Qemu-devel] [PATCH 1/1] pc & q35: fix handling of lowmem

2014-02-28 Thread Don Slutz
On 02/28/14 08:35, Gerd Hoffmann wrote: On Do, 2014-02-27 at 15:01 -0500, Don Slutz wrote: Without this, asking for 3.25G on memory for pc-i440fx-2.0 does not adjust the pci hole to start at 3G. Asking for 3.75G does do this adjustment. This is intentional. If we can fit all ram into low memo

[Qemu-devel] [PULL 06/38] input: add core bits of the new input layer

2014-02-28 Thread Gerd Hoffmann
Register and unregister handlers. Event dispatcher code. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 32 + ui/Makefile.objs | 2 +- ui/input.c | 83 ++ 3 files changed, 116 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 18/38] input: mouse: switch legacy handlers to new core

2014-02-28 Thread Gerd Hoffmann
legacy mouse event handlers are registered in the new core, so they receive events submitted to the new input core. legacy kbd_mouse_event() continues to use the old code paths. So new-core event handlers wouldn't see events submitted via kbd_mouse_event. This leads to the constrain that we we mu

[Qemu-devel] [PATCH v5 0/7] dataplane: switch to N:M devices-per-thread model

2014-02-28 Thread Stefan Hajnoczi
v5: * Use Igor's get_pointer() malloc string patch [Igor] * Add object_get_canonical_basename() and use it for iothread_get_id() [Igor] v4: * Rename qdev property to virtio-blk-pci,x-iothread= since we will switch to QOM links once object_property_add_link() is fixed [bonzini] v3: * Fixed

[Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename()

2014-02-28 Thread Stefan Hajnoczi
It is often useful to find an object's child property name. Also use this new function to simplify the implementation of object_get_canonical_path(). Signed-off-by: Stefan Hajnoczi --- include/qom/object.h | 8 qom/object.c | 53 ++--

[Qemu-devel] [PATCH v5 7/7] dataplane: replace internal thread with IOThread

2014-02-28 Thread Stefan Hajnoczi
Today virtio-blk dataplane uses a 1:1 device-per-thread model. Now that IOThreads have been introduced we can generalize this to N:M devices per threads. This patch drops thread code from dataplane in favor of running inside an IOThread AioContext. As a bonus we solve the case where a guest keep

[Qemu-devel] [PATCH v5 2/7] rfifolock: add recursive FIFO lock

2014-02-28 Thread Stefan Hajnoczi
QemuMutex does not guarantee fairness and cannot be acquired recursively: Fairness means each locker gets a turn and the scheduler cannot cause starvation. Recursive locking is useful for composition, it allows a sequence of locking operations to be invoked atomically by acquiring the lock around

[Qemu-devel] [PATCH v5 4/7] iothread: add I/O thread object

2014-02-28 Thread Stefan Hajnoczi
This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop threads, allowing users to define them. When SMP guests run on SMP hosts it makes s

[Qemu-devel] [PULL 10/38] input: keyboard: switch gtk ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a633d89..74c0936 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -59,6 +59,7 @@ #include "trace.h" #include "ui/console.h" +#include "ui/input.h

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 16:06, Eric Blake ha scritto: On 02/28/2014 07:00 AM, Paolo Bonzini wrote: Il 28/02/2014 14:40, Eric Blake ha scritto: These should probably be 'int', not 'str'. If you have to hand-parse a string into a numeric value, you encoded the QMP wrong. Eric, note that this is not QMP.

[Qemu-devel] [PATCH v5 3/7] aio: add aio_context_acquire() and aio_context_release()

2014-02-28 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

[Qemu-devel] [PULL 27/38] input-legacy: remove kbd_put_keycode

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 23 --- 2 files changed, 24 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index a3062d0..c7f4e4f 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -46,7

[Qemu-devel] [PATCH v5 6/7] iothread: add "iothread" qdev property type

2014-02-28 Thread Stefan Hajnoczi
Add a "iothread" qdev property type so devices can be hooked up to an IOThread from the comand-line: qemu -object iothread,id=iothread0 \ -device some-device,x-iothread=iothread0 Note that Paolo Bonzini has suggested using QOM links instead. This way the relationship between the object

Re: [Qemu-devel] [PATCH] linux-user: correct handling of break exception for MIPS

2014-02-28 Thread Andreas Färber
Hi, Am 28.02.2014 15:25, schrieb Petar Jovanovic: > From: Petar Jovanovic > > Exception with break instruction has not been correctly propagated as > SIGTRAP. This resolves crash issues with examples that use break > instruction on MIPS. > > Signed-off-by: Petar Jovanovic > --- > linux-user/m

[Qemu-devel] [PULL v3 00/38] rework input handling, sdl2 support

2014-02-28 Thread Gerd Hoffmann
Hi, The input layer moves to a model modeled roughly after the linux event layer. It also uses qapi to create all the data types needed. First, because it is convinient to have all the support code generated, and also to make it easier to integrate with qmp some day. Porting work has only be d

[Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings

2014-02-28 Thread Stefan Hajnoczi
From: Igor Mammedov get_pointer()'s print() callback might return a heap allocated string, to avoid adding dedicated get_pointer_foo for this case convert current print() callbacks to return temporary heap allocated string and make get_pointer() free it. Signed-off-by: Igor Mammedov Signed-off-

[Qemu-devel] [PULL 31/38] input: move mouse mode notifier to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 include/ui/input.h | 4 ui/input-legacy.c| 34 +- ui/input.c | 30 ++ 4 files changed, 35 insertions(+), 37 deletions(-) diff --git a/include/ui/cons

[Qemu-devel] [PULL 30/38] input-legacy: remove kbd_mouse_event

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 49 - 2 files changed, 50 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 21b32e4..71a0da3 100644 --- a/include/ui/console.h +++ b/incl

[Qemu-devel] [PULL 04/38] input: qapi: add unmapped key

2014-02-28 Thread Gerd Hoffmann
Simplifies building something -> QkeyCode mapping tables. Uninitialized entries can easily identified then. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- qapi-schema.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index

[Qemu-devel] [PULL 13/38] input: keyboard: switch spice ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 3beb8de..c9df699 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -26,12 +26,15 @@ #include "qemu-common.

[Qemu-devel] [PATCH v4 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-02-28 Thread Lluís Vilanova
Adds the "include(...)" primitive to the syntax of QAPI schema files. Signed-off-by: Lluís Vilanova --- docs/qapi-code-gen.txt |8 scripts/qapi.py| 36 ++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/docs/qapi-code-gen.t

[Qemu-devel] [PATCH v4 0/3] qapi: Allow modularization of QAPI schema files

2014-02-28 Thread Lluís Vilanova
Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova --- Changes in v4: * Rebase on 3e890c7. * Minor cosmetic changes. * Fix recording of included files in case of a cycl

[Qemu-devel] [PATCH v4 1/3] qapi: Use an explicit input file

2014-02-28 Thread Lluís Vilanova
Use an explicit input file on the command-line instead of reading from standard input Signed-off-by: Lluís Vilanova --- Makefile | 24 ++-- docs/qapi-code-gen.txt|4 ++-- scripts/qapi-commands.py

[Qemu-devel] [PATCH v4 3/3] qapi: Add tests for the "include" directive

2014-02-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- tests/Makefile|4 +++- tests/qapi-schema/include-cycle-b.json|1 + tests/qapi-schema/include-cycle-c.json|1 + tests/qapi-schema/include-cycle.err |1 + tests/qapi-schema/include-cycle.exit |1 +

[Qemu-devel] [PULL 21/38] input: mouse: switch vnc ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 46 ++ ui/vnc.h | 1 + 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 4658559..7dfc94a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1484,7 +1484,7 @@ static void client

[Qemu-devel] [PULL 20/38] input: mouse: switch sdl ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 84 ++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index e78e020..b80b3df 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -351,7 +351,7 @@ static void sdl_hide

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:08, schrieb Alexey Kardashevskiy: > On 03/01/2014 02:05 AM, Paolo Bonzini wrote: >> Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: >>> On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: > Il 27/02/2014 15:39, Marc

Re: [Qemu-devel] [PATCH v4 0/3] qapi: Allow modularization of QAPI schema files

2014-02-28 Thread Eric Blake
On 02/28/2014 08:53 AM, Lluís Vilanova wrote: > Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing > these to be modularized into multiple per-topic files in the future. > > Signed-off-by: Lluís Vilanova > --- Series: Reviewed-by: Eric Blake -- Eric Blake eblake

Re: [Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-28 Thread Richard Henderson
On 02/28/2014 12:33 AM, Claudio Fontana wrote: > ping? > > Richard, do you prefer to spin your polishing from last year instead? I do prefer my patch set over this. >> +INSN_IMM = 0x1000, /* 3.4.1, 3.4.4 - add/sub and logical */ >> +INSN_SHIFT = 0x1ac02000, /* 3.5.8 - Data

Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements

2014-02-28 Thread Andreas Färber
Am 26.02.2014 18:18, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Modify s390_cpu_addr2state to allow fetching state information for cpu > addresses > above smp_cpus. Hotplug requires this capability. > > Also add s390_cpu_set_state function to allow modification of ipi_state > entrie

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 16:57, Andreas Färber ha scritto: Am 28.02.2014 16:08, schrieb Alexey Kardashevskiy: On 03/01/2014 02:05 AM, Paolo Bonzini wrote: Il 28/02/2014 16:03, Alexey Kardashevskiy ha scritto: On 02/28/2014 02:04 AM, Marcel Apfelbaum wrote: On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzin

Re: [Qemu-devel] [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value

2014-02-28 Thread Luiz Capitulino
On Mon, 17 Feb 2014 20:01:42 +0200 Marcel Apfelbaum wrote: > On Mon, 2014-02-17 at 10:38 -0700, Eric Blake wrote: > > On 02/17/2014 04:52 AM, Marcel Apfelbaum wrote: > > > A NULL value is not added to visitor's stack, but there > > > is no check for that when the visitor tries to return > > > tha

Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > From: Igor Mammedov > > get_pointer()'s print() callback might return a heap allocated > string, to avoid adding dedicated get_pointer_foo for this case > convert current print() callbacks to return temporary heap > allocated string and make get_poi

Re: [Qemu-devel] migrate to fd - how to use with HMP?

2014-02-28 Thread Stefan Hajnoczi
On Fri, Feb 28, 2014 at 09:30:33PM +1100, Alexey Kardashevskiy wrote: > On 02/28/2014 09:27 PM, Stefan Hajnoczi wrote: > > On Fri, Feb 28, 2014 at 03:05:12PM +1100, Alexey Kardashevskiy wrote: > >> However once socket_scm_helper talked to "mon" (./qemu.monitor), I cannot > >> get any response from

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Alex Bennée
Peter Maydell writes: > On 28 February 2014 14:27, Alexander Graf wrote: >> Could we check the instruction at the sognaling pc and check >> if it's a known syscall instruction? No need to replace glibc >> wrappers then. > > No, because the behaviour we want for "started handling > syscall in qe

Re: [Qemu-devel] [PATCH] linux-user: correct handling of break exception for MIPS

2014-02-28 Thread Petar Jovanovic
> This looks strange. Isn't &*info == info? It is. Just a few lines above, queue_signal is called in the same manner for style/preference reasons I presume, so this patch follows the pattern. Otherwise, it would require to change the other call site too. Regards, Petar __

[Qemu-devel] [PULL 3/3] target-i386: Fix ucomis and comis memory access

2014-02-28 Thread Richard Henderson
We were loading 16 bytes for both single and double-precision scalar comparisons. Reported-by: Alexander Bluhm Signed-off-by: Richard Henderson --- target-i386/translate.c | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/target

Re: [Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename()

2014-02-28 Thread Andreas Färber
Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > It is often useful to find an object's child property name. Also use > this new function to simplify the implementation of > object_get_canonical_path(). > > Signed-off-by: Stefan Hajnoczi > --- > include/qom/object.h | 8 > qom/object.c

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-28 Thread Peter Maydell
On 28 February 2014 17:08, Alex Bennée wrote: > > Peter Maydell writes: > >> On 28 February 2014 14:27, Alexander Graf wrote: >>> Could we check the instruction at the sognaling pc and check >>> if it's a known syscall instruction? No need to replace glibc >>> wrappers then. >> >> No, because th

Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common

2014-02-28 Thread Richard Henderson
On 02/26/2014 01:53 PM, Peter Maydell wrote: > In QEMU we don't make any use at all of the common symbol > functionality, so we can avoid this problem entirely simply > by compiling with -fno-common. Enable this option for all > builds, not just MacOSX, so that if we ever inadvertently > introduce

[Qemu-devel] [PULL 0/3] target-i386 updates

2014-02-28 Thread Richard Henderson
I wasn't able to solicit additional review on patch 3, but at least the first two managed a R-B. r~ The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906: modules: Fix building with --enable-modules (2014-02-28 12:30:13 +) are available in the git repository at:

[Qemu-devel] [PULL 2/3] target-i386: Fix SSE status flag corruption

2014-02-28 Thread Richard Henderson
When we restore the mxcsr register with FXRSTOR, or set it with gdb, we need to update the various SSE status flags in CPUX86State Reported-by: Richard Purdie Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-i386/cpu.h| 3 +++ target-i386/fpu_helper.c | 15 ++

[Qemu-devel] [PULL 1/3] target-i386: Fix CC_OP_CLR vs PF

2014-02-28 Thread Richard Henderson
Parity should be set for a zero result. Cc: qemu-sta...@nongnu.org Reviewed-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target-i386/cc_helper.c | 2 +- target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/targe

[Qemu-devel] [RFC PATCH] qemu: x86: ignore ioapic polarity

2014-02-28 Thread Gabriel L. Somlo
Both QEMU and KVM have already accumulated a significant number of optimizations based on the hard-coded assumption that ioapic polarity will always use the ActiveHigh convention, where the logical and physical states of level-triggered irq lines always match (i.e., active(asserted) == high == 1, i

Re: [Qemu-devel] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Richard Henderson
On 02/26/2014 02:51 PM, Thomas Falcon wrote: > +void ppc_cpu_gdb_swap_register(uint8_t *mem_buf, int n) > +{ > +int len = ppc_cpu_gdb_register_len(n); > +int i = 0; > +uint8_t tmp; > +for (i = 0; i < len/2; i++) { > +tmp = *(mem_buf + i); > +*(mem_buf+i) = *(mem_buf

[Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-02-28 Thread Mario Smarduch
Public bug reported: When using indpendent transport and backend in this case virtio-net- device transport, none of the acceleration features are set after guest probes the transport the backend is plugged into. For virtio-net this leads to low throughput/performance. This holds true for virtio-

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-02-28 Thread Alex Williamson
On Tue, 2014-02-25 at 20:37 -0600, Kim Phillips wrote: > We basically add support for the SysBusDevice type in addition to the > existing PCIDevice support. This involves taking common code from the > existing vfio_initfn(), and putting it under a new vfio_find_get_group(), > that both vfio_initfn

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
Thanks, trivially reproduced. Will bisect. ** Changed in: qemu (Ubuntu) Importance: Undecided => High ** Changed in: qemu (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [PATCH v9 00/14] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-28 Thread Luiz Capitulino
On Tue, 18 Feb 2014 14:11:24 +0800 qiaonuohan wrote: > Hi, all > > The last version is here: > http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg03669.html > > Command 'dump-guest-memory' was introduced to dump guest's memory. But the > vmcore's format is only elf32 or elf64. The messa

Re: [Qemu-devel] [PATCH v5 1/7] object: add object_get_canonical_basename()

2014-02-28 Thread Igor Mammedov
On Fri, 28 Feb 2014 18:15:55 +0100 Andreas Färber wrote: > Am 28.02.2014 16:18, schrieb Stefan Hajnoczi: > > It is often useful to find an object's child property name. Also use > > this new function to simplify the implementation of > > object_get_canonical_path(). > > > > Signed-off-by: Stefa

Re: [Qemu-devel] [PATCH v2] virtio-net: add a field to indicate if vlan table is used

2014-02-28 Thread Luiz Capitulino
On Fri, 21 Feb 2014 18:01:40 +0800 Amos Kong wrote: > On Thu, Feb 20, 2014 at 12:46:14PM -0500, Vlad Yasevich wrote: > > On 02/20/2014 11:38 AM, Amos Kong wrote: > > > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > > > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Peter Maydell
Actually, the interesting bit of the stack trace starts just below where you cut it off, because object_initialize_with_type() is just asserting that it wasn't called with a NULL pointer, so what we really want to know is what the caller was... -- You received this bug notification because you ar

[Qemu-devel] [PULL 4/9] qmp: Fix BlockdevOptionQuorum.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Fix some nits before QEMU 2.0 freeze. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qapi-schema.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index ac8ad24..c3592f6

[Qemu-devel] [PULL 1/9] qemu-iotests: add more tests to the "quick" group

2014-02-28 Thread Stefan Hajnoczi
From: Paolo Bonzini None of these needs QEMU_PROG, and they all take but a few seconds. We need to point the launching script to qemu-nbd, though. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests-quick.sh | 1 + tests/qemu-iotests/group| 34 +

[Qemu-devel] [PULL 0/9] Block patches

2014-02-28 Thread Stefan Hajnoczi
The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca91020290: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-02-27 16:00:31 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch ch

[Qemu-devel] [PULL 8/9] discard rbd error output when not relevant in qemu-iotests

2014-02-28 Thread Stefan Hajnoczi
From: Loic Dachary Suppress rbd progress messages with --no-progress so they are not confused with an error output when comparing test results ( progress is displayed on stderr ). Signed-off-by: Loic Dachary Reviewed-by: Josh Durgin Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/commo

[Qemu-devel] [PULL 6/9] qemu-io-test: Disable Quorum test when not compiled in.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Quorum is not compiled by default: make the quorum 081 test aware of this. Signed-off-by: Benoit Canet Reviewed-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/081 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/081 b/tests/qem

[Qemu-devel] [PULL 2/9] block: gluster - code movements, state storage changes

2014-02-28 Thread Stefan Hajnoczi
From: Jeff Cody In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 41 ++--- 1 file changed, 26 in

[Qemu-devel] [PULL 5/9] qmp: Make Quorum error events more palatable.

2014-02-28 Thread Stefan Hajnoczi
From: Benoît Canet Insert quorum QMP events documentation alphabetically. Also change the "ret" errno value by an optional "error" being an strerror(-ret) in the QUORUM_REPORT_BAD qmp event. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block/quorum.

[Qemu-devel] [PULL 7/9] block: use /var/tmp instead of /tmp for -snapshot

2014-02-28 Thread Stefan Hajnoczi
From: Amit Shah If TMPDIR is not specified, the default was to use /tmp for the working copy of the block devices. Update this to /var/tmp instead, so systems using tmp-on-tmpfs don't end up inadvertently using RAM for the block device. Signed-off-by: Amit Shah Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 3/9] block: gluster - add reopen support.

2014-02-28 Thread Stefan Hajnoczi
From: Jeff Cody Gluster does parse open flags in its .bdrv_open() implementation, and the .bdrv_reopen_* implementations need to do the same. A new gluster connection to the image file to be created is established in the .bdrv_reopen_prepare(), and the image file opened with the new flags. If t

[Qemu-devel] [PULL 9/9] block/vmdk: do not report file offset for compressed extents

2014-02-28 Thread Stefan Hajnoczi
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 83839f9..b69988d 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1184,7

Re: [Qemu-devel] [PATCH] qmp: Check for returned data from __json_read in get_events

2014-02-28 Thread Luiz Capitulino
On Mon, 24 Feb 2014 13:45:01 +0800 Fam Zheng wrote: > When QEMU process aborts and socket is closed, qmp client will not > detect it. When this happens, some qemu-iotests scripts will enter an > endless loop waiting for qmp events. > > It's better we raise an exception in qmp.py to catch this an

Re: [Qemu-devel] [PATCH] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-02-28 Thread Luiz Capitulino
On Tue, 25 Feb 2014 09:42:43 +0100 Hani Benhabiles wrote: > On Tue, Feb 25, 2014 at 09:41:02AM +0100, Markus Armbruster wrote: > > Hani Benhabiles writes: > > > > > The error message as currently used is confusing as there are no > > > "balloon" or > > > "spice" devices. > > > > > > (qemu) bal

Re: [Qemu-devel] [PATCH] monitor: Remove left-over code in do_info_profile.

2014-02-28 Thread Luiz Capitulino
On Wed, 26 Feb 2014 23:09:52 +0100 Hani Benhabiles wrote: > This is a left-over from 4a1418e. > > Signed-off-by: Hani Benhabiles Applied to the qmp branch, thanks. > --- > monitor.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/monitor.c b/monitor.c > index aebcbd8..3863d83 10

[Qemu-devel] [RFC PATCH v2] qemu: x86: ignore ioapic polarity

2014-02-28 Thread Gabriel L. Somlo
Both QEMU and KVM have already accumulated a significant number of optimizations based on the hard-coded assumption that ioapic polarity will always use the ActiveHigh convention, where the logical and physical states of level-triggered irq lines always match (i.e., active(asserted) == high == 1, i

Re: [Qemu-devel] [PATCH v3 0/2] dataplane: add query-iothreads QMP command

2014-02-28 Thread Luiz Capitulino
On Thu, 27 Feb 2014 11:48:40 +0100 Stefan Hajnoczi wrote: > v3: > * Loop until predicate is true to handle pthread_cond spurious wakeups > [eblake] > * Fix additional instances of "thread_id" [eblake] > > v2: > * Use "thread-id" instead of "thread_id" in QAPI [eblake] > * Avoid mutex unlock

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread 陈梁
> On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: >> Add counters to log the times of updating the dirty bitmap. >> >> Signed-off-by: ChenLiang >> Signed-off-by: Gonglei >> --- >> arch_init.c | 20 >> 1 file changed, 20 insertions(+) > > Is it also worth updating MigrationSta

[Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Gabriel L. Somlo
Some guests (e.g. 0S X) insist on a minimum lapic version of 0x14. This patch bumps the emulated lapic version to 0x14 to accomodate that. Signed-off-by: Gabriel L. Somlo --- Along with the TCG ioapic polarity fix, this allows me to boot OS X without KVM acceleration. I dug around the Intel doc

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-28 Thread Joaquim Barrera
On 24/02/14 23:26, Paolo Bonzini wrote: Thanks for raising this. I noticed that mirror_run() does not throttle the first loop where it populates the dirty bitmap using bdrv_is_allocated_above(). This is on purpose. Does it causes a noticeable stall in the guest? The main copy loop does take

Re: [Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
Hm, sadly bisect gives me: ubuntu@c-trusty-0:~/qemu$ git bisect good ba1183da9a10b94611cad88c44a5c6df005f9b55 is the first bad commit commit ba1183da9a10b94611cad88c44a5c6df005f9b55 Author: Fam Zheng Date: Mon Feb 10 14:48:52 2014 +0800 rules.mak: fix $(obj) to a real relative path

Re: [Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
gdb stack dump: Program received signal SIGABRT, Aborted. 0x72849f79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) where #0 0x72849f79 in __GI_raise (sig=sig@entry=6)

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Thomas Falcon
On 02/28/2014 11:37 AM, Richard Henderson wrote: On 02/26/2014 02:51 PM, Thomas Falcon wrote: +void ppc_cpu_gdb_swap_register(uint8_t *mem_buf, int n) +{ +int len = ppc_cpu_gdb_register_len(n); +int i = 0; +uint8_t tmp; +for (i = 0; i < len/2; i++) { +tmp = *(mem_buf + i)

<    1   2   3   >