Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Andreas Färber
Hi, Am 24.02.2014 20:08, schrieb Romain Dolbeau: > Hello, > > This patch adds this ability to select a specific variant of > the e1000 virtual ethernet from the command-line. Previously > only a single device was available, selected at compile time. > This helps for guests with limited hardware s

Re: [Qemu-devel] Question

2014-02-25 Thread Andreas Färber
Am 25.02.2014 07:54, schrieb Atlas Khan: > Plz someone guide me that how I can add new virtual hardware in QEMU? I > tried t get help from already made hardware but it gives me no > idea...Plz someone guide me and tell me detailed process. Please don't post the same question again and agai

Re: [Qemu-devel] [PATCH 3/4] exynos4210: Set reset-cbar property of Cortex-A9 CPUs

2014-02-25 Thread Peter Crosthwaite
On Tue, Feb 25, 2014 at 6:24 AM, Peter Maydell wrote: > Set the reset-cbar property of the Exynos4210 SoC's Cortex-A9 > CPUs, so that Linux doesn't misrecognize them as a broken > uniprocessor SoC. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite But a couple of random notes bel

Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 00:00, Stefan Weil ha scritto: Ah, thanks for explaining. I'll use the suggested name in an updated series. But you are aware that qga/ already includes sysemu/os-posix.h and sysemu/os-win32.h indirectly? Should those two files also be in include/qemu? No, but perhaps part of it s

Re: [Qemu-devel] Add a new hardware

2014-02-25 Thread Andreas Färber
Am 21.02.2014 10:34, schrieb atlas khan: > I am working on project in which we have add support of a board in > QEMU. We have to add some virtual devices in QEMU. The question which > I want to ask that what should I do to add virtual device. And after > adding that device in \hw in which file I ha

Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 06:32, Stefan Weil ha scritto: Am 23.02.2014 18:02, schrieb Stefan Weil: Today, most .o files depend on windows.h when QEMU is built with MinGW or MinGW-w64 (32 and 64 bit builds). These patches reduce the number of such files from more than 1800 to less than 180. They also allow r

Re: [Qemu-devel] [PATCH 2/3] target-i386: Fix SSE status flag corruption

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 08:30, Richard Henderson ha scritto: When we restore the mxcsr register with FXRSTOR, or set it with gdb, we need to update the various SSE status flags in CPUX86State Reported-by: Richard Purdie Signed-off-by: Richard Henderson --- Differs from Purdie's patch primarily in fixing

Re: [Qemu-devel] [PATCH 4/4] virt: Set reset-cbar on CPUs

2014-02-25 Thread Peter Crosthwaite
On Tue, Feb 25, 2014 at 6:24 AM, Peter Maydell wrote: > Set the reset-cbar property on CPUs used by the virt board, > if they have it. This isn't necessary for correct functioning > under Linux (since the A9 isn't a valid CPU for the virt board), > but it is the correct behaviour. > > Signed-off-b

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Markus Armbruster
Eric Blake writes: > On 02/24/2014 01:29 AM, Markus Armbruster wrote: > >>> >>> The other burden is documenting what QOM paths to be queried, and >>> knowing where to find that documentation. That is, it's another layer >>> of complexity, but it's also a more powerful expression. >>> >>> I'm com

Re: [Qemu-devel] [PATCH 2/4] realview-pbx-a9: Set reset-cbar property for CPUs

2014-02-25 Thread Peter Crosthwaite
On Tue, Feb 25, 2014 at 6:24 AM, Peter Maydell wrote: > If the CPU is a Cortex-A9 then we should set its reset-cbar property > so that the guest can read the correct PERIPHBASE/CBAR register value; > newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) > will otherwise assume the CP

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Andreas Färber
Am 25.02.2014 09:25, schrieb Markus Armbruster: > Eric Blake writes: > >> On 02/24/2014 01:29 AM, Markus Armbruster wrote: >> The other burden is documenting what QOM paths to be queried, and knowing where to find that documentation. That is, it's another layer of complexity,

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 09:25, Markus Armbruster ha scritto: > Haven't we already done that in the past? For example, object-add > currently takes an unspecified dictionary of options, where you would > have to consult QOM documentation to learn what makes sense to send. My question isn't about where the

Re: [Qemu-devel] [PATCH] configure: Make C++ test work with --enable-werror

2014-02-25 Thread Andreas Färber
Am 24.02.2014 20:08, schrieb Peter Maydell: > gcc's C++ compiler complains about being passed some -W options > which make sense for C but not for C++. This means we mustn't try > a C++ compile with QEMU_CFLAGS, but only with a filtered version > that removes the offending options. This filtering w

Re: [Qemu-devel] [PATCH v3 22/31] target-arm: A64: Implement MSR (immediate) instructions

2014-02-25 Thread Peter Crosthwaite
On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell wrote: > Implement the MSR (immediate) instructions, which can update the > PSTATE SP and DAIF fields. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > target-arm/helper.h| 2 ++ > target-arm/op_helper.c | 25 +

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Andreas Färber
Am 25.02.2014 09:30, schrieb Paolo Bonzini: > Il 25/02/2014 09:25, Markus Armbruster ha scritto: >>> > Haven't we already done that in the past? For example, object-add >>> > currently takes an unspecified dictionary of options, where you would >>> > have to consult QOM documentation to learn what

Re: [Qemu-devel] [PATCH v3 23/31] target-arm: Implement AArch64 view of CPACR

2014-02-25 Thread Peter Crosthwaite
On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell wrote: > Implement the AArch64 view of the CPACR. The AArch64 > CPACR is defined to have a lot of RES0 bits, but since > the architecture defines that RES0 bits may be implemented > as reads-as-written and we know that a v8 CPU will have > no register

Re: [Qemu-devel] [PATCH v3 24/31] target-arm: Add utility function for checking AA32/64 state of an EL

2014-02-25 Thread Peter Crosthwaite
On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell wrote: > There are various situations where we need to behave differently > depending on whether a given exception level is in AArch64 or > AArch32 state. The state of the current exception level is stored > in env->aarch64, but there's no equivalent

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-25 Thread Andreas Färber
Am 25.02.2014 00:07, schrieb Stefan Weil: > Am 24.02.2014 14:07, schrieb Andreas Färber: >> Am 23.02.2014 18:02, schrieb Stefan Weil: >>> These header files are used by most QEMU source files. If they >>> depend on windows.h, all those source files do so, too. >>> > [...] >> >> First of all, why wa

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-25 Thread Alex Bennée
Dann Frazier writes: > On Mon, Feb 17, 2014 at 6:40 AM, Alex Bennée wrote: >> Hi, > > Thanks to all involved for your work here! > >> After a solid few months of work the QEMU master branch [1] has now reached >> instruction feature parity with the suse-1.6 [6] tree that a lot of people >> have

Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API

2014-02-25 Thread Andreas Färber
Am 25.02.2014 09:20, schrieb Paolo Bonzini: > Il 25/02/2014 06:32, Stefan Weil ha scritto: >> Am 23.02.2014 18:02, schrieb Stefan Weil: >>> Today, most .o files depend on windows.h when QEMU is built with >>> MinGW or >>> MinGW-w64 (32 and 64 bit builds). These patches reduce the number of >>> such

Re: [Qemu-devel] [PATCH] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-02-25 Thread Markus Armbruster
Hani Benhabiles writes: > The error message as currently used is confusing as there are no "balloon" or > "spice" devices. > > (qemu) balloon 1024 > balloon: Device 'balloon' has not been activated > > With this patch: > > (qemu) balloon 1024 > balloon: No balloon device has been activated > > Si

Re: [Qemu-devel] [PATCH 1/4] vexpress: Set reset-cbar property for CPUs

2014-02-25 Thread Peter Crosthwaite
On Tue, Feb 25, 2014 at 6:23 AM, Peter Maydell wrote: > Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) > now assume that if the CPU is a Cortex-A9 and the reset value of the > PERIPHBASE/CBAR register is zero then the CPU is a specific buggy > single core A9 SoC, and will not

Re: [Qemu-devel] [PATCH] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-02-25 Thread Hani Benhabiles
On Tue, Feb 25, 2014 at 09:41:02AM +0100, Markus Armbruster wrote: > Hani Benhabiles writes: > > > The error message as currently used is confusing as there are no "balloon" > > or > > "spice" devices. > > > > (qemu) balloon 1024 > > balloon: Device 'balloon' has not been activated > > > > With

Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

2014-02-25 Thread Peter Crosthwaite
Ping! On Wed, Feb 12, 2014 at 10:27 AM, Peter Crosthwaite wrote: > Hi Andreas, > > Here is a mixed bag of QOM cleanups, moving us slightly closer to > QOMification of SSI. > > This prepares support for some major refactoring around SSI (in > particular some QSPI patches). > > Regards, > Peter > >

Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h

2014-02-25 Thread Peter Crosthwaite
Ping! On Thu, Feb 13, 2014 at 9:21 AM, Peter Crosthwaite wrote: > Hi Edgar, > > This file is written for a very old qdev style of machine description. > Remove by inlining all usages of its functions (which is consistent with > the modern preference that qdev_initery should be inline and not in >

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-25 Thread Andreas Färber
Am 25.02.2014 09:39, schrieb Alex Bennée: > > Dann Frazier writes: > >> On Mon, Feb 17, 2014 at 6:40 AM, Alex Bennée wrote: >>> Hi, >> >> Thanks to all involved for your work here! >> >>> After a solid few months of work the QEMU master branch [1] has now reached >>> instruction feature parity

Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

2014-02-25 Thread Andreas Färber
Am 25.02.2014 09:46, schrieb Peter Crosthwaite: > Ping! Looked good, didn't get to applying them yet. I did wonder though a) why 1/6 is not renaming the parent field to verify and b) whether I can swap d vs. dev naming in one hunk there while at it. Cheers, Andreas > > On Wed, Feb 12, 2014 at 1

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Romain Dolbeau
2014-02-25 9:01 GMT+01:00 Andreas Färber : > > -#define E1000(obj) \ > > -OBJECT_CHECK(E1000State, (obj), TYPE_E1000) > > +#define E1000(obj) \ > > + DO_UPCAST(E1000State, parent_obj, obj) > > No, don't go backwards in time please. Take a look at e.g. eepro100, >

Re: [Qemu-devel] Error compiling qemu from source on Ubuntu 12.10

2014-02-25 Thread Peter Maydell
On 25 February 2014 04:15, Jobin Raju George wrote: > On Mon, Feb 24, 2014 at 5:54 PM, Peter Maydell > wrote: >> Why not just do the git submodule command that the error message >> from configure suggests? You don't need to manually stick the tarball >> into the qemu tree like this. >> > When I d

[Qemu-devel] [PATCH 1/2][RFC] qom: introduce cpu QOM hierarchy tree /machine/node/socket/core/thread/cpu.

2014-02-25 Thread Chen Fan
Signed-off-by: Chen Fan --- include/qom/node.h | 66 +++ qom/Makefile.objs | 2 +- qom/node.c | 156 + 3 files changed, 223 insertions(+), 1 deletion(-) create mode 100644 include/qom/node.h create mode 100644 q

[Qemu-devel] [PATCH 2/2][RFC] cpu: link each new cpu to QOM tree /machine/node/socket/core/thread/cpu respectively.

2014-02-25 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/i386/pc.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 348b15f..4e07ef9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -57,6 +57,7 @@ #include "hw/boards.h" #includ

[Qemu-devel] [PATCH 0/2][RFC] prebuild cpu QOM tree /machine/node/socket/core/thread/..

2014-02-25 Thread Chen Fan
Hi, at present, after hotplug a discontinuous cpu id on source, then done migration, on target, it will fail to add the unoccupied cpu id which was skipped at source, this cause is on target Qemu prebuild CPU with continuous cpu_index. so after migration, the cpu infrastructure bewteen

Re: [Qemu-devel] Error compiling qemu from source on Ubuntu 12.10

2014-02-25 Thread Jobin Raju George
On Tue, Feb 25, 2014 at 2:42 PM, Peter Maydell wrote: > On 25 February 2014 04:15, Jobin Raju George wrote: > > On Mon, Feb 24, 2014 at 5:54 PM, Peter Maydell > > > wrote: > >> Why not just do the git submodule command that the error message > >> from configure suggests? You don't need to manual

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Romain Dolbeau
2014-02-25 9:58 GMT+01:00 Romain Dolbeau : > 2014-02-25 9:01 GMT+01:00 Andreas Färber : > > > @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = { >> > @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = { >> >> I would hope that adding to these two legacy lists is no

Re: [Qemu-devel] Error compiling qemu from source on Ubuntu 12.10

2014-02-25 Thread Peter Maydell
On 25 February 2014 09:19, Jobin Raju George wrote: > On Tue, Feb 25, 2014 at 2:42 PM, Peter Maydell > wrote: >> This looks like you didn't get qemu by cloning it from git (maybe you got >> a tarball?). That's fine but it's not what you said you did... >> > > Exactly! But is there a difference if

[Qemu-devel] [PATCH v3 1/2] include/qemu/crc32c.h: Rename include guards to match filename

2014-02-25 Thread Will Newton
Signed-off-by: Will Newton Reviewed-by: Peter Maydell --- include/qemu/crc32c.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changes in v3: - None diff --git a/include/qemu/crc32c.h b/include/qemu/crc32c.h index 56d1c3b..dafb6a1 100644 --- a/include/qemu/crc32c.h +++ b/include/qe

[Qemu-devel] [PATCH v3 0/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-25 Thread Will Newton
This series adds support for the AArch32 CRC32 instructions added in ARMv8. Will Newton (2): include/qemu/crc32c.h: Rename include guards to match filename target-arm: Add support for AArch32 ARMv8 CRC32 instructions configure | 2 +- include/qemu/crc32c.h | 4 ++-- target-ar

[Qemu-devel] [PATCH v3 2/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-25 Thread Will Newton
Add support for AArch32 CRC32 and CRC32C instructions added in ARMv8. The CRC32-C implementation used is the built-in qemu implementation and The CRC-32 implementation is from zlib. This requires adding zlib to LIBS to ensure it is linked for the linux-user binary. Signed-off-by: Will Newton ---

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Kevin Wolf
Am 21.02.2014 um 15:32 hat Stefan Hajnoczi geschrieben: > On Fri, Feb 21, 2014 at 10:16 AM, Stefan Hajnoczi wrote: > > Maybe I just need some convincing but it seems that QAPI is the simplest > > and cleanest way to define external APIs. > > > > Disagree? Tell me why :). > > I'm replying to myse

[Qemu-devel] [PATCH 06/17] s390x/virtio-hcall: Specification exception for illegal subcodes

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth So far, the DIAG 500 hypervisor call was only setting -EINVAL in R2 when a guest tried to call this function with an illegal subcode. This patch now changes the behavior so that a specification exception is thrown instead, since this is the common behavior of other DIAG function

[Qemu-devel] [PATCH 14/17] s390x/event-facility: exploit realize/unrealize

2014-02-25 Thread Christian Borntraeger
From: Heinz Graalfs init/exit functionality of abstract SCLPEvent class is now exploiting realize/unrealize. Signed-off-by: Heinz Graalfs Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 27 ++- 1 file changed, 18 inserti

[Qemu-devel] [PATCH 04/17] s390x/kvm: Fixed bad SIGP SET-ARCHITECTURE handler

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth The SET-ARCHITECTURE handler in QEMU caused a program interruption. This is wrong according to the "Principles of Operations" specification (since SIGP should never cause a program interrupt) and was likely only introduced for debugging purposes. Since we handle SET-ARCHITECTURE

[Qemu-devel] [PATCH 11/17] s390x/event-facility: some renaming

2014-02-25 Thread Christian Borntraeger
From: Heinz Graalfs Do some renaming to shorten some identifiers and to emphasize sclp. Signed-off-by: Heinz Graalfs Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 13/17] s390x/event-facility: add support for live migration

2014-02-25 Thread Christian Borntraeger
From: Heinz Graalfs Add support for live migration using VMStateDescription. Signed-off-by: Heinz Graalfs Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/s390x/event-facility.c

[Qemu-devel] [PATCH 16/17] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-25 Thread Christian Borntraeger
We have to set the cssid to 0, otherwise the stsch code will return an operand exception without the m bit. In the same way we should set m=0. This case was triggered in some cases during reboot, if for some reason the location of blk_schid.cssid contains 1 and m was 0. Turns out that the qemu elf

[Qemu-devel] [PATCH 10/17] s390x/sclp: Fixed setting of condition code register

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth In the SCLP handler function, the condition code register must only be set if no exception occured. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PATCH 15/17] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-25 Thread Christian Borntraeger
The current code does not initialize next_idx in the virtio ring. As the ccw bios will always use guest memory at a fixed location, this queue might != 0 after a reboot. Lets make the initialization explicit. Signed-off-by: Christian Borntraeger Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/v

[Qemu-devel] [PATCH 03/17] s390x/async_pf: Check for apf extension and enable pfault

2014-02-25 Thread Christian Borntraeger
From: Dominik Dingel S390 can also use async page faults, to enhance guest scheduling. In case of live migration we want to disable the feature and let all pending request finish. Signed-off-by: Dominik Dingel Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- hw/intc/s390

[Qemu-devel] [PATCH 08/17] s390x/sclp: Fixed the size of sccb and code parameter

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth The pointer to the SCCB should not be limited to 32 bits only. In contrast to this, the command word parameter is only 32 bits (the upper 32 bits should be ignored). Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/sclp

[Qemu-devel] [PATCH 2/3] tests: add nbd-fault-injector.py utility

2014-02-25 Thread Stefan Hajnoczi
The nbd-fault-injector.py script is a special kind of NBD server. It throws away all writes and produces zeroes for reads. Given a list of fault injection rules, it can simulate NBD protocol errors and is useful for testing NBD client error handling code paths. See the patch for documentation.

[Qemu-devel] [PATCH 17/17] s390-ccw.img: new binary rom to match latest fixes

2014-02-25 Thread Christian Borntraeger
Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 9336 -> 9336 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 6727f0ca39d6bf6d114974d1535cb7ad9e56355f..f6223e77c2aacfa86652d63b773dc05eca55570d 100644 GIT b

[Qemu-devel] [PATCH 00/17] s390x/kvm: pending patches

2014-02-25 Thread Christian Borntraeger
Anthony, Peter, here is what I have queued for my next pull request. I will wait until the linux header updates move from kvm/queue to kvm/next, which should happen soon. The patch queue is basically the combined queue of things already posted. o https://lists.gnu.org/archive/html/qemu-devel/201

[Qemu-devel] [PATCH 05/17] s390x/virtio-hcall: Add range check for hypervisor call

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth The handler for diag 500 did not check whether the requested function was in the supported range, so illegal values could crash QEMU in the worst case. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger CC: qemu-sta...@nongnu.org ---

[Qemu-devel] [PATCH 0/3] nbd: fix issues when connection breaks

2014-02-25 Thread Stefan Hajnoczi
The first patch ensures the nbd_receive_reply() fd handler is unregistered when the connection to the server breaks. This avoids high CPU consumption and flooding error messages. The second patch introduces an NBD server fault injection script. Using this fake NBD server it is possible to exerci

[Qemu-devel] [PATCH 1/3] nbd: close socket if connection breaks

2014-02-25 Thread Stefan Hajnoczi
nbd_receive_reply() is called by the event loop whenever data is available or the socket has been closed by the remote side. This patch closes the socket when an error occurs to prevent the nbd_receive_reply() handler from being called indefinitely after the connection has failed. Note that we we

[Qemu-devel] [PATCH 02/17] s390x/kvm: implement floating-interrupt controller device

2014-02-25 Thread Christian Borntraeger
From: Jens Freimann This patch implements a floating-interrupt controller device (flic) which interacts with the s390 flic kvm_device. Signed-off-by: Jens Freimann Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- default-configs/s390x-softmmu.mak | 1 + hw/intc/Makefile.

[Qemu-devel] [PATCH 12/17] s390x/event-facility: code restructure

2014-02-25 Thread Christian Borntraeger
From: Heinz Graalfs Code restructure in order to simplify class hierarchy - remove S390SCLPDevice abstract base class and move function pointers into new SCLPEventFacilityClass - implement SCLPEventFacility as SysBusDevice - use define constants for instance creation strings The follow

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Stefan Hajnoczi
On Tue, Feb 25, 2014 at 10:46 AM, Kevin Wolf wrote: > External QOM interfaces have their place, especially for debugging or > trying out things before there is a proper API, but it's not as the > primary external interface. Yes, I agree. Stefan

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-25 Thread Hu Tao
On Wed, Feb 19, 2014 at 10:03:13AM +0100, Paolo Bonzini wrote: <...> > > static int > > ram_backend_memory_init(HostMemoryBackend *backend, Error **errp) > > { > >+HostMemoryBackendRam *ram_backend = MEMORY_BACKEND_RAM(backend); > >+int mode = ram_backend->policy; > >+void *p; > >+

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: add 080 NBD client disconnect tests

2014-02-25 Thread Kevin Wolf
Am 25.02.2014 um 11:09 hat Stefan Hajnoczi geschrieben: > This new test case uses nbd-fault-injector.py to simulate broken TCP > connections at each stage in the NBD protocol. This way we can exercise > block/nbd-client.c's socket error handling code paths. > > In particular, this serves as a reg

Re: [Qemu-devel] [PATCH 2/2] qtest: fix a "!chr->fd_in_tag" assertion error in qtest.

2014-02-25 Thread Gal Hammer
Hi, After reading the code again. It make sense to leave the call to remove_fd_in_watch() because I changed the code so the chr_update_read_handler function is called only when the front end is opened. Submitting a new version of the patch. Gal. - Original Message - From: "Gal Ha

[Qemu-devel] [PATCH V6] char: restore read callback on a reattached (hotplug) chardev

2014-02-25 Thread Gal Hammer
Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred from the host to the guest (e.g. via the virtio-serial port). https://bugzilla.redhat.com/sh

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-25 Thread Hu Tao
On Wed, Feb 19, 2014 at 10:36:57AM +0100, Igor Mammedov wrote: > On Wed, 19 Feb 2014 10:03:13 +0100 > Paolo Bonzini wrote: > > > 19/02/2014 08:54, Hu Tao ha scritto: > > > Thus makes user control how to allocate memory for ram backend. > > > > > > Signed-off-by: Hu Tao > > > --- > > > backend

[Qemu-devel] [PATCH 09/17] s390x/sclp: Add missing checks to SCLP handler

2014-02-25 Thread Christian Borntraeger
From: Thomas Huth If the 51 most significant bits of the SCCB address are zero or equal to the prefix, we should throw an specification exception, too. Also moved the check for privileged mode to sclp_service_call() to have all program checks in one place now. Signed-off-by: Thomas Huth Reviewe

[Qemu-devel] [PATCH 07/17] s390x/eventfacility: mask out commands

2014-02-25 Thread Christian Borntraeger
As a followup to commit 5f04c14a10fa7f259bc0808f35a0beda49f7821e (s390-sclp: Define New SCLP Codes) we should mask the sclp command not only in base sclp, but also in the event facility. Based on an initial patch from Ralf Hoppe. Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.

[Qemu-devel] [PULL 0/1] Lonely uq/master patch for 2014-02-24

2014-02-25 Thread Paolo Bonzini
Anthony, Peter, The following changes since commit 7c08db30e6a43f7083a881eb07bfbc878e001e08: target-i386: Move KVM default-vendor hack to instance_init (2014-02-03 17:33:55 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Paolo Al

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 11:15, Stefan Hajnoczi ha scritto: On Tue, Feb 25, 2014 at 10:46 AM, Kevin Wolf wrote: > External QOM interfaces have their place, especially for debugging or > trying out things before there is a proper API, but it's not as the > primary external interface. Yes, I agree. -obje

Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-25 Thread Stefan Hajnoczi
On Mon, Feb 24, 2014 at 09:21:38PM +0100, Peter Lieven wrote: > Am 24.02.2014 13:54, schrieb Stefan Hajnoczi: > > On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote: > >> In order to proceed with the integration of the NFS protocol driver into > >> qemu I was asked by Stefan to add integr

Re: [Qemu-devel] [PULL 0/2] xen-140220

2014-02-25 Thread Peter Maydell
On 20 February 2014 18:12, Stefano Stabellini wrote: > The following changes since commit 2ca92bb993991d6dcb8f68751aca9fc2ec2b8867: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-3' into staging > (2014-02-20 15:25:05 +) > > are available in the git repository at: > > > gi

Re: [Qemu-devel] [PATCH v2] net: Disable netmap backend when not supported

2014-02-25 Thread Stefan Hajnoczi
On Mon, Feb 24, 2014 at 10:54:43AM +0100, Vincenzo Maffione wrote: > I cannot see it in your net tree. It's there now. Sorry, I sometimes forget to push to my public repo. Stefan

[Qemu-devel] [PATCH 01/17] update linux headers to kvm/queue

2014-02-25 Thread Christian Borntraeger
This updates the kvm headers to commit 56c103ec040b1944c8866f79aa768265c0dd2986 (KVM: x86: Fix xsave cpuid exposing bug) Signed-off-by: Christian Borntraeger --- linux-headers/asm-arm/kvm.h | 28 + linux-headers/asm-arm64/kvm.h | 30 +- linux-headers/asm-pow

[Qemu-devel] [PATCH 3/3] qemu-iotests: add 080 NBD client disconnect tests

2014-02-25 Thread Stefan Hajnoczi
This new test case uses nbd-fault-injector.py to simulate broken TCP connections at each stage in the NBD protocol. This way we can exercise block/nbd-client.c's socket error handling code paths. In particular, this serves as a regression test to make sure nbd-client.c doesn't cause an infinite l

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: add 080 NBD client disconnect tests

2014-02-25 Thread Stefan Hajnoczi
On Tue, Feb 25, 2014 at 11:16:16AM +0100, Kevin Wolf wrote: > Am 25.02.2014 um 11:09 hat Stefan Hajnoczi geschrieben: > > This new test case uses nbd-fault-injector.py to simulate broken TCP > > connections at each stage in the NBD protocol. This way we can exercise > > block/nbd-client.c's socket

Re: [Qemu-devel] device_del id missing after blockdev-add

2014-02-25 Thread William Dauchy
On Feb24 16:34, Stefan Hajnoczi wrote: > Also, it should probably be 'removable':true? oh true, did not mention this was a boolean > You forgot to give the device an ID. Could that be the problem here? yup I spotted that some days after and forgot to write an answer here. that's solved the issu

[Qemu-devel] [PULL 1/1] KVM: Use return value for error print

2014-02-25 Thread Paolo Bonzini
From: Alexander Graf Commit 94ccff13 introduced a more verbose failure message and retry operations on KVM VM creation. However, it ended up using a variable for its failure message that hasn't been initialized yet. Fix it to use the value it meant to set. Cc: qemu-sta...@nongnu.org Signed-off-

Re: [Qemu-devel] [PATCH 2/3] tests: add nbd-fault-injector.py utility

2014-02-25 Thread Nick Thomas
Hi, On 25/02/14 10:09, Stefan Hajnoczi wrote: > The nbd-fault-injector.py script is a special kind of NBD server. It > throws away all writes and produces zeroes for reads. Given a list of > fault injection rules, it can simulate NBD protocol errors and is useful > for testing NBD client error h

[Qemu-devel] [PULL] qemu-sparc: CG3 framebuffer plus misc sun4m fixes

2014-02-25 Thread Mark Cave-Ayland
Hi Peter, This branch contains updates for SPARC, particularly a new implementation of the CG3 framebuffer as reviewed on list, plus timer/hostid fixes from Olivier. Please pull. ATB, Mark. The following changes since commit c58e291591dbc1c846fa152d4792554803405ebb: Merge remote-tracking

Re: [Qemu-devel] [PULL 00/54] Block patches

2014-02-25 Thread Peter Maydell
On 21 February 2014 22:11, Kevin Wolf wrote: > The following changes since commit 3e890c77cf038d8c2de66ed7996fe77a6f94787c: > > Merge remote-tracking branch > 'remotes/stefanha/tags/qtest-monitor-process-pull-request' into staging > (2014-02-21 14:54:05 +) > > are available in the git repo

Re: [Qemu-devel] [PATCH] monitor: Fix 'mouse_button': do not move mouse

2014-02-25 Thread Eugene Shatokhin
Hi, On 07/03/2013 08:08 PM, Andreas Färber wrote: Am 03.07.2013 14:50, schrieb Eugene Shatokhin: If absolute positions are used, 'mouse_button' command moved mouse pointer to (0, 0) before generating a mouse button event. The event was therefore generated at incorrect position. This problem is

Re: [Qemu-devel] [PULL] xtensa queue 2014-02-24

2014-02-25 Thread Peter Maydell
On 24 February 2014 01:01, Max Filippov wrote: > Hi Anthony, Peter, > > please pull my current xtensa tree. > > The following changes since commit 105a060188dc6fdd4551571a966514d1a5f6815a: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140220' into staging (2014-02-

Re: [Qemu-devel] [PATCH] monitor: Fix 'mouse_button': do not move mouse

2014-02-25 Thread Gerd Hoffmann
On Di, 2014-02-25 at 16:21 +0400, Eugene Shatokhin wrote: > Hi, > > On 07/03/2013 08:08 PM, Andreas Färber wrote: > > Am 03.07.2013 14:50, schrieb Eugene Shatokhin: > >> If absolute positions are used, 'mouse_button' command moved mouse > >> pointer to (0, 0) before generating a mouse button event

Re: [Qemu-devel] [PULL 0/6] qemu-ga: various fixes, and serial support for w32

2014-02-25 Thread Peter Maydell
On 24 February 2014 01:21, Michael Roth wrote: > Hello, > > Please pull the following patches for qemu-ga, which include a number of > fixes applicable for the upcoming 1.7.1 release, and support for > communicating with a Windows guest over a serial port. > > The following changes since commit 10

[Qemu-devel] Some line of codes in a file that I cant understand

2014-02-25 Thread Atlas Khan
I am watching i8259.c in \hw folder in QEMU. here is something like this static const VMStateDescription vmstate_pic = { .name = "i8259", .version_id = 1, .minimum_version_id = 1, .minimum_version_id_old = 1, .fields = (VMStateField[]) { VMSTATE_UINT8(last_irr, PicStat

Re: [Qemu-devel] [PATCH 0/4] target-ppc: htab fixes (V2)

2014-02-25 Thread Alexander Graf
Greg Kurz wrote: > On Mon, 17 Feb 2014 14:22:14 +0100 > Greg Kurz wrote: > >> Hi, >> >> This is a new tentative for the patches 2/5 to 5/5 from the "target-ppc: >> Add support for dumping guest memory using qemu gdb server" patchset: >> >> https://lists.nongnu.org/archive/html/qemu-ppc/2014-01/

[Qemu-devel] [PULL 00/11] Net patches

2014-02-25 Thread Stefan Hajnoczi
The following changes since commit c58e291591dbc1c846fa152d4792554803405ebb: Merge remote-tracking branch 'remotes/sstabellini/xen-140220' into staging (2014-02-24 16:12:55 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you to f

[Qemu-devel] [PULL 01/11] opencores_eth: flush queue whenever can_receive can go from false to true

2014-02-25 Thread Stefan Hajnoczi
From: Max Filippov The following registers control whether MAC can receive frames: - MODER.RXEN bit that enables/disables receiver; - TX_BD_NUM register that specifies number of RX descriptors. Notify QEMU networking core when the MAC is ready to receive frames. Discard frame and raise BUSY inter

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-25 Thread Michael Matz
Hi, On Tue, 25 Feb 2014, Andreas Färber wrote: > >> There are some pretty large differences between these trees with > >> respect to signal syscalls - is that the likely culprit? > > > > Quite likely. We explicitly concentrated on the arch64 specific > > instruction emulation leaving more gene

[Qemu-devel] [PULL 04/11] net: TAP uses NetClientInfo offloading callbacks

2014-02-25 Thread Stefan Hajnoczi
From: Vincenzo Maffione The TAP NetClientInfo structure is inizialized with the TAP-specific functions that manipulates offloading features. Signed-off-by: Vincenzo Maffione Signed-off-by: Stefan Hajnoczi --- net/tap-win32.c | 92 ++--- net/

[Qemu-devel] [PULL 07/11] net: add offloading support to netmap backend

2014-02-25 Thread Stefan Hajnoczi
From: Vincenzo Maffione Whit this patch, the netmap backend supports TSO/UFO/CSUM offloadings, and accepts the virtio-net header, similarly to what happens with TAP. The offloading callbacks in the NetClientInfo interface have been implemented. Signed-off-by: Vincenzo Maffione Signed-off-by: St

[Qemu-devel] [PULL 06/11] net: make tap offloading callbacks static

2014-02-25 Thread Stefan Hajnoczi
From: Vincenzo Maffione Since TAP offloadings are manipulated through a new API, it's not necessary to export them in include/net/tap.h anymore. Signed-off-by: Vincenzo Maffione Signed-off-by: Stefan Hajnoczi --- include/net/tap.h | 6 -- net/tap-win32.c | 12 ++-- net/tap.c

[Qemu-devel] [PULL 11/11] virtio-net: use qemu_get_queue() where possible

2014-02-25 Thread Stefan Hajnoczi
qemu_get_queue() is a shorthand for qemu_get_subqueue(n->nic, 0). Use the shorthand where possible. Signed-off-by: Stefan Hajnoczi --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 9218a09..3c0342e 100644

[Qemu-devel] [PULL 09/11] net: remove implicit peer from offload API

2014-02-25 Thread Stefan Hajnoczi
The virtio_net offload APIs are used on the NIC's peer (i.e. the tap device). The API was defined to implicitly use nc->peer, saving the caller the trouble. This wasn't ideal because: 1. There are callers who have the peer but not the NIC. Currently they are forced to bypass the API and acces

[Qemu-devel] [PATCH 1/7] timer: move QEMUTimerList functions together

2014-02-25 Thread Xuebing Wang
This patch does below: - Move function timerlist_has_timers() to be first QEMUTimerList function because there is a chance that we will make it private - Move QEMUTimerList related functions together - Remove below comments for function timerlist_deadline_ns(), because: -- There is a

Re: [Qemu-devel] [PATCH 1/2][RFC] qom: introduce cpu QOM hierarchy tree /machine/node/socket/core/thread/cpu.

2014-02-25 Thread Eric Blake
On 02/25/2014 02:07 AM, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > include/qom/node.h | 66 +++ > qom/Makefile.objs | 2 +- > qom/node.c | 156 > + > 3 files changed, 223 insertions(+), 1 deletion(-) > cr

Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-25 Thread Kevin Wolf
Am 25.02.2014 um 11:47 hat Paolo Bonzini geschrieben: > Il 25/02/2014 11:15, Stefan Hajnoczi ha scritto: > >On Tue, Feb 25, 2014 at 10:46 AM, Kevin Wolf wrote: > >>> External QOM interfaces have their place, especially for debugging or > >>> trying out things before there is a proper API, but it's

[Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

2014-02-25 Thread Xuebing Wang
There are 6 categories of APIs: - QEMUClockType - QEMUTimerList - QEMUTimerListGroup - QEMUTimer - General utility functions - Low level clock functions Problems / solutions with previous API implementations: 1) Can not think of cases that we need QEMUTimerList APIs. Reference: kernel_tree/Doc

[Qemu-devel] [PATCH 3/7] timer: move QEMUClockType related functions together

2014-02-25 Thread Xuebing Wang
Signed-off-by: Xuebing Wang --- qemu-timer.c | 160 ++ 1 file changed, 82 insertions(+), 78 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 2db87ba..471150c 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -314,6 +314,10 @@ sta

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-25 Thread Kevin Wolf
Am 24.02.2014 um 14:01 hat Peter Lieven geschrieben: > On 24.02.2014 11:38, Paolo Bonzini wrote: > >Il 24/02/2014 11:26, Peter Lieven ha scritto: > >> > >>I personally do not need this for QCOW2 but for iSCSI. Here the optimization > >>is basically saved bandwidth since a zero write becomes a WRITE

[Qemu-devel] [PATCH 5/7] timer: move QEMUTimer related functions together

2014-02-25 Thread Xuebing Wang
Signed-off-by: Xuebing Wang --- qemu-timer.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 6f13a76..c9801da 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -548,6 +548,9 @@ int qemu_poll_ns(GPollFD *fds, guint nfds, int64_t

[Qemu-devel] [PATCH 6/7] timer: move general utility functions together

2014-02-25 Thread Xuebing Wang
Signed-off-by: Xuebing Wang --- qemu-timer.c | 97 ++ 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index c9801da..e592c14 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -501,53 +501,6 @@ int

  1   2   3   >