Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Paolo Bonzini
Il 15/01/2014 23:15, Peter Maydell ha scritto: > >> > +curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running); > The libcurl docs say "This function was added in libcurl 7.15.4, and > is deemed stable since 7.16.0. " So if we want to keep supporting > pre-7.16 libcurl then we ne

Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function

2014-01-16 Thread Stefan Hajnoczi
On Tue, Jan 14, 2014 at 11:59:46AM +0100, Vincenzo Maffione wrote: > This function was used to set the using_vnet_hdr field into the > TAPState struct. However, it is always called immediately before > (see virtio-net.c) or immediately after (see vmxnet3.c) the function > tap_set_vnet_hdr_len(). It

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Paolo Bonzini
Il 15/01/2014 22:56, Peter Maydell ha scritto: > > We have had endless problems with it, including upstream discussions > > with curl people, summarised in this bug: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=971790 > > Looking through the thread from upstream, I see they basically > said

Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support

2014-01-16 Thread Stefan Hajnoczi
On Tue, Jan 14, 2014 at 11:59:44AM +0100, Vincenzo Maffione wrote: > (3) There is actually an important problem. In the previous patch version, > TCP/UDP traffic was > supported between two guests attached to a VALE switch if and only if > both guests use (or > don't) the same offloadings

Re: [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev

2014-01-16 Thread Gal Hammer
Hi, Anyone? Thanks, Gal. On 07/01/2014 09:25, Amit Shah wrote: On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote: Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restor

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Richard W.M. Jones
On Wed, Jan 15, 2014 at 11:06:23PM +0100, Paolo Bonzini wrote: > Il 15/01/2014 18:23, Peter Maydell ha scritto: > > libcurl versions 7.16.0 and later have a timer callback interface which > > must be implemented in order for libcurl to make forward progress (it > > will sometimes rely on being call

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Richard W.M. Jones
On further investigation, the "No such file or directory" error occurs when using snapshot=on. ie: This fails: ./x86_64-softmmu/qemu-system-x86_64 -drive 'file=http://127.0.0.1/~rjones/cirros-0.3.1-x86_64-disk.img,if=virtio,snapshot=on' This works: ./x86_64-softmmu/qemu-system-x86_64 -drive

Re: [Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD

2014-01-16 Thread Lei Li
Any comments? On 01/08/2014 05:12 PM, Lei Li wrote: This patch series tries to refactor the functions used for exchange of FD in current code, provide common methods for it. The series is based on the localhost migration with side channel for ram series as it was already a good shape. But if yo

Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function

2014-01-16 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 11:59:46AM +0100, Vincenzo Maffione wrote: > This function was used to set the using_vnet_hdr field into the > TAPState struct. However, it is always called immediately before > (see virtio-net.c) or immediately after (see vmxnet3.c) the function > tap_set_vnet_hdr_len(). It

Re: [Qemu-devel] [PATCH 0/9 v4] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2014-01-16 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 05:55:45PM +0100, Igor Mammedov wrote: > changes since v3: > - fixup/add comments as reqused by Peter Crosthwaite > - use error_abort to reduce error handling verbosity > - fix tests/test-qdev-global-props build failure on make check > - rebase on top of current master:

Re: [Qemu-devel] [PATCH 0/9 v4] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2014-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2014 11:33:37 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 14, 2014 at 05:55:45PM +0100, Igor Mammedov wrote: > > changes since v3: > > - fixup/add comments as reqused by Peter Crosthwaite > > - use error_abort to reduce error handling verbosity > > - fix tests/test-qdev-glo

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-01-16 Thread Kevin Wolf
Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: > Having both read-only=on and snapshot=on together does not make sense; > currently, the read-only argument is effectively ignored for the > temporary snapshot. To prevent confusion, disallow the usage of both > 'snapshot=on' and 'read-only=on'. >

[Qemu-devel] [PATCH v17 03/10] rules.mak: allow per object cflags and libs

2014-01-16 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var (e.g. common-obj-y

[Qemu-devel] [PATCH v17 00/10] Shared library module support

2014-01-16 Thread Fam Zheng
Many thanks for everyones testing and debugging! v17: [01/10] util: Split out qemu_exec_dir from os_find_datadir New. Used in 07 for module searching. [07/10] module: implement module loading Probe for shasum, sha1sum or sha1 in configure. (PMM, Paolo)

[Qemu-devel] [PATCH v17 01/10] util: Split out qemu_exec_dir from os_find_datadir

2014-01-16 Thread Fam Zheng
This can be reused by module loading routines. Signed-off-by: Fam Zheng --- include/qemu/osdep.h | 4 os-posix.c | 40 ++-- os-win32.c | 19 +-- util/oslib-posix.c | 45 +

[Qemu-devel] [PATCH v17 04/10] block: use per-object cflags and libs

2014-01-16 Thread Fam Zheng
No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to enable modules. -

[Qemu-devel] [PATCH v17 02/10] rules.mak: fix $(obj) to a real relative path

2014-01-16 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

[Qemu-devel] [PATCH v17 05/10] darwin: do not use -mdynamic-no-pic

2014-01-16 Thread Fam Zheng
From: Paolo Bonzini While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini Signed-off-by: F

[Qemu-devel] [PATCH v17 07/10] module: implement module loading

2014-01-16 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$RELEASEHASH w

[Qemu-devel] [PATCH v17 06/10] build-sys: introduce common-obj-m and block-obj-m for DSO

2014-01-16 Thread Fam Zheng
Add necessary rules and flags for shared object generation. $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). The new rules introduced here are: 0) For all %.so compiling: QEMU_CFLAGS += -fPIC 1) %.o in $(common-obj-m) is compiled to %.o, then linked

[Qemu-devel] [PATCH v17 08/10] Makefile: install modules with "make install"

2014-01-16 Thread Fam Zheng
Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 670ce44..a91f119 100644 --- a/Makefile +++ b/Makefile @@ -371,6 +371,12 @@ install-datadir install-localst

[Qemu-devel] [PATCH v17 09/10] .gitignore: ignore module related files (dll, so, mo)

2014-01-16 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 1c9d63d..7702b0c 100644 --- a/.gitignore +++ b/.gitignore @@ -64,6 +64,9 @@ fsdev/virtfs-proxy-helper.pod *.cp *.dvi *.exe +*.dll +*.so +*.

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Kevin Wolf
Am 16.01.2014 um 10:24 hat Richard W.M. Jones geschrieben: > > On further investigation, the "No such file or directory" error occurs > when using snapshot=on. > > ie: > > This fails: > > ./x86_64-softmmu/qemu-system-x86_64 -drive > 'file=http://127.0.0.1/~rjones/cirros-0.3.1-x86_64-disk.img,i

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Peter Maydell
On 16 January 2014 08:38, Paolo Bonzini wrote: > Il 15/01/2014 23:15, Peter Maydell ha scritto: >> >>> > +curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running); >> The libcurl docs say "This function was added in libcurl 7.15.4, and >> is deemed stable since 7.16.0. " So if we

[Qemu-devel] [PATCH v17 10/10] block: convert block drivers linked with libs to modules

2014-01-16 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 0da1253..2

Re: [Qemu-devel] [PULL 36/42] qapi: QMP interface for blkdebug and blkverify

2014-01-16 Thread Kevin Wolf
Am 15.01.2014 um 16:19 hat Eric Blake geschrieben: > On 01/15/2014 03:22 AM, Kevin Wolf wrote: > > From: Max Reitz > > > > Add structures to support blkdebug and blkverify in blockdev-add. > > > > Signed-off-by: Max Reitz > > Signed-off-by: Kevin Wolf > > --- > > qapi-schema.json | 113 > > +

[Qemu-devel] [Bug 1269606] Re: curl driver (http) always says "No such file or directory"

2014-01-16 Thread Richard Jones
Turns out this is because of using "snapshot=on". Simple reproducer: ./x86_64-softmmu/qemu-system-x86_64 -drive 'file=http://127.0.0.1/~rjones/cirros-0.3.1-x86_64-disk.img,if=virtio,snapshot=on' -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH 4/6] virtfs-proxy-helper: replace send_fd with qemu_send_with_fd

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:54PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > fsdev/virtfs-proxy-helper.c | 51 ++ > hw/9pfs/virtio-9p-proxy.h |5 > 2 files changed, 8 insertions(+), 48 deletions(-) > > diff --git a/fsdev/virtfs-prox

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-16 Thread Paolo Bonzini
Il 16/01/2014 10:55, Peter Maydell ha scritto: > On 16 January 2014 08:38, Paolo Bonzini wrote: >> Il 15/01/2014 23:15, Peter Maydell ha scritto: >>> > +curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running); >>> The libcurl docs say "This function was added in libcurl 7.15.4

Re: [Qemu-devel] [PATCH 5/6] virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:55PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > hw/9pfs/virtio-9p-proxy.c | 60 ++-- > 1 files changed, 3 insertions(+), 57 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c > inde

Re: [Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:50PM +0800, Lei Li wrote: > This patch series tries to refactor the functions used for > exchange of FD in current code, provide common methods > for it. > > The series is based on the localhost migration with side channel > for ram series as it was already a good sh

Re: [Qemu-devel] [PATCH 0/9 v3] pc: CPU hotplug support for Q35

2014-01-16 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 05:36:30PM +0100, Igor Mammedov wrote: > Changes since v2: > * use dependency auto generation for *.dsl files > * hide DEVICE(PRES) from UI > * add comments to document holes punched in CRES > * reduce ifdeffenery by moving CPU hotplug defines to > a dedicated he

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Add a blank space between the variable and '='

2014-01-16 Thread Michael Tokarev
Thanks, applied. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios: Remove execute flag from BIOS files

2014-01-16 Thread Michael Tokarev
28.12.2013 11:31, Stefan Weil wrote: > BIOS files are not directly executable, so they don't need this flag. > All other BIOS files don't use the execute flag. Thanks, applied. /mjt

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Fam Zheng
On Wed, 01/15 19:35, Peter Maydell wrote: > On 15 January 2014 08:48, Fam Zheng wrote: > > Adds extract-libs in LINK to expand any "per object libs", the syntax to > > define > > such a libs options is like: > > > > foo.o-libs := $(CURL_LIBS) > > > > in block/Makefile.objs. > > > > Simila

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Peter Maydell
On 15 January 2014 08:48, Fam Zheng wrote:.objs. > Similarly, > > foo.o-cflags := $(FOO_CFLAGS) > > is also supported. I noticed that we already support per-object cflags via: $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBUILD_Y8950=0 (this example from audio/Makefile.objs). Is your

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Add a blank space between the variable and '='

2014-01-16 Thread Peter Maydell
On 16 January 2014 10:50, Michael Tokarev wrote: > Thanks, applied. Can you fix the subject line in your tree to have a prefix indicating which area of the codebase it affects, please? thanks -- PMM

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2014-01-16 Thread Paolo Bonzini
Il 16/01/2014 03:50, Michael Roth ha scritto: > If we go to that effort, it may make sense to try to re-license to GPLv2+ > while we're at it, but either way I think this should be done as a separate > patchset, and shouldn't hold up Wenchao's series. I can send that out, since > it's my screw-up.

[Qemu-devel] [PATCH] tests: require that acpi tests are enabled explicitly

2014-01-16 Thread Michael S. Tsirkin
ACPI code is changing as bit too fast to make it worth it to require everyone to check it against expected output. Make test run depend on an ACPI_TEST_EXPECTED_AML set in environment, so interested people can run it without affecting everyone. Signed-off-by: Michael S. Tsirkin --- I'd like to p

[Qemu-devel] [PATCH v2 5/5] disas: Implement disassembly output for A64

2014-01-16 Thread Peter Maydell
From: Claudio Fontana Use libvixl to implement disassembly output in debug logs for A64, for use with both AArch64 hosts and targets. Signed-off-by: Claudio Fontana [PMM: * added support for target disassembly * switched to custom QEMUDisassembler so the output format matches what QEMU exp

[Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-16 Thread Peter Maydell
Hi. This is a rebased and mildly cleaned up version of Claudio's RFC patchset from last year to add libvixl to QEMU and use it for A64 disassembly. NOTE NOTE NOTE * we now link with g++, not gcc (even if the target doesn't happen to need the A64 disassembler, since it's a bit hard to tell w

[Qemu-devel] [PATCH v2 2/5] rules.mak: Link with C++ if we have a C++ compiler

2014-01-16 Thread Peter Maydell
If we have a C++ compiler available, link with it, because we might be linking some C++ files in. This allows us to include C++ object files in the QEMU binary proper. Signed-off-by: Peter Maydell --- rules.mak | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rules.mak

[Qemu-devel] [PATCH v2 4/5] disas/libvixl: Fix upstream libvixl compilation issues

2014-01-16 Thread Peter Maydell
Fix various minor issues with upstream libvixl so that it will compile successfully on the platforms QEMU cares about: * remove unused GBytes constant (it clashes with the glib headers) * fix suffixes on constants to use 'LL' for 64 bit constants so we can compile on 32 bit hosts Signed-off-b

[Qemu-devel] [PATCH v2 1/5] rules.mak: Support .cc as a C++ source file suffix

2014-01-16 Thread Peter Maydell
The A64 disassembler libvixl uses .cc as its suffix for C++ source files, so add support for it (we already support .cpp). Signed-off-by: Peter Maydell --- rules.mak | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index 49edb9b..cd9187e 100644 --- a

[Qemu-devel] [PATCH] scsi: Support TEST UNIT READY in the dummy LUN0

2014-01-16 Thread Paolo Bonzini
SeaBIOS waits for LUN0 to respond to the TEST UNIT READY command in order to decide whether it should part of the boot sequence. If LUN0 does not respond to the command, boot is delayed by up to 5 seconds. This currently happens when there is no LUN0 on a target. Fix that by adding a trivial impl

[Qemu-devel] [PATCH V2 00/01] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Changes since V1: * Removed subsystem & revision strings from the hardware ID string of pci-serial, pci-serial-2x

[Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.inf | 227 +

Re: [Qemu-devel] [PATCH v2 13/24] block: Introduce bdrv_co_do_pwritev()

2014-01-16 Thread Kevin Wolf
Am 13.12.2013 um 14:22 hat Kevin Wolf geschrieben: > This is going to become the bdrv_co_do_preadv() equivalent for writes. > In this patch, however, just a function taking byte offsets is created, > it doesn't align anything yet. > > Signed-off-by: Kevin Wolf > --- > block.c | 23 ++

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-16 Thread Antonios Motakis
On Wed, Jan 15, 2014 at 3:49 PM, Michael S. Tsirkin wrote: > On Wed, Jan 15, 2014 at 01:50:47PM +0100, Antonios Motakis wrote: > > > > > > > > On Wed, Jan 15, 2014 at 10:07 AM, Michael S. Tsirkin > wrote: > > > > On Tue, Jan 14, 2014 at 07:13:43PM +0100, Antonios Motakis wrote: > > > > >

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Fam Zheng
On Thu, 01/16 11:04, Peter Maydell wrote: > On 15 January 2014 08:48, Fam Zheng wrote:.objs. > > Similarly, > > > > foo.o-cflags := $(FOO_CFLAGS) > > > > is also supported. > > I noticed that we already support per-object cflags via: > > $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBU

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Paolo Bonzini
Il 16/01/2014 13:40, Fam Zheng ha scritto: > , compared to > > $(obj)/foo.mo-objs := $(obj)/bar.o $(obj)/biz.o $(obj)/qux.o > > or slightly better > > $(obj)/foo.mo-objs := $(addprefix $(obj), bar.o, biz.o, qux.o) > > I've already converted block/curl.o's cflags to this, later in this s

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-16 Thread Peter Crosthwaite
On Thu, Jan 16, 2014 at 12:45 PM, Stefan Hajnoczi wrote: > On Wed, Jan 15, 2014 at 06:24:24PM +1000, Peter Crosthwaite wrote: >> On Tue, Jan 14, 2014 at 3:19 PM, Stefan Hajnoczi wrote: >> > On Mon, Jan 13, 2014 at 11:16:37PM +1000, Peter Crosthwaite wrote: >> >> On Mon, Jan 13, 2014 at 11:15 PM,

Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2014-01-16 Thread Kevin Wolf
Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben: > This case can't run when IMGPROTO=nbd, since it needs to create some > internal snapshot which would fail for EOF write request, even when > TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto > to file. > > _require_comman

[Qemu-devel] [PATCH] char: udp chardev shouldn't require an explicit open.

2014-01-16 Thread Gal Hammer
A chardev with a UDP backend never send the CHR_EVENT_OPENED event. This cause the virtio-serial port not to work because data is dropped when no listner on the host side. Signed-off-by: Gal Hammer --- qemu-char.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c ind

Re: [Qemu-devel] In "pci_fixup_video" check if this is or should be the primary video d

2014-01-16 Thread Bjorn Helgaas
[+cc Michael, Jesse, David, qemu-devel] On Wed, Jan 15, 2014 at 8:58 PM, wrote: > I suggest you should not break the PCI specification, as a developer of > proprietary > hypervisor, but I think your patch is no problem. > Your PCI structure is specialized structure for your virtual machine. > M

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Gerd Hoffmann
On Do, 2014-01-16 at 07:18 -0500, Miki Mishael wrote: > Support for pci-serial-2x and pci-serial-4x > added to inf file. > Standard Windows driver mf.sys used to > split single function > device into per-port nodes. Patch looks good. Not that I understand everything

Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support

2014-01-16 Thread Vincenzo Maffione
2014/1/16 Stefan Hajnoczi > On Tue, Jan 14, 2014 at 11:59:44AM +0100, Vincenzo Maffione wrote: > > (3) There is actually an important problem. In the previous patch > version, TCP/UDP traffic was > > supported between two guests attached to a VALE switch if and only > if both guests use (or >

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Eric Blake
On 01/08/2014 02:12 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qemu/fd-exchange.h | 25 +++ > util/Makefile.objs |1 + > util/qemu-fd-exchange.c| 97 > > 3 files changed, 123 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Eric Blake
On 01/08/2014 02:12 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qemu/fd-exchange.h | 25 +++ > util/Makefile.objs |1 + > util/qemu-fd-exchange.c| 97 > > 3 files changed, 123 insertions(+), 0 deletions(-) >

[Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements

2014-01-16 Thread Marcel Apfelbaum
patch 1: refactoring Addressed Michael S. Tsirkin's prev comments: Renamed ssdt_tables to tables to avoid confusion. patch 2: resolved iasl crash Addressed Michael S. Tsirkin's prev comments: Do not assume the order of ssdt tables and single ssdt table. patch 3: do not fail on as

Re: [Qemu-devel] [PATCH 2/2] seccomp: add some basic shared memory syscalls to the whitelist

2014-01-16 Thread Eduardo Otubo
On 01/15/2014 05:38 PM, Paul Moore wrote: PulseAudio requires the use of shared memory so add shmget(), shmat(), and shmdt() to the syscall whitelist. Reported-by: xu...@redhat.com Signed-off-by: Paul Moore --- qemu-seccomp.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [Qemu-devel] [PATCH 0/2] QEMU/seccomp fixes for PulseAudio

2014-01-16 Thread Eduardo Otubo
On 01/15/2014 05:38 PM, Paul Moore wrote: It turns out we need to add some additional syscalls to QEMU to make PulseAudio happy. Two minor patches follow ... --- Paul Moore (2): seccomp: add mkdir() and fchmod() to the whitelist seccomp: add some basic shared memory syscalls to

Re: [Qemu-devel] [PATCH 1/2] seccomp: add mkdir() and fchmod() to the whitelist

2014-01-16 Thread Eduardo Otubo
I have tested and reviewed both patches. And if nothing more comes up, I'll send a pull request by tomorrow EOD. On 01/15/2014 05:38 PM, Paul Moore wrote: The PulseAudio library attempts to do a mkdir(2) and fchmod(2) on "/run/user//pulse" which is currently blocked by the syscall filter; this

Re: [Qemu-devel] qemu-seccomp.c:228: error: '__NR_getcpu' undeclared here (not in a function)

2014-01-16 Thread Eduardo Otubo
On 01/03/2014 12:54 PM, lejeczek wrote: dear developers I was hoping someone could suggest what is missing or incompatible on my setup that causes a compilation to fail I'm trying to rpmbuild-compile qemu-1.2.2-1.fc18.src.rpm on rhel 6.5 I thought I have got all dependencies from rpm perspect

Re: [Qemu-devel] [PATCH 0/2] QEMU/seccomp fixes for PulseAudio

2014-01-16 Thread Paul Moore
On Thursday, January 16, 2014 01:52:30 PM Eduardo Otubo wrote: > On 01/15/2014 05:38 PM, Paul Moore wrote: > > It turns out we need to add some additional syscalls to QEMU to make > > PulseAudio happy. Two minor patches follow ... > > > > --- > > > > Paul Moore (2): > >seccomp: add mkdir

[Qemu-devel] [RFC PATCH] balloon: add automatic ballooning support

2014-01-16 Thread Luiz Capitulino
The current balloon device has an important drawback: it's entirely manual. This largely limits the feature when used to manage memory on a memory over-committed host. In order to make the balloon device really useful for memory-overcommit setups, we have to make it automatic. This is what this pa

[Qemu-devel] [PATCH v1 1/4] object_add: consolidate error handling

2014-01-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- qmp.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index 0f46171..a67e0c4 100644 --- a/qmp.c +++ b/qmp.c @@ -549,15 +549,17 @@ void object_add(const char *type, const char *id, const QDict *qdict, for (e

[Qemu-devel] [PATCH v1 3/4] add optional 2nd stage initialization to -object/object-add commands

2014-01-16 Thread Igor Mammedov
Introduces USER_CREATABLE interface that must be implemented by objects which are designed to created with -object CLI option or object-add QMP command. Interface provides an ability to do an optional second stage initialization of the object created with -object/object-add commands. By providing

[Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization

2014-01-16 Thread Igor Mammedov
Adds UserCreatable interface that objects must inherit from If they need to be created with help of -object/object-add commands. Interface also provides an optional complete() callback, that is called after object properties are set. Which allows * replace custom backend APIs to initialize them w

[Qemu-devel] [PATCH v1 4/4] virtio_rng: replace custom backend API with UserCreatable.complete() callback

2014-01-16 Thread Igor Mammedov
in addition fix default backend leak by releasing it if its initialization failed. Signed-off-by: Igor Mammedov --- backends/rng.c | 12 ++-- hw/virtio/virtio-rng.c | 15 +-- include/sysemu/rng.h | 11 --- 3 files changed, 19 insertions(+), 19 deletion

[Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id'

2014-01-16 Thread Igor Mammedov
object_property_add_child() may fail if 'id' matches an already existing object. Which meansi an incorrect command line. So instead of silently ignoring error, report it and terminate QEMU. Signed-off-by: Igor Mammedov --- vl.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id'

2014-01-16 Thread Eric Blake
On 01/16/2014 09:34 AM, Igor Mammedov wrote: s/ingnore/ignore/ in subject > object_property_add_child() may fail if 'id' matches > an already existing object. Which meansi an incorrect s/meansi/means/ > command line. > So instead of silently ignoring error, report it and > terminate QEMU. > >

[Qemu-devel] [PATCH 3/3] acpi unit-test: do not fail on asl mismatch

2014-01-16 Thread Marcel Apfelbaum
The asl comparison will break every time the ACPI tables are updated. This may break the git bisect. Instead of failing print a warning on stderr including the retained asl files, so they can be compared offline. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 13 +++-- 1 file ch

[Qemu-devel] [PATCH 1/3] acpi unit-test: renamed ssdt_tables to tables

2014-01-16 Thread Marcel Apfelbaum
Just a refactoring, ssdt_tables name was confusing as it included other tables as well. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test

[Qemu-devel] [PATCH 2/3] acpi unit-test: resolved iasl crash

2014-01-16 Thread Marcel Apfelbaum
It seems that iasl has an issue when disassembles some ACPI tables using the command line: iasl -e DSDT -e SSDT -d HPET Modified the iasl command line to "iasl -d HPET" until the problem is solved. The command line remained the same for DSDT and SSDT tables. Reported-by: Michael S. Tsirkin Signe

[Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Have created wrapper

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Alexander Graf
On 16.01.2014, at 17:59, Thomas Falcon wrote: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. It accomplishes this goal by byte swapping the values of > any registers if the MSR:LE value is set.

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-16 Thread Benoît Canet
Le Thursday 12 Dec 2013 à 16:33:53 (+0100), Benoît Canet a écrit : > v5: > block empty node names [Kevin] > factorize setting of node-name option [Kevin] > NULL terminate node_name on removal [Kevin] > make query-named-block-nodes return BlockDeviceInfo structure [Eric] > Change

[Qemu-devel] [PULL 07/11] linux-user: fixed s390x clone() argument order

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db, where TARGET_CLONE_BACKWARDS was specified instead of TARGET_CLONE_BACKWARDS2. Signed-off-by: Pavel Zbitskiy Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- linux-user/s390x/syscall.h |2 +- 1 f

[Qemu-devel] [PULL 02/11] Fix typo of tiemr in timer.h

2014-01-16 Thread Michael Tokarev
From: Namhyung Kim Signed-off-by: Namhyung Kim Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- include/qemu/timer.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 5afcffc..7f9a074 100644 --- a/incl

[Qemu-devel] [PULL 03/11] Add bios-256k.bin to BLOBS on Makefile

2014-01-16 Thread Michael Tokarev
From: Eduardo Habkost The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but "make install" isn't installing it, so qemu-system-x86_64 won't run out of the box. Add it to BLOBS so it gets installed. Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann Tested-by: William

[Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

2014-01-16 Thread Michael Tokarev
From: Kewei Yu Signed-off-by: Kewei Yu Signed-off-by: Michael Tokarev --- vl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7f4fe0d..2b47866 100644 --- a/vl.c +++ b/vl.c @@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp) bdrv_i

[Qemu-devel] [PULL 10/11] pc-bios: Remove execute flag from BIOS files

2014-01-16 Thread Michael Tokarev
From: Stefan Weil BIOS files are not directly executable, so they don't need this flag. All other BIOS files don't use the execute flag. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- pc-bios/kvmvapic.bin | Bin 9216 -> 9216 bytes pc-bios/multiboot.bin | Bin 1024 -> 1024 byt

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Peter Maydell
On 16 January 2014 16:59, Thomas Falcon wrote: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. It accomplishes this goal by byte swapping the values of > any registers if the MSR:LE value is set.

[Qemu-devel] [PULL 08/11] linux-user: fixed getsockopt() optlen

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy optlen parameter of getsockopt() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes optlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy Signed-off-by: Michael Toka

[Qemu-devel] [PULL 04/11] exec: Exclude non portable function for MinGW

2014-01-16 Thread Michael Tokarev
From: Stefan Weil cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are unavailable for MinGW. As the function is unused for MinGW, it can simply be excluded from compilation. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- include/exec/ram_addr.h |2 ++

[Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

2014-01-16 Thread Michael Tokarev
There's nothing exciting in there, but we have some small bugfixes here and there, and a few cosmetic changes too. This is my first signed pull request too, based on my regular GnuPG key which I use to sign Debian packages. Please pull. Thanks, /mjt The following changes since commit 1cf892ca2

[Qemu-devel] [PULL 05/11] virtio-balloon: don't hardcode config size value

2014-01-16 Thread Michael Tokarev
From: Luiz Capitulino Use sizeof(struct virtio_balloon_config) instead. Signed-off-by: Luiz capitulino Reviewed-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/virtio/virtio-balloon.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-b

[Qemu-devel] [PULL 09/11] linux-user: fixed recvfrom() addrlen

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy addrlen parameter of recvfrom() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes addrlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy Signed-off-by: Michael Toka

[Qemu-devel] [PULL 01/11] docs: Fix typo in QMP WAKEUP example

2014-01-16 Thread Michael Tokarev
From: Namhyung Kim Cc: qemu-triv...@nongnu.org Signed-off-by: Namhyung Kim Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- docs/qmp/qmp-events.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index 6

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Alexander Graf
> Am 16.01.2014 um 18:41 schrieb Peter Maydell : > >> On 16 January 2014 16:59, Thomas Falcon wrote: >> This patch allows registers to be properly read from and written to >> when using the gdbstub to debug a ppc guest running in little >> endian mode. It accomplishes this goal by byte swappin

[Qemu-devel] [PULL 06/11] ide: cmd_exec_dev_diagnostic() always set error register to 0x01

2014-01-16 Thread Michael Tokarev
From: David du Colombier <0in...@gmail.com> This notably fix IDE CD probing on the Plan 9 operating system, which rely on the error register set by the Execute Device Diagnostic command to detect drive configurations. Thanks to Rémi Pommarel for reporting this issue. Signed-off-by: David du Colo

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Peter Maydell
On 16 January 2014 17:51, Alexander Graf wrote: >> Am 16.01.2014 um 18:41 schrieb Peter Maydell : >> Also see my remarks on the previous patch series suggesting >> that we should look at this in a more holistic way than >> just randomly fixing small bits of things. A good place >> to start would b

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-01-16 Thread Jeff Cody
On Thu, Jan 16, 2014 at 10:39:30AM +0100, Kevin Wolf wrote: > Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: > > Having both read-only=on and snapshot=on together does not make sense; > > currently, the read-only argument is effectively ignored for the > > temporary snapshot. To prevent confusi

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Thomas Falcon
On 01/16/2014 11:10 AM, Alexander Graf wrote: On 16.01.2014, at 17:59, Thomas Falcon wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of a

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 22:54:42) > On 12/16/2013 01:59 PM, Alexey Kardashevskiy wrote: > > On 12/06/2013 09:32 AM, Michael Roth wrote: > >> From: Nathan Fontenot > >> > >> This add entries to the root OF node to advertise our PHBs as being > >> DR-capable in according with PAPR s

Re: [Qemu-devel] [PATCH v2 04/14] spapr_pci: add set-indicator RTAS interface

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 22:26:32) > On 12/06/2013 09:32 AM, Michael Roth wrote: > > From: Mike Day > > > > Signed-off-by: Mike Day > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr_pci.c | 93 > > > > include/hw/pp

Re: [Qemu-devel] [PATCH v2 05/14] spapr_pci: add get/set-power-level RTAS interfaces

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 21:09:09) > On 12/06/2013 09:32 AM, Michael Roth wrote: > > From: Nathan Fontenot > > > > Signed-off-by: Nathan Fontenot > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr_pci.c | 22 ++ > > 1 file changed, 22 insertions(+) >

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Hervé Poussineau
Hi, Miki Mishael a écrit : Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.i

[Qemu-devel] [Bug 1254672] Re: ps segfaults with qemu-{arm, armel, mips, powerpc}-static

2014-01-16 Thread Ken Sharp
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254672 Title: ps segfaults with qemu-{arm,armel,mips,powerpc}-static Status in QEMU:

  1   2   >