Re: [Qemu-devel] [RFC PATCH v5 1/6] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 08:30, Paolo Bonzini wrote: > Il 11/09/2013 07:38, Fam Zheng ha scritto: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)/curl.o: QEMU_CFLAGS

[Qemu-devel] qemu-img convert will increase the VM image

2013-09-11 Thread xuanmao_001
Hi, all: I have question about qemu-img convert ... I have a orignal image with following information: # qemu-img info ori.qcow2 image: ori.qcow2 file format: qcow2 virtual size: 2.0G (2097152000 bytes) disk size: 308M cluster_size: 65536 when I executed with "qemu-img convert -f qcow2 -O

Re: [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-11 Thread Max Reitz
On 2013-09-11 08:23, Fam Zheng wrote: On Tue, 09/10 11:33, Max Reitz wrote: Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz --- tests/qemu-iotests/064 | 72 ++ tests/q

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 07:38, Fam Zheng ha scritto: > The new option will enable support of shared object build. Otherwise > objects are static linked to executables. > > Signed-off-by: Fam Zheng > --- > Makefile.target | 6 +- > configure | 8 > rules.mak | 8 ++-- > 3 files

Re: [Qemu-devel] [RFC PATCH v5 6/6] block: build qed and curl as shared library

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 07:38, Fam Zheng ha scritto: > Curl and qed block drivers are built as shared object module. We have > per object cflags and libs support now, move CURL_CFLAGS and CURL_LIBS > from global option variables to a per object basis. > > "make install" is not installing them yet, manually

Re: [Qemu-devel] [PATCH RFC 3/4] Curling: the sender

2013-09-11 Thread junqing . wang
hi, >> +bool create = false; > >This variable is never set. It is set in the following 'if' block. +create = true;<<=== >> -migration_bitmap = bitmap_new(ram_pages); >> -bitmap_set(migration_bitmap, 0, ram_pages); >> -migration_dirty_pages = ram_pages; >> +i

Re: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights

2013-09-11 Thread Kevin Wolf
Am 11.09.2013 um 04:38 hat Wenchao Xia geschrieben: > 于 2013/9/10 19:47, Kevin Wolf 写道: > >Am 09.09.2013 um 13:57 hat Stefan Hajnoczi geschrieben: > >>On Fri, Sep 06, 2013 at 11:24:31AM +0800, Wenchao Xia wrote: > >>>This series add test case for fd passing with unix socket at runtime. Since > >>>g

Re: [Qemu-devel] [RFC PATCH v5 6/6] block: build qed and curl as shared library

2013-09-11 Thread Fam Zheng
On Wed, 09/11 09:28, Paolo Bonzini wrote: > Il 11/09/2013 07:38, Fam Zheng ha scritto: > > Curl and qed block drivers are built as shared object module. We have > > per object cflags and libs support now, move CURL_CFLAGS and CURL_LIBS > > from global option variables to a per object basis. > > >

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 07:38, Fam Zheng ha scritto: > Added three types of modules: > > typedef enum { > MODULE_LOAD_BLOCK = 0, > MODULE_LOAD_UI, > MODULE_LOAD_NET, > MODULE_LOAD_MAX, > } module_load_type; If you want to make spice into a module, you probably need a

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > There are a couple of things that can be improved still (I don't like > obj-save-y for example), but things are taking shape and all of this > looks like something that can be fixed on top. If you look at > converting more parts to modules (e.g.

Re: [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-11 Thread Fam Zheng
On Wed, 09/11 09:26, Max Reitz wrote: > On 2013-09-11 08:23, Fam Zheng wrote: > >On Tue, 09/10 11:33, Max Reitz wrote: > >>Add a test for the additional information now provided by qemu-img info > >>when used on qcow2 images. > >> > >>Signed-off-by: Max Reitz > >>--- > >> tests/qemu-iotests/064

[Qemu-devel] [PATCH] qdev: rename qdev_free() to qdev_unparent()

2013-09-11 Thread Stefan Hajnoczi
The qdev_free() function name is misleading since all the function does is unlink the device from its parent. The device is not necessarily freed. The device will be freed when its QObject refcount reaches zero. It is usual for the parent (bus) to hold the final reference but there are cases whe

Re: [Qemu-devel] [PATCH] qdev: rename qdev_free() to qdev_unparent()

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 09:45, Stefan Hajnoczi ha scritto: > The qdev_free() function name is misleading since all the function does > is unlink the device from its parent. The device is not necessarily > freed. > > The device will be freed when its QObject refcount reaches zero. It is > usual for the par

Re: [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-11 Thread Max Reitz
On 2013-09-11 09:44, Fam Zheng wrote: On Wed, 09/11 09:26, Max Reitz wrote: On 2013-09-11 08:23, Fam Zheng wrote: On Tue, 09/10 11:33, Max Reitz wrote: Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz --- tests/qemu

[Qemu-devel] [PATCH v4 3/6] block/qapi: Human-readable ImageInfoSpecific dump

2013-09-11 Thread Max Reitz
Add a function for generically dumping the ImageInfoSpecific information in a human-readable format to block/qapi.c. Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to allow qemu-img info resp. qemu-io -c info to print that format specific information. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v4 0/6] Provide additional info through qemu-img info

2013-09-11 Thread Max Reitz
qemu-img info provides only pretty general information about an image. For any image format, there might be specific options which cannot be represented in a universal way; for instance, qcow2 provides the compatibility and lazy_refcount options whose values are certainly interesting but currently

[Qemu-devel] [PATCH v4 1/6] qapi: Add ImageInfoSpecific type

2013-09-11 Thread Max Reitz
Add a new type ImageInfoSpecific as a union for image format specific information in ImageInfo. Signed-off-by: Max Reitz --- qapi-schema.json | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 2b2c8bc..d4c63d9 100644 -

[Qemu-devel] [PATCH v4 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-11 Thread Max Reitz
Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz --- tests/qemu-iotests/064 | 72 ++ tests/qemu-iotests/064.out | 22 ++ tests/qemu-iotests/group | 1 + 3 fil

[Qemu-devel] [PATCH v4 5/6] qemu-iotests: Discard specific info in _img_info

2013-09-11 Thread Max Reitz
In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format else. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 19 ++-

[Qemu-devel] [PATCH v4 4/6] qcow2: Add support for ImageInfoSpecific

2013-09-11 Thread Max Reitz
Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific. This contains the compatibility level as a string and an optional lazy_refcounts boolean (optional means mandatory for compat >= 1.1 and not available for compat == 0.10). In qcow2_get_info, fill the BlockDriverInfo.format_sp

[Qemu-devel] [PATCH v4 2/6] block: Add ImageInfoSpecific to BlockDriverInfo

2013-09-11 Thread Max Reitz
Add the new ImageInfoSpecific type also to BlockDriverInfo, as well as a bdrv_put_info function which releases all data allocated by bdrv_get_info from BlockDriverInfo (such as the new ImageInfoSpecific field). To prevent memory leaks, bdrv_put_info has to be called on every BlockDriverInfo object

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Gerd Hoffmann
On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > > > There are a couple of things that can be improved still (I don't like > > obj-save-y for example), but things are taking shape and all of this > > looks like something that can be fixed

Re: [Qemu-devel] [PATCH] docs: Fix IO port number for CPU present bitmap.

2013-09-11 Thread Igor Mammedov
On Tue, 10 Sep 2013 17:36:18 +0100 Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > docs/specs/acpi_cpu_hotplug.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt > index 5dec0c5..f6f5774 1

Re: [Qemu-devel] Disabling IRQ error

2013-09-11 Thread Xie Xianshan
Hi Max, Thanks for your reply. And I am sorry for my unclear description. I want to add a new device "fpga" for e500, and trigger an interrupt IRQ3 while the register BB_INTR_REG which belongs to device "fpga" is wrote by the device driver of "fpga". For e500, IRQ3 is an external interr

Re: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights

2013-09-11 Thread Wenchao Xia
于 2013/9/11 15:32, Kevin Wolf 写道: Am 11.09.2013 um 04:38 hat Wenchao Xia geschrieben: 于 2013/9/10 19:47, Kevin Wolf 写道: Am 09.09.2013 um 13:57 hat Stefan Hajnoczi geschrieben: On Fri, Sep 06, 2013 at 11:24:31AM +0800, Wenchao Xia wrote: This series add test case for fd passing with unix socke

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Fam Zheng
On Wed, 09/11 10:01, Gerd Hoffmann wrote: > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > > Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > > > > > There are a couple of things that can be improved still (I don't like > > > obj-save-y for example), but things are taking shape and all

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Peter Maydell
On 11 September 2013 09:01, Gerd Hoffmann wrote: > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: >> It looks like TARGET_PAGE_SIZE is the only reason why qxl is built >> per-target, and in qxl_ram_set_dirty it should be enough to do >> >> qxl_set_dirty(&qxl->vga.vram, offset, offset +

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 & qemu32 CPU models

2013-09-11 Thread Igor Mammedov
On Tue, 10 Sep 2013 17:48:59 -0300 Eduardo Habkost wrote: > There's no Intel CPU with family=6,model=2, and Linux and Windows guests > disable SEP when seeing that combination due to Pentium Pro erratum #82. > > In addition to just having SEP ignored by guests, Skype (and maybe other > applicati

Re: [Qemu-devel] [PATCH] qdev: rename qdev_free() to qdev_unparent()

2013-09-11 Thread Andreas Färber
Am 11.09.2013 09:45, schrieb Stefan Hajnoczi: > The qdev_free() function name is misleading since all the function does > is unlink the device from its parent. The device is not necessarily > freed. > > The device will be freed when its QObject refcount reaches zero. It is > usual for the parent

Re: [Qemu-devel] guest kernel 3.10 panic at boot (__mcheck_cpu_init_generic) with kvm64 vcpu + amd host cpu (qemu 1.4)

2013-09-11 Thread Gleb Natapov
On Wed, Sep 11, 2013 at 05:39:01AM +0200, Alexandre DERUMIER wrote: > Hi List, > I'm trying to boot a debian squeeze guest with a 3.10 kernel, and I have a > crash at boot > > This only happen with kvm64 vcpu + amd host (opteron 6100 or opteron 6300). > Check host dmesg for unhandled msrs. > ho

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 & qemu32 CPU models

2013-09-11 Thread Andreas Färber
Am 11.09.2013 10:22, schrieb Igor Mammedov: > On Tue, 10 Sep 2013 17:48:59 -0300 > Eduardo Habkost wrote: > >> There's no Intel CPU with family=6,model=2, and Linux and Windows guests >> disable SEP when seeing that combination due to Pentium Pro erratum #82. >> >> In addition to just having SEP

Re: [Qemu-devel] [PATCH RFC 4/4] Curling: the receiver

2013-09-11 Thread junqing . wang
hi, At 2013-09-10 22:19:48,"Juan Quintela" wrote: >> @@ -112,13 +113,24 @@ static void process_incoming_migration_co(void *opaque) >> { >> QEMUFile *f = opaque; >> int ret; >> +int count = 0; >> >> -ret = qemu_loadvm_state(f); >> -qemu_fclose(f); >> -if (ret < 0) {

Re: [Qemu-devel] qemu-img convert will increase the VM image

2013-09-11 Thread Kevin Wolf
Am 11.09.2013 um 09:14 hat xuanmao_001 geschrieben: > Hi, all: > > I have question about qemu-img convert ... > > I have a orignal image with following information: > # qemu-img info ori.qcow2 > image: ori.qcow2 > file format: qcow2 > virtual size: 2.0G (2097152000 bytes) > disk size: 30

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Fam Zheng
On Wed, 09/11 09:27, Paolo Bonzini wrote: > Il 11/09/2013 07:38, Fam Zheng ha scritto: > > The new option will enable support of shared object build. Otherwise > > objects are static linked to executables. > > > > Signed-off-by: Fam Zheng > > --- > > Makefile.target | 6 +- > > configure

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 & qemu32 CPU models

2013-09-11 Thread Igor Mammedov
On Wed, 11 Sep 2013 10:25:58 +0200 Andreas Färber wrote: > Am 11.09.2013 10:22, schrieb Igor Mammedov: > > On Tue, 10 Sep 2013 17:48:59 -0300 > > Eduardo Habkost wrote: > > > >> There's no Intel CPU with family=6,model=2, and Linux and Windows guests > >> disable SEP when seeing that combinatio

Re: [Qemu-devel] [PATCH v2] e1000: NetClientInfo.receive_iov implemented

2013-09-11 Thread Stefan Hajnoczi
On Tue, Sep 10, 2013 at 02:19:47PM +0200, Vincenzo Maffione wrote: > This patch implements the NetClientInfo.receive_iov method for the > e1000 device emulation. In this way a network backend that uses > qemu_sendv_packet() can deliver the fragmented packet without > requiring an additional copy in

Re: [Qemu-devel] [PATCH V8 0/8] add internal snapshot support at block device level

2013-09-11 Thread Kevin Wolf
Am 11.09.2013 um 08:04 hat Wenchao Xia geschrieben: > This series brings internal snapshot support at block devices level, now we > have two three methods to do block snapshot lively: 1) backing chain, > 2) internal one and 3) drive-back up approach. > > Comparation: > Advantages:

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 10:35, Fam Zheng ha scritto: >> > Since you'll have a v6, please move "all: modules" to Makefile, and in >> > rules.mak: >> > >> > .PHONY: modules >> > modules: >> > > Why is ".PHONY: modules" not in Makefile too? I think you would need it even in Makefile.target, so I suggested ru

Re: [Qemu-devel] qemu-img convert will increase the VM image

2013-09-11 Thread xuanmao_001
the first 30lines output from orignal image: 1 [ 0] 128/ 4096000 sectors allocated at offset 0.00 bytes (1) 2 [ 65536] 1920/ 4095872 sectors not allocated at offset 64 KiB (0) 3 [ 1048576] 128/ 4093952 s

Re: [Qemu-devel] [PATCH 1/3 resend v2] savevm: add comments for qemu_file_get_error()

2013-09-11 Thread Juan Quintela
Lei Li wrote: > Add comments for qemu_file_get_error(), as its return value > is not very clear. > > Signed-off-by: Lei Li Reviewed-by: Juan Quintela

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Gerd Hoffmann
On Mi, 2013-09-11 at 09:20 +0100, Peter Maydell wrote: > On 11 September 2013 09:01, Gerd Hoffmann wrote: > > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > >> It looks like TARGET_PAGE_SIZE is the only reason why qxl is built > >> per-target, and in qxl_ram_set_dirty it should be enough

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Juan Quintela
Lei Li wrote: > qemu_file_rate_limit() never return negative value since the refactor > by Commit 1964a39, this patch gets rid of the negative check for it, > adjust bytes_transferred and return value correspondingly in > ram_save_iterate(). > > Signed-off-by: Lei Li > Signed-off-by: Paolo Bonzi

Re: [Qemu-devel] Disabling IRQ error

2013-09-11 Thread Max Filippov
On Wed, Sep 11, 2013 at 12:12 PM, Xie Xianshan wrote: > I want to add a new device "fpga" for e500, and trigger an interrupt IRQ3 > while the register BB_INTR_REG which belongs to device "fpga" is wrote by > the device driver of "fpga". > For e500, IRQ3 is an external interrupt irq. > Accord

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 11:17, Juan Quintela ha scritto: > Lei Li wrote: >> qemu_file_rate_limit() never return negative value since the refactor >> by Commit 1964a39, this patch gets rid of the negative check for it, >> adjust bytes_transferred and return value correspondingly in >> ram_save_iterate(). >>

Re: [Qemu-devel] [PATCH v3 00/14] qemu: generate acpi tables for the guest

2013-09-11 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 01:22:57AM +0200, Andreas Färber wrote: > Am 26.07.2013 14:19, schrieb Andreas Färber: > > Am 25.07.2013 18:19, schrieb Michael S. Tsirkin: > >> On Thu, Jul 25, 2013 at 05:50:55PM +0200, Andreas Färber wrote: > >>> Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: > This

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Peter Maydell
On 11 September 2013 09:56, Gerd Hoffmann wrote: > On Mi, 2013-09-11 at 09:20 +0100, Peter Maydell wrote: >> Does this mean that the code was previously wrong for targets >> which didn't have 4K pages, or would we just have been a bit >> inefficient? I ask because ARM's TARGET_PAGE_SIZE is 1K... >

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-09-11 Thread Fabio Fantoni
Il 14/08/2013 12:30, Fabio Fantoni ha scritto: Il 18/07/2013 14:35, Paolo Bonzini ha scritto: Il 18/07/2013 14:31, Andreas Färber ha scritto: I'm just curious, why is this so complicated? Is this likely to be fragile and break in the future? As pointed out previously, the bus=pci.0 bit will b

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-09-11 Thread Ian Campbell
On Wed, 2013-09-11 at 12:14 +0200, Fabio Fantoni wrote: > Ping Is this directed and Xen or qmeu folks? What are the outstanding questions which need to be answered? It doesn't look to me like Ian's concerns from the (great?) grandparent have been addressed? On the other hand I appear to be missi

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Gerd Hoffmann
> > (3) rom->num_pages field. That one will change for arm. The linux > > kernel qxl kms driver seems not to care at all. Not surprising, > > it is more convenient to use the offsets in the rom to figure how > > the qxl memory layout looks like. > > Note that the ARM Linux *kern

Re: [Qemu-devel] [PATCH v2] e1000: NetClientInfo.receive_iov implemented

2013-09-11 Thread Vincenzo Maffione
Thanks for the help! Actually I've found out that the variable "copied" I use in this patch can be removed, we can simply increment the variable "ba" instead (ba += iov_copy). I have the patch v3 to do that ready. Do you think it is worth sending it? Best regards, Vincenzo 2013/9/11 Stefan

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules

2013-09-11 Thread Peter Maydell
On 11 September 2013 11:37, Gerd Hoffmann wrote: >> What is the num_pages field supposed to mean, given that >> "page size" isn't a well defined platform independent value >> (for hardware or for QEMU)? > > It's 4k on x86 and not really defined on !x86 (with the !x86 installed > base being pretty

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Juan Quintela
Paolo Bonzini wrote: > Il 11/09/2013 11:17, Juan Quintela ha scritto: >> Lei Li wrote: >>> qemu_file_rate_limit() never return negative value since the refactor >>> by Commit 1964a39, this patch gets rid of the negative check for it, >>> adjust bytes_transferred and return value correspondingly i

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 13:06, Juan Quintela ha scritto: >>> And I think that the right solution is make qemu_get_rate_limit() to >>> return -1 in case of error (or the error, I don't care). >> >> You might do both things, it would avoid the useless g_usleep you >> pointed out below. But Lei's patch is good

[Qemu-devel] [PATCH 3/4] qxl: simplify page dirtying

2013-09-11 Thread Gerd Hoffmann
No need to do target page size calculations here, memory_region_set_dirty will care for us. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index bcbf97a..ee2db0d 100644 --- a/hw/display/q

[Qemu-devel] [PATCH 1/4] qxl: define qxl operating on 4k pages

2013-09-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 5 +++-- hw/display/qxl.h | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index c50e285..f0bfd2c 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -364,7 +364,7 @@ static void ini

[Qemu-devel] [PATCH 2/4] qxl: simplify qxl_rom_size

2013-09-11 Thread Gerd Hoffmann
Nowdays rom size is fixed at 8192 for live migration compat reasons. So we can ditch the pointless math trying to calculate the size needed. Also make the size sanity check fail at compile time not runtime. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 4 +--- 1 file changed, 1 insertion(+

[Qemu-devel] [PATCH 4/4] qxl: compile only once

2013-09-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs index 6e9fb3b..540df82 100644 --- a/hw/display/Makefile.objs +++ b/hw/display/Makefile.objs @@ -31,5 +31,4 @@ obj-$(C

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-09-11 Thread Fabio Fantoni
Il 11/09/2013 12:19, Ian Campbell ha scritto: On Wed, 2013-09-11 at 12:14 +0200, Fabio Fantoni wrote: Ping Is this directed and Xen or qmeu folks? What are the outstanding questions which need to be answered? It doesn't look to me like Ian's concerns from the (great?) grandparent have been ad

Re: [Qemu-devel] [PATCH] qdev: rename qdev_free() to qdev_unparent()

2013-09-11 Thread Stefan Hajnoczi
On Wed, Sep 11, 2013 at 10:23 AM, Andreas Färber wrote: > Am 11.09.2013 09:45, schrieb Stefan Hajnoczi: >> diff --git a/hw/pci/pci-hotplug-old.c b/hw/pci/pci-hotplug-old.c >> index 619fe47..f197f5f 100644 >> --- a/hw/pci/pci-hotplug-old.c >> +++ b/hw/pci/pci-hotplug-old.c >> @@ -248,7 +248,7 @@ st

[Qemu-devel] [Bug 1222034] Re: QEMU + SPICE + AUDIO = FAILURE

2013-09-11 Thread will
That above example is from a debian x64 guest. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1222034 Title: QEMU + SPICE + AUDIO = FAILURE Status in QEMU: New Bug description: Hello it's my f

[Qemu-devel] [Bug 1222034] Re: QEMU + SPICE + AUDIO = FAILURE

2013-09-11 Thread will
Here is the dmesg that occurs inside the guest using any recent qemu upstream build for me: [ 248.943541] input: spice vdagent tablet as /devices/virtual/input/input6 [ 677.164385] input: spice vdagent tablet as /devices/virtual/input/input7 [183308.532032] INFO: rcu_sched self-detected stall on

[Qemu-devel] [PATCH v2] qdev: drop misleading qdev_free() function

2013-09-11 Thread Stefan Hajnoczi
The qdev_free() function name is misleading since all the function does is unlink the device from its parent. The device is not necessarily freed. The device will be freed when its QObject refcount reaches zero. It is usual for the parent (bus) to hold the final reference but there are cases whe

[Qemu-devel] [RFC 0/4] ARM aarch64 disas output libvixl support

2013-09-11 Thread Claudio Fontana
This is the aarch64 libvixl support patchset in the current state. It provides (limited) support for disassembly output on aarch64. Only host disassembly is enabled, since target for aarch64 is not in yet. An external objdump solution as exemplified before by R.H. seems preferable to me, even if

[Qemu-devel] [RFC 1/4] configure: add c++ compiler support

2013-09-11 Thread Claudio Fontana
This patch is similar to Tomoki Sekiyama's [PATCH v9 01/10] configure: Support configuring C++ compile, with the main differences being: not using "c++" as default compiler, instead do not enable by default (requires explicit CXX env, --cxx option or cross-compilation prefix) separate CFLAGS an

[Qemu-devel] [RFC 2/4] rules.mak: support C++ compiling and linking

2013-09-11 Thread Claudio Fontana
support compilation of .cc and .cpp files, and if C++ is enabled always link with C++ in the non-libtool case. Signed-off-by: Claudio Fontana --- rules.mak | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/rules.mak b/rules.mak index 4499745..d2f1b1f 1

[Qemu-devel] [RFC 4/4] disas: implement host disassembly output for aarch64

2013-09-11 Thread Claudio Fontana
use C++ libvixl to implement output, for now only enabled for the host output disasm, since we don't have the aarch64 target yet. Signed-off-by: Claudio Fontana --- configure | 6 + disas.c | 2 ++ disas/Makefile.objs | 7 ++ disas/aarch64

Re: [Qemu-devel] [RFC 0/4] ARM aarch64 disas output libvixl support

2013-09-11 Thread Andreas Färber
Hi Claudio, Am 11.09.2013 14:54, schrieb Claudio Fontana: > > This is the aarch64 libvixl support patchset in the current state. > It provides (limited) support for disassembly output on aarch64. > Only host disassembly is enabled, since target for aarch64 is not in yet. > > An external objdump

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-09-11 Thread Fabio Fantoni
Il 11/09/2013 13:38, Fabio Fantoni ha scritto: Il 11/09/2013 12:19, Ian Campbell ha scritto: On Wed, 2013-09-11 at 12:14 +0200, Fabio Fantoni wrote: Ping Is this directed and Xen or qmeu folks? What are the outstanding questions which need to be answered? It doesn't look to me like Ian's con

Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes & cleanup

2013-09-11 Thread Markus Armbruster
Markus Armbruster writes: > Series has been on list for more than 8 weeks (not counting the initial > PATCH RFC), and rebased twice. Right now, it still applies. Please > either merge or tell me what I need to do to get it merged. Thanks! Twelve weeks now. > Markus Armbruster writes: > >> A

Re: [Qemu-devel] [RFC 0/4] ARM aarch64 disas output libvixl support

2013-09-11 Thread Peter Maydell
On 11 September 2013 14:14, Andreas Färber wrote: > Am 11.09.2013 14:54, schrieb Claudio Fontana: >> This is the aarch64 libvixl support patchset in the current state. >> It provides (limited) support for disassembly output on aarch64. >> Only host disassembly is enabled, since target for aarch64

[Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Fam Zheng
Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading function: void module_load(module_load_type). which loads all ".so" files in a subdir under "${

[Qemu-devel] [PATCH v6 7/8] .gitignore: ignore module related files (dll, so, mo)

2013-09-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index d2c5c2f..4d0ac09 100644 --- a/.gitignore +++ b/.gitignore @@ -63,6 +63,9 @@ fsdev/virtfs-proxy-helper.pod *.cp *.dvi *.exe +*.dll +*.so +*.mo *.fn *.ky *.log -- 1.8.

Re: [Qemu-devel] [PATCH 0/2] Try to fix problem with emulated smartcards where invalid PIN succeeds

2013-09-11 Thread Ray Strode
Hi, On Mon, Sep 9, 2013 at 2:19 PM, Robert Relyea wrote: > ack... The original problem is a little worse than ray says. It's not a > 60 second window, it's pretty much anytime until the card is explicitly > logged out. Ray's patch will fix this. Okay, I'll resend the patch series with an improved

[Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules

2013-09-11 Thread Fam Zheng
The new option will enable support of shared object build. Otherwise objects are static linked to executables. Signed-off-by: Fam Zheng --- Makefile.target | 6 +- configure | 8 rules.mak | 6 +- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/Makefi

[Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs

2013-09-11 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed a nested var (e.g. common-obj-y) t

[Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules

2013-09-11 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs no longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. Signed-off-by: Fam Zheng --- block/M

Re: [Qemu-devel] [RFC 0/4] ARM aarch64 disas output libvixl support

2013-09-11 Thread Peter Maydell
On 11 September 2013 13:54, Claudio Fontana wrote: > This is the aarch64 libvixl support patchset in the current state. > It provides (limited) support for disassembly output on aarch64. > Only host disassembly is enabled, since target for aarch64 is not in yet. Incidentally, people interested in

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:34, Fam Zheng ha scritto: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './block

[Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
The variable extra_cflags needs to be quoted in config-host.mak, in particular because it might contain parentheses that would otherwise be interpreted by the shell when reloading the file. For instance, if one wants to define some attribute with configure: ./configure --extra-cflags="-Dcoroutine

[Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-11 Thread Fam Zheng
Add necessary rules and flags for shared object generation. $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). The new rules introduced here are: 0) For all %.so compiling: QEMU_CFLAGS += -fPIC 1) %.o in $(common-obj-m) is compiled to %.o, then linked

Re: [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:34, Fam Zheng ha scritto: > Adds extract-libs in LINK to expand any "per object libs", the syntax to > define > such a libs options is like: > > foo.o-libs := $(CURL_LIBS) > > in block/Makefile.objs. > > Similarly, > > foo.o-cflags := $(FOO_CFLAGS) > > is also

[Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install"

2013-09-11 Thread Fam Zheng
Install all the subdirs for modules under configure option "moddir". Signed-off-by: Fam Zheng --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index c50b4b3..ca84d32 100644 --- a/Makefile +++ b/Makefile @@ -360,6 +360,12 @@ install-datadir install-locals

Re: [Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:34, Fam Zheng ha scritto: > The new option will enable support of shared object build. Otherwise > objects are static linked to executables. > > Signed-off-by: Fam Zheng > --- > Makefile.target | 6 +- > configure | 8 > rules.mak | 6 +- > 3 files c

[Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

[Qemu-devel] [PATCH v2 0/2] Try to fix problem with emulated smartcards where invalid PIN succeeds

2013-09-11 Thread Ray Strode
This updated patch series includes Reviewed-By lines from Alon Levy and Robert Relyea, and also improves the accuracy of the second commit message. This set should be ready to merge. Back story is that I started writing a blog post about virtualized smartcards here: https://blogs.gnome.org/hal

[Qemu-devel] [PATCHv2 2/2] libcacard: Lock NSS cert db when selecting an applet on an emulated card

2013-09-11 Thread Ray Strode
From: Ray Strode When a process in a guest uses an emulated smartcard, libcacard running on the host passes the PIN from the guest to the PK11_Authenticate NSS function. The first time PK11_Authenticate is called the passed in PIN is used to unlock the certificate database. Subsequent calls to PK

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:41, Gabriel Kerneis ha scritto: > The variable extra_cflags needs to be quoted in config-host.mak, > in particular because it might contain parentheses that would > otherwise be interpreted by the shell when reloading the file. > > For instance, if one wants to define some attribu

[Qemu-devel] [PATCHv2 1/2] libcacard: introduce new vcard_emul_logout

2013-09-11 Thread Ray Strode
From: Ray Strode vcard_emul_reset currently only logs NSS out, but there is a TODO for potentially sending insertion/removal events when powering down or powering up. For clarity, this commit moves the current guts of vcard_emul_reset to a new vcard_emul_logout function which will never send ins

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Peter Maydell
On 11 September 2013 06:38, Fam Zheng wrote: > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -34,6 +34,7 @@ > #include "qemu/timer.h" > #include "qemu/envlist.h" > #include "elf.h" > +#include > > char *exec_path; > > @@ -3551,6 +3552,8 @@ int main(int argc, char **argv, char **envp)

Re: [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install"

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:34, Fam Zheng ha scritto: > Install all the subdirs for modules under configure option "moddir". > > Signed-off-by: Fam Zheng > --- > Makefile | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Makefile b/Makefile > index c50b4b3..ca84d32 100644 > --- a/Makefile > +

[Qemu-devel] [PATCH v6 0/8] Shared Library Module Support

2013-09-11 Thread Fam Zheng
This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules The main idea behind modules is to isolate dependencies on third party libraries from qemu executables, such as libglusterfs or librbd, so that the end users can install core qemu packa

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 16:10, Alex Bligh ha scritto: > > > --On 11 September 2013 13:38:27 +0800 Fam Zheng wrote: > >> +switch (type) { >> +case MODULE_LOAD_BLOCK: >> +path = CONFIG_PREFIX "/qemu/block/"; >> +break; >> +case MODULE_LOAD_UI: >> +path = CONFIG_PREFIX "/

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Alex Bligh
--On 11 September 2013 13:38:27 +0800 Fam Zheng wrote: +switch (type) { +case MODULE_LOAD_BLOCK: +path = CONFIG_PREFIX "/qemu/block/"; +break; +case MODULE_LOAD_UI: +path = CONFIG_PREFIX "/qemu/ui/"; +break; +case MODULE_LOAD_NET: +path

[Qemu-devel] [PATCH v4 17/24] arm11mpcore: Create container MemoryRegion in instance_init

2013-09-11 Thread Andreas Färber
This allows to map the region directly after object initialization. Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 8719634..5f80e7b 100644 --- a/hw/cpu/ar

[Qemu-devel] [PATCH v4 04/24] a9scu: QOM cleanups

2013-09-11 Thread Andreas Färber
From: Andreas Färber Rename A9SCUState::busdev field to parent_obj and turn realizefn into an instance_init function to allow early MMIO mapping. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/misc/a9scu.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[Qemu-devel] [PATCH v4 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification

2013-09-11 Thread Andreas Färber
From: Andreas Färber Hello Peter, This series fully QOM'ifies A9MPCore so that it can be embedded for Tegra2. It goes on to do the same for A15MPCore, which had previously been taken as template for Cortex-A57 by John Rigby, and since v3 ARM11MPCore. Separate headers are introduced to only expo

[Qemu-devel] [PATCH v4 15/24] arm11mpcore: Fix typo in MemoryRegion name

2013-09-11 Thread Andreas Färber
"mpcode" -> "mpcore" Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index a786c62..27cd32b 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -93,7 +93,7 @@ static

[Qemu-devel] [PATCH v4 13/24] a15mpcore: Prepare for QOM embedding

2013-09-11 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 21 + include/hw/cpu/a15mpcore.h | 44 2 files changed, 45 insertions(+), 20 deletions(-) create mode 100644 include/hw/cpu/a15mpcore.h diff --g

[Qemu-devel] [PATCH v4 06/24] arm_mptimer: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber Split the SysBusDevice initfn into instance_init and realizefn. Signed-off-by: Andreas Färber --- hw/timer/arm_mptimer.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c index 80

[Qemu-devel] [PATCH v4 07/24] a9mpcore: Embed ARMMPTimerState

2013-09-11 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 29 ++- hw/timer/arm_mptimer.c | 35 --- include/hw/timer/arm_mptimer.h | 54 ++ 3 files

  1   2   3   >