On Wed, 09/11 10:01, Gerd Hoffmann wrote: > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > > Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > > > > > There are a couple of things that can be improved still (I don't like > > > obj-save-y for example), but things are taking shape and all of this > > > looks like something that can be fixed on top. If you look at > > > converting more parts to modules (e.g. rbd or spice), you can drop that > > > RFC! :) > > > > Talking about spice, a question for Gerd. > > > > With Fam's work to enable shared modules, hw/display/qxl* would have to > > be placed in a module as well because they depend on ui/spice-core.c. > > Yes. Can modules depend on modules? Or would we have to create a > single, big spice module with core, qxl, audio, chardev etc? > No dependence support yet.
Fam > > Right now, modularization is limited to files that are built once for > > all of QEMU, which is not the case for qxl. > > > > It looks like TARGET_PAGE_SIZE is the only reason why qxl is built > > per-target, and in qxl_ram_set_dirty it should be enough to do > > > > qxl_set_dirty(&qxl->vga.vram, offset, offset + 1); > > > > Would it be fine to use a generic 4096 constant everywhere else? > > Yes. Maybe s/TARGET_PAGE_SIZE/QXL_PAGE_SIZE/ to make clear that qxl > operates on 4k pages. > > cheers, > Gerd > >
