We have a lot of code duplication between machine types,
this increases with each new machine type
and each new field.
This has already introduced a minor bug: description
for pc-1.3 says "Standard PC" while description for
pc-1.4 is "Standard PC (i440FX + PIIX, 1996)"
which makes you think 1.3 is
Il 27/08/2013 01:17, Peter Maydell ha scritto:
> On 26 August 2013 23:33, Paolo Bonzini wrote:
>> Il 26/08/2013 19:30, Richard Henderson ha scritto:
>>> This isn't the kernel, where non-pagable code size is a concern, so I don't
>>> see
>>> how full configuration of machine emulations and devices
Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
>>> So this is here to make sure we don't accidentally get out of halted state
>>> by an interrupt on that vcpu. Could you please somehow make that part
>>> obvious? Either by adding a comment or by only explicitly masking DEC and
>>> EE and
Il 26/08/2013 09:12, Markus Armbruster ha scritto:
> * pc and its variants
>
> Of 19 PC types, 18 get .default_boot_order = "cad", and one (xenfv)
> gets nothing.
I think you mean xenpv---which isn't a PC machine, in principle (or so
Stefano told me) it could be used for ARM as well.
Paolo
commit 398489018183d613306ab022653552247d93919f
pc: limit 64 bit hole to 2G by default
introduced a way for management to control
the window allocated to the 64 bit PCI hole.
This is useful, but existing management tools do not know how to set
this property. As a result, e.g. specifying a lar
Paolo Bonzini writes:
> Il 26/08/2013 09:12, Markus Armbruster ha scritto:
>> * pc and its variants
>>
>> Of 19 PC types, 18 get .default_boot_order = "cad", and one (xenfv)
>> gets nothing.
>
> I think you mean xenpv---which isn't a PC machine, in principle (or so
> Stefano told me) it coul
Il 27/08/2013 09:01, Michael S. Tsirkin ha scritto:
> We have a lot of code duplication between machine types,
> this increases with each new machine type
> and each new field.
>
> This has already introduced a minor bug: description
> for pc-1.3 says "Standard PC" while description for
> pc-1.4 i
On Mon, Aug 26, 2013 at 11:52:26AM +0200, Erik Rull wrote:
> is it possible to get back to the "legacy" BIOS instead of the (u)efi based
> BIOS? I have problems booting the guest on a SSD HDD, there it reboots
> infinitely, when running the guest on a rotating HDD, it works. On qemu 1.2.0
> both di
On 08/27/2013 05:02 PM, Paolo Bonzini wrote:
> Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
So this is here to make sure we don't accidentally get out of halted state
by an interrupt on that vcpu. Could you please somehow make that part
obvious? Either by adding a comment
On Mon, Aug 26, 2013 at 09:59:51PM -0500, Yaodong Yang wrote:
> In sum, the bdrv_co_do_readv() seems to be executed inside two thread, the
> migration thread and native iothread. Both of them executed the function
> twice for a single request. Could someone explain it for me ? I appreciate it
>
On 08/21/2013 02:42 PM, Alexey Kardashevskiy wrote:
> This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
> Changes:
> v2:
> * added slot and function numbers into traces
> * added arrows in trace strings
> ---
> hw/pci/pci_ho
Yes, it is a bug. It should go back to the previous setting if the new screen
resolution falied.
I will send a patch later.
Thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1216368
Title:
u
"Michael S. Tsirkin" writes:
> We have a lot of code duplication between machine types,
> this increases with each new machine type
> and each new field.
>
> This has already introduced a minor bug: description
> for pc-1.3 says "Standard PC" while description for
> pc-1.4 is "Standard PC (i440FX
On Mon, Aug 26, 2013 at 10:07:23AM -0500, Yaodong Yang wrote:
> 1. Is it true that all the requests to disk images need to go through
> function bdrv_co_do_readv() or bdrv_co_do_writev()?
Yes, read/write requests go through those functions.
> 2. In block-migration thread, the bdrv_co_do_readv is
It should be caller's responsibility to tell which bds* needs take
action in multithread case, but since now only one thread exist
and only one bds* group exist, add this function to manage the
bds* queue temporarily. Once the block layer user code manage
the bds* queue by itself and global bdrv_st
In order to support multiple caller from different thread, global
inside block layer should be carefully treated. bdrv_states represent
a group of bds* which is now used by qemu, so it is a user concept which
should be managed by user. This series tries to move it out, so later
different thread can
Signed-off-by: Wenchao Xia
---
block.c |2 +-
include/block/block.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index a387c1a..9db3c32 100644
--- a/block.c
+++ b/block.c
@@ -93,7 +93,7 @@ static bool bdrv_exceed_iops_limits(BlockDr
Signed-off-by: Wenchao Xia
---
block.c |4 ++--
include/block/block.h |2 +-
migration.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index bf35b90..e4dd84e 100644
--- a/block.c
+++ b/block.c
@@ -4175,11 +4175,11 @@ vo
Am 23.08.2013 um 13:05 hat Ján Tomko geschrieben:
> On 08/19/2013 11:25 AM, Kevin Wolf wrote:
> > By the time that qemu 1.7 will be released, enough time will has passed
> > since qemu 1.1, which is the first version to understand version 3
> > images, that changing the default shouldn't hurt many
On Thu, Aug 22, 2013 at 03:09:06PM -0500, Anthony Liguori wrote:
> Paolo Bonzini writes:
> > Also, a virtio watchdog device makes little sense, IMHO. PV makes sense
> > if emulation has insufficient performance, excessive CPU usage, or
> > excessive complexity. We already have both an ISA and a
By the time that qemu 1.7 will be released, enough time will have passed
since qemu 1.1, which is the first version to understand version 3
images, that changing the default shouldn't hurt many people any more
and the benefits of using the new format outweigh the pain.
qemu-iotests already runs wi
According to hpet spec, hpet irq is high active. But according to
ICH spec, there is inversion before the input of ioapic. So the OS
will expect low active on this IRQ line.(And this is observed on
bare metal).
We fold the emulation of this inversion inside the hpet logic.
Signed-off-by: Liu Ping
On different machines, the device can has different properties.
Export machine type's check interface to devices, so the device
can decide its behavior at runtime.
Signed-off-by: Liu Ping Fan
---
include/hw/boards.h | 1 +
vl.c| 8
2 files changed, 9 insertions(+)
diff
On q35 machine, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23
of ioapic can be dynamically assigned to hpet as guest chooses.
Signed-off-by: Liu Ping Fan
---
hw/timer/hpet.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/
On Tue, Aug 27, 2013 at 08:58:05AM +0200, Paolo Bonzini wrote:
> > diff --git a/block/gluster.c b/block/gluster.c
> > index 46f36f8..942154a 100644
> > --- a/block/gluster.c
> > +++ b/block/gluster.c
> > @@ -427,20 +427,9 @@ static void gluster_finish_aiocb(struct glfs_fd *fd,
> > ssize_t ret, voi
Currently if gluster AIO callback thread fails to notify the QEMU thread about
AIO completion, we try graceful recovery by marking the disk drive as
inaccessible. This error recovery code is race-prone as found by Asias and
Stefan. However as found out by Paolo, this kind of error is impossible and
On Tue, Aug 27, 2013 at 05:48:35PM +1000, Alexey Kardashevskiy wrote:
> On 08/21/2013 02:42 PM, Alexey Kardashevskiy wrote:
> > This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses.
> >
> > Signed-off-by: Alexey Kardashevskiy
> > ---
> > Changes:
> > v2:
> > * added slot and
On Wed, Aug 21, 2013 at 02:42:06PM +1000, Alexey Kardashevskiy wrote:
> This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
Applied, thanks.
> Changes:
> v2:
> * added slot and function numbers into traces
> * added arrows in
v2:
* Rebased onto qemu.git/master following the merge of Alex's AioContext timers
The purpose of these patches is to eventually allow device models to set and
cancel timers without holding the global mutex. When the device model runs in
a vcpu thread and the iothread processes timers, the
QEMUT
host_alarm_handler() is invoked from the signal processing thread
(currently the iothread). Previously we did processing in a real signal
handler with signalfd and therefore needed signal-safe timer code.
Today host_alarm_handler() just marks the alarm timer as expired/pending
and notifies the ma
Introduce QEMUTimerList->active_timers_lock to protect the linked list
of active timers. This allows qemu_timer_mod_ns() to be called from any
thread.
Note that vm_clock is not thread-safe and its use of
qemu_clock_has_timers() works fine today but is also not thread-safe.
The purpose of this pa
On Tue, Aug 27, 2013 at 09:29:33AM +0200, Paolo Bonzini wrote:
> Il 27/08/2013 09:01, Michael S. Tsirkin ha scritto:
> > We have a lot of code duplication between machine types,
> > this increases with each new machine type
> > and each new field.
> >
> > This has already introduced a minor bug: d
On 27.08.2013, at 05:42, Alexey Kardashevskiy wrote:
> This has reworked USB OHCI and adds support of USB EHCI,
> VIRTIO-SCSI and various fixes (IBM VSCSI, VGA and more).
>
> The full list of fixes is:
> * usb-ohci: Convert td-phys every time to td-virt
> * usb-storage: Fix cbwflags field
> *
On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote:
> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote:
>> Also, QEMU is definitely not the only project that has higher
>> acceptance
>> criteria than patch-works-for-the-patch-author. :)
>
> There's a difference between high acceptance
On Thu, Aug 22, 2013 at 01:25:32PM -0500, Anthony Liguori wrote:
> I believe that the watchdogs we emulate today are not supported by a
> majority of guests.
BTW this is not true. The two watchdog devices are supported
by all Linux guests.
Windows guests do not support them, but Windows lacks[1]
On 27 Aug 2013, at 09:23, Stefan Hajnoczi wrote:
> host_alarm_handler() is invoked from the signal processing thread
> (currently the iothread). Previously we did processing in a real signal
> handler with signalfd and therefore needed signal-safe timer code.
>
> Today host_alarm_handler() just
On 27.08.2013, at 07:43, Nikunj A Dadhania wrote:
> Alexander Graf writes:
>
>> On 26.08.2013, at 13:46, Nikunj A Dadhania wrote:
>>
>>> Alexander Graf writes:
>>>
On 26.08.2013, at 12:58, Nikunj A Dadhania wrote:
> This implements capabilities exchange between host and client
Il 27/08/2013 10:10, Liu Ping Fan ha scritto:
> On q35 machine, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23
> of ioapic can be dynamically assigned to hpet as guest chooses.
First of all, the backwards-compatible q35 machines should also use the
old value.
Second, the HPET should _no
On 27.08.2013, at 09:41, Alexey Kardashevskiy wrote:
> On 08/27/2013 05:02 PM, Paolo Bonzini wrote:
>> Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
> So this is here to make sure we don't accidentally get out of halted
> state by an interrupt on that vcpu. Could you please someh
On 27 Aug 2013, at 09:23, Stefan Hajnoczi wrote:
> Introduce QEMUTimerList->active_timers_lock to protect the linked list
> of active timers. This allows qemu_timer_mod_ns() to be called from any
> thread.
>
> Note that vm_clock is not thread-safe and its use of
> qemu_clock_has_timers() works
On Tue, Aug 27, 2013 at 4:45 PM, Paolo Bonzini wrote:
> Il 27/08/2013 10:10, Liu Ping Fan ha scritto:
>> On q35 machine, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23
>> of ioapic can be dynamically assigned to hpet as guest chooses.
>
> First of all, the backwards-compatible q35 machin
On 08/27/2013 06:54 PM, Alexander Graf wrote:
>
> On 27.08.2013, at 09:41, Alexey Kardashevskiy wrote:
>
>> On 08/27/2013 05:02 PM, Paolo Bonzini wrote:
>>> Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
>> So this is here to make sure we don't accidentally get out of halted
>> st
On 27.08.2013, at 11:03, Alexey Kardashevskiy wrote:
> On 08/27/2013 06:54 PM, Alexander Graf wrote:
>>
>> On 27.08.2013, at 09:41, Alexey Kardashevskiy wrote:
>>
>>> On 08/27/2013 05:02 PM, Paolo Bonzini wrote:
Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
>>> So this is here
Alexander Graf writes:
>> +static int vscsi_send_capabilities(VSCSIState *s, vscsi_req *req)
>> +{
>> +struct viosrp_capabilities *vcap;
>> +struct capabilities cap = { };
>> +uint16_t len, req_len;
>> +uint64_t buffer;
>> +int rc;
>> +
>> +vcap = &req->iu.mad.capabilities;
On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote:
> From: David Gibson
>
> Recent (host) kernels support emulating the PAPR defined "XICS" interrupt
> controller system within KVM. This patch allows qemu to initialize and
> configure the in-kernel XICS, and keep its state in sync with qemu'
On 23.08.2013, at 14:02, Alexey Kardashevskiy wrote:
> From: Benjamin Herrenschmidt
>
> This adds support for the H_IPOLL hypercall which the guest
> uses to poll for a pending interrupt. This hypercall is
> mandatory for PAPR+ and there is no way for the guest to
> detect whether it is support
On 23.08.2013, at 14:03, Alexey Kardashevskiy wrote:
> From: Benjamin Herrenschmidt
>
> This implements H_XIRR_X hypercall in addition to H_XIRR as
> it is mandatory for PAPR+ and there is no way for the guest to
> detect whether it is supported or not so just add it.
>
> As the Partition Adju
Il 27/08/2013 11:01, liu ping fan ha scritto:
> On Tue, Aug 27, 2013 at 4:45 PM, Paolo Bonzini wrote:
>> Il 27/08/2013 10:10, Liu Ping Fan ha scritto:
>>> On q35 machine, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23
>>> of ioapic can be dynamically assigned to hpet as guest chooses.
>>
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> This adds an incompatible bit indicating corruption to qcow2. Any image
> with this bit set may not be written to unless for repairing (and
> subsequently clearing the bit if the repair has been successful).
>
> Signed-off-by: Max Reitz
> ---
>
Am 27.08.2013 11:54, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful).
On 23.08.2013, at 06:29, Alexey Kardashevskiy wrote:
> On 08/19/2013 07:01 PM, Michael S. Tsirkin wrote:
>> On Mon, Aug 19, 2013 at 06:10:01PM +1000, Alexey Kardashevskiy wrote:
>>> On 08/19/2013 05:54 PM, Michael S. Tsirkin wrote:
On Mon, Aug 19, 2013 at 05:44:04PM +1000, Alexey Kardashevsk
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> Two new functions are added; the first one checks a given range in the
> image file for overlaps with metadata (main header, L1 tables, L2
> tables, refcount table and blocks).
>
> The second one should be used immediately before writing to the i
On Tue, Aug 27, 2013 at 12:06:49PM +0200, Alexander Graf wrote:
>
> On 23.08.2013, at 06:29, Alexey Kardashevskiy wrote:
>
> > On 08/19/2013 07:01 PM, Michael S. Tsirkin wrote:
> >> On Mon, Aug 19, 2013 at 06:10:01PM +1000, Alexey Kardashevskiy wrote:
> >>> On 08/19/2013 05:54 PM, Michael S. Tsir
On Tue, 2013-08-27 at 13:26 +0300, Michael S. Tsirkin wrote:
> e would end up with something like
> >
> > diff --git a/kvm-all.c b/kvm-all.c
> > index 716860f..ca3251e 100644
> > --- a/kvm-all.c
> > +++ b/kvm-all.c
> > @@ -1190,6 +1190,10 @@ int kvm_irqchip_add_msi_route(KVMState *s,
> > MSIMessa
On Mon, Aug 26, 2013 at 03:34:15PM -0700, Richard Henderson wrote:
> On 08/26/2013 03:26 PM, Paolo Bonzini wrote:
> > Something that can be done on top of this patch: what about moving the
> > "-1" to helper_ret_*? It is common to pretty much all the targets
> > (except ARM has -2), and it would a
On Tue, Aug 27, 2013 at 12:26:00AM +0100, Peter Maydell wrote:
> On 26 August 2013 22:00, Richard Henderson wrote:
> > Allow the code that tcg generates to be less obtuse, passing in
> > the return address directly instead of computing it in the helper.
>
> > +uint8_t helper_ret_ldb_mmu(CPUArchSt
On Fri, Aug 16, 2013 at 11:13:25PM -0700, Richard Henderson wrote:
> V2:
> * Feedback from Aurelien
> * Added the first patch.
> * ARM patches fixed.
>
> Sorry about not merging back from the tree on my arm machine
> before posting the patch set last time.
>
>
> r~
>
>
> Richard H
Currently, If the setting of video mode failed, qemu will exit. It
should go back to the previous setting if the new screen resolution
failed. This patch fixes LP#1216368, add support to revert to existing
surface for the failure of video mode setting.
Reported-by: Sascha Krissler
Signed-off-by:
Am 27.08.2013 12:17, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
Two new functions are added; the first one checks a given range in the
image file for overlaps with metadata (main header, L1 tables, L2
tables, refcount table and blocks).
The second one should be used i
On 07.08.2013, at 10:21, Alexey Kardashevskiy wrote:
> The patch adds a spapr-pci-vfio-host-bridge device type
> which is a PCI Host Bridge with VFIO support. The new device
> inherits from the spapr-pci-host-bridge device and adds
> the following properties:
> iommu - IOMMU group ID which
Am 27.08.2013 um 13:06 hat Max Reitz geschrieben:
> Am 27.08.2013 12:17, schrieb Kevin Wolf:
> >Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> >>Two new functions are added; the first one checks a given range in the
> >>image file for overlaps with metadata (main header, L1 tables, L2
> >>tabl
The x86 and ppc targets call cpu_synchronize_state() from their
*_cpu_dump_state() callbacks to ensure that up to date state is dumped
when KVM is enabled (for example when a KVM internal error occurs).
Move this call up into the generic cpu_dump_state() function so that
other KVM targets (namely
On 27.08.2013, at 12:32, Benjamin Herrenschmidt wrote:
> On Tue, 2013-08-27 at 13:26 +0300, Michael S. Tsirkin wrote:
>> e would end up with something like
>>>
>>> diff --git a/kvm-all.c b/kvm-all.c
>>> index 716860f..ca3251e 100644
>>> --- a/kvm-all.c
>>> +++ b/kvm-all.c
>>> @@ -1190,6 +1190,10
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> The pre-write overlap check function is now called before most of the
> qcow2 writes (aborting it on collision or other error).
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-cache.c| 17 +
> block/qcow2-cluster.c | 23 ++
Is there somebody can help me to trigger a gpio interrupt inside qemu? I
wrote a simple function to trigger a interrupt in pl061.c as follow:
PL061State *gPl061;
void pl061_raise_irq()
{
qemu_set_irq(gPl061->irq, 1);
}
gPl061 is assigned in function pl061_initfn:
static int pl061_initfn(SysBusD
Am 27.08.2013 13:32, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17 +
Am 27.08.2013 um 13:41 hat Max Reitz geschrieben:
> Am 27.08.2013 13:32, schrieb Kevin Wolf:
> >Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> >>The pre-write overlap check function is now called before most of the
> >>qcow2 writes (aborting it on collision or other error).
> >>
> >>Signed-off
On Tue, Aug 27, 2013 at 3:36 PM, she roy wrote:
> Is there somebody can help me to trigger a gpio interrupt inside qemu? I
> wrote a simple function to trigger a interrupt in pl061.c as follow:
> PL061State *gPl061;
> void pl061_raise_irq()
> {
> qemu_set_irq(gPl061->irq, 1);
> }
[...]
> But
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> Adds a new function checking for overlapping cluster allocations.
> Furthermore, qcow2_check now marks the image as consistent if no
> corruptions have been found.
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-cluster.c | 414
>
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
> A new test on corrupted images with overlapping cluster allocations.
>
> Signed-off-by: Max Reitz
One more thing that could be checked is that the image can be opened
read-only, but not r/w while the corrupt flag is set. The existing tests
look
Commit 0b516ef0dfad9a7b34c675c98e8ec92ab4d38466 added version.o to all
executables, but broke out-of-tree builds: for those builds the pattern
rule %.o: %.rc from rules.mak does not match, so version.o was no longer
built.
Adding explicit build rules fixes this.
Reported-by: Michael Roth
Signed-
The QEMU mascot which was already used for the NSIS installer
is now used for all QEMU executables.
Signed-off-by: Stefan Weil
---
version.rc |2 ++
1 file changed, 2 insertions(+)
diff --git a/version.rc b/version.rc
index 82e10ec..a50d62f 100644
--- a/version.rc
+++ b/version.rc
@@ -26,3
The following changes since commit f7ad538e1ea130c8b6f3abb06ad6c856242c799e:
Merge remote-tracking branch 'stefanha/block' into staging (2013-08-26
09:19:50 -0500)
are available in the git repository at:
git://qemu.weilnetz.de/qemu.git mingw
for you to fetch changes up to 92f1623663a8797e
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
monitor.c | 18 ++
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index a59a402..d1a6bda 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4090,14 +4090,21 @@ static void file_completion(Moni
Now all completion functions do not use *cur_mon any more, instead
they use rs->mon. In short, structure ReadLineState decide where
the complete action would be taken now.
Tested with the case that qemu have two telnet monitors, auto
completion function works normal.
Signed-off-by: Wenchao Xia
R
These include files don't exist for MinGW and are not needed for Linux
(and hopefully for other hosts as well), so remove them.
Signed-off-by: Stefan Weil
---
ui/gtk.c |4
1 file changed, 4 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index c38146f..b5f4f0b 100644
--- a/ui/gtk.c
+++ b
New member *cmd_table is added in structure Monitor to avoid direct usage of
*mon_cmds. Now monitor have an associated command table, when global variable
*info_cmds is also discarded, structure Monitor would gain full control about
how to deal with user input.
Signed-off-by: Wenchao Xia
---
mon
This series make auto completion and help functions works normal for sub
command, by using reentrant functions. In order to do that, global variables
are not directly used in those functions any more. With this series, cmd_table
is a member of structure Monitor so it is possible to create a monitor
help_cmd() need this function later, so move it. get_str() is called by
parse_cmdline() so it is moved also. Some code style error reported by
check script, is also fixed.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
monitor.c | 191 +++
A new local variable *mon is added in monitor_find_completion()
to make compile pass, which will be removed later in
conversion patch for monitor_find_completion().
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
monitor.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletio
This patch allows auto completion work normal for sub command case,
"info block [DEVICE]" can auto complete now, by re-enter the completion
function. In original code "info" is treated as a special case, now it
is treated as a sub command group, global variable info_cmds is not used
any more.
"hel
It doesn't need to be done for every monitor, so change it.
Signed-off-by: Wenchao Xia
---
monitor.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index fffb434..db4d441 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4762,6 +4762,7 @@ void monitor_i
In order to support sub command in auto completion, a reentrant function
is needed, so monitor_find_completion() is split into two parts. The
first part does parsing of user input which need to be done only once,
the second part does the auto completion job according to the parsing
result, which co
Parameter *mon is added, and local variable *mon added in previous patch
is removed. The caller readline_completion(), pass rs->mon as value, which
should be initialized in readline_init() called by monitor_init().
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
include/monitor/readline.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
monitor.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index 31b527d..a59a402 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4034,7 +4034,7 @@ static void cmd_completion(Monitor *mon, cons
A new parameter type 'S' is introduced to allow user input any string.
"help info block" works normal now.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
hmp-commands.hx |2 +-
monitor.c | 27 +++
2 files changed, 28 insertions(+), 1 deletions(-)
dif
In qmp_human_monitor_command(), the monitor need to initialized for
basic functionalities, and later more init code will be added, so
split off this function. Note that it is different with QMP mode
monitor which accept json string from monitor's input,
qmp_human_monitor_command() retrieve the huma
The old code in help_cmd() uses global 'info_cmds' and treats it as a
special case. Actually 'info_cmds' is a sub command group of 'mon_cmds',
in order to avoid direct use of it, help_cmd() needs to change its work
mechanism to support sub command and not treat it as a special case
any more.
To su
Now special case "help *" in auto completion can work with sub commands,
such as "help info u*".
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
monitor.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index 81f41e6..8d07f9c 100644
---
Since this function will be used by help_cmd() later, so improve
it to make it more generic and easier to use. free_cmdline_args()
is added too as paired function to free the result.
One change of this function is that, when the valid args in input
exceed the limit of MAX_ARGS, it fails now, inste
On 08/27/2013 11:06 AM, Richard W.M. Jones wrote:
On Thu, Aug 22, 2013 at 03:09:06PM -0500, Anthony Liguori wrote:
Paolo Bonzini writes:
Also, a virtio watchdog device makes little sense, IMHO. PV makes sense
if emulation has insufficient performance, excessive CPU usage, or
excessive complex
When a Python script is run, Python normally writes bytecode into a .pyc file.
QEMU's build process uses several Python scripts which are called from
configure or make.
The generated .pyc files take disk space without being of much use, because
those scripts are short, not time critical and only c
On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote:
> Il 22/08/2013 19:53, Laszlo Ersek ha scritto:
> >> > We should just introduce a simple watchdog device based on virtio and
> >> > call it a day. Then it's cross platform, solves the guest enumeration
> >> > problem, and libvirt can d
On Tue, Aug 27, 2013 at 8:13 AM, Daniel P. Berrange wrote:
> On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote:
>> Il 22/08/2013 19:53, Laszlo Ersek ha scritto:
>> >> > We should just introduce a simple watchdog device based on virtio and
>> >> > call it a day. Then it's cross platfor
Hello Eduardo,
I read a bit about caches on wikipedia.
If I understand correctly changing the CPUID L3 cache infos in QEMU will change
the value displayed in the guest /proc/cpuinfo but will not change the size of
the l3 cache used by the hardware. So I am chasing a cosmetic bug.
If it right ?
On Tue, Aug 27, 2013 at 03:18:16PM +0200, Benoît Canet wrote:
>
> Hello Eduardo,
>
> I read a bit about caches on wikipedia.
>
> If I understand correctly changing the CPUID L3 cache infos in QEMU will
> change
> the value displayed in the guest /proc/cpuinfo but will not change the size of
> t
On Tue, 27 Aug 2013 20:39:37 +0800
Wenchao Xia wrote:
> 于 2013-8-27 9:43, Wenchao Xia 写道:
> > 于 2013-8-26 23:55, Luiz Capitulino 写道:
> >> On Fri, 23 Aug 2013 16:17:52 +0800
> >> Wenchao Xia wrote:
> >>
> >>> This series make auto completion and help functions works normal for sub
> >>> command,
于 2013-8-27 9:43, Wenchao Xia 写道:
于 2013-8-26 23:55, Luiz Capitulino 写道:
On Fri, 23 Aug 2013 16:17:52 +0800
Wenchao Xia wrote:
This series make auto completion and help functions works normal for sub
command, by using reentrant functions. In order to do that, global
variables
are not directly
On Tue, Aug 27, 2013 at 04:08:12PM +0300, Ronen Hod wrote:
> So the right solution is to send a heart-beat to a management
> application (using qemu-ga or whatever), and let it decide how to
> handle it.
Agreed. The qemu watchdog lets you do this already. You can (using
the qemu monitor, or libv
On Tue, Aug 27, 2013 at 04:17:56PM +0300, Gleb Natapov wrote:
> On Tue, Aug 27, 2013 at 03:18:16PM +0200, Benoît Canet wrote:
> >
> > Hello Eduardo,
> >
> > I read a bit about caches on wikipedia.
> >
> > If I understand correctly changing the CPUID L3 cache infos in QEMU will
> > change
> > th
1 - 100 of 207 matches
Mail list logo
