Re: [Qemu-devel] [PATCH 0/3] Fail migration on bdrv_flush_all() error

2013-07-15 Thread Stefan Hajnoczi
On Fri, Jul 05, 2013 at 02:03:50PM +0200, Kevin Wolf wrote: > If bdrv_flush_all() returns an error, there is an inconsistency in the > view of an image file between the source and the destination host. > Completing the migration would lead to corruption. Better abort > migration in this case. > >

Re: [Qemu-devel] [PATCH v2 repost 1/9] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-07-15 Thread Hu Tao
On Wed, Jul 10, 2013 at 04:51:35PM +0300, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin Duplicated signed-off-by, although this is not a problem. Reviewed-by: Hu Tao > --- > hw/i386/pc.c | 2 -- > in

Re: [Qemu-devel] [PATCH v2 repost 5/9] i386: add bios linker/loader

2013-07-15 Thread Laszlo Ersek
On 07/14/13 13:41, Michael S. Tsirkin wrote: > On Fri, Jul 12, 2013 at 04:17:28PM +0200, Laszlo Ersek wrote: >> On 07/10/13 15:51, Michael S. Tsirkin wrote: >>> +struct BiosLinkerLoaderEntry { >>> +uint32_t command; >>> +union { >>> +/* >>> + * COMMAND_ALLOCATE - allocate a

Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser

2013-07-15 Thread Dong Xu Wang
On Thu, Jul 11, 2013 at 3:49 AM, Eric Blake wrote: > On 07/09/2013 02:41 PM, Eric Blake wrote: >> On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: >>> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: These patches will replace QEMUOptionParameter with QemuOpts. Change logs ple

Re: [Qemu-devel] [PATCH v2 repost 2/9] i386: add ACPI table files from seabios

2013-07-15 Thread Hu Tao
On Wed, Jul 10, 2013 at 04:51:38PM +0300, Michael S. Tsirkin wrote: <...> > diff --git a/hw/i386/ssdt-misc.dsl b/hw/i386/ssdt-misc.dsl > new file mode 100644 > index 000..ac11e96 > --- /dev/null > +++ b/hw/i386/ssdt-misc.dsl > @@ -0,0 +1,73 @@ > +/* > + * This program is free software; you ca

Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source

2013-07-15 Thread Hu Tao
On Wed, Jul 10, 2013 at 04:51:41PM +0300, Michael S. Tsirkin wrote: > Detect presence of IASL compiler and use it > to process ASL source. If not there, use pre-compiled > files in-tree. Add script to update the in-tree files. Do you want to check for iasl version for now? See: http://www.seabios

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 1/5] linker: utility to patch in-memory ROM files

2013-07-15 Thread Michael S. Tsirkin
On Sun, Jul 14, 2013 at 02:24:52PM -0400, Kevin O'Connor wrote: > On Sun, Jul 07, 2013 at 06:42:35PM +0300, Michael S. Tsirkin wrote: > > Add ability for a ROM file to point to > > it's image in memory. When file is in memory, > > add utility that can patch it, storing > > pointers to one file with

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 4/5] acpi: load and link tables from /etc/acpi/

2013-07-15 Thread Michael S. Tsirkin
On Sun, Jul 14, 2013 at 02:27:14PM -0400, Kevin O'Connor wrote: > On Sun, Jul 07, 2013 at 06:42:43PM +0300, Michael S. Tsirkin wrote: > > Load files in /etc/acpi/, link them using > > a linker script and use for acpi tables, including the RSDP. > > Presense of RSDP in this directory completely disa

Re: [Qemu-devel] build bot not updating?

2013-07-15 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 12:02:50PM +0800, Stefan Hajnoczi wrote: > On Mon, Jul 08, 2013 at 08:33:55AM +0300, Michael S. Tsirkin wrote: > > I noticed two things with buildbot: > > http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_6_0 > > > > 1. up to jun 23 it keept rebuilding same hash

Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source

2013-07-15 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 04:00:23PM +0800, Hu Tao wrote: > On Wed, Jul 10, 2013 at 04:51:41PM +0300, Michael S. Tsirkin wrote: > > Detect presence of IASL compiler and use it > > to process ASL source. If not there, use pre-compiled > > files in-tree. Add script to update the in-tree files. > > Do

Re: [Qemu-devel] [PATCH v2] [Bug 1187529] Update bridge mappings for migration/restore

2013-07-15 Thread Michael S. Tsirkin
On Tue, Jul 09, 2013 at 11:40:02AM -0400, dk...@verizon.com wrote: > From: Don Koch > > Fix for LP#1187529: Devices on PCI bridge stop working when > live-migrated. Update bridge mappings for all PCI bridge > devices in get_pci_config_device(). > > Signed-off-by: Don Koch Applied, thanks. > -

Re: [Qemu-devel] [PATCH] Fix BRDIGE typo.

2013-07-15 Thread Michael S. Tsirkin
On Tue, Jul 09, 2013 at 01:36:05PM -0400, Don Koch wrote: > From: Don Koch > > Fix typo in PCI_CLASS_BRDIGE_PCI_INF_SUB. > > Signed-off-by: Don Koch Applied, thanks. > --- > hw/pci-bridge/i82801b11.c | 2 +- > include/hw/pci/pci_ids.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(

[Qemu-devel] [PATCH] hw/openrisc: typo in openrisc_sim

2013-07-15 Thread Jia Liu
2 indent typo. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 924438b..f0dabb9 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@

Re: [Qemu-devel] [PATCH v2 repost 5/9] i386: add bios linker/loader

2013-07-15 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 09:33:25AM +0200, Laszlo Ersek wrote: > On 07/14/13 13:41, Michael S. Tsirkin wrote: > > On Fri, Jul 12, 2013 at 04:17:28PM +0200, Laszlo Ersek wrote: > >> On 07/10/13 15:51, Michael S. Tsirkin wrote: > > >>> +struct BiosLinkerLoaderEntry { > >>> +uint32_t command; > >>

[Qemu-devel] [PATCH 1/2] target-openrisc: Free typename in cpu_class_by_name

2013-07-15 Thread Jia Liu
Add a g_free into openrisc_cpu_class_by_name to free typename. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index 6d40f1b..e348df0 100644 --- a/target-openrisc/cpu.c +++ b/target-openrisc/cpu.c

[Qemu-devel] [PATCH 2/2] hw/openrisc: Use stderr output instead of qemu_log

2013-07-15 Thread Jia Liu
Here should be stderr output instead of qemu_log. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 924438b..26bff75 100644 --- a/hw/openrisc/openrisc_sim.c +++ b

[Qemu-devel] [PATCH 0/2] target-openrisc hw/openrisc: Two OpenRISC fix.

2013-07-15 Thread Jia Liu
Fix OpenRISC CPU and sim broad, in cpu.c we should free typename, and in openrisc_sim.c we should use stderr output. Jia Liu (2): target-openrisc: free typename in cpu_class_by_name hw/openrisc: Use stderr output instead of qemu_log hw/openrisc/openrisc_sim.c | 2 +- target-openrisc/cpu.c

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-15 Thread Fabio Fantoni
Il 12/07/2013 17:33, George Dunlap ha scritto: On 12/07/13 13:36, Fabio Fantoni wrote: Il 12/07/2013 13:06, George Dunlap ha scritto: On 12/07/13 11:22, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3

Re: [Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-15 Thread Fabio Fantoni
Il 12/07/2013 15:58, Fabio Fantoni ha scritto: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5

Re: [Qemu-devel] [PATCH v6 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-15 Thread Libaiqing
Hi tomoki, I test the patch v6. When calling the command " guest-fsfreeze-freeze ", an error occurs. The desc is "{"error": {"class": "GenericError", "desc": "failed to initialize for backup: (error: 80042302)"}}" The eventlog in the guest is : EventID 8193;CoCreateInstanceerror h

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

2013-07-15 Thread Stefan Hajnoczi
On Sun, Jul 07, 2013 at 06:00:17PM +0800, Liu Ping Fan wrote: > @@ -211,6 +238,7 @@ AioContext *aio_context_new(void) > ctx = (AioContext *) g_source_new(&aio_source_funcs, sizeof(AioContext)); > ctx->pollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD)); > ctx->thread_pool = NULL; >

[Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-15 Thread Kevin Wolf
AHCI couldn't cope with asynchronous commands that aren't doing DMA, it simply wouldn't complete them. Due to the bug fixed in commit f68ec837, FLUSH commands would seem to have completed immediately even if they were still running on the host. After the commit, they would simply hang and never uns

Re: [Qemu-devel] [PATCH v2 8/8] vexpress: Add virtio-mmio transports

2013-07-15 Thread Peter Maydell
On 15 July 2013 01:17, Peter Crosthwaite wrote: > On Sat, Jul 13, 2013 at 6:37 AM, Peter Maydell > wrote: >> +static int add_virtio_mmio_node(void *fdt, uint32_t acells, uint32_t scells, >> +hwaddr addr, hwaddr size, uint32_t intc, >> +

[Qemu-devel] [PATCH V3 1/7] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-07-15 Thread Xu Wang
If there is a loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. This patch refine and export loop checking function from collect_image_ info_list() to block

[Qemu-devel] [PATCH V3 0/7] Redefine and export backing file loop check

2013-07-15 Thread Xu Wang
If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to bloc

[Qemu-devel] [PATCH V3 6/7] block: Add backing file loop check in qcow2_change_backing_file()

2013-07-15 Thread Xu Wang
Add backing file loop check before execute change backing file for qcow2 format. Signed-off-by: Xu Wang --- block/qcow2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 0eceefe..01bd7d5 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1195,6 +1195

[Qemu-devel] [PATCH V3 2/7] block: Add WIN32 platform support for backing_file_loop_check()

2013-07-15 Thread Xu Wang
Method of get_inode is different between Linux and WIN32 plateform. This patch added inode caculate method on Windows plateform so that backing file check could work on Windows plateform. Signed-off-by: Xu Wang --- block.c | 109 +++- 1

[Qemu-devel] [PATCH V3 3/7] block: Check infinite loop in bdrv_img_create()

2013-07-15 Thread Xu Wang
Backing file loop should be checked before qemu-img create command execution. If loop was found, qemu-img create should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index a

[Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init()

2013-07-15 Thread Xu Wang
Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- blockdev.c | 6 ++

Re: [Qemu-devel] [PATCH V2 0/1] ARM aarch64 TCG tlb fast lookup

2013-07-15 Thread Claudio Fontana
On 10.07.2013 16:48, Jani Kokkonen wrote: > > This patch implements the TCG tlb fast lookup in > tcg_out_qemu_ld/st for the aarch64 TCG target. > Supports also CONFIG_QEMU_LDST_OPTIMIZATION. > > Tested running on a x86-64 physical machine running Foundation v8, > running a linux 3.2.0 minimal

[Qemu-devel] [PATCH V3 4/7] block: Add backing file loop check in change_backing_file()

2013-07-15 Thread Xu Wang
Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error was printed. Signed-off-by: Xu Wang --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index e9b9112..bd8240c 100644 ---

[Qemu-devel] [PATCH V3 7/7] block: Add backing file loop check in qed_change_backing_file()

2013-07-15 Thread Xu Wang
Add backing file loop check before execute change backing file for qed format. Signed-off-by: Xu Wang --- block/qed.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/qed.c b/block/qed.c index f767b05..79c2875 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1468,6 +1468,13 @@ stat

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-15 Thread Alexey Kardashevskiy
On 07/15/2013 04:06 PM, Alexander Graf wrote: > > On 15.07.2013, at 05:24, Alexey Kardashevskiy wrote: > >> As it looks like all portio users have migrated to new portio api, >> the workaround with memory access to io ports routing is no more >> needed. >> >> This also fixes a bug with byte swapp

Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-15 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 11:34:31AM +0200, Kevin Wolf wrote: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running

Re: [Qemu-devel] [PATCH v2 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-15 Thread Peter Maydell
On 15 July 2013 01:30, Peter Crosthwaite wrote: > I have patches on list converting the other "setprop" APIs to Error ** based > reporting (as per your suggestion). Once that change happens we will have > two separate error schemes for the one fn. > > For sanity checking user specified values (e.g

Re: [Qemu-devel] Morph cpu_reset -> device_reset

2013-07-15 Thread Andreas Färber
Hi Peter, Am 15.07.2013 06:02, schrieb Peter Crosthwaite: > A while ago, TYPE_CPU was refactored to by a child of TYPE_DEVICE. As > something of a hangover though, CPU has a separate reset fn to device. > This means > > device_reset(DEVICE(my_cpu)); > > doesn't actually work as a reset. Should w

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-15 Thread Qiao Nuohan
On 07/09/2013 03:36 PM, Qiao Nuohan wrote: Still waiting for introspection... And comments about format will be very helpful. Hi Stefan and others, What do you think about the process of creating vmcore in kdump-compressed format? -- Regards Qiao Nuohan

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 4/5] acpi: load and link tables from /etc/acpi/

2013-07-15 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 11:11:59AM +0300, Michael S. Tsirkin wrote: > On Sun, Jul 14, 2013 at 02:27:14PM -0400, Kevin O'Connor wrote: > > On Sun, Jul 07, 2013 at 06:42:43PM +0300, Michael S. Tsirkin wrote: > > > Load files in /etc/acpi/, link them using > > > a linker script and use for acpi tables

Re: [Qemu-devel] [PATCH v2 repost 2/9] i386: add ACPI table files from seabios

2013-07-15 Thread Michael S. Tsirkin
On Mon, Jul 15, 2013 at 03:49:18PM +0800, Hu Tao wrote: > Otherwise, > > Reviewed-by: Hu Tao Thanks for the detailed review, I'll address your comments in the next revision.

Re: [Qemu-devel] Fw: [PATCH 2/2] Add Enhanced Three-Speed EthernetController (eTSEC)

2013-07-15 Thread Fabien Chouteau
On 07/15/2013 03:25 AM, Yao Xingtao wrote: > Hi: > I'm very interesting in it, but I don't know how to create a eTSEC > device, I did a test as below: > > for(i = 0; i < nb_nics; i++) { > NICInfo *nd = &nd_table[i]; > if (!nd->model) { > nd->model = g_strdup("eTSEC"); >

Re: [Qemu-devel] [PATCH v2 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-15 Thread Peter Crosthwaite
Hi Peter, On Mon, Jul 15, 2013 at 7:44 PM, Peter Maydell wrote: > On 15 July 2013 01:30, Peter Crosthwaite wrote: >> I have patches on list converting the other "setprop" APIs to Error ** based >> reporting (as per your suggestion). Once that change happens we will have >> two separate error sch

Re: [Qemu-devel] [PATCH v2 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-15 Thread Peter Maydell
On 15 July 2013 11:24, Peter Crosthwaite wrote: > On Mon, Jul 15, 2013 at 7:44 PM, Peter Maydell > wrote: >> It's trying to allow the arm/boot code to continue to distinguish >> the two error cases it does currently: >> * RAM start address doesn't fit [a board model error] >> * RAM size doesn'

Re: [Qemu-devel] [PATCH v2] atomic: using memory_order_relaxed for refcnt inc/dec ops

2013-07-15 Thread Paolo Bonzini
Il 14/07/2013 12:23, liu ping fan ha scritto: >> if the refcount ops are frequent enough, I strongly suspect cacheline >> bouncing has a bigger effect than the memory barriers. >> > When out of biglock, object_ref/unref to pin the Device will be quite > often, and can it be marked "frequent"? Or ho

Re: [Qemu-devel] Morph cpu_reset -> device_reset

2013-07-15 Thread Peter Crosthwaite
Hi Andreas, On Mon, Jul 15, 2013 at 7:55 PM, Andreas Färber wrote: > Hi Peter, > > Am 15.07.2013 06:02, schrieb Peter Crosthwaite: >> A while ago, TYPE_CPU was refactored to by a child of TYPE_DEVICE. As >> something of a hangover though, CPU has a separate reset fn to device. >> This means >> >>

[Qemu-devel] [PATCH 1/4] block: add discard_zeroes and max_unmap to BlockDriverInfo

2013-07-15 Thread Peter Lieven
Signed-off-by: Peter Lieven --- include/block/block.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 297ec1e..aceb780 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -18,6 +18,11 @@ typedef struct BlockDriverInfo {

[Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-15 Thread Peter Lieven
this adds the proposed solution to add a generic mechanism to zeroize a target in qemu-img if it has discard_zeroes but has_zero_init is 0. Peter Lieven (4): block: add discard_zeroes and max_unmap to BlockDriverInfo iscsi: add .bdrv_get_info block/raw: add .bdrv_get_info qemu-img: conditi

[Qemu-devel] [PATCH 3/4] block/raw: add .bdrv_get_info

2013-07-15 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/raw.c b/block/raw.c index 8c81de9..f1682d4 100644 --- a/block/raw.c +++ b/block/raw.c @@ -121,6 +121,11 @@ static int raw_has_zero_init(BlockDriverState *bs) return bdrv_has_zero_in

[Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-15 Thread Peter Lieven
if a destination has has_zero_init = 0, but it supports discard zeroes use discard to convert the target into an all zero device. Signed-off-by: Peter Lieven --- qemu-img.c | 56 +++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH 2/4] iscsi: add .bdrv_get_info

2013-07-15 Thread Peter Lieven
this is used to reveal max_unmap and discard_zeroes capabilities. Signed-off-by: Peter Lieven --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 2b8fab9..74a35b9 100644 --- a/block/iscsi.c +++ b/block/i

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 08/07/2013 11:21, Fam Zheng ha scritto: > > Should the source be "bs" for MIRROR_SYNC_MODE_NONE? Also in this case > > you may want to default the format to "qcow2" instead of bs's format. > > Maybe not. "source" only affects when sync=top below here. For reading > the uncopied for target from

Re: [Qemu-devel] [PATCH V2 0/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 06/07/2013 03:38, Ian Main ha scritto: >> > This patch adds sync modes on top of the work that Stefan Hajnoczi has >> > done. >> > >> > These patches apply on kevin/block with >> > '[PATCH] block: add drive_backup HMP command' also applied. >> > >> > Hopefully all is in order as this is my f

[Qemu-devel] Performance regression "ioport: Switch dispatching to memory core layer"

2013-07-15 Thread Stefan Hajnoczi
The following qemu.git commit adds a ~2 minute regression in boot time to a x86_64 live CD: commit b40acf99bef69fa8ab0f9092ff162fde945eec12 Author: Jan Kiszka Date: Mon Jun 24 10:45:09 2013 +0200 ioport: Switch dispatching to memory core layer After the ISOLINUX menu, the display

[Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-15 Thread Peter Lieven
this patch adds an efficient encoding for zero blocks by adding a new flag indiciating a block is completly zero. additionally bdrv_write_zeros() is used at the destination to efficiently write these zeroes. v2->v3: - changed type of flags in blk_send() from int to uint64_t - added migration ca

Re: [Qemu-devel] Performance regression "ioport: Switch dispatching to memory core layer"

2013-07-15 Thread Jan Kiszka
On 2013-07-15 12:52, Stefan Hajnoczi wrote: > The following qemu.git commit adds a ~2 minute regression in boot time > to a x86_64 live CD: > > commit b40acf99bef69fa8ab0f9092ff162fde945eec12 > Author: Jan Kiszka > Date: Mon Jun 24 10:45:09 2013 +0200 > > ioport: Switch dispatching

[Qemu-devel] [PULL 1/8] blockdev: add sync mode to drive-backup QMP command

2013-07-15 Thread Kevin Wolf
From: Stefan Hajnoczi The drive-backup command is similar to the drive-mirror command, except no guest data written after the command executes gets copied. Add a sync mode argument which determines whether the entire disk is copied, just allocated clusters, or only clusters being written to by t

[Qemu-devel] [PULL 0/8] Block patches

2013-07-15 Thread Kevin Wolf
The following changes since commit c3cb8e77804313e1be99b5f28a34a346736707a5: ioport: remove LITTLE_ENDIAN mark for portio (2013-07-12 14:37:47 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to a62eaa26c1d6d48fbdc3ac1d32

[Qemu-devel] [PULL 2/8] block: add drive_backup HMP command

2013-07-15 Thread Kevin Wolf
From: Stefan Hajnoczi Make "drive_backup" available on the HMP monitor: drive_backup [-n] [-f] device target [format] The -n flag requests QEMU to reuse the image found in new-image-file, instead of recreating it from scratch. The -f flag requests QEMU to copy the whole disk, so that the res

[Qemu-devel] [PULL 4/8] qemu-iotests: Update 051 reference output

2013-07-15 Thread Kevin Wolf
This has been broken by commit bd5c51ee. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051.out | 107 +++ tests/qemu-iotests/common.filter | 2 +- 2 files changed, 76 insertions(+), 33 deletions(-) diff --git a/tests/qemu-iotests/051.out b/tests/qe

[Qemu-devel] [PULL 5/8] block: Add return value for bdrv_flush_all()

2013-07-15 Thread Kevin Wolf
bdrv_flush() can fail, and bdrv_flush_all() should return an error as well if this happens for a block device. It returns the first error return now, but still at least tries to flush the remaining devices even in error cases. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block.c

[Qemu-devel] [PULL 8/8] ahci: Fix FLUSH command

2013-07-15 Thread Kevin Wolf
AHCI couldn't cope with asynchronous commands that aren't doing DMA, it simply wouldn't complete them. Due to the bug fixed in commit f68ec837, FLUSH commands would seem to have completed immediately even if they were still running on the host. After the commit, they would simply hang and never uns

[Qemu-devel] [PULL 3/8] block: Don't parse protocol from file.filename

2013-07-15 Thread Kevin Wolf
One of the major reasons for doing something new for -blockdev and blockdev-add was that the old block layer code parses filenames instead of just taking them literally. So we should really leave it untouched when it's passing using the new interfaces (like -drive file.filename=...). This allows o

[Qemu-devel] [PULL 6/8] cpus: Add return value for vm_stop()

2013-07-15 Thread Kevin Wolf
If flushing the block devices fails, return an error. The VM is stopped anyway. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- cpus.c | 20 +--- include/sysemu/sysemu.h | 4 ++-- stubs/vm-stop.c | 2 +- 3 files changed, 16 insertions(+), 10

[Qemu-devel] [PULL 7/8] migration: Fail migration on bdrv_flush_all() error

2013-07-15 Thread Kevin Wolf
If bdrv_flush_all() returns an error, there is an inconsistency in the view of an image file between the source and the destination host. Completing the migration would lead to corruption. Better abort migration in this case. To reproduce this case, try the following (ensures that there is somethi

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-15 Thread Wanlong Gao
On 07/09/2013 02:25 AM, Luiz Capitulino wrote: >> + >> > +# @set-mpol: >> > +# >> > +# Set the host memory binding policy for guest NUMA node. >> > +# >> > +# @nodeid: The node ID of guest NUMA node to set memory policy to. >> > +# >> > +# @mem-policy: The memory policy string to set. > Shouldn't t

Re: [Qemu-devel] [PATCH 1/2] object: introduce Qref to abstract the refcnt interface

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 04:49, Liu Ping Fan ha scritto: > Qref is similar to kref. It hides the refcnt detail and provides > a common interface. And this patch is based on the idiom of refcnt, > and adopts some optimization about memory model, which finally > falls back on gcc implementation. > > Signed-off

Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round

2013-07-15 Thread Petar Jovanovic
ping From: Petar Jovanovic Sent: Monday, July 08, 2013 11:14 AM To: Richard Henderson; Petar Jovanovic Cc: qemu-devel@nongnu.org; aurel...@aurel32.net Subject: RE: [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round ping http://patchwork.ozlabs.org/patc

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

2013-07-15 Thread Petar Jovanovic
ping From: Petar Jovanovic Sent: Monday, July 08, 2013 11:20 AM To: Richard Henderson Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 ping htt

Re: [Qemu-devel] [edk2] OVMF and qemu 1.5.2 (git trunk)

2013-07-15 Thread Laszlo Ersek
On 07/15/13 12:23, Oleksii Shevchuk wrote: > I managed to run it from edk2: > qemu-system-x86_64 -L /opt/edk2/Build/OvmfX64/DEBUG_GCC46/QEMU -hda > fat:/opt/edk2/Build/OvmfX64/DEBUG_GCC46/X64 > > But with enabled kvm it doesn't work and boots vry slow. > > It successfully runned with KV

[Qemu-devel] QEMU option -d in_asm on i386

2013-07-15 Thread Anderson Sartor
Regarding the QEMU code present in the Android source (I tested on QEMU 1.1.2 as well and got the same results), I am able to get in_asm, out_asm, etc data with ARM and MIPS architectures. However on i386 nothing is saved to the log using any of the "-d" options. Why is i386 different? How can I ge

Re: [Qemu-devel] Morph cpu_reset -> device_reset

2013-07-15 Thread Andreas Färber
Am 15.07.2013 12:45, schrieb Peter Crosthwaite: > Hi Andreas, > > On Mon, Jul 15, 2013 at 7:55 PM, Andreas Färber wrote: >> Hi Peter, >> >> Am 15.07.2013 06:02, schrieb Peter Crosthwaite: >>> A while ago, TYPE_CPU was refactored to by a child of TYPE_DEVICE. As >>> something of a hangover though,

Re: [Qemu-devel] [PATCH 0/3] qemu-timer: make QEMUTimer functions thread-safe

2013-07-15 Thread Paolo Bonzini
Il 05/07/2013 19:51, Jan Kiszka ha scritto: > On 2013-07-05 14:39, Stefan Hajnoczi wrote: >> This series makes the following functions thread-safe: >> >> qemu_mod_timer_ns() >> qemu_mod_timer() >> qemu_del_timer() >> qemu_timer_pending() >> >> The following were already thread-safe: >> >>

Re: [Qemu-devel] guest xp vm can not recognize vcpu

2013-07-15 Thread Oliver Francke
Hi, from the topology-line I would assume, you should switch sockets=1 and cores=2, multiple sockets would mean multiple processors vs. one processor with multiple cores. Hope it helps, Oliver. On 07/11/2013 02:49 AM, yue-kvm wrote: hi, all in guest xp vm , device management shows a help s

Re: [Qemu-devel] [PATCH 0/3] qemu-timer: make QEMUTimer functions thread-safe

2013-07-15 Thread Jan Kiszka
On 2013-07-15 14:45, Paolo Bonzini wrote: > Il 05/07/2013 19:51, Jan Kiszka ha scritto: >> On 2013-07-05 14:39, Stefan Hajnoczi wrote: >>> This series makes the following functions thread-safe: >>> >>> qemu_mod_timer_ns() >>> qemu_mod_timer() >>> qemu_del_timer() >>> qemu_timer_pending() >>

Re: [Qemu-devel] QEMU option -d in_asm on i386

2013-07-15 Thread Peter Maydell
On 15 July 2013 13:21, Anderson Sartor wrote: > Regarding the QEMU code present in the Android source (I tested on QEMU > 1.1.2 as well and got the same results), I am able to get in_asm, out_asm, > etc data with ARM and MIPS architectures. However on i386 nothing is saved > to the log using any o

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-15 Thread Paolo Bonzini
Il 09/07/2013 05:37, Alexey Kardashevskiy ha scritto: > > btw xics-kvm does not introduce new members but does have very different > .pre_save and .post_load. This actually was the whole point of splitting > xics into xics and xics-kvm. I cannot see how I can fix it without hacks. > Property's can

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-15 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 09/07/2013 09:17, David Gibson ha scritto: > So, Alexey addressed the xics vs. xics-kvm issues. But there's > another factor here. It's not clear to me how you'd QOM this > component. > > What's being registered here is the "presentation server

Re: [Qemu-devel] [PATCH 09/17] pseries: rework PAPR virtual SCSI

2013-07-15 Thread Paolo Bonzini
Il 08/07/2013 20:42, Anthony Liguori ha scritto: >> > +static int vscsi_fetch_desc(VSCSIState *s, struct vscsi_req *req, >> > +unsigned n, unsigned buf_offset, >> > +struct srp_direct_buf *ret) >> > +{ >> > +struct srp_cmd *cmd = &req->iu.

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-15 Thread Alexey Kardashevskiy
On 07/15/2013 11:05 PM, Paolo Bonzini wrote: > Il 09/07/2013 05:37, Alexey Kardashevskiy ha scritto: >> >> btw xics-kvm does not introduce new members but does have very different >> .pre_save and .post_load. This actually was the whole point of splitting >> xics into xics and xics-kvm. I cannot se

Re: [Qemu-devel] QEMU option -d in_asm on i386

2013-07-15 Thread Anderson Sartor
Thank you for your answer. It was, as you guessed, the KVM acceleration, explicity calling "-disable-kvm" did the trick and everything is working now. Thanks again 2013/7/15 Peter Maydell > On 15 July 2013 13:21, Anderson Sartor wrote: > > Regarding the QEMU code present in the Android source

[Qemu-devel] [PATCH] linux-user: declare sys_futex to have 6 arguments

2013-07-15 Thread Petar Jovanovic
From: Petar Jovanovic sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect declaration in the mips_syscall_args array. This change fixes the cases where the 5th and 6th arguments have non-zero value and have importance. An example is a Linux implementation of pthread_cond

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 15:13, Alexey Kardashevskiy ha scritto: >> > >> > The vmstate's pre_save and post_load functions can dispatch to a method >> > in the subclass. Again, i8259 does exactly what you want: >> > >> > static void pic_dispatch_pre_save(void *opaque) >> > { >> > PICCommonState *s = opa

Re: [Qemu-devel] [PATCH v2 repost 6/9] loader: support for unmapped ROM blobs

2013-07-15 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > @@ -697,7 +703,12 @@ static void rom_reset(void *unused) > if (rom->data == NULL) { > continue; > } > -cpu_physical_memory_write_rom(rom->addr, rom->data, rom->datasize); > +if (rom->mr) { > +

Re: [Qemu-devel] [PATCH arm-devs v2 1/2] hw/timer: Introduce ARM A9 Global Timer.

2013-07-15 Thread Peter Maydell
On 15 July 2013 06:19, wrote: > From: Peter Crosthwaite > > The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore. > The timer is shared but each CPU has a private independent comparator > and interrupt. > > Based on version contributed by Francois LEGAL. > > Signed-off-by: Fran

Re: [Qemu-devel] [PATCH arm-devs v2 2/2] cpu/a9mpcore: Add Global Timer

2013-07-15 Thread Peter Maydell
On 15 July 2013 06:19, wrote: > From: François LEGAL > > Add the global timer to A9 MPCore. > > Signed-off-by: François LEGAL > [PC Changes: > * new commit message > * split off original version as a separate patch > ] > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell assuming

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-15 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 09/07/2013 17:11, David Gibson ha scritto: > Under TCG, the guest timebase is not tracked as it advances, but > an appropriate value is computed from the host system time when > the timebase is read. Under TCG, the timebase uses vm_clock so it is m

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-15 Thread Paolo Bonzini
Il 08/07/2013 20:39, Anthony Liguori ha scritto: > Alexey Kardashevskiy writes: > >> From: David Gibson >> >> This patch adds the necessary VMStateDescription information to save the >> state of PAPR TCE tables (that is, the PAPR specified IOMMU). >> >> Signed-off-by: David Gibson >> Signed-off

Re: [Qemu-devel] [PATCH] linux-user: declare sys_futex to have 6 arguments

2013-07-15 Thread Peter Maydell
On 15 July 2013 14:17, Petar Jovanovic wrote: > From: Petar Jovanovic > > sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect > declaration in the mips_syscall_args array. > > This change fixes the cases where the 5th and 6th arguments have non-zero > value and have impor

[Qemu-devel] support using KVM_MEM_READONLY flag for regions commit and OVMF UEFI incompatibility

2013-07-15 Thread Oleksii Shevchuk
I tried do run QEMU with OVMF UEFI bios (QEMU and EDK2 trunk). It hangs while booting: qemu-kvm -L . -bios OVMF.fd --enable-kvm -debugcon file:/tmp/debug -global isa-debugcon.iobase=0x402 -global PIIX4_PM.disable_s3=0 -global PIIX4_PM.disable_s4=0 SecCoreStartupWithStack(0xFFFE6000, 0x8) F

Re: [Qemu-devel] [PATCH 0/3] qemu-timer: make QEMUTimer functions thread-safe

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 14:57, Jan Kiszka ha scritto: > On 2013-07-15 14:45, Paolo Bonzini wrote: >> Il 05/07/2013 19:51, Jan Kiszka ha scritto: >>> On 2013-07-05 14:39, Stefan Hajnoczi wrote: This series makes the following functions thread-safe: qemu_mod_timer_ns() qemu_mod_timer()

[Qemu-devel] [PATCH RFC 0/3] Recursive QOM realize

2013-07-15 Thread Andreas Färber
Hello, To honor the Soft Freeze, here is an early throw at recursive realization based on earlier patches from Paolo. Originally Paolo and me had implemented QOM realize at Object level. Paolo's goal was to set realized = true on /machine and it propagating from there on. This series now implemen

[Qemu-devel] [PATCH RFC 3/3] qdev: Assert no new devices get created during realization

2013-07-15 Thread Andreas Färber
This is safe because current devices are already realized at this point and busses are not devices. Signed-off-by: Andreas Färber --- hw/core/qdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index ec621cd..e86e72d 100644 --- a/hw/core/qdev.c +++ b/h

[Qemu-devel] [PATCH RFC 2/3] qdev: Realize on machine creation done

2013-07-15 Thread Andreas Färber
As a preparation for Anthony's targetted late realization of devices, iterate /machine children in qdev_machine_creation_done() and set realized = true for devices. Suggested-by: Anthony Liguori Signed-off-by: Andreas Färber --- hw/core/qdev.c | 29 + 1 file changed,

[Qemu-devel] [PATCH RFC 1/3] qdev: Add support for recursive realization

2013-07-15 Thread Andreas Färber
Add realize_children and unrealize_children QOM methods to DeviceClass. Call them after realized = true and before realized = false respectively. The default implementation walks busses and realizes their devices. Signed-off-by: Paolo Bonzini [AF: Transferred from Object to DeviceState] Signed-o

Re: [Qemu-devel] [PATCH] exec.c: Pass correct pointer type to qemu_ram_ptr_length

2013-07-15 Thread Paolo Bonzini
Il 08/07/2013 10:44, Peter Maydell ha scritto: > Commit e3127ae0 introduced a problem where we're passing a > hwaddr* to qemu_ram_ptr_length() but it wants a ram_addr_t*; > this will cause problems on 32 bit hosts and in any case > provokes a clang warning on MacOSX: > > CCarm-softmmu/exec.o

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-15 Thread Anthony Liguori
Peter Maydell writes: > On 12 July 2013 23:50, Benjamin Herrenschmidt > wrote: >> Our experience is that it actually works fine for almost everything >> except virtio :-) ie mostly TARGET_WORDS_BIGENDIAN is irrelevant (and >> should be). > > I agree that TARGET_WORDS_BIGENDIAN *should* go away,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-15 Thread Peter Maydell
On 15 July 2013 15:01, Anthony Liguori wrote: > Peter Maydell writes: >> On 12 July 2013 23:50, Benjamin Herrenschmidt >> wrote: >> I agree that TARGET_WORDS_BIGENDIAN *should* go away, but >> it exists currently. Do you actually implement a CPU which >> does dynamic endianness flipping? > > TC

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-15 Thread Benjamin Herrenschmidt
On Mon, 2013-07-15 at 09:01 -0500, Anthony Liguori wrote: > On PPC, le_mode only really affects load/stores and instruction > decoding. Any shared data structures between the CPU and OS remain big > endian. Translation: On ppc with the specific machine type "pseries" which emulates a paravirtual

Re: [Qemu-devel] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-15 Thread Fabien Chouteau
On 07/15/2013 04:00 AM, Peter Crosthwaite wrote: > Hi Fabien, > Hi Peter, > On Thu, Jul 11, 2013 at 3:10 AM, Fabien Chouteau wrote: >> +#ifdef DEBUG_REGISTER >> +printf("Write 0x%08x @ 0x" TARGET_FMT_plx" val:0x%08x->0x%08x : %s >> (%s)\n", >> + (unsigned int)value, addr, before,

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-15 Thread Paolo Bonzini
Il 06/07/2013 18:24, Alex Bligh ha scritto: > Add timed bottom halves. A timed bottom half is a bottom half that > will not execute until a given time has passed (qemu_bh_schedule_at) > or a given interval has passed (qemu_bh_schedule_in). ... and may be delayed arbitrarily past that given interva

Re: [Qemu-devel] Performance regression "ioport: Switch dispatching to memory core layer"

2013-07-15 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 7:01 PM, Jan Kiszka wrote: > On 2013-07-15 12:52, Stefan Hajnoczi wrote: >> The following qemu.git commit adds a ~2 minute regression in boot time >> to a x86_64 live CD: >> >> commit b40acf99bef69fa8ab0f9092ff162fde945eec12 >> Author: Jan Kiszka >> Date: Mon Jun 2

  1   2   3   4   >