On 07/09/2013 02:25 AM, Luiz Capitulino wrote: >> + >> > +# @set-mpol: >> > +# >> > +# Set the host memory binding policy for guest NUMA node. >> > +# >> > +# @nodeid: The node ID of guest NUMA node to set memory policy to. >> > +# >> > +# @mem-policy: The memory policy string to set. > Shouldn't this be an enum? Also, optional members have a leading '#optional' > string and if a default value is used it should be documented.
Thank you, will fix in V5. > >> > +# >> > +# @mem-hostnode: The host node or node range for memory policy. > It doesn't seem appropriate to use a string here. Maybe we could > use a list with only to values (like [0,2] for 0-2) or maybe a > list of nodes if that makes sense (like [0,1,2]). I wonder if not using string, how to support "+" and "!" ? Thanks, Wanlong Gao
