Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-26 Thread jcd
For my own education, could you elaborate on the reason this is not a good change? Thanks. JC - Mail original - > Il 25/06/2013 22:53, Peter Maydell ha scritto: > > On 25 June 2013 19:42, Paolo Bonzini wrote: > >> Il 25/06/2013 20:21, Peter Maydell ha scritto: > >>> @@ -416,7 +513,

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 09:08, j...@tribudubois.net ha scritto: > For my own education, could you elaborate on the reason this is not a > good change? Quoting from http://article.gmane.org/gmane.comp.emulators.qemu/218078: > The MemoryRegion name is free text that can be changed as desired and > doesn't ne

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Eric Blake writes: > On 05/23/2013 03:08 AM, Amos Kong wrote: >> We want to implement mac programming over macvtap through Libvirt, >> related rx-filter configuration contains main mac, some of rx-mode >> and mac-table. >> >> The previous patch adds QMP event to notify management of rx-filter >>

Re: [Qemu-devel] [RFC PATCH 2/3] block: assign backing relationship in drive-backup

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 05:59, Fam Zheng ha scritto: > Assign source image as the backing hd of target bs, so reading target bs > gets the point-in-time copy of data from source image. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/blockdev.c

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-26 Thread jcd
Thanks for the info. Is this consolidated into some "developper documentation" somewhere (a wiki, ...)? JC - Mail original - > Il 26/06/2013 09:08, j...@tribudubois.net ha scritto: > > For my own education, could you elaborate on the reason this is not a > > good change? > Quoting

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-26 Thread Peter Crosthwaite
Hi On Wed, Jun 26, 2013 at 4:56 PM, Paolo Bonzini wrote: > Il 25/06/2013 22:53, Peter Maydell ha scritto: >> On 25 June 2013 19:42, Paolo Bonzini wrote: >>> Il 25/06/2013 20:21, Peter Maydell ha scritto: @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev) sysbus

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 05:59, Fam Zheng ha scritto: > > The block job originally had total control over target bs: when the job > completes, the target is deleted. Now it's shared with NBD, so we should make > sure the job completion or canceling wouldn't crash NBD server. This patch > doesn't handle this

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-26 Thread Fam Zheng
On Wed, 06/26 09:23, Paolo Bonzini wrote: > Il 26/06/2013 05:59, Fam Zheng ha scritto: > > > > The block job originally had total control over target bs: when the job > > completes, the target is deleted. Now it's shared with NBD, so we should > > make > > sure the job completion or canceling wou

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-26 Thread Kevin Wolf
Am 26.06.2013 um 08:46 hat Bharata B Rao geschrieben: > On Wed, Jun 26, 2013 at 07:59:27AM +0200, Peter Lieven wrote: > > > > Am 26.06.2013 um 05:14 schrieb Bharata B Rao : > > > > > On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > > >> > > >> Can you please review for the gluster,

Re: [Qemu-devel] [PATCH] block/ssh: Set bdrv_has_zero_init according to the file type.

2013-06-26 Thread Kevin Wolf
Am 25.06.2013 um 19:15 hat Richard W.M. Jones geschrieben: > From: "Richard W.M. Jones" > > If the remote is a regular file, set it to true (ie. reads of > uninitialized areas in a newly created file will return zeroes). > If we can't prove that, return false (a safe default). > > Tested by addi

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-26 Thread Stefan Hajnoczi
On Tue, Jun 25, 2013 at 04:36:53PM +0200, Paolo Bonzini wrote: > Il 25/06/2013 16:06, Kevin Wolf ha scritto: > > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > > +if (!full) { > > +error_setg(&errp, "-f is not yet impleme

[Qemu-devel] [PATCH] gluster: Return bdrv_has_zero_init = 0

2013-06-26 Thread Kevin Wolf
GlusterFS volumes can be backed by block devices, in which case bdrv_create() doesn't make sure that the image is zeroed out. It is currently not possibly to detect whether a given image is backed by a file or a block device, and incorrectly assuming that it is zeroed corrupts images during qemu-im

[Qemu-devel] Google Summer of Code 2013 has started

2013-06-26 Thread Stefan Hajnoczi
It is a pleasure to welcome the following GSoC 2013 students to the QEMU, KVM, and libvirt communities: Libvirt Wireshark Dissector - Yuto KAWAMURA (kawamuray) http://qemu-project.org/Features/LibvirtWiresharkDissector Libvirt Introduce API to query IP addresses for given domain - Nehal J. Wani (

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-26 Thread Paolo Bonzini
Il 24/06/2013 19:58, Stefan Weil ha scritto: >>> hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void >>> function [-Wreturn-type] >>> hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void >>> function [-Wreturn-type] >> I think you could report this to mingw. GCC shou

Re: [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings

2013-06-26 Thread Paolo Bonzini
Il 24/06/2013 19:48, Stefan Weil ha scritto: > Hi Alex, > > this mini series fixes the remaining compiler warnings in > my w32/w64 cross build environment on Debian wheezy. > > [PATCH 1/3] spapr: Use named enum for function remove_hpte > [PATCH 2/3] spapr: Fix compiler warning for some versions o

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-26 Thread liu ping fan
On Wed, Jun 26, 2013 at 2:34 PM, Paolo Bonzini wrote: > Il 26/06/2013 04:59, liu ping fan ha scritto: >>> The latter part could be the hard one in a multi-threaded context, but I >>> think it's up to the device to ensure it. It doesn't _have_ to be hard. >>> For example, joining the data-plane t

Re: [Qemu-devel] [PATCH 10/15] target-i386: convert 'hv_spinlocks' to static property

2013-06-26 Thread Igor Mammedov
On Tue, 25 Jun 2013 17:34:44 -0300 Eduardo Habkost wrote: > On Tue, Jun 25, 2013 at 05:30:50PM -0300, Eduardo Habkost wrote: > > On Wed, Jun 05, 2013 at 03:18:41PM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > [...] > > > @@ -1632,6 +1677,7 @@ static void cpu_x86_p

Re: [Qemu-devel] [PATCH 08/15] target-i386: cpu: convert 'tsc-frequency' to static property

2013-06-26 Thread Igor Mammedov
On Mon, 24 Jun 2013 14:09:43 -0300 Eduardo Habkost wrote: > On Wed, Jun 05, 2013 at 03:18:39PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target-i386/cpu.c | 12 +--- > > 1 files changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/target-i386/c

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 10:20, liu ping fan ha scritto: >>> On the other hand, pushing _delete() out of finalization path is not >>> easy, since we do not what time the DeviceState has done with its bh. >> >> See above: >> >> - if the BH will run in the iothread, the BH is definitely not running >> (because

Re: [Qemu-devel] [PATCH] target-arm: Added CP15 VBAR support

2013-06-26 Thread Peter Maydell
On 26 June 2013 02:57, Peter Crosthwaite wrote: > On Wed, Feb 27, 2013 at 8:10 PM, Peter Maydell > wrote: >> This one's tricky because the VBAR only exists in CPUs with >> TrustZone, and strictly speaking QEMU models a non-TrustZone >> core. However we already have some dummy cp15 registers whic

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Peter Maydell
On 26 June 2013 00:38, David Gibson wrote: > On Mon, Jun 24, 2013 at 12:02:39PM +0100, Peter Maydell wrote: >> On 24 June 2013 11:56, Alexander Graf wrote: >> > This looks pretty complicated for something actually quite >> > simple: All you want is to pass in a number of 64bit values, >> > rather

[Qemu-devel] Libvirt : Bootstrap fails for local gnulib

2013-06-26 Thread chandrashekar shastri
Hi All, The Libvirt compliation fails to bootstarp for local gnulib. We do not have outbound access for the test machines. So, we ll pull the gnulib from and copy to the test machines. When we run ./bootstrap --no-git --gnulib-srcdir=/path/to/local, below is the error: ./bootstrap: Bootstr

[Qemu-devel] [PATCH v5 06/14] acpi_piix4 : Implement memory device hotplug registers

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis A 32-byte register is used to present up to 256 hotplug-able memory devices to BIOS and OSPM. Hot-add and hot-remove functions trigger an ACPI hotplug event through these. Only reads are allowed from these registers. An ACPI hot-remove event but needs to wait for OSPM t

[Qemu-devel] [PATCH v5 00/14] ACPI memory hotplug

2013-06-26 Thread Hu Tao
It's been quite a while since v4 and lots of changes happend in qemu and v4 just can't apply anymore. So this series is basically a rebase. Another purpose is to bring up discussions to make consensus on some questions since v4, see http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01219.html

[Qemu-devel] [PATCH v5 01/14] qapi: make visit_type_size fallback to v->type_int()

2013-06-26 Thread Hu Tao
In case of v->type_uint64 is NULL, fallback to v->type_int, by calling visit_type_uint64(). Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- qapi/qapi-visit-core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.

[Qemu-devel] [PATCH v5 10/14] pc: Add dimm paravirt SRAT info

2013-06-26 Thread Hu Tao
The numa_fw_cfg paravirt interface is extended to include SRAT information for all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, denoting start address, size and node proximity. The new info is appended after existing numa info, so that the fw_cfg layout does not break.

[Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- vl.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/vl.c b/vl.c index 767e020..9d88a79 100644 --- a/vl.c +++ b/vl.c @@ -170,6 +170,7 @@ int main(int

[Qemu-devel] [PATCH v5 3/7] acpi-dsdt: Implement functions for memory hotplug

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. Signed-off-by: Vasilis Liaskovitis --- src/acpi-dsdt-mem-hotplug.dsl | 57 +++

[Qemu-devel] [PATCH v5 02/14] Add SIZE type to qdev properties

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis This patch adds a 'SIZE' type property to qdev. It will make dimm description more convenient by allowing sizes to be specified with K,M,G,T prefixes instead of number of bytes e.g.: -device dimm,id=mem0,size=2G,bus=membus.0 Credits go to Ian Molton for original patch.

[Qemu-devel] [PATCH v5 09/14] memory controller: initialize dram controller.

2013-06-26 Thread Hu Tao
Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- hw/i386/pc.c | 27 +++ include/hw/i386/pc.h | 5 + 2 files changed, 32 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 55056b1..65838a6 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@

[Qemu-devel] [PATCH v5 03/14] qemu-option: export parse_option_number

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- include/qemu/option.h | 2 ++ util/qemu-option.c| 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/qemu/option.h b/include/qemu/option.h index 83c1e84..d7a0bb9 100644 --- a/

[Qemu-devel] [PATCH v5 13/14] balloon: update with hotplugged memory

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis query-balloon and "info balloon" should report total memory available to the guest. balloon inflate/ deflate can also use all memory available to the guest (initial + hotplugged memory) Ballon driver has been minimaly tested with the patch, please review and test. Cav

[Qemu-devel] [PATCH v5 7/7] pci: Use paravirt interface for pcimem_start and pcimem64_start

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based on initial memory and hotplug-able dimms. It's possible to avoid the new paravirt interface, and cal

[Qemu-devel] [PATCH v5 04/14] Implement dimm device abstraction

2013-06-26 Thread Hu Tao
Each hotplug-able memory slot is a DimmDevice. All DimmDevices are attached to a new bus called DimmBus. This bus is introduced so that we no longer depend on hotplug-capability of main system bus (the main bus does not allow hotplugging). The DimmBus should be attached to a chipset Device (i440fx

[Qemu-devel] [PATCH v5 11/14] Introduce paravirt interface QEMU_CFG_PCI_WINDOW

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Qemu calculates the 32-bit and 64-bit PCI starting offsets based on initial memory and hotplug-able dimms. This info needs to be passed to Seabios for PCI initialization. Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- hw/i386/pc_q35.c | 10

[Qemu-devel] [PATCH v5 14/14] Implement dimm-info

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis "query-dimm-info" and "info dimm" will give current state of all dimms in the system e.g. dimm0: on dimm1: off dimm2: off dimm3: on etc. Signed-off-by: Vasilis Liaskovitis Signed-off-by: Hu Tao --- hmp-commands.hx | 2 ++ hmp.c | 17 ++

[Qemu-devel] [PATCH v5 07/14] acpi_ich9 : Implement memory device hotplug registers

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis This implements acpi dimm hot-add capability for q35 (ich9). The logic is the same as for the pc machine (piix4). TODO: Fix acpi irq delivery bug. Currently there is a flood of irqs when delivering an acpi interrupt (should be just one). Guest complains as follows: "irq

[Qemu-devel] [PATCH v5 12/14] Implement "info memory" and "query-memory"

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Returns total physical memory available to guest in bytes, including hotplugged memory. Note that the number reported here may be different from what the guest sees e.g. if the guest has not logically onlined hotplugged memory. This functionality is provided independent

[Qemu-devel] [PATCH v5 5/7] acpi: generate hotplug memory devices

2013-06-26 Thread Hu Tao
The memory device generation is guided by qemu paravirt info. Seabios uses the info to setup SRAT entries for the hotplug-able memory slots, and to generate appropriate memory device objects. One memory device (and corresponding SRAT entry) is generated for each hotplug-able qemu memslot. Currently

[Qemu-devel] [PATCH v5 0/7] support for ACPI memory hotplug

2013-06-26 Thread Hu Tao
This series adds memory devices and related methods to support ACPI memory hotplug. This series works with qemu counterpart. See qemu series for a detailed description. Hu Tao (2): set psize to 0 when romfile_loadfile failed acpi: generate hotplug memory devices Vasilis Liaskovitis (5): Ad

[Qemu-devel] [PATCH v5 2/7] Add SSDT memory device support

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Define SSDT hotplug-able memory devices in _SB namespace. The dynamically generated SSDT includes per memory device hotplug methods. These methods just call methods defined in the DSDT. Also dynamically generate a MTFY method and a MEON array of the online/available memo

[Qemu-devel] [PATCH v5 08/14] memory: record below_4g_mem_size, above_4g_mem_size

2013-06-26 Thread Hu Tao
Signed-off-by: Hu Tao --- hw/i386/pc.c | 17 - include/hw/i386/pc.h | 2 ++ 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5bb4989..55056b1 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1288,7 +1288,6 @@ static int mem

[Qemu-devel] [PATCH v5 4/7] set psize to 0 when romfile_loadfile failed

2013-06-26 Thread Hu Tao
Signed-off-by: Hu Tao --- src/romfile.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/romfile.c b/src/romfile.c index ea71d1f..b1b89bb 100644 --- a/src/romfile.c +++ b/src/romfile.c @@ -51,28 +51,33 @@ romfile_loadfile(const char *name, int *psize) {

[Qemu-devel] [PATCH v5 1/7] Add ACPI_EXTRACT_DEVICE* macros

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis This allows to extract the beginning, end and name of a Device object. Signed-off-by: Vasilis Liaskovitis --- tools/acpi_extract.py | 28 1 file changed, 28 insertions(+) diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py index ab

[Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path

2013-06-26 Thread Fam Zheng
When creating image with backing file, the driver tries to calculate the relative path from created image file to backing file, but the path computation is incorrect. e.g.: $ qemu-img create -f vmdk -b vmdk-data-disk.vmdk vmdk-data-snapshot1 Formatting 'vmdk-data-snapshot1', fmt=vmdk size=

[Qemu-devel] [PATCH v5 6/7] q35: Add memory hotplug handler

2013-06-26 Thread Hu Tao
From: Vasilis Liaskovitis Signed-off-by: Vasilis Liaskovitis --- src/q35-acpi-dsdt.dsl | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl index c031d83..5b28d72 100644 --- a/src/q35-acpi-dsdt.dsl +++ b/src/q35-acpi-dsdt.dsl @@

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Eric Blake writes: > On 05/24/2013 07:08 AM, Luiz Capitulino wrote: >> This sounds like premature optimization to me, but I wonder if instead >> of cluttering commands with arguments to do the filtering we could add >> some standard way of doing this in the QAPI. > > Maybe we could make QAPI supp

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-26 Thread liu ping fan
On Wed, Jun 26, 2013 at 4:38 PM, Paolo Bonzini wrote: > Il 26/06/2013 10:20, liu ping fan ha scritto: On the other hand, pushing _delete() out of finalization path is not easy, since we do not what time the DeviceState has done with its bh. >>> >>> See above: >>> >>> - if the BH will ru

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 11:13, Hu Tao ha scritto: > From: Vasilis Liaskovitis > > Signed-off-by: Vasilis Liaskovitis > Signed-off-by: Hu Tao > --- > vl.c | 51 +++ > 1 file changed, 51 insertions(+) > > diff --git a/vl.c b/vl.c > index 767e020..9d88a79 10

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

2013-06-26 Thread liu ping fan
On Tue, Jun 25, 2013 at 5:40 PM, Kevin Wolf wrote: > Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben: >> BH will be used outside big lock, so introduce lock to protect >> between the writers, ie, bh's adders and deleter. The lock only >> affects the writers and bh's callback does not take this

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Amos Kong writes: > We want to implement mac programming over macvtap through Libvirt, > related rx-filter configuration contains main mac, some of rx-mode > and mac-table. > > The previous patch adds QMP event to notify management of rx-filter > change. This patch adds a monitor command to query

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 11:44, liu ping fan ha scritto: > On Wed, Jun 26, 2013 at 4:38 PM, Paolo Bonzini wrote: >> Il 26/06/2013 10:20, liu ping fan ha scritto: > On the other hand, pushing _delete() out of finalization path is not > easy, since we do not what time the DeviceState has done with its

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-06-26 Thread Markus Armbruster
Amos Kong writes: > netclient 'name' entry in event is useful for management to know > which device is changed. n->netclient_name is not always set. > This patch changes to use nc->name. If we don't assign 'id', > qemu will set a generated name to nc->name. > > Signed-off-by: Amos Kong > --- >

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-06-26 Thread Markus Armbruster
Amos Kong writes: > On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: >> netclient 'name' entry in event is useful for management to know >> which device is changed. n->netclient_name is not always set. >> This patch changes to use nc->name. If we don't assign 'id', >> qemu will set a ge

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Alexander Graf
On 26.06.2013, at 10:49, Peter Maydell wrote: > On 26 June 2013 00:38, David Gibson wrote: >> On Mon, Jun 24, 2013 at 12:02:39PM +0100, Peter Maydell wrote: >>> On 24 June 2013 11:56, Alexander Graf wrote: This looks pretty complicated for something actually quite simple: All you want

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Ian Campbell
On Wed, 2013-06-19 at 12:31 +0100, Paul Durrant wrote: > That's correct. If a vendor wishes to ship a new driver for an > existing piece of h/w they just post it. However, at some point the > vendor will sell a new piece of h/w which requires a driver that will > not work with older h/w. So, they

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Ian Campbell
On Thu, 2013-06-20 at 09:56 +0100, Tim Deegan wrote: > At 07:47 + on 20 Jun (1371714432), Paul Durrant wrote: > > > > I agree. If this is really the only solution, we would need to have > > > > both versions presented to the guest so that old drivers continue to > > > > work without any interve

Re: [Qemu-devel] [PATCH v4 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-06-26 Thread Laszlo Ersek
On 06/25/13 17:01, Paolo Bonzini wrote: > Il 25/06/2013 17:01, Laszlo Ersek ha scritto: >> On 06/06/13 17:06, Tomoki Sekiyama wrote: >> >>> +if ! command -v msiextract > /dev/null; then >>> + echo 'msiextract not found. Please install msitools.' >&2 >>> + exit 1 >>> +fi >> >> (This is not a revie

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Peter Maydell
On 26 June 2013 11:31, Alexander Graf wrote: > I think it makes sense to make this API special-purpose for "reg". > We currently have a generic "put any number of 32bit values into the > property" function (qemu_devtree_setprop_cells). Yes, but that doesn't work for things that aren't simple arra

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 26 June 2013 11:40 > To: Tim (Xen.org) > Cc: Paul Durrant; Matt Wilson; Alex Bligh; xen-de...@lists.xen.org; qemu- > de...@nongnu.org > Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Add Xen platform PCI device > version 2. > > On Thu, 2013-

[Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-26 Thread Gerd Hoffmann
This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fb hmp: framebuffer-display on|off There is also a query-framebuffer command for qmp. Signed-off-by: Gerd Hoffmann --- hmp

[Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-26 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Alexander Graf
On 26.06.2013, at 12:50, Peter Maydell wrote: > On 26 June 2013 11:31, Alexander Graf wrote: >> I think it makes sense to make this API special-purpose for "reg". >> We currently have a generic "put any number of 32bit values into the >> property" function (qemu_devtree_setprop_cells). > > Yes,

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Ian Campbell
On Wed, 2013-06-26 at 12:23 +0100, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 26 June 2013 11:40 > > To: Tim (Xen.org) > > Cc: Paul Durrant; Matt Wilson; Alex Bligh; xen-de...@lists.xen.org; qemu- > > de...@nongnu.org > > Subject: Re: [Xen-devel] [Qemu-devel

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 14 Jun 2013 13:46:41 +0800 > Amos Kong wrote: > >> On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: >> > On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: >> > > Amos Kong writes: >> >> >> > > > diff --git a/hw/input/ps2.c b/hw/input/

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Tim Deegan
At 11:23 + on 26 Jun (1372245783), Paul Durrant wrote: > We could blacklist all existing Citrix PV drivers in upstream QEMU, > to avoid the clash, but that seems like a very unfriendly > approach. Also, it's not going to stop someone with an existing VM, > who happens to be using legacy Citrix

[Qemu-devel] [PATCH] mac-io: Add escc-legacy memory alias region

2013-06-26 Thread Alexander Graf
Mac OS X's debugging serial driver accesses the ESCC through a different register layout, called "escc-legacy". This layout differs from the normal escc register layout purely by the location of the respective registers. This patch adds a memory alias region that takes normal escc registers and ma

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Paul Durrant
> -Original Message- > From: Tim Deegan [mailto:t...@xen.org] > Sent: 26 June 2013 12:58 > To: Paul Durrant > Cc: Ian Campbell; Matt Wilson; Alex Bligh; xen-de...@lists.xen.org; qemu- > de...@nongnu.org > Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Add Xen platform PCI device > version 2.

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise.

[Qemu-devel] [PATCH v2 0/2] block: add drive_backup HMP command

2013-06-26 Thread Stefan Hajnoczi
These patches add the sync mode argument to drive-backup (just like drive-mirror) and then introduce the drive_backup HMP command. It's necessary to add the sync mode argument although only the 'full' is supported, since the drive_mirror HMP command defaults to sync mode 'top'. To avoid confusion

[Qemu-devel] [PATCH v2 1/2] blockdev: add sync mode to drive-backup QMP command

2013-06-26 Thread Stefan Hajnoczi
The drive-backup command is similar to the drive-mirror command, except no guest data written after the command executes gets copied. Add a sync mode argument which determines whether the entire disk is copied, just allocated clusters, or only clusters being written to by the guest. Currently onl

[Qemu-devel] [PATCH v2 2/2] block: add drive_backup HMP command

2013-06-26 Thread Stefan Hajnoczi
Make "drive_backup" available on the HMP monitor: drive_backup [-n] [-f] device target [format] The -n flag requests QEMU to reuse the image found in new-image-file, instead of recreating it from scratch. The -f flag requests QEMU to copy the whole disk, so that the result does not need a back

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Tim Deegan
At 12:06 + on 26 Jun (1372248391), Paul Durrant wrote: > > -Original Message- > > From: Tim Deegan [mailto:t...@xen.org] > > Sent: 26 June 2013 12:58 > > To: Paul Durrant > > Cc: Ian Campbell; Matt Wilson; Alex Bligh; xen-de...@lists.xen.org; qemu- > > de...@nongnu.org > > Subject: Re:

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Michael R. Hines
On 06/26/2013 02:37 AM, Paolo Bonzini wrote: Il 26/06/2013 02:31, Michael R. Hines ha scritto: On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was wrong - this does require a protocol extension. This is because the RDMA transfers are asynchrono

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Peter Crosthwaite
Hi, On Wed, Jun 26, 2013 at 8:50 PM, Peter Maydell wrote: > On 26 June 2013 11:31, Alexander Graf wrote: >> I think it makes sense to make this API special-purpose for "reg". >> We currently have a generic "put any number of 32bit values into the >> property" function (qemu_devtree_setprop_cells

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Paolo Bonzini
Il 26/06/2013 14:37, Michael R. Hines ha scritto: > On 06/26/2013 02:37 AM, Paolo Bonzini wrote: >> Il 26/06/2013 02:31, Michael R. Hines ha scritto: >>> On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: > I was wrong - this does require a proto

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Alexander Graf
On 06/26/2013 02:38 PM, Peter Crosthwaite wrote: Hi, On Wed, Jun 26, 2013 at 8:50 PM, Peter Maydell wrote: On 26 June 2013 11:31, Alexander Graf wrote: I think it makes sense to make this API special-purpose for "reg". We currently have a generic "put any number of 32bit values into the prop

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-26 Thread Paul Durrant
> -Original Message- > From: Tim Deegan [mailto:t...@xen.org] > Sent: 26 June 2013 13:36 > To: Paul Durrant > Cc: Ian Campbell; Matt Wilson; Alex Bligh; xen-de...@lists.xen.org; qemu- > de...@nongnu.org > Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Add Xen platform PCI device > version 2.

Re: [Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-26 Thread Richard W.M. Jones
On Wed, Jun 26, 2013 at 07:47:47AM +0530, Shehbaz Jaffer wrote: > I want to determine the amount of screen activity taking place on VGA > monitor/ Screen for different applications (eg. playing vlc video, normal > typing.) > > When I do not start the X server, I can easily determine the screen > a

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Peter Maydell
On 26 June 2013 13:38, Peter Crosthwaite wrote: > On Wed, Jun 26, 2013 at 8:50 PM, Peter Maydell > wrote: >> I think we could avoid the "varargs doesn't promote" problem >> by using a varargs-macro wrapper: >> >> #define qemu_devtree_setprop_sized_cells(fdt, node, prop, ...) \ >> do { \ >>

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-26 Thread Peter Maydell
On 26 June 2013 13:38, Peter Crosthwaite wrote: > Are statement expressions sanctioned? ..and to answer this specific question which I missed first time round, we already use them (eg container_of, MAKE_TCGV_PTR). We seem to mark some but not all of them with __extension__; I think on balance th

Re: [Qemu-devel] [PATCH 2/5] tcg: Simplify logic using TCG_OPF_NOT_PRESENT

2013-06-26 Thread Claudio Fontana
Hello Richard, eons ago Richard wrote: > > Expand the definition of "not present" to include "should not be present". > This means we can simplify the logic surrounding the generic tcg opcodes > for which the host backend ought not be providing definitions. > > Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v4 02/12] boot-order-test: New; covering just PC for now

2013-06-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/Makefile | 2 ++ tests/boot-order-test.c | 73 + 2 files changed, 75 insertions(+) create mode 100644 tests/boot-order-test.c diff --git a/tests/Makefile b/tests/Makefile index c107489..394e029

[Qemu-devel] [PATCH v4 09/12] boot-order-test: Add tests for PowerPC PREP

2013-06-26 Thread Markus Armbruster
Cc: Andreas Färber Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster --- tests/boot-order-test.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c index c711c71..75b1642 100644 --- a/tests/b

[Qemu-devel] [PATCH v4 10/12] boot-order-test: Add tests for Sun4m

2013-06-26 Thread Markus Armbruster
Cc: Blue Swirl Signed-off-by: Markus Armbruster --- tests/boot-order-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c index 75b1642..a3928ed 100644 --- a/tests/boot-order-test.c +++ b/tests/boot-order-test.c @@ -161,6 +1

[Qemu-devel] [PATCH v4 03/12] libqos: include dependencies

2013-06-26 Thread Markus Armbruster
From: Anthony Liguori Otherwise rebuilds can fail when libqos is modified. Reported-by: Markus Armbruster Signed-off-by: Anthony Liguori Signed-off-by: Markus Armbruster --- tests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile b/tests/Makefile index 394e029..34a2

[Qemu-devel] [PATCH v4 05/12] boot-order-test: Add tests for PowerMacs

2013-06-26 Thread Markus Armbruster
From: Andreas Färber They set the boot device via fw_cfg, which is then translated to a boot path of "hd" or "cd" in OpenBIOS. Signed-off-by: Andreas Färber Cc: Alexander Graf Cc: qemu-...@nongnu.org Converted to libqos/fw_cfg on Anthony's request. Signed-off-by: Markus Armbruster --- tests/

[Qemu-devel] [PATCH v4 01/12] qtest: Don't reset on qtest chardev connect

2013-06-26 Thread Markus Armbruster
libqtest's qtest_init() connecting to the qtest socket triggers reset. This was coded in the hope we could use the same QEMU process for multiple tests that way. Never used. Injects an extra reset even when it's not used, and that can mess up tests such as the one of -boot once I'm about to add.

[Qemu-devel] [PATCH v4 00/12] Boot order tests

2013-06-26 Thread Markus Armbruster
v4: * Old PATCH 1-6 got merged, only tests left; cover letter changed accordingly * PATCH 1,6 unchanged * PATCH 2 fix system-reset race (Anthony) * New PATCH 4,11 to make libqos/fw_cfg usable for the ppc, Sun4 tests * New PATCH 3 shanghaied from Anthony, to make PATCH 4 compile without make cle

[Qemu-devel] [PATCH v4 12/12] boot-order-test: Add tests for Sun4u

2013-06-26 Thread Markus Armbruster
Cc: Blue Swirl Signed-off-by: Markus Armbruster --- tests/boot-order-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c index a3928ed..4b233d0 100644 --- a/tests/boot-order-test.c +++ b/tests/boot-order-test.c @@ -173,6 +1

[Qemu-devel] [PATCH v4 04/12] libqos: Add support for memory-mapped fw_cfg

2013-06-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/libqos/fw_cfg.c | 29 + tests/libqos/fw_cfg.h | 3 +++ 2 files changed, 32 insertions(+) diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c index e386ff7..49d1683 100644 --- a/tests/libqos/fw_cfg.c +++ b/tests/libqos

[Qemu-devel] [PATCH v4 08/12] boot-order-test: Code motion for better readability

2013-06-26 Thread Markus Armbruster
Cc: Andreas Färber Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster --- tests/boot-order-test.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c index 7

[Qemu-devel] [PATCH v4 07/12] boot-order-test: Better separate target-specific and generic parts

2013-06-26 Thread Markus Armbruster
The initial version did just PC. I didn't bother to separate out generic parts, because I don't like to abstract from a single case. Now we have two cases, PC and PowerMac, and I'm about to add more. Time to do it right. To ease review, this commit changes the code in-place, and the next commit

[Qemu-devel] [PATCH v4 11/12] libqos: Generalize I/O-mapped fw_cfg

2013-06-26 Thread Markus Armbruster
Provide a constructor that takes the base address in addition to the PC-specific one. Signed-off-by: Markus Armbruster --- tests/Makefile | 2 +- tests/fw_cfg-test.c | 2 +- tests/libqos/fw_cfg-pc.c | 40 tests/libqos/fw_cfg-pc.h | 20 ---

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 08:54:46 +0200 Markus Armbruster wrote: > Eric Blake writes: > > > On 05/23/2013 03:07 AM, Amos Kong wrote: > >> Introduce this new QMP event to notify management after guest changes > >> rx-filter configuration. > >> > >> Signed-off-by: Amos Kong > >> --- > >> QMP/qmp-ev

Re: [Qemu-devel] [PATCH 3/5] tcg-arm: Make use of conditional availability of opcodes for divide

2013-06-26 Thread Claudio Fontana
Richard wrote (eons ago): > We can now detect and use divide instructions at runtime, rather than > having to restrict their availability to compile-time. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 16 ++-- > tcg/arm/tcg-target.h | 14 -- > 2 file

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster wrote: > Meh, I got confused and reviewed an out-of-date version. Hope it's not > entirely noise. I don't think it is. But this series got applied to Michael's tree, so if you want your comments addressed before applying to master (I think we

[Qemu-devel] [PATCH v4 06/12] boot-order-test: Cover -boot once in ppc tests

2013-06-26 Thread Markus Armbruster
Cc: Andreas Färber Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster --- tests/boot-order-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c index 766981d..1a8e22a 100644 --- a/tests/boot-order-test.c +++ b/test

Re: [Qemu-devel] [PATCH 5/5] tcg-arm: Use AT_PLATFORM to detect the host ISA

2013-06-26 Thread Claudio Fontana
Richard wrote (eons ago): > With this we can generate armv7 insns even when the OS compiles for a > lower common denominator. The macros are arranged so that when we do > compile for a given ISA, all of the runtime checks for that ISA are > optimized away. > > Signed-off-by: Richard Henderson >

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-26 Thread Michael R. Hines
On 06/26/2013 08:39 AM, Paolo Bonzini wrote: Il 26/06/2013 14:37, Michael R. Hines ha scritto: On 06/26/2013 02:37 AM, Paolo Bonzini wrote: Il 26/06/2013 02:31, Michael R. Hines ha scritto: On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was w

  1   2   3   >