On Wed, 26 Jun 2013 08:54:46 +0200
Markus Armbruster <arm...@redhat.com> wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
> > On 05/23/2013 03:07 AM, Amos Kong wrote:
> >> Introduce this new QMP event to notify management after guest changes
> >> rx-filter configuration.
> >>
> >> Signed-off-by: Amos Kong <ak...@redhat.com>
> >> ---
> >> QMP/qmp-events.txt | 14 ++++++++++++++
> >> include/monitor/monitor.h | 1 +
> >> monitor.c | 1 +
> >> 3 files changed, 16 insertions(+)
> >>
> >> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> >> index 92fe5fb..ad6612b 100644
> >> --- a/QMP/qmp-events.txt
> >> +++ b/QMP/qmp-events.txt
> >> @@ -154,6 +154,20 @@ Data:
> >> "path": "/machine/peripheral/virtio-net-pci-0" },
> >> "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> >>
> >> +RX_FILTER_CHANGED
> >> +-----------------
> >
> >> +
> >> DEVICE_TRAY_MOVED
> >> -----------------
> >
> > Isn't this file supposed to be kept in sorted order, to minimize merge
> > conflicts when backporting events?
>
> Yes, please. Also helps humans navigate.
>
> GUEST_PANICKED is out of order, needs fixing.
The ultimate fix would be to add event support to the qapi.
