Re: [Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios

2013-04-19 Thread Hu Tao
On Thu, Apr 18, 2013 at 11:22:56AM +0200, Markus Armbruster wrote: > Hu Tao writes: > > > This lets seabios patch the corresponding SSDT entry. > > > > Signed-off-by: Hu Tao > > --- > > hw/misc/pvpanic.c | 14 ++ > > hw/nvram/fw_cfg.c | 8 +++- > > include/hw/nv

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-19 Thread Peter Lieven
On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes: Modify Anthony's starvation detection logic to keep the BQL unlocked until the starvation condition goes away.

[Qemu-devel] [PATCH 0/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
Below is the implementation of VMWare PVSCSI device PVSCSI implementation is based on Paolo Bonzini code sumbitted some time ago but never applied. See commit messages and file headers for details. This patch contains changes made by Deep Debroy, see here: http://lists.gnu.org/archive/html/qemu-d

[Qemu-devel] [PATCH v20 2/7] add a new qevent: QEVENT_GUEST_PANICKED

2013-04-19 Thread Hu Tao
This event will be emited when qemu detects guest panic. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c | 1 + 3 files changed, 16 insertions(+) diff --git a/QMP/qmp-events.txt b/

[Qemu-devel] [PATCH v20 1/7] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-04-19 Thread Hu Tao
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- include/sysemu/sysemu.h | 1 + qapi-schema.json| 5 - qmp.c | 3 +-- vl.c| 13 +++-- 4 files changed, 17 insertions(+), 5 delet

[Qemu-devel] [PATCH v20 4/7] pvpanic: pass configurable ioport to seabios

2013-04-19 Thread Hu Tao
This lets seabios patch the corresponding SSDT entry. Signed-off-by: Hu Tao --- hw/misc/pvpanic.c | 14 ++ hw/nvram/fw_cfg.c | 8 +++- include/hw/nvram/fw_cfg.h | 2 ++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pv

[Qemu-devel] [PATCH v20 5/7] pvpanic: add document of pvpanic

2013-04-19 Thread Hu Tao
Signed-off-by: Hu Tao --- docs/specs/pvpanic.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file mode 100644 index 000..c7bbacc --- /dev/null +++ b/

[Qemu-devel] [PATCH v20 3/7] introduce a new qom device to deal with panicked event

2013-04-19 Thread Hu Tao
pvpanic device is used to send guest panic event from guest to qemu. When guest panic happens, pvpanic device driver will write a event number to IO port 0x505(which is the IO port occupied by pvpanic device, by default). On receiving the event, pvpanic device will pause guest cpu(s), and send a q

Re: [Qemu-devel] [PATCH 0/1 V4] virtio-net: dynamic network offloads configuration

2013-04-19 Thread Dmitry Fleytman
Hello All, Any news regarding this patch? Thanks, Dmitry On Sun, Apr 7, 2013 at 9:34 AM, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > This patch implements recently accepted by virtio-spec > dynamic offloads configuration feature. > See commit message for details. > > V4 changes: > 1

[Qemu-devel] [PATCH v20 6/7] pvpanic: create pvpanic by default for machine 1.5

2013-04-19 Thread Hu Tao
Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- hw/i386/pc_piix.c| 16 ++-- hw/i386/pc_q35.c | 15 ++- hw/misc/pvpanic.c| 7 +++ include/hw/i386/pc.h | 3 +++ 4 files changed, 38 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i

Re: [Qemu-devel] [PATCH v19 3/7] introduce a new qom device to deal with panicked event

2013-04-19 Thread Hu Tao
On Thu, Apr 18, 2013 at 01:04:25PM +0200, Paolo Bonzini wrote: > Il 18/04/2013 11:23, Markus Armbruster ha scritto: > > Hu Tao writes: > > > >> pvpanic device is used to send guest panic event from guest to qemu. > >> > >> When guest panic happens, pvpanic device driver will write a event > >> nu

[Qemu-devel] [PATCH] tap: properly initialize vhostfds

2013-04-19 Thread Jason Wang
Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were forgot, this will lead qemu to ignore all fds passed by management through vhostfds, and tries to create vhost_net device itself. Fix by adding this check also. Reportyed-by: Michal Privoznik Cc: Michal Privoznik Cc: qemu-

[Qemu-devel] [PATCH v20 7/7] Wire up disabled wait a panicked event on s390

2013-04-19 Thread Hu Tao
From: Christian Borntraeger On s390 the disabled wait state indicates a state of attention. For example Linux uses that state after a panic. Lets put the system into panicked state. An alternative implementation would be to state disabled-wait instead of pause in the action field. (e.g. z/OS, z

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 01:21, Sander Eikelenboom ha scritto:> > Thursday, April 18, 2013, 3:32:37 PM, you wrote: > >> Il 18/04/2013 15:27, Stefano Stabellini ha scritto: > > Any thing that springs to mind ? >>> Nope, sorry. >>> Given the commit that your bisection identified and the error message

[Qemu-devel] [PATCH v20 0/7] Add pvpanic device to deal with guest panic event

2013-04-19 Thread Hu Tao
This series introduces a new simulated device, pvpanic, to notify qemu when guest panic event happens. Along with this series, there are two patches to add seabios ACPI driver and kernel ACPI driver for the device, respectively. Tested with: - qemu(kvm)/qemu(tcg) - qemu piix/q35 - default

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 09:05, Dmitry Fleytman ha scritto: > +if (pvscsi_req->dev->resetting) { > +pvscsi_req->cmp.hostStatus = BTSTAT_BUSRESET; > +} I'm changing this to if (pvscsi_req->cmp.hostStatus == BTSTAT_SUCCESS) { if (pvscsi_req->dev->resetting) { pvscsi_req

Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP

2013-04-19 Thread Richard Henderson
On 2013-04-19 04:52, liguang wrote: Signed-off-by: liguang --- target-i386/seg_helper.c | 46 +++--- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 906e4f3..5f7f99d 100644 ---

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Jens Freimann
On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: > Hi Jens, > > Am 03.04.2013 08:42, schrieb Jens Freimann: > > this is what our approach to CPU hotplug looks like. > > With respect to Igor's CPU hotplug series, how should we proceed? > > Should we change the interface to > > qemu

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 9:27:34 AM, you wrote: > Il 19/04/2013 01:21, Sander Eikelenboom ha scritto:> >> Thursday, April 18, 2013, 3:32:37 PM, you wrote: >> >>> Il 18/04/2013 15:27, Stefano Stabellini ha scritto: >> >> Any thing that springs to mind ? Nope, sorry. Given the c

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
Paolo, thanks for review. Regarding the change - it's ok with me, but why do one needs this? I think we always set proper status before request cancellation. May QEMU call cancel callback on its own? Dmitry. On Fri, Apr 19, 2013 at 10:37 AM, Paolo Bonzini wrote: > Il 19/04/2013 09:05, Dmitry

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 9:27:34 AM, you wrote: > Il 19/04/2013 01:21, Sander Eikelenboom ha scritto:> >> Thursday, April 18, 2013, 3:32:37 PM, you wrote: >> >>> Il 18/04/2013 15:27, Stefano Stabellini ha scritto: >> >> Any thing that springs to mind ? Nope, sorry. Given the c

Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP

2013-04-19 Thread li guang
在 2013-04-19五的 09:48 +0200,Richard Henderson写道: > On 2013-04-19 04:52, liguang wrote: > > Signed-off-by: liguang > > --- > > target-i386/seg_helper.c | 46 > > +++--- > > 1 files changed, 23 insertions(+), 23 deletions(-) > > > > diff --git a/target-i3

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 09:53, Dmitry Fleytman ha scritto: > Paolo, thanks for review. > > Regarding the change - it's ok with me, but why do one needs this? I > think we always set proper status before request cancellation. > May QEMU call cancel callback on its own? The cancel callback should not be run

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: >> > What version is glib on the host? > Ah i knew i forgot to look something up .. > > ii libglib2.0-0 > 2.24.2-1 The GLib library of C routines > ii

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
I see. Thanks. On Fri, Apr 19, 2013 at 10:58 AM, Paolo Bonzini wrote: > Il 19/04/2013 09:53, Dmitry Fleytman ha scritto: > > Paolo, thanks for review. > > > > Regarding the change - it's ok with me, but why do one needs this? I > > think we always set proper status before request cancellation.

Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP

2013-04-19 Thread Richard Henderson
On 2013-04-19 09:55, li guang wrote: do you think we can also get rid of ESP, EBP, ...? I don't see why not... r~

[Qemu-devel] [PATCH] block/ssh: Require libssh2 >= 1.2.8.

2013-04-19 Thread Richard W.M. Jones
From: "Richard W.M. Jones" libssh2 >= 1.2.8 is required to enable this block device (because that version introduced the libssh2_session_handshake call). Change the test to use pkg-config exclusively. If the user requests --enable-libssh2 and the minimum version is not available, then the follo

Re: [Qemu-devel] [RFC PATCH v4 14/15] slirp: handle race condition

2013-04-19 Thread Jan Kiszka
On 2013-04-19 02:18, liu ping fan wrote: > On Thu, Apr 18, 2013 at 3:13 PM, Jan Kiszka wrote: >> On 2013-04-17 10:39, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Slirp and its peer can run on different context at the same time. >>> Using lock to protect >> >> What are the usage rules for t

Re: [Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios

2013-04-19 Thread Markus Armbruster
Hu Tao writes: > On Thu, Apr 18, 2013 at 11:22:56AM +0200, Markus Armbruster wrote: >> Hu Tao writes: >> >> > This lets seabios patch the corresponding SSDT entry. [...] >> > diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h >> > index 05c8df1..07cc941 100644 >> > --- a/include

[Qemu-devel] [PATCH] tcg: Remove temp_buf

2013-04-19 Thread Richard Henderson
All targets have been converted to allocating space for temporaries on the stack. No need to allocate space within the CPU_COMMON block. Signed-off-by: Richard Henderson --- This depends on my tcg-arm patch set that's still outstanding. r~ --- include/exec/cpu-defs.h | 2 -- 1 file changed, 2

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > This patch qom-ifies the QemuConsoles and adds an new, optional > parameter to the screendump command to specify the device you > want dump from. > > Question for the QOM guys: where in the tree should the QemuConsoles > show up? I can't find anything in the tre

Re: [Qemu-devel] [PATCH 2/5] vmdk: add support for “zeroed‐grain” GTE

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 11:48:42AM +0800, Fam Zheng wrote: > diff --git a/block/vmdk.c b/block/vmdk.c > index 450a721..5e60940 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -33,10 +33,13 @@ > #define VMDK4_MAGIC (('K' << 24) | ('D' << 16) | ('M' << 8) | 'V') > #define VMDK4_COMPRESSION_DE

Re: [Qemu-devel] [PATCH] Initial TLS support for VNC Websockets

2013-04-19 Thread Tim Hardeck
Hi, did anybody had time yet to review my patch? Regards Tim -- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany T: +49 (0) 911 74053-0 F: +49 (0) 911 74053-483 http://www.suse.de/ signature.asc Descri

Re: [Qemu-devel] [PATCH 3/5] vmdk: Add option to create zeroed-grain image

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 11:48:43AM +0800, Fam Zheng wrote: > @@ -1714,6 +1719,11 @@ static QEMUOptionParameter vmdk_create_options[] = { > "VMDK flat extent format, can be one of " > "{monolithicSparse (default) | monolithicFlat | > twoGbMaxExtentSparse | twoGbMaxExtentFl

Re: [Qemu-devel] [PATCH 4/5] vmdk: change magic number to macro

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 11:48:44AM +0800, Fam Zheng wrote: > From: Feiran Zheng > > Two hard coded flag bits are changed to macros. > > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index

Re: [Qemu-devel] [PATCH 2/5] vmdk: add support for “zeroed‐grain” GTE

2013-04-19 Thread Fam Zheng
On Fri, 04/19 10:59, Stefan Hajnoczi wrote: > On Fri, Apr 19, 2013 at 11:48:42AM +0800, Fam Zheng wrote: > > diff --git a/block/vmdk.c b/block/vmdk.c > > index 450a721..5e60940 100644 > > --- a/block/vmdk.c > > +++ b/block/vmdk.c > > @@ -33,10 +33,13 @@ > > #define VMDK4_MAGIC (('K' << 24) | ('D'

Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 11:48:45AM +0800, Fam Zheng wrote: > From: Feiran Zheng > > Use special offset to write zeroes efficiently, when zeroed-grain GTE is > available. If zero-write an allocated cluster, cluster is leaked because > its offset pointer is overwritten by "0x1". > > Signed-off-by:

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 02:16:34PM -0600, Keith Busch wrote: > Initial commit for emulated nvme pci storage device. Implements the > minimum from the specification to work with existing drivers. > > Cc: Keith Busch > Signed-off-by: Keith Busch > > A lot of people are very interested in this, so

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio.h: drop unused function prototypes

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 09:12:55AM -0400, Luiz Capitulino wrote: > They are unused since commit 5c7d0962f60498c3f11d402e1c857cb9d5d8568d. > > Signed-off-by: Luiz Capitulino > --- > include/hw/virtio/virtio.h | 2 -- > 1 file changed, 2 deletions(-) Thanks, applied to the trivial patches tree: h

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Remove unneeded type casts

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 08:53:58PM +0200, Stefan Weil wrote: > cpu_physical_memory_read, cpu_physical_memory_write take any pointer > as 2nd argument without needing a type cast. > > Signed-off-by: Stefan Weil > --- > hw/arm/armv7m.c| 12 ++-- > hw/arm/boot.c |

Re: [Qemu-devel] [Qemu-trivial] [PATCH] w64: Fix compiler warnings (wrong format specifier)

2013-04-19 Thread Stefan Hajnoczi
On Sat, Apr 13, 2013 at 10:45:50PM +0200, Stefan Weil wrote: > GetLastError() returns a DWORD value which is unsigned long, > so the correct format specifier is %lu. > > Signed-off-by: Stefan Weil > --- > > Debian's w32 cross compiler does not complain about the wrong > specifiers, but the w64 c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Add lost ARM core again

2013-04-19 Thread Stefan Hajnoczi
On Sun, Apr 14, 2013 at 10:52:50PM +0200, Stefan Weil wrote: > Commit 0434e30afb6175212389811e0b28b948eb3c1e40 accidentally removed > the compilation of arm11mpcore.c. > > Signed-off-by: Stefan Weil > --- > default-configs/arm-softmmu.mak |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

2013-04-19 Thread Stefan Hajnoczi
On Thu, Mar 21, 2013 at 06:57:36PM +0100, Petar Jovanovic wrote: > From: Petar Jovanovic > > do_semop() is called from two places, and one of these fails to convert > return error to target errno when semop fails. This patch changes the > function to always return target errno in case of an unsuc

Re: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-19 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 10:21:05PM +0200, Stefan Weil wrote: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil > --- > > Please note: I could only run limited tests with the new code > because ssh.c is currently not compiled in my w32/w64 env

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ssh: Remove unnecessary use of strlen function.

2013-04-19 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 10:09:33PM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > --- > block/ssh.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

Re: [Qemu-devel] [Qemu-trivial] [PATCH] m25p80: Remove bogus include of devices.h

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 12:18:05PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > I think in the early revisions of this we had an instantiation helper > for the device in devices.h. This was later removed and this header was > left over. Removed > > Signed-off-by: Pete

[Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Amos Kong
Libvirt doesn't have a stable way to know option support detail. This patch introdued a new qmp command to query configuration schema information. hmp command isn't added. Signed-off-by: Amos Kong CC: Osier Yang CC: Anthony Liguori --- Reposted this patch: https://www.redhat.com/archives/libvi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Add lost ARM core again

2013-04-19 Thread Peter Maydell
On 19 April 2013 10:39, Stefan Hajnoczi wrote: > On Sun, Apr 14, 2013 at 10:52:50PM +0200, Stefan Weil wrote: >> -CONFIG_ARM5MPCORE=y >> CONFIG_ARM9MPCORE=y >> +CONFIG_ARM11MPCORE=y > > Did you mean to remove CONFIG_ARM5MPCORE? This is correct -- we don't emulate the Cortex-A5. -- PMM

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

2013-04-19 Thread Riku Voipio
On 19 April 2013 12:42, Stefan Hajnoczi wrote: > On Thu, Mar 21, 2013 at 06:57:36PM +0100, Petar Jovanovic wrote: > > From: Petar Jovanovic > > > > do_semop() is called from two places, and one of these fails to convert > > return error to target errno when semop fails. This patch changes the >

Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-19 Thread Peter Maydell
On 19 April 2013 03:06, wrote: > From: Peter Crosthwaite > > Invalidate the LQSPI cached page when transitioning into LQSPI mode. > Otherwise there is a possibility that the controller will return stale > data to the guest when transitioning back to LQ_MODE after a page > program. > > Signed-off

Re: [Qemu-devel] OpenBios in Sparc can't handle long kernel command lines.

2013-04-19 Thread Mark Cave-Ayland
On 22/03/13 05:19, Rob Landley wrote: If I do this: qemu-system-sparc -nographic -no-reboot -kernel image -hda hda.sqf -append 'root=/dev/sda rw init=/sbin/init.sh panic=1 PATH=/usr/distcc:/bin:/sbin console=ttyS0 HOST=sparc CPUS=1 DISTCC_HOSTS=10.0.2.2:31322/1 FTP_SERVER=10.0.2.2 FTP_PORT=3130

Re: [Qemu-devel] [PATCH for-1.5 v2 00/15] Xilinx SPIPS fixes round 2

2013-04-19 Thread Peter Maydell
On 19 April 2013 03:02, wrote: > From: Peter Crosthwaite > > Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by > a number of bugs/incompletnesses found by some (very) rigourous test > vectors. Other than the random inserted code after goto, Reviewed-by: Peter Maydell --

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-19 Thread Laszlo Ersek
On 04/18/13 22:30, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 10:22:24PM +0200, Laszlo Ersek wrote: >> This patch reuses some code from SeaBIOS, which was originally under >> LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This >> relicensing has been acked by all cont

Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes

2013-04-19 Thread Fam Zheng
On Fri, 04/19 11:12, Stefan Hajnoczi wrote: > On Fri, Apr 19, 2013 at 11:48:45AM +0800, Fam Zheng wrote: > > From: Feiran Zheng > > > > Use special offset to write zeroes efficiently, when zeroed-grain GTE is > > available. If zero-write an allocated cluster, cluster is leaked because > > its off

Re: [Qemu-devel] [PATCH 2/5] vmdk: add support for “zeroed‐grain” GTE

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 11:10 AM, Fam Zheng wrote: > On Fri, 04/19 10:59, Stefan Hajnoczi wrote: >> On Fri, Apr 19, 2013 at 11:48:42AM +0800, Fam Zheng wrote: >> > diff --git a/block/vmdk.c b/block/vmdk.c >> > index 450a721..5e60940 100644 >> > --- a/block/vmdk.c >> > +++ b/block/vmdk.c >> > @@ -3

Re: [Qemu-devel] [PATCH] tap: properly initialize vhostfds

2013-04-19 Thread Michal Privoznik
On 19.04.2013 09:11, Jason Wang wrote: > Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were > forgot, this will lead qemu to ignore all fds passed by management through > vhostfds, and tries to create vhost_net device itself. Fix by adding this > check > also. > > Reportyed

[Qemu-devel] [PULL 0/8] Trivial patches for 13 to 19 April 2013

2013-04-19 Thread Stefan Hajnoczi
The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove duplicate test (2013-04-18 14:12:31 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to ad6b40f471cf8bf7b106032145b1b2a

[Qemu-devel] [PATCH 1/8] bswap: fix compiler warning

2013-04-19 Thread Stefan Hajnoczi
From: Alexey Kardashevskiy The bswap functions use memcpy but the bswap.h header itself does not seem to include it in some configuration such as cross compiling for powerpc64 on x86_64 machine. The patch explicitly includes string.h. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Stefan Haj

[Qemu-devel] [PATCH 2/8] virtio.h: drop unused function prototypes

2013-04-19 Thread Stefan Hajnoczi
From: Luiz Capitulino They are unused since commit 5c7d0962f60498c3f11d402e1c857cb9d5d8568d. Signed-off-by: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.

[Qemu-devel] [PATCH 8/8] m25p80: Remove bogus include of devices.h

2013-04-19 Thread Stefan Hajnoczi
From: Peter Crosthwaite I think in the early revisions of this we had an instantiation helper for the device in devices.h. This was later removed and this header was left over. Removed Signed-off-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/block/m25p80.c | 1 - 1 file changed,

[Qemu-devel] [PATCH 4/8] w64: Fix compiler warnings (wrong format specifier)

2013-04-19 Thread Stefan Hajnoczi
From: Stefan Weil GetLastError() returns a DWORD value which is unsigned long, so the correct format specifier is %lu. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index c15ff6c..5a

[Qemu-devel] [PATCH 6/8] block/ssh: Add missing gcc format attributes

2013-04-19 Thread Stefan Hajnoczi
From: Stefan Weil Now gcc will check whether format string and variable arguments match. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8f78e2e..b4e048c 100644 --

[Qemu-devel] [PATCH 7/8] ssh: Remove unnecessary use of strlen function.

2013-04-19 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" Reviewed-by: Eric Blake Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index b4e048c..93a8b53 100644 --- a/block/ssh.c +++ b/block/ssh.c @@

[Qemu-devel] [PATCH 3/8] Remove unneeded type casts

2013-04-19 Thread Stefan Hajnoczi
From: Stefan Weil cpu_physical_memory_read, cpu_physical_memory_write take any pointer as 2nd argument without needing a type cast. Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- hw/arm/armv7m.c| 12 ++-- hw/arm/boot.c

[Qemu-devel] [PATCH 5/8] linux-user: change do_semop to return target errno when unsuccessful

2013-04-19 Thread Stefan Hajnoczi
From: Petar Jovanovic do_semop() is called from two places, and one of these fails to convert return error to target errno when semop fails. This patch changes the function to always return target errno in case of an unsuccessful call. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell

Re: [Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-19 Thread Gleb Natapov
On Fri, Apr 19, 2013 at 01:05:08AM +, Zhanghaoyu (A) wrote: > >> On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote: > >>> I start 10 VMs(windows xp), then running geekbench tool on them, > >>> about 2 days, one of them was reset, I found the reset operation is > >>> done by int k

Re: [Qemu-devel] [RFC PATCH v4 01/15] util: introduce gsource event abstration

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 02:52:08PM +0800, liu ping fan wrote: > On Thu, Apr 18, 2013 at 10:01 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 17, 2013 at 04:39:10PM +0800, Liu Ping Fan wrote: > >> +static gboolean prepare(GSource *src, gint *time) > >> +{ > >> +EventGSource *nsrc = (EventGSource *)

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Osier Yang
On 19/04/13 17:52, Amos Kong wrote: Libvirt doesn't have a stable way to know option support Actually no way now. Libvirt swtiched to use qmp to collect the qemu capabilities for qemu newer than 1.2.0, thus there is no way to probe either if a option or a property is supported or not by QEMU.

Re: [Qemu-devel] [RFC PATCH v4 06/15] net: port socket to GSource

2013-04-19 Thread Stefan Hajnoczi
On Fri, Apr 19, 2013 at 01:58:40PM +0800, liu ping fan wrote: > On Thu, Apr 18, 2013 at 10:34 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 17, 2013 at 04:39:15PM +0800, Liu Ping Fan wrote: > > I'm a little worried that we're lacking G_IO_HUP | G_IO_ERR. Perhaps > > disconnect and network errors wil

Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf

2013-04-19 Thread Andreas Färber
Hi, Am 19.04.2013 10:27, schrieb Richard Henderson: > All targets have been converted to allocating space for temporaries > on the stack. No need to allocate space within the CPU_COMMON block. > > Signed-off-by: Richard Henderson > --- > This depends on my tcg-arm patch set that's still outstan

Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf

2013-04-19 Thread Andreas Färber
Am 19.04.2013 14:11, schrieb Andreas Färber: > Hi, > > Am 19.04.2013 10:27, schrieb Richard Henderson: >> All targets have been converted to allocating space for temporaries >> on the stack. No need to allocate space within the CPU_COMMON block. >> >> Signed-off-by: Richard Henderson >> --- >> T

Re: [Qemu-devel] [PATCH v2 13/23] qapi: Add a primitive to include other files from a QAPI schema file

2013-04-19 Thread Lluís Vilanova
Eric Blake writes: > On 04/16/2013 07:51 AM, Lluís Vilanova wrote: >> Adds the "input(...)" primitive to the syntax of QAPI schema files. > Interesting idea, but isn't "include(...)" a more common name than > "input(...)"? Indeed it is. Thanks for the catch. Lluis -- "And it's much the same

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Eric Blake
On 04/19/2013 06:02 AM, Osier Yang wrote: > On 19/04/13 17:52, Amos Kong wrote: >> Libvirt doesn't have a stable way to know option support > > Actually no way now. > >> + >> +## >> +# @ConfigSchemaInfo: >> +# >> +# Configration schema information. >> +# >> +# @option: option name >> +# >> +# @c

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Eric Blake
On 04/19/2013 03:52 AM, Amos Kong wrote: > Libvirt doesn't have a stable way to know option support > detail. This patch introdued a new qmp command to query > configuration schema information. hmp command isn't added. Agreed; HMP is not needed: by the time you can connect to a human monitor, you'

[Qemu-devel] [PULL 0/2] QMP queue

2013-04-19 Thread Luiz Capitulino
Two important fixes. The changes (since 09dada400328d75daf79e3eca1e48e024fec148d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Amos Kong (1): monitor: fix the wrong order of releasing keys Luiz Capitulino (1): virtio-balloon: fix integer ov

[Qemu-devel] [PULL 1/2] monitor: fix the wrong order of releasing keys

2013-04-19 Thread Luiz Capitulino
From: Amos Kong (qemu) sendkey ctrl_r-scroll_lock-scroll_lock Executing this command could not let Windows guest panic, it caused by the wrong order of releasing keys. This problem was introduced by commit e4c8f004c55d9da3eae3e14df740238bf805b5d6. The right release order should be starting from

[Qemu-devel] [PULL 2/2] virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event

2013-04-19 Thread Luiz Capitulino
Because dev->actual is uint32_t, the expression 'dev->actual << VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when dev->actual >= 1048576. To reproduce: 1. Start a VM with a QMP socket and 5G of RAM 2. Connect to the QMP socket, negotiate capabilities and issue: { "execu

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 10:04:22 AM, you wrote: > Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: >>> > What version is glib on the host? >> Ah i knew i forgot to look something up .. >> >> ii libglib2.0-0 >> 2.24.2-1

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 14:56, Sander Eikelenboom ha scritto: > > Friday, April 19, 2013, 10:04:22 AM, you wrote: > >> Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: > What version is glib on the host? >>> Ah i knew i forgot to look something up .. >>> >>> ii libglib2.0-0

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-19 Thread Eric Blake
On 04/19/2013 02:37 AM, Markus Armbruster wrote: >> Question for the libvirt guys: Is it ok for libvirt to just extend the >> existing screendump command? Can libvirt figure there is a new >> (optional) parameter? See patch #5. > > Nope, QMP can't do that. I argued for such capabilities, but t

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Andreas Färber
Am 19.04.2013 09:51, schrieb Jens Freimann: > On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: >> Hi Jens, >> >> Am 03.04.2013 08:42, schrieb Jens Freimann: >>> this is what our approach to CPU hotplug looks like. >>> With respect to Igor's CPU hotplug series, how should we proceed?

[Qemu-devel] [PATCH RESEND v3 0/4] virtio-9p refactoring.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring: nothing changed, it's just rebased. Basically it creates virtio-9p-device backend which extends virtio-device. Then a virtio-9p-device can be connected on a virtio-bus. virtio-9p-pci is modified, extends virtio-pci and have a vir

[Qemu-devel] [PATCH RESEND v3 1/4] virtio-9p: add the virtio-9p device.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Create virtio-9p which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 73 +- hw/9pfs/virtio-9p.h| 9 ++ hw/virtio/virtio-pci.c | 3 +

[Qemu-devel] [PATCH RESEND v3 2/4] virtio-9p-pci: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-9p-pci is modified for the new API. The device virtio-9p-pci extends virtio-pci. It creates and connects a virtio-9p during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p.h| 1 - hw/virtio/virtio-pci.c |

[Qemu-devel] [PATCH RESEND v3 4/4] virtio-9p: cleanup: QOM casts.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic As the virtio-9p-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 11 +++ hw/9pfs/virtio-9p.c| 2 +- hw/9pfs/virtio-9p.h| 2 +- 3 files changed, 5 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH RESEND v3 3/4] virtio-9p: cleanup: init function.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This remove old init function as it is no longer needed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 75 ++ 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Osier Yang
On 19/04/13 20:02, Osier Yang wrote: On 19/04/13 17:52, Amos Kong wrote: Libvirt doesn't have a stable way to know option support Actually no way now. Libvirt swtiched to use qmp to collect the qemu capabilities for qemu newer than 1.2.0, thus there is no way to probe either if a option or a

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Osier Yang
On 19/04/13 20:39, Eric Blake wrote: On 04/19/2013 03:52 AM, Amos Kong wrote: Libvirt doesn't have a stable way to know option support detail. This patch introdued a new qmp command to query configuration schema information. hmp command isn't added. Agreed; HMP is not needed: by the time you ca

[Qemu-devel] [PATCH v4 0/8] virtio-rng refactoring.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Tested-by: Cornelia Huck Acked-by: Amit Shah This is the last backend of the refactoring (*and must be applied at last, because it would break virtio-9p*). Basically it creates virtio-rng-device which extends virtio-device. Then a virtio-rng-device can be connected on a

[Qemu-devel] [PATCH v4 2/8] virtio-rng: add virtio-rng device.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Create virtio-rng-device which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 3 +- hw/virtio/virtio-pci.c | 8 +-- hw/virtio/virtio-rng.c | 108 +

[Qemu-devel] [PATCH v4 3/8] virtio-rng-pci: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-pci is modified for the new API. The device virtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-device during the init. The properties are not changed. The virtio_pci_reset function, is removed as no longer used. The virtio_pci_rst fu

[Qemu-devel] [PATCH v4 5/8] virtio-rng-ccw: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-ccw is modified for the new API. The device virtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-device during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 48 ++

[Qemu-devel] [PATCH v4 1/8] virtio-rng: don't use pointer for configuration.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-rng properties. So *conf is replaced by conf. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 12 ++-- include/hw/virtio/virtio-rng.h | 2 +- 2 files changed, 7 insert

[Qemu-devel] [PATCH v4 8/8] virtio-rng: cleanup: use QOM casts.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic As the virtio-rng-pci, virtio-rng-s390 and virtio-rng-ccw are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic Reviewed-by: Andreas Färber --- hw/virtio/virtio-rng.c | 27 +++ include/hw/virtio/virtio-rng.h |

[Qemu-devel] [PATCH v4 6/8] virtio-rng: cleanup: init and exit functions.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 87 +++--- include/hw/virtio/virtio.h | 2 -- 2 files changed, 21 insertions(+), 68 deletions(-)

[Qemu-devel] [PATCH 1/3] linux-user: change do_semop to return target errno when unsuccessful

2013-04-19 Thread riku . voipio
From: Petar Jovanovic do_semop() is called from two places, and one of these fails to convert return error to target errno when semop fails. This patch changes the function to always return target errno in case of an unsuccessful call. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v4 4/8] virtio-rng-s390: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-s390 is modified for the new API. The device virtio-rng-s390 extends virtio-s390-device as before. It creates and connects a virtio-rng during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 38

[Qemu-devel] [PULL] [PATCH 0/3] linux-user pending patches

2013-04-19 Thread riku . voipio
From: Riku Voipio The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove duplicate test (2013-04-18 14:12:31 +0200) are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream for you to fetch chan

[Qemu-devel] [PATCH v4 7/8] virtio-rng: cleanup: remove qdev field.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 2 -- include/hw/virtio/virtio-rng.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 805dd18..

[Qemu-devel] [PATCH 2/3] linux-user: fix undefined shift in copy_to_user_fdset

2013-04-19 Thread riku . voipio
From: Andreas Schwab If TARGET_ABI_BITS is bigger than 32 we shift by more than the size of int. Signed-off-by: Andreas Schwab Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/sysc

  1   2   >