Paolo, thanks for review.

Regarding the change - it's ok with me, but why do one needs this? I think
we always set proper status before request cancellation.
May QEMU call cancel callback on its own?

Dmitry.


On Fri, Apr 19, 2013 at 10:37 AM, Paolo Bonzini <pbonz...@redhat.com> wrote:

> Il 19/04/2013 09:05, Dmitry Fleytman ha scritto:
> > +    if (pvscsi_req->dev->resetting) {
> > +        pvscsi_req->cmp.hostStatus = BTSTAT_BUSRESET;
> > +    }
>
> I'm changing this to
>
>     if (pvscsi_req->cmp.hostStatus == BTSTAT_SUCCESS) {
>         if (pvscsi_req->dev->resetting) {
>             pvscsi_req->cmp.hostStatus = BTSTAT_BUSRESET;
>          } else {
>             pvscsi_req->cmp.hostStatus = BTSTAT_ABORTQUEUE;
>          }
>      }
>
> Otherwise it's okay.
>
> Thanks!
>
> Paolo
>

Reply via email to