Hu Tao <hu...@cn.fujitsu.com> writes: > On Thu, Apr 18, 2013 at 11:22:56AM +0200, Markus Armbruster wrote: >> Hu Tao <hu...@cn.fujitsu.com> writes: >> >> > This lets seabios patch the corresponding SSDT entry. [...] >> > diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h >> > index 05c8df1..07cc941 100644 >> > --- a/include/hw/nvram/fw_cfg.h >> > +++ b/include/hw/nvram/fw_cfg.h >> > @@ -1,6 +1,8 @@ >> > #ifndef FW_CFG_H >> > #define FW_CFG_H >> > >> > +#include "exec/hwaddr.h" >> > + >> > #define FW_CFG_SIGNATURE 0x00 >> > #define FW_CFG_ID 0x01 >> > #define FW_CFG_UUID 0x02 >> >> Why is the include necessary? > > Withou it gcc gives error like this: > > In file included from hw/misc/pvpanic.c:21:0: > qemu/include/hw/nvram/fw_cfg.h:68:25: error: unknown type name ‘hwaddr’ > qemu/include/hw/nvram/fw_cfg.h:68:42: error: unknown type name ‘hwaddr’
Okay, your change makes sense, but it doesn't belong into this patch. Put it into a separate one if you need to respin anyway.
