[Qemu-devel] [PATCH 1/2] usb-redir: Add flow control support

2013-03-19 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index c519b9b..0b2a5e6 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -104,6 +104,8 @@ struct U

Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support

2013-03-19 Thread Hans de Goede
Hi, Oops. v2 is on its way. Regards, Hans On 03/19/2013 01:40 PM, Gerd Hoffmann wrote: On 03/14/13 17:36, Hans de Goede wrote: +if (!dev->watch) { +dev->watch = qemu_chr_fe_add_watch(dev->cs, G_IO_OUT, + usbredir_write_unbloc

[Qemu-devel] [PATCH 2/2] usb-redir: Fix crash on migration with no client connected

2013-03-19 Thread Hans de Goede
If no client is connected on the src side, then we won't receive a parser during migrate, in this case usbredir_post_load() should be a nop, rather then to try to derefefence the NULL dev->parser pointer. Signed-off-by: Hans de Goede --- hw/usb/redirect.c | 4 1 file changed, 4 insertions(+

[Qemu-devel] usb-redir: Add flow control support v2 + one more fix

2013-03-19 Thread Hans de Goede
Here is v2 of the "usb-redir: Add flow control support" patch with the checkpatch issue fixed + one other usb-redir bugfix. Regards, Hans

Re: [Qemu-devel] KVM call agenda for 2013-03-19

2013-03-19 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there are no agenda, call got cancelled. Happy hacking. Later, Juan.

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Hans de Goede
Hi, Looks good, one minor nitpick. On 03/19/2013 10:57 AM, Gerd Hoffmann wrote: chardev flow control broke monitor, fix it by adding watch support. --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920

Re: [Qemu-devel] [PATCH v9 03/10] virtio-blk: don't use pointer for configuration.

2013-03-19 Thread Kevin Wolf
Am 19.03.2013 um 14:38 hat KONRAD Frédéric geschrieben: > On 18/03/2013 09:59, Kevin Wolf wrote: > >Am 15.03.2013 um 19:48 hat fred.kon...@greensocs.com geschrieben: > >>From: KONRAD Frederic > >> > >>The configuration field must not be a pointer as it will be used for > >>virtio-blk > >>properti

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-03-19 Thread Stefano Stabellini
On Fri, 15 Mar 2013, Frediano Ziglio wrote: > Modern notebook support 136x768 resolution. The resolution width is ^this can't be right > not multiple of 16 causing some problems. > > Qemu VGA emulation require width resolution to be multiple of 8. > > VNC implementati

[Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Gerd Hoffmann
chardev flow control broke monitor, fix it by adding watch support. Signed-off-by: Gerd Hoffmann --- v2: fix tyops --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920..74807f9 100644 --- a/monitor.c +++

Re: [Qemu-devel] usb-redir: Add flow control support v2 + one more fix

2013-03-19 Thread Gerd Hoffmann
On 03/19/13 14:54, Hans de Goede wrote: > Here is v2 of the "usb-redir: Add flow control support" patch > with the checkpatch issue fixed + one other usb-redir bugfix. Added #1, #2 is already in the usb queue (yes, I should flush it ...). cheers, Gerd

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Michael R. Hines
On 03/19/2013 09:45 AM, Paolo Bonzini wrote: This is because of downtime: You have to drain the queue anyway at the very end, and if you don't drain it in advance after each iteration, then the queue will have lots of bytes in it waiting for transmission and the Virtual Machine will be stopped fo

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 15:10, Michael R. Hines ha scritto: > On 03/19/2013 09:45 AM, Paolo Bonzini wrote: >> This is because of downtime: You have to drain the queue anyway at the >> very end, and if you don't drain it in advance after each iteration, then >> the queue will have lots of bytes in it waiting

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

2013-03-19 Thread Markus Armbruster
Stefan Berger writes: > On 03/19/2013 03:45 AM, Markus Armbruster wrote: >> Stefan Berger writes: >> >>> On 03/18/2013 09:10 AM, Markus Armbruster wrote: > In case the TPM is currently not operating on a command there will be > no impact. In case the TPM is operating on a command, it wil

Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts

2013-03-19 Thread Markus Armbruster
Fabien Chouteau writes: > On 03/14/2013 01:34 PM, Markus Armbruster wrote: >> Fabien Chouteau writes: >> >>> On 03/14/2013 09:44 AM, Markus Armbruster wrote: Fabien Chouteau writes: > We introduce a new command line option. It's a generic option to > customize the gdb server:

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Laszlo Ersek
On 03/19/13 15:04, Gerd Hoffmann wrote: > chardev flow control broke monitor, fix it by adding watch support. > > Signed-off-by: Gerd Hoffmann > --- > v2: fix tyops Well played, Sir :) > --- > monitor.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > dif

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

2013-03-19 Thread Stefan Berger
On 03/19/2013 10:28 AM, Markus Armbruster wrote: Stefan Berger writes: I can write an OS that sends a command to the TPM and then shuts down without waiting for the program to terminate or the even the response from the TPM to come back . In this case we would need to cancel the command on ex

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-19 Thread Corey Bryant
On 03/19/2013 03:26 AM, Markus Armbruster wrote: [Note cc: Anthony for QAPI schema expertise] Stefan Berger writes: On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 +++

[Qemu-devel] [Bug]? (RDMA-related) ballooned memory not consulted during migration?

2013-03-19 Thread Michael R. Hines
Consider the following sequence: 1. Boot fresh VM (say, a boring 1GB vm)=> Resident set is small, say 100M 2. Touch all the memory (with a utility or something) => Resident set is ~1G 3. Send QMP "balloon 500" => Resident set is ~500M 4. Now, migrate the VM => Resident set i

Re: [Qemu-devel] large memory requirements for translate.c a barrier

2013-03-19 Thread qemu-devel
Penned by Paolo Bonzini on 20130316 3:14.29, we have: | Il 15/03/2013 20:21, Todd T. Fries ha scritto: | > PID USERNAME PRI NICE SIZE RES STATE WAIT TIMECPU COMMAND | > 28818 todd 640 1142M 53M onproc/0 - 2:01 17.24% cc1 | > | > For systems with lower limits

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
This is actual a much bigger problem that I thought, not just for RDMA: Currently the *sender* side is does not support overcommit during a regular TCP migration...I assume because the migration_bitmap does not know which memory is mapped or unmapped by the host kernel. Is this a known issue

Re: [Qemu-devel] QEMU-kvm 1.0 build and python

2013-03-19 Thread Stefan Hajnoczi
On Mon, Mar 18, 2013 at 03:28:45PM -0400, Udayan Bapat wrote: > I am trying to cross compile qemu-kvm for a custom platform and the > environment does not contain python. Due to this, the configure is > breaking. I found that there are a few .pl scripts that get fired > during configure. Are they e

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Gerd Hoffmann
On 03/19/13 15:45, Laszlo Ersek wrote: > On 03/19/13 15:04, Gerd Hoffmann wrote: >> chardev flow control broke monitor, fix it by adding watch support. >> >> Signed-off-by: Gerd Hoffmann >> --- >> v2: fix tyops > > Well played, Sir :) > >> --- >> monitor.c | 23 +-- >> 1 f

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread George Dunlap
On Tue, Mar 19, 2013 at 11:21 AM, George Dunlap wrote: > On 03/19/2013 11:14 AM, Paolo Bonzini wrote: >> >> Il 19/03/2013 11:51, George Dunlap ha scritto: >>> >>> On 03/19/2013 10:43 AM, Paolo Bonzini wrote: >> >> Even for successful migration, it would also be bad for downtime (QEMU >

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Paolo Bonzini wrote: > Il 19/03/2013 11:06, George Dunlap ha scritto: > > On Mon, Mar 18, 2013 at 6:00 PM, Paolo Bonzini wrote: > >> Il 18/03/2013 18:38, George Dunlap ha scritto: > > > This might be a difference between Xen and KVM. On Xen migration is > made to

Re: [Qemu-devel] [Bug]? (RDMA-related) ballooned memory not consulted during migration?

2013-03-19 Thread Michael R. Hines
Actually, you don't even need ballooning to reproduce this behavior. Is this a known issue? - Michael On 03/19/2013 11:02 AM, Michael R. Hines wrote: Consider the following sequence: 1. Boot fresh VM (say, a boring 1GB vm)=> Resident set is small, say 100M 2. Touch all t

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Fabien Chouteau
On 03/19/2013 01:10 PM, Alexander Graf wrote: > > On 19.03.2013, at 13:03, Fabien Chouteau wrote: > >> Although the support of this register may be uncomplete, there are no >> reason to prevent the debugger from reading or writing it. >> >> Signed-off-by: Fabien Chouteau >> --- >> gdbstub.c

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 11:08:24AM -0400, Michael R. Hines wrote: > This is actual a much bigger problem that I thought, not just for RDMA: > > Currently the *sender* side is does not support overcommit > during a regular TCP migration...I assume because the > migration_bitmap does not know wh

Re: [Qemu-devel] [Bug]? (RDMA-related) ballooned memory not consulted during migration?

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 11:12:50AM -0400, Michael R. Hines wrote: > Actually, you don't even need ballooning to reproduce this behavior. > > Is this a known issue? > > - Michael Yes.

Re: [Qemu-devel] large memory requirements for translate.c a barrier

2013-03-19 Thread Andreas Färber
Am 15.03.2013 20:21, schrieb Todd T. Fries: > Is there any hints or hope of breaking translate.c up into a smaller file? You don't specify which version you're talking about (git?) and don't mention which translate.c file either. The longest-building one I am aware of was target-ppc/translate.c,

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Peter Maydell
On 19 March 2013 15:14, Fabien Chouteau wrote: > I can if I include helper.h, unfortunately this file is named helpers.h > (note the 's') for m68k so I wont be able to include it for all > platforms. The way we do this on ARM for cpsr_read is: * cpsr_read() is defined in target-arm/cpu.h * gdbs

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread George Dunlap
On Tue, Mar 19, 2013 at 3:12 PM, George Dunlap wrote: > > I've just had a chat with Stefano, and it turns out I was a bit > confused -- this change has nothing to do with qemu running as a > device model, but only as qemu running as a PV back-end for PV guests. > So the question of when in the sa

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
On 03/19/2013 11:16 AM, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 11:08:24AM -0400, Michael R. Hines wrote: This is actual a much bigger problem that I thought, not just for RDMA: Currently the *sender* side is does not support overcommit during a regular TCP migration...I assume be

Re: [Qemu-devel] [PATCHv2 1/9] move vector definitions to qemu-common.h

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > vector optimizations will now be used at various places > not just in is_dup_page() in arch_init.c > > this patch also adds a zero splat vector. > > Signed-off-by: Peter Lieven > --- > arch_init.c | 20 > include/qem

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 11:32:49AM -0400, Michael R. Hines wrote: > On 03/19/2013 11:16 AM, Michael S. Tsirkin wrote: > >On Tue, Mar 19, 2013 at 11:08:24AM -0400, Michael R. Hines wrote: > >>This is actual a much bigger problem that I thought, not just for RDMA: > >> > >>Currently the *sender* side

Re: [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > The new parameter is unused yet. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signatu

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > include/qemu-common.h |2 ++ > util/cutils.c | 40 > 2 files changed, 42 insertions(+) > > > +#define BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR 8 Good. > +

Re: [Qemu-devel] [PATCH 03/35] configure: fix TPM logic

2013-03-19 Thread Andreas Färber
Am 18.03.2013 18:34, schrieb Paolo Bonzini: > A non-native i386 or x86_64 emulator should not have TPM passthrough > support, since the TPM is only present for those hosts. > > Signed-off-by: Paolo Bonzini Looks good, Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH,

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > performance gain on SSE2 is approx. 20-25%. altivec > is not tested. performance for unsigned long arithmetic > is unchanged. > > Signed-off-by: Peter Lieven > --- > util/cutils.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/ut

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:08 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> performance gain on SSE2 is approx. 20-25%. altivec >> is not tested. performance for unsigned long arithmetic >> is unchanged. >> >> Signed-off-by: Peter Lieven >> --- >> util/cutils.c |7 +++ >

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 16:54 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> include/qemu-common.h |2 ++ >> util/cutils.c | 40 >> 2 files changed, 42 insertions(+) >> > >> >> +#define

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
On 19.03.2013 12:18, Paolo Bonzini wrote: Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Has anyone tested if -spice is wor

[Qemu-devel] kvm suspend performance

2013-03-19 Thread Thomas Knauth
Dear all, lately I've been playing around with qemu's/kvm's suspend (to disk) and resume. My initial expectation was that both operations are I/O bound. So it surprised me to see that suspend to disk seems to be CPU-bound. Suspending a VM with 1.5 GB memory takes 55 seconds. This works out to less

[Qemu-devel] [PATCH] target-i386: Fix flags computation for ADOX

2013-03-19 Thread Richard Henderson
When starting from CC_OP_DYNAMIC, and issuing adox before adcx, a typo used the wrong value for the resulting CC_OP. Cc: Blue Swirl Reported-by: Torbjorn Granlund Signed-off-by: Richard Henderson --- target-i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ta

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Eric Blake
On 03/19/2013 10:18 AM, Peter Lieven wrote: > > Am 19.03.2013 um 16:54 schrieb Eric Blake : > >> On 03/15/2013 09:50 AM, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >>> --- >>> include/qemu-common.h |2 ++ >>> util/cutils.c | 40 >>> 2

Re: [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > this patch adds the usage of buffer_find_nonzero_offset() > to skip large areas of zeroes. > > compared to loop unrolling presented in an earlier > patch this adds another 50% performance benefit for > skipping large areas of zeroes. loop unrolling alo

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 16:13, Stefano Stabellini ha scritto: > This patch only impacts the PV backend in QEMU, not the IDE interface. > PV frontends and backends always disconnect and reconnect during > save/restore. > So we can be *certain* that bdrv_close at the sender side is called > before the new conn

Re: [Qemu-devel] [PATCHv2 5/9] migration: search for zero instead of dup pages

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > virtually all dup pages are zero pages. remove > the speical is_dup_page() function and use the s/speical/special/ > optimized buffer_is_zero() function instead. > > Signed-off-by: Peter Lieven > --- > arch_init.c | 17 + > 1 file

[Qemu-devel] [PATCH 1/1] microblaze: Ignore non-cpu accesses to unmapped areas

2013-03-19 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-microblaze/op_helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-microblaze/op_helper.c b/target-microblaze/op_helper.c index 1c62f3c..f2cb88b 100644 --- a/target-microblaze/op_helper.c +++

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Paolo Bonzini wrote: > Il 19/03/2013 16:13, Stefano Stabellini ha scritto: > > This patch only impacts the PV backend in QEMU, not the IDE interface. > > PV frontends and backends always disconnect and reconnect during > > save/restore. > > So we can be *certain* that bdrv_clos

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 16:54, Peter Lieven ha scritto: > On 19.03.2013 12:18, Paolo Bonzini wrote: >> Il 19/03/2013 09:51, Markus Armbruster ha scritto: >>> Paolo, please have a look. >> Why isn't it enough to call bdrv_init_with_whitelist earlier? >> >> There is no conditional logic in it, the whitelist is

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
Allowing QEMU to swap due to a cgroup limit during migration is a viable overcommit option? I'm trying to keep an open mind, but that would kill the migration time. - Michael On 03/19/2013 11:36 AM, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 11:32:49AM -0400, Michael R. Hines wrote

Re: [Qemu-devel] Is is a bug? (window scale)

2013-03-19 Thread Peter Cheung
Sorry about the attachment size, i didn't look out the file size.Is here the right mailing list to report bug? or the team have something like bugzilla? Thanksfrom Peter > Date: Mon, 18 Mar 2013 17:36:15 -0600 > From: ebl...@redhat.com > To: mcheun...@hotmail.com > CC: qemu-devel@nongnu.org > Su

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 18:09, Michael R. Hines ha scritto: > Allowing QEMU to swap due to a cgroup limit during migration is a viable > overcommit option? > > I'm trying to keep an open mind, but that would kill the migration > time. Would it swap? Doesn't the kernel back all zero pages with a single

[Qemu-devel] OOM don't like qemu-kvm

2013-03-19 Thread Peter Cheung
Hi AllMy compuer is i7 with 32 GB ram without swap, i try to launch 28 vm with 1GB ram each, it runs smoothly.If I launch 64 VMs, after the VMs eat up all the memory, the linux hang. If the linux is lack of memory, the OOM will try to kill process, right? And the OOM should pick those qemu-k

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Fabien Chouteau
On 03/19/2013 04:23 PM, Peter Maydell wrote: > On 19 March 2013 15:14, Fabien Chouteau wrote: >> I can if I include helper.h, unfortunately this file is named helpers.h >> (note the 's') for m68k so I wont be able to include it for all >> platforms. > > The way we do this on ARM for cpsr_read is:

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Peter Maydell
On 19 March 2013 17:20, Fabien Chouteau wrote: > On 03/19/2013 04:23 PM, Peter Maydell wrote: >> The way we do this on ARM for cpsr_read is: >> * cpsr_read() is defined in target-arm/cpu.h >> * gdbstub.c calls cpsr_read() >> * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read() >> * help

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 06:14:45PM +0100, Paolo Bonzini wrote: > Il 19/03/2013 18:09, Michael R. Hines ha scritto: > > Allowing QEMU to swap due to a cgroup limit during migration is a viable > > overcommit option? > > > > I'm trying to keep an open mind, but that would kill the migration > > time

Re: [Qemu-devel] [PATCHv2 6/9] migration: add an indicator for bulk state of ram migration

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > the first round of ram transfer is special since all pages > are dirty and thus all memory pages are transferred to > the target. this patch adds a boolean variable to track > this stage. > > Signed-off-by: Peter Lieven > --- > arch_init.c |3 +++

Re: [Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > during bulk stage of ram migration if a page is a > zero page do not send it at all. > the memory at the destination reads as zero anyway. > > even if there is an madvise with QEMU_MADV_DONTNEED > at the target upon receival of a zero page I have obser

Re: [Qemu-devel] [PATCHv2 8/9] migration: do not search dirty pages in bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > avoid searching for dirty pages just increment the > page offset. all pages are dirty anyway. > > Signed-off-by: Peter Lieven > --- > arch_init.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch_init.c b/

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
OK, so I did a quick test and the cgroup does appear to be working correctly for zero pages. Nevertheless, this still doesn't solve the chunk registration problem for RDMA. Even with a cgroup on the sender *or* receiver side, there is no API that I know that would correctly indicate to the m

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Markus Armbruster
Gerd Hoffmann writes: > chardev flow control broke monitor, fix it by adding watch support. > > Signed-off-by: Gerd Hoffmann > --- > v2: fix tyops > --- Subject lacks v2. Anthony, holler if you want a respin to unconfuse your tools.

[Qemu-devel] [PATCH V2] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Fabien Chouteau
Although the support of this register may be uncomplete, there are no reason to prevent the debugger from reading or writing it. Signed-off-by: Fabien Chouteau --- gdbstub.c |3 ++- target-ppc/cpu.h|2 ++ target-ppc/fpu_helper.c |5 + target-ppc/

Re: [Qemu-devel] [PATCHv2 9/9] migration: use XBZRLE only after bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > at the beginning of migration all pages are marked dirty and > in the first round a bulk migration of all pages is performed. > > currently all these pages are copied to the page cache regardless > if there are frequently updated or not. this doesn't m

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > Specify -drive file.option=... on the command line to pass the option to > the protocol instead of the format driver. > > Signed-off-by: Kevin Wolf > --- > block.c | 63 --- > 1 file changed,

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
I also did a test using RDMA + cgroup, and the kernel killed my QEMU :) So, infiniband is not smart enough to know how to avoid pinning a zero page, I guess. - Michael On 03/19/2013 01:14 PM, Paolo Bonzini wrote: Il 19/03/2013 18:09, Michael R. Hines ha scritto: Allowing QEMU to swap due to

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 18:40, Michael R. Hines ha scritto: > registration scheme would not work with cgroups because we would be > attempting to pin zero pages (for no reason) that cgroups has already > kicked out, which would defeat the purpose of using cgroups. Yeah, pinning would be a problem. > So, i

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-03-19 Thread Gleb Natapov
On Thu, Mar 14, 2013 at 04:15:10AM +, Matthew Anderson wrote: > Thanks for the suggestion but so far it hasn't made any difference. > > I thought I may be an issue with the mainline kernel I was using so I changed > over to Ubuntu 12.10 and QEMU 1.2.0. Stability is slightly better but I still

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
On 03/19/2013 01:52 PM, Paolo Bonzini wrote: So, if I submit a separate patch to fix this, would you guys review it? (Using /dev/pagemap). Sorry about the ignorance, but what is /dev/pagemap? :) /dev/pagemap is a recent interface for eserland accesses to the pagetables. https://www.kernel.org/d

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Kevin Wolf
Am 19.03.2013 um 18:48 hat Eric Blake geschrieben: > On 03/18/2013 11:23 AM, Kevin Wolf wrote: > > Specify -drive file.option=... on the command line to pass the option to > > the protocol instead of the format driver. > > > > Signed-off-by: Kevin Wolf > > --- > > block.c | 63 > > +

Re: [Qemu-devel] [Bug 1156313] [NEW] X86-64 flags handling broken

2013-03-19 Thread Richard Henderson
On 03/17/2013 12:34 PM, Torbjorn Granlund wrote: > Public bug reported: > > The current qemu sources cause improper handling of flags on x86-64. > This bug seems to have shown up a few weeks ago. > > A plain install of Debian GNU/Linux makes user processes catch > spurious signals. The kernel se

[Qemu-devel] [PATCH 2/2] pflash_cfi01: Implement migration support

2013-03-19 Thread Peter Maydell
Add a vmstate to pflash_cfi01, so that it can be live migrated. XXX this device is in pc, so does this break cross version migration??? Signed-off-by: Peter Maydell --- hw/pflash_cfi01.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/pflash_cfi01.

Re: [Qemu-devel] [PATCH V2 0/3] ARM: Misc ARM big-endian bug fixes

2013-03-19 Thread Richard Henderson
On 03/19/2013 04:30 AM, Peter Maydell wrote: > (As an aside, perhaps we should generate the list in qapi-schema.json > automatically rather than hardcoding every target name? dunno) Definitely. It took me quite a while to find this when updating my spu target emulator a while back. r~

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Michael R. Hines
On 03/19/2013 10:22 AM, Paolo Bonzini wrote: Il 19/03/2013 15:10, Michael R. Hines ha scritto: On 03/19/2013 09:45 AM, Paolo Bonzini wrote: This is because of downtime: You have to drain the queue anyway at the very end, and if you don't drain it in advance after each iteration, then the queue

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Richard Henderson
On 03/19/2013 10:20 AM, Fabien Chouteau wrote: > Cleaner solution indeed. I'll do the opposite, store_fpscr calls > helper_store_fpscr. The declarations won't be in the right places for that to work right. Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading "cpu_" prefix,

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 19:27, Michael R. Hines ha scritto: >>> >> That however gives me an idea... Instead of the full drain at the end >> of an iteration, does it make sense to do a "partial" drain at every >> chunk full, so that you don't have > N bytes pending and the downtime is >> correspondingly limi

[Qemu-devel] [PATCH 1/2] pflash_cfi01: Drop unused 'bypass' field

2013-03-19 Thread Peter Maydell
For pflash_cfi01 the 'bypass' field is set to zero and never changes, so remove it (it is a leftover from pflash_cfi02, where bypass is implemented). Signed-off-by: Peter Maydell --- hw/pflash_cfi01.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/pflash_cfi0

[Qemu-devel] [PATCH 0/2] Implement migration support for pflash_cfi01

2013-03-19 Thread Peter Maydell
These patches implement migration support for pflash_cfi01. The first patch just drops some useless state so we don't have to think about it for migration. NB that pflash_cfi01 is used in the x86 pc model. I think this means that migration while the BIOS is accessing the flash wouldn't have worked

Re: [Qemu-devel] [PATCH] char: Fix return type of qemu_chr_fe_add_watch()

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix compile failures introduced by recent console changes

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Markus Armbruster writes: > Gerd Hoffmann writes: > >> chardev flow control broke monitor, fix it by adding watch support. >> >> Signed-off-by: Gerd Hoffmann >> --- >> v2: fix tyops >> --- > > Subject lacks v2. Anthony, holler if you want a respin to unconfuse > your tools. I already processe

Re: [Qemu-devel] [PATCH v3] add a boot option to do strict boot

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH] target-i386: Don't modify env->eflags around cpu_dump_state

2013-03-19 Thread Richard Henderson
We can compute the value in cpu_dump_state anyway, and gratuitous modifications to eflags creates heisenbugs. Cc: Blue Swirl Signed-off-by: Richard Henderson --- cpu-exec.c | 3 --- target-i386/helper.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/cpu-exec.c b

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Alex Bligh
Stefano, George, This patch only impacts the PV backend in QEMU, not the IDE interface. PV frontends and backends always disconnect and reconnect during save/restore. So we can be *certain* that bdrv_close at the sender side is called before the new connection is established at the receiver side

Re: [Qemu-devel] [PATCHv2 8/9] migration: do not search dirty pages in bulk stage

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:40 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> avoid searching for dirty pages just increment the >> page offset. all pages are dirty anyway. >> >> Signed-off-by: Peter Lieven >> --- >> arch_init.c | 12 +--- >> 1 file changed, 9 insertions

Re: [Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:36 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> during bulk stage of ram migration if a page is a >> zero page do not send it at all. >> the memory at the destination reads as zero anyway. >> >> even if there is an madvise with QEMU_MADV_DONTNEED >> a

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > Il 19/03/2013 16:54, Peter Lieven ha scritto: >> On 19.03.2013 12:18, Paolo Bonzini wrote: >>> Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. >>> Why isn't it enough to call bdrv_init_with_whitelist earlier? >>>

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Eric Blake
On 03/19/2013 12:05 PM, Kevin Wolf wrote: > Am 19.03.2013 um 18:48 hat Eric Blake geschrieben: >> On 03/18/2013 11:23 AM, Kevin Wolf wrote: >>> Specify -drive file.option=... on the command line to pass the option to >>> the protocol instead of the format driver. >>> >>> Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:49 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> this patch adds the usage of buffer_find_nonzero_offset() >> to skip large areas of zeroes. >> >> compared to loop unrolling presented in an earlier >> patch this adds another 50% performance benefit for

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:43 schrieb Eric Blake : > On 03/19/2013 10:18 AM, Peter Lieven wrote: >> >> Am 19.03.2013 um 16:54 schrieb Eric Blake : >> >>> On 03/15/2013 09:50 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven --- include/qemu-common.h |2 ++ util/cutils.c

[Qemu-devel] [PATCH v3] NVMe: Initial commit

2013-03-19 Thread Keith Busch
Initial commit for emulated nvme pci device. Implements the minimum from the specification to work with existing drivers. Cc: Keith Busch Signed-off-by: Keith Busch Just going for the simplest patch possible for this device. If this is okay, the remainining features implementing the full specif

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:08 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> performance gain on SSE2 is approx. 20-25%. altivec >> is not tested. performance for unsigned long arithmetic >> is unchanged. >> >> Signed-off-by: Peter Lieven >> --- >> util/cutils.c |7 +++ >

[Qemu-devel] [PATCH 0/2] Fix display resize bugs introduced after recent console revamp

2013-03-19 Thread Igor Mitsyanko
Bad things were happening in display update functions every time a screen has to be resized. Igor Mitsyanko (2): exynos4210_fimd.c: fix display resize bug introduced after console revamp hw/vmware_vga.c: fix screen resize bug introduced after console revamp hw/exynos4210_fimd.c |

[Qemu-devel] [PATCH 2/2] hw/vmware_vga.c: fix screen resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko --- hw/vmware_vga.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-

[Qemu-devel] [PATCH 1/2] exynos4210_fimd.c: fix display resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
In exynos4210 display update function, we were acquiring DisplaySurface pointer before calling screen resize function, not paying attention that resize procedure can replace current DisplaySurface with newly allocated one. Right thing to do is to initialize DisplaySurface AFTER a call to resize fu

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Alexander Graf
On 19.03.2013, at 19:32, Richard Henderson wrote: > On 03/19/2013 10:20 AM, Fabien Chouteau wrote: >> Cleaner solution indeed. I'll do the opposite, store_fpscr calls >> helper_store_fpscr. > > The declarations won't be in the right places for that to work right. > > Canonically, cpu_store_fps

[Qemu-devel] [PATCH] pcie: Add endpoint capability initialization wrapper

2013-03-19 Thread Alex Williamson
Fix the awkward API of mangling the caller specified PCIe type and just provide an interface to initialize an endpoint device. This will pick either a regular endpoint or integrated endpoint based on the bus and return pcie_cap_init to doing exactly what is asked. Signed-off-by: Alex Williamson

Re: [Qemu-devel] [PATCH 03/11] qemu-socket: Make socket_optslist public

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > Allow other users to create the QemuOpts needed for inet_connect_opts(). > > Signed-off-by: Kevin Wolf > --- > include/qemu/sockets.h | 2 ++ > util/qemu-sockets.c| 22 +++--- > 2 files changed, 13 insertions(+), 11 deletions(-) >

<    1   2   3   >