On 19 March 2013 17:20, Fabien Chouteau <chout...@adacore.com> wrote: > On 03/19/2013 04:23 PM, Peter Maydell wrote: >> The way we do this on ARM for cpsr_read is: >> * cpsr_read() is defined in target-arm/cpu.h >> * gdbstub.c calls cpsr_read() >> * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read() >> * helper.h declares HELPER(cpsr_read) as usual >> >> I'm not sure you want to include helper.h. >> > > Cleaner solution indeed. I'll do the opposite, store_fpscr > calls helper_store_fpscr.
I think that way round is kind of backwards personally (HELPER functions are for TCG generated code to call) but it doesn't make much difference really. -- PMM
