On 03/19/2013 04:23 PM, Peter Maydell wrote: > On 19 March 2013 15:14, Fabien Chouteau <chout...@adacore.com> wrote: >> I can if I include helper.h, unfortunately this file is named helpers.h >> (note the 's') for m68k so I wont be able to include it for all >> platforms. > > The way we do this on ARM for cpsr_read is: > * cpsr_read() is defined in target-arm/cpu.h > * gdbstub.c calls cpsr_read() > * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read() > * helper.h declares HELPER(cpsr_read) as usual > > I'm not sure you want to include helper.h. >
Cleaner solution indeed. I'll do the opposite, store_fpscr calls helper_store_fpscr. Thanks, -- Fabien Chouteau
