Here are the remaining patches. Interdiff at the end of this cover
letter.
Thanks,
Paolo
Paolo Bonzini (4):
mirror: switch mirror_iteration to AIO
mirror: add buf-size argument to drive-mirror
mirror: support more than one in-flight AIO operation
mirror: support arbitrarily-sized iterat
Yet another optimization is to extend the mirroring iteration to include more
adjacent dirty blocks. This limits the number of I/O operations and makes
mirroring efficient even with a small granularity. Most of the infrastructure
is already in place; we only need to put a loop around the computat
Hi Anthony,
Thanks for your review. Resubmit this series with your comments
squashed in. I will push console command part in another thread.
Thanks.
This patch series attempts to add new char backend CirMemCharDriver with
a circular buffer and expose it to users by introducing QMP interface
me
Hi,
Background-
I am trying win2008/Linux installation & boot on QEMU+ OVMF, but bootloader
app was crashing so i started doing this experiment with other Images and
landed here.
When I debugged it, I learnt that crash is in CoreStartImage() at
Image->EntryPoint ().
Experiment-
When I duplicate a
Signed-off-by: Lei Li
---
qemu-char.c | 120 +++
qemu-options.hx | 10 +
2 files changed, 130 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 9ba0573..b323e94 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -
Signed-off-by: Lei Li
---
hmp-commands.hx | 19 ++
hmp.c| 17
hmp.h|1 +
qapi-schema.json | 25 +++
qemu-char.c | 57 ++
qmp-commands.hx | 34 +
This makes sense when the next commit starts using the extra buffer space
to perform many I/O operations asynchronously.
Signed-off-by: Paolo Bonzini
---
block/mirror.c | 8
blockdev.c | 9 -
hmp.c | 2 +-
include/block/block_i
With AIO support in place, we can start copying more than one chunk
in parallel. This patch introduces the required infrastructure for
this: the buffer is split into multiple granularity-sized chunks,
and there is a free list to access them.
Because of copy-on-write, a single operation may alread
There is really no change in the behavior of the job here, since
there is still a maximum of one in-flight I/O operation between
the source and the target. However, this patch already introduces
the AIO callbacks (which are unmodified in the next patch)
and some of the logic to count in-flight ope
Hi all,
We add new entries for qemu/configure(QEMU v1.3.0), which
can locate our libraries and header files to compile our driver
for QEMU. The new entries in qemu/configure are like following.
[...]
2828 ##
2829 # hlfs probe
2830 echo "Entering HLFS probe.
Signed-off-by: Lei Li
---
hmp-commands.hx | 16
hmp.c| 13 +
hmp.h|1 +
qapi-schema.json | 41 +
qemu-char.c | 48
qmp-commands.hx | 3
21.01.2013 22:58, Michael Tokarev wrote:
We in debian talked about splitting qemu-system into
individual target packages for a long time, and there's
a patch (almost current) to support it, in qemu-system-split-mjt
branch of qemu debian git tree (I'll refresh it hopefully
today).
[...]
Heck. T
> > > If I reset/suspend/resume/ the VM during a backup job run I get:
> > >
> > > block.c:1221: bdrv_drain_all: Assertion
> > > `((&bs->tracked_requests)->lh_first
> > == ((void *)0))' failed.
> > > Aborted
> > >
> > > I am not 100% sure, but I think a simple qemu_aio_wait() is not
> > > enough
>
On Mon, Jan 21, 2013 at 02:16:35PM +0200, Dmitry Fleytman wrote:
> I've checked origin of headers, some of them are self-made, other came from
> following places:
> 1. file rtl8139.c from QEMU codebase
> 2. /usr/include/netinet/ip6.h from glibc
> 3. /usr/include/netinet/in.h from glibc
On 23.11.2012 12:01, Michael S. Tsirkin wrote:
On Fri, Nov 23, 2012 at 10:41:21AM +0100, Peter Lieven wrote:
Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi:
On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote:
is anyone aware of a problem with the linux network bridge that in very r
Am 22.01.2013 09:03, schrieb Paolo Bonzini:
> Here are the remaining patches. Interdiff at the end of this cover
> letter.
>
> Thanks,
>
> Paolo
>
> Paolo Bonzini (4):
> mirror: switch mirror_iteration to AIO
> mirror: add buf-size argument to drive-mirror
> mirror: support more than one
On Mon, Jan 21, 2013 at 12:15:51PM +0100, Paolo Bonzini wrote:
> Il 21/01/2013 11:17, Kevin Wolf ha scritto:
> > Am 18.01.2013 18:33, schrieb Paolo Bonzini:
> >>
> >>> Am 18.01.2013 17:22, schrieb Paolo Bonzini:
> I haven't written a testcase for it, it's tricky but should be
> doable.
>
On Mon, Jan 21, 2013 at 09:23:28AM +0900, MORITA Kazutaka wrote:
> diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
> index 1542e43..abc6662 100644
> --- a/slirp/tcp_subr.c
> +++ b/slirp/tcp_subr.c
> @@ -429,8 +429,7 @@ tcp_connect(struct socket *inso)
> setsockopt(s,SOL_SOCKET,SO_REUSEADDR,(
On Mon, Jan 21, 2013 at 09:23:27AM +0900, MORITA Kazutaka wrote:
> This series adds support for a unix domain socket for a connection
> between qemu and local sheepdog server. The first two patches are
> cleanups for the third patch.
>
> Changes from v1:
> - split patch for easy review
> - move
On 22.01.2013 10:04, Peter Lieven wrote:
On 23.11.2012 12:01, Michael S. Tsirkin wrote:
On Fri, Nov 23, 2012 at 10:41:21AM +0100, Peter Lieven wrote:
Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi:
On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote:
is anyone aware of a problem wi
Am 21.01.2013 17:09, schrieb Paolo Bonzini:
> HBitmaps provides an array of bits. The bits are stored as usual in an
> array of unsigned longs, but HBitmap is also optimized to provide fast
> iteration over set bits; going from one bit to the next is O(logB n)
> worst case, with B = sizeof(long) *
On Mon, Jan 21, 2013 at 11:42:54PM +, Peter Maydell wrote:
> There seems to be something wrong with the dependencies
> or makefile runes for some of the trace infrastructure.
>
> For example:
> pm215@canth:~/src/qemu/qemu$ less trace/generated-tracers.c
> /* This file is autogenerated by trace
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
qemu-log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-log.c b/qemu-log.c
index b655b30..64a1b88 100644
--- a/qemu-log.c
+++ b/qemu-log.c
@@ -84,7 +84,7 @@ void qemu_set_log(int log_flags, bool use_own_buff
Once upon a time, it was decided that qemu_malloc(0) should abort.
Switching to glib retired that bright idea. Some code that was added
to cope with it (e.g. in commits 702ef63, b76b6e9) is still around.
Bury it.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
block/qcow2-refcount
> > > Are you using timers in any way?
> >
> > Yes, I call co_sleep_ns(rt_clock, delay) to limit rate to output
> > stream.
>
> Use block_job_sleep_ns instead, and only call it when no I/O is pending.
Thanks, that works!
On 22 January 2013 10:00, Stefan Hajnoczi wrote:
> On Mon, Jan 21, 2013 at 11:42:54PM +, Peter Maydell wrote:
>> I have no idea whether we can make qemu's build process more
>> resistant to that kind of diachronic change, but I mention it
>> anyway :-)
>
> Yes, this is an annoying weakness in
On Mon, Jan 21, 2013 at 05:44:34PM +0800, harryxiyou wrote:
> On Mon, Jan 21, 2013 at 5:07 PM, Andreas Färber wrote:
> >
> > There's a patch queued on qemu-trivial:
> > http://patchwork.ozlabs.org/patch/213610/
> >
> > Would be nice to get this applied soon, it looks annoying but is not to
> > wor
Hi,
This is the usb patch queue. Unbreaks usb-storage. Little ohci fix.
Adds a usb-storage variant which is exposed as real scsi controller
(i.e. no automagic scsi-* device, also brings multi-lun support).
please pull,
Gerd
The following changes since commit 1356b98d3e95a85071e6bf9a99e8799
This reverts commit a1cbfd554e11bb8af38c2f3e1f1574bf4c563cd2.
Test isn't useless. scsi_req_enqueue() may finish the request (will
actually happen for requests which don't trigger any I/O such as
INQUIRY), then call usb_msd_command_complete() which in turn will
set s->req to NULL after unref'ing i
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ohci.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 6a2f5f8..dd9967b 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1736,6 +1736,7 @@ static void ohci_mem_write(void *opaque,
/* PXA2
Markus Armbruster writes:
> Stefan Hajnoczi writes:
>
>> On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>> index 6eab7f7..74155fb 100644
>>> --- a/hw/9pfs/virtio-9p-device.c
>>> +++ b/hw/9pfs/virtio-9p-
Am 18.12.2012 10:46, schrieb Philipp Hahn:
> Hello Kevin, hello Michael,
>
> On Wednesday 12 December 2012 17:54:58 Kevin Wolf wrote:
>> Am 12.12.2012 15:09, schrieb Philipp Hahn:
>>> Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf:
As you can see in the commit message of that patch
Peter Maydell writes:
> On 22 January 2013 10:00, Stefan Hajnoczi wrote:
>> On Mon, Jan 21, 2013 at 11:42:54PM +, Peter Maydell wrote:
>>> I have no idea whether we can make qemu's build process more
>>> resistant to that kind of diachronic change, but I mention it
>>> anyway :-)
>>
>> Yes,
I figure it's freed somewhere deep down in QAPI, with g_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
qga/commands.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands.c b/qga/commands.c
index 7ffb35e..528b082 100644
--- a/qga/commands.c
+++
Basically the same as usb-storage, but without automatic scsi
device setup. Also features support for up to 16 LUNs.
Signed-off-by: Gerd Hoffmann
---
docs/usb-storage.txt | 11 +-
hw/usb/dev-storage.c | 94 ++
2 files changed, 89 insertion
On Tue, Jan 22, 2013 at 6:14 PM, Stefan Hajnoczi wrote:
[...]
> The fix is now in qemu.git/master.
Ok, thanks for your job.
--
Thanks
Harry Wei
Note: the allocation in virtio_9p_init() is still leaked. To be fixed
in a followup commit.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
hw/9pfs/virtio-9p-device.c | 2 +-
hw/9pfs/virtio-9p-local.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw
Ping^3?
This issue is still present in qemu 1.3 and current git (1.4-tobe) versions,
and the said commit is still revertable, and reverting it still fixes the
problem...
I wonder why only debian users suffer from this problem ;)
Thanks,
/mjt
12.11.2012 19:13, Michael Tokarev wrote:
Ping^2 ?
Note that we already free with g_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
qapi/qmp-registry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c
index 70cdbca..28bbbe8 100644
--- a/qapi/qmp-registry.c
+++ b/q
v3: const tweak suggested by stefanha in PATCH 08/11, rest identical
except 03/11's commit message mentions leak (thanks stefanha!)
v2: Windows compile fix in PATCH 08/11 (thanks eblake!), rest identical
Markus Armbruster (11):
g_malloc(0) and g_malloc0(0) return NULL; simplify
g_strdup(N
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
fsdev/virtfs-proxy-helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 6b9afd3..36f6616 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/v
From: Alon Levy
This is a simpler solution to 869981, where migration breaks since qxl's
rom bar size has changed. Instead of ignoring fields in QXLRom, which is what
has
actually changed, we remove some of the modes, a mechanism already
accounted for by the guest. The modes left allow for portr
From: Alon Levy
Signed-off-by: Alon Levy
Signed-off-by: Gerd Hoffmann
---
hw/qxl.c | 11 +++
trace-events |2 ++
2 files changed, 13 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 9dc44b9..0d81816 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -945,6 +945,12 @@ static void in
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
ui/spice-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3f2c565..bcc4199 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -848,8 +848,8 @@ static int qemu_spi
On Mon, Jan 21, 2013 at 05:08:26PM +0100, Stefan Hajnoczi wrote:
> On Sat, Jan 19, 2013 at 09:54:27AM +0800, ak...@redhat.com wrote:
> > @@ -350,6 +351,18 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t
> > cmd,
> > struct virtio_net_ctrl_mac mac_data;
> > size_t s;
> >
> > +
Signed-off-by: Markus Armbruster
---
qemu-log.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/qemu-log.c b/qemu-log.c
index 64a1b88..30c9ab0 100644
--- a/qemu-log.c
+++ b/qemu-log.c
@@ -21,10 +21,12 @@
#include "qemu/log.h"
#ifdef WIN32
-static const char
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
hw/9pfs/virtio-9p-device.c | 6 +-
hw/block-common.c | 4 +---
net/net.c | 4 +---
slirp/slirp.c | 8 ++--
util/qemu-option.c | 8 ++--
5 files changed, 7 insertions(+), 23 del
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
readline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/readline.c b/readline.c
index a0c9638..d6e04d4 100644
--- a/readline.c
+++ b/readline.c
@@ -247,14 +247,14 @@ static void readline_hist_add(ReadLineStat
Hi,
Here comes the spice patch queue with two little bugfixes for qxl.
please pull,
Gerd
The following changes since commit 1356b98d3e95a85071e6bf9a99e8799e1ae1bbee:
sysbus: Drop sysbus_from_qdev() cast macro (2013-01-21 13:52:24 -0600)
are available in the git repository at:
git://an
Note that we already free with g_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
libcacard/vcard_emul_nss.c | 4 ++--
libcacard/vreader.c| 2 +-
libcacard/vscclient.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libcacard/vcard_emul_
Gerd Hoffmann writes:
> This reverts commit a1cbfd554e11bb8af38c2f3e1f1574bf4c563cd2.
>
> Test isn't useless. scsi_req_enqueue() may finish the request (will
> actually happen for requests which don't trigger any I/O such as
> INQUIRY), then call usb_msd_command_complete() which in turn will
> s
This is another unexpected result of eac236ea7bfc1902126be70459e320591078df5c,
which happens often when bisecting between v1.3.0 and current git master.
Before the said commit, trace.c and trace.h files were generated in the
build dir. Now trace.c has moved to include/trace.h and it acts just
as
Hi,
Thank you for submitting your patch series. checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.
If you believe this message was sent in error, please ignore it
or respond here with an explanation.
Otherwise, please correct the coding styl
Hi,
Thank you for submitting your patch series. This note is to inform
you that this patch series no longer applies against the latest
qemu.git tree.
If it's been at least a few days since you submitted this series,
please resubmit a new version of your patch series so it can be
considered for i
> make check failed for me, and it turns out it was because
> MALLOC_CHECK_=3 was set. Look:
>
> $ valgrind tests/test-hbitmap
> ==5964== Memcheck, a memory error detector
> ==5964== Copyright (C) 2002-2010, and GNU GPL'd, by Julian Seward et
> al.
> ==5964== Using Valgrind-3.6.1 and LibVEX; rerun
On 01/22/13 11:25, Kevin Wolf wrote:
> Am 18.12.2012 10:46, schrieb Philipp Hahn:
>> Hello Kevin, hello Michael,
>>
>> On Wednesday 12 December 2012 17:54:58 Kevin Wolf wrote:
>>> Am 12.12.2012 15:09, schrieb Philipp Hahn:
Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf:
> As you
On 22/01/2013 11:23, Markus Armbruster wrote:
Markus Armbruster writes:
Stefan Hajnoczi writes:
On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 6eab7f7..74155fb 100644
--- a/hw/9pfs/virtio-9p-devi
Here is a follow-up for the failure that Kevin reported.
Paolo Bonzini (2):
mirror: do nothing on zero-sized disk
hbitmap: add assertion on hbitmap_iter_init
block/mirror.c | 2 +-
include/qemu/hbitmap.h | 3 ++-
tests/test-hbitmap.c | 13 +++--
util/hbitmap.c |
On a zero-sized disk we need to break out of the job successfully
before bdrv_dirty_iter_init is called, otherwise you will get an
assertion failure with the next patch.
Signed-off-by: Paolo Bonzini
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirr
hbitmap_iter_init causes an out-of-bounds access when the "first"
argument is or greater than or equal to the size of the bitmap.
Forbid this with an assertion, and remove the failing testcase.
Reported-by: Kevin Wolf
Signed-off-by: Paolo Bonzini
---
include/qemu/hbitmap.h | 3 ++-
tests/test-
Hello Qemu folks,
I'm sorry to be (very) late, but I do not agree with this patch.
Your modification just makes the "kill" command behave like "detach", so
why not use "detach" instead?
"kill" has its own semantic and it's important to keep it. So I suggest
we revert this patch.
Regards,
> Too
Am 22.01.2013 14:17, schrieb Laszlo Ersek:
> As I understand it, the question is not whether b7ab0fea works or not
> (it does), the question is whether *without* b7ab0fea there is a real
> problem (user visible bug).
Correct. Or actually not whether, but why.
> Commit b7ab0fea decreased "avail_se
Anthony,
The following changes since commit fedf2de31023b4ee71a4e578db013976243a8143:
Merge remote-tracking branch 'stefanha/trivial-patches' into staging
(2013-01-11 08:43:18 -0600)
are available in the git repository at:
git://github.com/bonzini/qemu.git scsi-next
for you to fetch chan
From: Peter Lieven
This patch adds support for bdrv_create. This allows e.g.
to use qemu-img to convert from any supported device to
an iscsi backed storage as destination.
Signed-off-by: Peter Lieven
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 52
From: Peter Lieven
libiscsi expects all write16 data in a linear buffer. If the
iovec only contains one buffer we can skip the linearization
step as well as the additional malloc/free and pass the
buffer directly.
Reported-by: Ronnie Sahlberg
Signed-off-by: Peter Lieven
Signed-off-by: Paolo Bo
From: Markus Armbruster
req was created by scsi_req_alloc(), which initializes req->dev to a
value it dereferences. req->dev isn't changed anywhere else.
Therefore, req->dev can't be null.
Drop the useless null test; it spooks Coverity.
Signed-off-by: Markus Armbruster
---
hw/scsi-bus.c | 2
Il 22/01/2013 13:19, Michael Tokarev ha scritto:
>
> And there's 3rd: just ignore this issue, since we can't improve git
> bisectability between 1.3 and 1.4 already, and it will be bisectable
> again past 1.4 (without new issues of the same sort).
Yes, just ignore this. Use a new out-of-tree bui
Il 22/01/2013 11:00, Stefan Hajnoczi ha scritto:
>> > I also just spent a long time trying to figure out why
>> > my MacOS system wouldn't build after a git pull; turns
>> > out that:
>> > (1) we used to have a generated trace.h and we don't any more
>> > (2) make distclean doesn't remove trace.h
>
From: Peter Lieven
This patch will send NOP-Out PDUs every 5 seconds to the iSCSI target.
If a consecutive number of NOP-In replies fail a reconnect is initiated.
iSCSI NOPs help to ensure that the connection to the target is still
operational.
This should not, but in reality may be the case eve
When a 0-sized disk is found, READ CAPACITY will return a
LUN NOT READY error. However, because it returns -1 instead
of zero, the HBA will call scsi_req_continue. This will
typically cause a segmentation fault or an assertion failure.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 4 ++--
On Mon, Jan 21, 2013 at 05:03:30PM +0100, Stefan Hajnoczi wrote:
> On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote:
> > From: "Michael S. Tsirkin"
> >
> > Virtio-net code makes assumption about virtqueue descriptor layout
> > (e.g. sg[0] is the header, sg[1] is the data buffer).
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 89c657f..860df32 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -1670,12 +1670,7 @@ static void lsi_reg_writeb(LSIState *s, int
On Tue, Jan 22, 2013 at 05:59:14AM +0100, Andreas Färber wrote:
> Am 22.01.2013 02:43, schrieb Marcelo Tosatti:
> > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote:
> >> Signed-off-by: Eduardo Habkost
> >> ---
> >> Cc: k...@vger.kernel.org
> >> Cc: Michael S. Tsirkin
> >> Cc: Gleb
Am 17.01.2013 21:45, schrieb Stefan Weil:
> These patches improve the error report if the file format was
> specified explicitly (example: -drive file=myfile,format=qcow2)
> and the given format does not match the real format.
>
> They fix those bugs:
>
> https://bugzilla.redhat.com/show_bug.cgi?
On 01/21/2013 04:43 PM, Marcelo Tosatti wrote:
> On Fri, Sep 28, 2012 at 10:05:09AM +0200, Jan Kiszka wrote:
>> On 2012-09-28 01:21, Satoru Moriya wrote:
>>> This is a first time for me to post a patch to qemu-devel.
>>> If there is something missing/wrong, please let me know.
>>>
>>> We have some
On Tue, Jan 22, 2013 at 10:38:14PM +0800, Amos Kong wrote:
> On Mon, Jan 21, 2013 at 05:03:30PM +0100, Stefan Hajnoczi wrote:
> > On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote:
> > > From: "Michael S. Tsirkin"
> > >
> > > Virtio-net code makes assumption about virtqueue descrip
Juan Quintela wrote:
> Hi
>
> Please send in any agenda topics you are interested in.
As there are no topics, no call Today.
See you next week.
Later, Juan.
On 2013-01-22 15:45, Satoru Moriya wrote:
> On 01/21/2013 04:43 PM, Marcelo Tosatti wrote:
>> On Fri, Sep 28, 2012 at 10:05:09AM +0200, Jan Kiszka wrote:
>>> On 2012-09-28 01:21, Satoru Moriya wrote:
This is a first time for me to post a patch to qemu-devel.
If there is something missing/
On Tue, Jan 22, 2013 at 03:27:26PM +0100, Paolo Bonzini wrote:
> Il 22/01/2013 11:00, Stefan Hajnoczi ha scritto:
> >> > I also just spent a long time trying to figure out why
> >> > my MacOS system wouldn't build after a git pull; turns
> >> > out that:
> >> > (1) we used to have a generated trace
On Tue, Jan 22, 2013 at 11:07:55AM +0100, Markus Armbruster wrote:
> v3: const tweak suggested by stefanha in PATCH 08/11, rest identical
> except 03/11's commit message mentions leak (thanks stefanha!)
>
> v2: Windows compile fix in PATCH 08/11 (thanks eblake!), rest identical
>
> Markus Arm
On 2013-01-22 15:04, Fabien Chouteau wrote:
> Hello Qemu folks,
>
> I'm sorry to be (very) late, but I do not agree with this patch.
>
> Your modification just makes the "kill" command behave like "detach", so
> why not use "detach" instead?
gdb automatically issues kill when you quite. This is
Am 18.01.2013 11:28, schrieb Stefan Hajnoczi:
> On Thu, Jan 17, 2013 at 11:01:52AM +0100, Kevin Wolf wrote:
>> Let's get Jason's patches merged while they still apply. I addressed the
>> review
>> comments (mostly my own) that came up during the v3 review, otherwise this is
>> unchanged.
>>
>> Ple
On 01/22/2013 07:01 AM, Paolo Bonzini wrote:
> Here is a follow-up for the failure that Kevin reported.
>
> Paolo Bonzini (2):
> mirror: do nothing on zero-sized disk
> hbitmap: add assertion on hbitmap_iter_init
>
> block/mirror.c | 2 +-
> include/qemu/hbitmap.h | 3 ++-
> tests/
- Original Message -
> On 01/09/2013 01:39 AM, Amos Kong wrote:
> > Current seabios will try to boot from selected devices first,
> > if they are all failed, seabios will also try to boot from
> > un-selected devices.
> >
> > We need to make it configurable. I already posted a seabios
> >
On 01/21/2013 02:56 PM, Anthony Liguori wrote:
>>> +ret=0
>>> +git log --format="%H %s" "$@" | while read LINE; do
>>> +commit="`echo $LINE | cut -f1 -d' '`"
>>> +subject="`echo $LINE | cut -f2- -d' '`"
>>> +echo "Subject: $subject"
>>
>> This won't work if $subject contains backslash.
KONRAD Frédéric writes:
> On 22/01/2013 11:23, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>>> Stefan Hajnoczi writes:
>>>
On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> index
At Tue, 22 Jan 2013 10:38:51 +0100,
Stefan Hajnoczi wrote:
>
> On Mon, Jan 21, 2013 at 09:23:27AM +0900, MORITA Kazutaka wrote:
> > This series adds support for a unix domain socket for a connection
> > between qemu and local sheepdog server. The first two patches are
> > cleanups for the third p
On Mon, Jan 21, 2013 at 07:35:22AM -0700, Eric Blake wrote:
> On 01/21/2013 06:14 AM, Andreas Färber wrote:
> >> glibc is already responsible from converting the 'unsigned long
> >> int' of the user declaration back into the 'unsigned int' that the
> >> kernel expects for the second argument. The
On Tue, Jan 22, 2013 at 10:23:32AM -0500, Amos Kong wrote:
> - Original Message -
> > On 01/09/2013 01:39 AM, Amos Kong wrote:
> > > Current seabios will try to boot from selected devices first,
> > > if they are all failed, seabios will also try to boot from
> > > un-selected devices.
> >
A correct mask should be `x & (1 << i)', rather than `x && (1 << i)'.
Also, in C99 signed shift (1 << 31) is undefined behavior, since the
result exceeds INT_MAX; use 1U instead.
Signed-off-by: Xi Wang
---
hw/openrisc_pic.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
From: Michael S. Tsirkin
Virtio-net code makes assumption about virtqueue descriptor layout
(e.g. sg[0] is the header, sg[1] is the data buffer).
This patch makes code not rely on the layout of descriptors.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Amos Kong
---
hw/virtio-net.c | 129
On Tue, Jan 22, 2013 at 4:43 PM, harryxiyou wrote:
> Hi all,
>
> We add new entries for qemu/configure(QEMU v1.3.0), which
> can locate our libraries and header files to compile our driver
> for QEMU. The new entries in qemu/configure are like following.
>
> [...]
> 2828 ##
In virtio-net guest driver, currently we write MAC address to
pci config space byte by byte, this means that we have an
intermediate step where mac is wrong. This patch introduced
a new control command to set MAC address, it's atomic.
VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibili
On Tue, 22 Jan 2013 16:12:50 +0800
Lei Li wrote:
> Signed-off-by: Lei Li
> ---
> qemu-char.c | 120
> +++
> qemu-options.hx | 10 +
> 2 files changed, 130 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
>
On Tue, 22 Jan 2013 16:12:51 +0800
Lei Li wrote:
> Signed-off-by: Lei Li
> ---
> hmp-commands.hx | 16
> hmp.c| 13 +
> hmp.h|1 +
> qapi-schema.json | 41 +
> qemu-char.c | 48 +++
On Tue, 22 Jan 2013 16:12:52 +0800
Lei Li wrote:
> Signed-off-by: Lei Li
> ---
> hmp-commands.hx | 19 ++
> hmp.c| 17
> hmp.h|1 +
> qapi-schema.json | 25 +++
> qemu-char.c | 57
> +
Help testing these patches is welcome.
Paolo Bonzini (1):
iscsi: do not leak acb->buf when commands are aborted
Peter Lieven (1):
iscsi: add support for iovectors
block/iscsi.c | 53 +++--
1 file changed, 43 insertions(+), 10 deletions(-)
--
acb->buf is freed in the WRITE(16) callback, but this may not
get called at all when commands are aborted. Add another
free in the ABORT TASK callback, which requires setting acb->buf
to NULL everywhere.
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 8 +++-
1 file changed, 7 insertions(+
On 01/22/2013 08:52 AM, Amos Kong wrote:
>>>
>>> Libvirt will need to expose an attribute that lets the user control
>>> whether to use this new option; how do we probe via QMP whether the
>>> new
>>> -boot strict=on command-line option is available?
>>
>> Hi all,
>>
>> How about add new info/quer
From: Peter Lieven
This patch adds support for directly passing the iovec
array from QEMUIOVector if libiscsi supports it.
Signed-off-by: Peter Lieven
[Preserve the improvements from commit 4cc841b, iscsi: partly
avoid iovec linearization in iscsi_aio_writev, 2012-11-19 - Paolo]
Signed-off-by:
1 - 100 of 174 matches
Mail list logo
