On Tue, Jan 22, 2013 at 05:59:14AM +0100, Andreas Färber wrote: > Am 22.01.2013 02:43, schrieb Marcelo Tosatti: > > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: > >> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > >> --- > >> Cc: k...@vger.kernel.org > >> Cc: Michael S. Tsirkin <m...@redhat.com> > >> Cc: Gleb Natapov <g...@redhat.com> > >> Cc: Marcelo Tosatti <mtosa...@redhat.com> > >> --- > >> include/sysemu/kvm.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > >> index 6bdd513..22acf91 100644 > >> --- a/include/sysemu/kvm.h > >> +++ b/include/sysemu/kvm.h > >> @@ -36,6 +36,7 @@ > >> #define KVM_FEATURE_ASYNC_PF 0 > >> #define KVM_FEATURE_STEAL_TIME 0 > >> #define KVM_FEATURE_PV_EOI 0 > >> +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > >> #endif > >> > >> extern int kvm_allowed; > >> -- > >> 1.7.11.7 > >> > > > > ACK > > BTW is it the general strategy to add these as needed for new patches? > Or should we add all current ones and mandate adding such dummy > definitions when new ones get introduced via linux-headers/ update?
I meant to include all existing bits in a single patch previously, but somehow I missed the KVM_FEATURE_CLOCKSOURCE_STABLE_BIT definition when looking at the kernel header. It would be nice to automatically refresh the fake-defines list when updating linux-headers, but I won't mind if we update the list (pulling all existing bits again) only when QEMU starts using a define that is missing. -- Eduardo
