KONRAD Frédéric <fred.kon...@greensocs.com> writes: > On 22/01/2013 11:23, Markus Armbruster wrote: >> Markus Armbruster <arm...@redhat.com> writes: >> >>> Stefan Hajnoczi <stefa...@gmail.com> writes: >>> >>>> On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote: >>>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c >>>>> index 6eab7f7..74155fb 100644 >>>>> --- a/hw/9pfs/virtio-9p-device.c >>>>> +++ b/hw/9pfs/virtio-9p-device.c >>>>> @@ -94,7 +94,7 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf >>>>> *conf) >>>>> exit(1); >>>>> } >>>>> - s->tag = strdup(conf->tag); >>>>> + s->tag = g_strdup(conf->tag); >>>>> s->ctx.uid = -1; >>>>> s->ops = fse->ops; >>>> s->tag is leaked. Want to send a follow-up patch to g_free() it? >>> I'll give it a try. >> Mind if I wait for Fred Konrad's virtio refactoring to settle? It >> should make the fix easier, and avoid getting into his way with >> pointless conflicts. > Hi, > > Maybe it's due to missing exit function? > > Do you want me to add an exit function to g_free this conf->tag?
Yes, please!
