Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-21 Thread Andreas Färber
Am 17.01.2013 16:16, schrieb Igor Mammedov: > Vendor property setter takes string as vendor value but cpudefs > use uint32_t vendor[123] fields to define vendor value. It makes it > difficult to unify and use property setter for values from cpudefs. > > Simplify code by using vendor property sette

[Qemu-devel] [PATCH v2] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

2013-01-21 Thread Stefan Weil
STATUS_TIMEOUT is defined in winnt.h: CChw/tpci200.o hw/tpci200.c:34:0: warning: "STATUS_TIMEOUT" redefined [enabled by default] /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0: note: this is the location of the previous definition Use STATUS_TIME

[Qemu-devel] [PULL for-1.4 0/1] seabios: update to 1.7.2 release

2013-01-21 Thread Gerd Hoffmann
Hi, Seabios 1.7.2 has just been released, let's update from our git snapshot to the final release. please pull, Gerd Gerd Hoffmann (1): seabios: update to 1.7.2 release pc-bios/acpi-dsdt.aml | Bin 4521 -> 4521 bytes pc-bios/bios.bin | Bin 131072 -> 262144 bytes pc-bios/q

[Qemu-devel] [PATCH 1/1] seabios: update to 1.7.2 release

2013-01-21 Thread Gerd Hoffmann
Not that many changes as we have a pretty recent git snapshot in master already: Hannes Reinecke (1): megasas: Invert PCI device selection Kevin O'Connor (2): Minor: Separate UUID display from F12 boot prompt. boot: Support "halt" in the boot order to prevent default boot attemp

Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000

2013-01-21 Thread Andreas Färber
Am 17.01.2013 16:16, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > --- > target-i386/cpu.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 333745b..ce914da 100644 > --- a/target

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-21 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 01:07:21PM -0800, Nicholas A. Bellinger wrote: > Hi MST & Co, > > On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: > > On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > Hello Anthony & Co, > > >

Re: [Qemu-devel] [PATCH v2 3/3] sheepdog: add support for connecting to unix domain socket

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 01:23, MORITA Kazutaka ha scritto: > This patch adds support for a unix domain socket for a connection > between qemu and local sheepdog server. You can use the unix domain > socket with the following syntax like NBD driver: > > $ qemu sheepdog:unix:: > > Note that must be an abs

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-21 Thread Kevin Wolf
Am 20.01.2013 16:54, schrieb Blue Swirl: > Recent Clang compilers have preliminary support for finding > unannotated fallthrough cases in switch statements with > compiler flag -Wimplicit-fallthrough. The support is incomplete, > it's only possible to annotate the case in C++ but not in C, so it >

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Drop OpenRISCCPUList

2013-01-21 Thread Andreas Färber
Am 16.01.2013 04:57, schrieb Andreas Färber: > It was missed in the previous cleanup because its naming did not match > the *CPUListState pattern. Use the generalized CPUListState instead. > > Signed-off-by: Andreas Färber No objections yet, so applied to qom-cpu (mentioning commit hash): https:

Re: [Qemu-devel] [QEMU]Install QEMU question

2013-01-21 Thread Andreas Färber
Hi, Am 21.01.2013 09:51, schrieb harryxiyou: > When i install QEMU in my Ubuntu 10.04, i happened to a > question, which i am not sure if it is ok for me to continue > to install QEMU. See > http://code.google.com/p/cloudxy/issues/detail?id=24 > for details. > > Could anyone give me some suggest

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-21 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 06:59:29PM -0200, Eduardo Habkost wrote: > Currently, the pc-1.4 machine init function enables PV EOI and then > calls the pc-1.2 machine init function. The problem with this approach > is that now we can't enable any additional compatibility code inside the > pc-1.2 init fu

[Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command

2013-01-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 16 hmp.c| 13 + hmp.h|1 + qapi-schema.json | 41 + qemu-char.c | 48 qmp-commands.hx | 3

[Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command

2013-01-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 19 ++ hmp.c| 17 hmp.h|1 + qapi-schema.json | 25 +++ qemu-char.c | 57 ++ qmp-commands.hx | 34 +

[Qemu-devel] [PATCH 4/4] HMP: Introduce console command

2013-01-21 Thread Lei Li
Signed-off-by: Lei Li --- hmp-commands.hx | 21 ++ hmp.c | 52 + hmp.h |1 + include/monitor/monitor.h |3 ++ monitor.c | 15 + 5 files changed,

[Qemu-devel] [RESEND PATCH for 1.4 v8 0/4] char: Add CirMemCharDriver and provide QMP interface

2013-01-21 Thread Lei Li
Hi Anthony, Since this patch series has already missed 1.3, I wonder if it can be merged into 1.4 release as it has been on mailing list for a long time, and I have rebased it again. Thanks. This patch series attempts to add new char backend CirMemCharDriver with a circular buffer and expose i

[Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

2013-01-21 Thread Lei Li
Signed-off-by: Lei Li --- qemu-char.c | 134 +++ qemu-options.hx | 10 2 files changed, 144 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9ba0573..950c543 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -9

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2013-01-21 Thread Janne Karhunen
Luke Kim: quite unlikely that above patch would cause the issue you see.. are you sure something else did not break in your environment? Can you execute that same make manually? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-21 Thread Stefan Hajnoczi
On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote: > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > > The viostor virtio-blk driver for Windows does not use the > > > VIRTIO_CONFIG_S_DRIVER bit.

[Qemu-devel] qmp drive-mirror vs qemu-img convert , drive-mirror really slow

2013-01-21 Thread Alexandre DERUMIER
Hi list, I'm doing some speed benchmark between drive-mirror vs qemu-img convert , and drive-mirror seem to be a lot slower. test: convert 1 32GB qcow2 file to raw file, local storage (6 disk 15k in raid10 + raid BBU cache) time result: qemu-img : 30sec drive-mirror (vm is paused, no write

Re: [Qemu-devel] [QEMU]Install QEMU question

2013-01-21 Thread harryxiyou
On Mon, Jan 21, 2013 at 5:07 PM, Andreas Färber wrote: > Hi, Hi Andreas, > > There's a patch queued on qemu-trivial: > http://patchwork.ozlabs.org/patch/213610/ > > Would be nice to get this applied soon, it looks annoying but is not to > worry about. > I see, thanks for your help ;-) -- Thank

Re: [Qemu-devel] [PATCH 1/4] ram: add free_space parameter to save_live functions

2013-01-21 Thread Orit Wasserman
On 01/18/2013 01:53 PM, Juan Quintela wrote: > As we really know how much space we have free in the buffers, we can > send that information instead of guessing how much we can sent each time. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 20 +--- > block-

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-21 Thread Michael S. Tsirkin
On Mon, Jan 21, 2013 at 10:36:18AM +0100, Stefan Hajnoczi wrote: > On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote: > > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > > > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > > > The viostor virtio-bl

[Qemu-devel] [PATCH 0/3 v7] vnc: added initial websocket protocol support

2013-01-21 Thread Tim Hardeck
This patch set adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket

Re: [Qemu-devel] [PATCH 2/4] ram: remove xbrle last_stage optimization

2013-01-21 Thread Orit Wasserman
Juan, Why not add a migration_is_last_stage (similar to migration_is_xbzrle) function and leave the optimization Regards, Orit On 01/18/2013 01:53 PM, Juan Quintela wrote: > We need to remove it to be able to return from complete to iterative > phases of migration. > > Signed-off-by: Juan Quinte

Re: [Qemu-devel] [PATCH 3/4] ram: reuse ram_save_iterate() for the complete stage

2013-01-21 Thread Orit Wasserman
On 01/18/2013 01:53 PM, Juan Quintela wrote: > This means that we only have one memory loop for the iterate and > complete phase. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 16 > migration.c | 12 > 2 files changed, 12 insertions(+), 16 deletions(-) > >

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-21 Thread Kevin Wolf
Am 18.01.2013 18:33, schrieb Paolo Bonzini: > >> Am 18.01.2013 17:22, schrieb Paolo Bonzini: >>> I haven't written a testcase for it, it's tricky but should be >>> doable. >>> Do you want me to respin, or can it be done as a followup? >> >> I think I would prefer a respin, but if you think otherwi

Re: [Qemu-devel] [PATCH 4/4] migration: print times for end phase

2013-01-21 Thread Orit Wasserman
This is for debugging? Why not trace events? Regards, Orit On 01/18/2013 01:53 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > block.c | 6 ++ > cpus.c | 17 + > migration.c | 13 + > savevm.c| 13 + > 4 files changed, 49

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2013-01-21 Thread James Le Cuirot
I get an undefined reference to cpu_set_tls. The other architectures have this defined in target-*/cpu.h but the implementations vary. They generally seem to modify a register or two. I'm out of my depth here. I have no idea what that would look like for i386. -- You received this bug notificatio

Re: [Qemu-devel] [PATCH 3/4] ram: reuse ram_save_iterate() for the complete stage

2013-01-21 Thread Paolo Bonzini
Il 18/01/2013 12:53, Juan Quintela ha scritto: > This means that we only have one memory loop for the iterate and > complete phase. I think this is premature. One important difference between iterate and complete is that ultimately iterate will run without the BQL, while that's not necessarily tr

[Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-21 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is

Re: [Qemu-devel] qmp drive-mirror vs qemu-img convert , drive-mirror really slow

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 10:40, Alexandre DERUMIER ha scritto: > Hi list, > > I'm doing some speed benchmark between > > drive-mirror vs qemu-img convert , > > and drive-mirror seem to be a lot slower. > > > test: > > convert 1 32GB qcow2 file to raw file, local storage (6 disk 15k in raid10 + > raid B

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-21 Thread Markus Armbruster
Peter Maydell writes: > On 20 January 2013 15:54, Blue Swirl wrote: [...] > I don't think there's much point adding tons of "XXX" comments > when a bunch of these aren't actually wrong code. Moreover, such comments make them look intentional to static analyzers. I doubt lying to our tools is a

[Qemu-devel] [PATCH 1/3] vnc: added buffer_advance function

2013-01-21 Thread Tim Hardeck
Following Anthony Liguori's Websocket implementation I have added the buffer_advance function to VNC and replaced all related buffer memmove operations with it. Signed-off-by: Tim Hardeck Reviewed-by: Anthony Liguori --- ui/vnc.c | 13 + ui/vnc.h |1 + 2 files changed, 10 inse

[Qemu-devel] [PATCH 3/3] vnc: fix possible uninitialized removals

2013-01-21 Thread Tim Hardeck
Some VncState values are not initialized before the Websocket handshake. If it fails QEMU segfaults during the cleanup. To prevent this behavior intialization checks are added. Signed-off-by: Tim Hardeck --- ui/vnc.c | 11 --- ui/vnc.h |1 + 2 files changed, 9 insertions(+), 3 dele

Re: [Qemu-devel] [PATCH v2] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

2013-01-21 Thread Stefan Hajnoczi
On Mon, Jan 21, 2013 at 07:49:51AM +0100, Stefan Weil wrote: > STATUS_TIMEOUT is defined in winnt.h: > > CChw/tpci200.o > hw/tpci200.c:34:0: > warning: "STATUS_TIMEOUT" redefined [enabled by default] > /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0

Re: [Qemu-devel] qmp drive-mirror vs qemu-img convert , drive-mirror really slow

2013-01-21 Thread Alexandre DERUMIER
>>Please try the blkmirror-job-1.4 branch from my github repo  >>(git://github.com/bonzini/qemu.git). That branch uses the qcow2 file's  >>cluster size as the granularity, and has other optimizations that kick  >>in when the image is sparse.  I'll try that, thanks Paolo, I'll keep you in touch.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-21 Thread Stefan Hajnoczi
On Mon, Jan 21, 2013 at 01:36:54AM +0400, Vadim Evard wrote: > By the way (sorry if this was discussed before and is a strong > decision) I'd say e-mail based workflow is of course very flexible - > and very very novice-unfriendly. Dash, I had to learn git commands > I'd never use in my usual workf

[Qemu-devel] [PATCH 2/4] acpitable: open the data file in binary mode

2013-01-21 Thread Stefan Hajnoczi
From: Michael Tokarev -acpitable {file|data}=file reads the content of file, but it is in binary form, so the file should be opened usin O_BINARY flag. On *nix it is a no-op, but on windows and other weird platform it is really needed. Signed-off-by: Michael Tokarev Signed-off-by: Stefan Hajnoc

[Qemu-devel] [PATCH 4/4] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

2013-01-21 Thread Stefan Hajnoczi
From: Stefan Weil STATUS_TIMEOUT is defined in winnt.h: CChw/tpci200.o hw/tpci200.c:34:0: warning: "STATUS_TIMEOUT" redefined [enabled by default] /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0: note: this is the location of the previous definit

Re: [Qemu-devel] [PATCH v2 08/12] mirror: allow customizing the granularity

2013-01-21 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: > The desired granularity may be very different depending on the kind of > operation (e.g. continuous replication vs. collapse-to-raw) and whether > the VM is expected to perform lots of I/O while mirroring is in progress. > > Allow the user to customize

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-21 Thread Eduardo Habkost
On Mon, Jan 21, 2013 at 04:39:24AM +0100, Andreas Färber wrote: > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > Currently, the pc-1.4 machine init function enables PV EOI and then > > calls the pc-1.2 machine init function. The problem with this approach > > is that now we can't enable any addi

Re: [Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-21 Thread Markus Armbruster
Stefan Weil writes: > Am 18.01.2013 09:53, schrieb Markus Armbruster: >> Stefan Weil writes: >>> This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk >>> when a file with the wrong format is selected. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> block/bochs.c |2 +- >>>

Re: [Qemu-devel] [PATCH v13 0/7] libqblock qemu block layer library

2013-01-21 Thread Paolo Bonzini
Il 14/12/2012 11:17, Paolo Bonzini ha scritto: > Il 14/12/2012 11:06, Wenchao Xia ha scritto: >> >> Hi Paolo, >> Do you think a rebase of the libqblock is needed? It have been quite >> a time without comments. > > I was hoping that other people would jump in. :) Please rebase, there will be som

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 11:17, Kevin Wolf ha scritto: > Am 18.01.2013 18:33, schrieb Paolo Bonzini: >> >>> Am 18.01.2013 17:22, schrieb Paolo Bonzini: I haven't written a testcase for it, it's tricky but should be doable. Do you want me to respin, or can it be done as a followup? >>> >>> I thi

[Qemu-devel] [PATCH v5 0/3] make mac programming for virtio net more robust

2013-01-21 Thread Amos Kong
Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Third patch introduced a new vq control command to set mac address, it's atomic. V2: check return of sending command, delay eth_mac_addr() V3: restore software address when fail to set hardw

[Qemu-devel] [PATCH v5 1/3] move virtnet_send_command() above virtnet_set_mac_address()

2013-01-21 Thread Amos Kong
We want to send vq command to set mac address in virtnet_set_mac_address(), so do this function moving. Fixed a little issue of coding style. Signed-off-by: Amos Kong --- drivers/net/virtio_net.c | 89 ++--- 1 files changed, 44 insertions(+), 45 deletion

[Qemu-devel] [PATCH v5 2/3] net: split eth_mac_addr for better error handling

2013-01-21 Thread Amos Kong
From: Stefan Hajnoczi When we set mac address, software mac address in system and hardware mac address all need to be updated. Current eth_mac_addr() doesn't allow callers to implement error handling nicely. This patch split eth_mac_addr() to prepare part and real commit part, then we can prepar

[Qemu-devel] [PATCH 3/4] configure: silence pkg-config's check for curses

2013-01-21 Thread Stefan Hajnoczi
From: Vadim Evard Signed-off-by: Vadim Evard Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4ebb60d..6211db9 100755 --- a/configure +++ b/configure @@ -2039,7 +2039,7 @@ fi if test "$mingw32" = "yes"

Re: [Qemu-devel] [PATCH for-1.4 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-21 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > This function will be used by both the CPU initialization code and the > fw_cfg table initialization code. > > Later this function will be updated to generate APIC IDs according to > the CPU topology. > > Signed-off-by: Eduardo Habkost > --- > tar

[Qemu-devel] [PULL for-1.4 0/4] Trivial patches for 16 to 21 January 2013

2013-01-21 Thread Stefan Hajnoczi
These fixes are for QEMU 1.4. The following changes since commit 8b17ed4caa7e015324a4ecbe3c863e32458d840a: Merge remote-tracking branch 'stefanha/block' into staging (2013-01-20 11:01:10 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for

Re: [Qemu-devel] [PATCH for-1.4 11/12] target-i386: Topology & APIC ID utility functions

2013-01-21 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > - Support 32-bit APIC IDs (in case x2APIC is going to be used) > - Coding style changes > - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ > - Rename topo_make_apic_id() to

Re: [Qemu-devel] [PATCH for-1.4 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-21 Thread Eduardo Habkost
On Mon, Jan 21, 2013 at 12:18:55PM +0100, Andreas Färber wrote: > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > This function will be used by both the CPU initialization code and the > > fw_cfg table initialization code. > > > > Later this function will be updated to generate APIC IDs accordin

[Qemu-devel] [PATCH 1/4] hw: Spelling fix in log message

2013-01-21 Thread Stefan Hajnoczi
From: Stefan Weil defineition -> definition Signed-off-by: Stefan Weil Reviewed-by: Andreas F=E4rber Signed-off-by: Stefan Hajnoczi --- hw/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index fb47cdc..6c443ba 100644 --

Re: [Qemu-devel] [PATCH v2 09/12] mirror: switch mirror_iteration to AIO

2013-01-21 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: > There is really no change in the behavior of the job here, since > there is still a maximum of one in-flight I/O operation between > the source and the target. However, this patch already introduces > the AIO callbacks (which are unmodified in the next

[Qemu-devel] [PATCH v5 3/3] virtio-net: introduce a new control to set macaddr

2013-01-21 Thread Amos Kong
Currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibility. Signed-off-by: Amos Kon

Re: [Qemu-devel] [RFC V5 20/36] qcow2: Drop hash for a given cluster when dedup makes refcount > 2^16/2.

2013-01-21 Thread Benoît Canet
> You are hardcoding to a width of 16 bits; however, version 3 makes the > refcount field variable-sized: > > 96 - 99: refcount_order > Describes the width of a reference count block entry > (width > in bits = 1 << refcount_order). For version 2 >

Re: [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2013-01-21 Thread Luiz Capitulino
On Fri, 18 Jan 2013 13:00:28 -0700 Eric Blake wrote: > On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > docs/virtio-balloon-stats.txt | 102 > > ++ > > 1 file changed, 102 insertions(+) > > create mode 100644

Re: [Qemu-devel] [PATCH v9 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2013-01-21 Thread Dmitry Fleytman
Fixed. Thanks. On Wed, Jan 16, 2013 at 4:27 PM, Stefan Hajnoczi wrote: > On Sat, Jan 12, 2013 at 06:09:42PM +0200, Dmitry Fleytman wrote: > > +static inline uint32_t > > +net_checksum_add(int len, uint8_t *buf) > > +{ > > +return net_checksum_add_cont(len, buf, 0); > > +} > > + > > +static

[Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-21 Thread Peter Maydell
Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to the files which included qemu-pixman.h, since they were relying on it implici

Re: [Qemu-devel] [PATCH v9 5/5] Adding VMXNET3 device implementation

2013-01-21 Thread Dmitry Fleytman
On Wed, Jan 16, 2013 at 5:16 PM, Stefan Hajnoczi wrote: > On Sat, Jan 12, 2013 at 06:09:46PM +0200, Dmitry Fleytman wrote: > > @@ -113,6 +113,8 @@ common-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o > > common-obj-$(CONFIG_PCNET_COMMON) += pcnet.o > > common-obj-$(CONFIG_E1000_PCI) += e1000.o > > co

Re: [Qemu-devel] [PATCH v9 4/5] Adding packet abstraction for VMWARE network devices

2013-01-21 Thread Dmitry Fleytman
On Thu, Jan 17, 2013 at 12:24 PM, Stefan Hajnoczi wrote: > On Wed, Jan 16, 2013 at 04:33:48PM +0100, Paolo Bonzini wrote: > > Il 16/01/2013 15:48, Stefan Hajnoczi ha scritto: > > >> > hw/vmxnet_rx_pkt.c | 187 ++ > > >> > hw/vmxnet_rx_pkt.h | 173 > > >> > hw/vmxn

Re: [Qemu-devel] [PATCH v2 09/12] mirror: switch mirror_iteration to AIO

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 12:39, Kevin Wolf ha scritto: > Am 16.01.2013 18:31, schrieb Paolo Bonzini: >> There is really no change in the behavior of the job here, since >> there is still a maximum of one in-flight I/O operation between >> the source and the target. However, this patch already introduces >> t

Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000

2013-01-21 Thread Igor Mammedov
On Mon, 21 Jan 2013 09:39:07 +0100 Andreas Färber wrote: > Am 17.01.2013 16:16, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > Reviewed-by: Eduardo Habkost > > --- > > target-i386/cpu.c |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/target-i3

Re: [Qemu-devel] [PATCH v2 09/12] mirror: switch mirror_iteration to AIO

2013-01-21 Thread Kevin Wolf
Am 21.01.2013 13:09, schrieb Paolo Bonzini: > Il 21/01/2013 12:39, Kevin Wolf ha scritto: >> Am 16.01.2013 18:31, schrieb Paolo Bonzini: >>> There is really no change in the behavior of the job here, since >>> there is still a maximum of one in-flight I/O operation between >>> the source and the ta

Re: [Qemu-devel] [PATCH v9 3/5] Adding common definitions for VMWARE devices

2013-01-21 Thread Dmitry Fleytman
Hello Stefan I've checked origin of headers, some of them are self-made, other came from following places: 1. file rtl8139.c from QEMU codebase 2. /usr/include/netinet/ip6.h from glibc 3. /usr/include/netinet/in.h from glibc How should we indicate this? Should we add something like:

[Qemu-devel] [PATCH v2 09/12] qdev: inline object_delete into qbus_free/qdev_free

2013-01-21 Thread Paolo Bonzini
We want object_delete to disappear, and we will do this one class at a time. Inline it for the qdev case, which we will tackle first. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 24bb19a..e65b32f

[Qemu-devel] [PATCH v2 08/12] qdev: add reference for the bus while it is referred to by the DeviceState

2013-01-21 Thread Paolo Bonzini
Now that the unparent callbacks are complete, we can correctly account more missing references. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index aad360f..24bb19a 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -100,6 +100,7 @

[Qemu-devel] [PATCH v2 04/12] qom: document reference counting of link properties

2013-01-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/qom/object.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 8e16ea8..5e8e528 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1033,6 +1033,11 @@ void object_property_add_child(Obje

[Qemu-devel] [PATCH v2 12/12] qom: remove object_delete

2013-01-21 Thread Paolo Bonzini
This is now unused. Signed-off-by: Paolo Bonzini --- include/qom/object.h | 17 ++--- qom/object.c | 7 --- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 5e8e528..2ac35a5 100644 --- a/include/qom/object.

Re: [Qemu-devel] [PATCH v2 11/12] mirror: support more than one in-flight AIO operation

2013-01-21 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: > With AIO support in place, we can start copying more than one chunk > in parallel. This patch introduces the required infrastructure for > this: the buffer is split into multiple granularity-sized chunks, > and there is a free list to access them. > >

[Qemu-devel] KVM call agenda for 2013-01-22

2013-01-21 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [PATCH for-1.4] target-cris: Drop unused cpu_cris_close() prototype

2013-01-21 Thread Edgar E. Iglesias
On Sun, Jan 20, 2013 at 03:20:58AM +0100, Andreas Färber wrote: > Such a function never existed. > > Signed-off-by: Andreas Färber > --- > Edgar, can you commit or ack? I'd like to base v2 of my CPU realizefn series > on this. Thanks, Andreas I've commited this one and the MicroBlaze part, Tha

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-21 Thread Alon Levy
> On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape > > (flipped), Portrait (flipped) > > - You can choose Resolution > > - You can click "Adva

[Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2013-01-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void interface_set_client_capabilities(QXLInstance *sin,

[Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192

2013-01-21 Thread Alon Levy
This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields in QXLRom, which is what has actually changed, we remove some of the modes, a mechanism already accounted for by the guest. The modes left allow for portrait and landscape

Re: [Qemu-devel] [PATCH v9 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2013-01-21 Thread Markus Armbruster
Dmitry Fleytman writes: > Adding utility function net_raw_checksum() that calculates checksum > of buffer given Your subject is excessively long. Please stick to the standard commit message format: subsystem: summary phrase (no more than 75 chars, please) Zero or more paragraphs of de

[Qemu-devel] [PATCH 3/6] hw/omap_dma, hw/omap_spi: Explicitly mark fallthroughs

2013-01-21 Thread Peter Maydell
Explicitly mark the fallthroughs as intentional in the code pattern where we gradually increment an index before falling into the code to read/write that array entry: case THINGY_3: idx++; case THINGY_2: idx++; case THINGY_1: idx++; case THINGY_0: return s->thingy[idx]; This makes static a

Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation

2013-01-21 Thread Edgar E. Iglesias
On Sat, Jan 19, 2013 at 06:28:10PM -0400, Grant Likely wrote: > The etraxfs Ethernet model implements quite a nice bitbanging core. The > change splits it out into a separate .c file. There are no functional > changes here, just movement of code and reformatting to match qemu > coding standards. H

Re: [Qemu-devel] [PATCH v2 11/12] mirror: support more than one in-flight AIO operation

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 13:35, Kevin Wolf ha scritto: > I'm wondering if a whole bitmap is really appropriate when you have at > most 16 parallel requests in flight. Other places in qemu (like > copy-on-read or qcow2 cluster allocation) use lists of in-flight > requests instead. > > I'm not requesting a cha

Re: [Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init

2013-01-21 Thread Andreas Färber
Am 21.01.2013 13:30, schrieb Paolo Bonzini: > BusState subclasses need to do their own allocation because > qbus_create_inplace calls object_initialize (which wipes out the > "free" callback). This patch separates the initialization of the object > (object_initialize) from its insertion in the qde

Re: [Qemu-devel] [RFC V7 00/11] Quorum block filter

2013-01-21 Thread Zhi Yong Wu
On Sat, Jan 19, 2013 at 1:30 AM, Benoît Canet wrote: > This patchset is rebased on top of "cutils: unsigned int parsing functions" > by "Eduardo Habkost". > > This patchset create a block driver implementing a quorum using total qemu > disk > images. Writes are mirrored on the $total files. > For

[Qemu-devel] [PATCH v2 07/12] qdev: move unrealization of devices from finalize to unparent

2013-01-21 Thread Paolo Bonzini
Similarly, a bus holds a reference back to the device, and this will prevent the device from going away as soon as this reference is counted properly. To avoid this, move the unrealization of devices to the unparent callback. This includes recursively unparenting all the buses and (after the prev

Re: [Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it

2013-01-21 Thread Andreas Färber
Am 21.01.2013 13:30, schrieb Paolo Bonzini: > Avoid that the object disappears after it's deleted from the QOM > composition tree, in case that was the only reference to it. > > Signed-off-by: Paolo Bonzini Acked-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nü

[Qemu-devel] [PATCH v2 05/12] qdev: add reference count to a device for the BusChild

2013-01-21 Thread Paolo Bonzini
Each device has a reference through the BusChild. This reference was not accounted for, add it now. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index b473bd7..f88a8a4 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -64,7 +6

[Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init

2013-01-21 Thread Paolo Bonzini
BusState subclasses need to do their own allocation because qbus_create_inplace calls object_initialize (which wipes out the "free" callback). This patch separates the initialization of the object (object_initialize) from its insertion in the qdev tree (qbus_realize); to do so, it moves the remain

[Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-21 Thread Paolo Bonzini
This series makes the ref_count field of device and bus objects actually match the number of references that the objects have. Once this is done, the question "how do I delete an object?" has a simple answer: use object_unparent if the object is reachable from the QOM tree, else use object_unref.

Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc91c111 network device

2013-01-21 Thread Grant Likely
On Sun, 20 Jan 2013 11:29:32 +, Peter Maydell wrote: > On 19 January 2013 22:28, Grant Likely wrote: > > The smc91c111 device has bitbanged MDIO access, but the model doesn't > > yet implement it. This patch uses the generalized bitbang MDIO support > > pulled out of etraxfs Ethernet driver.

[Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs

2013-01-21 Thread Peter Maydell
These patches either mark implicit fallthroughs in case statements or (in a few cases) remove them by putting in an explicit 'break' or 'return' rather than relying on the one in the following case. There is no behaviour change for any of these patches, and in all cases I've examined the code and a

[Qemu-devel] [PATCH 4/6] hw/pflash_cfi02.c: Mark deliberate fallthrough

2013-01-21 Thread Peter Maydell
Mark the deliberate fallthrough where we treat the case of an attempt to read flash when it is an unknown command state as if it were a normal read. Signed-off-by: Peter Maydell --- hw/pflash_cfi02.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c ind

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-21 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 18.01.2013 18:46, schrieb Eric Blake: > On 01/18/2013 09:40 AM, Eduardo Habkost wrote: >> On Fri, Jan 18, 2013 at 09:11:42AM -0700, Eric Blake wrote: >>> On 01/18/2013 07:20 AM, Eduardo Habkost wrote: > Could you suggest a text for me to add ple

[Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it

2013-01-21 Thread Paolo Bonzini
Avoid that the object disappears after it's deleted from the QOM composition tree, in case that was the only reference to it. Signed-off-by: Paolo Bonzini --- qom/object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qom/object.c b/qom/object.c index 03e6f24..1a123da 100644 --- a/qom/ob

Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation

2013-01-21 Thread Grant Likely
On Sun, 20 Jan 2013 18:29:25 +0100, Andreas Färber wrote: > Am 19.01.2013 23:28, schrieb Grant Likely: > > The etraxfs Ethernet model implements quite a nice bitbanging core. The > > change splits it out into a separate .c file. There are no functional > > changes here, just movement of code and

Re: [Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init

2013-01-21 Thread Paolo Bonzini
Il 21/01/2013 14:01, Andreas Färber ha scritto: >> > BusState subclasses need to do their own allocation because >> > qbus_create_inplace calls object_initialize (which wipes out the >> > "free" callback). This patch separates the initialization of the object >> > (object_initialize) from its inse

Re: [Qemu-devel] [PATCH 0/3] Generalize bitbang MDIO and use for versatile-pb

2013-01-21 Thread Grant Likely
On Sun, 20 Jan 2013 18:26:06 +0100, Andreas Färber wrote: > Am 19.01.2013 23:28, schrieb Grant Likely: > > This series extracts the MDIO bitbang code from the etraxfs driver and > > makes it usable on targets using the smc9 Ethernet controller. I've > > tested this using u-boot on the versati

Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation

2013-01-21 Thread Grant Likely
On Mon, 21 Jan 2013 13:51:02 +0100, "Edgar E. Iglesias" wrote: > On Sat, Jan 19, 2013 at 06:28:10PM -0400, Grant Likely wrote: > > The etraxfs Ethernet model implements quite a nice bitbanging core. The > > change splits it out into a separate .c file. There are no functional > > changes here, ju

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-21 Thread Max Filippov
On Mon, Jan 21, 2013 at 5:11 PM, Markus Armbruster wrote: > Blue Swirl writes: > >> Recent Clang compilers have preliminary support for finding >> unannotated fallthrough cases in switch statements with >> compiler flag -Wimplicit-fallthrough. The support is incomplete, >> it's only possible to a

Re: [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-21 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the > RFC > I sent last week, though. > > Igor argued that APIC ID should be set by the board and not by the CPU itself, > but I am not doing that because: > - I want to keep t

Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements

2013-01-21 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: > The fixes from the previous post are: > > 1) the in_flight_bitmap is now properly set and cleared [Stefan]; > > 2) persistent dirty bitmap left out [Stefan]; > > 3) reordered arguments in qmp-command.hx to follow patch order [Stefan]; > > 4) tests/q

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-21 Thread Anthony Liguori
"Nicholas A. Bellinger" writes: > Hi MST & Co, > > On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: >> On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: >> > From: Nicholas Bellinger >> > >> > Hello Anthony & Co, >> > >> > This is the fourth installment to add

[Qemu-devel] [PATCH v2 06/12] qdev: move deletion of children from finalize to unparent

2013-01-21 Thread Paolo Bonzini
A device will never be finalized as long as it has a reference from other devices that sit on its buses. To ensure that the references go away, deassociate a bus from its children in the unparent callback for the bus. Signed-off-by: Paolo Bonzini --- hw/qdev.c | 37 +

  1   2   3   >