On Sun, 20 Jan 2013 18:29:25 +0100, Andreas Färber <afaer...@suse.de> wrote: > Am 19.01.2013 23:28, schrieb Grant Likely: > > The etraxfs Ethernet model implements quite a nice bitbanging core. The > > change splits it out into a separate .c file. There are no functional > > changes here, just movement of code and reformatting to match qemu > > coding standards. > > > > Cc: Peter Maydell <peter.mayd...@linaro.org> > > Cc: Paul Brook <p...@codesourcery.com> > > Cc: Edgar E. Iglesias <edgar.igles...@gmail.com> > > Cc: Anthony Liguori <aligu...@us.ibm.com> > > Signed-off-by: Grant Likely <grant.lik...@secretlab.ca> > > --- > > hw/bitbang_mdio.c | 263 > > +++++++++++++++++++++++++++++++++++++++++++++++ > > hw/bitbang_mdio.h | 72 +++++++++++++ > > hw/cris/Makefile.objs | 1 + > > hw/etraxfs_eth.c | 273 > > +------------------------------------------------ > > 4 files changed, 337 insertions(+), 272 deletions(-) > > create mode 100644 hw/bitbang_mdio.c > > create mode 100644 hw/bitbang_mdio.h > > If you fix coding style issues in the original file first this helps > git's copy detection. Looks like either you have it disabled for patches > or it's not detecting it at all... I would expect some "similarity N%" > notice.
I played around with this a lot and I couldn't make the copy detection pick up on the lines being moved. I've not disabled copy detection or anything like that. Regardless, I've split the coding style changes into a separate patch and I'll resubmit. g.
