Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Jason Baron ha scritto: > +typedef struct ICH9_LPCIrqState { > +struct ICH9_LPCState *lpc; Please add DEFINE_PROP_PTR property for this field in gmch_pcihost_info, so we know this ought to become a link later. > +qemu_irq *pic; > +qemu_irq *ioapic; > +} ICH9_LPCIr

Re: [Qemu-devel] [PATCH 16/25] pci: Add class 0xc05 as 'SMBus'

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Jason Baron ha scritto: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > Signed-off-by: Jason Baron > --- > hw/pci.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 55e4ad3..3727afa 100644 > --- a/hw/pci.c > +++

Re: [Qemu-devel] [PATCH 18/25] q35: Fix irr initialization for slots 25..31

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Jason Baron ha scritto: > From: Isaku Yamahata > > This was totally off: The CC registers are 16 bit (stored as little > endian), their offsets run in reverse order, and D26IR as well as D25IR > have 4 bytes offset to their successors. > > Reported-by: Jan Kiszka > Signed-o

Re: [Qemu-devel] [PATCH 25/25] q35: automatically load the q35 dsdt table

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Jason Baron ha scritto: > Automatically, locate the required q35 dsdt table on load. Otherwise we error > out. This could be done in the bios, but its harder to produce a good error > message. > > Signed-off-by: Jason Baron > --- > hw/pc_q35.c | 26

Re: [Qemu-devel] [PATCH 24/25] Add a fallback bios file search, if -L fails.

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Jason Baron ha scritto: > If -L is specified, and qemu does not find the bios file in , then > the search fails. Add infrastructure such that the search will continue in > the default paths, if not found in the -L path. > > Signed-off-by: Jason Baron What is this useful for

Re: [Qemu-devel] [PATCH 25/25] q35: automatically load the q35 dsdt table

2012-09-14 Thread Gerd Hoffmann
On 09/14/12 09:08, Paolo Bonzini wrote: > Il 13/09/2012 22:12, Jason Baron ha scritto: >> Automatically, locate the required q35 dsdt table on load. Otherwise we error >> out. This could be done in the bios, but its harder to produce a good error >> message. >> /* PC hardware initialisation */ >>

Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

2012-09-14 Thread Kevin Wolf
Am 13.09.2012 18:12, schrieb Paolo Bonzini: > Il 13/09/2012 17:49, Jeff Cody ha scritto: >> Block drivers should always open the files in writeback mode (see commit >> e1e9b0ac), so raw-posix/raw-win32 should not parse the BDRV_O_CACHE_WB >> flag. >> >> Signed-off-by: Jeff Cody >> --- >> block/ra

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-14 Thread Stefan Hajnoczi
On Fri, Sep 14, 2012 at 2:34 AM, Amos Kong wrote: > On 13/09/12 20:29, Stefan Hajnoczi wrote: >> >> On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: >> Regarding migration: do we migrate the NetClient->link_down field? If >> we only migrate the status register value then the link may actually >>

Re: [Qemu-devel] [PATCH v2 08/16] block: raw-posix image file reopen

2012-09-14 Thread Kevin Wolf
Am 13.09.2012 18:57, schrieb Jeff Cody: > On 09/13/2012 12:02 PM, Paolo Bonzini wrote: >> Il 13/09/2012 17:49, Jeff Cody ha scritto: >>> + >>> +/* >>> + * If we didn't have BDRV_O_NOCACHE set before, we may not have >>> allocated >>> + * aligned_buf >>> + */ >>> +ret = raw_allo

Re: [Qemu-devel] [PATCH 25/25] q35: automatically load the q35 dsdt table

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 09:25, Gerd Hoffmann ha scritto: >> > >> > Should we take the PIIX4 DSDT into the QEMU tree, and do the same thing >> > for PIIX4? > We should surely have both at the same place. Dunno what the best place > is, we have interactions with both seabios code and acpi tables and qemu > +

Re: [Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function

2012-09-14 Thread Michael S. Tsirkin
On Thu, Sep 13, 2012 at 07:52:35PM +0300, Orit Wasserman wrote: > >> +for (e = res; e != NULL; e = e->ai_next) { > >> +sock = inet_connect_addr(e, block, in_progress, errp); > >> +if (in_progress && *in_progress) { > >> +return sock; > > > > Doesn't this leak res? >

Re: [Qemu-devel] [PULL 00/13] Net patches

2012-09-14 Thread Stefan Hajnoczi
On Mon, Sep 10, 2012 at 10:55 AM, Stefan Hajnoczi wrote: > Fixes for hung NICs, USB network interface packet dropping, and inefficient > netdev socket non-blocking I/O. > > The following changes since commit 0c267217ca9985e6d118ec8368bebd382db7a099: > > musicpal: Fix flash mapping (2012-09-08 10

Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator

2012-09-14 Thread Gerd Hoffmann
On 09/13/12 22:12, Jason Baron wrote: > +if (ram_size >= 0xe000) { > +above_4g_mem_size = ram_size - 0xe000; > +below_4g_mem_size = 0xe000; We should make the hole larger to get more pci i/o address space below 4G, especially as q35 needs a good chunk of it for mmco

Re: [Qemu-devel] [PATCH 07/11] Fix copy&paste typos in documentation comments

2012-09-14 Thread Stefan Hajnoczi
On Thu, Sep 6, 2012 at 11:00 AM, Stefan Hajnoczi wrote: > From: BALATON Zoltan > > Signed-off-by: BALATON Zoltan > Signed-off-by: Stefan Hajnoczi > --- > memory.h | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Please disregard this thread, there has been an issue with m

[Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Michael Tokarev
What's the difference between the two except that the latter adds some more instructions (actually whole new subsytem) to the former? Why do we need -i386, what -x86_64 does not do which does -i386? Thanks, /mjt

[Qemu-devel] [PATCH 09/13] net: fix usbnet_receive() packet drops

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The USB network interface has a single buffer which the guest reads from. This patch prevents multiple calls to usbnet_receive() from clobbering the input buffer. Instead we queue packets until buffer space becomes available again. This is inspired by virtio-net and e1000

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-14 Thread Stefan Hajnoczi
On Tue, Sep 11, 2012 at 12:23:37PM +0200, Kevin Wolf wrote: > Am 05.09.2012 15:26, schrieb riegama...@gmail.com: > > From: Dunrong Huang > > > > The caller would not delete temporary file after failed get_tmp_filename(). > > > > Signed-off-by: Dunrong Huang > > Thanks, applied to the block bra

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: fix seccomp check

2012-09-14 Thread Stefan Hajnoczi
On Thu, Sep 06, 2012 at 10:40:30PM +0200, Yann E. MORIN wrote: > Currently, if libseccomp is missing but the user explicitly requested > seccomp support using --enable-seccomp, configure silently ignores the > situation and disables seccomp support. > > This is unlike all other tests that explicit

Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 09:27, Kevin Wolf ha scritto: > I can't see how bs->file is needed here for writethrough semantics. > bdrv_open_common() sets bs->enable_write_cache to false and > bdrv_co_do_writev() checks it and flushes if necessary. Looks fine to me. You're right. > In fact, bdrv_open_common() e

[Qemu-devel] [PULL 00/13] Net patches

2012-09-14 Thread Stefan Hajnoczi
Fixes for hung NICs, USB network interface packet dropping, and inefficient netdev socket non-blocking I/O. The following changes since commit 0c267217ca9985e6d118ec8368bebd382db7a099: musicpal: Fix flash mapping (2012-09-08 10:17:57 +) are available in the git repository at: git://gith

[Qemu-devel] [PATCH 13/13] net: EAGAIN handling for net/socket.c TCP

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi Replace spinning send_all() with a proper non-blocking send. When the socket write buffer limit is reached, we should stop trying to send and wait for the socket to become writable again. Non-blocking TCP sockets can return in two different ways when the write buffer limit

Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

2012-09-14 Thread Kevin Wolf
Am 13.09.2012 23:45, schrieb Jeff Cody: > On 09/13/2012 04:29 PM, Paolo Bonzini wrote: >> Il 13/09/2012 21:44, Paolo Bonzini ha scritto: >>> Il 13/09/2012 21:04, Jeff Cody ha scritto: >> Perhaps we _should_ preserve that in bs->open_flags, while still using >> the initial value of BDRV_O_CA

Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

2012-09-14 Thread Kevin Wolf
Am 14.09.2012 09:50, schrieb Paolo Bonzini: > Il 14/09/2012 09:27, Kevin Wolf ha scritto: >> I can't see how bs->file is needed here for writethrough semantics. >> bdrv_open_common() sets bs->enable_write_cache to false and >> bdrv_co_do_writev() checks it and flushes if necessary. Looks fine to me

Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 09:55, Kevin Wolf ha scritto: >> Either we go and touch all the protocols >> > (effectively removing BDRV_O_CACHE_WB from the BlockDriver >> > specification), or treating raw-{posix,win32} specially means we leave >> > bugs everywhere else. > Yes, touch all protocols and fix them. BDR

Re: [Qemu-devel] [PULL 00/14] usb patch queue

2012-09-14 Thread Michael Tokarev
On 13.09.2012 12:39, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue, featuring life migration support for > usb network redirection and the usual share of bugfixes ;) Are any of the bugfixes worth to apply to previous or new -stable series? I know usbredir configure fix is neede

Re: [Qemu-devel] [PULL 00/10] spice patch queue

2012-09-14 Thread Michael Tokarev
On 13.09.2012 12:45, Gerd Hoffmann wrote: > Hi, > > This pull brings monitor configuration support for qxl which is needed > by the upcoming kms qxl driver. Also a nice speedup for qxl in vga mode > and as usual some bugfixes. Again, anything worth to apply/backport to -stable? For example, "

[Qemu-devel] [PATCH 11/11] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs

2012-09-14 Thread Stefan Hajnoczi
From: Igor Mitsyanko '%' symbols were missing in front of PRIu64 macros in DPRINTF() messages in arch_init.c, this caused compilation warnings when compiled with DEBUG_ARCH_INIT defined. Signed-off-by: Igor Mitsyanko Signed-off-by: Stefan Hajnoczi --- arch_init.c |8 1 file chan

[Qemu-devel] [PATCH 07/11] Fix copy&paste typos in documentation comments

2012-09-14 Thread Stefan Hajnoczi
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Signed-off-by: Stefan Hajnoczi --- memory.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/memory.h b/memory.h index bd1bbae..f6c8e32 100644 --- a/memory.h +++ b/memory.h @@ -252,9 +252,9 @@ void memory_regio

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-14 Thread Paolo Bonzini
Il 13/09/2012 22:12, Nicholas A. Bellinger ha scritto: >> > Are you still seeing the performance degradation discussed in the thread >> > >> > "vhost-scsi port to v1.1.0 + MSI-X performance regression" >> > > So the performance regression reported here with QEMU v1.2-rc + > virtio-scsi ended up

Re: [Qemu-devel] [PULL 00/14] usb patch queue

2012-09-14 Thread Gerd Hoffmann
> Are any of the bugfixes worth to apply to previous or new -stable > series? I know usbredir configure fix is needed, anything else? >> Gerd Hoffmann (2): >> usb-host: allow emulated (non-async) control requests without USBPacket This. >> ehci: Fix interrupts stopping when Interrup

Re: [Qemu-devel] [PULL 00/10] spice patch queue

2012-09-14 Thread Gerd Hoffmann
On 09/14/12 10:01, Michael Tokarev wrote: > On 13.09.2012 12:45, Gerd Hoffmann wrote: >> Hi, >> >> This pull brings monitor configuration support for qxl which is needed >> by the upcoming kms qxl driver. Also a nice speedup for qxl in vga mode >> and as usual some bugfixes. > > Again, anything

Re: [Qemu-devel] [PATCH v3] rtl8139: implement 8139cp link status

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 04:16, Amos Kong ha scritto: > +/* The LinkDown bit of MediaStatus is inverse with link status */ > +ret = 0xd0 | (s->nic->nc.link_down ? MSR_LinkDown : 0); > DPRINTF("MediaStatus read 0x%x\n", ret); > break; > > @@ -3453,12 +3466,27

Re: [Qemu-devel] [PATCH 19/25] ahci: add migration support

2012-09-14 Thread Juan Quintela
Jason Baron wrote: > Add support for ahci migration. This patch builds upon the patches originally > posted by Andreas Färber. > > These patches have been tested by migrating Windows 7 and Fedora 16 guests on > both piix with ahci attached and on q35 (which has a built-in ahci > controller). > +

Re: [Qemu-devel] [libvirt] [PATCH v4 0/5] Per-guest configurable user/group for QEMU processes

2012-09-14 Thread Daniel P. Berrange
On Tue, Sep 11, 2012 at 02:13:38PM -0400, Corey Bryant wrote: > Are there any other requirements that need to be taken care of to > enable execution of QEMU guests under separate unprivileged user IDs > (ie. DAC isolation)? > > At this point, this patch series (Per-guest configurable user/group >

[Qemu-devel] [PULL 00/12] Trivial patches for 16 August to 14 September 2012

2012-09-14 Thread Stefan Hajnoczi
The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to e84d5956cc62

[Qemu-devel] [PATCH 01/12] srp: Don't use QEMU_PACKED for single elements of a structured type

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil QEMU_PACKED results in a MinGW compiler warning when it is used for single structure elements: warning: 'gcc_struct' attribute ignored Using QEMU_PACKED for the whole structure avoids the compiler warning without changing the memory layout. Signed-off-by: Stefan Weil Signed-

[Qemu-devel] [PATCH 08/13] net: clean up usbnet_receive()

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The USB network interface has two code paths depending on whether or not RNDIS mode is enabled. Refactor usbnet_receive() so that there is a common path throughout the function instead of duplicating everything across if (is_rndis(s)) ... else ... code paths. Clean up codi

[Qemu-devel] no "won't fix" for QEMU bugs in Launchpad?

2012-09-14 Thread Paolo Bonzini
I see the won't fix entry is disabled for QEMU bugs, at least for me. Is it just my permissions, or is it disabled? Paolo

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-14 Thread Jason Wang
On 09/14/2012 03:30 PM, Stefan Hajnoczi wrote: On Fri, Sep 14, 2012 at 2:34 AM, Amos Kong wrote: On 13/09/12 20:29, Stefan Hajnoczi wrote: On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: Regarding migration: do we migrate the NetClient->link_down field? If we only migrate the status registe

[Qemu-devel] [PATCH 10/13] net: broadcast hub packets if at least one port can receive

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi In commit 60c07d933c66c4b30a83b7ccbc8a0cb3df1b2d0e ("net: fix qemu_can_send_packet logic") the "VLAN" broadcast behavior was changed to queue packets if any net client cannot receive. It turns out that this was not actually the right fix and just hides the real bug that hw/

Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

2012-09-14 Thread Juan Quintela
Orit Wasserman wrote: > From: "Michael S. Tsirkin" > > refactor address resolution code to fix nonblocking connect > remove getnameinfo call > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Amos Kong > Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela > -int inet_connect_opts(

[Qemu-devel] [Bug 427612] Re: kvm sends caps lock key up event twice

2012-09-14 Thread Paolo Bonzini
Fixed in upstream commit 4e79bcbb96d3c189e50adbdac7b1e28d834ba43e. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/427612 Title: kvm sends caps

Re: [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-14 Thread Juan Quintela
Orit Wasserman wrote: > No need to add non blocking parameters to the blocking inet_connect > add block parameter for inet_connect_opts instead of using QemuOpt "block". > > Signed-off-by: Orit Wasserman Reviewed-by: Juan Quintela

[Qemu-devel] [Bug 1050823] [NEW] segmentation fault when using usb-net and -netdev tap

2012-09-14 Thread Paolo Bonzini
Public bug reported: The following command causes a Segmentation fault: qemu-kvm -usb -device usb-net,netdev=net0 -netdev tap,id=net0 Segmentation fault The following command does not: qemu-kvm -usb -device usb-net,netdev=net0 -netdev user,id=net0 Program received signal SIGSEGV, Segmentation

[Qemu-devel] [PULL 00/13] Net patches

2012-09-14 Thread Stefan Hajnoczi
Fixes for hung NICs, USB network interface packet dropping, and inefficient netdev socket non-blocking I/O. The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 +0200) are available in the git repos

Re: [Qemu-devel] no "won't fix" for QEMU bugs in Launchpad?

2012-09-14 Thread Peter Maydell
On 14 September 2012 09:53, Paolo Bonzini wrote: > I see the won't fix entry is disabled for QEMU bugs, at least for me. > Is it just my permissions, or is it disabled? I think that to set Won't Fix (and Triaged) you need to be in the QEMU launchpad project's list of 'bug supervisors': https://h

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-14 Thread Juan Quintela
Orit Wasserman wrote: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > > To fix this make inet_connect_nonb

Re: [Qemu-devel] [PATCH v3] rtl8139: implement 8139cp link status

2012-09-14 Thread Amos Kong
On 14/09/12 16:36, Paolo Bonzini wrote: Il 14/09/2012 04:16, Amos Kong ha scritto: +/* The LinkDown bit of MediaStatus is inverse with link status */ +ret = 0xd0 | (s->nic->nc.link_down ? MSR_LinkDown : 0); DPRINTF("MediaStatus read 0x%x\n", ret);

[Qemu-devel] [PATCH 05/13] net: add receive_disabled logic to iov delivery path

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi This patch adds the missing NetClient->receive_disabled logic in the sendv delivery code path. It seems that commit 893379efd0e1b84ceb0c42a713293f3dbd27b1bd ("net: disable receiving if client returns zero") only added the logic to qemu_deliver_packet() and not qemu_deliver_

[Qemu-devel] [PATCH 11/13] net: asynchronous send/receive infrastructure for net/socket.c

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The net/socket.c net client is not truly asynchronous. This patch borrows the qemu_set_fd_handler2() code from net/tap.c as the basis for proper asynchronous send/receive. Only read packets from the socket when the peer is able to receive. This avoids needless queuing. La

[Qemu-devel] [PATCH 02/13] e1000: flush queue whenever can_receive can go from false to true

2012-09-14 Thread Stefan Hajnoczi
From: Paolo Bonzini When the guests replenish the receive ring buffer, the network device should flush its queue of pending packets. This is done with qemu_flush_queued_packets. e1000's can_receive can go from false to true when RCTL or RDT are modified. Reported-by: Luigi Rizzo Cc: Stefan Ha

[Qemu-devel] [PATCH 06/12] linux-user: Remove #if 0'd cpu_get_real_ticks() definition

2012-09-14 Thread Stefan Hajnoczi
From: Peter Maydell Remove the cpu_get_real_ticks() definition from linux-user/main.c. This has been disabled via #if 0 and unused since commit 1dce7c3c22 in 2006; the definitions we actually use are in qemu-timer.h. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/m

Re: [Qemu-devel] [PATCH 06/12] linux-user: Remove #if 0'd cpu_get_real_ticks() definition

2012-09-14 Thread Riku Voipio
On Fri, Sep 14, 2012 at 09:42:20AM +0100, Stefan Hajnoczi wrote: > From: Peter Maydell > > Remove the cpu_get_real_ticks() definition from linux-user/main.c. > This has been disabled via #if 0 and unused since commit 1dce7c3c22 > in 2006; the definitions we actually use are in qemu-timer.h. > >

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 11:39:38AM +0400, Michael Tokarev wrote: > What's the difference between the two except that the > latter adds some more instructions (actually whole new > subsytem) to the former? Why do we need -i386, what > -x86_64 does not do which does -i386? AFAIK, qemu-system-x86_6

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Michael Tokarev
On 14.09.2012 13:33, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 11:39:38AM +0400, Michael Tokarev wrote: >> What's the difference between the two except that the >> latter adds some more instructions (actually whole new >> subsytem) to the former? Why do we need -i386, what >> -x86_64 doe

[Qemu-devel] [PATCH 08/12] console: Clean up bytes per pixel calculation

2012-09-14 Thread Stefan Hajnoczi
From: BALATON Zoltan Division with round up is the correct way to compute this even if the only case where division with round down gives incorrect result is probably 15 bpp. This case was explicitely patched up in one of these functions but was unhandled in the other. (I'm not sure about setting

[Qemu-devel] [PATCH 04/12] Spelling fixes in comments and macro names (ressource -> resource)

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally, so the change should be safe. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/xen-host-pci-device.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xen-host-pci-dev

[Qemu-devel] [PATCH 11/12] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs

2012-09-14 Thread Stefan Hajnoczi
From: Igor Mitsyanko '%' symbols were missing in front of PRIu64 macros in DPRINTF() messages in arch_init.c, this caused compilation warnings when compiled with DEBUG_ARCH_INIT defined. Signed-off-by: Igor Mitsyanko Signed-off-by: Stefan Hajnoczi --- arch_init.c |8 1 file chan

[Qemu-devel] [PATCH 12/13] net: EAGAIN handling for net/socket.c UDP

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi Implement asynchronous send for UDP (or other SOCK_DGRAM) sockets. If send fails with EAGAIN we wait for the socket to become writable again. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --g

[Qemu-devel] [PATCH 03/13] xen: flush queue when getting an event

2012-09-14 Thread Stefan Hajnoczi
From: Paolo Bonzini xen does not have a register that, when written, will cause can_receive to go from false to true. However, flushing the queue can be attempted whenever the front-end raises its side of the Xen event channel. There is a single event channel for tx and rx. Cc: Stefano Stabell

[Qemu-devel] [PATCH 03/12] Fix spelling (licenced -> licensed) in GPL

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil The patch also fixes the case of "written". Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/imx_avic.c |4 ++-- hw/imx_timer.c |4 ++-- hw/kzm.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/imx_avic.c b/hw/imx_a

[Qemu-devel] [PATCH 05/12] ui: Fix spelling in comment (ressource -> resource)

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil The function is called interface_release_resource. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- ui/spice-display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 99bc665..11f55c4 100644 --

[Qemu-devel] [PATCH 06/13] net: do not report queued packets as sent

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi Net send functions have a return value where 0 means the packet has not been sent and will be queued. A non-zero value means the packet was sent or an error caused the packet to be dropped. This patch fixes two instances where packets are queued but we return their size.

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 11:39, Michael Tokarev wrote: > On 14.09.2012 13:33, Daniel P. Berrange wrote: >> On Fri, Sep 14, 2012 at 11:39:38AM +0400, Michael Tokarev wrote: >>> What's the difference between the two except that the >>> latter adds some more instructions (actually whole new >>> subsytem) to the

[Qemu-devel] [PATCH 09/13] net: fix usbnet_receive() packet drops

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi The USB network interface has a single buffer which the guest reads from. This patch prevents multiple calls to usbnet_receive() from clobbering the input buffer. Instead we queue packets until buffer space becomes available again. This is inspired by virtio-net and e1000

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Michael Tokarev
On 14.09.2012 14:00, Jan Kiszka wrote: [] > The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on > the TCG side: We measured noticeable performance benefits when running > 32/16 bit OSes against qemu-system-i386 vs. using qemu-system-x86_64. I > don't have numbers at hand, but coll

[Qemu-devel] [PATCH 09/12] qapi: Fix enumeration typo error

2012-09-14 Thread Stefan Hajnoczi
From: Lei Li Signed-off-by: Lei Li Reviewed-by: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- qapi-schema-guest.json |2 +- qapi-schema.json |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index d955cf1

[Qemu-devel] [PATCH 01/13] net: notify iothread after flushing queue

2012-09-14 Thread Stefan Hajnoczi
From: Paolo Bonzini virtio-net has code to flush the queue and notify the iothread whenever new receive buffers are added by the guest. That is fine, and indeed we need to do the same in all other drivers. However, notifying the iothread should be work for the network subsystem. And since we ar

[Qemu-devel] [PATCH 07/12] Fix copy&paste typos in documentation comments

2012-09-14 Thread Stefan Hajnoczi
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Signed-off-by: Stefan Hajnoczi --- memory.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/memory.h b/memory.h index bd1bbae..f6c8e32 100644 --- a/memory.h +++ b/memory.h @@ -252,9 +252,9 @@ void memory_regio

[Qemu-devel] [PATCH 13/13] net: EAGAIN handling for net/socket.c TCP

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi Replace spinning send_all() with a proper non-blocking send. When the socket write buffer limit is reached, we should stop trying to send and wait for the socket to become writable again. Non-blocking TCP sockets can return in two different ways when the write buffer limit

[Qemu-devel] [PATCH 12/12] configure: fix seccomp check

2012-09-14 Thread Stefan Hajnoczi
From: "Yann E. MORIN" Currently, if libseccomp is missing but the user explicitly requested seccomp support using --enable-seccomp, configure silently ignores the situation and disables seccomp support. This is unlike all other tests that explicitly fail in such situation. Fix that. Signed-off

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 12:03, Michael Tokarev wrote: > On 14.09.2012 14:00, Jan Kiszka wrote: > [] >> The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on >> the TCG side: We measured noticeable performance benefits when running >> 32/16 bit OSes against qemu-system-i386 vs. using qemu-syst

[Qemu-devel] [PATCH 04/13] eepro100: Fix network hang when rx buffers run out

2012-09-14 Thread Stefan Hajnoczi
From: Bo Yang This is reported by QA. When installing os with pxe, after the initial kernel and initrd are loaded, the procedure tries to copy files from install server to local harddisk, the network becomes stall because of running out of receive descriptor. [Whitespace fixes and removed qemu_n

[Qemu-devel] [PATCH 07/13] net: add -netdev options to man page

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Hajnoczi Document the -netdev syntax which supercedes the older -net syntax. This patch is a first step to making -netdev prominent in the QEMU manual. Reported-by: Anatoly Techtonik Signed-off-by: Stefan Hajnoczi --- qemu-options.hx |7 +++ 1 file changed, 7 insertions(+

[Qemu-devel] [PATCH 02/12] Spelling fixes in comments and documentation

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil These wrong spellings were detected by codespell: * successully -> successfully * alot -> a lot * wanna -> want to * infomation -> information * occured -> occurred ["also is" -> "is also" and "ressources" -> "resources" suggested by Peter Maydell ] Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-14 Thread Marcelo Tosatti
On Thu, Sep 13, 2012 at 02:43:55PM -0400, Don Slutz wrote: > On 09/12/12 13:55, Marcelo Tosatti wrote: > >The problem with integrating this is that it has little or > >no assurance from documentation. The Linux kernel source is a good > >source, then say "accordingly to VMWare guest support code in

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 12:12:43PM +0200, Jan Kiszka wrote: > On 2012-09-14 12:03, Michael Tokarev wrote: > > On 14.09.2012 14:00, Jan Kiszka wrote: > > [] > >> The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on > >> the TCG side: We measured noticeable performance benefits when

[Qemu-devel] [PATCH 10/12] kvm: Fix warning from static code analysis

2012-09-14 Thread Stefan Hajnoczi
From: Stefan Weil Report from smatch: kvm-all.c:1373 kvm_init(135) warn: variable dereferenced before check 's' (see line 1360) 's' cannot by NULL (it was alloced using g_malloc0), so there is no need to check it here. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Ste

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 12:20, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 12:12:43PM +0200, Jan Kiszka wrote: >> On 2012-09-14 12:03, Michael Tokarev wrote: >>> On 14.09.2012 14:00, Jan Kiszka wrote: >>> [] The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on the TCG side:

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Peter Maydell
On 14 September 2012 11:12, Jan Kiszka wrote: > On 2012-09-14 12:03, Michael Tokarev wrote: >> The thing is: x86_64 becomes the only x86 platform these days, or at >> least the MAIN platform. > > I know, and I'm telling everyone. Still, too many crazy people keep on > installing 32-bit distros or

Re: [Qemu-devel] [PATCH 24/25] Add a fallback bios file search, if -L fails.

2012-09-14 Thread Peter Maydell
On 13 September 2012 21:12, Jason Baron wrote: > If -L is specified, and qemu does not find the bios file in , then > the search fails. Add infrastructure such that the search will continue in > the default paths, if not found in the -L path. > @@ -1872,12 +1873,15 @@ static int balloon_parse(co

Re: [Qemu-devel] Selective block migration (still on 0.13)

2012-09-14 Thread Kevin Wolf
Am 13.09.2012 16:58, schrieb Christian Theune: > Hi, > > we're currently still on 0.13, looking forward to a large update soon. :) > > We haven't been using live migration up until now, but are > investigating it to multiple downtimes (restarting updated hosts and > restarting updated guests) w

Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator

2012-09-14 Thread Michael S. Tsirkin
On Thu, Sep 13, 2012 at 04:12:42PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > pc q35 based chipset emulator to support pci express natively. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron I think it's best to smash the following patch into this one otherwise review b

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Aurelien Jarno
On Fri, Sep 14, 2012 at 02:03:58PM +0400, Michael Tokarev wrote: > On 14.09.2012 14:00, Jan Kiszka wrote: > [] > > The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on > > the TCG side: We measured noticeable performance benefits when running > > 32/16 bit OSes against qemu-system-

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-14 Thread Michael S. Tsirkin
On Fri, Sep 14, 2012 at 08:45:11AM +0200, Paolo Bonzini wrote: > Il 14/09/2012 00:27, Nicholas A. Bellinger ha scritto: > > *) Keep vhost-scsi as a backend to virtio-scsi-pci > > > > - Reduces duplicated code amongst multiple virtio-scsi backends. > > > > - Follows the split for what existi

[Qemu-devel] [PATCH 04/11] block/curl: Fix wrong free statement

2012-09-14 Thread Kevin Wolf
From: Stefan Weil Report from smatch: block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free() The check was redundant, and free was also wrong because the memory was allocated using g_strdup. Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/curl.c |

[Qemu-devel] [PULL 00/11] Block patches

2012-09-14 Thread Kevin Wolf
The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Benoît Canet (2): qapi: Add SnapshotInfo and

[Qemu-devel] [PATCH 02/11] ATAPI: STARTSTOPUNIT only eject/load media if powercondition is 0

2012-09-14 Thread Kevin Wolf
From: Ronnie Sahlberg The START STOP UNIT command will only eject/load media if power condition is zero. If power condition is !0 then LOEJ and START will be ignored. >From MMC (sbc contains similar wordings too) The Power Conditions field requests the block device to be placed in the power

[Qemu-devel] [PATCH 03/11] ide: Fix error messages from static code analysis (no real error)

2012-09-14 Thread Kevin Wolf
From: Stefan Weil Report from smatch: hw/ide/core.c:1472 ide_exec_cmd(423) error: buffer overflow 'smart_attributes' 8 <= 29 hw/ide/core.c:1474 ide_exec_cmd(425) error: buffer overflow 'smart_attributes' 8 <= 29 hw/ide/core.c:1475 ide_exec_cmd(426) error: buffer overflow 'smart_attributes' 8 <

[Qemu-devel] [PATCH 06/11] block: fix block tray status

2012-09-14 Thread Kevin Wolf
From: Pavel Hrdina The tray status should change also if you eject empty block device. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 470bdcc..c754353 100644 --- a/block.c ++

[Qemu-devel] [PATCH 11/11] block: Don't forget to delete temporary file

2012-09-14 Thread Kevin Wolf
From: Dunrong Huang The caller would not delete temporary file after failed get_tmp_filename(). Signed-off-by: Dunrong Huang Signed-off-by: Kevin Wolf --- block.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index c754353..e78039b 100644 ---

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-14 Thread Michael S. Tsirkin
On Tue, Sep 11, 2012 at 08:46:34AM -0500, Anthony Liguori wrote: > On 09/10/2012 01:24 AM, Michael S. Tsirkin wrote: > >On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: > >>Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: > >>>On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=, , ..." option

2012-09-14 Thread Peter Maydell
On 12 September 2012 14:20, Laurent Desnogues wrote: > Sorry, I had missed this patch... > > On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost wrote: >> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for >> comma-separated target lists on the --target-list option. e.g.: >> >>

[Qemu-devel] [PATCH 05/11] vdi: Fix warning from clang

2012-09-14 Thread Kevin Wolf
From: Stefan Weil ccc-analyzer reports these warnings: block/vdi.c:704:13: warning: Dereference of null pointer bmap[i] = VDI_UNALLOCATED; ^ block/vdi.c:702:13: warning: Dereference of null pointer bmap[i] = i; ^ Moving some code into the if block

Re: [Qemu-devel] no "won't fix" for QEMU bugs in Launchpad?

2012-09-14 Thread Anthony Liguori
Paolo Bonzini writes: > I see the won't fix entry is disabled for QEMU bugs, at least for me. > Is it just my permissions, or is it disabled? Anyone who would like greater access to Launchpad, please send me a private email with your LP username. I would be more than grateful to anyone that wan

[Qemu-devel] [PATCH 08/11] qapi: Add SnapshotInfo and ImageInfo.

2012-09-14 Thread Kevin Wolf
From: Benoît Canet Signed-off-by: Benoit Canet Signed-off-by: Kevin Wolf --- qapi-schema.json | 64 ++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a9f465a..1c168c5 100644 --- a/q

[Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Hi all, here is a proposal for moving around 150 C files currently in the toplevel directory to separate, well-delimited subdirectories. Header files would be moved for now in include/, preparing for subsequent reorganization of headers. Usually the files would keep their names, but I loathe nam

[Qemu-devel] [PATCH 07/11] ahci: properly reset PxCMD on HBA reset

2012-09-14 Thread Kevin Wolf
From: Jason Baron While testing q35, I found that windows 7 (specifically, windows 7 ultimate with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. The failure message is: 'A required cd/dvd device driver is missing. If you have a driver floppy disk, CD, DVD, or USB flash

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=, , ..." option

2012-09-14 Thread Anthony Liguori
Peter Maydell writes: > On 12 September 2012 14:20, Laurent Desnogues > wrote: >> Sorry, I had missed this patch... >> >> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost wrote: >>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for >>> comma-separated target lists on the --t

[Qemu-devel] [PATCH] Revert "Add ability to disable build of all targets"

2012-09-14 Thread Anthony Liguori
This reverts commit 66d5499b3754b83c09487259c08fe2ce73188a59. This commit broke --target-list="x86_64-softmmu" and the fix isn't immediatley obvious. Signed-off-by: Anthony Liguori --- configure | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/configure b/con

  1   2   3   >