On Tue, Sep 11, 2012 at 12:23:37PM +0200, Kevin Wolf wrote: > Am 05.09.2012 15:26, schrieb riegama...@gmail.com: > > From: Dunrong Huang <riegama...@gmail.com> > > > > The caller would not delete temporary file after failed get_tmp_filename(). > > > > Signed-off-by: Dunrong Huang <riegama...@gmail.com> > > Thanks, applied to the block branch.
For the record, using the close(2) errno after calling unlink(2) isn't a good idea. We should follow the docs and preserve errno carefully. It's the exact issue I pointed out on the original patch. Stefan