Re: [Qemu-devel] [PATCH] iSCSI: Add support for SG_IO in bdrv_ioctl()

2012-08-21 Thread Paolo Bonzini
Il 21/08/2012 01:59, Ronnie Sahlberg ha scritto: > We need to support SG_IO in the synchronous bdrv_ioctl() since this > is used by scsi-block > > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c | 109 > - > 1 files changed, 108 inse

Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2012-08-21 Thread Paolo Bonzini
Il 20/08/2012 20:11, Jan Kiszka ha scritto: > VCPUs are either resumed directly via vm_start, after the incoming > migration is done, or when a continue command is issued. We don't need > the explicit resume before entering main_loop. > > Signed-off-by: Jan Kiszka > --- > > I was adding nesting

Re: [Qemu-devel] commit da57febfed "qdev: give all devices a canonical path" broke usb_del

2012-08-21 Thread Paolo Bonzini
Il 20/08/2012 19:58, Anthony Liguori ha scritto: > Michael Tokarev writes: > >> On 08.08.2012 17:09, Michael Tokarev wrote: >> [] >>> Something similar should be applied to 1.1-stable. FWIW, some >>> changes are not needed there. >> >> Cherry-pick to stable-1.1 removes the two unneeded hunks. >>

Re: [Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Yonit Halperin
Hi, On 08/21/2012 09:58 AM, Gerd Hoffmann wrote: Hi, +#if SPICE_SERVER_VERSION>= 0x000b02 /* 0.11.2 */ +static void display_start(void) +{ +DisplayListItem *item; + +QLIST_FOREACH(item,&display_list, link) { +item->display->running = true; +} +} I think we should simply

[Qemu-devel] [PATCH v6 11/13] target-mips-ase-dsp: Add MIPS[32|64] ASE DSP[R1|R2] generic cpu model

2012-08-21 Thread Jia Liu
Add MIPS[32|64] ASE DSP[R1|R2] generic cpu model for test. Signed-off-by: Jia Liu --- target-mips/translate_init.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index c39138f..547fa00

[Qemu-devel] [PATCH v6 09/13] target-mips-ase-dsp: Add compare pick instructions

2012-08-21 Thread Jia Liu
Add MIPS ASE DSP Compare-Pick instructions. Signed-off-by: Jia Liu --- target-mips/dsp_helper.c | 917 ++ target-mips/helper.h | 52 +++ target-mips/translate.c | 323 3 files changed, 1292 insertions(+) diff --git a/target-m

[Qemu-devel] [PATCH v6 06/13] target-mips-ase-dsp: Add GPR Based shift instructions

2012-08-21 Thread Jia Liu
Add MIPS ASE DSP GPR-Based Shift instructions. Signed-off-by: Jia Liu --- target-mips/dsp_helper.c | 991 ++ target-mips/helper.h | 62 +++ target-mips/translate.c | 359 + 3 files changed, 1412 insertions(+) diff --git a/targ

[Qemu-devel] [PATCH v6 02/13] target-mips-ase-dsp: Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number

2012-08-21 Thread Jia Liu
Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number. Signed-off-by: Jia Liu --- target-mips/translate.c | 107 +++ 1 file changed, 81 insertions(+), 26 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.

Re: [Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 09:09, Yonit Halperin wrote: > Hi, > On 08/21/2012 09:58 AM, Gerd Hoffmann wrote: >>Hi, >> >>> +#if SPICE_SERVER_VERSION>= 0x000b02 /* 0.11.2 */ >>> +static void display_start(void) >>> +{ >>> +DisplayListItem *item; >>> + >>> +QLIST_FOREACH(item,&display_list, link) { >>> +

Re: [Qemu-devel] qemu log function to print out the registers of the guest

2012-08-21 Thread Max Filippov
On Tue, Aug 21, 2012 at 9:40 AM, Steven wrote: > Hi, Max, > I wrote a small program to verify your patch could catch all the load > instructions from the guest. However, I found some problem from the > results. > > The guest OS and the emulated machine are both 32bit x86. My simple > program in th

[Qemu-devel] [PATCH v6 10/13] target-mips-ase-dsp: Add MIPS ASE DSP Accumulator and DSPControl Access instructions

2012-08-21 Thread Jia Liu
Add MIPS ASE DSP Accumulator and DSPControl Access instructions. Signed-off-by: Jia Liu --- target-mips/dsp_helper.c | 1044 ++ target-mips/helper.h | 52 +++ target-mips/translate.c | 461 3 files changed, 1557 insertions(

[Qemu-devel] Dump guest page table inside QEMU makes system hang

2012-08-21 Thread Wei-Ren Chen
Hi all, I want to dump guest page table when guest writes to cr3, the code snipt below, --- uint32_t pgd[1024][1024]; // guest page table static void dump_guest_pgtable(target_ulong cr3) { int i, j; uint32_t phyaddr = cr3; uint32_t val; for (i = 0; i < NUM_ENTRY; ++i) {

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-08-21 Thread Jan Kiszka
On 2012-08-19 11:42, Avi Kivity wrote: > On 08/17/2012 06:04 PM, Jan Kiszka wrote: >> Can anyone imagine that such a barrier may actually be required? If it is currently possible that env->stop is evaluated before we called into sigtimedwait in qemu_kvm_eat_signals, then we could a

Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2012-08-21 Thread Jan Kiszka
On 2012-08-21 09:01, Paolo Bonzini wrote: > Il 20/08/2012 20:11, Jan Kiszka ha scritto: >> VCPUs are either resumed directly via vm_start, after the incoming >> migration is done, or when a continue command is issued. We don't need >> the explicit resume before entering main_loop. >> >> Signed-off-

[Qemu-devel] [PATCH v6 04/13] target-mips-ase-dsp: Add load instructions

2012-08-21 Thread Jia Liu
Add MIPS ASE DSP Load instructions. Signed-off-by: Jia Liu --- target-mips/translate.c | 69 +++ 1 file changed, 69 insertions(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index b049238..f154f09 100644 --- a/target-mips/translat

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-21 Thread Stefan Priebe - Profihost AG
Am 21.08.2012 00:36, schrieb ronnie sahlberg: On Mon, Aug 20, 2012 at 6:12 PM, Stefan Priebe - Profihost AG wrote: Hi Ronnie, Am 20.08.2012 10:08, schrieb Paolo Bonzini: That's because the "big QEMU lock" is held by the thread that called qemu_aio_cancel. and i also see no cancellation mes

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-21 Thread Paolo Bonzini
> > When performing the UNMAPS, maybe setting timeout to something > > really big, and at the same time also dropping queue-depth to something > > really small so that the guest kernel will not be able to send so > > many UNMAPs concurrently. > > How is this relevant to the fact, that i can't even

Re: [Qemu-devel] x86, nops settings result in kernel crash

2012-08-21 Thread Michael Tokarev
On 20.08.2012 21:13, Tomas Racek wrote: [] Can we trim the old, large and now not-so-relevant discussion please? ;) > I can provide you with more different traces if it can help. But I thought > that maybe it will be more useful for you to try it on your own. So I've > prepared some minimal debi

Re: [Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Gerd Hoffmann
Hi, > +#if SPICE_SERVER_VERSION >= 0x000b02 /* 0.11.2 */ > +static void display_start(void) > +{ > +DisplayListItem *item; > + > +QLIST_FOREACH(item, &display_list, link) { > +item->display->running = true; > +} > +} I think we should simply use a global variable for 'runnin

Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-21 Thread Jan Kiszka
On 2012-08-15 13:08, Peter Maydell wrote: > Move the init of the irqchip_inject_ioctl field of KVMState out of > kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > can be used even when no irqchip is created (for architectures > that support async interrupt notification even without

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-08-21 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 8:21 AM, Jan Kiszka wrote: > On 2012-08-19 11:42, Avi Kivity wrote: >> On 08/17/2012 06:04 PM, Jan Kiszka wrote: >>> > Can anyone imagine that such a barrier may actually be required? If it > is currently possible that env->stop is evaluated before we called into >>

Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-21 Thread Peter Maydell
On 21 August 2012 09:19, Jan Kiszka wrote: > On 2012-08-15 13:08, Peter Maydell wrote: >> Move the init of the irqchip_inject_ioctl field of KVMState out of >> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() >> can be used even when no irqchip is created (for architectures >> that

[Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Cong Meng
This patch adds some queue limit parameters into block drive. And inits them for sg block drive. Some interfaces are also added for accessing them. Signed-off-by: Cong Meng --- block/raw-posix.c | 58 + block_int.h |4 +++ blockdev.

[Qemu-devel] [PATCH 2/2 v1] virtio-scsi: set per-LUN queue limits for sg devices

2012-08-21 Thread Cong Meng
Each virtio scsi HBA has global request queue limits. But the passthrough LUNs (scsi-generic) come from different host HBAs may have different request queue limits. If the guest sends commands that exceed the host limits, the commands will be rejected by host HAB. To address the issue, this patch

[Qemu-devel] [PATCH v1] virtio-scsi: get and set the queue limits for sg device

2012-08-21 Thread Cong Meng
Each virtio scsi HBA has global request queue limits. But the passthrough LUNs (scsi-generic) come from different host HBAs may have different request queue limits. If the guest sends commands that exceed the host limits, the commands will be rejected by host HAB. This patch addresses this issue

Re: [Qemu-devel] [PATCH] usb-redir: Never return USB_RET_NAK for async handled packets

2012-08-21 Thread Gerd Hoffmann
On 08/17/12 17:27, Hans de Goede wrote: > USB_RET_NAK is not a valid response for async handled packets (and will > trigger an assert as such). > > Also drop the warning when receiving a status of cancelled for packets not > cancelled by qemu itself, this can happen when a device gets unredirected

Re: [Qemu-devel] [PATCH] usb: Halt ep queue en cancel pending packets on a packet error

2012-08-21 Thread Gerd Hoffmann
On 08/17/12 15:24, Hans de Goede wrote: > For controllers which queue up more then 1 packet at a time, we must halt the > ep queue, and inside the controller code cancel all pending packets on an > error. Patch added to usb patch queue. thanks, Gerd

[Qemu-devel] [PATCH] Properly use backing file argument to git-img convert

2012-08-21 Thread brad
From: Brad Campbell Converting to an image with an output backing file would write out the contents of the source image whether or not it was already contained in the new backing file. This commit ensures that the source file is checked against the new backing file and output is only allocate

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-21 Thread Natanael Copa
On Mon, 20 Aug 2012 19:53:22 + Blue Swirl wrote: > >> - Do not remove the explicit add of -lm unless Haiku. This was due > >>to > >> http://www.mail-archive.com/qemu-devel@nongnu.org/msg102965.html I > >> am not sure if this is valid, though. > > > > Certainly building a linux-user targe

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Paolo Bonzini
Il 21/08/2012 10:23, Cong Meng ha scritto: > +static void sg_get_queue_limits(BlockDriverState *bs, const char *filename) > +{ > +DIR *ffs; > +struct dirent *d; > +char path[MAXPATHLEN]; > + > +snprintf(path, MAXPATHLEN, > + "/sys/class/scsi_generic/sg%s/device/block/",

Re: [Qemu-devel] [PATCH v1] virtio-scsi: get and set the queue limits for sg device

2012-08-21 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 9:26 AM, Cong Meng wrote: > Each virtio scsi HBA has global request queue limits. But the passthrough > LUNs (scsi-generic) come from different host HBAs may have different request > queue limits. If the guest sends commands that exceed the host limits, the > commands will

[Qemu-devel] [PATCH v3 4/5] spice: add 'migrated' flag to spice info

2012-08-21 Thread Yonit Halperin
The flag is 'true' when spice migration has completed on the src side. It is needed for a case where libvirt dies before migration completes and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED. When libvirt is restored and queries the migration status, it also needs to query spice and check if i

[Qemu-devel] [PATCH v3 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Yonit Halperin
QXLWorker->start/stop are deprecated since spice-server 0.11.2 Signed-off-by: Yonit Halperin --- hw/qxl.c |7 --- ui/spice-core.c|4 ui/spice-display.c | 32 ++-- ui/spice-display.h |9 +++-- 4 files changed, 45 insertions(+),

[Qemu-devel] [PATCH v3 1/5] spice: notify spice server on vm start/stop

2012-08-21 Thread Yonit Halperin
Spice server needs to know about the vm state in order to prevent attempts to write to devices when they are stopped, mainly during the non-live stage of migration. Instead, spice will take care of restoring this writes, on the migration target side, after migration completes. Signed-off-by: Yonit

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-21 Thread Avi Kivity
On 08/21/2012 07:48 AM, liu ping fan wrote: > On Sun, Aug 19, 2012 at 7:36 PM, Avi Kivity wrote: >> On 08/19/2012 02:23 PM, Peter Maydell wrote: >>> On 19 August 2012 11:12, Avi Kivity wrote: On 08/17/2012 10:41 AM, liu ping fan wrote: > And something like omap_mpu_timer_init() in file h

[Qemu-devel] [PATCH v3 3/5] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

2012-08-21 Thread Yonit Halperin
When migrating, libvirt queries the migration status, and upon migration completions, it closes the migration src. On the other hand, when migration is completed, spice transfers data from the src to destination via the client. This data is required for keeping the spice session after migration, wi

[Qemu-devel] [PATCH v3 0/5] add support for spice migration v3

2012-08-21 Thread Yonit Halperin
v3: patch 2: hold a global variable for the state of spice display, instead of one per device. v2: Notify spice about vm state changes only via spice_server_vm_start/stop spice repo: http://cgit.freedesktop.org/~yhalperi/spice/log/?h=seamless-migration.v2 --- Hi, The following

[Qemu-devel] [PATCH v3 5/5] spice: adding seamless-migration option to the command line

2012-08-21 Thread Yonit Halperin
The seamless-migration flag is required in order to identify whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not (by default the flag is off). New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag. When this flag is off, spice fallbacks to it

Re: [Qemu-devel] [RFC/PATCH] qemu: Use valgrind annotations to mark kvm guest memory as defined

2012-08-21 Thread Christian Borntraeger
On 10/08/12 15:11, Christian Borntraeger wrote: > valgrind with kvm produces a big amount of false positives regarding > "Conditional jump or move depends on uninitialised value(s)". This > happens because the guest memory is allocated with qemu_vmalloc which > boils down posix_memalign etc. This f

Re: [Qemu-devel] [PATCH v3 0/5] add support for spice migration v3

2012-08-21 Thread Michal Privoznik
On 21.08.2012 10:51, Yonit Halperin wrote: > v3: > patch 2: hold a global variable for the state of spice display, instead of > one per > device. > > v2: > Notify spice about vm state changes only via spice_server_vm_start/stop > spice repo: > http://cgit.freedesktop.org/~yhalperi/spic

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-21 Thread liu ping fan
On Tue, Aug 21, 2012 at 4:57 PM, Avi Kivity wrote: > On 08/21/2012 07:48 AM, liu ping fan wrote: >> On Sun, Aug 19, 2012 at 7:36 PM, Avi Kivity wrote: >>> On 08/19/2012 02:23 PM, Peter Maydell wrote: On 19 August 2012 11:12, Avi Kivity wrote: > On 08/17/2012 10:41 AM, liu ping fan wrote

Re: [Qemu-devel] x86, nops settings result in kernel crash

2012-08-21 Thread Tomas Racek
> On 20.08.2012 21:13, Tomas Racek wrote: > [] > Can we trim the old, large and now not-so-relevant discussion please? > ;) > > > I can provide you with more different traces if it can help. But I > > thought that maybe it will be more useful for you to try it on > > your own. So I've prepared som

[Qemu-devel] [PATCH v6 13/13] target-mips-ase-dsp: Change TODO

2012-08-21 Thread Jia Liu
Delete DSP r1 & DSP r2 from TODO. Signed-off-by: Jia Liu --- target-mips/TODO |2 -- 1 file changed, 2 deletions(-) diff --git a/target-mips/TODO b/target-mips/TODO index 2a3546f..15d67cd 100644 --- a/target-mips/TODO +++ b/target-mips/TODO @@ -6,8 +6,6 @@ General - Unimplemented ASEs:

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Cong Meng
On Tue 21 Aug 2012 04:48:17 PM CST, Paolo Bonzini wrote: Il 21/08/2012 10:23, Cong Meng ha scritto: +static void sg_get_queue_limits(BlockDriverState *bs, const char *filename) +{ +DIR *ffs; +struct dirent *d; +char path[MAXPATHLEN]; + +snprintf(path, MAXPATHLEN, +

Re: [Qemu-devel] [PATCH v1] virtio-scsi: get and set the queue limits for sg device

2012-08-21 Thread Cong Meng
On Tue 21 Aug 2012 04:53:59 PM CST, Stefan Hajnoczi wrote: On Tue, Aug 21, 2012 at 9:26 AM, Cong Meng wrote: Each virtio scsi HBA has global request queue limits. But the passthrough LUNs (scsi-generic) come from different host HBAs may have different request queue limits. If the guest sends

Re: [Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-21 Thread Alon Levy
> On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote: > > --- > > .gitmodules| 3 +++ > > compiler.h | 7 +++ > > spice-protocol | 1 + > > 3 files changed, 11 insertions(+) > > create mode 16 spice-protocol I accidentally sent this patch, you can see the "(temp)" in the title. >

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-21 Thread Avi Kivity
On 08/20/2012 04:56 PM, Richard Davies wrote: > We're running host kernel 3.5.1 and qemu-kvm 1.1.1. > > I hadn't though about it, but I agree this is related to cpu overcommit. The > slow boots are intermittent (and infrequent) with cpu overcommit whereas I > don't think it occurs without cpu ove

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 9:23 AM, Cong Meng wrote: > This patch adds some queue limit parameters into block drive. And inits them > for sg block drive. Some interfaces are also added for accessing them. > > Signed-off-by: Cong Meng > --- > block/raw-posix.c | 58 > +

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 10:41 AM, Cong Meng wrote: > > > On Tue 21 Aug 2012 04:48:17 PM CST, Paolo Bonzini wrote: >> >> Il 21/08/2012 10:23, Cong Meng ha scritto: >>> >>> +static void sg_get_queue_limits(BlockDriverState *bs, const char >>> *filename) >>> +{ >>> +DIR *ffs; >>> +struct dire

Re: [Qemu-devel] [PATCH 2/2 v1] virtio-scsi: set per-LUN queue limits for sg devices

2012-08-21 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 9:23 AM, Cong Meng wrote: > @@ -557,6 +621,7 @@ static uint32_t virtio_scsi_get_features(VirtIODevice > *vdev, > { > requested_features |= (1UL << VIRTIO_SCSI_F_HOTPLUG); > requested_features |= (1UL << VIRTIO_SCSI_F_CHANGE); > +requested_features |= (1UL <<

Re: [Qemu-devel] [RFC/PATCH] qemu: Use valgrind annotations to mark kvm guest memory as defined

2012-08-21 Thread Avi Kivity
On 08/21/2012 12:03 PM, Christian Borntraeger wrote: > On 10/08/12 15:11, Christian Borntraeger wrote: >> valgrind with kvm produces a big amount of false positives regarding >> "Conditional jump or move depends on uninitialised value(s)". This >> happens because the guest memory is allocated with

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > From: "Daniel P. Berrange" > > > > Add a 'query-target' QAPI command to allow management applications > > to determine what target architecture a QEMU binary is emulating > > without having to p

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:31:38 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > Add a 'query-target' QAPI command to allow management applications > > to determine what target architecture a QEMU binary

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-21 Thread Avi Kivity
On 08/21/2012 12:25 PM, liu ping fan wrote: > On Tue, Aug 21, 2012 at 4:57 PM, Avi Kivity wrote: >> On 08/21/2012 07:48 AM, liu ping fan wrote: >>> On Sun, Aug 19, 2012 at 7:36 PM, Avi Kivity wrote: On 08/19/2012 02:23 PM, Peter Maydell wrote: > On 19 August 2012 11:12, Avi Kivity wrote

Re: [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-21 Thread Benoît Canet
Le Monday 20 Aug 2012 à 14:37:08 (-0600), Eric Blake a écrit : > On 08/20/2012 01:47 PM, Blue Swirl wrote: > > On Mon, Aug 20, 2012 at 11:47 AM, Benoît Canet > > wrote: > >> Valid quorum resources look like: > >> quorum:threshold/total:path/to/image_1: ... :path/to/image_total > >> > >> '\' can e

Re: [Qemu-devel] [PATCH] target-mips: Enable access to required RDHWR hardware registers

2012-08-21 Thread Andreas Färber
Am 21.08.2012 01:41, schrieb Meador Inge: > While running in the usermode emulator all of the MIPS32r2 *required* > RDHWR hardware registers should be accessible (the Linux kernel enables > access to these same registers). > > Signed-off-by: Meador Inge > --- > target-mips/translate.c |7 +++

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-21 Thread Paolo Bonzini
Il 21/08/2012 11:52, Stefan Hajnoczi ha scritto: >>> >> Using /sys/dev/block or /sys/dev/char seems easier, and lets you >>> >> retrieve the parameters for block devices too. >>> >> >> > what do you mean with "block devices"? Using "/dev/sda" instead of >> > "/dev/sg0"? Yes. >>> >> However, I'm

[Qemu-devel] [PATCH v10 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- v9->v10 Use CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC instead of -D directly, define is created in config-host.h so hw/qxl.[ch] is unchanged except for s/QXL_HAS_IO_MONITORS_CONFIG_ASYNC/CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC (Blue Swirl) No other patches changed. Dropped

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Peter Maydell
On 21 August 2012 11:05, Daniel P. Berrange wrote: > On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote: >> "bits" is really ambiguous. What it means in QEMU (specifically the >> value you are returning) is probably not what you expect it to mean. > > My intent was to indicate the po

Re: [Qemu-devel] [RFC] How should QEMU code handle include statements

2012-08-21 Thread Avi Kivity
On 08/20/2012 11:07 PM, Stefan Weil wrote: > While I personally prefer (1) and used it for my first contributions, > QEMU introduced qemu-common.h. I had the impression that from then on > QEMU preferred strategy (2). Obviously not everybody shares that > impression. > > Which strategy / rule do

[Qemu-devel] [PATCH v10 2/4] qxl: disallow unknown revisions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break

Re: [Qemu-devel] TPM does not seem to work under QEMU with TPM patches

2012-08-21 Thread Jordi Cucurull Juan
Hi Kent, I have solved the issue. The problem was that in CentOS the tpm_dis driver is integrated into the kernel and it was not loaded by default. I have added the following keywords to the kernel load line in the bootloader: tpm_tis.force=1 Now the /dev/tpm0 device appears in the virtual m

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 11:17:40AM +0100, Peter Maydell wrote: > On 21 August 2012 11:05, Daniel P. Berrange wrote: > > On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote: > >> "bits" is really ambiguous. What it means in QEMU (specifically the > >> value you are returning) is probab

[Qemu-devel] [PATCH] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- qapi-schema-guest.json |6 +- qapi/qmp-core.h|1 + qapi/qmp-registry.c| 12 qga/commands.c |1 + 4 files changed, 19 inser

Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-21 Thread Jan Kiszka
On 2012-08-21 10:25, Peter Maydell wrote: > On 21 August 2012 09:19, Jan Kiszka wrote: >> On 2012-08-15 13:08, Peter Maydell wrote: >>> Move the init of the irqchip_inject_ioctl field of KVMState out of >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() >>> can be used even when n

[Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-21 Thread Jordi Cucurull Juan
Dear all, After applying the TPM patches to QEMU, I was wondering if it is possible to simultaneously use the TPM in more than one virtual machine, i.e. virtualisation of the TPM. According to the paper "Stefan Berger, Ramón Cáceres, Kenneth A. Goldman, Ronald Perez, Reiner Sailer, Leendert

Re: [Qemu-devel] [PATCH v10 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:16, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > This io calls the corresponding new sp

Re: [Qemu-devel] [PATCH v3 0/5] add support for spice migration v3

2012-08-21 Thread Gerd Hoffmann
> Yonit Halperin (5): > spice: notify spice server on vm start/stop > spice: notify on vm state change only via spice_server_vm_start/stop > spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED > spice: add 'migrated' flag to spice info > spice: adding seamless-migration option to the comm

[Qemu-devel] [PATCH v10 4/4] configure: print spice-protocol and spice-server versions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84fa2c6..02c06aa 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice="yes" libs_softmmu="$libs_softmmu $spice_libs" QEMU_CFLA

Re: [Qemu-devel] [PATCH] PPC: Update openbios-bin

2012-08-21 Thread Andreas Färber
Am 21.08.2012 00:33, schrieb Alexander Graf: > This updates the OpenBIOS binaries for PPC to svn revision 1063, > fixing -M g3beige with large PCI memory users. > > Signed-off-by: Alexander Graf > --- > pc-bios/README |3 ++- > pc-bios/openbios-ppc | Bin 729876 -> 750392 bytes > 2 fi

Re: [Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > buffered_file.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/buffered_file.c b/buffered_file.c > index f170aa0..4148abb 100644 > --- a/buffered_file.c > +++ b/buffered_file.c

[Qemu-devel] [PATCH v10 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= 0.12.0. This io calls the corresponding new spice api spice_qxl_monitors_config_async to let s

Re: [Qemu-devel] [PATCH 2/8] fix migration sync

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > arch_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch_init.c b/arch_init.c > index 9b46bfc..0a9ca85 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -488,6 +488,7 @@ static int ram_save_set

[Qemu-devel] [PATCH v11 2/4] qxl: disallow unknown revisions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break

[Qemu-devel] [PATCH v11 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- v10->v11 fixed coding style: space before square bracket. fixed an old instance too. (Gerd) hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6 +1385,1

[Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Yonit Halperin
Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. Signed-off-by: Yonit Halperin --- qemu-options.hx | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/

Re: [Qemu-devel] [PATCH 3/8] migration: move total_time from ram stats to migration info

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hmp.c| 4 ++-- > migration.c | 6 +++--- > qapi-schema.json | 14 +++--- > qmp-commands.hx | 6 +++--- > 4 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/hmp.c b/hm

Re: [Qemu-devel] [PATCH 5/8] migration: print total downtime for final phase of migration

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hmp.c| 4 > migration.c | 6 +- > migration.h | 1 + > qapi-schema.json | 7 ++- > qmp-commands.hx | 3 +++ > 5 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > arch_init.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 0a9ca85..7eb6e86 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -538,7

Re: [Qemu-devel] [PATCH 7/8] migration: export migrate_get_current()

2012-08-21 Thread Orit Wasserman
On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration.c | 2 +- > migration.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration.c b/migration.c > index 49cd336..186bcf2 100644 > --- a/migration.c > +++ b/migration.c > @@ -

[Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= 0.12.0. This io calls the corresponding new spice api spice_qxl_monitors_config_async to let s

Re: [Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:51, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. All four patches added to spice patch queu

[Qemu-devel] [PATCH v11 4/4] configure: print spice-protocol and spice-server versions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84fa2c6..02c06aa 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice="yes" libs_softmmu="$libs_softmmu $spice_libs" QEMU_CFLA

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:54, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-21 Thread liu ping fan
On Tue, Aug 21, 2012 at 6:13 PM, Avi Kivity wrote: > On 08/21/2012 12:25 PM, liu ping fan wrote: >> On Tue, Aug 21, 2012 at 4:57 PM, Avi Kivity wrote: >>> On 08/21/2012 07:48 AM, liu ping fan wrote: On Sun, Aug 19, 2012 at 7:36 PM, Avi Kivity wrote: > On 08/19/2012 02:23 PM, Peter Mayde

Re: [Qemu-devel] [PATCH] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Paolo Bonzini
Il 21/08/2012 12:25, Michal Privoznik ha scritto: > +bool qmp_command_reports_success(const char *name) { > +QmpCommand *cmd; > + > +QTAILQ_FOREACH(cmd, &qmp_commands, node) { > +if (strcmp(cmd->name, name) == 0) { > +return cmd->options ^ QCO_NO_SUCCESS_RESP; Clever...

[Qemu-devel] [PATCH v2] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- diff to v1: -changed condition in qmp_command_reports_success per Paolo's advice qapi-schema-guest.json |6 +- qapi/qmp-core.h|1 + qapi/qmp-registry.c

Re: [Qemu-devel] [PATCH v4] linux-user: fix emulation of getdents

2012-08-21 Thread Peter Maydell
On 20 August 2012 23:13, Dmitry V. Levin wrote: > In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last > byte of the target dirent structure (aka d_type byte) was never copied > from the host dirent structure, thus breaking everything that relies > on valid d_type value, e.g. glob(

[Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Eric Blake
On 08/21/2012 06:03 AM, Michal Privoznik wrote: > This is a useful hint for users (or libvirt) whether a command returns > anything success and hence wait for reply or not. > --- > diff to v1: > -changed condition in qmp_command_reports_success per Paolo's advice > > qapi-schema-guest.json |6

Re: [Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Eric Blake
On 08/21/2012 06:17 AM, Eric Blake wrote: > On 08/21/2012 06:03 AM, Michal Privoznik wrote: >> This is a useful hint for users (or libvirt) whether a command returns >> anything success and hence wait for reply or not. >> +++ b/qapi-schema-guest.json >> @@ -91,10 +91,14 @@ >> # >> # @enabled: wh

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Eric Blake
On 08/21/2012 04:54 AM, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. For older released, this is true; but for future versions of qemu, libvirt would much rather learn this informa

Re: [Qemu-devel] [PATCH V2 0/6] virtio-trace: Support virtio-trace

2012-08-21 Thread Masami Hiramatsu
(2012/08/21 14:16), Amit Shah wrote: > On (Thu) 09 Aug 2012 [21:30:29], Yoshihiro YUNOMAE wrote: >> Hi All, >> >> The following patch set provides a low-overhead system for collecting kernel >> tracing data of guests by a host in a virtualization environment. > > ACK this series. Thank you! > I

[Qemu-devel] [PATCH for-1.2 v3] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- diff to v2: -fixed typo and field description diff to v1: -changed condition in qmp_command_reports_success per Paolo's advice qapi-schema-guest.json |6 +- qapi/q

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-21 Thread Avi Kivity
On 08/21/2012 02:18 PM, liu ping fan wrote: >> >>> But as >>> it will also take the code path which has object_ref(Object*), so it >>> has to convert, otherwise the code will corrupt. >>> That is what I want to express. >> >> Option 2, for example, had MemoryRegionOps::object(MemoryRegion *) which

Re: [Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 13:06, Gerd Hoffmann wrote: > On 08/21/12 12:51, Alon Levy wrote: >> Revision bumped to 4 for new IO support, enabled for spice-server >= >> 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and >> defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= >> 0.12.

[Qemu-devel] [PATCH 3/3] linux-user: fix statfs

2012-08-21 Thread Alexander Graf
The statfs syscall should always memset(0) its full struct extent before writing to it. Newer versions of the syscall use one of the reserved fields for flags, which would otherwise get stale values from uncleaned memory. This fixes libarchive for me, which got confused about the return value of p

[Qemu-devel] [PATCH 2/3] linux-user: implement FS_IOC_SETFLAGS ioctl

2012-08-21 Thread Alexander Graf
Signed-off-by: Alexander Graf --- linux-user/ioctls.h |1 + linux-user/syscall_defs.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 1b798b3..5027c74 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@ -

[Qemu-devel] [PATCH 1/3] linux-user: implement FS_IOC_GETFLAGS ioctl

2012-08-21 Thread Alexander Graf
Signed-off-by: Alexander Graf --- linux-user/ioctls.h |1 + linux-user/syscall_defs.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index bb76c56..1b798b3 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@

[Qemu-devel] [PATCH 0/3] linux-user: Assorted fixed for libarchive

2012-08-21 Thread Alexander Graf
Howdy, While running libarchive's test suite in qemu-arm, I ran into a few linux-user bugs and unimplemented ioctls. The statfs one is really nasty. IMHO it's 1.2 material. There's also a bug outstanding for libarchive where FIEMAP doesn't seem to work properly. I haven't gotten around to track

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Luiz Capitulino
On Tue, 21 Aug 2012 11:07:50 +0100 "Daniel P. Berrange" wrote: > On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote: > > On Mon, 20 Aug 2012 15:31:38 +0100 > > "Daniel P. Berrange" wrote: > > > > > From: "Daniel P. Berrange" > > > > > > Add a 'query-target' QAPI command to allow

  1   2   3   >