Re: [Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

2012-08-06 Thread Amos Kong
- Original Message - > [cc: Amos] > > Luiz Capitulino writes: > > > This error is currently returned by inet_connect_opts(), however > > it causes the follow spurious message on HMP: > > > > (qemu) migrate tcp:0: > > migrate: Connection can not be completed immediately We us

Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-06 Thread Gerd Hoffmann
> diff --git a/configure b/configure > index cef0a71..5fcd315 100755 > --- a/configure > +++ b/configure > @@ -2630,7 +2630,7 @@ EOF >spice_cflags=$($pkg_config --cflags spice-protocol spice-server > 2>/dev/null) >spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) >

[Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/

2012-08-06 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- target-arm/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 29008a4..494c682 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -9892,7 +9892,7 @@

Re: [Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present

2012-08-06 Thread Gerd Hoffmann
On 07/28/12 17:27, Kevin O'Connor wrote: > On Thu, Jul 26, 2012 at 03:38:47PM +, Alexey Korolev wrote: >> HI, >> >> Current version of Seabios is causing blue screen on Windows2003 when 64bit >> PCI resource is present and occupies high memory. >> >> BSOD Error code is: 0x00A5 (0x02, 0xFFF

[Qemu-devel] [PATCH] ISCSI: Pick default initiator-name based on the name of the VM

2012-08-06 Thread ronniesahlberg
From: Ronnie Sahlberg This patch updates the iscsi layer to automatically pick a 'unique' initiator-name based on the name of the vm in case the user has not set an explicit iqn-name to use. Create a new function qemu_get_vm_name() that returns the name of the VM, if specified. This way we c

Re: [Qemu-devel] [PATCH] ISCSI: Pick default initiator-name based on the name of the VM

2012-08-06 Thread Paolo Bonzini
Il 06/08/2012 10:24, ronniesahlb...@gmail.com ha scritto: > diff --git a/block/iscsi.c b/block/iscsi.c > index 993a86d..243496b 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -896,23 +896,31 @@ static char *parse_initiator_name(const char *target) > QemuOptsList *list; > QemuOpts

Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic > SSI slave state (e.g. the CS line state). This is more me being confused about how this should work than a review comment, but it seems a bit odd that we have a

Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-06 Thread Peter Maydell
On 6 August 2012 10:13, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic >> SSI slave state (e.g. the CS line state). > > This is more me being confused about how this should work than a

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 03.08.2012 00:21, schrieb Corey Bryant: >>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >>> int ret; >>> int mode = 0; >>> >>> +#ifndef _WIN32 >>> +const char *fdset_id_str; >>> + >>> +/* Attempt dup of fd from fd set */ >>> +if (strstart(name, "/d

Re: [Qemu-devel] [PATCH v5 03/15] ssi: Implemented CS behaviour

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Added default CS behaviour for SSI slaves. SSI devices can set a property > to enable CS behaviour which will create a GPIO on the device which is the > CS. Tristating of the bus on SSI transfers is implemented. > > Signed-off-by: Peter A. G

Re: [Qemu-devel] [PATCH v5 04/15] ssi: Added create_slave_no_init()

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Slave creation function that can be used to create an SSI slave without > qdev_init() being called. This give machine models a change to set properties. Not convinced about this one -- I think that if machine models need to do more complica

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Kevin Wolf
Am 01.08.2012 17:15, schrieb Paolo Bonzini: > Il 01/08/2012 16:59, Kevin Wolf ha scritto: >> Block jobs aren't really different from guests in that respect. Maybe >> the BB needs a second iostatus field that must explicitly be reset, and >> the old one keeps doing the stupid thing for compatibility

Re: [Qemu-devel] [PATCH v5 05/15] qdev: allow multiple qdev_init_gpio_in() calls

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Allow multiple qdev_init_gpio_in() calls for the one device. The first call > will > define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be > handled > with different handlers. Needed when two levels of the QOM class heir

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 06:16 AM, Peter A. G. Crosthwaite wrote: Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite --- hw/Makefile.objs |1 + hw/fifo.c| 79 ++ hw/fifo.h|

Re: [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error.

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > To be more consistent with the newer ways of error signalling. That and SIGABT > is easier to debug with than exit(1). > > Signed-off-by: Peter A. G. Crosthwaite Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Paolo Bonzini
Il 06/08/2012 11:29, Kevin Wolf ha scritto: >>> >> Block jobs aren't really different from guests in that respect. Maybe >>> >> the BB needs a second iostatus field that must explicitly be reset, and >>> >> the old one keeps doing the stupid thing for compatibility's sake. >> > >> > Or the iostatu

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Added a FIFO API that can be used to create and operate byte FIFOs. I'm not asking for actual conversions, but it would be nice to see a list of some devices that could in principle be moved to using this FIFO, as an indication of its gener

Re: [Qemu-devel] [PATCH v5 12/15] petalogix-ml605: added SPI controller with n25q128

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Added SPI controller to the reference design, with two n25q128 spi-flashes > connected. > > Signed-off-by: Peter A. G. Crosthwaite > --- > hw/petalogix_ml605_mmu.c | 28 +++- > 1 files changed, 27 insertions(+), 1

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 06:16 AM, Peter A. G. Crosthwaite wrote: Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite --- hw/Makefile.objs |1 + hw/fifo.c| 79 ++ hw/fifo.h|

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-06 Thread Kevin Wolf
Am 02.08.2012 09:20, schrieb Kevin Shanahan: > On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: Set the block driver read_only flag for cdrom de

Re: [Qemu-devel] [PATCH V2] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-06 Thread Stefan Hajnoczi
On Mon, Aug 6, 2012 at 3:18 AM, Dong Xu Wang wrote: > > Signed-off-by: Dong Xu Wang > --- > v1->v2: fix param leak. > > qemu-img.c | 28 +--- > 1 files changed, 17 insertions(+), 11 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Peter Maydell
On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: > +static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s) > +{ > +bool page_aligned = false; > +unsigned int n, begin; > +const uint16_t block_size = s->blksize & 0x0fff; > +uint32_t boundary_chk = 1 << (((s->blksize & 0x

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 11:44, schrieb Paolo Bonzini: > Il 06/08/2012 11:29, Kevin Wolf ha scritto: >> Block jobs aren't really different from guests in that respect. Maybe >> the BB needs a second iostatus field that must explicitly be reset, and >> the old one keeps doing the stupid thing for c

Re: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing

2012-08-06 Thread Lei Li
Ping? On 07/20/2012 07:09 AM, Anthony Liguori wrote: Lei Li writes: tcp_chr_write() did not deal with writing to an unconnected connection and return the original length of the data, it's not right and would cause false writing. So (re-)connect it and return 0 for this situation. Signed-off-

Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-08-06 Thread Peter Maydell
On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: > +static uint64_t > +exynos4210_sdhci_readfn(void *opaque, target_phys_addr_t offset, unsigned > size) > +{ > +Exynos4SDHCIState *s = (Exynos4SDHCIState *)opaque; > +uint32_t ret; > + > +switch (offset & ~0x3) { > +case SDHC

Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: Convert MemCharDriver to circular buffer

2012-08-06 Thread Lei Li
On 08/02/2012 05:30 AM, Anthony Liguori wrote: Lei Li writes: Signed-off-by: Lei Li --- qemu-char.c | 96 +++--- qemu-char.h |2 +- 2 files changed, 78 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c2

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Paolo Bonzini
Il 06/08/2012 12:45, Kevin Wolf ha scritto: >> In the long term >> we will add the failing blockdev name to the blockjob iostatus. > I think you misunderstood. What I was trying to say is that with the > same reasoning we'd need a field that doesn't automatically reset its > status on 'cont' not on

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Peter Maydell
On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: > From: Igor Mitsyanko > > Device model for standard SD Host Controller Interface (SDHCI) compliant with > version 2.00 of SD association specification. > +typedef struct ADMADescr { > +target_phys_addr_t addr; > +uint16_t length; >

Re: [Qemu-devel] [PATCH V2] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 12:14, schrieb Stefan Hajnoczi: > On Mon, Aug 6, 2012 at 3:18 AM, Dong Xu Wang > wrote: >> >> Signed-off-by: Dong Xu Wang >> --- >> v1->v2: fix param leak. >> >> qemu-img.c | 28 +--- >> 1 files changed, 17 insertions(+), 11 deletions(-) > > Reviewed-by:

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 02:30 PM, Peter Maydell wrote: On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: +static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s) +{ +bool page_aligned = false; +unsigned int n, begin; +const uint16_t block_size = s->blksize & 0x0fff; +uint32_t bo

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Peter Maydell
On 6 August 2012 12:28, Igor Mitsyanko wrote: > On 08/06/2012 02:30 PM, Peter Maydell wrote: >>> +static void get_adma_description(SDHCIState *s, ADMADescr *dscr) >>> +{ >>> +uint32_t adma1 = 0; >>> +uint64_t adma2 = 0; >>> +target_phys_addr_t entry_addr = (target_phys_addr_t)s->admasy

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 03:15 PM, Peter Maydell wrote: On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: From: Igor Mitsyanko Device model for standard SD Host Controller Interface (SDHCI) compliant with version 2.00 of SD association specification. +typedef struct ADMADescr { +target_phys_add

Re: [Qemu-devel] vga-pci and MMIO BAR

2012-08-06 Thread Gerd Hoffmann
On 07/25/12 05:57, Benjamin Herrenschmidt wrote: > Hi folks ! > > Would there be any objection to adding a second MMIO BAR to qemu-vga > which mirrors the bochs magic VBE ports ? No. > Once done, I'd like to look into doing a qemudrmfb similar to the cirrus > one that pretty much gives you gener

Re: [Qemu-devel] KVM segfaults with 3.5 while installing ubuntu 12.04

2012-08-06 Thread Avi Kivity
On 08/06/2012 11:46 AM, Stefan Priebe - Profihost AG wrote: > But still i got the segfault and core dump - this is my main problem? I > mean qemu-kvm master isn't declared as stable. So i don't care about the > slowness here. > > What can we do about the core dump and crash? Okay, I reproduced i

Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 02:56 PM, Peter Maydell wrote: On 6 August 2012 04:25, Peter A. G. Crosthwaite wrote: +static uint64_t +exynos4210_sdhci_readfn(void *opaque, target_phys_addr_t offset, unsigned size) +{ +Exynos4SDHCIState *s = (Exynos4SDHCIState *)opaque; +uint32_t ret; + +switch (of

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Igor Mitsyanko
Recently I've noticed that drive_get_next() usage is not very convenient if you want to use specific SD controller interface. Maybe we should switch from drive_get_next() to DEFINE_PROP_DRIVE()? It'll still preserve "-sd .." behaviour. What do you think Peter?

Re: [Qemu-devel] KVM segfaults with 3.5 while installing ubuntu 12.04

2012-08-06 Thread Avi Kivity
On 08/06/2012 03:12 PM, Avi Kivity wrote: > On 08/06/2012 11:46 AM, Stefan Priebe - Profihost AG wrote: > >> But still i got the segfault and core dump - this is my main problem? I >> mean qemu-kvm master isn't declared as stable. So i don't care about the >> slowness here. >> >> What can we do a

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Igor Mitsyanko
On 08/06/2012 01:48 PM, Peter Maydell wrote: On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: Added a FIFO API that can be used to create and operate byte FIFOs. I'm not asking for actual conversions, but it would be nice to see a list of some devices that could in principle be moved to

Re: [Qemu-devel] KVM segfaults with 3.5 while installing ubuntu 12.04

2012-08-06 Thread Avi Kivity
On 08/06/2012 03:37 PM, Avi Kivity wrote: > On 08/06/2012 03:12 PM, Avi Kivity wrote: >> On 08/06/2012 11:46 AM, Stefan Priebe - Profihost AG wrote: >> >>> But still i got the segfault and core dump - this is my main problem? I >>> mean qemu-kvm master isn't declared as stable. So i don't care abo

Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling

2012-08-06 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 5:16 PM, Paolo Bonzini wrote: > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net > because it always registers the virtio_pci_host_notifier_read() handler > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. > The result is both QEMU an

[Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands

2012-08-06 Thread Avi Kivity
The scsi passthrough handler falls through after completing a request into the failure path, resulting in a use after free. Reprducible by running a guest with aio=native on a block device. Reported-by: Stefan Priebe Signed-off-by: Avi Kivity --- hw/virtio-blk.c | 1 + 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH] linux-user: Fix SNDCTL_DSP_MAP{IN, OUT}BUF ioctl definitions

2012-08-06 Thread Peter Maydell
Ping? Patchwork url: http://patchwork.ozlabs.org/patch/172731/ -- PMM On 23 July 2012 19:06, Peter Maydell wrote: > Fix the SNDCTL_DSP_MAP{IN,OUT}BUF ioctl definitions so that they > refer to a suitably defined target struct layout rather than hardcoding > the ioctl number. This fixes complaints

Re: [Qemu-devel] [PATCH] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-06 Thread Peter Maydell
Ping? Patchwork url: http://patchwork.ozlabs.org/patch/172732/ -- PMM On 23 July 2012 19:07, Peter Maydell wrote: > The code to initialise the target_to_host_errno_table[] array was > accidentally inside the loop through checking and initialising all > the supported ioctls. This was harmless bu

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
On 07/30/12 14:08, Benjamin Herrenschmidt wrote: > On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: >> Let's balkanize some more then? >> >> No, qxl is our paravirt vga, we should improve it instead of spawning >> new ones (which will be horrible in the eyes of the next person to look >> at the

Re: [Qemu-devel] [RFC 00/27]: add new error format

2012-08-06 Thread Luiz Capitulino
On Mon, 6 Aug 2012 02:35:03 -0400 (EDT) Amos Kong wrote: > - Original Message - > > On Thu, 02 Aug 2012 10:31:28 +0800 > > Amos Kong wrote: > > > > > On 01/08/12 21:29, Luiz Capitulino wrote: > > > > On Wed, 01 Aug 2012 19:33:27 +0800 > > > > Amos Kong wrote: > > > > > > > >> On 31/07/

Re: [Qemu-devel] [PATCH] linux-user: Fix incorrect TARGET_BLKBSZGET, TARGET_BLKBSZSET

2012-08-06 Thread Peter Maydell
Ping? Patchwork URL: http://patchwork.ozlabs.org/patch/172730/ let me know if you want a v2 patch rather than just hand-fixing the signed-off-by line snafu. thanks -- PMM On 23 July 2012 19:05, Peter Maydell wrote: > The definitions for the ioctl numbers TARGET_BLKBSZGET and > TARGET_BLKBSZSET

Re: [Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands

2012-08-06 Thread Stefan Hajnoczi
On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity wrote: > The scsi passthrough handler falls through after completing a > request into the failure path, resulting in a use after free. > > Reprducible by running a guest with aio=native on a block device. > > Reported-by: Stefan Priebe > Signed-off-by: A

Re: [Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands

2012-08-06 Thread Avi Kivity
On 08/06/2012 04:11 PM, Stefan Hajnoczi wrote: > On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity wrote: >> The scsi passthrough handler falls through after completing a >> request into the failure path, resulting in a use after free. >> >> Reprducible by running a guest with aio=native on a block devic

Re: [Qemu-devel] [PATCHv5 3/4] Adding qemu-seccomp-debug.[ch]

2012-08-06 Thread Eduardo Otubo
On Fri, Aug 03, 2012 at 03:54:40PM -0500, Anthony Liguori wrote: > Eduardo Otubo writes: > > > The new 'trap' (debug) mode will capture the illegal system call before it > > is > > executed. The feature and the implementation is based on Will Drewry's > > patch - https://lkml.org/lkml/2012/4/12/

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, Hi, > Minor improvements to stdvga actual help qxl (presumably). qxl still > provides a vga interface which is used when guest drivers aren't > available. > > It's not clear to me why it doesn't enable VBE but presumably if it did, > then accelerations could be mapped through VBE. QXL a

Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling

2012-08-06 Thread Paolo Bonzini
Il 06/08/2012 14:48, Stefan Hajnoczi ha scritto: >> > Interesting, I tested vhost (or thought so). Can you try this >> > patch instead? > Does this really make the code better than just reverting the patch? The main problem here is that the current code has calls to event_notifier

[Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Paolo Bonzini
Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net because it always registers the virtio_pci_host_notifier_read() handler function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. The result is both QEMU and vhost_net.ko polling on the same eventfd and the virtio_net.

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Corey Bryant
On 08/06/2012 05:15 AM, Kevin Wolf wrote: Am 03.08.2012 00:21, schrieb Corey Bryant: @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) int ret; int mode = 0; +#ifndef _WIN32 +const char *fdset_id_str; + +/* Attempt dup of fd from fd set */ +if (strs

Re: [Qemu-devel] [PATCH] fips: fix build on !Linux

2012-08-06 Thread Paul Moore
On Friday, August 03, 2012 06:31:38 PM Anthony Liguori wrote: > Commit 0f66998 makes -enable-fips conditional on Linux hosts but then uses > it unconditionally in vl.c. > > Fix this by moving the fips handling to os-posix.c and adding a condition. Sorry for not catching this, thanks for the fix.

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Stefan Hajnoczi
On Mon, Aug 6, 2012 at 2:26 PM, Paolo Bonzini wrote: > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net > because it always registers the virtio_pci_host_notifier_read() handler > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. > The result is both QEMU an

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, > QXL has a lot of short comings. Here's a short list: > > - It's 100% PC centric. It requires PCI and is completely oblivious to > endianness. No. The endianess is actually clearly defined. It's little endian for both guest/host interface (aka qxl) and the network protocol. So it i

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Paolo Bonzini
Il 06/08/2012 15:39, Stefan Hajnoczi ha scritto: >> > hw/virtio-pci.c | 14 +++--- >> > hw/virtio.c | 7 +-- >> > hw/virtio.h | 3 ++- >> > 3 file modificati, 14 inserzioni(+), 10 rimozioni(-) > Internationalized diff stat, I never noticed... :) Must be new with the latest u

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 15:32, schrieb Corey Bryant: > On 08/06/2012 05:15 AM, Kevin Wolf wrote: >> Am 03.08.2012 00:21, schrieb Corey Bryant: > @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >int ret; >int mode = 0; > > +#ifndef _WIN32 > +cons

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, > The latter sounds like a better long term approach, however it lacks > backward compat with qemu-vga, but I doubt it's a big deal especially if > we provide a working VBE ROM for x86. A vbe rom isn't a big deal. You probably want support the 0x01CE and 0x01CF ports (on x86) so the vgabio

Re: [Qemu-devel] [PATCH] eventfd: making it thread safe

2012-08-06 Thread Avi Kivity
On 08/01/2012 07:05 AM, David Gibson wrote: > From: Alexey Kardashevskiy > > QEMU uses IO handlers to run select() in the main loop. > The handlers list is managed by qemu_set_fd_handler() helper > which works fine when called from the main thread as it is > called when select() is not waiting. >

Re: [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/

2012-08-06 Thread Andreas Färber
Am 06.08.2012 09:05, schrieb Peter A. G. Crosthwaite: > Signed-off-by: Peter A. G. Crosthwaite > --- > target-arm/translate.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 29008a4..494c682 100644 > --- a/tar

Re: [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/

2012-08-06 Thread Peter Maydell
On 6 August 2012 08:05, Peter A. G. Crosthwaite wrote: > Signed-off-by: Peter A. G. Crosthwaite > --- > target-arm/translate.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 29008a4..494c682 100644 > --- a/ta

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Corey Bryant
On 08/06/2012 09:51 AM, Kevin Wolf wrote: Am 06.08.2012 15:32, schrieb Corey Bryant: On 08/06/2012 05:15 AM, Kevin Wolf wrote: Am 03.08.2012 00:21, schrieb Corey Bryant: @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) int ret; int mode = 0; +#ifndef _WIN3

Re: [Qemu-devel] [PATCH master/stable] virtio-mlk: fix use-after-free while handling scsi commands

2012-08-06 Thread Andreas Färber
Am 06.08.2012 15:11, schrieb Stefan Hajnoczi: > On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity wrote: >> The scsi passthrough handler falls through after completing a >> request into the failure path, resulting in a use after free. >> >> Reprducible by running a guest with aio=native on a block device

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using > migrate-set-apabilities QMP command. s/set-apabilities/set-capabilities/ > The management can query the current migration capabilities using > query-migrate-capabilitie

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > >> QXL has a lot of short comings. Here's a short list: >> >> - It's 100% PC centric. It requires PCI and is completely oblivious to >> endianness. > > No. The endianess is actually clearly defined. It's little endian for > both guest/host interface (aka qxl

[Qemu-devel] [Bug 897750] Re: libvirt/kvm problem with disk attach/detach/reattach on running virt

2012-08-06 Thread Serge Hallyn
@Stefan, I'm confused too. I don't have the VM I saw that on available right now, but think it was a quantal image built from the net install cd. On a precise server image, pci_hotplug is indeed built in. acpiphp is NOT being auto-loaded. ( smoser <) -- You received this bug notifi

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-08-06 Thread Paolo Bonzini
The patch at http://permalink.gmane.org/gmane.comp.emulators.qemu/162828 fixes it for ioeventfd=on (the bug is that the ioeventfd is not added to the select() arguments), but I and Avi disagreed on whether ioeventfd=off works. :) Jamie/Richard/Georg, can you test your respective reproducers withou

[Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Paolo Bonzini
Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net because it always registers the virtio_pci_host_notifier_read() handler function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. The result is both QEMU and vhost_net.ko polling on the same eventfd and the virtio_net.

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-08-06 Thread Stefan Hajnoczi
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven wrote: > i debugged my initial problem further and found out that the problem happens > to be that > the main thread is stuck in pause_all_vcpus() on reset or quit commands in > the monitor > if one cpu is stuck in the do-while loop kvm_cpu_exec. If I

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-06 Thread Corey Minyard
On 08/02/2012 04:05 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/02/2012 01:32 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 09:40 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 08:15 PM, Kevin O'Connor wrote: Well, I should also probably add

[Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Bhushan Bharat-R65777
Hi Avi/All, I am facing issue to boot KVM guest on x86 (I used to work on PowerPC platform and do not have enough knowledge of x86). I am working on making VFIO working on PowerPC Booke, So I have cloned Alex Williamsons git repository, compiled kernel for x86 on fedora with virtualization conf

Re: [Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 136 > +++ > 1 files changed, 136 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > diff --git a/docs/xbzrle.txt b/d

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Stefan Hajnoczi
On Mon, Aug 6, 2012 at 3:56 PM, Paolo Bonzini wrote: > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net > because it always registers the virtio_pci_host_notifier_read() handler > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. > The result is both QEMU an

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > New query-migrate-cache-size QMP command and 'info migrat

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qapi-schema.json > @@ -264,11 +264,18 @@ > #migration has ended, it

Re: [Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Avi Kivity
On 08/06/2012 06:40 PM, Bhushan Bharat-R65777 wrote: > Hi Avi/All, > > I am facing issue to boot KVM guest on x86 (I used to work on PowerPC > platform and do not have enough knowledge of x86). I am working on making > VFIO working on PowerPC Booke, So I have cloned Alex Williamsons git > repos

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 28 > hmp.c| 13 +++

Re: [Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Alex Williamson
On Mon, 2012-08-06 at 15:40 +, Bhushan Bharat-R65777 wrote: > Hi Avi/All, > > I am facing issue to boot KVM guest on x86 (I used to work on PowerPC > platform and do not have enough knowledge of x86). I am working on making > VFIO working on PowerPC Booke, So I have cloned Alex Williamsons g

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Orit Wasserman
On 08/06/2012 05:26 PM, Eric Blake wrote: > On 08/05/2012 03:13 AM, Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate-set-apabilities QMP command. > > s/set-apabilities/set-capabilities/ > >> The management can query the current

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Eric Blake
On 08/06/2012 10:04 AM, Orit Wasserman wrote: > On 08/06/2012 05:26 PM, Eric Blake wrote: >> On 08/05/2012 03:13 AM, Orit Wasserman wrote: >>> The management can enable/disable a capability for the next migration by >>> using >>> migrate-set-apabilities QMP command. >> >> s/set-apabilities/set-cap

[Qemu-devel] [PATCH] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
Fix a variety of typos in comments in target-arm files. Signed-off-by: Peter Maydell --- Includes all the ones I spotted but not the 'middel' fix which Peter C has already submitted a patch for, so the two patches shouldn't conflict. target-arm/arm-semi.c|2 +- target-arm/cpu.h

Re: [Qemu-devel] [PATCH] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
On 6 August 2012 17:33, Peter Maydell wrote: > Fix a variety of typos in comments in target-arm files. > -/* Handling addition overflow with 64 bits inputs values is more > - * tricky than with 32 bits values. */ > +/* Handling addition overflow with 64 bit inputs values is more > + * tricky tha

[Qemu-devel] [PATCH v2] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
Fix a variety of typos in comments in target-arm files. Signed-off-by: Peter Maydell --- Changes v1->v2: s/inputs values/input values/ target-arm/arm-semi.c|2 +- target-arm/cpu.h |2 +- target-arm/helper.c |6 +++--- target-arm/neon_helper.c | 26 +---

[Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-06 Thread Peter Maydell
Move the init of the irqchip_inject_ioctl field of KVMState out of kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() can be used even when no irqchip is created (for architectures that support async interrupt notification even without an in kernel irqchip). Signed-off-by: Peter Mayde

Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Eric Blake
On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > New query-migrate-cache-size QMP command and 'info migrat

Re: [Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats

2012-08-06 Thread Eric Blake
On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman Sparse on the commit message. You need to document why the change is safe (namely, call out which commit introduced 'total_time' in the first place, and the fact that the commit is not part of 1.1, so we are fixing an

Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Orit Wasserman
On 08/06/2012 09:13 PM, Eric Blake wrote: > On 08/06/2012 11:51 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2, it will >> be >> rounded down to the nearest power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> New q

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Eric Blake
On 08/06/2012 10:28 AM, Orit Wasserman wrote: >> That is, BOTH commands end up iterating over a list of caps, and output >> identical information in the case where caps exist of 'name: state' for >> each capability. >> > The information is different: > the first: > MigrationCapabilityStatusList *

[Qemu-devel] [PATCH 12/12] Restart optimization on stage3 update version

2012-08-06 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5f864a6..5181953 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

[Qemu-devel] [PATCH 00/12] Migration next v11

2012-08-06 Thread Orit Wasserman
Changes from v10: remove query-migrate-supported-capabilities commands. Update documentation. Replace total_time with total-time fix other comments by Eric Changes from v9: rename query-migrtion-supported-capabilities to query-migrate-supported-capabilities rename 'info migration_supported_capabi

[Qemu-devel] [PATCH 11/12] Add XBZRLE statistics

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 28 hmp.c| 13 + migration.c | 17 + migrati

[Qemu-devel] [PATCH 04/12] Add cache handling functions

2012-08-06 Thread Orit Wasserman
Add MRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + cutils.c |9 ++ include/qemu/page_cache.h |

[Qemu-devel] [PATCH 00/12] Migration next v12

2012-08-06 Thread Orit Wasserman
Changes from v11: Fix example for query-migrate-cache-size commands Move patch 10 (Change total_time to total-time) to patch 9 and fix comment. Changes from v10: remove query-migrate-supported-capabilities commands. Update documentation. Replace total_time with total-time fix other comments by Eri

[Qemu-devel] [PATCH 01/12] Add migration capabilities

2012-08-06 Thread Orit Wasserman
The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use 'info migrate_capabilities' HMP command. Currently only XBZRLE capability is available. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- hmp-commands.hx |

[Qemu-devel] [PATCH 06/12] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-08-06 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia Signed-off-by: Pe

[Qemu-devel] [PATCH 09/12] Change total_time to total-time in MigrationStats

2012-08-06 Thread Orit Wasserman
migration total_time was introduced in commit d5f8a5701d3690b5ec0c34b6a5c0b5a24d274540 for QEMU 1.2 Signed-off-by: Orit Wasserman --- qapi-schema.json |4 ++-- qmp-commands.hx |9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.jso

[Qemu-devel] [PATCH 10/12] Add migration accounting for normal and duplicate pages

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 38 ++ hmp.c|6 ++ migration.c |6 ++ migration.h

[Qemu-devel] [PATCH 07/12] Add XBZRLE to ram_save_block and ram_save_live

2012-08-06 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed, then send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-

[Qemu-devel] [PATCH 12/12] Restart optimization on stage3 update version

2012-08-06 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5f864a6..5181953 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

  1   2   >