On 6 August 2012 10:13, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > <peter.crosthwa...@petalogix.com> wrote: >> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic >> SSI slave state (e.g. the CS line state). > > This is more me being confused about how this should work than a > review comment, but it seems a bit odd that we have a hierarchy > Device->SSI->ADS7846[etc], where the VMState for the ADS7846 > includes a field for the SSI VMState, but the SSI VMState doesn't > include a field for the Device VMState. > > What you've done here matches how i2c works currently, but I've > just cc'd Anthony and Juan to check whether there's a better way > of doing it.
Oh, and just to mention the obvious, if we add fields to these vmstates we need to bump the version numbers. -- PMM
