On 29 June 2012 02:50, Catalin Patulea wrote:
> On Thu, Jun 28, 2012 at 2:25 PM, Peter Maydell
> wrote:
>> No new code should be using the uint64 &c types (which are
>> "at least NN bits wide") -- uint64_t or uint_fast64_t please.
> Ok, changed some {int -> flag} and {uint64 -> uint64_t}.
>
> Th
Verified this bug against latest qemu-kvm upstream.
kvm + qemu-kvm: ae7a2a3f + a212f79f..
The following commit fixed it.
commit a212f79fc4596570124fb864425b980c157cd001
Author: Jason Wang
Date: Thu May 17 13:25:43 2012 +0800
rtl8139: validate rx ring before receiving packets
Commit ff
Am 29.06.2012 02:50, schrieb Peter Crosthwaite:
>>
>> The problem I see is:
>>
>> FDTMachineInfo *fdt_generic_create_machine()
>> {
>>...
>>while (qemu_co_queue_enter_next(fdti->cq));
>> }
>>
>> The problem you have is not that the block layer is yielding. The
>> problem is that you need t
On Jun 29, 2012 6:24 PM, "Kevin Wolf" wrote:
>
> Am 29.06.2012 02:50, schrieb Peter Crosthwaite:
> >>
> >> The problem I see is:
> >>
> >> FDTMachineInfo *fdt_generic_create_machine()
> >> {
> >>...
> >>while (qemu_co_queue_enter_next(fdti->cq));
> >> }
> >>
> >> The problem you have is no
Sorry, correct mailing list address. :)
Add the prefix of the subject.
On 06/29/2012 04:27 PM, Li Zhang wrote:
From: Li Zhang
v1 -> v2:
* Convert USB option from char to bool.
v2 -> v3:
* Remove global USB option
* Get USB option with qemu_opt_get_bool().
* Send vga patch
Sorry, correct mailing list address. :)
On 06/29/2012 04:27 PM, Li Zhang wrote:
From: Li Zhang
pSeries machine needs to enable USB to add a USB
keyboard or USB mouse. -usb option won't be used in
the future, and machine options are a better way to
enable USB.
So this patch is to add USB optio
Correct mailing list address.
On 06/29/2012 04:27 PM, Li Zhang wrote:
From: Li Zhang
Functions pci_vga_init() and pci_cirrus_vga_init() are decleared
in pc.h. That prevents other platforms (e.g. sPAPR) to use them.
This patch is to create one new file vga-pci.h and move the
decleartions to vg
Correct mailing list address.
On 06/29/2012 04:27 PM, Li Zhang wrote:
From: Li Zhang
Now that the declearations of pci_vga_init() and pci_cirrus_vga_init()
are moved to vga-pci.h. So it's necessary to cleanup pc.h on the
platforms which include the file and add vga-pci.h.
This patch is to cle
Correct mailing list address. :)
On 06/29/2012 04:27 PM, Li Zhang wrote:
From: Li Zhang
Also instanciate the USB keyboard and mouse when that option is used
(you can still use -device to create individual devices without all
the defaults)
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by:
On Fri, Jun 29, 2012 at 01:31:01PM +1000, Peter Crosthwaite wrote:
> Hi Edgar,
>
> I think for little ones like this, ill start a microblaze-devs patch
> queue and periodically send pull requests. Ill send the patches singly
> to qemu-devel for ACK and NACK as I create them, then [PULL] every
> co
Public bug reported:
Environment:
Host OS (ia32/ia32e/IA64):ia32e
Guest OS (ia32/ia32e/IA64):ia32e
Guest OS Type (Linux/Windows):Linux(RHEL6u1)
kvm.git Commit:ae7a2a3fb6f8b784c2752863f4f1f20c656f76fb
qemu-kvm Commit:a212f79fc4596570124fb864425b980c157cd001
Host Kernel Version:3.5.0-rc
Orit Wasserman wrote:
> From: Isaku Yamahata
>
> Signed-off-by: Isaku Yamahata
> ---
> block-migration.c |8
> migration.c | 13 -
> migration.h |8 ++--
> qemu-common.h |1 +
> savevm.c | 13 +
> sysemu.h |
On 18.06.2012, at 10:24, Li Zhang wrote:
> On Mon, Jun 18, 2012 at 3:54 PM, Peter Crosthwaite
> wrote:
>>>
>>> 3. Can't have USB: fail if the user tries to enable it.
>>>
>>> Code sketch:
>>>
>>>/* init USB devices */
>>>if (!machine->has_usb) {
>>>if (usb_enabled)
>>>
Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
Posted for pulling for Anthony.
Later, Juan.
Orit Wasserman wrote:
> Signed-off-by: Benoit Hudzia
> Signed-off-by: Petter Svard
> Signed-off-by: Aidan Shribman
> Signed-off-by: Orit Wasserman
Asked Anthony also for pull.
Later, Juan.
Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
Also integrated in the pull request.
Later, Juan.
On 26 June 2012 06:13, Peter A. G. Crosthwaite
wrote:
> target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200)
>
> are available in the git repository at:
> git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next
Sorry I haven't got round to reviewing th
On 20 June 2012 00:58, Peter Chubb wrote:
> For Linux to be able to work out how fast its clocks are going, so
> that timer ticks come approximately at the right time, it needs to
> be able to query the clock control module (CCM).
>
> This is the start of a CCM implementation. It currently knows
On 20 June 2012 00:58, Peter Chubb wrote:
> Implement the timers on the Freescale i.MX31 SoC.
> This is not a complete implementation, but gives enough for
> Linux to boot and run. In particular external triggers, which are
> not useful under QEMU, are not implemented.
>
>
> Signed-off-by: Philip
On 20 June 2012 00:58, Peter Chubb wrote:
> Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built
> around the Freescale i.MX31.
>
>
> Signed-off-by: Philip O'Sullivan
> Signed-off-by: Peter Chubb
Reviewed-by: Peter Maydell
-- PMM
On 06/28/2012 11:22 PM, Juan Quintela wrote:
Notice that the live migration users never unregister, so no problem
about freeing the ops structure.
Signed-off-by: Juan Quintela
---
arch_init.c |9 +++--
block-migration.c | 10 --
migration.h |4 ++--
savevm
Peter Crosthwaite writes:
> On Jun 29, 2012 6:24 PM, "Kevin Wolf" wrote:
>>
>> Am 29.06.2012 02:50, schrieb Peter Crosthwaite:
>> >>
>> >> The problem I see is:
>> >>
>> >> FDTMachineInfo *fdt_generic_create_machine()
>> >> {
>> >>...
>> >>while (qemu_co_queue_enter_next(fdti->cq));
>> >
Blue Swirl wrote:
> On Thu, Jun 28, 2012 at 7:22 PM, Juan Quintela wrote:
>> We split it into 2 functions, foo_live_iterate, and foo_live_complete.
>> At this point, we only remove the bits that are for the other stage,
>> functionally this is equivalent to previous code.
>>
>> Signed-off-by: Jua
Igor Mitsyanko wrote:
> On 06/28/2012 11:22 PM, Juan Quintela wrote:
>> Notice that the live migration users never unregister, so no problem
>> about freeing the ops structure.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> arch_init.c |9 +++--
>> block-migration.c | 10
Can anoyne explain to me the consequences of my patch btw? I am
struggling to see how co-routines actually call into the block layer
API (without already being there) such that these fast paths are even
activated?
>>>
>>> No, the assumption is a completely different one and it has nothing to
>>> d
On 20 June 2012 00:57, Peter Chubb wrote:
> Changes since V9: Added MAINTAINERS entry, rebased (and tested)
> against git tip.
I've added this series to arm-devs.next. Sorry it's taken me a while
to get round to reviewing it.
-- PMM
Hi
v2:
- Change Migration params from int to bool (Orit)
- Change %ld to %PRIu64 (Blue found it)
- cc Anthony O:-)
Atacched the interdiff, it is trivial, instead of repost all patches
(changes are really trivial).
Anthony, please pull.
v1:
Here are the patches that were reviewed and had no com
Am 26.06.2012 05:18, schrieb Evgeny Voevodin:
> On 25.06.2012 16:00, Andreas Färber wrote:
>> Am 25.06.2012 13:46, schrieb Evgeny Voevodin:
>>> On 25.06.2012 13:24, Andreas Färber wrote:
Am 25.06.2012 09:55, schrieb Oleg Ogurtsov:
> Signed-off-by: Oleg Ogurtsov
> ---
>hw/arm/Ma
Am 28.06.2012 19:51, schrieb Peter Maydell:
> On 20 June 2012 15:44, Anthony Liguori wrote:
>> This avoids the problem associated with having multiple target specific files
>> in a single directory with the current build system.
>>
>> We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj fi
On 06/29/2012 04:41 AM, Juan Quintela wrote:
> Orit Wasserman wrote:
>> Signed-off-by: Orit Wasserman
>
> Posted for pulling for Anthony.
Did this include the hunk that I pointed out about 11/13 being in the
wrong patch?
>
>> @@ -389,7 +509,7 @@ int ram_save_live(QEMUFile *f, int stage, void
Am 28.06.2012 18:46, schrieb Peter Maydell:
> On 20 June 2012 18:28, Rabin Vincent wrote:
>> Add a minimal dump-guest-memory support for ARM. The -p option is not
>> supported and we don't add any QEMU-specific notes.
>
> So what does this patch give us? This commit message is pretty
> short and
On 29 June 2012 13:26, Andreas Färber wrote:
> Am 26.06.2012 05:18, schrieb Evgeny Voevodin:
>> Oh, I see. Should we place this device to hw/Makefile.objs in v2?
>
> That would've been nice, but I'll do it as a follow-up now.
It's not clear to me that we actually have consensus on what
goes in hw
On 29 June 2012 13:42, Andreas Färber wrote:
> Am 28.06.2012 18:46, schrieb Peter Maydell:
>> On 20 June 2012 18:28, Rabin Vincent wrote:
>>> +int cpu_write_elf64_note(write_core_dump_function f, CPUArchState *env,
>>> + int cpuid, void *opaque)
>>
>> Should these APIs rea
Am 28.06.2012 01:00, schrieb Catalin Patulea:
> Hey guys,
>
> I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to
> be implemented using SoftFloat only. This was motivated by some correctness
> issues
> that we noticed with the current implementation which follows the AM
Am 29.06.2012 15:06, schrieb Peter Maydell:
> On 29 June 2012 13:26, Andreas Färber wrote:
>> Am 26.06.2012 05:18, schrieb Evgeny Voevodin:
>>> Oh, I see. Should we place this device to hw/Makefile.objs in v2?
>>
>> That would've been nice, but I'll do it as a follow-up now.
>
> It's not clear to
On 29 June 2012 14:13, Andreas Färber wrote:
> Am 28.06.2012 01:00, schrieb Catalin Patulea:
>> /*
>> +| Returns 1 if the extended double-precision floating-point value `a' is an
>> +| unsupported; otherwise returns 0.
>>
On 25 June 2012 16:47, solar wrote:
> QEMU emulator version 1.1.0, Copyright (c) 2003-2008 Fabrice Bellard
>
> parameters used: qemu-system-arm -M versatilepb -m 256 -net nic -net
> user,hostfwd=tcp::40022-:22 -nographic -hda debian-6-armel.img -kernel
> vmlinuz-2.6.32-5-versatile -initrd initrd.i
Am 29.06.2012 10:27, schrieb Li Zhang:
> From: Li Zhang
>
> pSeries machine needs to enable USB to add a USB
> keyboard or USB mouse. -usb option won't be used in
> the future, and machine options are a better way to
> enable USB.
>
> So this patch is to add USB option to machine options
> (-mac
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v2: improve manpage description
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 7 ++-
3 files changed, 26 insertions(+
On 06/28/2012 12:51 PM, Peter Maydell wrote:
On 20 June 2012 15:44, Anthony Liguori wrote:
This avoids the problem associated with having multiple target specific files
in a single directory with the current build system.
We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too
Am 29.06.2012 10:27, schrieb Li Zhang:
> From: Li Zhang
>
> Functions pci_vga_init() and pci_cirrus_vga_init() are decleared
"declared"
> in pc.h. That prevents other platforms (e.g. sPAPR) to use them.
>
> This patch is to create one new file vga-pci.h and move the
> decleartions to vga-pci.
Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> On Mon, 25 Jun 2012 22:26:58 +0200
> Jan Kiszka wrote:
>
>> On 2012-06-25 18:55, Luiz Capitulino wrote:
>>> Allow for disabling memory merge support (KSM on Linux), which is
>>> enabled by default otherwise.
>>
>> -machine mem_merge=on|off?
>
> Tha
On 06/29/2012 09:00 AM, Luiz Capitulino wrote:
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v2: improve manpage description
exec.c | 19 ---
qemu-config.c | 4
qemu-option
On Fri, 29 Jun 2012 09:18:09 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:00 AM, Luiz Capitulino wrote:
> > Allows to disable memory merge support (KSM on Linux), which is enabled
> > by default otherwise.
> >
> > Signed-off-by: Luiz Capitulino
> > ---
> >
> > o v2: improve manpage description
On Fri, 29 Jun 2012 16:18:14 +0200
Andreas Färber wrote:
> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> > On Mon, 25 Jun 2012 22:26:58 +0200
> > Jan Kiszka wrote:
> >
> >> On 2012-06-25 18:55, Luiz Capitulino wrote:
> >>> Allow for disabling memory merge support (KSM on Linux), which is
> >>
On 2012-06-29 16:25, Anthony Liguori wrote:
> On 06/29/2012 09:18 AM, Andreas Färber wrote:
>> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
>>> On Mon, 25 Jun 2012 22:26:58 +0200
>>> Jan Kiszka wrote:
>>>
On 2012-06-25 18:55, Luiz Capitulino wrote:
> Allow for disabling memory merge supp
On Fri, 29 Jun 2012 09:25:36 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:18 AM, Andreas Färber wrote:
> > Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >> On Mon, 25 Jun 2012 22:26:58 +0200
> >> Jan Kiszka wrote:
> >>
> >>> On 2012-06-25 18:55, Luiz Capitulino wrote:
> Allow for disab
On 06/29/2012 09:18 AM, Andreas Färber wrote:
Am 25.06.2012 22:39, schrieb Luiz Capitulino:
On Mon, 25 Jun 2012 22:26:58 +0200
Jan Kiszka wrote:
On 2012-06-25 18:55, Luiz Capitulino wrote:
Allow for disabling memory merge support (KSM on Linux), which is
enabled by default otherwise.
-mach
On Fri, 29 Jun 2012 16:30:19 +0200
Jan Kiszka wrote:
> On 2012-06-29 16:25, Anthony Liguori wrote:
> > On 06/29/2012 09:18 AM, Andreas Färber wrote:
> >> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >>> On Mon, 25 Jun 2012 22:26:58 +0200
> >>> Jan Kiszka wrote:
> >>>
> On 2012-06-25 18:5
On 06/29/2012 02:59 PM, Peter Maydell wrote:
On 26 June 2012 06:13, Peter A. G. Crosthwaite
wrote:
target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200)
are available in the git repository at:
git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v3: rename madvise_mergeable() to memory_try_enable_merging()
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 7 ++-
3
On 29 June 2012 15:52, Igor Mitsyanko wrote:
> On 06/29/2012 02:59 PM, Peter Maydell wrote:
>> The irq code looks dubious: we seem to have a single output
>> irq, but the code does things like:
>> qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errintsts);
>> but in other code paths:
>>
Am 29.06.2012 02:34, schrieb Peter Crosthwaite:
> On Thu, Jun 28, 2012 at 11:05 PM, Andreas Färber wrote:
>> Am 28.06.2012 03:08, schrieb Peter Crosthwaite:
>>> On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf wrote:
>> [...]
[...] Why did commas in names work before, but now don't? Or p
On 06/29/2012 07:01 PM, Peter Maydell wrote:
On 29 June 2012 15:52, Igor Mitsyanko wrote:
On 06/29/2012 02:59 PM, Peter Maydell wrote:
The irq code looks dubious: we seem to have a single output
irq, but the code does things like:
qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errin
Am 29.06.2012 08:41, schrieb Dunrong Huang:
> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type
> safety but raises compile error of incompatible pointer type.
What's the difference between the signatures?
Regards,
Andreas
> Fix it by casting to correct function type
>
> S
On 06/28/2012 03:49 PM, Blue Swirl wrote:
On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori wrote:
On 06/21/2012 03:04 AM, Avi Kivity wrote:
On 06/19/2012 09:58 PM, Blue Swirl wrote:
At least qemu-ifup/down scripts, migration exec and smbd have been
mentioned. Only the system calls made by
In particular, don't set disk type and geometry when a CD-ROM on bus
ide.0 has media during CMOS initialization.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index bca53d0..077ba87 10064
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have
a geometry. scsi-block sho
On Thu, Jun 28, 2012 at 04:06:24PM +0900, MORITA Kazutaka wrote:
>
> 'offset' is the offset of the sheepdog object. I think it should be
> 'done' since we need to pass the number of skip bytes.
Indeed. Odd that mny tests didn't catch this.
>
> > goto done;
> > }
hd_geometry_guess() picks geometry and translation. Callers can get
the geometry directly, via parameters, but for translation they need
to go through the block layer.
Add a parameter for translation, so it can optionally be gotten just
like geometry. In preparation of purging translation from t
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 02eb5c2..94e6c30 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,15 +321,16 @@ static v
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 15 +++
hw/qdev.h|3 +++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 002c7f9..0b18f8c 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-pr
This isn't quite orthodox. CHS translation is firmware configuration,
communicated via the RTC's CMOS RAM, not a property of the disk. But
it's best to treat it just like geometry anyway.
Maintain backward compatibility exactly like for geometry: fall back
to DriveInfo's translation, set with -d
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 94e6c30..ca1c1e9 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -368,6 +368,27 @@
Hi all,
I would like to use qemu to emulate a muliticore PowerPC PReP machine but it
see that the SMP is not
supported for the PReP architecture. In fact, running:
qemu-system-ppc -M prep -smp 2
It returns this message:
Number of SMP cpus requested (2), exceeds max cpus supported by mach
Eric Blake wrote:
> On 06/29/2012 04:41 AM, Juan Quintela wrote:
>> Orit Wasserman wrote:
>>> Signed-off-by: Orit Wasserman
>>
>> Posted for pulling for Anthony.
>
> Did this include the hunk that I pointed out about 11/13 being in the
> wrong patch?
Nopis. Adding it.
>>> @@ -389,7 +509,7 @
These patches add exynos4210 Clock Management Unit emulation
and usage of it by exynos4210 UART
Maksim Kozlov (2):
ARM: exynos4210: CMU support
exynos4210: UART: Added using of CMU-callback functionality
hw/arm/Makefile.objs |1 +
hw/exynos4210.c | 16 +
hw/exynos4210.h | 4
Add using of functionality provided by CMU - get_rate and
register_clock_handler.
Signed-off-by: Maksim Kozlov
---
hw/exynos4210_uart.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c
index
vvfat creates a virtual VFAT filesystem with a certain logical
geometry that depends on its options. It sets the "geometry hint" to
this geometry. It is the only block driver to do this.
The geometry hint is about about *physical* geometry, and used only by
certain hard disk device models.
vvfa
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 22 --
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 4e47ec6..40609a1 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -110,8 +110,7 @@ static void gue
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/s390-virtio-
Due to queuing/pipelining, there can now be multiple packets per
endpoint in flight. So the assertion in usb_packet_complete became wrong
and can cause bogus QEMU terminations. Seen with a passed-through USB
headset.
Signed-off-by: Jan Kiszka
---
I'm not 100% sure that the assertion that the ass
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
blockdev.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/core.c|
Instead of flushing pending coalesced MMIO requests on every vmexit,
this provides a mechanism to selectively flush when memory regions
related to the coalesced one are accessed. This first of all includes
the coalesced region itself but can also applied to other regions, e.g.
of the same device, b
Commit 5bbdbb46 moved it to block.c because "other geometry guessing
functions already reside in block.c". Device-specific functionality
should be kept in device code, not the block layer. Move it back.
Disk geometry guessing is still in block.c. To be moved out in a
later patch series.
Bonus:
Hi
v3:
Anthony thinks that a Pull request v3 is a bit too much, so here we are
with a normal patch series. Only one change since pull request 2.
- Add missing chuck about migration_end() (Reported by eblake).
Please, review.
v2:
- Change Migration params from int to bool (Orit)
- Change %ld to
Leave it to ide_init_drive().
Signed-off-by: Markus Armbruster
---
blockdev.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 37521b5..d5f2f57 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -330,15 +330,15 @@ DriveInfo *drive_init(QemuOpts
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for ide-hd. ide-drive is legacy. ide-cd doesn't have a
geometry.
Bonus: info qtre
Orit Wasserman wrote:
> It will return 0 if the page is unmodifed.
>
> Signed-off-by: Orit Wasserman
This does another thing, it adds stage parameter to ram_save_block(),
and it "shouldn't" need it (famous last words).
> -static int ram_save_block(QEMUFile *f)
> +static int ram_save_block(QEMUF
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 84 +++---
1 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 70eb116..3f3070b 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index a9e8b74..81c2e54 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -483,6 +483,9 @@ int ram_load(QEMUFile *f, vo
Each test litters /tmp with several files: a pid file and two
sockets. Tidy up.
Signed-off-by: Markus Armbruster
---
tests/libqtest.c | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 071b6be..02d0392
Add exynos4210 Clock Management Units emulation
Signed-off-by: Maksim Kozlov
---
hw/arm/Makefile.objs |1 +
hw/exynos4210.c | 16 +
hw/exynos4210.h | 42 ++
hw/exynos4210_cmu.c | 1462 ++
4 files changed, 1521 insertions(+), 0 de
This allows to know how long each section takes to save.
An awk script like this tells us sections that takes more that 10ms
$1 ~ /savevm_state_iterate_end/ {
/* Print savevm_section_end line when > 10ms duration */
if ($2 > 1) {
printf("%s times_missing=%u\n",
To prepare move of guess_disk_lchs() into hw/, where it poking
BlockDriverState member io_limits_enabled directly would be unclean.
Signed-off-by: Markus Armbruster
---
block.c | 24 +---
block.h |2 ++
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/blo
bdrv_get_floppy_geometry_hint() fails to store through its parameter
drive when bs has a geometry hint. Makes fd_revalidate() assign
random crap to drv->drive.
Has been broken that way for ages. Harmless, because:
* The only way to set a geometry hint is -drive if=none,cyls=...
Since commit c
Currently, it is split between hd_geometry_guess() and
pc_cmos_init_late(). Confusing. info qtree shows the result of the
former. Also confusing.
Fold the part done in pc_cmos_init_late() into hd_geometry_guess().
Signed-off-by: Markus Armbruster
---
blockdev.h |1 +
hw/hd-geometry
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by: Markus Armbruster
---
hw
Calculate the number of dirty pages takes a lot on hosts with lots
of memory. Just maintain how many pages are dirty.
Signed-off-by: Juan Quintela
---
arch_init.c | 15 +--
cpu-all.h |1 +
exec-obsolete.h | 10 ++
3 files changed, 12 insertions(+), 14 delet
So far covers only IDE and tests only CMOS contents.
Signed-off-by: Markus Armbruster
---
tests/Makefile |2 +
tests/hd-geo-test.c | 402 +++
2 files changed, 404 insertions(+), 0 deletions(-)
create mode 100644 tests/hd-geo-test.c
diff
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happy.
Signed-off-by: Markus
In preparation of purging it from the block layer, which will happen
later in this series.
Signed-off-by: Markus Armbruster
---
blockdev.c |4
blockdev.h |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9e0a72a..4d3b707 100644
--- a/
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 3f3070b..4e47ec6 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -88,14 +88,31 @@ stat
ram_save_remaining() is an expensive operation when there is a lot of memory.
So we only call the function when we need it.
Signed-off-by: Juan Quintela
---
arch_init.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index f5fd1f5..64
When hd_geometry_guess() picks a geometry, it also picks the
appropriate translation, but only when the prior translation hint is
BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior
translation would be passed to the BIOS whether it's suitable for the
geometry or not.
Fortunately, that c
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c | 33 +++--
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index cfa1af2..78b3c0c 100644
--- a/arch_init.c
+++ b/arch_init.c
@
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 78b3c0c..f5fd1f5 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -304,6 +304,11 @@ stati
From: Orit Wasserman
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/arch_init
Refactor the code that is only needed for tcg to an static function.
Call that only when tcg is enabled. We can't refactor to a dummy
function in the kvm case, as qemu can be compiled at the same time
with tcg and kvm.
Signed-off-by: Juan Quintela
---
exec.c | 31 +
If buffers are full, don't iterate, just exit.
Signed-off-by: Juan Quintela
---
savevm.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/savevm.c b/savevm.c
index 987c6c0..a15c163 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1626,6 +1626,9 @@ int qemu_savevm_state_iterate(QEMUFile *f)
1 - 100 of 141 matches
Mail list logo
