Am 29.06.2012 02:34, schrieb Peter Crosthwaite: > On Thu, Jun 28, 2012 at 11:05 PM, Andreas Färber <afaer...@suse.de> wrote: >> Am 28.06.2012 03:08, schrieb Peter Crosthwaite: >>> On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf <ag...@suse.de> wrote: >>>> >> [...] >>>> [...] Why did commas in names work before, but now don't? Or put >>>> differently: Was this change on purpose? >> [...] >>> The -device command line arg. E.G. qemu-system-microblaze -device >>> xilinx.axidma,foo=bar, ... >>> >>> If I have ,'s in the device name i need to escape them as they are >>> syntax in -device. >> >> QOM is perfectly capable of handling commas and SPARC uses "SUNW,", too. >> Using QMP in the future (Markus' RFC) should not be a problem either. >> >> Do you really need to construct board-level devices using -device? >> >> Maybe you have a suggestion to fix the syntax escaping issue for >> Anthony's suggested -object? Because a comma is rather common in OF/FDT. > > Yeh, our names are OF/FDT based, which is where the commas come from. > I got rid of the comma though as something of a take the most > defensive approach and handle the rest in external tools. > >> >> Adjusting device names to match what your Xilinx tool set uses sounds >> very reasonable. But translating from "," to "." in two places does not >> sound superior to translating from "," to ",," in one place to me? Maybe >> I'm misunderstanding something? It might help to introduce QOM-style >> TYPE_ constants, then the name is in a single location only. > > So does escaping ","s with -device work today?
I never needed it myself but I remember reading that for file names ",," (double comma) escaping was introduced. I would assume that to be implemented at QemuOpts level so that it should work for random parameters, and after all the device name is translated to a regular driver= parameter, too. If that doesn't work I would consider it a bug. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
