Re: [Qemu-devel] [PATCH 1/5] i82378: Remove bogus MMIO coalescing

2012-06-25 Thread Hervé Poussineau
Jan Kiszka a écrit : This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. CC: A

Re: [Qemu-devel] [PATCH 1/5] i82378: Remove bogus MMIO coalescing

2012-06-25 Thread Andreas Färber
Am 25.06.2012 09:11, schrieb Hervé Poussineau: > Jan Kiszka a écrit : >> This MMIO area is an entry gate to legacy PC ISA devices, addressed via >> PIO over there. Quite a few of the PIO ports have side effects on access >> like starting/stopping timers that must be executed properly ordered >> /wr

[Qemu-devel] [PATCH 0/5] kvm: Get coalesced MMIO flushing out of the hot-path

2012-06-25 Thread Jan Kiszka
We currently flush the coalesced MMIO buffer on every vmexit to userspace. KVM only provides a single buffer per VM, so a central lock is required to read from it. This is a contention point given a large enough VCPU set. Moreover, we need to hold the BQL while replaying the queued requests, probab

[Qemu-devel] [PATCH 4/5] VGA: Flush coalesced MMIO on related MMIO/PIO accesses

2012-06-25 Thread Jan Kiszka
In preparation of stopping to flush coalesced MMIO unconditionally on vmexits, mark VGA MMIO and PIO regions as synchronous /wrt coalesced MMIO and flush the buffer explicitly on PIO accesses that do not use generic memory regions yet. Signed-off-by: Jan Kiszka --- hw/cirrus_vga.c |7 +++

[Qemu-devel] [PATCH 2/5] memory: Flush coalesced MMIO on selected region access

2012-06-25 Thread Jan Kiszka
Instead of flushing pending coalesced MMIO requests on every vmexit, this provides a mechanism to selectively flush when memory regions related to the coalesced one are accessed. This first of all includes the coalesced region itself but can also applied to other regions, e.g. of the same device, b

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Andreas Färber
Am 25.06.2012 03:51, schrieb Peter Crosthwaite: > Ping! @PMM > > You rejected my workaround in V2 (i.e. using -dtb to force is_linux) > on the grounds that youd "accept some reasonable way of saying "this > ELF file is a Linux kernel"," That brings us back to V1 - this patch. > Any objections? I

[Qemu-devel] buildbot failure in qemu on default_openbsd_current

2012-06-25 Thread qemu
The Buildbot has detected a new failure on builder default_openbsd_current while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/298 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: brad_openbsd

[Qemu-devel] [PATCH 5/5] kvm: Stop flushing coalesced MMIO on vmexit

2012-06-25 Thread Jan Kiszka
The memory subsystem will now take care of flushing whenever affected regions are accessed or the memory mapping changes. Signed-off-by: Jan Kiszka --- kvm-all.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index f8e4328..a1d32f6 100644 --- a/kv

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Peter Crosthwaite
On Mon, Jun 25, 2012 at 5:31 PM, Andreas Färber wrote: > Am 25.06.2012 03:51, schrieb Peter Crosthwaite: >> Ping! @PMM >> >> You rejected my workaround in V2 (i.e. using -dtb to force is_linux) >> on the grounds that youd "accept some reasonable way of saying "this >> ELF file is a Linux kernel","

[Qemu-devel] [PATCH 1/5] i82378: Remove bogus MMIO coalescing

2012-06-25 Thread Jan Kiszka
This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. CC: Andreas Färber CC: Herv

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Implement hotplug support for virtio-scsi

2012-06-25 Thread mc
Quoting Stefan Hajnoczi : On Wed, Jun 20, 2012 at 7:47 AM, Cong Meng wrote: Implement the hotplug() and hot_unplug() interfaces in virtio-scsi, by signal the virtio_scsi.ko in guest kernel via event virtual queue. The counterpart patch of virtio_scsi.ko will be sent soon in another thread.

[Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Jan Kiszka
Flush pending coalesced MMIO before performing mapping or state changes that could affect the event orderings or route the buffered requests to a wrong region. Signed-off-by: Jan Kiszka In addition, we also have to --- memory.c | 23 +++ 1 files changed, 23 insertions(+),

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Peter Maydell
On 25 June 2012 02:51, Peter Crosthwaite wrote: > You rejected my workaround in V2 (i.e. using -dtb to force is_linux) > on the grounds that youd "accept some reasonable way of saying "this > ELF file is a Linux kernel"," That brings us back to V1 - this patch. > Any objections? I'd really like t

Re: [Qemu-devel] [PATCH 2/5] memory: Flush coalesced MMIO on selected region access

2012-06-25 Thread Avi Kivity
On 06/25/2012 10:00 AM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also ap

[Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-06-25 Thread Mike Lovell
Hi all, Here is something I've been tinkering with the past few weeks and now have it in a state where the basic idea makes sense, it works, and could use some feedback from the community. This is what I've been calling QDES or QEMU Distributed Ethernet Switch. I first had the idea when I was pla

[Qemu-devel] [PATCH] Initial commit for QDES - QEMU Distributed Ethernet Switch

2012-06-25 Thread Mike Lovell
This commit adds a new network backend to QEMU. It combines the basic behavior of the unicast udp and multicast socket backends with some intelligence about the source and destination of the packets. It also adds a header to the packets to allow for creating multiple logical networks using the same

[Qemu-devel] [Bug 1013467] Re: network in bridge mode doesn't work in SMP Linux guest

2012-06-25 Thread Xuekun Hu
The regression is due to the patch of "rtl8139: do the network/host communication only in normal operating mode". (Commit ff71f2e8cacefae99179993204172bc65e4303df). However after applying the patch, someone already reported this issue. (http://comments.gmane.org/gmane.comp.emulators.qemu/150064)

Re: [Qemu-devel] [PATCH] Initial commit for QDES - QEMU Distributed Ethernet Switch

2012-06-25 Thread Mike Lovell
I'm not sure why but it looks like my intro email for this got eaten by something. Here it is again and sorry if it shows up twice. This is my first time posting to the list and submitting a patch and I guess something doesn't like the way I did it. - Hi all, Here is something I've been ti

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
This patch add RTC device Oleg Ogurtsov (1): Exynos4: added RTC device hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_rtc.c diff --git a/hw/arm/Makefile.

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Andreas Färber
Am 25.06.2012 09:01, schrieb Jan Kiszka: > Flush pending coalesced MMIO before performing mapping or state changes > that could affect the event orderings or route the buffered requests to > a wrong region. > > Signed-off-by: Jan Kiszka > > In addition, we also have to Stray paste or missing a

Re: [Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

2012-06-25 Thread Kevin Wolf
Am 24.06.2012 19:15, schrieb Hervé Poussineau: > This patchset adds a PCI connection to the 53c9x emulation already > present in QEMU. The emulated card is the AMD PCscsi adapter, > and has been tested on multiple Microsoft operating systems. > > Changes v1 -> v2: > - use qemu_log_mask(LOG_UNIMP,

Re: [Qemu-devel] [PATCH v6 5/6] fdc_test: update media_change test

2012-06-25 Thread Kevin Wolf
Am 24.06.2012 08:16, schrieb Blue Swirl: > On Fri, Jun 22, 2012 at 10:33 AM, Pavel Hrdina wrote: >> After rewrite DSKCHG bit handling the test has to be updated. Now >> is needed to seek to different track to clear DSKCHG bit. >> >> Signed-off-by: Pavel Hrdina >> --- >> tests/fdc-test.c | 29 +

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Evgeny Voevodin
On 25.06.2012 11:55, Oleg Ogurtsov wrote: Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Peter Crosthwaite
On Mon, Jun 25, 2012 at 5:59 PM, Peter Maydell wrote: > On 25 June 2012 02:51, Peter Crosthwaite > wrote: >> You rejected my workaround in V2 (i.e. using -dtb to force is_linux) >> on the grounds that youd "accept some reasonable way of saying "this >> ELF file is a Linux kernel"," That brings us

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Avi Kivity
On 06/25/2012 10:01 AM, Jan Kiszka wrote: > Flush pending coalesced MMIO before performing mapping or state changes > that could affect the event orderings or route the buffered requests to > a wrong region. > > Signed-off-by: Jan Kiszka > > In addition, we also have to Yes, we do. > > void

Re: [Qemu-devel] [PATCH v6 08/16] target-or32: Add instruction tanslation

2012-06-25 Thread Max Filippov
On Mon, Jun 25, 2012 at 6:50 AM, Jia Liu wrote: > Hi Max, > > On Thu, Jun 21, 2012 at 6:24 PM, Max Filippov wrote: >> On Thu, Jun 21, 2012 at 6:58 AM, Jia Liu wrote: >>> Add OpenRISC instruction tanslation routines. >>> >>> Signed-off-by: Jia Liu >> >> [...] >> >>> +    case 0x0009: >>> +      

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Peter Maydell
On 25 June 2012 09:55, Peter Crosthwaite wrote: > As for architectures, I can speak for Microblaze and the PPC > bootloader for virtex_ml507. The DTB will blob in regardless of > whether its an elf or not, so no is_linux switch is needed there for > my Linux elfs. There is no functional difference

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Implement hotplug support for virtio-scsi

2012-06-25 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 03:51:13AM -0400, m...@linux.vnet.ibm.com wrote: > > Quoting Stefan Hajnoczi : > > >On Wed, Jun 20, 2012 at 7:47 AM, Cong Meng wrote: > >>Implement the hotplug() and hot_unplug() interfaces in virtio-scsi, > >>by signal > >>the virtio_scsi.ko in guest kernel via event vir

Re: [Qemu-devel] [PATCH v4 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-06-25 Thread Stefan Hajnoczi
On Fri, Jun 22, 2012 at 01:31:17PM -0600, Eric Blake wrote: > On 06/22/2012 12:36 PM, Corey Bryant wrote: > > This sets the close-on-exec flag for the file descriptor received > > via SCM_RIGHTS. > > > > Signed-off-by: Corey Bryant > > --- > > v4 > > -This patch is new in v4 (ebl...@redhat.com)

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-25 Thread Peter Crosthwaite
On Mon, Jun 25, 2012 at 7:03 PM, Peter Maydell wrote: > On 25 June 2012 09:55, Peter Crosthwaite > wrote: >> As for architectures, I can speak for Microblaze and the PPC >> bootloader for virtex_ml507. The DTB will blob in regardless of >> whether its an elf or not, so no is_linux switch is neede

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Andreas Färber
Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: > Signed-off-by: Oleg Ogurtsov > --- > hw/arm/Makefile.objs |1 + > hw/exynos4210.c |8 + > hw/exynos4210_rtc.c | 607 > ++ > 3 files changed, 616 insertions(+), 0 deletions(-) > create mo

[Qemu-devel] [RFC] Attaching EHCI to sysbus.

2012-06-25 Thread Peter Crosthwaite
Hi All, I have a platform (Xilinx Zynq) that has a USB EHCI controller that attaches directly to the system bus and not through PCI. We are looking for a way to disentangle EHCI from PCI - currently it inherits from TYPE_PCI_DEVICE: static TypeInfo ehci_info = { .name = "usb-ehci",

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Peter Maydell
On 25 June 2012 08:55, Oleg Ogurtsov wrote: > Subject: [PATCH] Exynos4: added RTC device "add", please. > > Signed-off-by: Oleg Ogurtsov (You don't need to send a cover letter for a single patch, by the way.) > +#define     BCDSEC          0x0070 > +#define     BDCMIN          0x0074 typo,

[Qemu-devel] [net-next RFC V4 PATCH 3/4] virtio: introduce a method to get the irq of a specific virtqueue

2012-06-25 Thread Jason Wang
Device specific irq optimizations such as irq affinity may be used by virtio drivers. So this patch introduce a new method to get the irq of a specific virtqueue. After this patch, virtio device drivers could query the irq and do device specific optimizations. First user would be virtio-net. Sign

[Qemu-devel] [net-next RFC V4 PATCH 4/4] virtio_net: multiqueue support

2012-06-25 Thread Jason Wang
This addes multiqueue support to virtio_net driver. This feature is negotiated through VIRTIO_NET_F_MULTIQUEUE. The driver expects the number of rx/tx queue paris is equal to the number of vcpus. To maximize the performance under this per-cpu rx/tx queue pairs, some optimization were introduced:

Re: [Qemu-devel] [PATCH v6 5/6] fdc_test: update media_change test

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 12:33, schrieb Pavel Hrdina: > After rewrite DSKCHG bit handling the test has to be updated. Now > is needed to seek to different track to clear DSKCHG bit. > > Signed-off-by: Pavel Hrdina > --- > tests/fdc-test.c | 29 + > 1 files changed, 21 insertio

Re: [Qemu-devel] [RFC] Attaching EHCI to sysbus.

2012-06-25 Thread Andreas Färber
Hi Peter, Am 25.06.2012 11:34, schrieb Peter Crosthwaite: > I have a platform (Xilinx Zynq) that has a USB EHCI controller that > attaches directly to the system bus and not through PCI. We are > looking for a way to disentangle EHCI from PCI - currently it inherits > from TYPE_PCI_DEVICE: > > st

Re: [Qemu-devel] [PATCH 1/2] CPUArchState: introduce per-cpu lock

2012-06-25 Thread Stefan Hajnoczi
On Sun, Jun 24, 2012 at 3:05 PM, liu ping fan wrote: > On Fri, Jun 22, 2012 at 8:36 PM, Stefan Hajnoczi wrote: >> On Thu, Jun 21, 2012 at 4:06 PM, Liu Ping Fan wrote: >>> diff --git a/cpu-defs.h b/cpu-defs.h >>> index f49e950..7305822 100644 >>> --- a/cpu-defs.h >>> +++ b/cpu-defs.h >>> @@ -30,6

Re: [Qemu-devel] [PATCH 1/2] CPUArchState: introduce per-cpu lock

2012-06-25 Thread Andreas Färber
Am 25.06.2012 12:04, schrieb Stefan Hajnoczi: > On Sun, Jun 24, 2012 at 3:05 PM, liu ping fan wrote: >> On Fri, Jun 22, 2012 at 8:36 PM, Stefan Hajnoczi wrote: >>> On Thu, Jun 21, 2012 at 4:06 PM, Liu Ping Fan wrote: diff --git a/main-loop.h b/main-loop.h index dce1cd9..d8d44a4 100644

[Qemu-devel] [RFC V2 PATCH 0/4] Multiqueue support for tap and virtio-net/vhost

2012-06-25 Thread Jason Wang
Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls

[Qemu-devel] [RFC V2 PATCH 1/4] option: introduce qemu_get_opt_all()

2012-06-25 Thread Jason Wang
Sometimes, we need to pass option like -netdev tap,fd=100,fd=101,fd=102 which can not be properly parsed by qemu_find_opt() because it only returns the first matched option. So qemu_get_opt_all() were introduced to return an array of pointers which contains all matched option. Signed-off-by: Jason

[Qemu-devel] [RFC V2 PATCH 2/4] tap: multiqueue support

2012-06-25 Thread Jason Wang
This patch adds basic support for the multiple queue capable tap device. When multiqueue were enabled for a tap device, user can attach/detach multiple files (sockets) to the device through TUNATTACHQUEUE/TUNDETACHQUEUE. Two helpers tun_attach() and tun_deatch() were introduced to attach and detac

[Qemu-devel] [RFC V2 PATCH 3/4] net: multiqueue support

2012-06-25 Thread Jason Wang
This patch adds the multiqueues support for emulated nics. Each VLANClientState pairs are now abstract as a queue instead of a nic, and multiple VLANClientState pointers were stored in the NICState. A queue_index were also introduced to let the emulated nics know which queue the packet were came fr

[Qemu-devel] [RFC V2 PATCH 4/4] virtio-net: add multiqueue support

2012-06-25 Thread Jason Wang
This patch let the virtio-net can transmit and recevie packets through multiuple VLANClientStates and abstract them as multiple virtqueues to guest. A new parameter 'queues' were introduced to specify the number of queue pairs. The main goal for vhost support is to let the multiqueue could be used

Re: [Qemu-devel] [net-next RFC V4 PATCH 3/4] virtio: introduce a method to get the irq of a specific virtqueue

2012-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2012 at 05:41:17PM +0800, Jason Wang wrote: > Device specific irq optimizations such as irq affinity may be used by virtio > drivers. So this patch introduce a new method to get the irq of a specific > virtqueue. > > After this patch, virtio device drivers could query the irq and d

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Jan Kiszka
On 2012-06-25 10:57, Avi Kivity wrote: > On 06/25/2012 10:01 AM, Jan Kiszka wrote: >> Flush pending coalesced MMIO before performing mapping or state changes >> that could affect the event orderings or route the buffered requests to >> a wrong region. >> >> Signed-off-by: Jan Kiszka >> >> In addit

Re: [Qemu-devel] running qemu with image file on a block device

2012-06-25 Thread Stefan Hajnoczi
On Sun, Jun 24, 2012 at 7:49 AM, udit agarwal wrote: >  I have set up a block device of 20G on my hard drive and is located at > /dev/sda2. Now I have created a raw image inside this device via command: >  "hp1:~ # qemu-img create -f raw /dev/sda2:server.img 10G" > > Then I copied the iso file on

Re: [Qemu-devel] [PATCH 1/2] CPUArchState: introduce per-cpu lock

2012-06-25 Thread Andreas Färber
Am 24.06.2012 16:02, schrieb liu ping fan: > On Fri, Jun 22, 2012 at 8:55 PM, Andreas Färber wrote: >> Am 21.06.2012 17:06, schrieb Liu Ping Fan: >>> introduce a lock for per-cpu to protect agaist accesing from >>> other vcpu thread. >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> cpu-defs.h |

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Jan Kiszka
On 2012-06-25 12:15, Jan Kiszka wrote: > On 2012-06-25 10:57, Avi Kivity wrote: >> The repetitiveness of this code suggests a different way of doing this: >> make every API call be its own subtransaction and perform the flush in >> memory_region_begin_transaction() (maybe that's the answer to my >>

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-06-25 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 6:42 AM, Mike Lovell wrote: > This is what I've been calling QDES or QEMU Distributed Ethernet Switch. I > first had the idea when I was playing with the udp and mcast socket network > backends while exploring how to build a VM infrastructure. I liked the idea of > using th

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Avi Kivity
On 06/25/2012 01:26 PM, Jan Kiszka wrote: > On 2012-06-25 12:15, Jan Kiszka wrote: >> On 2012-06-25 10:57, Avi Kivity wrote: >>> The repetitiveness of this code suggests a different way of doing this: >>> make every API call be its own subtransaction and perform the flush in >>> memory_region_begin

Re: [Qemu-devel] [PATCH 3/5] memory: Flush coalesced MMIO on mapping and state changes

2012-06-25 Thread Jan Kiszka
On 2012-06-25 13:01, Avi Kivity wrote: > On 06/25/2012 01:26 PM, Jan Kiszka wrote: >> On 2012-06-25 12:15, Jan Kiszka wrote: >>> On 2012-06-25 10:57, Avi Kivity wrote: The repetitiveness of this code suggests a different way of doing this: make every API call be its own subtransaction and

Re: [Qemu-devel] [PATCH stable-1.1 00/26] Initial tree and candidates for stable-1.1

2012-06-25 Thread Stefano Stabellini
On Sat, 23 Jun 2012, Michael Roth wrote: > Hi everyone, > > I've set up a tree for stable-1.1 at: > > git://github.com/mdroth/qemu.git stable-1.1 Thanks for doing this. > That is simply the initial commit for v1.1.0 > > I've set up a staging tree for the first batch of commits at: > > git://

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Evgeny Voevodin
On 25.06.2012 13:24, Andreas Färber wrote: Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertio

Re: [Qemu-devel] [PATCH v6 6/6] fdc_test: introduce test_sense_interrupt

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 12:33, schrieb Pavel Hrdina: > Calling sense interrupt status while there is no interrupt should > return invalid command (0x80). > > Read command should always returns in st0 seek_end bit set to 1. > > Signed-off-by: Pavel Hrdina > --- > tests/fdc-test.c | 25 ++

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Andreas Färber
Am 25.06.2012 13:46, schrieb Evgeny Voevodin: > On 25.06.2012 13:24, Andreas Färber wrote: >> Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: >>> Signed-off-by: Oleg Ogurtsov >>> --- >>> hw/arm/Makefile.objs |1 + >>> hw/exynos4210.c |8 + >>> hw/exynos4210_rtc.c | 607 >>> ++

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: > On 06/22/2012 01:50 PM, Amit Shah wrote: > >On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: > >>On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: > >>> > >>>Oh, that's a good point. > > > >But easily fixed. > > Of course, e

Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl

2012-06-25 Thread Andreas Färber
Am 24.06.2012 17:14, schrieb Alexander Graf: > On 24.06.2012, at 16:18, Stefan Weil wrote: > >> This fixes a compiler error when QEMU was configured with --enable-debug. >> >> Signed-off-by: Stefan Weil >> --- >> >> Alex, please review. It fixes the compiler error, but I did the change >> simply

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Anthony Liguori
On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: Oh, that's a good point. But

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: > On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: > >On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: > >>On 06/22/2012 01:50 PM, Amit Shah wrote: > >>>On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: > On

Re: [Qemu-devel] [PATCH v6 4/6] fdc: fix interrupt handling

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 12:33, schrieb Pavel Hrdina: > If you call the SENSE INTERRUPT STATUS command while there is no interrupt > waiting you get as result unknown command. > > Fixed status0 register handling for read/write/format commands. > > Signed-off-by: Pavel Hrdina > --- > hw/fdc.c | 34 ++

[Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Peter Maydell
This patchset defines a set of macros for use in printf format strings for handling target_phys_addr_t values, as suggested by Andreas Färber (http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01547.html) We can then use them in some places which were previously either making assumptions abo

[Qemu-devel] [PATCH 1/4] targphys.h: Define PRI*PLX format specifier macros

2012-06-25 Thread Peter Maydell
Define a set of PRI*PLX format specifier macros for working with target_phys_addr_t types. These follow the standard pattern for such macros, and are more flexible than TARGET_FMT_plx, which does not allow specification of field widths. Suggested-by: Andreas Färber Signed-off-by: Peter Maydell -

[Qemu-devel] [PATCH 4/4] monitor: Use PRI*PLX to avoid TARGET_PHYS_ADDR_BITS ifdef

2012-06-25 Thread Peter Maydell
Now we have PRX*PLX for printing target_phys_addr_t values, we can use them in monitor.c rather than having duplicate code in two arms of a TARGET_PHYS_ADDR_BITS ifdef. Signed-off-by: Peter Maydell --- monitor.c | 29 - 1 files changed, 4 insertions(+), 25 deletions

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Anthony Liguori
On 06/25/2012 07:30 AM, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [

[Qemu-devel] [PATCH 2/4] hw/omap.h: Use PRIxPLX to define OMAP_FMT_plx

2012-06-25 Thread Peter Maydell
Use the new PRIxPLX macro to avoid the need to define an OMAP_FMT_plx macro whose expansion depends directly on TARGET_PHYS_ADDR_BITS. Signed-off-by: Peter Maydell --- hw/omap.h |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index 3d98941..2

[Qemu-devel] [PATCH 3/4] hw/sh_serial: Use PRIxPLX rather than %x for physaddr

2012-06-25 Thread Peter Maydell
Switch a format string from %x to PRIxPLX so that it will continue to work even if target_phys_addr_t is changed to 64 bits in the future. Signed-off-by: Peter Maydell --- hw/sh_serial.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/sh_serial.c b/hw/sh_serial.c

Re: [Qemu-devel] [PATCH stable-1.1 00/26] Initial tree and candidates for stable-1.1

2012-06-25 Thread Kevin Wolf
Am 23.06.2012 02:33, schrieb Michael Roth: > Hi everyone, > > I've set up a tree for stable-1.1 at: > > git://github.com/mdroth/qemu.git stable-1.1 > > That is simply the initial commit for v1.1.0 > > I've set up a staging tree for the first batch of commits at: > > git://github.com/mdroth/qem

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:54:18AM -0500, Anthony Liguori wrote: > On 06/25/2012 07:30 AM, Daniel P. Berrange wrote: > >On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: > >>On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: > >>>On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguo

Re: [Qemu-devel] [PATCH 7/8] dirty bitmap: abstract its use

2012-06-25 Thread Juan Quintela
Orit Wasserman wrote: > On 06/22/2012 04:46 PM, Juan Quintela wrote: >> Always use accessors to read/set the dirty bitmap. >> >> Signed-off-by: Juan Quintela >> -static inline int cpu_physical_memory_get_dirty_flags(ram_addr_t addr) >> +/* read dirty bit (return 0 or 1) */ >> +static inline int

Re: [Qemu-devel] [PATCH 1/4] targphys.h: Define PRI*PLX format specifier macros

2012-06-25 Thread Eric Blake
On 06/25/2012 06:45 AM, Peter Maydell wrote: > Define a set of PRI*PLX format specifier macros for working > with target_phys_addr_t types. These follow the standard pattern > for such macros, and are more flexible than TARGET_FMT_plx, which > does not allow specification of field widths. > > Sugg

Re: [Qemu-devel] [PATCH 1/8] Add spent time for migration

2012-06-25 Thread Eric Blake
On 06/25/2012 12:24 AM, Orit Wasserman wrote: >> # @MigrationInfo >> @@ -275,8 +280,9 @@ >> # 'cancelled'. If this field is not returned, no migration process >> # has been initiated >> # >> -# @ram: #optional @MigrationStats containing detailed migration status, >> -#

Re: [Qemu-devel] [RFC][PATCH 05/11] kvm: Introduce kvm_irqchip_add_msi_route

2012-06-25 Thread Alex Williamson
On Mon, 2012-05-14 at 18:07 -0300, Jan Kiszka wrote: > Add a service that establishes a static route from a virtual IRQ line to > an MSI message. Will be used for IRQFD and device assignment. As we will > use this service outside of CONFIG_KVM protected code, stub it properly. > > Signed-off-by: J

Re: [Qemu-devel] [PATCH v4 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-06-25 Thread Corey Bryant
On 06/25/2012 05:16 AM, Stefan Hajnoczi wrote: On Fri, Jun 22, 2012 at 01:31:17PM -0600, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This sets the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant --- v4 -This patch is new in

Re: [Qemu-devel] [PATCH 0/2] introduce bdrv_swap, implement bdrv_append on top

2012-06-25 Thread Stefan Hajnoczi
On Fri, Jun 15, 2012 at 10:38 AM, Kevin Wolf wrote: > Am 14.06.2012 16:55, schrieb Paolo Bonzini: >> Yet another tiny bit extracted from block mirroring, looks like it >> should be useful for block commit too. >> >> Paolo Bonzini (2): >>   block: copy over job and dirty bitmap fields in bdrv_appen

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Andreas Färber
Am 25.06.2012 14:45, schrieb Peter Maydell: > This patchset defines a set of macros for use in printf format strings > for handling target_phys_addr_t values, as suggested by Andreas Färber > (http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01547.html) What is the X for again? I assume PL

Re: [Qemu-devel] [RFC][PATCH 05/11] kvm: Introduce kvm_irqchip_add_msi_route

2012-06-25 Thread Jan Kiszka
On 2012-06-25 15:38, Alex Williamson wrote: > On Mon, 2012-05-14 at 18:07 -0300, Jan Kiszka wrote: >> Add a service that establishes a static route from a virtual IRQ line to >> an MSI message. Will be used for IRQFD and device assignment. As we will >> use this service outside of CONFIG_KVM protec

Re: [Qemu-devel] [PATCH 7/8] dirty bitmap: abstract its use

2012-06-25 Thread Orit Wasserman
On 06/25/2012 04:20 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> On 06/22/2012 04:46 PM, Juan Quintela wrote: >>> Always use accessors to read/set the dirty bitmap. >>> >>> Signed-off-by: Juan Quintela >>> -static inline int cpu_physical_memory_get_dirty_flags(ram_addr_t addr) >>> +/* read

[Qemu-devel] [PATCH 2/4] target-xtensa: drop usage of prev_debug_excp_handler

2012-06-25 Thread Igor Mammedov
Chains of exception handlers are currently unused feature. Dropping it to be consistent with target-i386 but it may simplify qom-ifying CPU in future like for target-i386. Signed-off-by: Igor Mammedov --- target-xtensa/helper.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) dif

[Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-06-25 Thread Igor Mammedov
v2: - drop usage of prev_debug_excp_handler consistently in all users - split from reset patches to avoid confusion of inter-dependency Compile & Run tested: target-i386: tcg and kvm mode i386-linux-user: running of /bin/ls Compile tested: xtensa-softmmu && xtensaeb-softmmu git tree for

[Qemu-devel] [PATCH 3/4] cleanup cpu_set_debug_excp_handler

2012-06-25 Thread Igor Mammedov
There are no users left for previous exception handler returned from cpu_set_debug_excp_handler. It should simplify code a little. Signed-off-by: Igor Mammedov --- cpu-exec.c |5 + exec-all.h |2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.

[Qemu-devel] [PATCH 1/4] target-i386: drop usage of prev_debug_excp_handler

2012-06-25 Thread Igor Mammedov
Chains of exception handlers are currently unused feature, drop it for now so as not to expose prev_debug_excp_handler at global scope when moving tcg initialization into target-i386/cpu.c Later we probably could re-invent better interface for this. Signed-off-by: Igor Mammedov --- target-i386/

[Qemu-devel] [PATCH 4/4] target-i386: move tcg initialization into x86_cpu_initfn()

2012-06-25 Thread Igor Mammedov
In order to make cpu object not depended on external ad-hoc initialization routines, move tcg initialization from cpu_x86_init inside cpu object "x86_cpu_initfn()". Signed-off-by: Igor Mammedov Reviewed-by: Andreas Färber --- target-i386/cpu.c| 10 ++ target-i386/cpu.h|1 +

Re: [Qemu-devel] [PATCH stable-1.1 00/26] Initial tree and candidates for stable-1.1

2012-06-25 Thread Michael Roth
On Mon, Jun 25, 2012 at 12:46:28PM +0100, Stefano Stabellini wrote: > On Sat, 23 Jun 2012, Michael Roth wrote: > > Hi everyone, > > > > I've set up a tree for stable-1.1 at: > > > > git://github.com/mdroth/qemu.git stable-1.1 > > Thanks for doing this. > > > > That is simply the initial commit

Re: [Qemu-devel] [PATCH 2/4] target-xtensa: drop usage of prev_debug_excp_handler

2012-06-25 Thread Max Filippov
On Mon, Jun 25, 2012 at 5:55 PM, Igor Mammedov wrote: > Chains of exception handlers are currently unused feature. Dropping it > to be consistent with target-i386 but it may simplify qom-ifying CPU > in future like for target-i386. > > Signed-off-by: Igor Mammedov > --- >  target-xtensa/helper.c

Re: [Qemu-devel] [RFC 0/7] qcow2: implement lazy refcounts optimization

2012-06-25 Thread Zhi Yong Wu
On Fri, Jun 22, 2012 at 11:08 PM, Stefan Hajnoczi wrote: > This series aims to improve qcow2 performance with cache=writethrough and > cache=directsync.  In particular it reduces the impact of metadata updates for What does cache=directsync mean? what is the difference between them? > allocating w

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Peter Maydell
On 25 June 2012 14:48, Andreas Färber wrote: > Am 25.06.2012 14:45, schrieb Peter Maydell: >> This patchset defines a set of macros for use in printf format strings >> for handling target_phys_addr_t values, as suggested by Andreas Färber >> (http://lists.gnu.org/archive/html/qemu-devel/2012-01/ms

Re: [Qemu-devel] [PATCH stable-1.1 00/26] Initial tree and candidates for stable-1.1

2012-06-25 Thread Michael Roth
On Mon, Jun 25, 2012 at 02:58:40PM +0200, Kevin Wolf wrote: > Am 23.06.2012 02:33, schrieb Michael Roth: > > Hi everyone, > > > > I've set up a tree for stable-1.1 at: > > > > git://github.com/mdroth/qemu.git stable-1.1 > > > > That is simply the initial commit for v1.1.0 > > > > I've set up a

Re: [Qemu-devel] [RFC 2/7] qcow2: introduce dirty bit

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: > This patch adds an incompatible feature bit to mark images that have not > been closed cleanly. When a dirty image file is opened a consistency > check and repair is performed. > > Signed-off-by: Stefan Hajnoczi > --- > block/qcow2.c | 44 ++

Re: [Qemu-devel] [RFC] Attaching EHCI to sysbus.

2012-06-25 Thread Anthony Liguori
On 06/25/2012 05:02 AM, Andreas Färber wrote: Hi Peter, Am 25.06.2012 11:34, schrieb Peter Crosthwaite: I have a platform (Xilinx Zynq) that has a USB EHCI controller that attaches directly to the system bus and not through PCI. We are looking for a way to disentangle EHCI from PCI - currently

Re: [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Corey Bryant
On 06/22/2012 03:58 PM, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This patch adds support to qemu_open to dup(fd) a pre-opened file descriptor if the filename is of the format /dev/fd/X. This can be used when QEMU is restricted from opening files, and the management applic

Re: [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Eric Blake
On 06/25/2012 08:24 AM, Corey Bryant wrote: >>> +if (fcntl_setfl(ret, O_CLOEXEC, (flags & O_CLOEXEC) ? 1 >>> : 0) < 0) { >> >> Broken. O_CLOEXEC _only_ affects open(); to change it on an existing >> fd, you have to use fcntl(F_GETFD/F_SETFD) (not F_GETFL/F_SETFL). >> >> > > I'll fix

Re: [Qemu-devel] [RFC 3/7] docs: add lazy refcounts bit to qcow2 specification

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: > The lazy refcounts bit indicates that this image can take advantage of > the dirty bit and that refcount updates can be postponed. > > Signed-off-by: Stefan Hajnoczi > --- > docs/specs/qcow2.txt |6 +- > 1 file changed, 5 insertions(+), 1 d

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Andreas Färber
Am 25.06.2012 16:10, schrieb Peter Maydell: > On 25 June 2012 14:48, Andreas Färber wrote: >> Am 25.06.2012 14:45, schrieb Peter Maydell: >>> This patchset defines a set of macros for use in printf format strings >>> for handling target_phys_addr_t values, as suggested by Andreas Färber >>> (http:

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Peter Maydell
On 25 June 2012 15:43, Andreas Färber wrote: > Am 25.06.2012 16:10, schrieb Peter Maydell: >> On 25 June 2012 14:48, Andreas Färber wrote: >>> Thus I would suggest TARGET_PRIdPHYSADDR, also addressing Eric's >>> comment. Judging from patches 2-4 it's not used to frequently unlike its >>> user TAR

[Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-06-25 Thread Peter Maydell
In our disassembly code, the bfd_vma type is always 64 bits, even if the target's virtual address width is only 32 bits. This means that when we print out addresses we need to truncate them to 32 bits, to avoid odd output which has incorrectly sign-extended a value to 64 bits, for instance this ARM

Re: [Qemu-devel] [RFC 5/7] qcow2: implement lazy refcounts

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: > Lazy refcounts is a performance optimization for qcow2 that postpones > refcount metadata updates and instead marks the image dirty. In the > case of crash or power failure the image will be left in a dirty state > and repaired next time it is opened

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

2012-06-25 Thread Andreas Färber
Am 25.06.2012 16:54, schrieb Peter Maydell: > On 25 June 2012 15:43, Andreas Färber wrote: >> Am 25.06.2012 16:10, schrieb Peter Maydell: >>> On 25 June 2012 14:48, Andreas Färber wrote: Thus I would suggest TARGET_PRIdPHYSADDR, also addressing Eric's comment. Judging from patches 2-4 i

Re: [Qemu-devel] [RFC 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: > This tests establishes the basic post-conditions of the qcow2 lazy > refcounts features: > > 1. If the image was closed normally, it is marked clean. > > 2. If an allocating write was performed and the image was not close > normally, then i

  1   2   >