On 25.06.2012 13:24, Andreas Färber wrote:
Am 25.06.2012 09:55, schrieb Oleg Ogurtsov:
Signed-off-by: Oleg Ogurtsov<o.ogurt...@samsung.com>
---
hw/arm/Makefile.objs | 1 +
hw/exynos4210.c | 8 +
hw/exynos4210_rtc.c | 607 ++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 616 insertions(+), 0 deletions(-)
create mode 100644 hw/exynos4210_rtc.c
This RTC like many other Exynos devices has no dependency on the CPU. I
have a patch in preparation that moves such devices from
hw/arm/Makefile.objs to hw/Makefile.objs.
I don't object to this patch, not even minor style nits spotted,
compliment, but if you have to respin for some reason, it would be nice
if you could consider that improvement.
These devices are SOC specific and this SOC is based on ARM only.
Do we really need to move them?
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevo...@samsung.com