[Qemu-devel] [PATCH v12 12/13] Add set_cachesize command

2012-06-19 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c |9 + hmp

Re: [Qemu-devel] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-19 Thread Eric Blake
On 06/14/2012 09:55 AM, Corey Bryant wrote: > This patch series adds the pass-fd QMP monitor command, which allows > an fd to be passed via SCM_RIGHTS, and returns the received file > descriptor. Support is also added to the block layer to allow QEMU > to dup the fd when the filename is of the /d

Re: [Qemu-devel] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-19 Thread Kevin Wolf
Am 19.06.2012 17:46, schrieb Eric Blake: > On 06/14/2012 09:55 AM, Corey Bryant wrote: > >> This patch series adds the pass-fd QMP monitor command, which allows >> an fd to be passed via SCM_RIGHTS, and returns the received file >> descriptor. Support is also added to the block layer to allow QEM

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Michael Roth
On Tue, Jun 19, 2012 at 03:54:23PM +0200, Juan Quintela wrote: > Juan Quintela wrote: > > Hi > > > > Please send in any agenda items you are interested in covering. > > > > Anthony suggested for last week: > > - multithreading vhost (and general vhost improvements) > > > > I suggest: > > - status

Re: [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure

2012-06-19 Thread Orit Wasserman
On 06/19/2012 07:00 PM, Eric Blake wrote: > On 06/19/2012 09:43 AM, Orit Wasserman wrote: >> From: Isaku Yamahata >> >> Signed-off-by: Isaku Yamahata >> --- > >> >> -static void block_set_params(int blk_enable, int shared_base, void *opaque) >> +static void block_set_params(const MigrationPara

[Qemu-devel] [PATCH v12 05/13] Add uleb encoding/decoding functions

2012-06-19 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 29 + qemu-common.h |8 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index af308cd..60fb7c8 100644 --- a/cutils.c +++ b/c

[Qemu-devel] [PATCH v12 04/13] Add cache handling functions

2012-06-19 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs|1 + cache.c | 219 +++

Re: [Qemu-devel] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-19 Thread Eric Blake
On 06/19/2012 09:57 AM, Kevin Wolf wrote: >> this new fd-passing approach, a file originally opened as O_RDONLY >> /dev/fd/21 will need to be reopened, but the reopened fd will (likely) >> not be 21. In other words, we need to make sure 'block-commit' supports >> the ability to pass in optional a

[Qemu-devel] [PATCH v12 09/13] Add migration_end function

2012-06-19 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch_init.c b/arch_init.c index c9ab66a..276d478 100644 --- a/arch_init.c +++ b/arch_init.c @@ -304,6 +304,11 @@ static void sort_ram_list(void) g_free(blocks); } +

[Qemu-devel] [PATCH v12 08/13] Change ram_save_block to return -1 if there are no more changes

2012-06-19 Thread Orit Wasserman
It will return 0 if the page is unmodifed. Signed-off-by: Orit Wasserman --- arch_init.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index fbed5ea..c9ab66a 100644 --- a/arch_init.c +++ b/arch_init.c @@ -184,11 +184,11 @@ static

[Qemu-devel] [PATCH v12 06/13] Add save_block_hdr function

2012-06-19 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index 81c2e54..cfa1af2 100644 --- a

Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Add migration capabiltes that can be queried by the management. s/capabiltes/capabilities/ > The managment can query the source QEMU and the destination QEMU in order to s/managment/management/ > verify both support some migration capability (cur

Re: [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > From: Isaku Yamahata > > Signed-off-by: Isaku Yamahata > --- > > -static void block_set_params(int blk_enable, int shared_base, void *opaque) > +static void block_set_params(const MigrationParams *params, void *opaque) As long as we are changin

Re: [Qemu-devel] [PATCH v12 03/13] Add XBZRLE documentation

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 115 > +++ > 1 files changed, 115 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > +Format > +=== > + > +The c

[Qemu-devel] [PATCH v12 13/13] Add XBZRLE statistics

2012-06-19 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 68 +- hmp.c| 13 ++ migration.c | 12 + migration.h |

[Qemu-devel] [PATCH v12 11/13] Add XBZRLE to ram_save_block and ram_save_live

2012-06-19 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-of

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Corey Bryant
On 06/19/2012 11:37 AM, Will Drewry wrote: On Tue, Jun 19, 2012 at 8:35 AM, Corey Bryant wrote: On 06/18/2012 06:14 PM, Will Drewry wrote: [-all] On Mon, Jun 18, 2012 at 4:53 PM, Corey Bryant wrote: On 06/18/2012 04:18 PM, Blue Swirl wrote: On Mon, Jun 18, 2012 at 3:22 PM, Corey

Re: [Qemu-devel] [PATCH v12 04/13] Add cache handling functions

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > +++ b/cache.c > @@ -0,0 +1,219 @@ > +/

[Qemu-devel] [PATCH v12 07/13] Add debugging infrastructure

2012-06-19 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- arch_init.c | 33 +++-- 1 files changed, 27 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index cfa1af2..fbed5ea 100644 --- a/arch_init.c +++ b/arch_init.c @@ -44,6 +44,14 @@ #include "exec-memory.h" #includ

Re: [Qemu-devel] [PATCH v12 05/13] Add uleb encoding/decoding functions

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Implement Unsigned Little Endian Base 128. > > Signed-off-by: Orit Wasserman > --- > cutils.c | 29 + > qemu-common.h |8 > 2 files changed, 37 insertions(+), 0 deletions(-) > > +int uleb128_decode_

Re: [Qemu-devel] [PATCH qom-next v2 33/33] target-arm: Remove ARM_CPUID_* macros

2012-06-19 Thread Andreas Färber
Am 14.05.2012 21:03, schrieb Peter Maydell: > All the uses of ARM_CPUID() to vary behaviour have now been > removed, so we can delete the ARM_CPUID_* macros now. > The one exception is the TI915T/925T, because of its odd behaviour > where the MIDR value can be changed at runtime. > > Signed-off-by

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Andreas Färber
Juan, Am 19.06.2012 16:59, schrieb Juan Quintela: > Alexander Graf wrote: >> On 09.06.2012, at 13:34, Benjamin Herrenschmidt wrote: >> >>> Ok, so I'm told there are patches to convert ppc, I haven't seen them in >>> my list archives, so if somebody has a pointer, please shoot, that will >>> save

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-19 Thread Michael Roth
On Tue, Jun 19, 2012 at 11:34:42PM +0900, Takuya Yoshikawa wrote: > On Tue, 19 Jun 2012 09:01:36 -0500 > Anthony Liguori wrote: > > > I'm not at all convinced that postcopy is a good idea. There needs a clear > > expression of what the value proposition is that's backed by benchmarks. > > Tho

[Qemu-devel] [PATCH v12 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-06-19 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- savevm.c | 91 ++ 1 files changed, 91 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 638

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 5:53 AM, Stefan Weil wrote: > Am 19.06.2012 04:31, schrieb Scott Wood: > >> If tci_out_label is called in the context of tcg_gen_code_search_pc, we >> could be overwriting an already patched relocation with zero -- and not >> repatch it because the set_label is past search_

Re: [Qemu-devel] [PATCH v12 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > savevm.c | 91 > ++ > 1 files changed, 91 insertions

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 7:45 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster wrote: >>> Commit 5bbdbb46 moved it to block.c because "other geometry guessing >>> functions already reside in block.c".  Device-specific functionality >>> shou

Re: [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 8:02 AM, Jia Liu wrote: > Hi Blue, > > Thank you for review. > Is this code OK? > > void HELPER(mtspr)(CPUOpenRISCState * env, >                   target_ulong ra, target_ulong rb, target_ulong offset) > { > #ifndef CONFIG_USER_ONLY >    int spr = (ra | offset); >    int id

Re: [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 12:54 PM, Alexander Graf wrote: > > On 07.06.2012, at 23:09, Blue Swirl wrote: > >> On Tue, Jun 5, 2012 at 11:52 PM, Alexander Graf wrote: >>> Today we have two separate places where we keep information which device >>> is where: >>> >>>  - hw/ppce500_mpc8544ds.c to instan

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 9:23 AM, Daniel P. Berrange wrote: > On Mon, Jun 18, 2012 at 08:15:37PM +, Blue Swirl wrote: >> On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange >> wrote: >> > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: >> >> On Friday, June 15, 2012 07:06:10 PM Bl

Re: [Qemu-devel] [PATCH v12 11/13] Add XBZRLE to ram_save_block and ram_save_live

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > In the outgoing migration check to see if the page is cached and > changed than send compressed page by using save_xbrle_page function. > In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set > and decompress the page (by using load_xbr

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 11:04 AM, Avi Kivity wrote: > On 06/16/2012 09:46 AM, Blue Swirl wrote: >> On Fri, Jun 15, 2012 at 9:36 PM, Paul Moore wrote: >>> On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: > On Friday, June 15, 2012

[Qemu-devel] [Bug 1015226] [NEW] arm realview pbx hung

2012-06-19 Thread ken_ma
Public bug reported: host(pc):ubuntu 10.1 qemu:qemu-1.1.0-1 target:realview-pbx-a9 kernel:2.6.34.10 gcc:4.4.6 command line, and output as follow: - majun@majun-Lenovo-Product:~/qemu$ qemu-system-arm -M realview-pbx-a9 -kernel ~/emb_linux/trunk/bsp/versatil

Re: [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 20:39, Blue Swirl wrote: > On Tue, Jun 19, 2012 at 12:54 PM, Alexander Graf wrote: >> >> On 07.06.2012, at 23:09, Blue Swirl wrote: >> >>> On Tue, Jun 5, 2012 at 11:52 PM, Alexander Graf wrote: Today we have two separate places where we keep information which device >>>

Re: [Qemu-devel] [PATCH v12 12/13] Add set_cachesize command

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by:

[Qemu-devel] [PATCH 14/31] PPC: e500: dt: create /chosen node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 28c7c8c..a078e24 100644 --- a/hw/ppce500_mpc8544ds.c +++ b/hw/ppce500_mpc8544ds.c @@ -101,6 +101,7 @@ static int

[Qemu-devel] [PATCH 11/31] PPC: e500: dt: create /cpus node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |5 + pc-bios/mpc8544ds.dtb | Bin 1972 -> 1924 bytes pc-bios/mpc8544ds.dts |5 - 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 3ec9013..c046206 10064

[Qemu-devel] [PATCH 17/31] PPC: e500: dt: create mpic node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf - use new multi-cell setting api --- hw/ppce500_mpc8544ds.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index c68e994..5c2b6ab 100644 ---

Re: [Qemu-devel] [PATCH v12 13/13] Add XBZRLE statistics

2012-06-19 Thread Eric Blake
On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > +++ b/qapi-schema.json > @@ -263,7 +263,28 @@ > # Since: 0.14.0. > ## > { 'type': 'MigrationStats', > - 'data':

[Qemu-devel] [PATCH v4 1/2] Force driftfix=none on previous machines

2012-06-19 Thread Crístian Viana
The current value for the -rtc driftfix option is 'none'. This patch makes sure that the old machines configuration will work the same way even after that option changes its default value. Signed-off-by: Crístian Viana --- There's a scenario when things don't work the way I expected: when I set

[Qemu-devel] [PATCH v4 2/2] Change driftfix default value to slew

2012-06-19 Thread Crístian Viana
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If driftfix is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- Anthony, Could you please try to reproduce the segfault again (as you stated in http://article.gmane.o

[Qemu-devel] [PATCH 09/31] PPC: e500: require libfdt

2012-06-19 Thread Alexander Graf
Now that we're moving all of the device tree generation from an external pre-execution generated blob to runtime generation using libfdt, we absolutely must have libfdt around. This requirement was there before already, as the only way to not require libfdt with e500 was to not use -kernel, which

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-19 Thread Arndt Kritzner
** Attachment added: "Minidump of BSOD with e1000 + ide" https://bugs.launchpad.net/qemu/+bug/1014681/+attachment/3196480/+files/Mini061912-01.dmp -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/101

[Qemu-devel] [PATCH 27/31] PPC: e500: Use new SOC dt format

2012-06-19 Thread Alexander Graf
Due to popular demand, let's clean up the soc node a bit and use more recent dt notions. Requested-by: Scott Wood Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544

[Qemu-devel] [PATCH 18/31] PPC: e500: dt: create global-utils node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf - use new multi-cell setting api --- hw/ppce500_mpc8544ds.c |9 + pc-bios/mpc8544ds.dts |6 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c inde

[Qemu-devel] [PATCH 21/31] dt: Add -machine dumpdtb option to dump the current dtb

2012-06-19 Thread Alexander Graf
Now that we are dynamically creating the dtb, it's really useful to be able to dump the created blob for debugging. This patch implements a -machine dumpdtb= option for e500 that dumps the dtb exactly in the form the guest would get it to disk. It can then be analyzed by dtc to get information abo

[Qemu-devel] [PATCH 30/31] dt: Add global option to set phandle start offset

2012-06-19 Thread Alexander Graf
If anyone outside of QEMU wants to mess with a QEMU generated device tree, he needs to know which range phandles are valid in. So let's expose a machine option that an external program can use to set the start allocate id for phandles in QEMU. Signed-off-by: Alexander Graf --- v2 -> v3: - ad

[Qemu-devel] [PATCH 29/31] PPC: e500: Extend address/size of / to 64bit

2012-06-19 Thread Alexander Graf
We want to be able to support >= 4GB of RAM. To do so, we need to be able to tell the guest OS how much RAM it has. However, that information today is capped to 32bit. So let's extend the offset and size fields to 64bit, so we can fit in big addresses and even one day - if we wish to do so - map d

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: > Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) Cheers, Ben.

[Qemu-devel] [PATCH 04/31] dt: temporarily disable subtree creation failure check

2012-06-19 Thread Alexander Graf
Usually we want to know when creating a subtree fails. However, while introducing this patch set we have to modify the device tree and some times have the code to create a subtree in both the binary tree and the dynamically created tree. So ignore failures about this for now and enable them once w

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:18, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: >> Tab alert. :) > > Argh :-) Gotta get an emacs config for use with qemu :-) So do you want to resend? I can just fix it on the fly too. Alex

[Qemu-devel] [PATCH 08/31] dt: add helper for 64bit cell adds

2012-06-19 Thread Alexander Graf
Some times in the device tree, we find an array of 2 u32 cells that really are a single u64 value. This patch adds a helper to make the creation of these easy. Signed-off-by: Alexander Graf Reviewed-by: Peter Crosthwaite --- v1 -> v2: - rename cell64 -> u64 --- device_tree.c |7 +++

[Qemu-devel] [PATCH 31/31] PPC: e500: Refactor serial dt generation

2012-06-19 Thread Alexander Graf
When generating serial port device tree nodes, we duplicate quite a bit of code, because there are 2 of them in the mpc8544ds board we emulate. Shove the generating code into a function, so we duplicate less code. Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf --- hw/ppce500_mp

Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 15:42 +0200, Gerd Hoffmann wrote: > Well, that isn't guaranteed ... > > > - otherwise the guest > > might invalidate IOMMU mappings while they are still in use by the device > > code. > > Guest tearing down mapping while usb packets using them are still in > flight would be

[Qemu-devel] [PATCH 24/31] PPC: e500: enable manual loading of dtb blob

2012-06-19 Thread Alexander Graf
We want to be able to override the automatically created device tree by using the -dtb option. Implement this for the mpc8544ds machine. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH 12/31] PPC: e500: dt: create /hypervisor node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |1 + pc-bios/mpc8544ds.dtb | Bin 1924 -> 1904 bytes pc-bios/mpc8544ds.dts |3 --- 3 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index c046206..54e7ec7 100644 ---

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 16:59 +0200, Juan Quintela wrote: > >> - The hash table (mentioned above). This is just a big chunk of > memory > >> (it will routinely be 16M), so I really don't want to start > iterating > >> all elements, just a bulk load will do, and the size might actually > be > >> varia

[Qemu-devel] [PATCH 01/31] dt: allow add_subnode to create root subnodes

2012-06-19 Thread Alexander Graf
Our subnode creation helper can't handle creation of root subnodes, like "/memory". Fix this by allowing the parent node to be an empty string, indicating the root node. Signed-off-by: Alexander Graf Reviewed-by: Peter Crosthwaite --- device_tree.c |7 ++- 1 files changed, 6 insertions(

[Qemu-devel] [PATCH 20/31] PPC: e500: dt: start with empty device tree

2012-06-19 Thread Alexander Graf
Now that all of the device tree bits are generated during runtime, we can get rid of the device tree blob and instead start from scratch with an empty device tree. Signed-off-by: Alexander Graf --- Makefile |1 - hw/ppce500_mpc8544ds.c |8 +--- pc-bios/mpc8544ds.dtb |

[Qemu-devel] [PATCH 02/31] dt: add helpers for multi-cell adds

2012-06-19 Thread Alexander Graf
We have device tree helpers that allow us to create single cell (u32) wide properties. However, when creating properties that contain an array of cells, we need to jump through hoops, manually passing in an array with converted endianness. To ease the pain of this, create a generic macro helper th

[Qemu-devel] [PATCH 26/31] PPC: e500: Use new MPIC dt format

2012-06-19 Thread Alexander Graf
Due to popular demand, we're updating the way we generate the MPIC node and interrupt lines based on what the current state of art is. Requested-by: Scott Wood Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c | 33 ++--- 1 files changed, 18 insertions(+), 1

[Qemu-devel] [PATCH 16/31] PPC: e500: dt: create serial nodes dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf - use new multi-cell setting api --- hw/ppce500_mpc8544ds.c | 35 +++ pc-bios/mpc8544ds.dts | 26 -- 2 files changed, 35 insertions(+), 26 deletions(-) diff --git a/hw/p

[Qemu-devel] [PATCH 06/31] dt: add helper for empty dt creation

2012-06-19 Thread Alexander Graf
We want to get rid of the concept of loading an external device tree and instead generate our own. However, to do this we need to also create a device tree template programatically. This patch adds a helper to create an empty device tree in memory. Signed-off-by: Alexander Graf Reviewed-by: Pete

[Qemu-devel] [PATCH 10/31] PPC: e500: dt: create memory node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |8 pc-bios/mpc8544ds.dtb | Bin 2028 -> 1972 bytes pc-bios/mpc8544ds.dts |5 - 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 506ddf3..3ec9013 10

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 22:20 +0200, Alexander Graf wrote: > So do you want to resend? I can just fix it on the fly too. If you can then sure, please do :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-19 Thread Stefan Weil
qemu-devel was no longer cc'ed, let us add it again. Cheers, Stefan Am 19.06.2012 22:35, schrieb Eduardo Habkost: On Tue, Jun 19, 2012 at 04:33:35AM -0700, Chegu Vinod wrote: [...] +#include Did you check whether this and the macros you're using are available on POSIX and ming

Re: [Qemu-devel] [PATCH 21/31] dt: Add -machine dumpdtb option to dump the current dtb

2012-06-19 Thread Peter Maydell
On 19 June 2012 20:15, Alexander Graf wrote: > Now that we are dynamically creating the dtb, it's really useful to > be able to dump the created blob for debugging. > @@ -300,6 +302,22 @@ static int mpc8544_load_device_tree(CPUPPCState *env, >     qemu_devtree_setprop_cell(fdt, pci, "#address-cel

[Qemu-devel] [PATCH 19/31] PPC: e500: dt: create pci node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf - use new multi-cell setting api --- hw/ppce500_mpc8544ds.c | 50 pc-bios/mpc8544ds.dtb | Bin 1810 -> 72 bytes pc-bios/mpc8544ds.dts | 46

Re: [Qemu-devel] [PATCH v3] spapr: Add "memop" hypercall

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:21, Benjamin Herrenschmidt wrote: > This adds a qemu-specific hypervisor call to the pseries machine > which allows to do what amounts to memmove, memcpy and xor over > regions of physical memory such as the framebuffer. > > This is the simplest way to get usable framebuffer

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:02, Benjamin Herrenschmidt wrote: > We were incorrectly g_free'ing an object that isn't allocated > in one error path and failed to release it completely in another > > This fixes qemu crashes with some cases of IO errors. > > Signed-off-by: Benjamin Herrenschmidt Thanks,

Re: [Qemu-devel] [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 07:56, Benjamin Herrenschmidt wrote: > More recent Power server chips (i.e. based on the 64 bit hash MMU) > support more than just the traditional 4k and 16M page sizes. This > can get quite complicated, because which page sizes are supported, > which combinations are supported

[Qemu-devel] [PATCH 03/31] dt: add helper for phandle references

2012-06-19 Thread Alexander Graf
Phandles are the fancy device tree name for "pointer to another node". To create a phandle property, we most likely want to reference to the node we're pointing to by its path. So create a helper that allows us to do so. Signed-off-by: Alexander Graf --- v2 -> v3: - rename "string" to target

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:30, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 16:59 +0200, Juan Quintela wrote: - The hash table (mentioned above). This is just a big chunk of >> memory (it will routinely be 16M), so I really don't want to start >> iterating all elements, just a b

[Qemu-devel] [PATCH 07/31] dt: add helper for phandle allocation

2012-06-19 Thread Alexander Graf
Phandle references work by having 2 pieces: - a "phandle" 1-cell property in the device tree node - a reference to the same value in a property we want to point to the other node To generate the 1-cell property, we need an allocation mechanism that gives us a unique number space. This pat

Re: [Qemu-devel] [PATCH 21/31] dt: Add -machine dumpdtb option to dump the current dtb

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:51, Peter Maydell wrote: > On 19 June 2012 20:15, Alexander Graf wrote: >> Now that we are dynamically creating the dtb, it's really useful to >> be able to dump the created blob for debugging. > >> @@ -300,6 +302,22 @@ static int mpc8544_load_device_tree(CPUPPCState *env,

[Qemu-devel] [PATCH 13/31] PPC: e500: dt: create / node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |8 pc-bios/mpc8544ds.dtb | Bin 1904 -> 1810 bytes pc-bios/mpc8544ds.dts |5 - 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 54e7ec7..28c7c8c 10

[Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Alexander Graf
Today we have two separate places where we keep information which device is where: - hw/ppce500_mpc8544ds.c to instantiate all devices - pc-bios/mpc8544ds.dtb as device tree to tell the guest about devices Every time we split crucial information, things can go terribly wrong. If you update on

[Qemu-devel] [PATCH 22/31] PPC: e500: dt: use 64bit cell helper

2012-06-19 Thread Alexander Graf
We have a nice 64bit helper to ease the device tree generation and make the code more readable when creating 64bit 2-cell parameters. Use it when generating the device tree. Signed-off-by: Alexander Graf --- v1 -> v2: - rename cell64 -> u64 - don't treat memory as single u64 --- hw/ppce50

[Qemu-devel] [PATCH 28/31] PPC: e500: Define addresses as always 64bit

2012-06-19 Thread Alexander Graf
Every time we use an address constant, it needs to potentially fit into a 64bit physical address space. So let's define things accordingly. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 23:00 +0200, Alexander Graf wrote: > How is the problem different from RAM? It's a 16MB region that can be > accessed by the guest even during transfer time, so it can get dirty > during the migration. But we only need to really transfer the last > small delta at the end of th

[Qemu-devel] [PATCH 15/31] PPC: e500: dt: create /soc8544 node dynamically

2012-06-19 Thread Alexander Graf
Signed-off-by: Alexander Graf --- v2 -> v3: - use snprintf - use new multi-cell setting api --- hw/ppce500_mpc8544ds.c | 17 + pc-bios/mpc8544ds.dts |9 - 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8

[Qemu-devel] [PATCH 25/31] Revert "dt: temporarily disable subtree creation failure check"

2012-06-19 Thread Alexander Graf
This reverts commit "dt: temporarily disable subtree creation failure check" which was meant as a temporary solution to keep external and dynamic device tree construction intact. Now that we switched to fully dynamic dt construction, it's no longer necessary. Signed-off-by: Alexander Graf ---

[Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration

2012-06-19 Thread Alexander Graf
This patch adds a helper to search for a node's phandle by its path. This is especially useful when the phandle is part of an array, not just a single cell in which case qemu_devtree_setprop_phandle would be the easy choice. Signed-off-by: Alexander Graf --- device_tree.c | 16 +++-

[Qemu-devel] [PATCH 23/31] PPC: e500: dt: use target_phys_addr_t for ramsize

2012-06-19 Thread Alexander Graf
We're passing the ram size as uint32_t, capping it to 32 bits atm. Change to target_phys_addr_t (uint64_t) to make sure we have all the bits. Signed-off-by: Alexander Graf --- hw/ppce500_mpc8544ds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c

Re: [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Andreas Färber
Am 19.06.2012 21:14, schrieb Alexander Graf: > v1 -> v2: > > - rename cell64 -> u64 > - don't treat memory as single u64 > - remove commit id from patch description > - NEW: PPC: e500: Use new MPIC dt format > PPC: e500: Use new SOC dt format > PPC: e500: Define addresses

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 23:13, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 23:00 +0200, Alexander Graf wrote: >> How is the problem different from RAM? It's a 16MB region that can be >> accessed by the guest even during transfer time, so it can get dirty >> during the migration. But we onl

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 23:48 +0200, Alexander Graf wrote: > > We could keep track manually maybe using some kind of dirty bitmap of > > changes to the hash table but that would add overhead to things like > > H_ENTER. > > Only during migration, right? True. It will be an "interesting" user/kernel

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Scott Wood
On 06/19/2012 12:53 AM, Stefan Weil wrote: > Am 19.06.2012 04:31, schrieb Scott Wood: >> If tci_out_label is called in the context of tcg_gen_code_search_pc, we >> could be overwriting an already patched relocation with zero -- and not >> repatch it because the set_label is past search_pc, causing

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Peter Maydell
On 19 June 2012 22:52, Scott Wood wrote: > On 06/19/2012 12:53 AM, Stefan Weil wrote: >> I saw from git history that ppc once had the same bug. >> The sparc backend (and maybe others) might still have it. > > SPARC looks wrong; the others look OK as far as I can tell from a quick > glance, without

[Qemu-devel] [PATCH 08/17] net: Remove VLANState

2012-06-19 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/dp8393x.c|1 - hw/exynos4_boards.c |2 +- hw/highbank.c |2 +- hw/integratorcp.c |2 +- hw/mcf5208.c|2 +- hw/mcf_

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 23:51, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 23:48 +0200, Alexander Graf wrote: >>> We could keep track manually maybe using some kind of dirty bitmap of >>> changes to the hash table but that would add overhead to things like >>> H_ENTER. >> >> Only during migr

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 00:27 +0200, Alexander Graf wrote: > > > I need to understand better how do that vs. qemu save/restore > though. IE. That means > > we can't just save the hash as a bulk and reload it, but we'd have > to save bits of > > it at a time or something like that no ? Or do we save

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Juan Quintela
Alexander Graf wrote: > On 19.06.2012, at 22:30, Benjamin Herrenschmidt wrote: > >> On Tue, 2012-06-19 at 16:59 +0200, Juan Quintela wrote: > - The hash table (mentioned above). This is just a big chunk of >>> memory > (it will routinely be 16M), so I really don't want to start >>> iterati

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 00:55 +0200, Juan Quintela wrote: > > This was going to be my question. > > If we can do something like: send hash register, and get a bitmap of > the > ones that get changed, we should be good. Perhaps we need something > "interesting" like removing old entries (no clue if

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Juan Quintela
Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 00:55 +0200, Juan Quintela wrote: >> >> This was going to be my question. >> >> If we can do something like: send hash register, and get a bitmap of >> the >> ones that get changed, we should be good. Perhaps we need something >> "interestin

[Qemu-devel] [PATCH v2] Fixes related to processing of qemu's -numa option

2012-06-19 Thread Chegu Vinod
From: root Changes since v1: - Use bitmap functions that are already in qemu (instead of cpu_set_t macro's) - Added a check for endvalue >= max_cpus. - Fix to address the round-robbing assignment (for the case when cpu's are not explicitly specified) Note: Continuing t

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 01:11 +0200, Juan Quintela wrote: > > > I am confident I can come up with something as far as the kernel and > > qemu <-> kernel interface goes. I need to get my head around the details > > on how to implement that two stage save process in qemu though and the > > correspondi

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 20.06.2012, at 01:28, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 01:11 +0200, Juan Quintela wrote: >> >>> I am confident I can come up with something as far as the kernel and >>> qemu <-> kernel interface goes. I need to get my head around the details >>> on how to implement that t

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 01:30 +0200, Alexander Graf wrote: > > We support the paravirtualized -M pseries in full emu as well, in which > > case the hashed page table is handled by qemu itself who implements the > > H_ENTER & co hypercalls. So it's very similar, except that qemu doesn't > > have to as

Re: [Qemu-devel] vm state save/restore question

2012-06-19 Thread Alexander Graf
On 20.06.2012, at 01:52, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 01:30 +0200, Alexander Graf wrote: >>> We support the paravirtualized -M pseries in full emu as well, in which >>> case the hashed page table is handled by qemu itself who implements the >>> H_ENTER & co hypercalls. So

<    1   2   3   >