From: Avi Kivity
mmio callbacks invoked by kvm_flush_coalesced_mmio_buffer() may
themselves indirectly call kvm_flush_coalesced_mmio_buffer().
Prevent reentering the function by checking a flag that indicates
we're processing coalesced mmio requests.
Signed-off-by: Avi Kivity
(cherry picked fro
From: Jan Kiszka
Device models rely on the core invoking their reset handlers after init.
We do this in the cold-plug case, but so far we miss this step after
hot-plug.
Signed-off-by: Jan Kiszka
Signed-off-by: Anthony Liguori
(cherry picked from commit 5ab28c8340f683121c081a181adfd9f72ab85cba)
Am 28.03.2012 16:34, schrieb Paolo Bonzini:
> Avoid cluttering too much the QOM root.
>
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2: add qdev_get_machine() and use it.
Thanks,
>
> hw/piix_pci.c |2 +-
> hw/ppc_prep.c |2 +-
> hw/qdev-monitor.c |4 ++--
> hw/qdev.c
From: Kevin Wolf
Commit 63ffb564 broke floppy devices specified on the command line like
-drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it
relies on drive_get() which works only with -fda/-drive if=floppy.
This patch resembles what we're already doing for IDE, i.e. remem
From: Charles Arnold
The Data Offset field in the Dynamic Disk Header is an 8 byte field.
Although the specification (2006-10-11) gives an example of initializing
only the first 4 bytes, images generated by Microsoft on Windows initialize
all 8 bytes.
Failure to initialize all 8 bytes results in
From: Peter Maydell
Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available():
this isn't valid and Valgrind complains about it.
Signed-off-by: Peter Maydell
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Andrzej Zaborowski
(cherry picked from commit 7f84c1272b601be88daeb828ec189
From: Anthony Liguori
Signed-off-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
hw/mc146818rtc.c | 33 --
hw/mc146818rtc.h |3 +-
hw/mc146818rtc_regs.h | 62 +
3 files changed, 63 insertions(+), 35
From: dann frazier
[Originally sent to qemu-kvm list, but I was redirected here]
The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of
this bit doesn't appear to change any behavior on Linux/Windows versions we've
tested, but it does cause Windows' PCI/PCI Express Complian
Il 28/03/2012 17:10, Andreas Färber ha scritto:
>> > if (dev == NULL) {
>> > -dev = container_get("/peripheral");
>> > +dev = container_get("/machine/peripheral");
> I was kinda hoping we could even do something like this in 1/4:
> container_get_relative(qdev_get_machine(), "pe
On 28 March 2012 15:37, Andrew Towers wrote:
> From: Andrew Towers
>
> Replaces the ARM_FEATURE_VFP3 check when reading MVFR0/1 with a check for
> ARM_FEATURE_V6K. Rationale: MVFR0/1 were introduced in the ARM1136 at the
> same time as ARMv6K, and a survey of TRMs indicates support in later model
On 03/27/2012 05:35 PM, Anthony Liguori wrote:
On 03/27/2012 03:24 PM, Stefan Berger wrote:
This patch adds support for TPM command line options.
The command line options supported here are
[...]
Monitor support for 'info tpm' has been added. It for example prints the
following:
(qemu) info
On Tue, Mar 27, 2012 at 07:59:07PM +0200, Michael S. Tsirkin wrote:
> piix acpi interface suffers from the following 2 issues:
>
> 1.
> - delete device a
> - quickly add device b in another slot
>
> if we do this before guest reads the down register,
> the down event is discarded and device will
On 03/27/2012 05:41 PM, Anthony Liguori wrote:
On 03/27/2012 03:24 PM, Stefan Berger wrote:
From Andreas Niederl's original posting with adaptations where
necessary:
This patch is based of off version 9 of Stefan Berger's patch series
"Qemu Trusted Platform Module (TPM) integration"
and ad
On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote:
> On 2012-03-28 13:31, Michael S. Tsirkin wrote:
> > Also, how would this support irqfd in the future? Will we have to
> > rip it all out and replace with per-device tracking that we
> > have today?
>
> Irqfd and kvm
The IDE PIO interface currently uses bdrv_read() to perform reads
synchronously. Synchronous I/O in the vcpu thread is bad because it
prevents the guest from executing code - it makes the guest
unresponsive.
This patch converts IDE PIO to use bdrv_aio_readv(). We simply need to
use the BUSY_STAT
IDE PIO mode is currently implemented using synchronous I/O functions. There's
no need to do this because the IDE interface is actually designed with polling
and interrupts in mind - we can do asynchronous I/O and let the guest know when
the operation has completed. The benefit of asynchronous I/
The IDE PIO write sector code path uses bdrv_write() and hence can make
the guest unresponsive while the I/O request is in progress. This patch
converts ide_sector_write() to use bdrv_aio_writev() by using the
BUSY_STAT bit to tell the guest that the request is in progress.
Signed-off-by: Stefan
On Wed, Mar 28, 2012 at 01:44:41PM +0200, Avi Kivity wrote:
> On 03/28/2012 01:33 PM, Jan Kiszka wrote:
> > On 2012-03-28 13:09, Avi Kivity wrote:
> > > On 03/22/2012 01:17 AM, Jan Kiszka wrote:
> > >> From: Jan Kiszka
> > >>
> > >> This patch basically adds kvm_irqchip_send_msi, a service for sen
Stefan Hajnoczi writes:
> The second aim of this conversion is to avoid calling bdrv_read()/bdrv_write()
> since they do not work with I/O throttling. This means guests should now boot
> IDE drives successfully when I/O throttling is enabled.
[...]
> Chris and Richard: Please test this to confir
Il 28/03/2012 17:43, Stefan Hajnoczi ha scritto:
> IDE PIO mode is currently implemented using synchronous I/O functions.
> There's
> no need to do this because the IDE interface is actually designed with polling
> and interrupts in mind - we can do asynchronous I/O and let the guest know
> when
Am 28.03.2012 03:05, schrieb David Gibson:
> This patch adds the PAPR defined RTAS system-reboot call to the pseries
> machine emulation, providing the guest with a way to trigger a reboot.
> This exposes a bug in the pseries VIO code which means CRQs are not
> properly reset on a system reset. Th
On 2012-03-28 17:43, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote:
>> On 2012-03-28 13:31, Michael S. Tsirkin wrote:
>>> Also, how would this support irqfd in the future? Will we have to
>>> rip it all out and replace with per-device tracking that w
On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote:
> On 2012-03-28 17:43, Michael S. Tsirkin wrote:
> > On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote:
> >> On 2012-03-28 13:31, Michael S. Tsirkin wrote:
> >>> Also, how would this support irqfd in the future? Will we have t
On Wed, 28 Mar 2012 13:17:43 +0800
Wen Congyang wrote:
> Hi, Luiz, Anthony, Jan
>
> do you have any comments about this patchset?
As far as QMP is concerned:
Acked-by: Luiz Capitulino
This can go through me tree, but I'd like an ACK from Jan and/or Anthony.
On 28 Mar 2012, at 15:26, Alon Levy wrote:
> Signed-off-by: Alon Levy
> ---
> scripts/tracetool |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/tracetool b/scripts/tracetool
> index 65bd0a1..e7cebf3 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracet
On 03/28/2012 10:26 AM, Lee Essen wrote:
>> +# 'limit', 'in' and 'next' are reserved keywords
>> +if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then
[ ... -o ... ] is not portable. POSIX says you must break it into:
[ ... ] || [ ... ]
or, more efficiently for this
2012/3/28 Alon Levy :
> - # 'limit' is a reserved keyword
> - if [ "$arg" = "limit" ]; then
> - arg="_limit"
> + # 'limit', 'in' and 'next' are reserved keywords
> + if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then
> + arg="_$arg"
>
Am 28.03.2012 02:45, schrieb David Gibson:
> On Tue, Mar 27, 2012 at 04:41:55PM +0100, Mark Cave-Ayland wrote:
>> Commit 41557447d30eeb944e42069513df13585f5e6c7f also introduced a subtle TLB
>> flush bug. By applying a mask to the interrupt MSR which cleared the IR/DR
>> bits at the start of the in
On 2012-03-28 18:30, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote:
>> On 2012-03-28 17:43, Michael S. Tsirkin wrote:
>>> On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote:
On 2012-03-28 13:31, Michael S. Tsirkin wrote:
> Also, how woul
On Wed, Mar 28, 2012 at 06:53:01PM +0200, Jan Kiszka wrote:
> On 2012-03-28 18:30, Michael S. Tsirkin wrote:
> > On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote:
> >> On 2012-03-28 17:43, Michael S. Tsirkin wrote:
> >>> On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote:
> O
Am 28.03.2012 14:52, schrieb Andreas Färber:
Hello Anthony and Justin,
As announced last year, SUSE is shipping a patched qemu-kvm 0.15.1
with our
recently released SLES 11 SP2. We are therefore very interested in cutting
0.15.2 releases for QEMU and later on qemu-kvm.
This series contains on
On 2012-03-28 19:06, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 06:53:01PM +0200, Jan Kiszka wrote:
>> On 2012-03-28 18:30, Michael S. Tsirkin wrote:
>>> On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote:
On 2012-03-28 17:43, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 20
On 03/28/2012 08:42 AM, Paolo Bonzini wrote:
This is a rebase of qtest. I split the gtester infrastructure into
its own patch, and reorganized the tests by moving everything into
tests/.
Also, libqtest now has bindings for the clock management commands, and
I am using them in rtc-test. Finally
Am 27.03.2012 19:06, schrieb Blue Swirl:
> On Tue, Mar 27, 2012 at 13:14, Andreas Färber wrote:
>> Am 27.03.2012 14:01, schrieb Lee Essen:
>>> On 27/03/2012 12:31, Andreas Färber wrote:
Am 27.03.2012 09:23, schrieb Stefan Hajnoczi:
> On Sat, Mar 24, 2012 at 04:26:27PM +, Lee Essen wro
On 03/27/2012 05:43 PM, Anthony Liguori wrote:
On 03/27/2012 03:24 PM, Stefan Berger wrote:
The following series of patches adds TPM (Trusted Platform Module)
support
to Qemu. An emulator for the TIS (TPM Interface Spec) interface is
added that provides the basis for accessing a 'backend' imple
On 3/27/12, Blue Swirl wrote:
> On Tue, Mar 27, 2012 at 18:19, Artyom Tarasenko wrote:
>> On Sun, Mar 11, 2012 at 12:02 PM, Blue Swirl wrote:
>>> Generate correct trap for external interrupts. Map PCI and ISA IRQs to
>>> RIC/UltraSPARC-IIi interrupt vectors.
>>>
>>> Signed-off-by: Blue Swirl
>>
The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap
correctly, and as a consequence pins max_gsi to 32 when it really
should be 1024. I ran into this limitation while testing pci
passthrough, where I consistently got an -ENOSPC return from
kvm_get_irq_route_gsi() called from assig
On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote:
> The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap
> correctly, and as a consequence pins max_gsi to 32 when it really
> should be 1024. I ran into this limitation while testing pci
> passthrough, where I consistently got an
Am 27.03.2012 19:24, schrieb Blue Swirl:
> On Tue, Mar 27, 2012 at 13:56, Andreas Färber wrote:
>> Am 27.03.2012 15:06, schrieb Stefan Hajnoczi:
>>> On Tue, Mar 27, 2012 at 1:01 PM, Lee Essen
>>> wrote:
On 27/03/2012 12:31, Andreas Färber wrote:
>
> Am 27.03.2012 09:23, schrieb Stef
frindex always is a 14 bits counter, and not a 13 bits one as we were
emulating. There are some subtle hints to this in the spec, first of all
"Table 2-12. FRINDEX - Frame Index Register" says:
"Bit 13:0 Frame Index. The value in this register increments at the end of
each time frame (e.g. micro-fr
On 2012-03-22 01:02, Paolo Bonzini wrote:
> Of these two functions, one is unused and the other is a dup of
> socket_set_nonblock. Unfortunately, there are some conflicts
> with system headers that need to be sorted out first.
>
> Paolo Bonzini (2):
> slirp: clean up conflicts with system heade
On 2012-03-28 20:20, Alex Williamson wrote:
> On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote:
>> The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap
>> correctly, and as a consequence pins max_gsi to 32 when it really
>> should be 1024. I ran into this limitation while testi
Avoids lots of warnings.
Signed-off-by: Jan Kiszka
---
qemu_socket.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu_socket.h b/qemu_socket.h
index fe4cf6c..51ad210 100644
--- a/qemu_socket.h
+++ b/qemu_socket.h
@@ -8,7 +8,9 @@
#include
#define socket_error()
Please, check individual patches for details.
hmp-commands.hx |3 +--
hmp.c|9 +
hmp.h|1 +
hw/pci-hotplug.c | 15 ---
hw/qdev-monitor.c| 18 +-
hw/qdev.c|5 +++--
hw/qdev.h
Currently string-output-visitor formats floats as %g, which is nice in
that trailing 0's are automatically truncated, but otherwise this causes
some issues:
- it 6 uses significant figures instead of 6 decimal places, which
means something like 155777.5 (which even has an exact floating point
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do
not currently validate this due to devfn being stored as a uint32_t.
This can lead to segfaults and other strange behavior.
We could technically just cast it to int32_t to implement the checking,
but this will not work for vis
Currently we test our visitors individually, and seperately for input
vs. output. This is useful for validating internal representations
against the native C types and vice-versa, and other visitor-specific
testing, but it doesn't cover the potential use-case of using visitor
pairs for serializatio
On Thu, Mar 22, 2012 at 04:12:12PM +0100, Andreas Färber wrote:
> Am 22.03.2012 15:37, schrieb Gerd Hoffmann:
> >>> +.driver = "USB",
> >>> +.property = "full-path",
> >>> +.value= "no",
> >>
> >> This touches on our "favorite" bit/bool topic again. While I
This patch adds the PAPR defined RTAS system-reboot call to the pseries
machine emulation, providing the guest with a way to trigger a reboot.
This exposes a bug in the pseries VIO code which means CRQs are not
properly reset on a system reset. This patch also fixes that bug by
adding a suitable r
The pseries machine code has a number of debug messages for debugging PAPR
hypercalls, dependent on DEBUG_SPAPR_HCALLS. This patch cleans these
messages up a bit, by adding __func__ to the hcall_dprintf() macro and
simplifying up a number of the individual messages accordingly.
Signed-off-by: Dav
Signed-off-by: Michael Roth
---
test-visitor-serialization.c | 40
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c
index 6ef57d0..b8ad16f 100644
--- a/test-visitor-serialization
PAPR specifies a Command Response Queue (CRQ) mechanism used for virtual
IO, which we implement. However, we don't correctly clean up registered
CRQs when we reset the system.
This patch adds a reset handler to fix this bug. While we're at it, add
in some of the extra debug messages that were us
These patches apply on top of qemu.git master, and can also be obtained from:
git://github.com/mdroth/qemu.git visitor-fixed-width-v4
CHANGES SINCE V3:
- Rebased on master and re-tested
CHANGES SINCE V2:
- Fix qemu-test errors due to now-strict bounds-checking we doing assignment
between sig
On Wed, Mar 28, 2012 at 06:15:18PM +0200, Andreas Färber wrote:
> Am 28.03.2012 03:05, schrieb David Gibson:
> > This patch adds the PAPR defined RTAS system-reboot call to the pseries
> > machine emulation, providing the guest with a way to trigger a reboot.
> > This exposes a bug in the pseries V
It currently uses qerror_report(), but next commits will convert
the drive_del command to the QAPI and this requires using
error_set().
One particularity of qerror_report() is that it knows when it's
running on monitor context or command-line context and prints the
error message accordingly. error
On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote:
On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
Signed-off-by: Anthony PERARD
Acked-by: Stefano Stabellini
Reviewed-by: me.
FYI, the scripts that I use to manage patches will collect Reviewed-by's and put
them in the comm
Signed-off-by: Anthony Liguori
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx |3 +--
hmp.c |9 +
hmp.h |1 +
hw/qdev-monitor.c | 15 +++
qapi-schema.json | 20
qmp-commands.hx |5 +
6 files changed
JSON numbers can be interpreted as either integers or floating point
values depending on their representation. As a result, QMP input visitor
might visit a QInt when it was expecting a QFloat, so add handling to
account for this.
Signed-off-by: Michael Roth
---
qapi/qmp-input-visitor.c |9 ++
This adds visitor interfaces for fixed-width integers types.
Implementing these in visitors is optional, otherwise we fall back to
visit_type_int() (int64_t) with some additional bounds checking to avoid
integer overflows for cases where the value fetched exceeds the bounds
of our target C type.
S
Signed-off-by: Michael Roth
---
hw/qdev-addr.c |4 +-
hw/qdev-properties.c | 140 ++
2 files changed, 87 insertions(+), 57 deletions(-)
diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c
index 0bb16c7..b711b6b 100644
--- a/hw/qdev-addr.c
+++
Less warnings for your console.
Signed-off-by: Jan Kiszka
---
I'll carry this in my queue.
slirp/slirp.h |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 2098b20..46bfe46 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -15,6 +1
Am 27.03.2012 19:24, schrieb Blue Swirl:
> On Tue, Mar 27, 2012 at 13:56, Andreas Färber wrote:
>> [...] While the MAINTAINER host support
>> sections do not list me (they're still new in there), Solaris patches
>> have traditionally gone through me, so that is not a particular reaction
>> to the
>> This linked list implementation is partially based on kernel code. So it
>> should be quite stable
> How about just copying the file?
>
> I've used the linux kernel list implementation elsewhere too and it
> worked just fine with only minor tweaks (remove some likely()/unlikely()
> macros IIRC)
> +static int xen_host_pci_sysfs_path(const XenHostPCIDevice *d,
> + const char *name, char *buf, ssize_t size)
> +{
> +int rc;
> +
> +rc = snprintf(buf, size, "/sys/bus/pci/devices/%04x:%02x:%02x.%x/%s",
The format is actually " %04x:%02x:%02x.%d"
> +
On Wed, Mar 28, 2012 at 04:02:04PM -0500, Anthony Liguori wrote:
> On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote:
> >On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
> >>Signed-off-by: Anthony PERARD
> >>Acked-by: Stefano Stabellini
> >
> >
> >Reviewed-by: me.
>
> FYI, the scr
On Wed, Mar 28, 2012 at 11:43 PM, Stefan Hajnoczi
wrote:
> IDE PIO mode is currently implemented using synchronous I/O functions.
> There's
> no need to do this because the IDE interface is actually designed with polling
> and interrupts in mind - we can do asynchronous I/O and let the guest kno
On Wed, Mar 28, 2012 at 04:39:07PM +0200, Gerd Hoffmann wrote:
> On 03/28/12 06:28, Alexey Korolev wrote:
> > This linked list implementation is partially based on kernel code. So it
> > should be quite stable
>
> How about just copying the file?
>
> I've used the linux kernel list implementation
On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote:
You really should say why this is added.. It is so odd just to have
'add this' without any justification. Can you at least say:
"We are using this in our quirk lookup provided by patch
titled: XXXYYY" ?
> Signed-off-by: Anthony PERA
Hi Michel,
It may be out of scope for qemu -- the scope is for the developers to
decide.
My point remains though: If this functionality isn't there when the
user installs qemu, they will find another solution. It won't be hard
to find. I have watched this happen.
Perhaps there's some synthesis
Hi,
These patches add support for the Primcell PL330 DMA controller and add it to
the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the
machine model update.
Thw Device model was originally contributed by Kirill Batuzov / Samsung, as
indicated by the (C) notice in hw/pl330
Signed-off-by: Peter A. G. Crosthwaite
---
hw/xilinx_zynq.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index 7290c64..033ba09 100644
--- a/hw/xilinx_zynq.c
+++ b/hw/xilinx_zynq.c
@@ -61,6 +61,9 @@ static void zynq
Device model for Primecell PL330 dma controller.
Signed-off-by: Peter A. G. Crosthwaite
---
MAINTAINERS |1 +
Makefile.target |1 +
hw/pl330.c | 1395 +++
3 files changed, 1397 insertions(+), 0 deletions(-)
create mode 100644
On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
> Acked-by: Stefano Stabellini
Reviewed-by: me.
> ---
> configure | 25 +
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> ind
On Wed, Mar 28, 2012 at 12:41:43PM +0100, Anthony PERARD wrote:
What is purpose of it? Can you give more details please?
> Signed-off-by: Anthony PERARD
> Acked-by: Stefano Stabellini
> ---
> hw/pci.c | 11 +++
> hw/pci.h |4 +++-
> hw/xen_platform.c |8
Sorry should be RFC
On Thu, Mar 29, 2012 at 12:54 PM, Peter A. G. Crosthwaite
wrote:
> Hi,
>
> These patches add support for the Primcell PL330 DMA controller and add it to
> the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the
> machine model update.
>
> Thw Device model
From: Li Zhang
There two entries of INDEX_op_ld_i64 in the ppc_op_defs. That causes an
assertion failure in tcg_add_target_add_op_defs() when --enable-debug is
used on a ppc64 backend (that's ppc64 host, not target).
Signed-off-by: Li Zhang
Signed-off-by: David Gibson
---
tcg/ppc64/tcg-targe
On Wed, Mar 28, 2012 at 11:30:56AM +0200, Michael S. Tsirkin wrote:
> On Wed, Mar 28, 2012 at 12:11:52PM +1100, David Gibson wrote:
> > Michael,
> >
> > Any chance of an ack or nack on this one?
> >
> > On Mon, Mar 19, 2012 at 03:58:11PM +1100, David Gibson wrote:
> > > There are several paths in
On 28.03.2012 19:43, Stefan Hajnoczi wrote:
> void ide_sector_read(IDEState *s)
> {
[]
> +s->iov.iov_base = s->io_buffer;
> +s->iov.iov_len = n * BDRV_SECTOR_SIZE;
> +qemu_iovec_init_external(&s->qiov, &s->iov, 1);
> +
> +bdrv_acct_start(s->bs, &s->acct, n * BDRV_SECTOR_SIZE, BDR
On 28.03.2012 19:43, Stefan Hajnoczi wrote:
...
> void ide_sector_read(IDEState *s)
> {
...
> +s->iov.iov_base = s->io_buffer;
> +s->iov.iov_len = n * BDRV_SECTOR_SIZE;
> +qemu_iovec_init_external(&s->qiov, &s->iov, 1);
> +bdrv_aio_readv(s->bs, sector_num, &s->qiov, n,
> +
101 - 179 of 179 matches
Mail list logo
