On Thu, Mar 22, 2012 at 04:12:12PM +0100, Andreas Färber wrote: > Am 22.03.2012 15:37, schrieb Gerd Hoffmann: > >>> + .driver = "USB", > >>> + .property = "full-path", > >>> + .value = "no", > >> > >> This touches on our "favorite" bit/bool topic again. While I agree that > >> "no" makes sense for a property of that name, the current code still > >> expects "on" and "off". In particular, "yes" would not work as expected. > > > > "no" *does* work as expected though, at least it survived my tests, > > thats why I didn't notice. > > > > I can s/no/off/ for consistency, no problem. Merging your yes/no patch > > is fine with me too. > > I stand corrected: Michael Roth's conversion of qdev properties to use > visitors implicitly changed the parsing logic to cover yes/no and > true/false as well. That's great news!
I believe Paolo did that conversion, but agreed :) > > So no change of .value is needed here. The only thing to note is that > print_bit() will output the value as on/off. > > Sorry for the confusion, > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
