Re: [Qemu-devel] XP install cores with SCSI LSI 53C895A disks

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 08:35, Gerd Hoffmann ha scritto: > Is INT13h supported for legacy OS and to boot? Future? But as far as > I saw implemented in seabios, right? Yes, Kevin (O' Connor, not Wolf) integrated the patch this week. It will also be in Fedora 17. > What BIOS translation is used? Buslogic? L

Re: [Qemu-devel] XP install cores with SCSI LSI 53C895A disks

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 08:46, Gerhard Wiesinger ha scritto: > On Fri, 9 Mar 2012, Gerd Hoffmann wrote: > >> Hi, >> > #2 isn't an issue actually, at least for Debian users -- Well, it is, to some degree. Because vanilla upstream doesn't support booting from lsi it has alot less users an

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Chris Wedgwood
> This will enable discard on more filesystems, including ext4. i think this should default to off for preallocated files this will punch holes all over the place and reallocation will cause fragmentation (guests will free and reallocat blocks normally) xfs has a mechanism to convert to unwritt

Re: [Qemu-devel] [PATCH] hw/pxa2xx.c: Fix handling of pxa2xx_i2c variable offset within region

2012-03-09 Thread Peter Maydell
On 8 March 2012 23:48, Andreas Färber wrote: > Am 08.03.2012 14:58, schrieb Peter Maydell: >> The pxa2xx I2C controller can be at an arbitrary offset within its >> region (this is used because one of the controllers starts at offset >> 0x1600 into an 0x1 sized region). The previous implementat

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 09:20, Chris Wedgwood ha scritto: > for preallocated files this will punch holes all over the place and > reallocation will cause fragmentation (guests will free and reallocat > blocks normally) SEEK_HOLE could provide a very simple heuristic to detect preallocated files (unfortunate

Re: [Qemu-devel] [RfC PATCH 1/2] usb: the big rename

2012-03-09 Thread Paolo Bonzini
Il 08/03/2012 10:16, Gerd Hoffmann ha scritto: > Reorganize usb source files. Create a new hw/usb/ directory and move > all usb source code to that place. Also make filenames a bit more > descriptive. Host adapters are prefixed with "hch-" now Nice tribute to Christoph, but I think I prefer hcd

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> For another, dev-foo.c is not natural English for a certain type of >> device - foo-dev.c would be better but I'd prefer without "dev", i.e., >> hw/usb/{audio,ccid,...}.c. And then of course only devices should go >> into hw/. > > I want a prefix because with pr

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Chris Wedgwood
> SEEK_HOLE could provide a very simple heuristic to detect preallocated > files (unfortunately ext4 does not implement SEEK_HOLE yet). SEEK_HOLE is a weird (confusing and no intuitive) API (IMO). There is FIEMAP or whatever it's called which seems somewhat saner. XFS specific there is also GETB

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 07:50, Gerd Hoffmann ha scritto: > I want a prefix because with prefixing you get the files nicely grouped > in directory listings, without creating another directory level, which > would IMHO be overkill for the number of files we have here. > > 'dev-*' is used for emulated usb devi

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 09:35, Chris Wedgwood ha scritto: >> SEEK_HOLE could provide a very simple heuristic to detect preallocated >> files (unfortunately ext4 does not implement SEEK_HOLE yet). > > SEEK_HOLE is a weird (confusing and no intuitive) API (IMO). There is > FIEMAP or whatever it's called whic

Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files.

2012-03-09 Thread Gerd Hoffmann
Hi, >> 'dev-' isn't the greated pick as it is somewhat generic indeed. I've >> also considered 'emu-' (to contrast with host-*), but it has pretty much >> the same issue. Other suggestions? > > Looks like all your dev- actually start with dev-usb-. No, they don't, I've dropped 'usb-' prefix

Re: [Qemu-devel] [RfC PATCH 1/2] usb: the big rename

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 09:42, Gerd Hoffmann ha scritto: >>> emulations are prefixed with "dev-". Fixup paths Makefile and include >>> >> paths to make it compile. No code changes. >> > >> > Let's start using include/usb instead? > I think that needs a few more cleanups beforehand, there is a single > usb

Re: [Qemu-devel] [RfC PATCH 1/2] usb: the big rename

2012-03-09 Thread Gerd Hoffmann
Hi, >> emulations are prefixed with "dev-". Fixup paths Makefile and include >> paths to make it compile. No code changes. > > Let's start using include/usb instead? I think that needs a few more cleanups beforehand, there is a single usb.h now, guess I better should split that into usb-priv

[Qemu-devel] [PATCH v1 03/12] net: Look up 'vlan' net clients using hubs

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v1 11/12] net: Rename vc local variables to nc

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

Re: [Qemu-devel] Add support for new image type

2012-03-09 Thread Kevin Wolf
Am 08.03.2012 18:16, schrieb Nate Bushman: > You make really good points on opening up the image file format. I see real > value there in that it would foster development of other solutions around > that format. The problem in this case is that StorageCraft's backup image > format uses proprie

[Qemu-devel] [PATCH v1 12/12] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepro100.

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Markus Armbruster
Mark Langsdorf writes: > Allow load_image_targphys to load files on systems with more than 2G of > emulated memory by changing the max_sz parameter from an int to an > unsigned long. > > Signed-off-by: Mark Langsdorf > --- > hw/loader.c |4 ++-- > hw/loader.h |3 ++- > 2 files changed,

Re: [Qemu-devel] [RfC PATCH 1/2] usb: the big rename

2012-03-09 Thread Gerd Hoffmann
Hi, > As I understood it, the idea is to make it simply Linux-like, with > public headers in include/ and private headers elsewhere. > > So even interfaces that are private to the USB layer, but shared among > multiple directories would be in include/. > > I suppose the external interfaces are

Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 06:01, schrieb David Gibson: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. This i

[Qemu-devel] [PATCH v1 06/12] net: Remove vlan qdev property

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

Re: [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 06:01, schrieb David Gibson: > dma-helpers.c contains a number of helper functions for doing > scatter/gather DMA, and various block device related DMA. Currently, > these directly access guest memory using cpu_physical_memory_*(), > assuming no IOMMU translation. > > This patch upd

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 11:51 PM, Ademar Reis wrote: > On Thu, Mar 08, 2012 at 05:21:44PM -0600, Anthony Liguori wrote: >> On 03/08/2012 04:24 PM, Ademar Reis wrote: >> >On Thu, Mar 08, 2012 at 03:24:15PM -0600, Anthony Liguori wrote: >> >>On 03/08/2012 03:02 PM, Ademar Reis wrote: >> >>>On Thu, Ma

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Jan Kiszka
On 2012-03-09 03:53, HATAYAMA Daisuke wrote: > From: Wen Congyang > Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping > Date: Fri, 09 Mar 2012 10:26:56 +0800 > >> At 03/09/2012 10:05 AM, HATAYAMA Daisuke Wrote: >>> From: Wen Congyang >>> Subject: Re: [RFC][PATCH 05/16 v8] Add API

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Jan Kiszka
On 2012-03-09 03:53, HATAYAMA Daisuke wrote: > From: Wen Congyang > Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping > Date: Fri, 09 Mar 2012 10:26:56 +0800 > >> At 03/09/2012 10:05 AM, HATAYAMA Daisuke Wrote: >>> From: Wen Congyang >>> Subject: Re: [RFC][PATCH 05/16 v8] Add API

Re: [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 06:01, schrieb David Gibson: > The AHCI device can provide both PCI and SysBus AHCI device > emulations. For this reason, it wasn't previously converted to use > the pci_dma_*() helper functions. Now that we have universal DMA > helper functions, this converts AHCI to use them. > >

Re: [Qemu-devel] building with today qemu-kvm git fail (vcard_emul_nss.c)

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 3:27 PM, Alexandre DERUMIER wrote: > Hi, > > i'm trying to build the last kvm git, > > ./configure --prefix=/usr --datadir=/usr/share/kvm > --docdir=/usr/share/doc/pve-qemu-kvm --sysconfdir=/etc --disable-xen > --enable-vnc-tls --enable-sdl --enable-uuid --enable-linux-aio

[Qemu-devel] [PATCH v1 01/12] net: Add a hub net client

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Wen Congyang
At 03/09/2012 05:41 PM, Jan Kiszka Wrote: > On 2012-03-09 03:53, HATAYAMA Daisuke wrote: >> From: Wen Congyang >> Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping >> Date: Fri, 09 Mar 2012 10:26:56 +0800 >> >>> At 03/09/2012 10:05 AM, HATAYAMA Daisuke Wrote: From: Wen Congyang

[Qemu-devel] [PATCH v1 05/12] net: Drop vlan argument to qemu_new_net_client()

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v1 04/12] hub: Check that hubs are configured correctly

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

Re: [Qemu-devel] [PATCH 02/13] Better support for dma_addr_t variables

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > A while back, we introduced the dma_addr_t type, which is supposed to > be used for bus visible memory addresses. At present, this is an > alias for target_phys_addr_t, but this will change when we eventually > add support for guest visible IOMMUs. >

[Qemu-devel] [PATCH v1 02/12] net: Use hubs for the vlan feature

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 46 ++

Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. Thi

[Qemu-devel] [PATCH v1 09/12] net: Rename non_vlan_clients to net_clients

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Jan Kiszka
On 2012-03-09 10:57, Wen Congyang wrote: > At 03/09/2012 05:41 PM, Jan Kiszka Wrote: >> On 2012-03-09 03:53, HATAYAMA Daisuke wrote: >>> From: Wen Congyang >>> Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping >>> Date: Fri, 09 Mar 2012 10:26:56 +0800 >>> At 03/09/2012 10:05 AM

Re: [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > +static inline int dma_memory_read(DMAContext *dma, dma_addr_t addr, > + void *buf, dma_addr_t len) > +{ > +return dma_memory_rw(dma, addr, buf, len, DMA_DIRECTION_TO_DEVICE); > +} > + > +static inline int dma_memo

[Qemu-devel] [PATCH v1 08/12] net: Remove VLANState

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Jan Kiszka
On 2012-03-09 11:05, Jan Kiszka wrote: >>> If crash can work both with and without paging, it should be default >>> *on* to avoid writing cores that can later on only be analyzed with that >>> tool. Still not sure, though, if that changes the requirement on what >>> memory regions should be written

[Qemu-devel] [PATCH v1 00/12] net: hub implemention

2012-03-09 Thread zwu . kernel
From: Zhi Yong Wu The patchset implements network hub stead of vlan. The main work was done by stefan, and i only rebased it to latest QEMU upstream, did some testings and will be responsible for pushing it to QEMU upstream. Stefan Hajnoczi (12): net: Add a hub net client net: Use hubs for

Re: [Qemu-devel] [PATCH 2/2] make check: Add qemu-iotests subset

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 5:01 PM, Kevin Wolf wrote: > Am 08.03.2012 17:52, schrieb Stefan Hajnoczi: >> On Thu, Mar 8, 2012 at 4:10 PM, Kevin Wolf wrote: >>> Am 08.03.2012 16:51, schrieb Stefan Hajnoczi: On Thu, Mar 8, 2012 at 11:32 AM, Kevin Wolf wrote: > Run the 'quick' group from qemu-i

Re: [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > dma-helpers.c contains a number of helper functions for doing > scatter/gather DMA, and various block device related DMA. Currently, > these directly access guest memory using cpu_physical_memory_*(), > assuming no IOMMU translation. > > This patch

[Qemu-devel] [PATCH v1 07/12] net: Remove vlan code from net.c

2012-03-09 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [Bug 950692] [NEW] High CPU usage in Host (revisited)

2012-03-09 Thread PetaMem
Public bug reported: Hi, last time QEMU(KVM) was working for us flawlessly was 2.6.35 kernel. Actually it still works flawlessly on that one single machine, that still has this kernel. Qemu version is meanwhile 1.0-r3, so the problem seems to be dependent on kernel version and not qemu version.

Re: [Qemu-devel] [patch] correct tracing.txt

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 8:30 AM, 陳韋任 wrote: >  Simple patch should cc to qemu-triv...@nongnu.org :). Not in all cases. qemu-trivial is a catch-all for simple patches so we don't forget them. It was a solution to the problem that patches were often forgotten if they touch a QEMU subsystem that is

Re: [Qemu-devel] [PATCH 10/13] iommu: Introduce IOMMU emulation infrastructure

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > This patch adds the basic infrastructure necessary to emulate an IOMMU > visible to the guest. The DMAContext structure is extended with > information and a callback describing the translation, and the various > DMA functions used by devices will now

Re: [Qemu-devel] [PATCH 13/13] pseries: Implement IOMMU and DMA for PAPR PCI devices

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 06:01, David Gibson ha scritto: > Currently the pseries machine emulation does not support DMA for emulated > PCI devices, because the PAPR spec always requires a (guest visible, > paravirtualized) IOMMU which was not implemented. Now that we have > infrastructure for IOMMU emulation

Re: [Qemu-devel] Add support for new image type

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 10:23, Kevin Wolf ha scritto: >> You make really good points on opening up the image file format. >> I see real value there in that it would foster development of >> other solutions around that format. The problem in this case is >> that StorageCraft's backup image format uses propri

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 5:15 PM, Paolo Bonzini wrote: > This will enable discard on more filesystems, including ext4. > > Signed-off-by: Paolo Bonzini > --- >  block/raw-posix.c |   29 - >  1 files changed, 24 insertions(+), 5 deletions(-) > > diff --git a/block/raw-pos

Re: [Qemu-devel] [PATCH v1 01/12] net: Add a hub net client

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 10:00, zwu.ker...@gmail.com ha scritto: > +/* TODO use qemu_send_packet() or need to call *_deliver_* directly? > */ > +/* TODO ignore return value? */ > +qemu_send_packet(&port->nc, buf, len); Did you see my message at http://permalink.gmane.org/gmane.comp.

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 11:31, Stefan Hajnoczi ha scritto: >> > +#ifdef FALLOC_FL_PUNCH_HOLE >> > +retval = fallocate(s->fd, FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE, >> > + sector_num << 9, (int64_t)nb_sectors << 9); > I'm concerned about introducing blocking syscalls in coroutine

Re: [Qemu-devel] [PATCH 1/5] block: Virtual Bridges VERDE GOW disk image format documentation

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 10:13 PM, Leonardo E. Reiter wrote: > commit 4b7b36f3776247c92615073b6fa0880d0a1ea1fb > Author: Leonardo E. Reiter > Date:   Thu Mar 8 15:50:55 2012 -0600 > >     Documentation for Virtual Bridges GOW version 1, 2, and 3 disk image > formats.  Includes products consuming th

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 10:43 AM, Paolo Bonzini wrote: > Il 09/03/2012 11:31, Stefan Hajnoczi ha scritto: >>> > +#ifdef FALLOC_FL_PUNCH_HOLE >>> > +    retval = fallocate(s->fd, FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE, >>> > +                       sector_num << 9, (int64_t)nb_sectors << 9); >> I'

Re: [Qemu-devel] [RFC PATCH 14/17] block: support FALLOC_FL_PUNCH_HOLE trimming

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 11:53, Stefan Hajnoczi ha scritto: > >> > 1) require a new-enough kernel and only use fallocate; return a NULL >> > aiocb if !has_discard and convert it to ENOTSUP. >> > >> > 2) extract now from my threads branch the work to generalize >> > posix-aio-compat into a more flexible threa

Re: [Qemu-devel] [PATCH 2/5] block: Virtual Bridges VERDE GOW disk image format data structures and common MACROs

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 10:14 PM, Leonardo E. Reiter wrote: > +#if defined(BLOCK_GOW1) > +#define GOW_MAGIC       GOW1_MAGIC > +#define GOW_MAXBLOCKS   1048576 > + > +/* GOW1: header is not padded */ > +/* header type, contains map */ > +typedef struct { > +    uint32_t magic; > +    uint32_t size;

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 00:51, schrieb Ademar Reis: > On Thu, Mar 08, 2012 at 05:21:44PM -0600, Anthony Liguori wrote: >>> Plus it's not unconditional: the test runner will report tests >>> SKIPPED if a dependency is not present. >> >> But then the tests aren't run so if most developers didn't have it >> ins

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Cleber Rosa
On 03/08/2012 08:21 PM, Anthony Liguori wrote: On 03/08/2012 04:24 PM, Ademar Reis wrote: On Thu, Mar 08, 2012 at 03:24:15PM -0600, Anthony Liguori wrote: On 03/08/2012 03:02 PM, Ademar Reis wrote: On Thu, Mar 08, 2012 at 01:16:58PM -0600, Anthony Liguori wrote: On 03/08/2012 11:59 AM, Ademar

Re: [Qemu-devel] Add support for new image type

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 11:28, schrieb Paolo Bonzini: > Il 09/03/2012 10:23, Kevin Wolf ha scritto: >>> You make really good points on opening up the image file format. >>> I see real value there in that it would foster development of >>> other solutions around that format. The problem in this case is >>> t

[Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-09 Thread Stefan Hajnoczi
Hi, I have a question about the libvirt SELinux policy that can be applied to QEMU processes. Yesterday Laine helped Khoa and me diagnose an issue where QEMU was doing fstatfs(2) but SELinux prevented this FILESYSTEM__GETATTR operation, resulting in a failed syscall with -EACCES. The SELinux hook

Re: [Qemu-devel] [PATCH 3/5] block: Virtual Bridges VERDE GOW disk image format, legacy GOW version 1 support implementation

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 10:15 PM, Leonardo E. Reiter wrote: > +#ifndef _WIN32 > +#include I recommend writing this in a platform-independent way using bdrv_*() APIs to access the image file. This has been a requirement for all block drivers. Legacy drivers have been updated too. The chance of

Re: [Qemu-devel] [PATCH 13/13] pseries: Implement IOMMU and DMA for PAPR PCI devices

2012-03-09 Thread David Gibson
On Fri, Mar 09, 2012 at 11:23:58AM +0100, Paolo Bonzini wrote: > Il 09/03/2012 06:01, David Gibson ha scritto: > > Currently the pseries machine emulation does not support DMA for emulated > > PCI devices, because the PAPR spec always requires a (guest visible, > > paravirtualized) IOMMU which was

Re: [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions

2012-03-09 Thread David Gibson
On Fri, Mar 09, 2012 at 11:06:41AM +0100, Paolo Bonzini wrote: > Il 09/03/2012 06:01, David Gibson ha scritto: > > +static inline int dma_memory_read(DMAContext *dma, dma_addr_t addr, > > + void *buf, dma_addr_t len) > > +{ > > +return dma_memory_rw(dma, addr, b

Re: [Qemu-devel] [PATCH 4/5] block: Virtual Bridges VERDE GOW disk image format, GOW version 2 and version 3 support implementation

2012-03-09 Thread Stefan Hajnoczi
On Thu, Mar 8, 2012 at 10:16 PM, Leonardo E. Reiter wrote: > +    s->full_block = calloc(1, GOW_BLOCKSIZE); Please use g_malloc0(GOW_BLOCKSIZE) and g_free() instead of standard library memory allocation functions. The glib memory management functions are a bit richer than the standard library fu

Re: [Qemu-devel] [patch] correct tracing.txt

2012-03-09 Thread Peter Maydell
On 9 March 2012 10:20, Stefan Hajnoczi wrote: > Not in all cases.  qemu-trivial is a catch-all for simple patches so > we don't forget them.  It was a solution to the problem that patches > were often forgotten if they touch a QEMU subsystem that isn't > actively maintained. I think you could arg

Re: [Qemu-devel] [KVM-AUTOTEST] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Osier Yang
On 2012年03月08日 20:17, Ademar Reis wrote: On Thu, Mar 08, 2012 at 11:54:31AM +, Stefan Hajnoczi wrote: On Thu, Mar 8, 2012 at 11:44 AM, Stefan Hajnoczi wrote: On Thu, Mar 8, 2012 at 4:00 AM, Lucas Meneghel Rodrigues wrote: One of our main goals is to provide useful tools for the qemu com

Re: [Qemu-devel] [patch] correct tracing.txt

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 11:48 AM, Peter Maydell wrote: > On 9 March 2012 10:20, Stefan Hajnoczi wrote: >> Not in all cases.  qemu-trivial is a catch-all for simple patches so >> we don't forget them.  It was a solution to the problem that patches >> were often forgotten if they touch a QEMU subsys

Re: [Qemu-devel] XP install cores with SCSI LSI 53C895A disks

2012-03-09 Thread Kevin O'Connor
On Fri, Mar 09, 2012 at 07:18:38AM +0100, Gerhard Wiesinger wrote: > BTW: I've found out how LSI logic BIOS geometry translation works > with (guessing) and without existing partition table. That might be > an option > for Seabios to implement. > @Kevin: What do you think? SeaBIOS has an algorithm

Re: [Qemu-devel] [PATCH 5/5] block: Virtual Bridges VERDE GOW disk image format, modifications to build components

2012-03-09 Thread Kevin Wolf
Am 08.03.2012 23:17, schrieb Leonardo E. Reiter: > commit eb7af36f02ff3b5bc13c2166a008de29632d5500 > Author: Leonardo E. Reiter > > Date: Thu Mar 8 15:56:49 2012 -0600 > > Include GOW disk image format objects in compilation and link. > Signed-off-by: Leonar

Re: [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 12:19, David Gibson ha scritto: >> > >> > This is opposite to the convention of dma_buf_read/dma_buf_write, which >> > is from the point of view of the device. > Uh, these are from the point of view of the device - the device writes > to memory == transfer from device. Right, dma_bu

Re: [Qemu-devel] [PATCH 3/5] block: Virtual Bridges VERDE GOW disk image format, legacy GOW version 1 support implementation

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 12:42, schrieb Stefan Hajnoczi: > On Thu, Mar 8, 2012 at 10:15 PM, Leonardo E. Reiter > wrote: >> +#ifndef _WIN32 >> +#include > > I recommend writing this in a platform-independent way using bdrv_*() > APIs to access the image file. This has been a requirement for all > block dri

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/09/2012 05:14 AM, Kevin Wolf wrote: Am 09.03.2012 00:51, schrieb Ademar Reis: On Thu, Mar 08, 2012 at 05:21:44PM -0600, Anthony Liguori wrote: Plus it's not unconditional: the test runner will report tests SKIPPED if a dependency is not present. But then the tests aren't run so if most

Re: [Qemu-devel] [PATCH 3/5] block: Virtual Bridges VERDE GOW disk image format, legacy GOW version 1 support implementation

2012-03-09 Thread Kevin Wolf
Am 08.03.2012 23:15, schrieb Leonardo E. Reiter: > +BlockDriver bdrv_gow1 = { > +.format_name= "gow1", > +.instance_size = sizeof(gow1_state_t), > +.bdrv_probe = gow1_probe, > +.bdrv_file_open = gow1_open, > +.bdrv_close = gow1_close, > +.bdrv_read = gow1_r

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific then. Look at device-add.sh in qemu-test. It's 71LOC. pci_hotplug.py in autotest is 204LOC. pci_hotplug.py does much more than device-add.s

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Kevin Wolf
Am 09.03.2012 12:59, schrieb Anthony Liguori: > On 03/09/2012 05:14 AM, Kevin Wolf wrote: >> Am 09.03.2012 00:51, schrieb Ademar Reis: >>> On Thu, Mar 08, 2012 at 05:21:44PM -0600, Anthony Liguori wrote: > Plus it's not unconditional: the test runner will report tests > SKIPPED if a depende

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/08/2012 05:07 PM, Lucas Meneghel Rodrigues wrote: On 03/08/2012 06:24 PM, Anthony Liguori wrote: Cons: - Lot of code will be duplicated to cover the main code paths: writting tests will require writting/supporting considerable ammount of code (that already exists in autotest). Again, ex

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/09/2012 06:13 AM, Kevin Wolf wrote: Am 09.03.2012 12:59, schrieb Anthony Liguori: On 03/09/2012 05:14 AM, Kevin Wolf wrote: Am 09.03.2012 00:51, schrieb Ademar Reis: On Thu, Mar 08, 2012 at 05:21:44PM -0600, Anthony Liguori wrote: Plus it's not unconditional: the test runner will report

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Cleber Rosa
On 03/09/2012 09:04 AM, Anthony Liguori wrote: On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific then. Look at device-add.sh in qemu-test. It's 71LOC. pci_hotplug.py in autotest is 204LOC.

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/09/2012 06:40 AM, Cleber Rosa wrote: On 03/09/2012 09:04 AM, Anthony Liguori wrote: On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific then. Look at device-add.sh in qemu-test. It's 71

[Qemu-devel] [PATCH v2 0/3] make check: Add qemu-iotests subset

2012-03-09 Thread Kevin Wolf
Kevin Wolf (3): qemu-iotests: Mark some tests as quick make check: Add qemu-iotests subset Add 'make check-block' tests/Makefile | 11 ++- tests/check-block.sh| 21 + tests/qemu-iotests-quick.sh | 17 + tests/qemu-iotest

[Qemu-devel] [PATCH v2 3/3] Add 'make check-block'

2012-03-09 Thread Kevin Wolf
Runs the full qemu-iotests suite for various image formats. Signed-off-by: Kevin Wolf --- tests/Makefile |6 +- tests/check-block.sh | 21 + 2 files changed, 26 insertions(+), 1 deletions(-) create mode 100755 tests/check-block.sh diff --git a/tests/Makefile

[Qemu-devel] [PATCH v2 1/3] qemu-iotests: Mark some tests as quick

2012-03-09 Thread Kevin Wolf
This creates a new test group 'quick' for some test case that take at most a couple of seconds each, so that the group can be run during a quick 'make check' Signed-off-by: Kevin Wolf --- tests/qemu-iotests/group | 24 1 files changed, 12 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset

2012-03-09 Thread Kevin Wolf
Run the 'quick' group from qemu-iotests during 'make check'. Signed-off-by: Kevin Wolf --- tests/Makefile |5 + tests/qemu-iotests-quick.sh | 17 + 2 files changed, 22 insertions(+), 0 deletions(-) create mode 100755 tests/qemu-iotests-quick.sh diff --git

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Cleber Rosa
On 03/09/2012 09:42 AM, Anthony Liguori wrote: On 03/09/2012 06:40 AM, Cleber Rosa wrote: On 03/09/2012 09:04 AM, Anthony Liguori wrote: On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific t

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-09 Thread Gerd Hoffmann
On 03/08/12 01:41, David Gibson wrote: > From: Benjamin Herrenschmidt > -assert(s->csw.sig == 0x53425355); > +assert(s->csw.sig == cpu_to_le32(0x53425355)); Correct but incomplete. residue is sent in host endian instead of little endian too. It is zero most of the time though, so it ea

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Lucas Meneghel Rodrigues
On 03/09/2012 09:13 AM, Anthony Liguori wrote: On 03/08/2012 05:07 PM, Lucas Meneghel Rodrigues wrote: Here is the qemu-test version http://git.qemu.org/?p=qemu-test.git;a=blob;f=tests/virtio-serial.sh;h=e95ae6e0b63758262919702d51a9c83bebe2fb08;hb=master So virtio-serial is an exception in a

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread HATAYAMA Daisuke
From: Jan Kiszka Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping Date: Fri, 09 Mar 2012 11:06:30 +0100 > On 2012-03-09 11:05, Jan Kiszka wrote: If crash can work both with and without paging, it should be default *on* to avoid writing cores that can later on only be ana

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Paolo Bonzini
Il 08/03/2012 18:59, Ademar Reis ha scritto: > unit-test: > void main() > { > my_function(); > } > > integration test (or validation test): > void main() > { > exec("my-application"); > } > > But that's all semantics, not important for this discussion IMO.

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Paolo Bonzini
Il 08/03/2012 22:24, Anthony Liguori ha scritto: > The qemu-test tests are smaller than the corresponding autotest tests. They also do much less. It's true that a combination of qemu-test + qtests could do 99% of the job more simply than autotest. But the last 1% (including migration) would requ

Re: [Qemu-devel] [RFC PATCH 0/3] qcow2: Save requests during cluster allocation

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 2, 2012 at 6:48 PM, Kevin Wolf wrote: > When a write request spans both allocated and unallocated clusters, qcow2 > splits the request in two parts. This is not necessary if we have sequential > writes: If the unallocated area can be allocated such that in the image file > it > is adj

Re: [Qemu-devel] [PATCH] PPC: Fix large page support in TCG

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 04:42, David Gibson wrote: > On Thu, Mar 08, 2012 at 09:24:53AM -0600, Nathan Whitehorn wrote: >> >> On Mar 7, 2012, at 7:25 PM, David Gibson wrote: >> >>> On Sat, Mar 03, 2012 at 10:39:34AM -0600, Nathan Whitehorn wrote: Fix large page support in TCG. The old code would

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Mark Langsdorf
On 03/09/2012 03:25 AM, Markus Armbruster wrote: > Mark Langsdorf writes: > >> Allow load_image_targphys to load files on systems with more than 2G of >> emulated memory by changing the max_sz parameter from an int to an >> unsigned long. >> >> Signed-off-by: Mark Langsdorf >> --- >> hw/loader.

Re: [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset

2012-03-09 Thread Stefan Hajnoczi
On Fri, Mar 9, 2012 at 12:46 PM, Kevin Wolf wrote: > Run the 'quick' group from qemu-iotests during 'make check'. > > Signed-off-by: Kevin Wolf > --- >  tests/Makefile              |    5 + >  tests/qemu-iotests-quick.sh |   17 + >  2 files changed, 22 insertions(+), 0 deletio

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 14:15, Mark Langsdorf wrote: > On 03/09/2012 03:25 AM, Markus Armbruster wrote: >> Mark Langsdorf writes: >> >>> Allow load_image_targphys to load files on systems with more than 2G of >>> emulated memory by changing the max_sz parameter from an int to an >>> unsigned long. >>

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Paolo Bonzini
Il 09/03/2012 01:04, Anthony Liguori ha scritto: >> >> * Sends data between host and guest back and forth, validates the data >> being >> sent, for both small and large amounts of data, both random or >> sequential. >> * Tests write/send in blocking, polling, selecting mode, with port >> mode sync/

Re: [Qemu-devel] [RFC][PATCH 05/16 v8] Add API to get memory mapping

2012-03-09 Thread Jan Kiszka
On 2012-03-09 13:53, HATAYAMA Daisuke wrote: > From: Jan Kiszka > Subject: Re: [RFC][PATCH 05/16 v8] Add API to get memory mapping > Date: Fri, 09 Mar 2012 11:06:30 +0100 > >> On 2012-03-09 11:05, Jan Kiszka wrote: > If crash can work both with and without paging, it should be default > *

Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'

2012-03-09 Thread Andreas Färber
Am 09.03.2012 13:46, schrieb Kevin Wolf: > Runs the full qemu-iotests suite for various image formats. > > Signed-off-by: Kevin Wolf > --- > tests/Makefile |6 +- > tests/check-block.sh | 21 + > 2 files changed, 26 insertions(+), 1 deletions(-) > create mode

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Mark Langsdorf
On 03/09/2012 07:21 AM, Alexander Graf wrote: > > On 09.03.2012, at 14:15, Mark Langsdorf wrote: > >> On 03/09/2012 03:25 AM, Markus Armbruster wrote: >>> Mark Langsdorf writes: >>> Allow load_image_targphys to load files on systems with more than 2G of emulated memory by changing the

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Paolo Bonzini
Il 08/03/2012 22:03, Anthony Liguori ha scritto: >>> >>> >>> Herein lies the problem. You forgot and it's your proposal :-) >> >> Ok, fair enough :) But still, qemu-jeos points out to external >> repositories, >> just as much as buildroot. It seems to me that the whole point about FSF >> requiring

Re: [Qemu-devel] [PATCH] use an unsigned long for the max_sz parameter in load_image_targphys

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 14:34, Mark Langsdorf wrote: > On 03/09/2012 07:21 AM, Alexander Graf wrote: >> >> On 09.03.2012, at 14:15, Mark Langsdorf wrote: >> >>> On 03/09/2012 03:25 AM, Markus Armbruster wrote: Mark Langsdorf writes: > Allow load_image_targphys to load files on systems

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

2012-03-09 Thread Anthony Liguori
On 03/09/2012 07:07 AM, Paolo Bonzini wrote: Il 08/03/2012 22:24, Anthony Liguori ha scritto: The qemu-test tests are smaller than the corresponding autotest tests. They also do much less. It's true that a combination of qemu-test + qtests could do 99% of the job more simply than autotest. B

  1   2   3   >