Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-29 Thread Alon Levy
On Tue, Feb 28, 2012 at 05:10:39PM -0300, Luiz Capitulino wrote: > On Sat, 25 Feb 2012 10:46:07 +0200 > Alon Levy wrote: > > > On Fri, Feb 24, 2012 at 04:40:15PM -0600, Anthony Liguori wrote: > > > On 02/24/2012 03:22 PM, Alon Levy wrote: > > > >This is an across the board change since I wanted t

[Qemu-devel] question about qemu-generated vmcore

2012-02-29 Thread Wen Congyang
Hi all. As you know, I am implementing a new, dedicated memory dump mechanism. crash cannot get phys_base, because the guest may be in the kdump kernel. As Dave and hatayama suggested, I want to put extra CPU's information in PT_NOTE. For example: $ readelf -n vmcore Notes at offset 0x01c8

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 5:15 PM, Martin Mailand wrote: > Hi Stefan, > I was bisecting qemu-kvm.git. qemu-kvm.git regularly merges from qemu.git. The history of the qemu-kvm.git repository is not linear because of these periodic merges from the qemu.git tree. I think what happened is that git bi

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-02-29 Thread Ori Mamluk
Hi Kevin and all, I think the BlockFilter direction goes very well with our plans for a replication module. I guess it would take some discussions and time to form a solid layer for the BlockFilters, and I'd like to move ahead in parallel with the replication module. What do you say about the

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-29 Thread Alon Levy
On Tue, Feb 28, 2012 at 05:05:32PM -0300, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 23:22:05 +0200 > Alon Levy wrote: > > > This is an across the board change since I wanted to keep the existing > > (good imo) single graphic_console_init callback setter, instead of > > introducing a new cb tha

Re: [Qemu-devel] [PATCH 1/4] qapi-schema: fix typos and explain 'spice' auth

2012-02-29 Thread Alon Levy
On Tue, Feb 28, 2012 at 04:57:10PM -0300, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 23:22:02 +0200 > Alon Levy wrote: > > > Signed-off-by: Alon Levy > > --- > > qapi-schema.json | 18 ++ > > 1 files changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/qapi-schema

Re: [Qemu-devel] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-29 Thread Kevin O'Connor
On Mon, Feb 27, 2012 at 04:25:09PM +0100, Jan Kiszka wrote: > On 2012-02-27 10:51, Daniel P. Berrange wrote: > > I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following > > crash: > > > > # qemu-system-x86_64 -fda ~/MS-DOS\ 6.22.img -m 1 -curses Does the error persist when run wi

Re: [Qemu-devel] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 03:45:13AM -0500, Kevin O'Connor wrote: > On Mon, Feb 27, 2012 at 04:25:09PM +0100, Jan Kiszka wrote: > > On 2012-02-27 10:51, Daniel P. Berrange wrote: > > > I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following > > > crash: > > > > > > # qemu-system-x86_

Re: [Qemu-devel] QOM: why "klass" used instead of "class" ?

2012-02-29 Thread Evgeny Voevodin
On 29.02.2012 13:05, 陳韋任 wrote: On Wed, Feb 29, 2012 at 10:59:54AM +0400, Michael Tokarev wrote: On 29.02.2012 09:52, Evgeny Voevodin wrote: include/qemu/object.h: [] * void my_device_class_init(ObjectClass *klass, void *class_data) * { * DeviceClass *dc = DEVICE_CLASS(klass); *

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Gleb Natapov
On Wed, Feb 29, 2012 at 09:08:52AM +0800, Wen Congyang wrote: > At 02/28/2012 06:45 PM, Gleb Natapov Wrote: > > On Tue, Feb 28, 2012 at 11:19:47AM +0100, Jan Kiszka wrote: > >> On 2012-02-28 10:42, Wen Congyang wrote: > >>> At 02/28/2012 05:34 PM, Jan Kiszka Wrote: > On 2012-02-28 09:23, Wen C

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 03:29 AM, Wen Congyang wrote: > At 02/28/2012 07:23 PM, Avi Kivity Wrote: > > On 02/27/2012 05:01 AM, Wen Congyang wrote: > >> We can know the guest is paniced when the guest runs on xen. > >> But we do not have such feature on kvm. This patch implemnts > >> this feature, and the impl

Re: [Qemu-devel] [SeaBIOS] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-29 Thread Fred .
Modern operating systems does not use BIOS much. DOS use BIOS a lot. SeaBIOS is a BIOS, so should be able to run operating systems that use BIOS. So I think DOS is something that ought to run/work on SeaBIOS if SeaBIOS implements BIOS correctly. Shouldn't DOS be some milestone for SeaBIOS? Perhaps

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Gleb Natapov
On Wed, Feb 29, 2012 at 11:49:58AM +0200, Avi Kivity wrote: > On 02/29/2012 03:29 AM, Wen Congyang wrote: > > At 02/28/2012 07:23 PM, Avi Kivity Wrote: > > > On 02/27/2012 05:01 AM, Wen Congyang wrote: > > >> We can know the guest is paniced when the guest runs on xen. > > >> But we do not have suc

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 11:49:58AM +0200, Avi Kivity wrote: > On 02/29/2012 03:29 AM, Wen Congyang wrote: > > At 02/28/2012 07:23 PM, Avi Kivity Wrote: > > > On 02/27/2012 05:01 AM, Wen Congyang wrote: > > >> We can know the guest is paniced when the guest runs on xen. > > >> But we do not have suc

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 11:55 AM, Gleb Natapov wrote: > > > > > > > How about using a virtio-serial channel for this? You can transfer any > > amount of information (including the dump itself). > > > Isn't it unreliable after the guest panicked? So is calling hypercalls, or dumping, or writing to the sc

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 11:58 AM, Daniel P. Berrange wrote: > > > > How about using a virtio-serial channel for this? You can transfer any > > amount of information (including the dump itself). > > When the guest OS has crashed, any dumps will be done from the host > OS using libvirt's core dump mechanism.

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Gleb Natapov
On Wed, Feb 29, 2012 at 12:00:41PM +0200, Avi Kivity wrote: > On 02/29/2012 11:55 AM, Gleb Natapov wrote: > > > > > > > > > > How about using a virtio-serial channel for this? You can transfer any > > > amount of information (including the dump itself). > > > > > Isn't it unreliable after the gu

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:05 PM, Gleb Natapov wrote: > On Wed, Feb 29, 2012 at 12:00:41PM +0200, Avi Kivity wrote: > > On 02/29/2012 11:55 AM, Gleb Natapov wrote: > > > > > > > > > > > > > How about using a virtio-serial channel for this? You can transfer any > > > > amount of information (including the d

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote: > > What I did, to allow bisect, is rebase Avi's patches on top > of my bridge implementation, then run qemu with a bridge. > bridge without Avi's patches at least starts booting, with > Avi's patches crashes before guest start. > > If you want to p

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Wen Congyang
At 02/29/2012 05:36 PM, Gleb Natapov Wrote: > On Wed, Feb 29, 2012 at 09:08:52AM +0800, Wen Congyang wrote: >> At 02/28/2012 06:45 PM, Gleb Natapov Wrote: >>> On Tue, Feb 28, 2012 at 11:19:47AM +0100, Jan Kiszka wrote: On 2012-02-28 10:42, Wen Congyang wrote: > At 02/28/2012 05:34 PM, Jan

Re: [Qemu-devel] blockdev operations [was: KVM call agenda for Tuesday 28th]

2012-02-29 Thread Kevin Wolf
Am 28.02.2012 17:07, schrieb Eric Blake: > On 02/28/2012 07:58 AM, Stefan Hajnoczi wrote: >> On Tue, Feb 28, 2012 at 2:47 PM, Paolo Bonzini wrote: >>> Il 28/02/2012 15:39, Stefan Hajnoczi ha scritto: I'm not a fan of transactions or freeze/thaw (if used to atomically perform other comman

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Wen Congyang
At 02/29/2012 06:08 PM, Avi Kivity Wrote: > On 02/29/2012 12:05 PM, Gleb Natapov wrote: >> On Wed, Feb 29, 2012 at 12:00:41PM +0200, Avi Kivity wrote: >>> On 02/29/2012 11:55 AM, Gleb Natapov wrote: >> > > How about using a virtio-serial channel for this? You can transfer any > amo

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 12:05:32PM +0200, Avi Kivity wrote: > On 02/29/2012 11:58 AM, Daniel P. Berrange wrote: > > > > > > How about using a virtio-serial channel for this? You can transfer any > > > amount of information (including the dump itself). > > > > When the guest OS has crashed, any du

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Michael S. Tsirkin
On Wed, Feb 29, 2012 at 12:09:14PM +0200, Avi Kivity wrote: > On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote: > > > > What I did, to allow bisect, is rebase Avi's patches on top > > of my bridge implementation, then run qemu with a bridge. > > bridge without Avi's patches at least starts booting,

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Wen Congyang
At 02/29/2012 06:05 PM, Avi Kivity Wrote: > On 02/29/2012 11:58 AM, Daniel P. Berrange wrote: >>> >>> How about using a virtio-serial channel for this? You can transfer any >>> amount of information (including the dump itself). >> >> When the guest OS has crashed, any dumps will be done from the h

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:17 PM, Wen Congyang wrote: > >>> > >> Yes, crash can be so severe that it is not even detected by a kernel > >> itself, so not OOPS message even printed. But in most cases if kernel is > >> functional enough to print OOPS it is functional enough to call single > >> hypercall instru

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Gleb Natapov
On Wed, Feb 29, 2012 at 12:08:19PM +0200, Avi Kivity wrote: > On 02/29/2012 12:05 PM, Gleb Natapov wrote: > > On Wed, Feb 29, 2012 at 12:00:41PM +0200, Avi Kivity wrote: > > > On 02/29/2012 11:55 AM, Gleb Natapov wrote: > > > > > > > > > > > > > > > > How about using a virtio-serial channel for th

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:19 PM, Daniel P. Berrange wrote: > On Wed, Feb 29, 2012 at 12:05:32PM +0200, Avi Kivity wrote: > > On 02/29/2012 11:58 AM, Daniel P. Berrange wrote: > > > > > > > > How about using a virtio-serial channel for this? You can transfer any > > > > amount of information (including the

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:31 PM, Wen Congyang wrote: > At 02/29/2012 06:05 PM, Avi Kivity Wrote: > > On 02/29/2012 11:58 AM, Daniel P. Berrange wrote: > >>> > >>> How about using a virtio-serial channel for this? You can transfer any > >>> amount of information (including the dump itself). > >> > >> When t

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:44 PM, Gleb Natapov wrote: > > > > > > > Yes, crash can be so severe that it is not even detected by a kernel > > > itself, so not OOPS message even printed. But in most cases if kernel is > > > functional enough to print OOPS it is functional enough to call single > > > hypercall

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-29 Thread Gleb Natapov
On Wed, Feb 29, 2012 at 12:48:57PM +0200, Avi Kivity wrote: > On 02/29/2012 12:44 PM, Gleb Natapov wrote: > > > > > > > > > Yes, crash can be so severe that it is not even detected by a kernel > > > > itself, so not OOPS message even printed. But in most cases if kernel is > > > > functional enoug

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:23 PM, Michael S. Tsirkin wrote: > On Wed, Feb 29, 2012 at 12:09:14PM +0200, Avi Kivity wrote: > > On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote: > > > > > > What I did, to allow bisect, is rebase Avi's patches on top > > > of my bridge implementation, then run qemu with a bridg

Re: [Qemu-devel] QOM: why "klass" used instead of "class" ?

2012-02-29 Thread 陳韋任
On Wed, Feb 29, 2012 at 10:59:54AM +0400, Michael Tokarev wrote: > On 29.02.2012 09:52, Evgeny Voevodin wrote: > > include/qemu/object.h: > [] > > * void my_device_class_init(ObjectClass *klass, void *class_data) > > * { > > * DeviceClass *dc = DEVICE_CLASS(klass); > > * dc->reset = my_

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC] seabios: add OSHP method stub

2012-02-29 Thread Gerd Hoffmann
> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl > index 442e7a8..3f50169 100644 > --- a/src/ssdt-pcihp.dsl > +++ b/src/ssdt-pcihp.dsl > @@ -24,6 +24,7 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", > "BXSSDTPCIHP", 0x1) > ACPI_EXTRACT_METHOD_STRING aml_ej0_name

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Michael S. Tsirkin
On Wed, Feb 29, 2012 at 12:53:50PM +0200, Avi Kivity wrote: > On 02/29/2012 12:23 PM, Michael S. Tsirkin wrote: > > On Wed, Feb 29, 2012 at 12:09:14PM +0200, Avi Kivity wrote: > > > On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote: > > > > > > > > What I did, to allow bisect, is rebase Avi's patche

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Avi Kivity
On 02/29/2012 12:53 PM, Avi Kivity wrote: > I did get an abort with -enable-kvm, but that looks like the old issue, > no? Looking into it. > > -- error compiling committee.c: too many arguments to function >From 4fa865c7086e2f287c91f4372df6eb5ddf40a48c Mon Sep 17 00:00:00 2001 From: Avi Kivity

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Avi Kivity
On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote: > It does not crash under valgrind :) > But valgrid did show some info: > > ==9202== Invalid write of size 8 > ==9202==at 0x2F313D: portio_list_add_1 (ioport.c:379) > Anthony, your "bad bisect" was in fact good - it was the very first patch tha

[Qemu-devel] [PATCH 0/3] 64bit pci patches

2012-02-29 Thread Gerd Hoffmann
Hi, Three patches for 64bit pci bar support. First is a clean bugfix, second adds a address space hole for 64bit PCI ressources, third gives you something to play with. Gerd Hoffmann (3): i44fx: fix pci_hole64 parameter passing pc: add pci64 memory hole ivshmem: add 64bit option hw/ivs

[Qemu-devel] [PATCH 1/3] i44fx: fix pci_hole64 parameter passing

2012-02-29 Thread Gerd Hoffmann
--- hw/piix_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index e0268fe..c2a3671 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -350,7 +350,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn, b = i440fx

[Qemu-devel] [PATCH 2/3] pc: add pci64 memory hole

2012-02-29 Thread Gerd Hoffmann
This patch adds a address space hole for 64bit PCI ressources. It starts at 0x80 (512 GB) and ends at 0x100 (1 TB), thus has 512 GB in size. This matches what the experimental seabios patches[1] are using. [1] http://www.kraxel.org/cgit/seabios/commit/?h=pci64 Signed-off-by: Gerd

[Qemu-devel] [PATCH 3/3] ivshmem: add 64bit option

2012-02-29 Thread Gerd Hoffmann
This patch adds a "use64" property which will make the ivshmem driver register a 64bit memory bar when set, so you have something to play with when testing 64bit pci bits. It also allows to have quite big shared memory regions, like this: [root@fedora ~]# lspci -vs1:1 01:01.0 RAM memory: Red Hat,

[Qemu-devel] [PATCH v2 1/6] output: add 64bit hex print support

2012-02-29 Thread Gerd Hoffmann
--- src/output.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/output.c b/src/output.c index bdde7cc..32cbcaa 100644 --- a/src/output.c +++ b/src/output.c @@ -249,6 +249,7 @@ bvprintf(struct putcinfo *action, const char *fmt, va_list args)

[Qemu-devel] [PATCH v2 6/6] pci: add prefmem64

2012-02-29 Thread Gerd Hoffmann
This patch adds a prefmem64 region for 64bit pci prefmem bars which we'll go map above 4G. This will happen when either the device is on the root bus or it is behind a bridge supporting 64bit memory windows and all prefmem bars of all devices hooked up using that bridge are 64bit capable. --- src

[Qemu-devel] [PATCH v2 0/6] pci: 64bit support

2012-02-29 Thread Gerd Hoffmann
Hi, New revision of my 64bit pci patches. This is what I'm using to play with 64bit PCI bars (ivshmem + qxl devices) and bridge support (patches from mst). Changes in v2: * tried to reduce the stack footprint of 64bit hex number printing. * changed patch splitting to make them (hopefully)

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Avi Kivity
On 02/29/2012 01:31 PM, Avi Kivity wrote: > On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote: > > It does not crash under valgrind :) > > But valgrid did show some info: > > > > ==9202== Invalid write of size 8 > > ==9202==at 0x2F313D: portio_list_add_1 (ioport.c:379) > > > > Anthony, your "bad

Re: [Qemu-devel] [PATCH v5 0/2] Group Live Snapshots

2012-02-29 Thread Kevin Wolf
Am 28.02.2012 21:54, schrieb Jeff Cody: > This patchset adds the ability to take a snapshot of a group of devices, > rather than each device individually. Upon failure of any snapshot, all > snapshots taken by the command will be abandoned, and the appropriate failure > code returned. > > All the

[Qemu-devel] [Bug 943186] Re: kvm segfault after livemigration with tablet

2012-02-29 Thread Alexandre Derumier
forget the command line /usr/bin/kvm -chardev socket,id=monitor,path=/var/run/qemu- server/10345.mon,server,nowait -mon chardev=monitor,mode=readline -vnc unix:/var/run/qemu-server/10345.vnc,x509,password -pidfile /var/run /qemu-server/10345.pid -daemonize -usb -device usb- tablet,bus=usb.0,port=1

[Qemu-devel] [Bug 943186] [NEW] kvm segfault after livemigration with tablet

2012-02-29 Thread Alexandre Derumier
Public bug reported: Hi, i'm working on proxmox 2 distribution, we are using qemu-kvm-git. Users reports kvm segfault with some system guest, after live migration with usb tablet. original thread: http://forum.proxmox.com/threads/8455-2-0RC1-Live-Migration-VM-Crashes-after-a-few-minutes Guests

[Qemu-devel] [PATCH v2 5/6] pci: fix bridge ressource allocation.

2012-02-29 Thread Gerd Hoffmann
The patch changes the bridge ressource allocation: Unused memory windows are disabled: If none of the devices connected to the bridge has -- say -- I/O bars, then the I/O memory window is turned off. This implies that bridges without devices don't get any ressources assigned. The pci bridge spec

Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-29 Thread Jan Kiszka
On 2012-02-28 23:18, Stefan Weil wrote: > Am 17.02.2012 16:45, schrieb Jan Kiszka: >> In case we requeued a packet that was the head of a longer session >> queue, we failed to restore this ordering. Also, we did not properly >> deal with changes to Slirp::next_m. >> >> Instead of a cumbersome roll

[Qemu-devel] [PATCH v2 4/6] pci: bridges can have two regions too

2012-02-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/pciinit.c | 20 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index aa391a0..33b9bf7 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -402,7 +402,7 @@ static void pci_bios_check_devices(st

[Qemu-devel] [PATCH v2 3/6] pci: 64bit support.

2012-02-29 Thread Gerd Hoffmann
Makes pciinit.c 64bit aware. Use 64bit everywhere. Support discovery and configuration of 64bit bars, with non-zero upper32 bits. While being at it introduce a struct pci_bar which can be passed easily. Signed-off-by: Gerd Hoffmann --- src/pci.h | 14 -- src/pciinit.c | 126 +++

[Qemu-devel] [PATCH v2 2/6] pci: split device discovery into multiple steps

2012-02-29 Thread Gerd Hoffmann
First bridge init, next pci bar discovery, finally pci bar ressource allocation. Needed because we need to figure whenever we can map 64bit bars above 4G before doing ressource allocation. Signed-off-by: Gerd Hoffmann --- src/pciinit.c | 39 --- 1 files cha

[Qemu-devel] [PATCHv3] Add blkmirror block driver

2012-02-29 Thread Federico Simoncelli
Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti Signed-off-by: Federico Simoncelli --- Makefile.objs |2 +- block/blkmirror.c | 255 cutils.c | 30 ++ docs/blkmirror.txt | 15 +++ qemu-

Re: [Qemu-devel] [PATCHv3] Add blkmirror block driver

2012-02-29 Thread Federico Simoncelli
- Original Message - > From: "Federico Simoncelli" > To: qemu-devel@nongnu.org > Cc: mtosa...@redhat.com, kw...@redhat.com, pbonz...@redhat.com, > stefa...@gmail.com, "Federico Simoncelli" > > Sent: Wednesday, February 29, 2012 1:28:21 PM > Subject: [PATCHv3] Add blkmirror block driver >

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Martin Mailand
Hi Stefan, you are right, the performance for the commits 0b9b128530b and 4fefc55ab04d are both good. What is the best approach to stay in the qemu-kvm.git history? -martin On 29.02.2012 09:38, Stefan Hajnoczi wrote: I suggest testing both of the qemu-kvm.git merge commits, 0b9b128530b and 4f

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michal Privoznik
On 28.02.2012 18:41, Luiz Capitulino wrote: >> Hmm, I know Michal already sent a new version with my suggestions, but >> > you're right, splitting out the commands simplified both the responses, >> > and makes it easier to discover whether or not that information is >> > available, since you can lo

[Qemu-devel] [PATCH v2 2/3] qemu-iotests: add iotests Python module

2012-02-29 Thread Stefan Hajnoczi
Block layer tests that involve QMP commands rather than qemu-img or qemu-io are not well-suited for shell scripting. This patch adds a Python module which allows tests to be written in Python instead. The basic API is: VM - class for launching and interacting with a VM QMPTestCase -

[Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming tests

2012-02-29 Thread Stefan Hajnoczi
This series adds the image streaming test suite to qemu-iotests. It covers the 'block_stream', 'block_job_cancel', 'block_job_set_speed', and 'query-block-jobs' QMP interfaces. Since these tests involve QMP it is no longer convenient to write them in bash. Instead these tests are written in Pytho

[Qemu-devel] [PATCH v2 3/3] test: add image streaming tests

2012-02-29 Thread Stefan Hajnoczi
This patch adds a test suite for the image streaming feature. It exercises the 'block_stream', 'block_job_cancel', 'block_job_set_speed', and 'query-block-jobs' QMP commands. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/030 | 151 tests

[Qemu-devel] [PATCH v2 1/3] qemu-iotests: export TEST_DIR for non-bash tests

2012-02-29 Thread Stefan Hajnoczi
Since qemu-iotests may need to create large image files it is possible to specify the test directory. The TEST_DIR variable needs to be exported so non-bash tests can make use of it. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.config |2 ++ 1 files changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming tests

2012-02-29 Thread Kevin Wolf
Am 29.02.2012 14:25, schrieb Stefan Hajnoczi: > This series adds the image streaming test suite to qemu-iotests. It covers > the > 'block_stream', 'block_job_cancel', 'block_job_set_speed', and > 'query-block-jobs' QMP interfaces. > > Since these tests involve QMP it is no longer convenient to w

[Qemu-devel] [PATCH 1/6] fix format name for backing file

2012-02-29 Thread Paolo Bonzini
The new image's backing file is the existing image, so we need to take the format from there. Signed-off-by: Paolo Bonzini --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index d78aa51..96a893b 100644 --- a/blockdev.c +++ b/blockd

[Qemu-devel] [PATCH 5/6] Add blkmirror block driver

2012-02-29 Thread Paolo Bonzini
From: Marcelo Tosatti Mirrored writes are used by live block copy. The blkmirror driver is for internal use only, because it requires bdrv_append to set up a backing_hd for it. It relies on a quirk of bdrv_append, which leaves the old image open for writes. The source is hardcoded as the backi

[Qemu-devel] [PATCH 2/6] qapi: complete implementation of unions

2012-02-29 Thread Paolo Bonzini
Union types are very cool, but nobody bothered to implement the visitors so far. :) Fill the gap. Signed-off-by: Paolo Bonzini --- qapi-schema-test.json | 10 ++ scripts/qapi-types.py |5 + scripts/qapi-visit.py | 31 ++- test-qmp-inpu

[Qemu-devel] [PATCH 0/6] Mirrored writes using blockdev-transaction

2012-02-29 Thread Paolo Bonzini
This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series. Tested with the following scenarios: a) mirror only 1) create base.qcow2 and start QEMU with it 2) Execute the following QMP command

[Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync

2012-02-29 Thread Paolo Bonzini
We will add other kinds of operation. Prepare for this by adjusting the schema and renaming some types/variables. Signed-off-by: Paolo Bonzini --- blockdev.c | 73 + qapi-schema.json | 33 qmp-commands.hx |

[Qemu-devel] [PATCH 6/6] add mirroring to blockdev-transaction

2012-02-29 Thread Paolo Bonzini
Add a new transaction type, "mirror". It stacks a new blkmirror file (instead of a snapshot) on top of the existing image. It is possible to combine snapshot and mirror as two actions in the same transaction. Because of atomicity ensured by blockdev-transaction, this will create a snapshot *and*

[Qemu-devel] [PATCH 4/6] add reuse field

2012-02-29 Thread Paolo Bonzini
In some cases it can be useful to use an existing file as the new image in a snapshot. Add this capability to blockdev-transaction. Signed-off-by: Paolo Bonzini --- blockdev.c | 18 +++--- qapi-schema.json |3 ++- qmp-commands.hx |7 +++ 3 files changed, 20 inse

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:12 PM, Martin Mailand wrote: > Hi Stefan, > you are right, the performance for the commits 0b9b128530b and 4fefc55ab04d > are both good. > What is the best approach to stay in the qemu-kvm.git history? I didn't know the answer so I asked on #git on freenode: < charon> s

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:44 PM, Stefan Hajnoczi wrote: > On Wed, Feb 29, 2012 at 1:12 PM, Martin Mailand wrote: >> Hi Stefan, >> you are right, the performance for the commits 0b9b128530b and 4fefc55ab04d >> are both good. >> What is the best approach to stay in the qemu-kvm.git history? > > I d

[Qemu-devel] [PATCH] qemu-iotests: Filter out DOS line endings

2012-02-29 Thread Kevin Wolf
This one makes it possible to run qemu-iotests on a Windows build using Wine and get somewhat meaningful results. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.filter |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/common.filter b/test

[Qemu-devel] [PATCH] qemu-iotests: 026: Reduce output changes for cache=none qcow2

2012-02-29 Thread Kevin Wolf
qemu-iotests supports the -nocache option which makes the tests run with cache=none. For blkdebug tests with qcow2 this means that we may see test results that differ from cache=writethrough. This patch makes the diff a bit smaller and therefore easier to review. Signed-off-by: Kevin Wolf --- te

[Qemu-devel] [PATCH] qemu-iotests: Test rebase with short backing file

2012-02-29 Thread Kevin Wolf
This tests that qemu-img rebase doesn't assume that the backing file has the same size as the image, but considers that it can be smaller. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/028 |5 + tests/qemu-iotests/028.out |1 + 2 files changed, 6 insertions(+), 0 deletions(-)

[Qemu-devel] Broken screendump with unconnected vnc

2012-02-29 Thread Avi Kivity
qemu-system-x86_64 -monitor stdio -vnc :0 QEMU 1.0.50 monitor - type 'help' for more information (qemu) screendump /tmp/x.ppm display /tmp/x.ppm shows an empty screenshot. Breaks autotest for me. Connecting a vnc viewer works around the problem. -- error compiling committee.c: too many argumen

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-29 Thread Michael S. Tsirkin
On Wed, Feb 29, 2012 at 01:45:49PM +0200, Avi Kivity wrote: > On 02/29/2012 01:31 PM, Avi Kivity wrote: > > On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote: > > > It does not crash under valgrind :) > > > But valgrid did show some info: > > > > > > ==9202== Invalid write of size 8 > > > ==9202==

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out DOS line endings

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:59 PM, Kevin Wolf wrote: > This one makes it possible to run qemu-iotests on a Windows build using Wine > and get somewhat meaningful results. > > Signed-off-by: Kevin Wolf > --- >  tests/qemu-iotests/common.filter |    8 +++- >  1 files changed, 7 insertions(+), 1 d

Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync

2012-02-29 Thread Paolo Bonzini
Il 29/02/2012 14:37, Paolo Bonzini ha scritto: > +assert(!(dev_info->snapshot->has_format && format)); Oops, this wanted to be assert(dev_info->snapshot->has_format == (format != NULL)); but it can just be omitted, I wasn't sure of how QAPI handled optionals. Paolo

Re: [Qemu-devel] [PATCH v5 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-29 Thread Luiz Capitulino
On Tue, 28 Feb 2012 15:54:06 -0500 Jeff Cody wrote: > This is a QAPI/QMP only command to take a snapshot of a group of > devices. This is similar to the blockdev-snapshot-sync command, except > blockdev-group-snapshot-sync accepts a list devices, filenames, and > formats. > > It is attempted to

Re: [Qemu-devel] [PATCH v5 2/2] QMP: Add qmp command for blockdev-group-snapshot-sync

2012-02-29 Thread Luiz Capitulino
On Tue, 28 Feb 2012 15:54:07 -0500 Jeff Cody wrote: > This adds the QMP command for blockdev-group-snapshot-sync. It > takes an array in as the input, for the argument devlist. The > array consists of the following elements: > > + device:device to snapshot. e.g. "ide-hd0", "virtio0"

Re: [Qemu-devel] [PATCH 5/6] Add blkmirror block driver

2012-02-29 Thread Stefan Hajnoczi
On Wed, Feb 29, 2012 at 1:37 PM, Paolo Bonzini wrote: > From: Marcelo Tosatti > > Mirrored writes are used by live block copy. > > The blkmirror driver is for internal use only, because it requires > bdrv_append to set up a backing_hd for it.  It relies on a quirk > of bdrv_append, which leaves t

Re: [Qemu-devel] [PATCH v5 0/2] Group Live Snapshots

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 12:54:50 +0100 Kevin Wolf wrote: > Am 28.02.2012 21:54, schrieb Jeff Cody: > > This patchset adds the ability to take a snapshot of a group of devices, > > rather than each device individually. Upon failure of any snapshot, all > > snapshots taken by the command will be aband

Re: [Qemu-devel] [PATCH 3/4] monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE

2012-02-29 Thread Luiz Capitulino
On Tue, 28 Feb 2012 22:51:44 +0200 Alon Levy wrote: > On Tue, Feb 28, 2012 at 05:01:13PM -0300, Luiz Capitulino wrote: > > On Fri, 24 Feb 2012 23:22:04 +0200 > > Alon Levy wrote: > > > > > Signed-off-by: Alon Levy > > > --- > > > QMP/qmp-events.txt | 14 ++ > > > console.c

[Qemu-devel] [PATCH] qemu-tool: revert cpu_get_clock() abort(3)

2012-02-29 Thread Stefan Hajnoczi
Despite the fact that the qemu-tool environment has no guest running and vm_clock therefore does not make sense, there is code that gets the vm_clock time even in qemu-tool. Therefore, revert the abort(3) call and just return 0 like we used to. This unbreaks qemu-img/qemu-io with QED and Kevin ha

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 08:49:10 +0100 Gerd Hoffmann wrote: > Hi, > > >> There is a hang possible with the current screendump command, qxl, a > >> spice client using libvirt and spice-gtk such as virt-viewer / > >> remote-viewer, where you have: > >> 1. libvirt waiting for screendump to complete >

Re: [Qemu-devel] [PATCH 5/6] Add blkmirror block driver

2012-02-29 Thread Paolo Bonzini
Il 29/02/2012 15:37, Stefan Hajnoczi ha scritto: >> Makefile.objs |2 +- >> block/blkmirror.c | 153 >> >> docs/blkmirror.txt | 16 ++ >> 3 files changed, 170 insertions(+), 1 deletions(-) >> create mode 100644 block/blkmirror

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 10:15:53 +0200 Alon Levy wrote: > On Tue, Feb 28, 2012 at 05:10:39PM -0300, Luiz Capitulino wrote: > > On Sat, 25 Feb 2012 10:46:07 +0200 > > Alon Levy wrote: > > > > > On Fri, Feb 24, 2012 at 04:40:15PM -0600, Anthony Liguori wrote: > > > > On 02/24/2012 03:22 PM, Alon Levy

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 10:39:29 +0200 Alon Levy wrote: > On Tue, Feb 28, 2012 at 05:05:32PM -0300, Luiz Capitulino wrote: > > On Fri, 24 Feb 2012 23:22:05 +0200 > > Alon Levy wrote: > > > > > This is an across the board change since I wanted to keep the existing > > > (good imo) single graphic_con

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 14:17:52 +0100 Michal Privoznik wrote: > On 28.02.2012 18:41, Luiz Capitulino wrote: > >> Hmm, I know Michal already sent a new version with my suggestions, but > >> > you're right, splitting out the commands simplified both the responses, > >> > and makes it easier to discove

Re: [Qemu-devel] [PATCH 1/2] qemu-img: fix segment fault when the image format is qed

2012-02-29 Thread Kevin Wolf
Am 19.02.2012 15:24, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > [root@f15 qemu]# qemu-img info /home/zwu/work/misc/rh6.img > image: /home/zwu/work/misc/rh6.img > file format: qed > virtual size: 4.0G (4294967296 bytes) > disk size: 1.2G > cluster_size: 65536 > Segmentation fault (core

[Qemu-devel] How QEMU handle precise exception?

2012-02-29 Thread 陳韋任
Hi all, I would like to know how QEMU handle precise exception. Basically, QEMU need to maintain a well-defined guest architecture state (register + memory) before returning to the exception handler. For the guest register, does QEMU save the guest registers (except guest pc) before every gue

Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 15:25:29 +0100 Paolo Bonzini wrote: > Il 29/02/2012 14:37, Paolo Bonzini ha scritto: > > +assert(!(dev_info->snapshot->has_format && format)); > > Oops, this wanted to be > > assert(dev_info->snapshot->has_format == (format != NULL)); > > but it can just be omit

[Qemu-devel] [PATCH 04/27] fdc: handle read-only floppies (abort early on write commands)

2012-02-29 Thread Kevin Wolf
From: Hervé Poussineau A real floppy doesn't attempt to write to read-only media either. Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- hw/fdc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 9d1f5b3..3d4bb11 100644

[Qemu-devel] [PATCH 12/27] qcow2: Fix build with DEBUG_EXT enabled

2012-02-29 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3692b45..dea12c1 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -89,7 +89,6 @@ static int qcow2_read_extensions(BlockDriverState *bs, uint64

[Qemu-devel] [PATCH 25/27] qemu-tool: revert cpu_get_clock() abort(3)

2012-02-29 Thread Kevin Wolf
From: Stefan Hajnoczi Despite the fact that the qemu-tool environment has no guest running and vm_clock therefore does not make sense, there is code that gets the vm_clock time even in qemu-tool. Therefore, revert the abort(3) call and just return 0 like we used to. This unbreaks qemu-img/qemu-

[Qemu-devel] [PATCH 20/27] qemu-iotests: add iotests Python module

2012-02-29 Thread Kevin Wolf
From: Stefan Hajnoczi Block layer tests that involve QMP commands rather than qemu-img or qemu-io are not well-suited for shell scripting. This patch adds a Python module which allows tests to be written in Python instead. The basic API is: VM - class for launching and interacting w

[Qemu-devel] [PATCH 17/27] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-29 Thread Kevin Wolf
From: Jeff Cody This is a QAPI/QMP only command to take a snapshot of a group of devices. This is similar to the blockdev-snapshot-sync command, except blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to keep the snapshot of the group atomic; if the cr

Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync

2012-02-29 Thread Paolo Bonzini
Il 29/02/2012 16:08, Luiz Capitulino ha scritto: >> > >> > but it can just be omitted, I wasn't sure of how QAPI handled optionals. > Do you now? Perhaps not. :) > All optionals will be accompanied of a 'bool has_OPTIONAL_NAME', this bool > will be true if the optional has been passed by the cal

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michael Roth
On Wed, Feb 29, 2012 at 12:01:16PM -0300, Luiz Capitulino wrote: > On Wed, 29 Feb 2012 14:17:52 +0100 > Michal Privoznik wrote: > > > On 28.02.2012 18:41, Luiz Capitulino wrote: > > >> Hmm, I know Michal already sent a new version with my suggestions, but > > >> > you're right, splitting out the

[Qemu-devel] [PATCH 01/27] fdc: take side count into account

2012-02-29 Thread Kevin Wolf
From: Hervé Poussineau Floppies can be simple or double-sided. However, current code was only taking the common case into account (ie 2 sides). This repairs single-sided floppies, which where totally broken before this patch : for track > 0, wrong sector number was calculated, and data was read/

  1   2   3   >